Re: [PATCH 2/2] hid: input: add HID_QUIRK_REUSE_AXES and fix dragonrise

2016-09-26 Thread Nikolai Kondrashov
Hi Benjamin, On 09/26/2016 12:29 PM, Benjamin Tissoires wrote: Ideally, we need to have Dragon Rise 0x0011 tested too. Nick, would you mind checking it if you still have this particular device? I never had it, but perhaps Vladislav still has some. Vladislav, would you be able to test a change

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-19 Thread Nikolai Kondrashov
Hi Hanjun, On 2/19/21 10:54 AM, Hanjun Guo wrote: > In specific, we will start from the testing work, using HULK robot > (reports lots of bugs to mainline kernel) testing framework to test > compile, reboot, functional testing, and will extend to basic > performance regression testing in the futu

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-26 Thread Nikolai Kondrashov
Hi Hanjun, On 2/26/21 10:03 AM, Hanjun Guo wrote: > On 2021/2/19 22:45, Nikolai Kondrashov wrote: >> Would you be interested in working with the Linux Foundation KernelCI project >> on submitting your build and test results to the common database - KCIDB? > > Yes, we are wil

Re: Tests failed for linux.git:master

2020-08-05 Thread Nikolai Kondrashov
On 8/5/20 2:55 PM, staging.kernelci.org bot wrote: > REVISION > > Status > ✅ > Repo > URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > branch: master > Discovered > by: 4da9f3302615f4191814f826054846bf843e2

Re: ELAN Touchscreen regression in recent 3.12 rc's? (USB)

2013-10-30 Thread Nikolai Kondrashov
Hi AceLan, On 10/30/2013 03:41 AM, AceLan Kao wrote: It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks. % git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53

Re: [PATCH 0/2] HID: huion: add libinput support

2015-02-24 Thread Nikolai Kondrashov
On 02/24/2015 12:34 AM, Benjamin Tissoires wrote: On Feb 23 2015 or thereabouts, Peter Hutterer wrote: yeah, but the thing is: those emails are only necessary _once_ per tablet. if they're not in the database, you'll get those questions for the lifetime of the tablet :) Also note that libwacom

Re: [PATCH 0/2] HID: huion: add libinput support

2015-02-24 Thread Nikolai Kondrashov
On 02/24/2015 12:44 AM, Benjamin Tissoires wrote: On Feb 19 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/18/2015 10:04 PM, Benjamin Tissoires wrote: On Feb 18 2015 or thereabouts, Nikolai Kondrashov wrote: [snipped] OK, will respin the patches for your out of the tree driver

Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT for the third interface to not create more than needed input nodes. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-u

Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: We append "Pen", "Pad", "Mouse" or "Keyboard" suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. As I said before, this is a very welcome change. Thanks, Benja

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: From: Nikolai Kondrashov Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off-by: Benjamin Tissoires --- Changed from the original patch: - update Makefile, Kconfig

Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Based on a patch from: Nikolai Kondrashov Most of the tablets handled by hid-uclogic already uses MULTI_INPUT. *use Fot the ones which are not quirked in usbhid/hidquirks, they have a *For custom report descriptor which contains only

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 11:28 PM, Benjamin Tissoires wrote: On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Reviewed-by: Nikolai Kondrashov Could I have your Signed-off-by here, it's mainly your patch, and so I kept your From. Sure: S

Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 11:36 PM, Benjamin Tissoires wrote: On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: We append "Pen", "Pad", "Mouse" or "Keyboard" suffix to the appropriate input node to matc

Re: [PATCH] HID: uclogic: make input_mapping independent of usb

2015-03-14 Thread Nikolai Kondrashov
On 03/13/2015 05:42 PM, Benjamin Tissoires wrote: No need to retrieve the USB handle in input_mapping() when we already do that in probe. It also allows to use the quirk without having to add the product ID matching. Signed-off-by: Benjamin Tissoires --- Nick, no need to cc DIGImend-devel whe

Re: [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Nikolai Kondrashov
On 03/03/2015 12:25 AM, Benjamin Tissoires wrote: On Feb 28 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now

Re: [PATCH v3 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Nikolai Kondrashov
0x07 It would be nice to also use this macro in the replaced report descriptor itself, but this will do for now. Reviewed-by: Nikolai Kondrashov Thanks a lot, Benjamin! Nick P.S. I like the way you describe the changes between patchset versions, will have to keep it in mind and use in m

Re: [PATCH] HID: Kconfig: add USB_HID dependency to UC-LOGIC

2015-03-04 Thread Nikolai Kondrashov
On 03/04/2015 06:24 PM, Benjamin Tissoires wrote: In commit 08177f4 (HID: uclogic: merge hid-huion driver in hid-uclogic) HID_HUION depends explicitely on USB_HID because it contained quite some USB-isms. Now that hid-uclogic is the new home of Huion tablets, we need to also add the dependency o

Re: [PATCH 1/2] HID: huion: enable button mode reporting

2015-02-19 Thread Nikolai Kondrashov
On 02/18/2015 10:24 PM, Benjamin Tissoires wrote: On Feb 18 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: diff --git a/drivers/hid/hid-huion.c b/drivers/hid/hid-huion.c index 61b68ca..50fbda4 100644 --- a/drivers/hid/hid-huion.c +++ b/drivers

Re: [PATCH 0/2] HID: huion: add libinput support

2015-02-19 Thread Nikolai Kondrashov
On 02/18/2015 10:04 PM, Benjamin Tissoires wrote: On Feb 18 2015 or thereabouts, Nikolai Kondrashov wrote: Hi Benjamin, I'm copying my reply to DIGImend-devel as well. On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: Hi Nikolai, I know you are actually merging hid-huion and hid-uclogi

Re: [PATCH 0/2] HID: huion: add libinput support

2015-02-22 Thread Nikolai Kondrashov
On 02/20/2015 07:34 AM, Peter Hutterer wrote: On Thu, Feb 19, 2015 at 01:54:17PM +0200, Nikolai Kondrashov wrote: [...] Last, I think we could add these tablets in the libwacom project, so that there will be a nice GUI to configure the buttons. That would be a very welcome change, without

Re: [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-02-28 Thread Nikolai Kondrashov
On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now, but it's better to check for the product id sooner than discovering that we have messed up one tablet later. Si

Re: [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool

2015-03-01 Thread Nikolai Kondrashov
he user to know which one is which. Signed-off-by: Benjamin Tissoires I read the kernel code and tested this a little. This looks and works fine. Reviewed-by: Nikolai Kondrashov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT

2015-03-01 Thread Nikolai Kondrashov
_INPUT; /* Allocate and assign driver data */ drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL); This seems safe and fine as a preventive. Reviewed-by: Nikolai Kondrashov Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets

2015-03-01 Thread Nikolai Kondrashov
On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: Some Huion tablets present 2 HID Pen interfaces. Only one is used, so we can drop the unused one. Signed-off-by: Benjamin Tissoires This is what might have been plaguing GIMP users. Thanks, Benjamin! Reviewed-by: Nikolai Kondrashov Nick

Re: [PATCH 0/2] HID: huion: add libinput support

2015-02-18 Thread Nikolai Kondrashov
Hi Benjamin, I'm copying my reply to DIGImend-devel as well. On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: Hi Nikolai, I know you are actually merging hid-huion and hid-uclogic, so we might not want to take this in this current state. We may need to postpone it when you have send the merge

Re: [PATCH 1/2] HID: huion: enable button mode reporting

2015-02-18 Thread Nikolai Kondrashov
On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: diff --git a/drivers/hid/hid-huion.c b/drivers/hid/hid-huion.c index 61b68ca..50fbda4 100644 --- a/drivers/hid/hid-huion.c +++ b/drivers/hid/hid-huion.c @@ -34,6 +34,9 @@ enum huion_ph_id { HUION_PH_ID_NUM }; +/* header of a button repo

Re: [PATCH 2/2] HID: huion: split the stylus and pad in 2 nodes

2015-02-18 Thread Nikolai Kondrashov
On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: Libinput expects the pad node to be different from the stylus one. We can just use HID_QUIRK_MULTI_INPUT to separate the buttons of the pad than the actual stylus. We can also remove the unused interfaces. Last, we append "Pen" or "Pad" suffix to

Re: [PATCH 1/2] HID: huion: enable button mode reporting

2015-02-18 Thread Nikolai Kondrashov
On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: @@ -81,6 +84,31 @@ static const __u8 huion_tablet_rdesc_template[] = { HUION_PH(PRESSURE_LM), /* Logical Maximum (PLACEHOLDER), */ 0x81, 0x02, /* Input (Variable), */ 0xC0,

Re: [PATCH] HID: hid-input: allow input_configured callback return errors

2015-09-26 Thread Nikolai Kondrashov
On 09/26/2015 02:14 AM, Dmitry Torokhov wrote: When configuring input device via input_configured callback we may encounter errors (for example input_mt_init_slots() may fail). Instead of continuing with half-initialized input device let's allow driver indicate failures. diff --git a/drivers/hid