Re: [PATCH] media: v4l: async: fix return of unitialized variable ret

2017-11-03 Thread Niklas Söderlund
dia: v4l: async: Fix notifier complete callback error > handling") > Signed-off-by: Colin Ian King Reviewed-by: Niklas Söderlund > --- > drivers/media/v4l2-core/v4l2-async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c >

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
frame or field. And if it should represent the frame height then v4l2_fill_pix_format() and v4l2_fill_mbus_format() should be updated to support converting from the two different formats for height. > > > * @code: data format code (from enum v4l2_mbus_pixelcode) > > * @field: used interlacing type (from enum v4l2_field) > > * @colorspace:colorspace of the data (from enum v4l2_colorspace) > > -- > Regards, > > Sakari Ailus > e-mail: sakari.ai...@iki.fi -- Regards, Niklas Söderlund

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > > Hi, > > > > Thanks for your patch. > > > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > >> Hi Kieran, > >> > >> On Mon, Jan 0

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Niklas Söderlund
fmt->field = hdmi->timings.bt.interlaced ? V4L2_FIELD_ALTERNATE : V4L2_FIELD_NONE; So I leave this up to you and feel free to add in either case. Reviewed-by: Niklas Söderlund > + fmt->height /= 2; > } > > static void adv748x_fill_optional_dv_timings(struct v4l2_dv_timings *timings) > -- > 2.7.4 > -- Regards, Niklas Söderlund

Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
; > Clarify this using the same text as is provided for the v4l2_pix_format > which is explicit on the matter, and by matching the terminology of > 'image height' rather than the misleading 'frame height'. > > Signed-off-by: Kieran Bingham Reviewed-by: Niklas S

Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
.org/pub/scm/linux/kernel/git/davem/net")) 2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle") -- Regards, Niklas Söderlund

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
Hi Vincent, Thanks for your feedback. On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote: > Hi Niklas, > > On 12 April 2018 at 11:18, Niklas Söderlund > wrote: > > Hi Vincent, > > > > I have observed issues running on linus/master from a few days back [1]. > &

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
I'm using arch/arm/configs/shmobile_defconfig for my tests. -- Regards, Niklas Söderlund

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
.7.4 > > > Thanks, > Vincent > > > > > > > > > > Regards, > > > Vincent > > > > > > > > 1. c18bb396d3d261eb ("Merge > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")) > > > > 2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle") > > > > > > > > -- > > > > Regards, > > > > Niklas Söderlund > > > > -- > > Regards, > > Niklas Söderlund -- Regards, Niklas Söderlund

Re: [PATCH] clk: renesas: rcar-gen2: Centralize quirks handling

2018-04-10 Thread Niklas Söderlund
> Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > To be queued in clk-renesas-for-v4.18. > > drivers/clk/renesas/rcar-gen2-cpg.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/renesas/r

Re: [PATCH 2/3] thermal: rcar_thermal: Prevent doing work after unbind

2018-09-28 Thread Niklas Söderlund
cancel_delayed_work_sync(&priv->work); > if (priv->chip->use_of_thermal) > thermal_remove_hwmon_sysfs(priv->zone); > else > -- > 2.17.1 > -- Regards, Niklas Söderlund

Re: [PATCH 1/3] dt-bindings: media: rcar-vin: Add R8A77995 support

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:00 +0200, Jacopo Mondi wrote: > Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by > rcar-vin driver. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- > Documentation/devicet

Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++ >

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-13 Thread Niklas Söderlund
Niklas, > > As you reviewed the rest of the series I'm wondering if you're planning > to review this patch too. Yes, I did not have schematics for D3 on hand when reviewing the rest of the series. Will review it now that I do, thanks for the ping :-) -- Regards, Niklas Söderlund

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-13 Thread Niklas Söderlund
eal as the VIN driver don't use these properties so no functional change should come of this but still a difference. Over all I'm happy with this change but before I add my tag I would like to understand why it differs from the Gen2 configuration for the adv7612 properties. Also on a side not it is possible with hardware switches on the board switch the VIN4 source to a completely different pipeline CVBS connector -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as this seems to be how the boards are shipped. But maybe mentioning this in the commit message would not hurt if you end-up resending the patch. > + > + remote-endpoint = <&adv7612_out>; > + }; > + }; > + }; > +}; > -- > 2.7.4 > -- Regards, Niklas Söderlund

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-14 Thread Niklas Söderlund
remote subdevice is not looking at its remote endpoint for bus parameters not considered by the rcar-vin driver? The thing is that the rcar-vin driver only looks at the remote endpoint for these properties and ignores the on its local endpoint. Maybe some v4l2 framework change is needed here to make sure the bus properties are the same on both endpoints of a link. But I fear such a change would break a lot of stuff. -- Regards, Niklas Söderlund

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-14 Thread Niklas Söderlund
Hi again, On 2018-05-14 11:49:00 +0200, Niklas Söderlund wrote: > Hi Laurent, > > On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote: > > [snip] > > > > > +&vin4 { > > > > + pinctrl-0 = <&vin4_pins>; > > > > +

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-14 Thread Niklas Söderlund
Hi Jacopo, On 2018-05-14 09:39:34 +0200, Jacopo Mondi wrote: > Hi Niklas, > > On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your patch. > > > > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: >

Re: [PATCH] media: dt-bindings: rcar-csi2: Add r8a774c0

2018-12-17 Thread Niklas Söderlund
Hi Fabrizio, Thanks for your work. On 2018-12-13 20:21:49 +, Fabrizio Castro wrote: > Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the > list of supported SoCs. > > Signed-off-by: Fabrizio Castro Reviewed-by: Niklas Söderlund > --- > Documentation/devicet

Re: [PATCH] media: rcar-vin: Add support for RZ/G2E

2018-12-17 Thread Niklas Söderlund
.compatible = "renesas,vin-r8a774c0", > + .data = &rcar_info_r8a77990, > + }, > + { > .compatible = "renesas,vin-r8a7778", > .data = &rcar_info_m1, > }, > -- > 2.7.4 > -- Regards, Niklas Söderlund

Re: [PATCH] media: dt-bindings: rcar-vin: Add R8A774C0 support

2018-12-17 Thread Niklas Söderlund
Hi Fabrizio, Thanks for your patch. On 2018-12-13 20:21:59 +, Fabrizio Castro wrote: > Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list > of SoCs supported by rcar-vin driver. > > Signed-off-by: Fabrizio Castro Reviewed-by: Niklas Söderlund > --- &

Re: [PATCH] media: rcar-csi2: Add support for RZ/G2E

2018-12-17 Thread Niklas Söderlund
Hi Fabrizio, Thanks. On 2018-12-13 20:24:12 +, Fabrizio Castro wrote: > According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 CSI-2 > blocks are identical, therefore use R-Car E3 definitions to add > RZ/G2E support. > > Signed-off-by: Fabrizio Castro Reviewed-

Re: [RFC PATCH] media: rcar-vin: Allow independent VIN link enablement

2018-12-26 Thread Niklas Söderlund
nk->sink->entity)) > return 0; > > - /* If any entity is in use don't allow link changes. */ > - media_device_for_each_entity(entity, &group->mdev) > - if (entity->use_count) > - return -EBUSY; > - > mutex_lock(&group->lock); > > /* Find the master VIN that controls the routes. */ > -- > 2.17.1 > -- Regards, Niklas Söderlund

Re: [PATCH v2 2/4] sh-pfc: Add emev2 pinmux support

2015-01-25 Thread Niklas Söderlund
gt; Hi Niklas, > > Thank you for the patch. > > I see that you've quickly taken my remarks into account, great work. Please > see below for a couple more comments. > > On Sunday 18 January 2015 13:20:02 Niklas Söderlund wrote: > > Add PFC support for the EMMA Mobile

[PATCH v3] sh-pfc: Add emev2 pinmux support

2015-01-25 Thread Niklas Söderlund
Add PFC support for the EMMA Mobile EV2 SoC including pin groups for on-chip devices. Signed-off-by: Niklas Söderlund --- .../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 + drivers/pinctrl/sh-pfc/Kconfig |5 + drivers/pinctrl/sh-pfc/Makefile

Re: [PATCH 0/4] sh-pfc: Add emev2 pinmux support

2015-01-09 Thread Niklas Söderlund
Hi Linus and Laurent, I know we are coming out of the holiday season so here is a humble ping on this patchset. * Niklas Söderlund [2014-12-12 21:01:33 +0100]: > Greetings, > > This patchset introduces pinmux support for the EMMA Mobile EV2 board to > the sh-pfc pin-contr

Re: [PATCH 2/4] sh-pfc: Add emev2 pinmux support

2015-01-17 Thread Niklas Söderlund
Hi Laurent, Thanks for your review. I will send a updated patch shortly. Regards // Niklas * Laurent Pinchart [2015-01-13 16:27:06 +0200]: > Hi Niklas, > > Thank you for the patch. > > On Friday 12 December 2014 21:01:35 Niklas Söderlund wrote: > > Add PFC support for th

[PATCH v2 0/4] Add emev2 pinmux support

2015-01-18 Thread Niklas Söderlund
bank_number schema * Group pins in larger groups instead of one group per pin * Only define the actual 159 GPIOs instead of 160 * There are 23 pins per row not 25, correct PIN_NUMBER macro * Define one larger reg entry in dts for pfc instead of four small Niklas Söderlund (4): sh-pfc: add macro to

[PATCH v2 4/4] ARM: shmobile: emev2-kzm9d: Add PFC information for uart1

2015-01-18 Thread Niklas Söderlund
Configure the pinmux on kzm9d to use the serial connector for uart1. Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/emev2-kzm9d.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts index 667d323

[PATCH v2 2/4] sh-pfc: Add emev2 pinmux support

2015-01-18 Thread Niklas Söderlund
Add PFC support for the EMMA Mobile EV2 SoC including pin groups for on-chip devices. Signed-off-by: Niklas Söderlund --- .../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 + drivers/pinctrl/sh-pfc/Kconfig |5 + drivers/pinctrl/sh-pfc/Makefile

[PATCH v2 3/4] ARM: shmobile: emev2: Add PFC information to emev2.dtsi

2015-01-18 Thread Niklas Söderlund
With this information all GPIOs can make use of the PFC functionality. Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/emev2.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/emev2.dtsi b/arch/arm/boot/dts/emev2.dtsi index cc7bfe0..bb45694 100644 --- a

[PATCH v2 1/4] sh-pfc: add macro to define pinmux without function

2015-01-18 Thread Niklas Söderlund
Used to define pinmux configurations where the pinmux function have no representation in the configuration registers but instead solely depends on a group selection. Signed-off-by: Niklas Söderlund --- drivers/pinctrl/sh-pfc/sh_pfc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

Re: [PATCH v2 1/3] media: i2c: adv748x: Simplify regmap configuration

2018-03-01 Thread Niklas Söderlund
epresented on a single line. > > Define ADV748X_REGMAP_CONF for this purpose use it to create the tables. > > Signed-off-by: Kieran Bingham Reviewed-by: Niklas Söderlund > > --- > v2: > - Remove unnecessary #undef > > drivers/media/i2c/adv748x/adv748x-core.c | 109

Re: [PATCH v2 3/3] media: i2c: adv748x: Add support for i2c_new_secondary_device

2018-03-01 Thread Niklas Söderlund
bus. > > Allow a device tree node to override the default addresses so that > address conflicts with other devices on the same bus may be resolved at > the board description level. > > Signed-off-by: Kieran Bingham Reviewed-by: Niklas Söderlund > --- > driver

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-26 Thread Niklas Söderlund
Hi Vincent, Thanks for all your help. On 2018-04-26 12:31:33 +0200, Vincent Guittot wrote: > Hi Niklas, > > Le Thursday 26 Apr 2018 à 00:56:03 (+0200), Niklas Söderlund a écrit : > > Hi Vincent, > > > > Here are the result, sorry for the delay. > > > >

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-26 Thread Niklas Söderlund
of > >> c18bb396d3d261eb ("Merge > >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") > > > > I can confirm that with the patch bellow I can no longer produce the > > problem. Thanks! > > Thanks for testing > Do you mind if I add >

Re: [PATCH v2 2/3] arm64: dts: renesas: draak: Describe CVBS input

2018-05-16 Thread Niklas Söderlund
ard switches SW-53 and SW-54 with CVBS input selected > by the default switches configuration. You are missing your SoB line :-) Reviewed-by: Niklas Söderlund > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 36 > ++ > 1 file changed, 36 insert

Re: [PATCH v2 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-16 Thread Niklas Söderlund
ave a policy about describing hardware which can't be used without flipping switches. I have no opinion on if we should do that or not I leave that to others, but for the change itself. Reviewed-by: Niklas Söderlund I think it's good we describe it as it's part of the Draak b

Re: media: rcar-vin: add group allocator functions

2018-04-24 Thread Niklas Söderlund
Hi there, > > While running static analysis on linux-next today a null pointer > dereference issue was detected by CoverityScan. The following commit > introduced the issue: > > commit 3bb4c3bc85bf77a76c921671800bde2e1bf82a88 > Author: Niklas Söderlund > Date:

Re: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

2019-04-23 Thread Niklas Söderlund
ers/thermal/rcar_gen3_thermal.c | 41 +++-- > 1 file changed, 9 insertions(+), 32 deletions(-) > > -- > 2.19.2 > -- Regards, Niklas Söderlund

Re: [RESEND PATCH] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register

2019-03-27 Thread Niklas Söderlund
le for H3ES1.*, according > to Hardware manual values 1 are "setting prohibited" for Gen3. > > Signed-off-by: Hoan Nguyen An Reviewed-by: Niklas Söderlund > --- > drivers/thermal/rcar_gen3_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH v2] timekeeping: Allow runtime PM from change_clocksource()

2021-02-11 Thread Niklas Söderlund
a2c5e6 ("clocksource: add enable() and disable() callbacks") Signed-off-by: Niklas Söderlund --- kernel/time/timekeeping.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 6ae

Re: [PATCH] dt-bindings: timer: Add renesas,em-sti bindings

2020-05-19 Thread Niklas Söderlund
Hi Geert, Thanks for your work. On 2020-05-19 10:11:01 +0200, Geert Uytterhoeven wrote: > Document Device Tree bindings for the Renesas EMMA Mobile System Timer. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > .../bindings/timer/renesas,em-sti.y

Re: [PATCH 20/20] arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes

2020-08-07 Thread Niklas Söderlund
andle the warning I'm not sure. I can only really see 2 options. 1. Ignore the warning. 2. Remove #address-cells, #size-cells and reg properties from port@ if the only endpoint described is endpoint@0. I would prefers option 2. that is what we do in other cases (for example on Gen2 boards that only have a single parallel sensor in some early DTS files we don't have the ports node and just describe a single port with the same reasoning. We are not at risk at someone describing a second CSI-2 bock as an overlay so I see no real harm in option 2. What are your thoughts Geert? You know more about DT then me. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds -- Regards, Niklas Söderlund

Re: [PATCH 20/20] arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes

2020-08-08 Thread Niklas Söderlund
Hi Geert and Lad, On 2020-08-07 13:36:46 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Aug 7, 2020 at 1:27 PM Niklas Söderlund > wrote: > > On 2020-08-06 13:47:58 +0200, Geert Uytterhoeven wrote: > > > On Thu, Aug 6, 2020 at 1:17 PM Lad, Prabhakar > >

Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Niklas Söderlund
hile at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as > there is no reason to do a synchronous power down. > > Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid > context") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund

Re: [PATCH] clocksource/drivers/sh_cmt: Make sure channel clock supply is enabled

2020-12-27 Thread Niklas Söderlund
dependency on implicit reset and/or > boot loader state, and by enabling the clock supply explicitly for all > channels used instead. This requires postponing the clk_disable() call, > else the timer's registers cannot be accessed in sh_cmt_setup_channel(). > > Signed-off-by: Geert

[PATCH] media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer

2021-04-13 Thread Niklas Söderlund
t; devices using the MAX96712 as a video source there are a lot of features missing. Most notably the ability to operate the GMSL bus. Signed-off-by: Niklas Söderlund --- MAINTAINERS | 6 + drivers/staging/media/Kconfig | 2 + drivers/staging/medi

Re: [PATCH 4/5] thermal/drivers/rcar: Remove notification usage

2020-12-10 Thread Niklas Söderlund
by: Daniel Lezcano Reviewed-by: Niklas Söderlund > --- > drivers/thermal/rcar_thermal.c | 19 --- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 6ae757d66f46..b49f04daaf47 100644 &g

Re: [PATCH][next] media: rcar-vin: fix return, use ret instead of zero

2020-12-04 Thread Niklas Söderlund
urned. Fix this. > > Addresses-Coverity: ("Unused value") > Fixes: b9ad52aafe38 ("media: rcar-vin: Rework parallel firmware parsing") > Signed-off-by: Colin Ian King Reviewed-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-core.c | 2 +- >

[PATCH 0/2] timekeeping: Fix change_clocksource() for PM and sh_cmt

2020-12-04 Thread Niklas Söderlund
anosleep CLOCK_REALTIME_ALARM[UNSUPPORTED] Nanosleep CLOCK_BOOTTIME_ALARM[UNSUPPORTED] Nanosleep CLOCK_TAI [OK] # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 Niklas Söderlund (2): clocksource

[PATCH 2/2] timekeeping: Allow runtime PM from change_clocksource()

2020-12-04 Thread Niklas Söderlund
a2c5e6 ("clocksource: add enable() and disable() callbacks") Signed-off-by: Niklas Söderlund --- kernel/time/timekeeping.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 685

[PATCH 1/2] clocksource/drivers/sh_cmt: Fix potential deadlock when calling runtime PM

2020-12-04 Thread Niklas Söderlund
154 [ 47.682308] smpboot_thread_fn+0x244/0x270 [ 47.690560] kthread+0x154/0x160 [ 47.697927] ret_from_fork+0x10/0x20 [ 47.708447] clocksource: Switched to clocksource e60f.timer Signed-off-by: Niklas Söderlund --- drivers/clocksource/sh_cmt.c | 18 ++ 1 file c

Re: [PATCH v2] dt-bindings: timer: renesas,cmt: add r8a779a0 CMT support

2021-03-11 Thread Niklas Söderlund
Hi Wolfram, Thanks for your patch. On 2021-03-11 10:09:18 +0100, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Reviewed-by: Niklas Söderlund > --- > > Changes since V1: > * none, but additional testing was done which revealed that this CMT > in deed behaves the same

Re: [PATCH] dt-bindings: timer: renesas,tmu: add r8a779a0 TMU support

2021-03-06 Thread Niklas Söderlund
Hi Wolfram, Thanks for your work. On 2021-03-05 15:23:59 +0100, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Reviewed-by: Niklas Söderlund > --- > > This is the correct one. TMU passed the testsuite, CMT needs a second > look. > > Documentation/devicetree/b

Re: [PATCH] clocksource: sh_cmt: use CMTOUT_IE only when supported

2021-03-08 Thread Niklas Söderlund
Hi Wolfram, Thanks for your patch. On 2021-03-05 14:28:59 +0100, Wolfram Sang wrote: > CMTOUT_IE is only supported for older SoCs. Newer SoCs shall not set > this bit. So, add a version check. > > Reported-by: Phong Hoang > Signed-off-by: Wolfram Sang Reviewed-by: N

[PATCH 2/2] iommu/io-pgtable-arm: use __dma_sync_single_for_device()

2016-05-08 Thread Niklas Söderlund
and a warning is printed. Avoid this warning by calling __dma_sync_single_for_device() which don't preform this check. Signed-off-by: Niklas Söderlund --- drivers/iommu/io-pgtable-arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/dr

[PATCH 1/2] dma-mapping: add __dma_sync_single_for_device()

2016-05-08 Thread Niklas Söderlund
() so the new mapping can't be found and are believed to be invalid. Add __dma_sync_single_for_device() that don't call into debug_dma_sync_single_for_device() and can be used in these situations. Signed-off-by: Niklas Söderlund --- include/linux/dma-mapping.h | 9 - 1 file

[PATCH 0/2] Fix incorrect warning from dma-debug

2016-05-08 Thread Niklas Söderlund
from [] (kernel_init+0x10/0x118) r9:[1.879529] ata1: link resume succeeded after 1 retries r8: r7: r6: r5:c071066c r4: [] (kernel_init) from [] (ret_from_fork+0x14/0x2c) r5:c071066c r4: ---[ end trace 6eb9a3df3009d491 ]--- Niklas Söderlund (2):

[PATCHv6 8/8] ARM: dts: r8a7791: add iommus to dmac0 and dmac1

2016-05-09 Thread Niklas Söderlund
A unconfirmed hardware bug prevents channel 0 and 15 to be used by the DMAC together with the IPMMU. The DMAC driver will disable the channels reducing the effective number of channels to 14 per DMAC. Signed-off-by: Niklas Söderlund Acked-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7791.dtsi

[PATCHv6 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

2016-05-09 Thread Niklas Söderlund
A unconfirmed hardware bug prevents channel 0 and 15 to be used by the DMAC together with the IPMMU. The DMAC driver will disable the channels reducing the effective number of channels to 14 per DMAC. Signed-off-by: Niklas Söderlund Acked-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7790.dtsi

[PATCHv6 0/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-05-09 Thread Niklas Söderlund
on some configurations. - Add DT information for r8a7791. * Changes since RFC - Switch to use the dma-mapping api instead of using the iommu_map() directly. Turns out the dma-mapper is much smarter then me... - Dropped the patch to expose domain->ops->pgsize_bitmap from within the iommu

[PATCHv6 3/8] dma-mapping: add dma_{map,unmap}_resource

2016-05-09 Thread Niklas Söderlund
Map/Unmap a device MMIO resource from a physical address. If no dma_map_ops method is available the operation is a no-op. Signed-off-by: Niklas Söderlund --- Documentation/DMA-API.txt | 22 +- include/linux/dma-mapping.h | 36 2 files

[PATCHv6 4/8] arm: dma-mapping: add {map,unmap}_resource for iommu ops

2016-05-09 Thread Niklas Söderlund
Add methods to map/unmap device resources addresses for dma_map_ops that are IOMMU aware. This is needed to map a device MMIO register from a physical address. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- arch/arm/mm/dma-mapping.c | 63

[PATCHv6 5/8] dmaengine: rcar-dmac: group slave configuration

2016-05-09 Thread Niklas Söderlund
Group slave address and transfer size in own structs for source and destination. This is in preparation for hooking up the dma-mapping API to the slave addresses. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- drivers/dma/sh/rcar-dmac.c | 38

[PATCHv6 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-05-09 Thread Niklas Söderlund
Enable slave transfers to a device behind a IPMMU by mapping the slave addresses using the dma-mapping API. Signed-off-by: Niklas Söderlund --- drivers/dma/sh/rcar-dmac.c | 82 +- 1 file changed, 74 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCHv6 1/8] dma-mapping: add {map,unmap}_resource to dma_map_ops

2016-05-09 Thread Niklas Söderlund
Add methods to handle mapping of device resources from a physical address. This is needed for example to be able to map MMIO FIFO registers to a IOMMU. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- include/linux/dma-mapping.h | 6 ++ 1 file changed, 6 insertions

[PATCHv6 2/8] dma-debug: add support for resource mappings

2016-05-09 Thread Niklas Söderlund
A MMIO mapped resource can not be represented by a struct page so a new debug type is needed to handle this. This patch add such type and functionality to add/remove entries and how to translate them to a physical address. Signed-off-by: Niklas Söderlund --- include/linux/dma-debug.h | 19

[PATCH] dmaengine: of_dma: approximate an average distribution

2016-05-11 Thread Niklas Söderlund
: i2c@e60b { ... dmas = <&dmac0 0x77>, <&dmac0 0x78>, <&dmac1 0x77>, <&dmac1 0x78>; dma-names = "tx", "rx", "tx", "rx"; ... }; Signed-off-by

Re: [PATCH] dmaengine: of_dma: approximate an average distribution

2016-05-11 Thread Niklas Söderlund
In my haste I forgot the most important part of this patch, I'm sorry Arnd. Suggested-by: Arnd Bergmann On 2016-05-11 15:15:11 +0200, Niklas Söderlund wrote: > Currently the following DT description would result in dmac0 always > being tried first and dmac1 second if dmac0 was

Re: [PATCHv6 2/8] dma-debug: add support for resource mappings

2016-05-19 Thread Niklas Söderlund
gt; > > > + entry->size = size; > > + entry->dev_addr = dma_addr; > > + entry->direction = direction; > > + entry->map_err_type = MAP_ERR_NOT_CHECKED; > > + > > + add_dma_entry(entry); > > +} > > +EXPORT_SYMBOL(debug_dma_map_resource); > > + -- Regards, Niklas Söderlund

Re: [PATCHv6 3/8] dma-mapping: add dma_{map,unmap}_resource

2016-05-19 Thread Niklas Söderlund
ce() (which is added in this patch) as one of the calls which return dma_addr_t should be checked for error using dma_mapping_error(). But yes the change effect all lines in the paragraph due to line wrapping. Hum or maybe I'm misunderstanding your question. -- Regards, Niklas Söderlund

[PATCH v4 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

2016-02-16 Thread Niklas Söderlund
A unconfirmed hardware bug prevents channel 0 and 15 to be used by the DMAC together with the IPMMU. The DMAC driver will disable the channels reducing the effective number of channels to 14 per DMAC. Signed-off-by: Niklas Söderlund Acked-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7790.dtsi

[PATCH v4 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-02-16 Thread Niklas Söderlund
Enable slave transfers to devices behind IPMMU:s by mapping the slave addresses using the dma-mapping API. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- drivers/dma/sh/rcar-dmac.c | 52 +- 1 file changed, 47 insertions(+), 5

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

2016-02-16 Thread Niklas Söderlund
On 2016-02-15 23:00:53 +0530, Vinod Koul wrote: > On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote: > > > > > This is a dependency for adding iommu support to the rcar-dmac driver, > > > cfr. > > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave > > > transfers". > >

[PATCH v4 5/8] dmaengine: rcar-dmac: group slave configuration

2016-02-16 Thread Niklas Söderlund
Group slave address and transfer size in own structs for source and destination. This is in preparation for hooking up the dma-mapping API to the slave addresses. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- drivers/dma/sh/rcar-dmac.c | 37

[PATCH v4 4/8] arm: dma-mapping: add {map,unmap}_resource for iommu ops

2016-02-16 Thread Niklas Söderlund
Add methods to map/unmap device resources addresses for dma_map_ops that are IOMMU aware. This is needed to map a device MMIO register from a physical address. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- arch/arm/mm/dma-mapping.c | 63

[PATCH v4 0/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-02-16 Thread Niklas Söderlund
- Add DT information for r8a7791. * Changes since RFC - Switch to use the dma-mapping api instead of using the iommu_map() directly. Turns out the dma-mapper is much smarter then me... - Dropped the patch to expose domain->ops->pgsize_bitmap from within the iommu api. - Dropped the pat

[PATCH v4 3/8] dma-mapping: add dma_{map,unmap}_resource

2016-02-16 Thread Niklas Söderlund
Map/Unmap a device resource from a physical address. If no dma_map_ops method is available the operation is a no-op. Signed-off-by: Niklas Söderlund --- include/linux/dma-mapping.h | 32 1 file changed, 32 insertions(+) diff --git a/include/linux/dma-mapping.h

[PATCH v4 2/8] dma-mapping: add {map,unmap}_resource to dma_map_ops

2016-02-16 Thread Niklas Söderlund
Add methods to handle mapping of device resources from a physical address. This is needed for example to be able to map MMIO FIFO registers to a IOMMU. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- include/linux/dma-mapping.h | 6 ++ 1 file changed, 6 insertions

[PATCH v4 1/8] iommu: Add MMIO mapping type

2016-02-16 Thread Niklas Söderlund
urphy Signed-off-by: Niklas Söderlund --- drivers/iommu/io-pgtable-arm.c | 9 +++-- include/linux/iommu.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c index 381ca5a..9c19989 100644 --- a/drivers/

[PATCH v4 8/8] ARM: dts: r8a7791: add iommus to dmac0 and dmac1

2016-02-16 Thread Niklas Söderlund
A unconfirmed hardware bug prevents channel 0 and 15 to be used by the DMAC together with the IPMMU. The DMAC driver will disable the channels reducing the effective number of channels to 14 per DMAC. Signed-off-by: Niklas Söderlund Acked-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7791.dtsi

[PATCH v3 5/8] dmaengine: rcar-dmac: group slave configuration

2016-02-09 Thread Niklas Söderlund
Group slave address and transfer size in own structs for source and destination. This is in preparation for hooking up the dma-mapping API to the slave addresses. Signed-off-by: Niklas Söderlund --- drivers/dma/sh/rcar-dmac.c | 37 + 1 file changed, 21

[PATCH v3 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-02-09 Thread Niklas Söderlund
Enable slave transfers to devices behind IPMMU:s by mapping the slave addresses using the dma-mapping API. Signed-off-by: Niklas Söderlund --- drivers/dma/sh/rcar-dmac.c | 57 ++ 1 file changed, 52 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v3 4/8] arm: dma-mapping: add {map,unmap}_resource for iommu ops

2016-02-09 Thread Niklas Söderlund
Add methods to map/unmap device resources addresses for dma_map_ops that are IOMMU aware. This is needed to map a device MMIO register from a physical address. Signed-off-by: Niklas Söderlund --- arch/arm/mm/dma-mapping.c | 63 +++ 1 file changed, 63

[PATCH v3 2/8] dma-mapping: add {map,unmap}_resource to dma_map_ops

2016-02-09 Thread Niklas Söderlund
Add methods to handle mapping of device resources from a physical address. This is needed for example to map be able to map MMIO FIFO registers to a IOMMU. Signed-off-by: Niklas Söderlund --- include/linux/dma-mapping.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/dma

[PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

2016-02-09 Thread Niklas Söderlund
Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/r8a7790.dtsi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 7dfd393..048bbf8 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm

[PATCH v3 0/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-02-09 Thread Niklas Söderlund
the iommu api. - Dropped the patch showing how I tested the RFC. Niklas Söderlund (7): dma-mapping: add {map,unmap}_resource to dma_map_ops dma-mapping: add dma_{map,unmap}_resource arm: dma-mapping: add {map,unmap}_resource for iommu ops dmaengine: rcar-dmac: group slave configuration

[PATCH v3 1/8] iommu: Add MMIO mapping type

2016-02-09 Thread Niklas Söderlund
From: Robin Murphy On some platforms, MMIO regions might need slightly different treatment compared to mapping regular memory; add the notion of MMIO mappings to the IOMMU API's memory type flags, so that callers can let the IOMMU drivers know to do the right thing. Signed-off-by: Robin Murphy

[PATCH v3 3/8] dma-mapping: add dma_{map,unmap}_resource

2016-02-09 Thread Niklas Söderlund
Map/Unmap a device resource from a physical address. If no dma_map_ops method is available the operation is a no-op. Signed-off-by: Niklas Söderlund --- include/linux/dma-mapping.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/include/linux/dma-mapping.h b

[PATCH v3 8/8] ARM: dts: r8a7791: add iommus to dmac0 and dmac1

2016-02-09 Thread Niklas Söderlund
Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/r8a7791.dtsi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 2a369dd..6dff061 100644 --- a/arch/arm/boot/dts/r8a7791.dtsi +++ b/arch/arm

Re: [PATCH v3 1/8] iommu: Add MMIO mapping type

2016-02-16 Thread Niklas Söderlund
>Hi Niklas, > > > >Thank you for the patch. > > > >On Wednesday 10 February 2016 01:57:51 Niklas Söderlund wrote: > >>From: Robin Murphy > >> > >>On some platforms, MMIO regions might need slightly different treatment > >>compared to mapp

Re: [PATCH v3 1/8] iommu: Add MMIO mapping type

2016-02-16 Thread Niklas Söderlund
* Robin Murphy [2016-02-16 12:43:40 +]: > On 16/02/16 12:06, Niklas Söderlund wrote: > >Hi Robin, > > > >Thanks for your update patch I will include it in my next version. But > >I'm sorry I do not understand, is your modification an addition or a > &

[PATCH 0/4] sh-pfc: Add emev2 pinmux support

2014-12-12 Thread Niklas Söderlund
Greetings, This patchset introduces pinmux support for the EMMA Mobile EV2 board to the sh-pfc pin-controller driver. Devicetree bindings for gpio and the populated serial connector are also defined in 3/4 and 4/4. Comments are welcome! Regards // Niklas Niklas Söderlund (4): sh-pfc: add

[PATCH 3/4] ARM: shmobile: emev2: Add PFC information to emev2.dtsi

2014-12-12 Thread Niklas Söderlund
With this information all GPIOs can make use of the PFC functionality. Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/emev2.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/emev2.dtsi b/arch/arm/boot/dts/emev2.dtsi index cc7bfe0..518b7fa 100644

[PATCH 4/4] ARM: shmobile: emev2-kzm9d: Add PFC information for uart1

2014-12-12 Thread Niklas Söderlund
Configure the pinmux on kzm9d to use the serial connector for uart1. Signed-off-by: Niklas Söderlund --- arch/arm/boot/dts/emev2-kzm9d.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts index 667d323

[PATCH 1/4] sh-pfc: add macro to define pinmux without function

2014-12-12 Thread Niklas Söderlund
Used to define pinmux configurations where the pinmux function have no representation in the configuration registers but instead solely depends on a group selection. Signed-off-by: Niklas Söderlund --- drivers/pinctrl/sh-pfc/sh_pfc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH 2/4] sh-pfc: Add emev2 pinmux support

2014-12-12 Thread Niklas Söderlund
Add PFC support for the EMMA Mobile EV2 SoC including pin groups for on-chip devices. Signed-off-by: Niklas Söderlund --- .../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 + drivers/pinctrl/sh-pfc/Kconfig |5 + drivers/pinctrl/sh-pfc/Makefile

Re: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource

2016-04-21 Thread Niklas Söderlund
Hi Christoph, Have you had time to look at the audit? Is there anything else I can do make progress on this? On 2016-04-13 15:29:16 +0200, Niklas Söderlund wrote: > Hi Christoph, > > On 2016-03-21 08:26:01 -0700, Christoph Hellwig wrote: > > On Thu, Mar 17, 2016 at 01:33:51PM

Re: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource

2016-04-25 Thread Niklas Söderlund
or(). With that I can't see how a dma_addr_t would end up in lib/dma-debug.c. But I might be missing something? In the big picture do you feel the approach I have is the correct way to solve my problem? Provided we can work out this issues ofc? -- Regards, Niklas Söderlund

  1   2   >