Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

2016-09-06 Thread Nicolas Dufresne
; I'm not sure I agree with the TODO, and even if I did, I'm not sure I agree > with this solution. Since queuing the buffer to the driver is not the same > as 'just before the DMA', since there may be many buffers queued up in the > driver and you don't know in vb2

Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

2016-09-06 Thread Nicolas Dufresne
o the mapping when buffers > > are queued in the driver since that's when the actual DMA operation are > > going to happen. > > > > Suggested-by: Nicolas Dufresne > > Signed-off-by: Javier Martinez Canillas > > Sorry, but I don't get why such chan

Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

2016-09-06 Thread Nicolas Dufresne
more appropriate to do the mapping when buffers > > are queued in the driver since that's when the actual DMA operation are > > going to happen. > > > > Suggested-by: Nicolas Dufresne > > Signed-off-by: Javier Martinez Canillas > > > > --- > >

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-15 Thread Nicolas Dufresne
Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > Hi Nicolas, > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > > > Currently videobuf2-dma-sg checks for dma d

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-17 Thread Nicolas Dufresne
Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > > Hi Nicolas, > > > > > > On Tue, Oct 10, 2017 at 11:4

[PATCH] uvc: Add D3DFMT_L8 support

2017-11-03 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This add support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 + drivers/media/usb/uvc/uvcvideo.h | 5

[PATCH v2] uvc: Add D3DFMT_L8 support

2017-11-06 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This adds support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 + drivers/media/usb/uvc/uvcvideo.h | 5

Re: [PATCH v7 0/6] V4L2 Explicit Synchronization

2018-01-10 Thread Nicolas Dufresne
Le mercredi 10 janvier 2018 à 14:07 -0200, Gustavo Padovan a écrit : > v7 bring a fix for a crash when not using fences and a uAPI fix. > I've done a bit more of testing on it and also measured some > performance. On a intel laptop a DRM<->V4L2 pipeline with fences is > runnning twice as faster tha

Re: [RFC PATCH 6/8] v4l2: document the request API interface

2018-01-26 Thread Nicolas Dufresne
Le vendredi 26 janvier 2018 à 12:40 -0800, Randy Dunlap a écrit : > > +Request API > > +=== > > + > > +The Request API has been designed to allow V4L2 to deal with > > requirements of > > +modern IPs (stateless codecs, MIPI cameras, ...) and APIs (Android > > Codec v2). > > Hi, > Just a qu

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > Dear Linux folks, > > > On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. > > ``` > [2.338094] calling uvc_init+0x0/0x1000 [uvcvideo] @ 295 > [2.338569] calling iTCO_wdt_init_module+0x0/0x1000 [iTCO_wdt] @ 2

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 20:04 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Tuesday, 20 March 2018 19:45:51 EET Nicolas Dufresne wrote: > > Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > > > Dear Linux folks, > > > > > > >

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-21 Thread Nicolas Dufresne
Le mercredi 21 mars 2018 à 10:55 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Wednesday, 21 March 2018 05:38:59 EET Nicolas Dufresne wrote: > > Le mardi 20 mars 2018 à 20:04 +0200, Laurent Pinchart a écrit : > > > On Tuesday, 20 March 2018 19:45:51 EET Nicolas Du

Re: [PATCH v8 07/13] [media] vb2: mark codec drivers as unordered

2018-03-09 Thread Nicolas Dufresne
Le vendredi 09 mars 2018 à 14:49 -0300, Gustavo Padovan a écrit : > From: Gustavo Padovan > > In preparation to have full support to explicit fence we are > marking codec as non-ordered preventively. It is easier and safer from an The usage of "codec" is soso > uAPI point of view to move f

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mercredi 18 octobre 2017 à 11:34 +0300, Stanimir Varbanov a écrit : > > On 10/17/2017 05:19 PM, Nicolas Dufresne wrote: > > Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > > > On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > > >

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mardi 13 mars 2018 à 20:44 -0400, Nicolas Dufresne a écrit : > Le mercredi 18 octobre 2017 à 11:34 +0300, Stanimir Varbanov a écrit > : > > > > On 10/17/2017 05:19 PM, Nicolas Dufresne wrote: > > > Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : >

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2018-03-13 Thread Nicolas Dufresne
Le mardi 13 mars 2018 à 21:09 -0400, Nicolas Dufresne a écrit : > > I've looked into this again. I have hit the same issue but with CPU > > to > > DRM, using DMABuf allocated from DRM Dumb buffers. In that case, > > using > > DMA_BUF_IOCTL_SYNC fixes the is

Re: DMA-buf and uncached system memory

2021-02-15 Thread Nicolas Dufresne
Le lundi 15 février 2021 à 09:58 +0100, Christian König a écrit : > Hi guys, > > we are currently working an Freesync and direct scan out from system > memory on AMD APUs in A+A laptops. > > On problem we stumbled over is that our display hardware needs to scan > out from uncached system memory

Re: DMA-buf and uncached system memory

2021-02-15 Thread Nicolas Dufresne
Le lundi 15 février 2021 à 13:10 +0100, Christian König a écrit : > > > Am 15.02.21 um 13:00 schrieb Thomas Zimmermann: > > Hi > > > > Am 15.02.21 um 10:49 schrieb Thomas Zimmermann: > > > Hi > > > > > > Am 15.02.21 um 09:58 schrieb Christian König: > > > > Hi guys, > > > > > > > > we are curr

Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-15 Thread Nicolas Dufresne
Le 2015-01-15 11:23, Frédéric Sureau a écrit : Maybe a->parm.output.capability should be set to |V4L2_CAP_TIMEPERFRAME| here. I think it is required by GStreamer V4L2 plugin. Looking at this, I think output device is indeed the right place to set this, and the capability should indeed be updat

Re: [PATCH 26/28] venus: implementing multi-stream support

2018-05-02 Thread Nicolas Dufresne
Le mercredi 02 mai 2018 à 13:10 +0530, Vikash Garodia a écrit : > Hello Stanimir, > > On 2018-04-24 18:14, Stanimir Varbanov wrote: > > This is implementing a multi-stream decoder support. The multi > > stream gives an option to use the secondary decoder output > > with different raw format (or th

Re: [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface

2019-04-17 Thread Nicolas Dufresne
Le dimanche 14 avril 2019 à 18:41 +0200, Paul Kocialkowski a écrit : > Hi, > > Le vendredi 12 avril 2019 à 16:47 -0400, Nicolas Dufresne a écrit : > > Le mercredi 06 mars 2019 à 17:00 +0900, Alexandre Courbot a écrit : > > > Documents the protocol that user-

Re: [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface

2019-04-17 Thread Nicolas Dufresne
Le mardi 16 avril 2019 à 09:37 +0200, Paul Kocialkowski a écrit : > Hi, > > Le lundi 15 avril 2019 à 11:30 -0400, Nicolas Dufresne a écrit : > > Le lundi 15 avril 2019 à 15:26 +0200, Paul Kocialkowski a écrit : > > > Hi, > > > > > > On Mon, 2019-04

Re: [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface

2019-04-17 Thread Nicolas Dufresne
Le mercredi 17 avril 2019 à 17:40 +0200, Paul Kocialkowski a écrit : > Hi, > > On Wed, 2019-04-17 at 11:30 -0400, Nicolas Dufresne wrote: > > Le dimanche 14 avril 2019 à 18:41 +0200, Paul Kocialkowski a écrit : > > > Hi, > > > > > > Le vendredi 12 av

Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-27 Thread Nicolas Dufresne
Le mercredi 27 février 2019 à 11:01 +0100, Maxime Ripard a écrit : > > Also regarding the pixel formats. I still think we should have two > > pixel formats: V4L2_PIX_FMT_H264_SLICE_RAW and > > V4L2_PIX_FMT_H264_SLICE_ANNEX_B, to properly represent "raw" NALUs > > and "annex B" formatted NALUs. > >

Re: [PATCH v2 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-22 Thread Nicolas Dufresne
Hi John, Le lundi 22 février 2021 à 17:39 +0100, Benjamin Gaignard a écrit : > > Le 22/02/2021 à 17:24, John Cox a écrit : > > > The H.265 ITU specification (section 7.4) define the general > > > slice segment header semantics. > > > Modified/added fields are: > > > - video_parameter_set_id: (7.4

Re: [PATCH v2 4/9] media: uapi: Add a control for HANTRO driver

2021-02-22 Thread Nicolas Dufresne
Le lundi 22 février 2021 à 17:28 +0100, Benjamin Gaignard a écrit : > > Le 22/02/2021 à 17:16, John Cox a écrit : > > > The HEVC HANTRO driver needs to know the number of bits to skip at > > > the beginning of the slice header. > > > That is a hardware specific requirement so create a dedicated co

Re: [PATCH v5 2/3] media: uapi: Add VP9 stateless decoder controls

2021-02-22 Thread Nicolas Dufresne
Hi All, Le lundi 02 novembre 2020 à 21:05 +0200, Adrian Ratiu a écrit : > From: Boris Brezillon > > Add the VP9 stateless decoder controls plus the documentation that goes > with it. > > Signed-off-by: Boris Brezillon > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  ..

Re: [PATCH v5 2/3] media: uapi: Add VP9 stateless decoder controls

2021-02-22 Thread Nicolas Dufresne
Le lundi 22 février 2021 à 16:00 -0500, Nicolas Dufresne a écrit : Hi All, Le lundi 02 novembre 2020 à 21:05 +0200, Adrian Ratiu a écrit : > From: Boris Brezillon > > Add the VP9 stateless decoder controls plus the documentation that goes > with it. > > Signed-off-by: Boris B

Re: [PATCH v4 2/3] media: uapi: Add VP9 stateless decoder controls

2021-02-24 Thread Nicolas Dufresne
Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit : > Hi Ezequiel, sorry for the late review! > > On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia > wrote: > > > > From: Boris Brezillon > > > > Add the VP9 stateless decoder controls plus the documentation that goes > > with it

Re: [PATCH v6 1/2] media: v4l2-ctrl: add controls for long term reference.

2021-02-10 Thread Nicolas Dufresne
Le jeudi 04 février 2021 à 11:05 +0100, Hans Verkuil a écrit : > On 04/02/2021 06:01, diksh...@codeaurora.org wrote: > > On 2021-02-01 16:50, Hans Verkuil wrote: > > > On 25/01/2021 06:51, Dikshita Agarwal wrote: > > > > Long Term Reference (LTR) frames are the frames that are encoded > > > > somet

Re: [BUG REPORT] media: coda: mpeg4 decode corruption on i.MX6qp only

2021-02-10 Thread Nicolas Dufresne
Hi Sven, Le mercredi 03 février 2021 à 11:33 -0500, Sven Van Asbroeck a écrit : > From: Sven Van Asbroeck > > We have observed that under certain repeatable circumstances, the CODA > mem2mem device consistently generates corrupted frames. This happens only > on an i.MX6qp (Plus) - the classic im

[PATCH v1] doc: h264/hevc: Clarify _START_CODE_NONE meaning

2021-02-09 Thread Nicolas Dufresne
: Nicolas Dufresne --- .../userspace-api/media/v4l/ext-ctrls-codec-stateless.rst | 4 +++- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst b

Re: [PATCH v3 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-25 Thread Nicolas Dufresne
Le jeudi 25 février 2021 à 10:09 -0300, Ezequiel Garcia a écrit : > Hi Benjamin, > > Thanks for the good work. > > On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote: > > The H.265 ITU specification (section 7.4) define the general > > slice segment header semantics. > > Modified/added fi

Re: [PATCH v3 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-25 Thread Nicolas Dufresne
Le jeudi 25 février 2021 à 18:34 +, John Cox a écrit : > On Thu, 25 Feb 2021 19:05:55 +0100, you wrote: > > > Dne ?etrtek, 25. februar 2021 ob 18:34:48 CET je Ezequiel Garcia napisal(a): > > > Hey Jernej, > > > > > > On Thu, 2021-02-25 at 18:01 +0100, Jernej Škrabec wrote: > > > > Hi Ezequiel

Re: [PATCH 03/10] media: uapi: h264: Split prediction weight parameters

2020-07-30 Thread Nicolas Dufresne
Le samedi 25 juillet 2020 à 22:30 +0900, Alexandre Courbot a écrit : > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia > wrote: > > The prediction weight parameters are only required under > > certain conditions, which depend on slice header parameters. > > > > The slice header syntax specifies

Re: [PATCH v2 0/6] Add new controls for CQ and Frame-skip

2020-07-30 Thread Nicolas Dufresne
Le mardi 21 juillet 2020 à 10:45 +0300, Stanimir Varbanov a écrit : > Hello, > > Here is v2 with following changes: > > * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas Thanks for this enhancement. No more comments on the doc from me. > * 4/6 Fixed compile warning

Re: [PATCH] media: cedrus: Add support for VP8 decoding

2020-05-20 Thread Nicolas Dufresne
Le mercredi 20 mai 2020 à 23:01 +0200, Jernej Skrabec a écrit : > VP8 in Cedrus shares same engine as H264. > > Note that it seems necessary to call bitstream parsing functions, > to parse frame header, otherwise decoded image is garbage. This is > contrary to what is driver supposed to do. Howeve

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-12-07 Thread Nicolas Dufresne
Le vendredi 13 novembre 2020 à 21:39 +0100, Daniel Vetter a écrit : > On Thu, Nov 12, 2020 at 08:11:02PM -0800, John Stultz wrote: > > On Thu, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote: > > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote: > > > > On Tue, 10 Nov 2020 at 09:19, John

Re: [PATCH v3 0/4] media: meson: Add support for the Amlogic GE2D Accelerator Unit

2020-12-08 Thread Nicolas Dufresne
Le mardi 17 novembre 2020 à 09:44 +0100, Neil Armstrong a écrit : > The GE2D is a 2D accelerator with various features like configurable blitter > with alpha blending, frame rotation, scaling, format conversion and colorspace > conversion. > > The driver implements a Memory2Memory VB2 V4L2 streami

Re: [PATCH 0/4] Chunk Heap Support on DMA-HEAP

2020-12-08 Thread Nicolas Dufresne
Le mardi 17 novembre 2020 à 10:19 -0800, Minchan Kim a écrit : > This patchset introduces a new dma heap, chunk heap that makes it > easy to perform the bulk allocation of high order pages. > It has been created to help optimize the 4K/8K HDR video playback > with secure DRM HW to protect contents

Re: [PATCH 2/9] misc: Add Xilinx AI engine device driver

2020-12-08 Thread Nicolas Dufresne
Le mercredi 18 novembre 2020 à 00:06 -0800, Wendy Liang a écrit : > Create AI engine device/partition hierarchical structure. > > Each AI engine device can have multiple logical partitions(groups of AI > engine tiles). Each partition is column based and has its own node ID > in the system. AI engi

Re: [PATCH v4 1/9] media: uapi: mpeg2: Rework quantization matrices semantics

2021-03-29 Thread Nicolas Dufresne
rhaps: "The quantisation controls is therefore optional for decoding streams that uses the default matrices." A stack that would not handle the default, would have to read the control at least once in order to avoid overriding valid values with 0s, not sure if that is wort

Re: [PATCH v3 05/15] media: mtk-vcodec: vdec: support stateless API

2021-03-17 Thread Nicolas Dufresne
Le mercredi 17 mars 2021 à 12:13 +0900, Alexandre Courbot a écrit : > On Tue, Mar 16, 2021 at 6:45 AM Ezequiel Garcia > wrote: > > > > Hi Alexandre, > > > > On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot > > wrote: > > > > > > Hi Ezequiel, thanks for the feedback! > > > > > > On Thu, Mar 4,

Re: [PATCH v5 01/22] media: camss: Fix vfe_isr_comp_done() documentation

2021-02-19 Thread Nicolas Dufresne
Hi Robert, not really a review, but I noticed Le mercredi 17 février 2021 à 12:21 +0100, Robert Foss a écrit : > Function name is comment is wrong, and was changed to be in > the same as the actual function name. > > The comment was changed to kerneldoc format. > > Signed

Re: [PATCH 4/4] venus: venc: Add support for AUD NALU control

2020-11-30 Thread Nicolas Dufresne
Le lundi 30 novembre 2020 à 11:08 +0200, Stanimir Varbanov a écrit : > Add support for Access Unit Delimiter control into encoder. > > Signed-off-by: Stanimir Varbanov > --- >  drivers/media/platform/qcom/venus/core.h   |  1 + >  drivers/media/platform/qcom/venus/venc.c   | 14 +++

Re: [PATCH v4 2/3] media: uapi: Add VP9 stateless decoder controls

2021-03-01 Thread Nicolas Dufresne
Le dimanche 28 février 2021 à 15:13 +0900, Alexandre Courbot a écrit : > Hi Nicolas, > > On Thu, Feb 25, 2021 at 6:08 AM Nicolas Dufresne > wrote: > > > > Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit : > > > Hi Ezequiel, sorry for the late

Re: [PATCH v3 05/15] media: mtk-vcodec: vdec: support stateless API

2021-03-15 Thread Nicolas Dufresne
Le lundi 15 mars 2021 à 20:28 +0900, Alexandre Courbot a écrit : > Hi Ezequiel, thanks for the feedback! > > On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia > wrote: > > > > Hello Alex, > > > > Thanks for the patch. > > > > On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot > > wrote: > > > > >

Re: [PATCH v3 06/15] media: mtk-vcodec: vdec: support stateless H.264 decoding

2021-03-15 Thread Nicolas Dufresne
Le lundi 15 mars 2021 à 20:28 +0900, Alexandre Courbot a écrit : > Hi Ezequiel, > > On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia > wrote: > > > >  Hi Alex, > > > > Thanks for the patch. > > > > On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot > > wrote: > > > > > > From: Yunfei Dong > > >

Re: [PATCH v2 3/8] media: add Mediatek's MM21 format

2021-03-02 Thread Nicolas Dufresne
Le jeudi 25 février 2021 à 19:16 +0900, Alexandre Courbot a écrit : > Add Mediatek's non-compressed 8 bit block video mode. This format is > produced by the MT8183 codec and can be converted to a non-proprietary > format by the MDP3 component. > > Signed-off-by: Alexandre Courbot > --- >  Documen

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Nicolas Dufresne
Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit : > Hi Tomasz, > > On 12/15/20 1:47 PM, Tomasz Figa wrote: > > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov > > wrote: > > > > > > Hi, > > > > > > Cc: Robin > > > > > > On 12/14/20 2:57 PM, Alexandre Courbot wrote: > > > >

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

2016-05-06 Thread Nicolas Dufresne
Thanks for re-submitting. See inline two typos to fix in teh comment. cheers, Nicolas Le vendredi 06 mai 2016 à 18:11 -0400, Javier Martinez Canillas a écrit : > From: ayaka > > User-space applications can use the VIDIOC_REQBUFS ioctl to determine if a > memory mapped, user pointer or DMABUF ba

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

2016-05-09 Thread Nicolas Dufresne
ssue, only free the buffers on VIDIOC_REQBUFS(0) but > don't > close the MFC instance to allow future VIDIOC_REQBUFS(n) calls to > succeed. > > Signed-off-by: ayaka > [javier: Rewrote changelog to explain the problem more detailed] > Signed-off-by: Javier Martinez Canillas I j

Re: imx53 IPU support on 4.0.4

2015-05-21 Thread Nicolas Dufresne
Le mercredi 20 mai 2015 à 21:55 +0100, Russell King - ARM Linux a écrit : > The way kernel development works is that patches are sent to mailing > lists for review. Kernel developers review the patches and provide > comments back. The comments are discussed and actioned, and a new > set of patch

Re: i.MX6 CSC and scaler

2014-12-15 Thread Nicolas Dufresne
Le 12/15/2014 01:23 PM, Steve Longerbeam a écrit : > You would need to write a gstreamer plugin to make use of the > mem2mem device for h/w CSC and scaling. There is an element already (v4l2transform), though it currently only handle color conversion. I'd like to see scaling in that too instead

Re: i.MX6 CSC and scaler

2014-12-16 Thread Nicolas Dufresne
Le 2014-12-16 08:30, Philipp Zabel a écrit : For the IPU IC mem2mem scaler/CSC, v4l2transform with scaling capability would be the perfect fit Thanks you for clarifying. Jean-Michel, are you going to work on this ? If so, feel free to contact me directly for pointers. You'll find me as stormer

Re: i.MX6 CSC and scaler

2014-12-16 Thread Nicolas Dufresne
Le 2014-12-16 09:27, Jean-Michel Hautbois a écrit : Have you already started something about that ? Yes, currently I do cropping right if there is no scaling. Doing this with S_CROP is really ackward, but very few m2m driver has been ported to G_SELECTION yet. The v4l2transform was tested to r

Re: i.MX6 CSC and scaler

2014-12-17 Thread Nicolas Dufresne
Le 2014-12-17 08:12, Jean-Michel Hautbois a écrit : [10005.819862] mx6-m2m ipum2m@ipu1: call capture S_FMT first to determine segmentation Please, find the part of the spec that would inforce that, if not inforced, do the spec work first. Nicolas -- To unsubscribe from this list: send the l

Re: [PATCH 3/7] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-04-18 Thread Nicolas Dufresne
Le lundi 18 avril 2016 à 16:22 +0800, tiffany lin a écrit : > > > We are plaining to remove m2m framework in th feature, although > we think > >  > > Remove it for just the decoder driver or both encoder and decoder? > >  > Remove it from decoder driver. Did you look at how CODA handle it (drivers

Re: [PATCH 1/7] [media]: v4l: add Mediatek MT21 video block format

2016-04-13 Thread Nicolas Dufresne
Le mercredi 13 avril 2016 à 20:01 +0800, Tiffany Lin a écrit : > From: Daniel Kurtz > > Mediatek video format is YVU8_420_2PLANE_PACK8_PROGRESSIVE. > > Create V4L2_PIX_FMT_MT21 and DRM_FORMAT_MT21 to be consistent with > V4L2_PIX_FMT_NV12 notation. > > Signed-off-by: Tiffany Lin > --- >  inclu

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Nicolas Dufresne
Le lundi 11 février 2019 à 16:16 +0100, Hans Verkuil a écrit : > Hi Maxime, > > A quick review below. Note that I am no expert on the codec details, so > I leave that to others. I'm mainly concentrating on the structs, flags, etc. > > On 2/11/19 3:39 PM, Maxime Ripard wrote: > > From: Pawel Oscia

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-03-20 Thread Nicolas Dufresne
Le mercredi 20 mars 2019 à 16:27 +0200, Ville Syrjälä a écrit : > On Tue, Mar 19, 2019 at 07:29:18PM -0400, Nicolas Dufresne wrote: > > Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit : > > > V4L2 uses different fourcc's than DRM, and has a different set of format

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-30 Thread Nicolas Dufresne
Le vendredi 30 août 2019 à 07:48 +0200, Boris Brezillon a écrit : > On Thu, 29 Aug 2019 21:04:28 +0200 > Jernej Škrabec wrote: > > > Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon > > napisal(a): > > > Hi Jernej, > > > > > > On Thu, 22 Aug 2019 21:44:57 +0200 > > > > > > J

Re: [PATCH 2/2] media: meson: vdec: add H.264 decoding support

2019-10-08 Thread Nicolas Dufresne
Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit : > Add support for the H264 compressed format (V4L2_PIX_FMT_H264). > > Signed-off-by: Maxime Jourdan > --- > drivers/staging/media/meson/vdec/Makefile | 2 +- > drivers/staging/media/meson/vdec/codec_h264.c | 482 +

Re: [PATCH 2/2] media: meson: vdec: add H.264 decoding support

2019-10-08 Thread Nicolas Dufresne
Le mardi 08 octobre 2019 à 16:27 -0400, Nicolas Dufresne a écrit : > Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit : > > Add support for the H264 compressed format (V4L2_PIX_FMT_H264). > > > > Signed-off-by: Maxime Jourdan > > --- > > drivers/

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-07-16 Thread Nicolas Dufresne
Le lundi 15 juillet 2019 à 14:12 +0200, Maxime Jourdan a écrit : > On Tue, Jun 11, 2019 at 10:29 AM Hans Verkuil > wrote: > > On 6/10/19 9:54 PM, Nicolas Dufresne wrote: > > > Hi Hans, > > > > > > I went through it, and I think we are close to re

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-07-17 Thread Nicolas Dufresne
Hello, there is one little detail/proposal, see inline . Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit : > From: Tomasz Figa > > Due to complexity of the video decoding process, the V4L2 drivers of > stateful decoder hardware require specific sequences of V4L2 API calls > to be foll

Re: [PATCH 0/2] media: meson: vdec: Add compliant H264 support

2019-10-12 Thread Nicolas Dufresne
Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit : > Hello, > > This patch series aims to bring H.264 support as well as compliance update > to the amlogic stateful video decoder driver. > > There is 1 issue that remains currently: > > - The following codepath had to be commented

Re: [PATCH v2 for 5.4 2/4] media: hantro: Fix H264 max frmsize supported on RK3288

2019-10-13 Thread Nicolas Dufresne
Le jeudi 10 octobre 2019 à 16:23 +0900, Tomasz Figa a écrit : > On Tue, Oct 8, 2019 at 11:12 PM Jonas Karlman wrote: > > On 2019-10-08 15:53, Tomasz Figa wrote: > > > On Tue, Oct 8, 2019 at 10:35 PM Tomasz Figa wrote: > > > > On Tue, Oct 8, 2019 at 7:42 PM Tomasz Figa wrote: > > > > > On Tue, Oc

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-14 Thread Nicolas Dufresne
Le jeudi 14 février 2019 à 11:43 +0900, Tomasz Figa a écrit : > > > > No, I exactly meant the OUTPUT queue. The behavior of s5p-mfc in case > > > > of the format not being detected yet is to waits for any pending > > > > bitstream buffers to be processed by the decoder before returning an > > > > e

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Nicolas Dufresne
Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : > Hi Stanimir, > > I never paid much attention to this patch series since others were busy > discussing it and I had a lot of other things on my plate, but then I heard > that this patch made G_FMT blocking. > > That's a no-go. App

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-29 Thread Nicolas Dufresne
Le mardi 29 janvier 2019 à 16:44 +0900, Alexandre Courbot a écrit : > On Fri, Jan 25, 2019 at 10:04 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Thu, 2019-01-24 at 20:23 +0800, Ayaka wrote: > > > Sent from my iPad > > > > > > > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski > > > > wrote:

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Nicolas Dufresne
Le lundi 28 janvier 2019 à 16:38 +0900, Tomasz Figa a écrit : > > > Nope, that's not what is expected to happen here. Especially since > > > you're potentially in non-blocking IO mode. Regardless of that, the > > > > OK, how to handle that when userspace (for example gstreamer) hasn't > > support

Re: [PATCH v2] venus: enc: fix enum_frameintervals

2019-01-29 Thread Nicolas Dufresne
Le mardi 22 janvier 2019 à 12:53 +0200, Stanimir Varbanov a écrit : > This ixes an issue when setting the encoder framerate because of ixes -> fixes > missing precision. Now the frameinterval type is changed to > TYPE_CONTINUOUS and step = 1. Also the math is changed when > framerate property is

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-29 Thread Nicolas Dufresne
Le vendredi 25 janvier 2019 à 12:27 +0900, Tomasz Figa a écrit : > On Fri, Jan 25, 2019 at 4:55 AM Nicolas Dufresne wrote: > > Le jeudi 24 janvier 2019 à 18:06 +0900, Tomasz Figa a écrit : > > > > Actually I just realized the last point might not even be achievable &g

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 12:38 +0900, Tomasz Figa a écrit : > > Yes, unfortunately, GStreamer still rely on G_FMT waiting a minimal > > amount of time of the headers to be processed. This was how things was > > created back in 2011, I could not program GStreamer for the future. If > > we stop

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-30 Thread Nicolas Dufresne
Le vendredi 25 janvier 2019 à 12:59 +0900, Tomasz Figa a écrit : > On Fri, Jan 25, 2019 at 5:14 AM Nicolas Dufresne wrote: > > Le mercredi 23 janvier 2019 à 14:04 +0100, Hans Verkuil a écrit : > > > > > Does this return the same set of formats as in the 'Querying

Re: [PATCH] media: videobuf2: Return error after allocation failure

2019-02-03 Thread Nicolas Dufresne
Le dimanche 03 février 2019 à 19:06 +0530, Souptick Joarder a écrit : > There is no point to continuing assignemnt after memory allocation assignemnt -> assignment. > failed, rather throw error immediately. > > Signed-off-by: Souptick Joarder > --- > drivers/media/common/videobuf2/videobuf2-vm

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-24 Thread Nicolas Dufresne
Le jeudi 24 janvier 2019 à 18:06 +0900, Tomasz Figa a écrit : > > Actually I just realized the last point might not even be achievable > > for some of the decoders (s5p-mfc, mtk-vcodec), as they don't report > > which frame originates from which bitstream buffer and the driver just > > picks the mo

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-24 Thread Nicolas Dufresne
Le mercredi 23 janvier 2019 à 19:02 +0900, Tomasz Figa a écrit : > On Sun, Nov 18, 2018 at 10:34 AM Nicolas Dufresne > wrote: > > Le samedi 17 novembre 2018 à 12:37 +0100, Hans Verkuil a écrit : > > > > > Does V4L2_CID_MIN_BUFFERS_FOR_CAPTURE make any sense for encod

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-24 Thread Nicolas Dufresne
Le mercredi 23 janvier 2019 à 14:04 +0100, Hans Verkuil a écrit : > > > Does this return the same set of formats as in the 'Querying > > > Capabilities' phase? > > > > > > > It's actually an interesting question. At this point we wouldn't have > > the OUTPUT resolution set yet, so that would be

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-24 Thread Nicolas Dufresne
Le mercredi 23 janvier 2019 à 12:28 +0100, Hans Verkuil a écrit : > On 01/23/19 11:00, Tomasz Figa wrote: > > On Sat, Nov 17, 2018 at 8:37 PM Hans Verkuil wrote: > > > On 11/17/2018 05:18 AM, Nicolas Dufresne wrote: > > > > Le lundi 12 novembre 2018 à 14:

Re: Hardware-accelerated video decoders used through a firmware instead of hardware registers

2019-05-12 Thread Nicolas Dufresne
Le dimanche 12 mai 2019 à 13:35 +0200, Paul Kocialkowski a écrit : > Hi, > > With the work done on the media request API and the cedrus driver for > Allwinner ARM SoCs, we now have a kernel interface for exposing fixed- > hardware video decoding pipelines (currently MPEG-2 and H.264, with > H.265

Re: Hardware-accelerated video decoders used through a firmware instead of hardware registers

2019-05-12 Thread Nicolas Dufresne
Le dimanche 12 mai 2019 à 18:32 +0200, Paul Kocialkowski a écrit : > Hi Nicolas, > > Le dimanche 12 mai 2019 à 10:17 -0400, Nicolas Dufresne a écrit : > > Le dimanche 12 mai 2019 à 13:35 +0200, Paul Kocialkowski a écrit : > > > Hi, > > > > > > With the

Re: [PATCH v2] media/doc: Allow sizeimage to be set by v4l clients

2019-05-14 Thread Nicolas Dufresne
Le mardi 14 mai 2019 à 10:54 +0200, Hans Verkuil a écrit : > Hi Stanimir, > > On 4/12/19 5:59 PM, Stanimir Varbanov wrote: > > This changes v4l2_pix_format and v4l2_plane_pix_format sizeimage > > field description to allow v4l clients to set bigger image size > > in case of variable length compres

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Nicolas Dufresne
Le mardi 23 avril 2019 à 14:33 +0200, Paul Kocialkowski a écrit : > Hi, > > On Tue, 2019-04-23 at 09:30 +0200, Daniel Vetter wrote: > > On Sun, Apr 21, 2019 at 01:40:45AM +0300, Laurent Pinchart wrote: > > > Hi Paul, > > > > > > On Thu, Apr 18, 2019 at 01:49:54PM +0200, Paul Kocialkowski wrote: >

Re: [PATCHv4 0/2] Document memory-to-memory video codec interfaces

2019-06-10 Thread Nicolas Dufresne
Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit : > Since Thomasz was very busy with other things, I've taken over this > patch series. This v4 includes his draft changes and additional changes > from me. > > This series attempts to add the documentation of what was discussed > during Me

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-06-10 Thread Nicolas Dufresne
Hi Hans, I went through it, and I think we are close to ready. Unfortunately, I believe the SOURCE_CHANGE event is still under specified. There was a post recently to try and add a new flag for changes in color space which is not included here. We are also missing a workflow for changes that don't

Re: [PATCHv4 0/2] Document memory-to-memory video codec interfaces

2019-07-03 Thread Nicolas Dufresne
Le mercredi 03 juillet 2019 à 18:04 +0900, Tomasz Figa a écrit : > On Wed, Jun 5, 2019 at 12:19 AM Nicolas Dufresne wrote: > > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit : > > > Since Thomasz was very busy with other things, I've taken over this > > >

Re: [PATCH v2 1/2] media: uapi: Add VP8 stateless decoder API

2019-07-03 Thread Nicolas Dufresne
__u16 padding; > + __u32 flags; > +}; > + > +struct v4l2_vp8_quantization_header { > + __u8 y_ac_qi; > + __s8 y_dc_delta; > + __s8 y2_dc_delta; > + __s8 y2_ac_delta; > + __s8 uv_dc_delta; > + __s8 uv_ac_delta; > + __u16 padding; > +}; > + > +struct v4l2_vp8_entropy_header { > + __u8 coeff_probs[4][8][3][11]; > + __u8 y_mode_probs[4]; > + __u8 uv_mode_probs[3]; > + __u8 mv_probs[2][19]; > + __u8 padding[3]; > +}; > + > +struct v4l2_vp8_entropy_coder_state { > + __u8 range; > + __u8 value; > + __u8 bit_count; > + __u8 padding; > +}; > + > +#define V4L2_VP8_FRAME_HEADER_FLAG_KEY_FRAME 0x01 > +#define V4L2_VP8_FRAME_HEADER_FLAG_EXPERIMENTAL 0x02 > +#define V4L2_VP8_FRAME_HEADER_FLAG_SHOW_FRAME0x04 > +#define V4L2_VP8_FRAME_HEADER_FLAG_MB_NO_SKIP_COEFF 0x08 > +#define V4L2_VP8_FRAME_HEADER_FLAG_SIGN_BIAS_GOLDEN 0x10 > +#define V4L2_VP8_FRAME_HEADER_FLAG_SIGN_BIAS_ALT 0x20 > + > +#define VP8_FRAME_IS_KEY_FRAME(hdr) \ > + (!!((hdr)->flags & V4L2_VP8_FRAME_HEADER_FLAG_KEY_FRAME)) > + > +struct v4l2_ctrl_vp8_frame_header { > + struct v4l2_vp8_segment_header segment_header; > + struct v4l2_vp8_loopfilter_header lf_header; > + struct v4l2_vp8_quantization_header quant_header; > + struct v4l2_vp8_entropy_header entropy_header; > + struct v4l2_vp8_entropy_coder_state coder_state; > + > + __u16 width; > + __u16 height; > + > + __u8 horizontal_scale; > + __u8 vertical_scale; > + > + __u8 version; > + __u8 prob_skip_false; > + __u8 prob_intra; > + __u8 prob_last; > + __u8 prob_gf; > + __u8 num_dct_parts; > + > + __u32 first_part_size; > + __u32 macroblock_bit_offset; > + __u32 dct_part_sizes[8]; > + > + __u64 last_frame_ts; > + __u64 golden_frame_ts; > + __u64 alt_frame_ts; > + > + __u64 flags; > +}; > + > +#endif I don't think any of my comments strictly requires a v3, could be later enhancements. You told me you wrote and ran a test for 32/64 compatibility, so I on did a light visual check. (even if you already got that from Tomasz) Reviewed-by: Nicolas Dufresne signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 00/11] Venus stateful Codec API

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 16:25 +0200, Hans Verkuil a écrit : > On 6/28/19 4:23 PM, Stanimir Varbanov wrote: > > Hi Hans, > > > > On 6/28/19 4:37 PM, Hans Verkuil wrote: > > > On 6/28/19 2:59 PM, Stanimir Varbanov wrote: > > > > Hello, > > > > > > > > Here is v2 of the Venus transition to statef

Re: [PATCH v2 00/11] Venus stateful Codec API

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 10:31 -0400, Nicolas Dufresne a écrit : > Le vendredi 28 juin 2019 à 16:25 +0200, Hans Verkuil a écrit : > > On 6/28/19 4:23 PM, Stanimir Varbanov wrote: > > > Hi Hans, > > > > > > On 6/28/19 4:37 PM, Hans Verkuil wrote: > >

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-07-19 Thread Nicolas Dufresne
Le vendredi 19 juillet 2019 à 14:45 +0900, Tomasz Figa a écrit : > On Wed, Jul 17, 2019 at 9:18 PM Nicolas Dufresne wrote: > > Hello, > > > > there is one little detail/proposal, see inline . > > > > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil

Re: [PATCH v2 0/6] [WIP]: rockchip mpp for v4l2 video deocder

2019-03-07 Thread Nicolas Dufresne
Le jeudi 07 mars 2019 à 18:03 +0800, Randy Li a écrit : > Although I really want to push those work after I added more codec > supports, but I found it is more urge to do those in v4l2 core framework and > userspace. > > I would use this driver to present the current problems, write down a > summa

Re: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12

2018-05-21 Thread Nicolas Dufresne
Le lundi 21 mai 2018 à 17:49 +0300, Ville Syrjälä a écrit : > On Mon, May 21, 2018 at 01:17:04AM +0800, Randy Li wrote: > > This pixel format is a fully packed and 10bits variant of NV12. > > A luma pixel would take 10bits in memory, without any > > filled bits between pixels in a stride. The color

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-23 Thread Nicolas Dufresne
Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : > >> Meanwhile I have found bigger obstacle - I cannot run multiple > instances > >> simultaneously. By m2m design it can execute only one job (m2m > context) > >> at a time per m2m device. Can you confirm that my observation is >

Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

2016-07-15 Thread Nicolas Dufresne
. So the reference count is incremented but > > not > > decremented for the endpoint and port nodes. > > > > Fix this by having separate pointers for each node looked up. > > > > Signed-off-by: Javier Martinez Canillas > > > > Any comments about this patch

Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

2016-07-15 Thread Nicolas Dufresne
Le vendredi 15 juillet 2016 à 12:53 -0400, Nicolas Dufresne a écrit : > Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a > écrit : > > Hello Sylwester, > > > > On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote: > > > The same struct device_

Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

2016-07-18 Thread Nicolas Dufresne
(not yet merged) implementing fallback at QBuf. Failing asynchronously would leave userspace with absolutely no way to handle the case of incompatible DMA-Buf. Regards, Nicolas p.s. I'll be away for the rest of the summer, see you in September. > > Regards, > > Hans >

Re: [PATCH 2/2] [media] s5p-g2d: Replace old driver with DRM version

2016-07-13 Thread Nicolas Dufresne
Le mardi 12 juillet 2016 à 20:02 -0300, Mauro Carvalho Chehab a écrit : > I suspect that you'll be applying this one via DRM tree, so: > > Em Tue, 24 May 2016 15:28:13 +0200 > Krzysztof Kozlowski escreveu: > > > Remove the old non-DRM driver because it is now entirely supported > by > > exynos_d

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-13 Thread Nicolas Dufresne
Le mercredi 13 juillet 2016 à 10:00 +0800, tiffany lin a écrit : > Hi Nicolas, > > On Tue, 2016-07-12 at 15:14 -0400, Nicolas Dufresne wrote: > > Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : > > > Le mardi 12 juillet 2016 à 16:16 +0800, W

  1   2   3   >