Re: [patch] mm: fix PageUptodate data race

2008-01-31 Thread Nick Piggin
Sorry, way behind on email here. I'll get through it slowly... On Sat, Jan 26, 2008 at 10:03:56PM -0800, Andrew Morton wrote: > > On Tue, 22 Jan 2008 05:01:14 +0100 Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > After running SetPageUptodate, preceeding s

Re: x86 arch updates also broke s390

2008-01-31 Thread Nick Piggin
On Thu, Jan 31, 2008 at 11:24:54AM +0100, Ingo Molnar wrote: > > * Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > > On Thu, 2008-01-31 at 02:33 +0200, Adrian Bunk wrote: > > > <-- snip --> > > > > > > ... > > > CC arch/s390/kernel/asm-offsets.s > > > In file included from > > > /hom

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-02-01 Thread Nick Piggin
On Friday 01 February 2008 09:45, Frederik Himpe wrote: > On ma, 2008-01-28 at 12:46 +1100, Nick Piggin wrote: > > On Sunday 27 January 2008 00:29, Frederik Himpe wrote: > > > On di, 2008-01-22 at 16:25 +1100, Nick Piggin wrote: > > > > > > On Tuesday 22 Janu

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Nick Piggin
On Friday 01 February 2008 21:31, Jens Axboe wrote: > On Fri, Feb 01 2008, Jens Axboe wrote: > > I think the right solution is to remove swap_io_context() and fix the io > > context referencing in as-iosched.c instead. > > IOW, the below. I don't know why Nick originally wanted to swap io > contex

Re: Feature Removals for 2.6.25

2008-02-01 Thread Nick Piggin
s used by a lot of drivers, and doesn't cost much to > maintain. > Who: Nick Piggin <[EMAIL PROTECTED]> Well the in-kernel callers have not all been converted yet. I have actually done the work, but it needs testing and merging by maintainers. Getting it done during this me

Re: [PATCH 3/3] uio: vm_operations_struct ->nopage to ->fault method conversion

2008-02-02 Thread Nick Piggin
On Saturday 02 February 2008 20:51, Denis Cheng wrote: > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Thanks, but already patched in -mm. > --- > drivers/uio/uio.c | 19 --- > 1 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/uio/uio.c b/drivers/uio/u

Re: [rfc] direct IO submission and completion scalability issues

2008-02-03 Thread Nick Piggin
On Fri, Jul 27, 2007 at 06:21:28PM -0700, Suresh B wrote: > > Second experiment which we did was migrating the IO submission to the > IO completion cpu. Instead of submitting the IO on the same cpu where the > request arrived, in this experiment the IO submission gets migrated to the > cpu that i

Re: [rfc] direct IO submission and completion scalability issues

2008-02-03 Thread Nick Piggin
On Sun, Feb 03, 2008 at 12:53:02PM +0200, Pekka Enberg wrote: > Hi Nick, > > On Feb 3, 2008 11:52 AM, Nick Piggin <[EMAIL PROTECTED]> wrote: > > +asmlinkage void smp_call_function_fast_interrupt(void) > > +{ > > [snip] > > > + while (!list_

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Nick Piggin
On Mon, Feb 04, 2008 at 03:40:20PM +1100, David Chinner wrote: > On Sun, Feb 03, 2008 at 08:14:45PM -0800, Arjan van de Ven wrote: > > David Chinner wrote: > > >Hi Nick, > > > > > >When Matthew was describing this work at an LCA presentation (not > > >sure whether you were at that presentation or n

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Nick Piggin
On Mon, Feb 04, 2008 at 11:12:44AM +0100, Jens Axboe wrote: > On Sun, Feb 03 2008, Nick Piggin wrote: > > On Fri, Jul 27, 2007 at 06:21:28PM -0700, Suresh B wrote: > > > > Hi guys, > > > > Just had another way we might do this. Migrate the completions out to &g

Re: Monthly md check == hung machine; how do I debug?

2008-02-04 Thread Nick Piggin
On Monday 04 February 2008 08:21, Robin Lee Powell wrote: > I've got a machine with a 4 disk SATA raid10 configuration using md. > The entire disk is loop-AES encrypted, but that shouldn't matter > here. > > Once a month, Debian runs: > > /usr/share/mdadm/checkarray --cron --all --quiet > > and

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-02-04 Thread Nick Piggin
On Tuesday 05 February 2008 01:49, Mike Galbraith wrote: > On Tue, 2008-01-22 at 06:47 +0100, Mike Galbraith wrote: > > On Tue, 2008-01-22 at 16:25 +1100, Nick Piggin wrote: > > > On Tuesday 22 January 2008 16:03, Mike Galbraith wrote: > > > > I've hit sa

Re: [git pull] SLUB updates for 2.6.25

2008-02-04 Thread Nick Piggin
On Tuesday 05 February 2008 10:47, Christoph Lameter wrote: > On Tue, 5 Feb 2008, Nick Piggin wrote: > > > erk, sorry, I misremembered. I was about to merge all the patches we > > > weren't going to merge. oops. > > > > While you're there, can you

Re: [git pull] SLUB updates for 2.6.25

2008-02-04 Thread Nick Piggin
On Tuesday 05 February 2008 09:30, Andrew Morton wrote: > On Mon, 4 Feb 2008 14:28:45 -0800 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > root (1): > > > SLUB: Do not upset lockdep > > > > err, what? I though I was going to merge these: > > > > slub-move-count_partial.patch > > slub-ren

Re: [git pull] SLUB updates for 2.6.25

2008-02-04 Thread Nick Piggin
On Tuesday 05 February 2008 11:32, Christoph Lameter wrote: > On Tue, 5 Feb 2008, Nick Piggin wrote: > > Ok. But the approach is just not so good. If you _really_ need something > > like that and it is a win over the regular non-atomic unlock, then you > > just have to impl

Re: [git pull for -mm] CPU isolation extensions (updated2)

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 15:10, Max Krasnyansky wrote: > Rusty - Stop machine. >After doing a bunch of testing last three days I actually downgraded > stop machine changes from [highly experimental] to simply [experimental]. > Pleas see this thread for more info: > http://marc.info/?l=linux

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 14:16, Robert Hancock wrote: > Nick Piggin wrote: > > On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: > >> Avoid buffer overflows in get_user_pages() > >> > >> So I spent a while pounding my head against my monitor tr

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: > Avoid buffer overflows in get_user_pages() > > So I spent a while pounding my head against my monitor trying to figure > out the vmsplice() vulnerability - how could a failure to check for > *read* access turn into a root exploit? It turn

Re: 2.6.24-sha1: RIP [] iov_iter_advance+0x38/0x70

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 09:27, Alexey Dobriyan wrote: > On Tue, Feb 12, 2008 at 02:04:30PM -0800, Andrew Morton wrote: > > On Sun, 10 Feb 2008 17:00:31 +0300 > > > > Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > This happened during LTP. FWIW, modprobe/rmmod trivial empty module > > > toge

Re: Kernel BUG at fs/mpage.c:489

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 08:50, Alan Cox wrote: > > Feb 12 19:55:08 butterfly kernel: hde: dma timeout error: status=0xd0 { > > Busy } Feb 12 19:55:08 butterfly kernel: ide: failed opcode was: unknown > > Your drive stopped responding. > > > Feb 12 19:55:08 butterfly kernel: hde: DMA disabled

Re: 2.6.24-sha1: RIP [] iov_iter_advance+0x38/0x70

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 11:17, Nick Piggin wrote: > On Wednesday 13 February 2008 09:27, Alexey Dobriyan wrote: > > It's a trivial dumb module which does nothing but loads and unloads. > > I redid ftest03 later without any suspicious activity and it oopsed the > >

Re: [git pull for -mm] CPU isolation extensions (updated2)

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 14:32, Max Krasnyansky wrote: > David Miller wrote: > > From: Nick Piggin <[EMAIL PROTECTED]> > > Date: Tue, 12 Feb 2008 17:41:21 +1100 > > > >> stop machine is used for more than just module loading and unloading. > &

Re: [ALPHA] ES40 fails to boot with >=kernel 2.6.23

2008-02-12 Thread Nick Piggin
On Tuesday 12 February 2008 04:27, Raúl Porcel wrote: > Hi, > > We have a Compaq AlphaServer ES40 and since 2.6.23 it won't boot. I'm > attaching the console log and the kernel config. > > Need to say that with a DEC Xp1000 it works fine, although they're > different machines, of course. > With .22

Re: [PATCH 2/2 resend] mm: various cleanups in get_user_pages()

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 00:10, Eugene Teo wrote: > Sorry for the repeated emails. Kindly ignore the previous resend. Please > review this instead. Thanks. I have tested this. If it is causing this much problems, can you split the cleanups into their own patches. > [PATCH 2/2] mm: various c

Re: [git pull for -mm] CPU isolation extensions (updated2)

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 17:06, Max Krasnyansky wrote: > Nick Piggin wrote: > > But don't let me dissuade you from making these good improvements > > to Linux as well :) Just that it isn't really going to be hard-rt > > in general. > > Actually that'

Re: Kernel BUG at fs/mpage.c:489

2008-02-13 Thread Nick Piggin
On Wednesday 13 February 2008 20:01, Andrew Morton wrote: > On Wed, 13 Feb 2008 08:26:27 +0100 Bart Dopheide <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13, 2008 at 12:05:45PM +1100, Nick Piggin wrote: > > :)On Wednesday 13 February 2008 08:50, Alan Cox wrote: > > :)&g

Re: Kernel BUG at fs/mpage.c:489

2008-02-13 Thread Nick Piggin
On Wednesday 13 February 2008 20:32, Andrew Morton wrote: > On Wed, 13 Feb 2008 20:24:03 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: > > BTW is it really true that the buffer can never be locked by > > anything else at this point? > > It has been for the past five o

Re: [patch 3/6] mmu_notifier: invalidate_page callbacks

2008-02-17 Thread Nick Piggin
On Saturday 16 February 2008 14:37, Andrew Morton wrote: > On Thu, 14 Feb 2008 22:49:02 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > > Two callbacks to remove individual pages as done in rmap code > > > > invalidate_page() > > > > Called from the inner loop of rmap walks to invalidate

Re: LatencyTOP: sync_page description

2008-02-17 Thread Nick Piggin
On Saturday 16 February 2008 08:56, Török Edwin wrote: > Hi Arjan, > > LatencyTOP says that sync_page is 'Writing a page to disk', however > I see that even when no writes are involved, such as during a > readdir, lseek, etc. > Naming it a write is misleading, as no program is running that is > doi

Re: IO queueing and complete affinity w/ threads: Some results

2008-02-18 Thread Nick Piggin
On Mon, Feb 18, 2008 at 02:33:17PM +0100, Andi Kleen wrote: > Jens Axboe <[EMAIL PROTECTED]> writes: > > > and that scrapping the remote > > softirq trigger stuff is sanest. > > I actually liked Nick's queued smp_function_call_single() patch. So even > if it was not used for block I would still l

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-18 Thread Nick Piggin
On Tuesday 19 February 2008 01:39, Andi Kleen wrote: > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > you have more faith in the authors knowledge of how his code actually > > behaves than I think is warranted :) > > iirc there was a mm patch some time ago to keep track of the actual > unlikely

Re: 2.6.24-sha1: RIP [] iov_iter_advance+0x38/0x70

2008-02-18 Thread Nick Piggin
On Wednesday 13 February 2008 09:27, Alexey Dobriyan wrote: > On Tue, Feb 12, 2008 at 02:04:30PM -0800, Andrew Morton wrote: > > > [ 4057.31] Pid: 7035, comm: ftest03 Not tainted > > > 2.6.24-25f666300625d894ebe04bac2b4b3aadb907c861 #2 [ 4057.31] RIP: > > > 0010:[] [] > > > iov_iter_advan

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-18 Thread Nick Piggin
On Tuesday 19 February 2008 13:40, Arjan van de Ven wrote: > On Tue, 19 Feb 2008 13:33:53 +1100 > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > Actually one thing I don't like about gcc is that I think it still > > emits cmovs for likely/unlikely branches, which

Re: [PATCH, RFC] kthread: (possibly) a missing memory barrier in kthread_stop()

2008-02-18 Thread Nick Piggin
On Tuesday 19 February 2008 10:03, Dmitry Adamushko wrote: > Hi, > > > [ description ] > > Subject: kthread: add a memory barrier to kthread_stop() > > 'kthread' threads do a check in the following order: > - set_current_state(TASK_INTERRUPTIBLE); > - kthread_should_stop(); > > and set_current_stat

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-18 Thread Nick Piggin
On Tuesday 19 February 2008 16:58, Willy Tarreau wrote: > On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > > > Note in particular the last predictors; assuming branch ending > > > with goto, including call, causing early function return or > > > retur

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-19 Thread Nick Piggin
On Tuesday 19 February 2008 16:44, KOSAKI Motohiro wrote: > background > > current VM implementation doesn't has limit of # of parallel reclaim. > when heavy workload, it bring to 2 bad things > - heavy lock contention > - unnecessary swap out > > abount

[patch] my mmu notifier sample driver

2008-02-19 Thread Nick Piggin
Index: linux-2.6/drivers/char/mmu_notifier_skel.c === --- /dev/null +++ linux-2.6/drivers/char/mmu_notifier_skel.c @@ -0,0 +1,255 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#

[patch] my mmu notifiers

2008-02-19 Thread Nick Piggin
Well I started reviewing the mmu notifier code, but it is kind of hard to know what you're talking about just by reading through code and not trying your suggestions for yourself... So I implemented mmu notifiers slightly differently. Andrea's mmu notifiers are rather similar. However I have tried

Re: [patch 3/6] mmu_notifier: invalidate_page callbacks

2008-02-19 Thread Nick Piggin
On Sunday 17 February 2008 06:22, Christoph Lameter wrote: > On Fri, 15 Feb 2008, Andrew Morton wrote: > > > flush_cache_page(vma, address, pte_pfn(*pte)); > > > entry = ptep_clear_flush(vma, address, pte); > > > + mmu_notifier(invalidate_page, mm, address); > > > > I j

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Nick Piggin
On Tuesday 19 February 2008 20:25, Andi Kleen wrote: > On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > > I actually once measured context switching performance in the scheduler, > > and removing the unlikely hint for testing RT tasks IIRC gave about 5% > > per

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Nick Piggin
On Friday 15 February 2008 17:49, Christoph Lameter wrote: > The invalidation of address ranges in a mm_struct needs to be > performed when pages are removed or permissions etc change. > > If invalidate_range_begin() is called with locks held then we > pass a flag into invalidate_range() to indicat

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Nick Piggin
On Tuesday 19 February 2008 20:57, Andi Kleen wrote: > On Tue, Feb 19, 2008 at 08:46:46PM +1100, Nick Piggin wrote: > > I think it was just a simple context switch benchmark, but not lmbench > > (which I found to be a bit too variable). But it was a long time ago... > >

Re: [patch] my mmu notifiers

2008-02-19 Thread Nick Piggin
On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > On Tue, Feb 19, 2008 at 09:43:57AM +0100, Nick Piggin wrote: > > are rather similar. However I have tried to make a point of minimising the > > impact the the core mm/. I don't see why we need to invalidate

Re: [patch] my mmu notifiers

2008-02-19 Thread Nick Piggin
On Tue, Feb 19, 2008 at 08:27:25AM -0600, Jack Steiner wrote: > > On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > > > understand the need for invalidate_begin/invalidate_end pairs at all. > > > > The need of the pairs is crystal clear to me: range_begin is needed > > for GRU _b

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Nick Piggin
On Friday 15 February 2008 17:49, Christoph Lameter wrote: > The invalidation of address ranges in a mm_struct needs to be > performed when pages are removed or permissions etc change. > > If invalidate_range_begin() is called with locks held then we > pass a flag into invalidate_range() to indicat

Re: [patch] my mmu notifiers

2008-02-19 Thread Nick Piggin
On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > On Tue, Feb 19, 2008 at 09:43:57AM +0100, Nick Piggin wrote: > > anything when changing the pte to be _more_ permissive, and I don't > > Note that in my patch the invalidate_pages in mprotect can be >

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-19 Thread Nick Piggin
On Friday 15 February 2008 17:49, Christoph Lameter wrote: > These special additional callbacks are required because XPmem (and likely > other mechanisms) do use their own rmap (multiple processes on a series > of remote Linux instances may be accessing the memory of a process). > F.e. XPmem may ha

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Nick Piggin
On Wednesday 20 February 2008 14:00, Robin Holt wrote: > On Wed, Feb 20, 2008 at 02:00:38AM +0100, Andrea Arcangeli wrote: > > On Wed, Feb 20, 2008 at 10:08:49AM +1100, Nick Piggin wrote: > > > Also, how to you resolve the case where you are not allowed to sleep? > > >

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-19 Thread Nick Piggin
On Wednesday 20 February 2008 14:12, Robin Holt wrote: > For XPMEM, we do not currently allow file backed > mapping pages from being exported so we should never reach this condition. > It has been an issue since day 1. We have operated with that assumption > for 6 years and have not had issues wit

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-20 Thread Nick Piggin
On Wednesday 20 February 2008 20:00, Robin Holt wrote: > On Wed, Feb 20, 2008 at 02:51:45PM +1100, Nick Piggin wrote: > > On Wednesday 20 February 2008 14:12, Robin Holt wrote: > > > For XPMEM, we do not currently allow file backed > > > mapping pages from being export

Re: [patch] my mmu notifiers

2008-02-20 Thread Nick Piggin
On Tue, Feb 19, 2008 at 05:40:50PM -0600, Jack Steiner wrote: > On Wed, Feb 20, 2008 at 12:11:57AM +0100, Nick Piggin wrote: > > On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > > > On Tue, Feb 19, 2008 at 09:43:57AM +0100, Nick Piggin wrote: > > > &

Re: [patch] my mmu notifiers

2008-02-20 Thread Nick Piggin
On Wed, Feb 20, 2008 at 02:09:41AM +0100, Andrea Arcangeli wrote: > On Wed, Feb 20, 2008 at 12:11:57AM +0100, Nick Piggin wrote: > > Sorry, I realise I still didn't get this through my head yet (and also > > have not seen your patch recently). So I don't know exact

Re: [PATCH] mmu notifiers #v6

2008-02-20 Thread Nick Piggin
On Wed, Feb 20, 2008 at 11:39:42AM +0100, Andrea Arcangeli wrote: > Given Nick's comments I ported my version of the mmu notifiers to > latest mainline. There are no known bugs AFIK and it's obviously safe > (nothing is allowed to schedule inside rcu_read_lock taken by > mmu_notifier() with my patc

Re: [PATCH] mmu notifiers #v6

2008-02-20 Thread Nick Piggin
On Wed, Feb 20, 2008 at 01:03:24PM +0100, Andrea Arcangeli wrote: > If there's agreement that the VM should alter its locking from > spinlock to mutex for its own good, then Christoph's > one-config-option-fits-all becomes a lot more appealing (replacing RCU > with a mutex in the mmu notifier list

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread Nick Piggin
On Wednesday 20 February 2008 23:52, Balbir Singh wrote: > Andi Kleen wrote: > > Document huge memory/cache overhead of memory controller in Kconfig > > > > I was a little surprised that 2.6.25-rc* increased struct page for the > > memory controller. At least on many x86-64 machines it will not fi

Re: [git pull] more SLUB updates for 2.6.25

2008-02-07 Thread Nick Piggin
On Friday 08 February 2008 13:13, Christoph Lameter wrote: > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/christoph/vm.git slub-linus > > (includes the cmpxchg_local fastpath since the cmpxchg_local work > by Matheiu is in now, and the non atomic unloc

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-07 Thread Nick Piggin
On Thu, Feb 07, 2008 at 07:25:45PM +0100, Jens Axboe wrote: > Hi, > > Here's a variant using kernel threads only, the nasty arch bits are then > not needed. Works for me, no performance testing (that's a hint for Alan > to try and queue up some testing for this variant as well :-) Well this stuff

Re: [rfc] direct IO submission and completion scalability issues

2008-02-07 Thread Nick Piggin
On Tue, Feb 05, 2008 at 11:14:19AM +1100, David Chinner wrote: > On Mon, Feb 04, 2008 at 11:09:59AM +0100, Nick Piggin wrote: > > You get better behaviour in the slab and page allocators and locality > > and cache hotness of memory. For example, I guess in a filesystem / >

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-07 Thread Nick Piggin
On Fri, Feb 08, 2008 at 08:47:47AM +0100, Jens Axboe wrote: > On Fri, Feb 08 2008, Nick Piggin wrote: > > On Thu, Feb 07, 2008 at 07:25:45PM +0100, Jens Axboe wrote: > > > Hi, > > > > > > Here's a variant using kernel threads only, the nasty arch bits ar

Re: [git pull] more SLUB updates for 2.6.25

2008-02-08 Thread Nick Piggin
On Friday 08 February 2008 18:29, Eric Dumazet wrote: > Nick Piggin a écrit : > > On Friday 08 February 2008 13:13, Christoph Lameter wrote: > >> are available in the git repository at: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/christoph/vm.git

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 08:59:55AM +0100, Jens Axboe wrote: > On Fri, Feb 08 2008, Nick Piggin wrote: > > And if you don't? > > Well if you don't ask for anything, you wont get anything :-) > As I mentioned, the patch is a playing ground for trying various setups. >

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 09:24:22AM +0100, Jens Axboe wrote: > On Fri, Feb 08 2008, Nick Piggin wrote: > > On Fri, Feb 08, 2008 at 08:59:55AM +0100, Jens Axboe wrote: > > > On Fri, Feb 08 2008, Nick Piggin wrote: > > > > And if you don't? > > > > &

Re: [patch] block layer: kmemcheck fixes

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 07:09:07AM -0800, Arjan van de Ven wrote: > David Miller wrote: > >From: Linus Torvalds <[EMAIL PROTECTED]> > >Date: Thu, 7 Feb 2008 09:42:56 -0800 (PST) > > > >>Can we please just stop doing these one-by-one assignments, and just do > >>something like > >> > >>memset(r

Re: [patch] block layer: kmemcheck fixes

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 02:56:09PM -0800, Arjan van de Ven wrote: > Nick Piggin wrote: > >>>Maybe cpus these days have so much store bandwith that doing > >>>things like the above is OK, but I doubt it :-) > >>on modern x86 cpus the memset may even be fast

Re: Oops report for the week upto Feb 10th 2008

2008-02-10 Thread Nick Piggin
On Monday 11 February 2008 11:35, Arjan van de Ven wrote: > The http://www.kerneloops.org website collects kernel oops and > warning reports from various mailing lists and bugzillas as well as > with a client users can install to auto-submit oopses. > Below is a top 10 list of the oopses/backtraces

Re: [PATCH] alloc_percpu() fails to allocate percpu data

2008-02-23 Thread Nick Piggin
On Friday 22 February 2008 09:26, Peter Zijlstra wrote: > On Thu, 2008-02-21 at 19:00 +0100, Eric Dumazet wrote: > > Some oprofile results obtained while using tbench on a 2x2 cpu machine > > were very surprising. > > > > For example, loopback_xmit() function was using high number of cpu > > cycles

Re: 2.6.24-sha1: RIP [] iov_iter_advance+0x38/0x70

2008-02-25 Thread Nick Piggin
On Wednesday 20 February 2008 09:01, Alexey Dobriyan wrote: > On Tue, Feb 19, 2008 at 11:47:11PM +0300, wrote: > > > Are you reproducing it simply by running the > > > ftest03 binary directly from the shell? How many times between oopses? > > > It is multi-process but no threads, so races should

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-25 Thread Nick Piggin
On Thursday 21 February 2008 21:58, Robin Holt wrote: > On Thu, Feb 21, 2008 at 03:20:02PM +1100, Nick Piggin wrote: > > > > So why can't you export a device from your xpmem driver, which > > > > can be mmap()ed to give out "anonymous" memory pages

Re: Proposal for "proper" durable fsync() and fdatasync()

2008-02-26 Thread Nick Piggin
On Tuesday 26 February 2008 18:59, Jamie Lokier wrote: > Andrew Morton wrote: > > On Tue, 26 Feb 2008 07:26:50 + Jamie Lokier <[EMAIL PROTECTED]> wrote: > > > (It would be nicer if sync_file_range() > > > took a vector of ranges for better elevator scheduling, but let's > > > ignore that :-) >

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread Nick Piggin
On Tuesday 26 February 2008 18:21, Gleb Natapov wrote: > On Tue, Feb 26, 2008 at 05:11:32PM +1100, Nick Piggin wrote: > > > You are missing one point here. The MPI specifications that have > > > been out there for decades do not require the process use a library > >

Re: oops when using git gc --auto

2008-02-26 Thread Nick Piggin
On Wednesday 27 February 2008 00:22, Otavio Salvador wrote: > Hello, > > Today I got this oops, someone has an idea of what's going wrong? > > Unable to handle kernel paging request at 0200 RIP: > [] find_get_pages+0x3c/0x69 At this point, the most likely candidate is a memory corrupt

Re: unfair stress on non memory allocating apps while swapout (in 2.4)

2000-10-21 Thread Nick Piggin
> why are programs which do not allocate memory be delayed while one > program is eating up all memory. This clearly means they are not delayed in > the malloc call but simply the kernel will not schedule them while he is bussy > to page out processes. Bernd, The reason why programs not allocatin

Topic for discussion: OS Design

2000-10-22 Thread Nick Piggin
> So what we really need to do is get some custom "RAM blitter" into our > hardware to do the memory copies needed for fast context switching and > message passing. don't you think you should quit while you're behind? > Too bad nobody on this list works at an electronics design company... ;-P

Re: Linux's implementation of poll() not scalable?

2000-10-23 Thread Nick Piggin
> I'm trying to write a server that handles 1 clients. On 2.4.x, > the RT signal queue stuff looks like the way to achieve that. I would suggest you try multiple polling threads. Not only will you get better SMP scalability, if you have say 16 threads, each one only has to handle ~ 600 fds.

2.4.0-test9 Oopses

2000-10-25 Thread Nick Piggin
Did the following with 2.4.0-test9 + reiserfs 3.6.18 (all ext2 filesystem, however) and all ide block devices. scsi0 : SCSI host adapter emulation for IDE ATAPI devices Vendor: RICOH Model: CD-R/RW MP7060A Rev: 1.50 Type: CD-ROM ANSI SCSI revision: 02 Vendor: A

[patch] BSD process accounting: new locking

2000-10-29 Thread Nick Piggin
I have attached a very small patch (test9) to remove the kernel lock from kernel/acct.c. If I am missing something major (a brain?), I apologise in advance. I have tested this on my UP x86 with spinlock debugging. I would appreciate comments or an explanation of why this can't be done if you have

Re: [patch] BSD process accounting: new locking

2000-10-29 Thread Nick Piggin
> I have attached a very small patch (test9) to remove the kernel lock from > kernel/acct.c. If I am missing something major (a brain?), I apologise in > advance. I have tested this on my UP x86 with spinlock debugging. I would > appreciate comments or an explanation of why this can't be done if y

test9 oops (in block_read_full_page)

2000-10-29 Thread Nick Piggin
I apologise if this oops has already been fixed: it has happened twice but I can't find the exact way to trigger it, I just want to make sure it is reported ;) Nick oops

Re: 2.4.0-test9 Oopses

2000-11-02 Thread Nick Piggin
x27;) { in fs/namei.c: __vfs_follow_link to oops. The oops is due to trying to follow an sg? link in /dev. Nick. - Original Message ----- From: "Nick Piggin" <[EMAIL PROTECTED]> To: "Linux-Kernel" <[EMAIL PROTECTED]> Sent: Wednesday, October 25, 2000 9:16

2.4.0-test10 oopses (bug in devfs)

2000-11-04 Thread Nick Piggin
> > ----- Original Message - > From: "Nick Piggin" <[EMAIL PROTECTED]> > To: "Linux-Kernel" <[EMAIL PROTECTED]> > Sent: Wednesday, October 25, 2000 9:16 PM > Subject: 2.4.0-test9 Oopses > > > > Did the following with 2.4.0-test9 + r

bkl usage

2000-11-12 Thread Nick Piggin
Hi. In my efforts to understand the linux kernel v2.4 I found the bkl being used in kernel/acct.c to lock seemingly local data. Would someone please explain what races this prevents vs. say: --- linux/kernel/acct.c Mon Oct 30 01:02:56 2000 +++ linux-2.4.0-test10/kernel/acct.c Mon Oct 30 01:10:20

Re: 2.6.12-rc2-mm1

2005-04-05 Thread Nick Piggin
Andrew Morton wrote: +sched-remove-unnecessary-sched-domains.patch +sched-improve-pinned-task-handling-again.patch [snip] CPU scheduler updates It is no problem that you picked these up for testing. But don't merge them yet, please. Suresh's underlying problem with the unnecessary sched domains is

Re: 2.6.12-rc2-mm1

2005-04-05 Thread Nick Piggin
Siddha, Suresh B wrote: On Tue, Apr 05, 2005 at 05:33:49PM +1000, Nick Piggin wrote: Suresh's underlying problem with the unnecessary sched domains is a failing of sched-balance-exec and sched-balance-fork, which That wasn't the only motivation. For example, on non-HT cpu's

[patch 1/5] sched: remove degenerate domains

2005-04-05 Thread Nick Piggin
kickin and correct it. In general, this patch also makes sense with out recent Nick's fixes in -mm. Signed-off-by: Suresh Siddha <[EMAIL PROTECTED]> Modified to account for more than just sched_groups when scanning for degenerate domains by Nick Piggin. Allow a runqueue's sd to go

[patch 2/5] sched: NULL domains

2005-04-05 Thread Nick Piggin
2/5 The previous patch fixed the last 2 places that directly access a runqueue's sched-domain and assume it cannot be NULL. We can now use a NULL domain instead of a dummy domain to signify no balancing is to happen. No functional changes. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]

[patch 3/5] sched: multilevel sbe and sbf

2005-04-05 Thread Nick Piggin
multilevel NUMA that ia64 is already using. This patch makes balance on fork and exec try balancing over not just the top most domain with the flag set, but all the way down the domain tree. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index: linux-2.6/kernel/s

[patch 4/5] sched: RCU sched domains

2005-04-05 Thread Nick Piggin
balance-on-exec had to potentially migrate between more than one CPU before finding a final CPU to migrate to, and balance-on-fork needed to potentially take multiple runqueue locks. So bite the bullet and make sched-domains go completely RCU. This actually simplifies the code quite a bit. Signed-of

[patch 5/5] sched: consolidate sbe sbf

2005-04-05 Thread Nick Piggin
be unlocked during balance-on-fork. schedstats is a problem. Maybe just have balance-on-event instead of distinguishing fork and exec? Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index: linux-2.6/kernel/sched.c === --- lin

Re: [patch 1/5] sched: remove degenerate domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: This is Suresh's patch with some modifications. Remove degenerate scheduler domains during the sched-domain init. actually, i'd suggest to not do this patch. The point of booting with a CONFIG_NUMA kernel on a non-NU

Re: [patch 2/5] sched: NULL domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Ingo Molnar <[EMAIL PROTECTED]> wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: 2/5 The previous patch fixed the last 2 places that directly access a runqueue's sched-domain and assume it cannot be NULL. We can now use a NULL domain instead of a dummy dom

Re: [patch 3/5] sched: multilevel sbe and sbf

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: Acked-by: Ingo Molnar <[EMAIL PROTECTED]> note that no matter how much scheduler logic, in the end cross-scheduling of tasks between nodes on NUMA will always have a permanent penalty (i.e. the 'migration cost' is 'infinity' in the long run), so the primary focus _hast to be_

Re: [patch 4/5] sched: RCU sched domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: 4/5 One of the problems with the multilevel balance-on-fork/exec is that it needs to jump through hoops to satisfy sched-domain's locking semantics (that is, you may traverse your own domain when not preemptable, and you m

Re: [patch 5/5] sched: consolidate sbe sbf

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: 5/5 Any ideas about what to do with schedstats? Do we really need balance on exec and fork as seperate statistics? Consolidate balance-on-exec with balance-on-fork. This is made easy by the sched-domains RCU patches. As well

Re: [patch 1/5] sched: remove degenerate domains

2005-04-06 Thread Nick Piggin
Ingo Molnar wrote: * Siddha, Suresh B <[EMAIL PROTECTED]> wrote: Similarly I am working on adding a new core domain for dual-core systems! All these domains are unnecessary and cause performance isssues on non Multi-threading/Multi-core capable cpus! Agreed that performance impact will be minor

Re: [patch 5/5] sched: consolidate sbe sbf

2005-04-06 Thread Nick Piggin
Nick Piggin wrote: One problem I just noticed, sorry. This is doing set_cpus_allowed without holding the runqueue lock and without checking the hard affinity mask either. Err, that is to say set_task_cpu, not set_cpus_allowed. -- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the

Re: Coding style: mixed-case

2005-04-06 Thread Nick Piggin
Kenneth Aafløy wrote: On Wednesday 06 April 2005 04:09, Matt Mackall wrote: While there may be reasons why mixed case is suboptimal, the real reason is that it's hard to keep track of which style is used where. It's annoying and error-prone to have to remember the naming format for everything in ad

Re: return value of ptep_get_and_clear

2005-04-06 Thread Nick Piggin
Kumar Gala wrote: ptep_get_and_clear has a signature that looks something like: static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep) It appears that its suppose to return the pte_t pointed to by ptep before its modif

Re: 2.6.12-rc2-mm1

2005-04-06 Thread Nick Piggin
Siddha, Suresh B wrote: On Tue, Apr 05, 2005 at 05:33:49PM +1000, Nick Piggin wrote: Lastly, I'd like to be a bit less intrusive with pinned task handling improvements. I think we can do this while still being effective in preventing livelocks. We want to see this fixed. Please post your

[patch] sched: consolidate sbe sbf

2005-04-06 Thread Nick Piggin
asy by the sched-domains RCU patches. As well as the general goodness of code reduction, this allows the runqueues to be unlocked during balance-on-fork. schedstats is a problem. Maybe just have balance-on-event instead of distinguishing fork and exec? Signed-off-by: Nick Piggin <[EMAIL PROTE

Re: [patch 4/5] sched: RCU sched domains

2005-04-07 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: At a minimum i think we need the fix+comment below. Well if we say "this is actually RCU", then yes. And we should probably change the preempt_{dis|en}ables in other places to rcu_read_lock. OTOH, if we say we just

  1   2   3   4   5   6   7   8   9   10   >