[PATCH v3 8/8] Input: atmel_mxt_ts - add support for reference data

2016-06-01 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 58 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/drivers/input

[PATCH v3 4/8] Input: atmel_mxt_ts - output diagnostic debug via v4l2 device

2016-06-01 Thread Nick Dyer
Register a video device to output T37 diagnostic data. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig| 2 + drivers/input/touchscreen/atmel_mxt_ts.c | 247 +++ 2 files changed, 249 insertions(+) diff --git a/drivers/input/touchscreen

[PATCH v3 1/8] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-06-01 Thread Nick Dyer
Atmel maXTouch devices have a T37 object which can be used to read raw touch deltas from the device. This consists of an array of 16-bit integers, one for each node on the touchscreen matrix. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 152

[PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L

2016-06-01 Thread Nick Dyer
This is a series of patches to add diagnostic data support to the Atmel maXTouch driver. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. There are significant performance advantages to putting this code into th

[PATCH v3 3/8] [media] v4l2-core: Add VFL_TYPE_TOUCH_SENSOR

2016-06-01 Thread Nick Dyer
Some touch controllers send out raw touch data in a similar way to a greyscale frame grabber. Add a new device type for these devices. Use a new device prefix v4l-touch for these devices, to stop generic capture software from treating them as webcams. Signed-off-by: Nick Dyer --- drivers/input

[PATCH v3 6/8] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-06-01 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L

2016-06-02 Thread Nick Dyer
Hi Dmitry- On 01/06/2016 19:17, Dmitry Torokhov wrote: > On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >> This is a series of patches to add diagnostic data support to the Atmel >> maXTouch driver. It's a rewrite of the previous implementation which output >&

[PATCH v3] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-26 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer [Tested successfully on S7817 and S7300

Re: [PATCH v3 00/18] Synaptics RMI4 and SMBus implementation

2016-11-07 Thread Nick Dyer
mi4 - f30/f03: Forward mechanical buttons on > > buttonpads to PS/2 guest > > Input: synaptics - allocate a Synaptics Intertouch device > > Input: synaptics-rmi4 - add rmi_platform > > Input: synaptics-rmi4 - smbus: call psmouse_deactivate before > > binding/resume > > Inp

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-12 Thread Nick Dyer
Hi Benjamin- Thanks for the review, I've answered in line. On Mon, Oct 10, 2016 at 03:48:07PM +0200, Benjamin Tissoires wrote: > On Sep 20 2016 or thereabouts, Nick Dyer wrote: > > Signed-off-by: Nick Dyer > > Tested-by: Chris Healy > > --- > > drive

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-13 Thread Nick Dyer
On Thu, Oct 13, 2016 at 03:52:45PM +0200, Benjamin Tissoires wrote: > > > You could basically export rmi_fn_reset() which would call > > > rmi_free_function_list(), rmi_scan_pdt (if initial reset), > > > rmi_probe_interrupts() and rmi_init_functions, and this would allow you > > > to have all this

Re: [PATCH v2 2/2] Input: synaptics-rmi4 - Propagate correct number of rx and tx electrodes to F54

2016-11-15 Thread Nick Dyer
F54 to avoid > corrupted output if not all electrodes are enabled. > > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 > ...") > Cc: Nick Dyer > Cc: Andrew Duggan > Cc: Chris Healy > Signed-off-by: Guenter Roeck Tested-by: Nick Dye

Re: [PATCH v2 1/2] Input: synaptics-rmi4 - add support for F55 sensor tuning

2016-11-15 Thread Nick Dyer
: synaptics-rmi4 - add support for F54 > ...") > Signed-off-by: Guenter Roeck Hi Guenter- I've tested this patch on s7813 and it works correctly. Tested-by: Nick Dyer > --- > v2: Drop unnecessary include files > Only read required number of query elements > Ad

Re: [-next, 1/2] Input: synaptics-rmi4 - add support for F55 sensor tuning

2016-10-20 Thread Nick Dyer
On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote: > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote: > > Sensor tuning support is needed to determine the number of enabled > > tx and rx electrodes for use in F54 functions. > > > > The number of enabled electrodes is not

[PATCH v5 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer Signed-off-by: Benjamin Tissoires --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4a88312..63c9e22

[PATCH v5 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 110 4 files changed, 137 insertions(+), 3 deletions

[PATCH v5 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers

[PATCH v5 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-24 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3

[PATCH v5 0/7] Input: synaptics-rmi4 - F34 device reflash support

2016-10-24 Thread Nick Dyer
Hi- Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v5: - Improve split between for different versions (req. Bjorn Andersson) - Address a couple of kbuild test robot issues - Fix a bug with configuration ID on V7 Changes in v4: - Add support for v7 bootload

[PATCH v5 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-24 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f34v7.c | 14

[PATCH v5 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-24 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi_f34.c| 53 +- drivers

[PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers

[PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to be specified

2016-10-24 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. Add a device tree property which can be set to force reading the first N pages. Signed-off-by: Nick Dyer --- Documentation/devicetree/bindings/input/rmi4/rmi_i2c.txt | 2

[PATCH v2] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-25 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 16

[PATCH v8] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-04 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- Hi Dmitry- Thanks for the useful review, here is an updated version. This patch applies on top of dtor

[PATCH] Input: synaptics-rmi4 - fix debug for sensor clip

2016-12-04 Thread Nick Dyer
The debug would only ever output zero for the clip information. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f12.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c index 8c5360c..e35c64b 100644 --- a

[PATCH v7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-11-29 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- Hi Dmitry- Here's an updated version of the F34 V7 support. This patch applies on top of dtor/synaptics

[PATCH v6 0/2] Input: synaptics-rmi4 - F34 device reflash support

2016-11-20 Thread Nick Dyer
Hi Dmitry- Please find an updated set of patches to add F34 firmware update to the RMI4 driver. Changes in v6: - Properly free irq_memory in rmi_free_function_list() - Split out the sysfs changes for now - Various coding style improvements to the V7 patch (now checkpatch clean) Changes in v5: -

[PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-11-20 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3

[PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-11-20 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi_f34

Re: [PATCH v8] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-10 Thread Nick Dyer
On Wed, Dec 07, 2016 at 06:14:18PM -0800, Dmitry Torokhov wrote: > On Mon, Dec 05, 2016 at 01:02:49AM +0000, Nick Dyer wrote: > > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data > > *f34, > > +

[PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-10 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- Changes in v9: - Fix strangeness introduced in conversion to proper le32_to_cpu() APIs - Various other minor

Re: [PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-11 Thread Nick Dyer
On Sun, Dec 11, 2016 at 12:03:49AM -0800, Dmitry Torokhov wrote: > On Sun, Dec 11, 2016 at 12:18:26AM +0000, Nick Dyer wrote: > > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data > > *f34, > > +

Re: Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-14 Thread Nick Dyer
On Mon, Mar 13, 2017 at 10:10:22PM -0700, Cameron Gutman wrote: > > Compared to hid-multitouch, the RMI stack seems to have > > completely broken palm rejection and introduced some random > > jumpiness during fine pointing motions. I don't know if these > > issues are caused by the

[PATCH v4 9/9] Input: synaptics-rmi4 - add support for F54 diagnostics

2016-06-17 Thread Nick Dyer
Function 54 implements access to various RMI4 diagnostic features. This patch adds support for retrieving this data. It registers a V4L2 device to output the data to user space. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1

[PATCH v4 1/9] [media] Add signed 16-bit pixel format

2016-06-17 Thread Nick Dyer
This will be used for output of raw touch delta data. This format is used by Atmel maXTouch (atmel_mxt_ts) and also Synaptics RMI4. Signed-off-by: Nick Dyer --- Documentation/DocBook/media/v4l/pixfmt-ys16.xml | 79 + Documentation/DocBook/media/v4l/pixfmt.xml | 1

[PATCH v4 3/9] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-06-17 Thread Nick Dyer
Atmel maXTouch devices have a T37 object which can be used to read raw touch deltas from the device. This consists of an array of 16-bit integers, one for each node on the touchscreen matrix. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig| 6 ++ drivers/input

[PATCH v4 2/9] [media] v4l2-core: Add VFL_TYPE_TOUCH_SENSOR

2016-06-17 Thread Nick Dyer
Some touch controllers send out raw touch data in a similar way to a greyscale frame grabber. Add a new device type for these devices. Use a new device prefix v4l-touch for these devices, to stop generic capture software from treating them as webcams. Signed-off-by: Nick Dyer --- drivers/input

[PATCH v4 7/9] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2016-06-17 Thread Nick Dyer
The mXT1386 family of chips have a different architecture which splits the diagnostic data into 3 columns. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/input

[PATCH v4 5/9] Input: atmel_mxt_ts - read touchscreen size

2016-06-17 Thread Nick Dyer
The touchscreen may have a margin where not all the matrix is used. Read the parameters from T9 and T100 and take account of the difference. Note: this does not read the XORIGIN/YORIGIN fields so it assumes that the touchscreen starts at (0,0) Signed-off-by: Nick Dyer --- drivers/input

[PATCH v4 6/9] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-06-17 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH v4 0/9] Output raw touch data via V4L2

2016-06-17 Thread Nick Dyer
This is a series of patches to add output of raw touch diagnostic data via V4L2 to the Atmel maXTouch and Synaptics RMI4 drivers. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. We have a utility which can rea

[PATCH v4 8/9] Input: atmel_mxt_ts - add support for reference data

2016-06-17 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 58 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/drivers/input

[PATCH v4 4/9] Input: atmel_mxt_ts - output diagnostic debug via v4l2 device

2016-06-17 Thread Nick Dyer
Register a video device to output T37 diagnostic data. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig| 6 +- drivers/input/touchscreen/atmel_mxt_ts.c | 244 +++ 2 files changed, 248 insertions(+), 2 deletions(-) diff --git a/drivers/input

Re: [PATCH] Input: synaptics-rmi4 - create firmware update sysfs attribute in F34

2017-02-12 Thread Nick Dyer
On Thu, Feb 09, 2017 at 01:25:08PM -0800, Dmitry Torokhov wrote: > There is no need to create sysfs attributes in the main driver core, > let F34 implementation do that. Hi Dmitry- I haven't tested this yet, but I did try creating/removing the sysfs entries in the f34 function probe/remove as you

Re: [PATCH] Input: synaptics-rmi4 - create firmware update sysfs attribute in F34

2017-02-13 Thread Nick Dyer
On Sun, Feb 12, 2017 at 04:02:51PM -0800, Dmitry Torokhov wrote: > On Sun, Feb 12, 2017 at 10:50:56PM +0000, Nick Dyer wrote: > > On Thu, Feb 09, 2017 at 01:25:08PM -0800, Dmitry Torokhov wrote: > > > There is no need to create sysfs attributes in the main driver core, > >

Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L

2016-06-13 Thread Nick Dyer
On 02/06/2016 16:14, Nick Dyer wrote: > On 01/06/2016 19:17, Dmitry Torokhov wrote: >> On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >>> This is a series of patches to add diagnostic data support to the Atmel >>> maXTouch driver. It's a rewrite of t

Re: [PATCH v5 0/9] Output raw touch data via V4L2

2016-06-27 Thread Nick Dyer
Hi Hans- Thanks for reviewing this again in such detail. On 27/06/2016 12:26, Hans Verkuil wrote: > On 06/23/2016 12:08 AM, Nick Dyer wrote: >> This is a series of patches to add output of raw touch diagnostic data via >> V4L2 >> to the Atmel maXTouch and Synaptics RMI4

Re: [PATCH v5 0/9] Output raw touch data via V4L2

2016-06-27 Thread Nick Dyer
On 27/06/2016 13:22, Hans Verkuil wrote: > On 06/27/2016 01:57 PM, Nick Dyer wrote: > 2) Alternatively, if we want to keep using BUF_TYPE_VIDEO_CAPTURE, then: > > - we keep V4L2_CAP_TOUCH which is combined with CAP_VIDEO_CAPTURE (and perhaps > VIDEO_OUTPUT in the future). The

[PATCH v6 07/11] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-06-30 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH v6 02/11] [media] v4l2-core: Add support for touch devices

2016-06-30 Thread Nick Dyer
touch data - V4L2_TCH_FMT_TU08 for unsigned 8-bit touch data This support will be used by: - Atmel maXTouch (atmel_mxt_ts) - Synaptics RMI4. - sur40 Signed-off-by: Nick Dyer --- drivers/media/media-entity.c | 2 ++ drivers/media/v4l2-core/v4l2-dev.c | 16 +--- drivers/media

[PATCH v6 08/11] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2016-06-30 Thread Nick Dyer
The mXT1386 family of chips have a different architecture which splits the diagnostic data into 3 columns. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/input

[PATCH v6 10/11] Input: synaptics-rmi4 - add support for F54 diagnostics

2016-06-30 Thread Nick Dyer
Function 54 implements access to various RMI4 diagnostic features. This patch adds support for retrieving this data. It registers a V4L2 device to output the data to user space. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1

[PATCH] v4l2-compliance: Changes to support touch sensors

2016-06-30 Thread Nick Dyer
Signed-off-by: Nick Dyer --- utils/v4l2-compliance/v4l2-compliance.cpp| 48 +++- utils/v4l2-compliance/v4l2-compliance.h | 1 + utils/v4l2-compliance/v4l2-test-input-output.cpp | 4 +- 3 files changed, 51 insertions(+), 2 deletions(-) diff --git a/utils

[PATCH v6 04/11] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-06-30 Thread Nick Dyer
Atmel maXTouch devices have a T37 object which can be used to read raw touch deltas from the device. This consists of an array of 16-bit integers, one for each node on the touchscreen matrix. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig| 6 ++ drivers/input

[PATCH v6 0/11] Output raw touch data via V4L2

2016-06-30 Thread Nick Dyer
This is a series of patches to add output of raw touch diagnostic data via V4L2 to the Atmel maXTouch and Synaptics RMI4 drivers. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. We have a utility which can rea

[PATCH v6 01/11] Input: atmel_mxt_ts - update MAINTAINERS email address

2016-06-30 Thread Nick Dyer
I'm leaving ITDev, so change to my personal email. My understanding is that someone at Atmel will take this on once their takeover by Microchip has settled down. Signed-off-by: Nick Dyer --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAIN

[PATCH v6 03/11] [media] DocBook: add support for touch devices

2016-06-30 Thread Nick Dyer
Signed-off-by: Nick Dyer --- Documentation/DocBook/media/v4l/dev-touch.xml | 51 ++ Documentation/DocBook/media/v4l/media-types.xml| 5 ++ .../DocBook/media/v4l/pixfmt-tch-td08.xml | 66 + .../DocBook/media/v4l/pixfmt-tch-td16.xml | 82

[PATCH v6 06/11] Input: atmel_mxt_ts - read touchscreen size

2016-06-30 Thread Nick Dyer
The touchscreen may have a margin where not all the matrix is used. Read the parameters from T9 and T100 and take account of the difference. Note: this does not read the XORIGIN/YORIGIN fields so it assumes that the touchscreen starts at (0,0) Signed-off-by: Nick Dyer --- drivers/input

[PATCH v6 11/11] Input: sur40 - use new V4L2 touch input type

2016-06-30 Thread Nick Dyer
Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards compatibility. Note: I have not tested these changes (I have no access to the hardware) so not signing off. --- drivers/input/touchscreen/sur40.c | 121 +++--- 1 file changed, 88 insertions(+), 33 d

[PATCH v6 09/11] Input: atmel_mxt_ts - add support for reference data

2016-06-30 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 57 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/drivers/input

[PATCH v6 05/11] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device

2016-06-30 Thread Nick Dyer
Register a video device to output T37 diagnostic data. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig| 6 +- drivers/input/touchscreen/atmel_mxt_ts.c | 244 +++ 2 files changed, 248 insertions(+), 2 deletions(-) diff --git a/drivers/input

[PATCH RFC v2 4/9] Input: atmel_mxt_ts - handle diagnostic data orientation

2015-12-24 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH RFC v2 1/9] Input: atmel_mxt_ts - improve touchscreen size/orientation handling

2015-12-24 Thread Nick Dyer
Both T100 and T9 handle range and orientation in a similar fashion. Reduce duplication between the two implementations. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 68 1 file changed, 26 insertions(+), 42 deletions(-) diff --git a

[PATCH RFC v2 3/9] Input: atmel_mxt_ts - read touchscreen position in matrix

2015-12-24 Thread Nick Dyer
The touchscreen may have a margin where not all the matrix is used. Read the parameters from T9 and T100 and take account of the difference. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 41 1 file changed, 36 insertions(+), 5 deletions

[PATCH RFC v2 5/9] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2015-12-24 Thread Nick Dyer
The mXT1386 family of chips have a different architecture which splits the diagnostic data into 3 columns. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/drivers/input

[PATCH RFC v2 2/9] Input: atmel_mxt_ts - add diagnostic data retrieval via debugfs

2015-12-24 Thread Nick Dyer
Retrieve refs data from the T37 diagnostic data object and expose it via a binary attribute in debugfs. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 208 +++ 1 file changed, 208 insertions(+) diff --git a/drivers/input/touchscreen

[PATCH RFC v2 7/9] Input: atmel_mxt_ts - add metadata to debugfs

2015-12-24 Thread Nick Dyer
Add information to debugfs to allow a generic utility to retrieve screen parameters and info. Signed-off-by: Nick Dyer --- Documentation/ABI/testing/debugfs-heatmap | 60 +++ drivers/input/touchscreen/atmel_mxt_ts.c | 48 +++-- 2 files changed

[PATCH RFC v2 9/9] Input: atmel_mxt_ts - single node diagnostic data support

2015-12-24 Thread Nick Dyer
Add support for retrieving a single node of data at high rate. --- drivers/input/touchscreen/atmel_mxt_ts.c | 60 +--- 1 file changed, 55 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c ind

[PATCH RFC v2 8/9] Input: atmel_mxt_ts - create debugfs info file

2015-12-24 Thread Nick Dyer
Add files in debugfs directory with info about the chip and input device. Signed-off-by: Nick Dyer --- Documentation/ABI/testing/debugfs-heatmap | 14 ++ drivers/input/touchscreen/atmel_mxt_ts.c | 22 ++ 2 files changed, 36 insertions(+) diff --git a

[PATCH RFC v2 6/9] Input: atmel_mxt_ts - add support for reference data

2015-12-24 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 75 +--- 1 file changed, 59 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH RFC v2 0/8] Input: atmel_mxt_ts - raw data via debugfs

2015-12-24 Thread Nick Dyer
splay this data has now been released, and you can find it at: https://github.com/ndyer/heatmap I've recorded a couple of videos of the utility in action on a Pixel 2: https://youtu.be/M0VD2gZt8Zk and https://youtu.be/nwDLB4zikzU Any feedback appreciated. Best regards Nick Dyer --

Re: [PATCH] atmel_mxt_ts: Add support for reset line

2017-06-29 Thread Nick Dyer
On Tue, Jun 27, 2017 at 06:24:38PM +0200, Sebastian Reichel wrote: > At least some of the Atmel Maxtouch touchscreen controllers have a reset > pin. If this is not driven correctly the device will be held in reset > and will not respond. > > Add support for driving the reset line via GPIO as is fo

Re: [PATCH] Input: synaptics-rmi4 - Only read the F54 query registers which are used

2017-06-22 Thread Nick Dyer
with the I2C controller or touchpad were addressed in: > commit 5b65c2a02966 ("HID: rmi: check sanity of the incoming report") > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195949 > Signed-off-by: Andrew Duggan Looks fine to me. Reviewed-by: Nick Dyer > --- &g

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

2017-05-31 Thread Nick Dyer
> Reviewed-by: Benjamin Tissoires > > Hm, I just realized taht we'd go from upper to lowercase hex digits. I > think it should be OK, but I'd like to hear interested parties (Nick). > > Or we'd need to introduce %pH I guess. Hi Dmitry- I can't see any issue wit

Re: [PATCH] Input: atmel_mxt_ts - Remove unnecessary byte_offset check

2017-10-08 Thread Nick Dyer
On Sun, Oct 08, 2017 at 07:44:18PM +0100, Christos Gkekas wrote: > Variable byte_offset is unsigned so checking whether it is greater or > equal to zero is redundant. > > Signed-off-by: Christos Gkekas Yep - looks sensible to me. Signed-off-by: Nick Dyer > --- > drivers

Re: [PATCH] input: atmel_mxt_ts: detect touchpad from devicetree

2017-10-08 Thread Nick Dyer
R_MM going to cause issues on this new device? I think you need to add this to Documentation/devicetree/bindings/input/atmel,maxtouch.txt Reviewed-by: Nick Dyer > Signed-off-by: Emil Renner Berthing > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++-- > include/linux/platfo

[PATCH v4 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers

[PATCH v4 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer Signed-off-by: Benjamin Tissoires --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4a88312..63c9e22

[PATCH v4 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers

[PATCH v4 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-18 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3

[PATCH v4 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-18 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f34v7.c | 14

[PATCH v4 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 112 4 files changed, 139 insertions(+), 3 deletions

[PATCH v4 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-18 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi_f34.c| 146

[PATCH v4 0/7]

2016-10-18 Thread Nick Dyer
Hi- Apologies, I think I hit send too soon on the previous email. Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v4: - Add support for v7 bootloaders and fix numerous issues - Add sysfs attributes for retrieving various hardware IDs - Add a couple of debug

Re: [PATCH v8 10/10] Input: sur40 - use new V4L2 touch input type

2016-08-12 Thread Nick Dyer
Signed-off-by: Nick Dyer On 12 August 2016 10:41:08 BST, Hans Verkuil wrote: >Hi Nick, > >On 07/18/2016 11:10 PM, Nick Dyer wrote: >> Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards >> compatibility. >> >> Note: I have not tested these

[PATCH v2] Documentation: add support for V4L touch devices

2016-08-14 Thread Nick Dyer
[v2: Fix minor issues and document V4L2_INPUT_TYPE_TOUCH and V4L2_CAP_TOUCH] Signed-off-by: Nick Dyer --- Documentation/media/uapi/mediactl/media-types.rst | 24 +++-- Documentation/media/uapi/v4l/dev-touch.rst| 56 +++ Documentation/media/uapi/v4l/devices.rst | 1

<    1   2   3   4   5