to solve a Clang specific issue.
The first patch is critical, I'm hoping Masahiro will pick it for the
Kbuild tree and help us to get the fix in 5.9.
The rest are cleanups; sending them for feedback/review/testing. Once
the first hits mainline, I plan to resend the rest to the x86
maintaine
On Wed, Aug 19, 2020 at 12:29 PM Arvind Sankar wrote:
>
> On Wed, Aug 19, 2020 at 12:16:53PM -0700, Nick Desaulniers wrote:
> > We're reverting
> > commit 5f074f3e192f ("lib/string.c: implement a basic bcmp")
> > in favor of -fno-builtin-bcmp. Remove
On Mon, Aug 10, 2020 at 3:33 PM Nick Desaulniers
wrote:
>
> On Thu, Aug 6, 2020 at 3:39 PM Nathan Huckleberry wrote:
> >
> > Mostly looks good to me. Just a minor nit.
> >
> > On Thu, Jul 30, 2020 at 3:51 PM Nick Desaulniers
> > wrote:
> > > +/*
>
On Tue, Aug 18, 2020 at 9:30 PM Masahiro Yamada wrote:
>
> Do you have any idea to cope with
> the 3% loss problem?
>
> If it is a problem, maybe I should try Idea 2).
I think it will be ok.
Reviewed-by: Nick Desaulniers
--
Thanks,
~Nick Desaulniers
configuring a build of clang
itself.
Don't rely on the compiler's implicit default linker; be explicit.
Cc: sta...@vger.kernel.org
Fixes: commit a0d1c951ef08 ("kbuild: support LLVM=1 to switch the default tools
to Clang/LLVM")
Reported-by: Matthias Maennich
Signed-off-by: N
Hi Gustavo,
Just noticed this on lore. I'm curious if you'd had a chance to test your PR
with e2079e93f562c reverted?
~Nick
> \
> +#define __TLBI_1(op, arg) asm (__TLBI_PREAMBLE
> \
> + "tlbi " #op ", %0\n"
> \
>ALTERNATIVE("nop\n nop",
> \
>"dsb ish\n tlbi " #op ", %0",
> \
>ARM64_WORKAROUND_REPEAT_TLBI,
> \
>
> base-commit: 4834ce9d8e074bb7ae197632e0708219b9f389b5
> --
> 2.28.0.163.g6104cc2f0b6-goog
>
--
Thanks,
~Nick Desaulniers
On Thu, Jul 30, 2020 at 3:37 PM Nick Desaulniers
wrote:
>
> On Mon, Jul 20, 2020 at 4:35 PM David Miller wrote:
> >
> > From: Nick Desaulniers
> > Date: Mon, 20 Jul 2020 12:48:38 -0700
> >
> > > Hi David, bumping for review.
> >
> > If it
-python-3-8-syntaxwarning-for-is-literal/
Signed-off-by: Nick Desaulniers
---
scripts/gdb/linux/rbtree.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/gdb/linux/rbtree.py b/scripts/gdb/linux/rbtree.py
index c4b991607917..fe462855eefd 100644
--- a/scripts/gdb/lin
d compiler optimizations
though we know this case will always return false.
Cc: sta...@vger.kernel.org
Link:
https://lore.kernel.org/kernel-hardening/CAK7LNASvb0UDJ0U5wkYYRzTAdnEs64HjXpEUL7d=v0cxiax...@mail.gmail.com/
Reported-by: Masahiro Yamada
Debugged-by: Sami Tolvanen
Signed-off-by: Jakub Ki
een running the past two
weeks, but sometimes have presentations of folks projects and
research. I think it would be cool to get more background on s390 and
work out the issues we're running into with testing.
--
Thanks,
~Nick Desaulniers
ccidentally in one of
> the decompressors.
>
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25754
>
> Tested-by: Nick Desaulniers
> Reviewed-by: Kees Cook
> Reviewed-by: Ard Biesheuvel
> Reviewed-by: Fangrui Song
> Tested-by: Sedat Dilek
> Signed-off-by: Arvin
nk: https://reviews.llvm.org/rGc41a18cf61790fc898dcda1055c3efbf442c14c0
Link:
https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/builds/178868465
Signed-off-by: Nick Desaulniers
---
https://lore.kernel.org/lkml/20200731230820.1742553-7-keesc...@chromium.org/
is the patch I'm hopeful for building th
On Fri, Aug 7, 2020 at 2:29 PM Arvind Sankar wrote:
>
> On Fri, Aug 07, 2020 at 12:41:00PM -0700, Nick Desaulniers wrote:
> > A recent change to a default value of configuration variable
> > (ENABLE_X86_RELAX_RELOCATIONS OFF -> ON) in LLVM now causes Clang's
> &
by: Masahiro Yamada
Debugged-by: Sami Tolvanen
Signed-off-by: Jakub Kicinski
Signed-off-by: Nick Desaulniers
---
Changes V1->V2:
* add Fixes tag.
include/linux/bitfield.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bitfield.h b/include/linux/bitfield
On Fri, Aug 7, 2020 at 6:43 PM Arvind Sankar wrote:
>
> On Fri, Aug 07, 2020 at 02:54:39PM -0700, Nick Desaulniers wrote:
> > On Fri, Aug 7, 2020 at 2:29 PM Arvind Sankar wrote:
> > >
> > > On Fri, Aug 07, 2020 at 12:41:00PM -0700, Nick Desaulniers wrote:
> &
On Mon, Aug 17, 2020 at 3:44 PM H. Peter Anvin wrote:
>
> On 2020-08-17 15:02, Nick Desaulniers wrote:
> > -ffreestanding typically inhibits "libcall optimizations" where calls to
> > certain library functions can be replaced by the compiler in certain
> &g
On Mon, Aug 17, 2020 at 10:44 PM Nathan Chancellor
wrote:
>
> On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote:
> > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342.
> >
> > Use `-fno-builtin-bcmp` instead.
> >
> > The issue with u
lt Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/20200818170337.805624-1-alex.dewar90%40gmail.com.
--
Thanks,
~Nick Desaulniers
t on bcmp.
>
> If somebody really *wants* to use bcmp, give them the "Get off my
> lawn" flag, and leave them alone. But never ever should "use bcmp" be
> any kind of default behavior. That's some batshit crazy stuff.
>
> Linus
You'll have to ask Clement about that. I'm not sure I ever saw the
"faster bcmp than memcmp" implementation, but I was told "it exists"
when I asked for a revert when all of our kernel builds went red.
--
Thanks,
~Nick Desaulniers
ng, but these days both the gcc and the clang teams have been
> wonderfully responsive.
Just trying to avoid the shoe, again. I'd really like to get to the
point where we can untangle putting out fires from implementing
feature requests though.
--
Thanks,
~Nick Desaulniers
On Tue, Aug 18, 2020 at 12:25 PM Nick Desaulniers
wrote:
>
> On Tue, Aug 18, 2020 at 12:19 PM Linus Torvalds
> wrote:
> >
> > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote:
> > >
> > > I'm not saying "change the semantics", nor am I
On Tue, Aug 18, 2020 at 12:57 PM Alex Dewar wrote:
>
> On Tue, Aug 18, 2020 at 11:13:10AM -0700, Nick Desaulniers wrote:
> > On Tue, Aug 18, 2020 at 10:04 AM Alex Dewar wrote:
> > >
> > > Depending on config options, account_other_time() may not be called
> >
> For eg, __builtin_strchr(s,'\0') can be optimized to strlen. gcc will
> optimize it that way even if -ffreestanding is used (so strlen has to
> mean strlen), while clang won't, so it misses a potential optimization.
> This is admittedly a silly example, but you could imagine something like
> strncpy being optimized to memcpy+memset if the source length was
> previously computed.
>
> PS: clang optimizes sprintf, but doesn't provide __builtin_sprintf?
https://bugs.llvm.org/show_bug.cgi?id=47224
--
Thanks,
~Nick Desaulniers
I keep getting bounce back from the suse.de address.
Cc: Andi Kleen
Signed-off-by: Nick Desaulniers
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 97fd835bd2a4..21f965400a28 100644
--- a/.mailmap
+++ b/.mailmap
@@ -32,6 +32,7 @@ Alex Shi
Alex Shi
On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers
wrote:
>
> On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar wrote:
> >
> > On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus Torvalds wrote:
> > > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote:
> > >
On Tue, Aug 18, 2020 at 2:41 PM Arvind Sankar wrote:
>
> On Tue, Aug 18, 2020 at 01:58:51PM -0700, Nick Desaulniers wrote:
> > On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers
> > wrote:
> > >
> > > On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar
> > >
t.
A free standing environment must always provide a core set of
functions like memset, memcpy, memcmp, memmove, according to
https://gcc.gnu.org/onlinedocs/gcc/Standards.html. Maybe those four
should be in a separate TU compiled as -ffreestanding, so that they
can never be lowered to calls to themselves (potentially infinitely
recursive)?
--
Thanks,
~Nick Desaulniers
On Tue, Aug 18, 2020 at 3:05 PM Dávid Bolvanský
wrote:
>
> st 19. 8. 2020 o 0:00 Nick Desaulniers napísal(a):
> >
> > On Tue, Aug 18, 2020 at 2:41 PM Arvind Sankar wrote:
> > >
> > > Note that -fno-builtin-foo seems to mean slightly different things in
>
just get turned off and
never addressed. My experience with the kernel has been that fixes
for different warnings also take varying amounts of time to get
accepted and work their way through mainline, meanwhile builds are
broken.
I agree that it's ideal to have no warnings, but from my perspective
-Werror is a major impediment to upgrading the tools. Wouldn't
recommend.
--
Thanks,
~Nick Desaulniers
I'd bet these get called
frequently and early on in boot, which is my least favorite time to
debug.
Reviewed-by: Nick Desaulniers
Tested-by: Nick Desaulniers
> ---
> lib/Makefile | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/l
Hi Alexander,
I'm genuinely trying to reproduce/understand this report, questions below:
On Sat, Jan 9, 2021 at 11:15 AM Alexander Lobakin wrote:
>
> From: Nick Desaulniers
> Date: Sat, 9 Jan 2021 09:50:44 -0800
>
> > On Sat, Jan 9, 2021 at 9:11 AM Alexander Lobakin w
rmail/binutils/2020-December/114671.html
Reported-by: Arnd Bergmann
Suggested-by: Josh Poimboeuf
Signed-off-by: Nick Desaulniers
---
Changes v2 -> v3:
* rework to use STB_LOCAL rather than STB_GLOBAL by dropping .L prefix,
as per Josh.
* rename oneline to drop STB_GLOBAL in commit message.
*
+= mem.o random.o
> +PGO_PROFILE_random.o := n
> obj-$(CONFIG_TTY_PRINTK) += ttyprintk.o
> obj-y += misc.o
> obj-$(CONFIG_ATARI_DSP56K) += dsp56k.o
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index e5574e506a5c..d83cacc79b1a 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -168,6 +168,7 @@ i915-y += \
> i915_vma.o \
> intel_region_lmem.o \
> intel_wopcm.o
> +PGO_PROFILE_i915_query.o := n
>
> # general-purpose microcontroller (GuC) support
> i915-y += gt/uc/intel_uc.o \
I'd rather have these both sorted out before landing with PGO disabled
on these files.
--
Thanks,
~Nick Desaulniers
r option has
> > been rejected.
>
> Meaning what exactly? There's no way for clang's integrated assembler to
> even get a cmdline option to not strip .text?
I can clean that up in v5; The section symbols were not generated then
stripped; they were simply never generated.
--
Thanks,
~Nick Desaulniers
On Tue, Dec 8, 2020 at 2:18 PM Arnd Bergmann wrote:
>
> On Tue, Dec 8, 2020 at 7:21 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote:
> > >
> > > On Mon, Dec 7, 2020 at 11:28 PM
U300 || (ARM && COMPILE_TEST)
> + depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST)
> default y if MACH_U300
> select WATCHDOG_CORE
> help
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
genksyms/
$ ./scripts/genksyms/genksyms -d < test_case.i
$ ./scripts/genksyms/genksyms -d -d < test_case.i
Best of luck on that endeavor.
```
I was planning on talking about this timebomb at plumbers, but had to
cut it due to the tight time constraints we were allotted.
--
Thanks,
~Nick Desaulniers
> annotation or the annotation of mips_sc_probe is wrong.
> FATAL: modpost: Section mismatches detected.
> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
> make[2]: *** [/builds/1kl9SVppm6wRdzlQ3UcQKIBaUrx/scripts/Makefile.modpost:59:
> vmlinux.symvers] Error 1
Anders sent a patch for this, too, IIRC. Once the above fixes land
upstream, we probably need to follow up on ensuring they get picked up
into the affected branches of stable.
--
Thanks,
~Nick Desaulniers
if clang is being used, selftests will build with clang.
> ifeq (,$(LINK.c))
> override LDFLAGS =
> -override MAKEFLAGS =
> +override MAKEFLAGS = CC=$(CC)
> endif
>
> # Append kselftest to KBUILD_OUTPUT and O to avoid cluttering
> --
> 2.29.2.576.ga3fc446d84-goog
>
--
Thanks,
~Nick Desaulniers
On Fri, Dec 4, 2020 at 9:06 AM Arvind Sankar wrote:
>
> On Thu, Dec 03, 2020 at 03:28:14PM -0800, Nick Desaulniers wrote:
> > On Thu, Dec 3, 2020 at 3:22 PM Nick Desaulniers
> > wrote:
> > >
> > > On Tue, Nov 24, 2020 at 9:28 AM Arvind Sankar
> > >
d
not determine a symbol for? I'm curious why we're even in this loop
though, since we didn't do anything related to static calls...is
`file->static_call_list` not populated correctly? Is the final else
case from `add_jump_destinations` perhaps being hit and adding nodes
to file->static_call_list incorrectly?
--
Thanks,
~Nick Desaulniers
gt;
> [1] https://docs.w3cub.com/gcc~10/local-register-variables
> Signed-off-by: Anders Roxell
Link: https://github.com/ClangBuiltLinux/linux/issues/606
Reported-by: Nathan Chancellor
Reported-by: Naresh Kamboju
Reviewed-by: Nick Desaulniers
> ---
> arch/mips/lib/uncached.c | 4 +++-
&
on, like
> > lto-user-symbols.txt or .list, to make it more human-friendly?
>
> Sure, I can rename this in the next version. Does anyone have strong
> opinions about the name and/or extension?
.txt extension would be fine.
--
Thanks,
~Nick Desaulniers
On Mon, Nov 23, 2020 at 10:57 AM Nick Desaulniers
wrote:
>
> On Mon, Nov 23, 2020 at 10:50 AM Greg Kroah-Hartman
> wrote:
> >
> > On Mon, Nov 23, 2020 at 10:31:10AM -0800, Nick Desaulniers wrote:
> > > Doesn't this depend on a v2 of
> > > https://
ic call
> reloc generation as well.
>
> Reported-by: Arnd Bergmann
> Signed-off-by: Josh Poimboeuf
Thanks for the patch!
Reviewed-by: Nick Desaulniers
Link: https://github.com/ClangBuiltLinux/linux/issues/1207
> ---
> tools/objtool/check.c | 11 +--
> tools/objtoo
On Fri, Dec 11, 2020 at 12:57 PM Nick Desaulniers
wrote:
>
> Thanks for the patch!
>
> Reviewed-by: Nick Desaulniers
> Link: https://github.com/ClangBuiltLinux/linux/issues/1207
Arnd reported another objtool warning/error from another randconfig in
https://github.com/ClangB
On Fri, Dec 11, 2020 at 4:42 PM Nick Desaulniers
wrote:
>
> On Fri, Dec 11, 2020 at 12:57 PM Nick Desaulniers
> wrote:
> >
> > Thanks for the patch!
> >
> > Reviewed-by: Nick Desaulniers
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1207
&g
from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/20200903023056.3914690-1-nivedita%40alum.mit.edu.
--
Thanks,
~Nick Desaulniers
bel_acntsxprint() fails, it won't assign to its
first param. In the caller, this means assigning uninitialized memory
(UB) when aa_label_acntsxprint() returns -ENOMEM for example. Thanks
for the patch.
Reviewed-by: Nick Desaulniers
>
> In aa_update_label_name(), this th
On Mon, Dec 21, 2020 at 1:23 PM Arvind Sankar wrote:
>
> On Mon, Dec 21, 2020 at 11:14:39AM -0800, Nick Desaulniers wrote:
> > On Wed, Sep 2, 2020 at 7:31 PM Arvind Sankar wrote:
> > >
> > > When CONFIG_RETPOLINE is disabled, Clang uses a jump table for
onfig
...
scripts/Kconfig.include:40: linker 'csky-linux-gnu-ld' not found
My distro doesn't package binutils-csky-linux-gnu, is there
documentation on how to build the kernel targeting CSKY, starting with
building GNU binutils configured with CSKY emulation?
--
Thanks,
~Nick Desaulniers
iguel Ojeda
Cc: Paul Mundt
Reported-by: Guenter Roeck
Signed-off-by: Nick Desaulniers
---
arch/sh/kernel/cpu/sh4a/smp-shx3.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/sh/kernel/cpu/sh4a/smp-shx3.c
b/arch/sh/kernel/cpu/sh4a/smp-shx3.c
index f8a2bec0f260..1261
remove_arg_zero is declared as __must_check. Looks like it can return
-EFAULT on failure.
Cc: Masahiro Yamada
Cc: Miguel Ojeda
Reported-by: Guenter Roeck
Signed-off-by: Nick Desaulniers
---
fs/binfmt_em86.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_em86
way.
>
> Right, looking at my latest randconfig logs, I see the same problem on x86
> builds with clang as well, though I'm not entirely sure which other
> configuration
> options are needed to trigger it.
>
> So my patch can be disregarded, but I agree this needs a better fix,
> either in clang or in the dcn driver.
If you could give https://github.com/ClangBuiltLinux/frame-larger-than
a spin again, I would appreciate any feedback.
--
Thanks,
~Nick Desaulniers
On Mon, Dec 7, 2020 at 2:17 PM Arnd Bergmann wrote:
>
> On Mon, Dec 7, 2020 at 11:08 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Mon, Dec 7, 2020 at 1:57 PM Arnd Bergmann wrote:
>
> > >
> > > Right, looking at my l
(I wonder why we don't use 4B alignment
for 32b...but 8 is a multiple of 4, so should be fine for 32b
targets).
Reviewed-by: Nick Desaulniers
Tested-by: Nick Desaulniers
Build+Boot tested aarch64 and x86_64 with ld.lld and ld.bfd. Did not
test loading builtin firmware.
> ---
&g
On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote:
>
> On Mon, Dec 7, 2020 at 11:28 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Mon, Dec 7, 2020 at 2:17 PM Arnd Bergmann wrote:
> > >
> > > On Mon, Dec 7, 2020 at 11:08 PM
d help
our product teams reduce the amount of out of tree code they have. As
long as help
sell/differentiate phones, I suspect our product teams will continue
to ship full LTO in production.
--
Thanks,
~Nick Desaulniers
((value >> 2) & 0xULL);
> + value = (value + (value >> 4)) & 0x0F0F0F0F0F0F0F0FULL;
> +
> + return (int)((unsigned long long)(value * 0x0101010101010101ULL) >>
> 56);
> +}
The kernel has a portable popcnt implementation called hweight64 if
you #include ; does that work here?
https://en.wikipedia.org/wiki/Hamming_weight
--
Thanks,
~Nick Desaulniers
783
Link: https://sourceware.org/binutils/docs/as/Symbol-Names.html
Link:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d1bcae833b32f1408485ce69f844dcd7ded093a8
Reported-by: Arnd Bergmann
Suggested-by: Josh Poimboeuf
Suggested-by: Borislav Petkov
Signed-off-by: Nick Desaulniers
---
C
struct invalid_value_data {
> struct type_descriptor *type;
> };
>
> +struct alignment_assumption_data {
> + struct source_location location;
> + struct source_location assumption_location;
> + struct type_descriptor *type;
> +};
> +
> #if defined(CONFIG_ARCH_SUPPORTS_INT128)
> typedef __int128 s_max;
> typedef unsigned __int128 u_max;
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.30.0
>
--
Thanks,
~Nick Desaulniers
if ((word & 0x3) == 0) {
num += 2;
word >>= 2;
}
if ((word & 0x1) == 0)
num += 1;
return num;
}
int main() {
int x = 3;
unsigned long y = 3;
printf("%d\n%lu\n", ffs(x), __ffs(y));
return 0;
}
```
will print:
1
0
--
Thanks,
~Nick Desaulniers
have bit 15 set, so I think this pair won't
> break the code.
> Try to hunt for R_MIPS_LO16 that have this bit set, i.e. they have
> '8', '9', 'a', 'b', 'c', 'd' or 'e' as their [15:12].
I don'
;o
> Cc: Catalin Marinas
> Cc: Florian Weimer
> Cc: Peter Zijlstra
> Cc: Linus Torvalds
> Cc: Nick Desaulniers
> Reported-by: Russell King
> Suggested-by: Arnd Bergmann
> Link: https://lore.kernel.org/r/20210105154726.gd1...@shell.armlinux.org.uk
> Signed-off-by: Wil
Suggested-by: Fangrui Song
Suggested-by: Caroline Tice
Signed-off-by: Nick Desaulniers
---
Makefile | 1 +
include/asm-generic/vmlinux.lds.h | 6 +-
lib/Kconfig.debug | 17 +
scripts/test_dwarf5_support.sh| 9 +
4 file
ed-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
---
Makefile | 14 +-
lib/Kconfig.debug | 21 -
2 files changed, 25 insertions(+), 10 deletions(-)
diff --git a/Makefile b/Makefile
index d49c3f39ceb4..656fff17b331 100644
--- a/Makefile
+++ b/Makefile
@@ -8
Signed-off-by: Masahiro Yamada
Reviewed-by: Nick Desaulniers
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 78361f0abe3a..dd7d8d35b2a5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -258,7 +258,6 @@ config
ahiro.
* remove -u from test_dwarf5_support.sh as per Masahiro.
* add a -gdwarf-5 cc-option check to Kconfig as per Jakub.
Masahiro Yamada (1):
Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4
Nick Desaulniers (2):
Kbuild: make DWARF version a choice
Kbuild: implement su
used outside of this translation unit
> >void __ubsan_handle_sub_overflow(void *data,
> >^
>
> Given that these are compiler inserted functions, there is not much of a
> point to having prototypes to them. If people feel shutting these
> warnings up is worthwhile, we can just add the prototypes right above
> the function definition in a follow up patch.
Same as stpcpy; it would be nice though. ;)
--
Thanks,
~Nick Desaulniers
Use more precise language and move the text to a region in the docs to
show that this constraint is not just for SYM_CODE_START*.
Suggested-by: Mark Brown
Suggested-by: Josh Poimboeuf
Signed-off-by: Nick Desaulniers
---
Documentation/asm-annotations.rst | 14 +-
1 file changed, 5
On Wed, Jan 13, 2021 at 8:59 AM Josh Poimboeuf wrote:
>
> On Tue, Jan 12, 2021 at 09:01:54PM +, Mark Brown wrote:
> > On Tue, Jan 12, 2021 at 11:46:24AM -0800, Nick Desaulniers wrote:
> >
> > This:
> >
> > > when building with LLVM_IAS=1 (Clang&#x
scripts/lld-version.sh
> K: \b(?i:clang|llvm)\b
>
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.30.0
>
--
Thanks,
~Nick Desaulniers
Sedat,
Thanks for testing, and congrats on https://lwn.net/Articles/839772/.
I always appreciate you taking the time to help test my work, and
other Clang+Linux kernel patches!
On Wed, Jan 13, 2021 at 1:24 PM Sedat Dilek wrote:
>
> On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers
&g
Maintained
> + - ``CC=clang``
> + * - powerpc
> + - Maintained
> + - ``CC=clang``
> + * - riscv
> + - Maintained
> + - ``CC=clang``
> + * - s390
> + - Maintained
> + - ``CC=clang``
> + * - x86
> + - Supported
> + - ``LLVM=1``
> +
> Getting Help
>
>
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.30.0
>
--
Thanks,
~Nick Desaulniers
ate GCC.
>
> Because Clang is now supported by the kernel print a clear
> Clang-specific warning.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/496
> Link: https://github.com/ClangBuiltLinux/linux/issues/503
> Reported-by: Nick Desaulniers
> Reviewed-by: Nick
cted end
> > of section
>
> Another weird compiler issue. It generates obviously dead code which
> jumps off the end of the function:
>
> f7: b0 01 mov $0x1,%al
> f9: 84 c0 test %al,%al
> fb: 0f 84 79 05 00 00 je 67a
>
> https://paste.centos.org/view/a1887ae3
>
> --
> Josh
>
--
Thanks,
~Nick Desaulniers
On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
>
> On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Tue, Jan 19, 2021 at 5:17 AM Adrian Ratiu
> > wrote:
> > > diff --git a/arch/arm/lib/xo
as a per source
> file compiler option.
Yes, patch 2 in the series removes it from .c source, and passes
-ftree-vectorize during Kbuild.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
> 1PT, UK
> Registration No: 1397386 (Wales)
>
--
Thanks,
~Nick Desaulniers
GCC version
> required by arm64 to 5.1.
>
> Reported-by: Russell King
> Suggested-by: Arnd Bergmann
> Signed-off-by: Will Deacon
> Tested-by: Nathan Chancellor
> Reviewed-by: Nick Desaulniers
> Reviewed-by: Nathan Chancellor
> Acked-by: Linus Torvalds
> Cc: # 4.4.y,
On Tue, Jan 19, 2021 at 2:04 PM Nick Desaulniers
wrote:
>
> On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
> >
> > On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> > Linux wrote:
> > >
> > > On Tue, Jan 19, 2021
he language spec.
Note there were also a lot of discussions lately on "where should the
volatile qualifier be allowed, or not."
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1152r0.html
https://www.youtube.com/watch?v=KJW_DLaVXIY
(2018? ok, maybe not lately. Lately for C)
I view this similarly as "where should the const qualifier be allowed, or not."
--
Thanks,
~Nick Desaulniers
flags when using LTO, based on Fangrui
> Song's comments.
> v3: - Added change log section based on Sedat Dilek's comments.
> v4: - Remove non-x86 Makfile changes and se "hweight64" instead of using our
> own popcount implementation, based on Nick Desaulnie
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups
> "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/1611042978-21473-1-git-send-email-yangtiezhu%40loongson.cn.
--
Thanks,
~Nick Desaulniers
e parts of the tree are already built with -std=gnu11
or -std=gnu17, as they rely on the implicit default C language mode
when unspecified. Oops?
--
Thanks,
~Nick Desaulniers
rules
> for section references, as the synthetic version is not marked __init.
Interesting, I didn't know LLVM could do that. Do you have a simpler
test case? Maybe I could just fix that in LLVM. (I would guess that
when synthesizing a function from an existing function, the new
function needs to copy the original functions attributes as well).
--
Thanks,
~Nick Desaulniers
Via:
https://lore.kernel.org/lkml/1610099389-28329-1-git-send-email-pna...@codeaurora.org/
> diff --git a/include/linux/init.h b/include/linux/init.h
> index 7b53cb3..617adcf 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -300,6 +300,10 @@ void __init parse_early_options(cha
erland
> (didn't tried to catch).
Thanks for the report. Sounds like we may indeed be producing an
incorrect relocation. This is only seen for big endian triples?
Getting a way for us to deterministically reproduce would be a good
first step. Which config or configs beyond defconfig, and which
relocations specifically are you observing this with?
--
Thanks,
~Nick Desaulniers
ta
> +
> + .. code-block:: sh
> +
> + $ cp -a /sys/kernel/debug/pgo/profraw /tmp/vmlinux.profraw
> +
> +5) (Optional) Download the raw profile data to the HOST machine.
> +
> +6) Process the raw profile data
> +
> + .. code-block:: sh
> +
> + $ llvm-profd
On Wed, Jan 13, 2021 at 5:19 PM Nick Desaulniers
wrote:
>
> Patch looks fine, but `make -j htmldocs` seems to be taking forever
> for me so I can't render it. Is this a known issue?
>
> $ make -j htmldocs
Just took a while, lots of warning spew (but not from this addition
t; 48 | \
+ (u64)'p' << 40 | \
+ (u64)'r' << 32 | \
+ (u64)'o' << 24 | \
+ (u64)'f' << 16 | \
+ (u64)'r' << 8 | \
+ (u64)129)
+#else
+ #define LLVM_PRF_MAGIC \
+ ((u64)255 << 56 | \
+ (u64)'l' << 48 | \
+ (u64)'p' << 40 | \
+ (u64)'r' << 32 | \
+ (u64)'o' << 24 | \
+ (u64)'f' << 16 | \
+ (u64)'R' << 8 | \
+ (u64)129)
+#endif
--
Thanks,
~Nick Desaulniers
ng) ; then
> - echo 0
> - exit 1
> -fi
> -
> -MAJOR=$(echo __clang_major__ | $compiler -E -x c - | tail -n 1)
> -MINOR=$(echo __clang_minor__ | $compiler -E -x c - | tail -n 1)
> -PATCHLEVEL=$(echo __clang_patchlevel__ | $compiler -E -x c - | tail -n 1)
> -printf "%d%02d%02d\\n" $MAJOR $MINOR $PATCHLEVEL
> diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh
> deleted file mode 100755
> index ae353432539b..
> --- a/scripts/gcc-version.sh
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -#!/bin/sh
> -# SPDX-License-Identifier: GPL-2.0
> -#
> -# gcc-version gcc-command
> -#
> -# Print the gcc version of `gcc-command' in a 5 or 6-digit form
> -# such as `29503' for gcc-2.95.3, `30301' for gcc-3.3.1, etc.
> -
> -compiler="$*"
> -
> -if [ ${#compiler} -eq 0 ]; then
> - echo "Error: No compiler specified." >&2
> - printf "Usage:\n\t$0 \n" >&2
> - exit 1
> -fi
> -
> -MAJOR=$(echo __GNUC__ | $compiler -E -x c - | tail -n 1)
> -MINOR=$(echo __GNUC_MINOR__ | $compiler -E -x c - | tail -n 1)
> -PATCHLEVEL=$(echo __GNUC_PATCHLEVEL__ | $compiler -E -x c - | tail -n 1)
> -printf "%d%02d%02d\\n" $MAJOR $MINOR $PATCHLEVEL
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
ally noisy so rather than making the shift a boolean implicitly, use
> it in an equality comparison so the shift is used as an integer value.
>
> Fixes: 4d1dbfe6cbec ("MIPS: atomic: Emit Loongson3 sync workarounds within
> asm")
> Fixes: a91f2a1dba44 ("MIPS: cmpxchg: Omit redu
On Thu, Jan 14, 2021 at 6:36 AM Jonathan Corbet wrote:
>
> On Wed, 13 Jan 2021 17:19:59 -0800
> Nick Desaulniers wrote:
>
> > Patch looks fine, but `make -j htmldocs` seems to be taking forever
> > for me so I can't render it. Is this a known issue?
> >
report to syzbot to
close the issue? I did a quick skim of
https://github.com/google/syzkaller/blob/master/docs/syzbot.md, but it
looks like communication with syzbot is based on commit messages?
--
Thanks,
~Nick Desaulniers
e have
> although I am not sure if building the kernel with ICC is well-supported.
>
> [1] https://lkml.org/lkml/2021/1/10/250
> [2] https://lkml.org/lkml/2021/1/12/1708
> [3] https://lkml.org/lkml/2021/1/12/1533
Consider Nathan's request to use lore links rather than lkml.org l
^~
> make[1]: *** [scripts/Makefile.build:279: mm/filemap.o] Error 1
> make[1]: *** Waiting for unfinished jobs
> make: *** [Makefile:1805: mm] Error 2
> make: *** Waiting for unfinished jobs
>
> Nick -- any clue what's happening here? We would like that const anonymous
> struct to behave like a const struct member, as the alternative (naming the
> thing) results in a lot of refactoring churn.
Weird, looks like a bug to me in Clang, filed
https://bugs.llvm.org/show_bug.cgi?id=48755.
--
Thanks,
~Nick Desaulniers
> From: Mahesh Kumar Kalikot Veetil
>
> Modules with a large number of compilation units may be
> exceeding AR and LD command argument list. Handle this gracefully by
> writing the long argument list in a file. The command line options
> read from file are inserted in place of the original @file
m/ClangBuiltLinux/linux/issues/1250
> Signed-off-by: Fangrui Song
Thanks for the patch.
Reviewed-by: Nick Desaulniers
Jessica, would you mind adding when applying:
Cc:
as I suspect we might want this fixed in stable tree's branches, too.
It might of interest to add:
Link:
e_voice: unexpected
> end of section
>
> I haven't had a chance to take a closer look yet, but some of these
> are probably related to
> https://github.com/ClangBuiltLinux/linux/issues/1192. However, I can
> reproduce these also with ToT Clang, not just with Clang 11.
>
> Sami
--
Thanks,
~Nick Desaulniers
501 - 600 of 2032 matches
Mail list logo
