s member cgrp is a struct cgroup, struct cgroup's
member ancestor_ids is a flexible member.
Signed-off-by: Nick Desaulniers
---
Alternatively, we could:
* Not use flexible array members. The flexible array members and allocation
strategy, added in commit b11cfb5807e30 mentions the hot pa
On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
Actually, not sure this is because HOSTCC was specifically clang, I
think that could be reworded to `When compiling ... with Clang, the
...`.
On Mon, Oct 16, 2017 at 11:40 PM, Nick Desaulniers
wrote:
> On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
>> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
>
> Actually, not sure this is because HOSTCC was specifically clang, I
> t
On Thu, May 25, 2017 at 04:07:08PM +0200, Paolo Bonzini wrote:
> I think we should do the fixup backwards.
>
> That is:
>
> - first do get_fpu
>
> - if the fixup is necessary, i.e. ctxt->mode < X86EMUL_MODE_PROT64, do
> fxsave into &fxstate.
>
> - then do segmented_read_std with the correct siz
On Wed, May 24, 2017 at 05:16:18PM +0900, Sergey Senozhatsky wrote:
> On (05/23/17 22:38), Nick Desaulniers wrote:
> > Fixes the following warning, found with Clang:
> well, no objections from my side. MM seems to be getting more and
> more `__maybe_unused' annotations becau
On Tue, May 16, 2017 at 10:27:46AM +0200, Michal Hocko wrote:
> I guess it is worth reporting this to clang bugzilla. Could you take
> care of that Nick?
>From https://bugs.llvm.org//show_bug.cgi?id=33065#c5
it seems that this is indeed a sequence bug in the previous version of
this code and not a
~ ^~~
As far as I can tell, from
http://www.computer-engineering.org/ps2mouse/
Under "Command Set" > "0xE9 (Status Request)"
the value 200 is a valid sample rate. An explicit cast silences this
warning.
Signed-off-by: Nick Desaulniers
---
drivers/input/mou
~ ^~~
As far as I can tell, from
http://www.computer-engineering.org/ps2mouse/
Under "Command Set" > "0xE9 (Status Request)"
the value 200 is a valid sample rate. Using unsigned char, rather than
signed char, for client->ps2 silences this warning.
Signe
~ ^~~
As far as I can tell, from
http://www.computer-engineering.org/ps2mouse/
Under "Command Set" > "0xE9 (Status Request)"
the value 200 is a valid sample rate. Using unsigned char, rather than
signed char, for client->ps2 silences this warning.
Sig
On Fri, May 26, 2017 at 10:07:46AM -0700, Dmitry Torokhov wrote:
> If you look at the code of this fucntion we really use ps2_data as
> signed in calculations, and this change would break that. While making
> ps2_data u8 might be beneficial we'd need to rework mousedev_packet() to
> use signed temp
tor(struct x86_emulate_ctxt *ctxt)
^
with CONFIG_FRAME_WARN set to 1024.
This patch does the fixup in em_fxstor now, avoiding one additional
struct fxregs_state, and now fxstor_fixup can be removed as it has no
other call sites.
Signed-off-by: Nick Desaulniers
---
New in V2:
* reworked patch to d
ping for review
On Tue, May 30, 2017 at 04:14:50AM +0800, kbuild test robot wrote:
>arch/x86/kvm/emulate.c: In function 'em_fxrstor':
> >> arch/x86/kvm/emulate.c:4015:5: warning: 'size' may be used uninitialized
> >> in this function [-Wmaybe-uninitialized]
> rc = segmented_read_std(ctxt, ctxt->memop.add
tor(struct x86_emulate_ctxt *ctxt)
^
with CONFIG_FRAME_WARN set to 1024.
This patch does the fixup in em_fxstor now, avoiding one additional
struct fxregs_state, and now fxstor_fixup can be removed as it has no
other call sites.
Signed-off-by: Nick Desaulniers
---
New in V3:
* initialized si
On Mon, May 29, 2017 at 01:39:08PM -0700, Nick Desaulniers wrote:
> + if (ctxt->mode < X86EMUL_MODE_PROT64) {
> + rc = asm_safe("fxsave %[fx]", , [fx] "+m"(fx_state));
> + if (rc != X86EMUL_CONTINUE
tor(struct x86_emulate_ctxt *ctxt)
^
with CONFIG_FRAME_WARN set to 1024.
This patch does the fixup in em_fxstor now, avoiding one additional
struct fxregs_state, and now fxstor_fixup can be removed as it has no
other call sites.
Signed-off-by: Nick Desaulniers
---
New in V4:
* undo changes for
g.
Also moves some reused logic into a helper function.
Signed-off-by: Nick Desaulniers
---
What's new in v4:
* replace mousedev_limit_delta() with update_clamped() that also updates
the ps2_data and delta values. The use of the temporary val should
avoid integral conv
> El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit:
>> So I hate this change, because it pointlessly duplicates an attribute that
>> should
>> only matter at the definition site.
>
> It's certainly not ideal, and then again essentially the same is done
> in kernel/sched/sched.h, just th
on of Clang's target triple to be later in the top
level Makefile than the inclusion of the arch specific Makefile,
breaking macros like ld-option when cross compiling. V2 was requested
at:
https://lkml.org/lkml/2017/4/21/116
Signed-off-by: Chris Fries
Signed-off-by: Nick Desaulniers
---
Mak
to always fail.
Signed-off-by: Nick Desaulniers
Reviewed-by: Matthias Kaehlcke
---
scripts/Kbuild.include | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 9ffd3dda3889..23c4df90e8ff 100644
--- a/scripts/Kbuild.inc
d-by: Gopinath Elanchezhian
Reported-by: Sindhuri Pentyala
Reported-by: Wei Wang
Suggested-by: Rahul Chaudhry
Suggested-by: Siqi Lin
Suggested-by: Stephen Hines
Signed-off-by: Nick Desaulniers
---
* Question to reviewers: should I be using $(and ..., ...) here rather
than double equals bl
other compression schemes, but my
teammate Wei just reported this benefits gzip as well. What do you
think?
> Also, you should be using CONFIG_RELOCATABLE not CONFIG_RANDOMIZE_BASE,.
Sure thing, will send v2 once you clarify the outer conditional and if
ld-option helps us take this patch now.
--
Thanks,
~Nick Desaulniers
+ folks in Suggested-by/Reported by lines, since git send-email seems
to only pull in folks on Signed-off-by line :(
https://lkml.org/lkml/2017/10/26/590
On Thu, Oct 26, 2017 at 2:17 PM, Siqi Lin wrote:
> I'm OK with sticking with the <2.27 binutils behavior. The gzip data is:
That's what this patch does; goes back to the <2.27 behavior for 2.27+.
> binutils 2.25:
> Image 41467904
> Image.gz 13395151
> binutils 2.27:
> Image 41467392
> Image.gz 1
> On Thu, Oct 26, 2017 at 1:41 PM, Ard Biesheuvel
wrote:>are seeded with the correct values,
I propose we simply drop the outer
> On Thu, Oct 26, 2017 at 2:17 PM, Siqi Lin wrote:
>> I'm OK with sticking with the <2.27 binutils behavior. The gzip data is:
> ... Nick:
> That's what this patch doe
l
Suggested-by: Rahul Chaudhry
Suggested-by: Siqi Lin
Suggested-by: Stephen Hines
Signed-off-by: Nick Desaulniers
---
Changes since v1:
* dropped LZ4 only outer conditional, per Ard.
* changed inner conditional for all RELOCATABLE, not just
RANDOMIZE_BASE, per Ard.
* updated commit message with f
; +KBUILD_CFLAGS += $(lseinstr) $(brokengasinst)
> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> KBUILD_CFLAGS += $(call cc-option, -mpc-relative-literal-loads)
> KBUILD_AFLAGS += $(lseinstr) $(brokengasinst)
> --
> 2.15.0.403.gc27cc4dac6-goog
>
--
Thanks,
~Nick Desaulniers
x27;s integrated assembler.
>
> Suggested-by: Greg Hackmann
> Suggested-by: Nick Desaulniers
> Signed-off-by: Sami Tolvanen
> ---
> arch/arm64/include/asm/kvm_hyp.h | 2 ++
> arch/arm64/include/asm/sysreg.h | 71
> ++--
> 2
On Fri, Nov 3, 2017 at 10:51 AM, Mark Rutland wrote:
> I had to create an aarch64-linux-gnu-clang wrapper, too. I'm not sure if
> there's build system help to avoid needing that?
Gah! So a BIG difference with Clang vs GCC for cross compiling is
that Clang by default ships with all backends enabl
On Fri, Nov 3, 2017 at 11:09 AM, Mark Rutland wrote:
ently compile
> What's the minimum set of patches necessary to work with clang (ignoring
> LTO)?
If you have a build of clang-5, then just patch 7 in this series to
work around the last compiler bug. If you build clang from source
from master,
On Fri, Nov 3, 2017 at 11:06 AM, Mark Rutland wrote:
> On Fri, Nov 03, 2017 at 10:53:08AM -0700, Nick Desaulniers wrote:
>> These mrs_s and msr_s macros in particular were preventing us from
>> linking arm64 with Clang's integrated assembler, regardless of LTO.
>> Th
On Fri, Nov 3, 2017 at 11:02 AM, Mark Rutland wrote:
> Ah, so I guess this is what I was hitting when testing with clang 5.0.0.
Exactly.
> I was under the impression that this series was jsut enablnig LTO
> support, not clang support generally.
Clang is supported at least for the arm64*/x86-64
gt; # ld-version
> # Note this is mainly for HJ Lu's 3 number binutil versions
> ld-version = $(shell $(LD) --version | $(srctree)/scripts/ld-version.sh)
> --
> 2.15.0.403.gc27cc4dac6-goog
>
--
Thanks,
~Nick Desaulniers
On Fri, Nov 3, 2017 at 11:29 AM, Mark Rutland wrote:
> On Fri, Nov 03, 2017 at 11:07:04AM -0700, Nick Desaulniers wrote:
>> On Fri, Nov 3, 2017 at 10:51 AM, Mark Rutland wrote:
>> > I had to create an aarch64-linux-gnu-clang wrapper, too. I'm not sure if
>> > th
; }
>
> . = ALIGN(PAGE_SIZE);
> --
> 2.15.0.403.gc27cc4dac6-goog
>
--
Thanks,
~Nick Desaulniers
Comparing make V=1 with the suggested config before my patch, after my
patch, and after Masahiro's suggestion to add $(LDFLAGS):
before:
...
ld -m elf_i386 -pie-T arch/x86/boot/compressed/vmlinux.lds ...
...
after my:
...
ld -m elf_i386 -T arch/x86/boot/compressed/vmlinux.lds ...
...
af
to always fail.
Suggested-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
Reviewed-by: Matthias Kaehlcke
---
Changes since v2:
* Add LDFLAGS to ld-option, as per Masahiro, and spotted by 0-day bot:
https://lists.01.org/pipermail/lkp/2017-October/007427.html
scripts/Kbuild.include |
ould not have to pay a penalty for no
runtime improvement.
Reported-by: Gopinath Elanchezhian
Reported-by: Sindhuri Pentyala
Reported-by: Wei Wang
Suggested-by: Ard Biesheuvel
Suggested-by: Rahul Chaudhry
Suggested-by: Siqi Lin
Suggested-by: Stephen Hines
Signed-off-by: Nick Desaulniers
Revi
+ linux-kbu...@vger.kernel.org
On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada
wrote:
> I do not like to add $(CLANG_TARGET) to a place for common helpers.
> Instead of $(CLANG_TARGET), please add
> $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS)
> to cc-ldoption and ld-option.
Thanks for the review. I
On Fri, Oct 27, 2017 at 11:28 AM, Nick Desaulniers
wrote:
> On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada
> wrote:
>> - please base your patch on linux-kbuild/kbuild branch
>
> Will do. Do I need to note it's based off that branch? Otherwise wont
> 0-day bot comp
to always fail.
Suggested-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
Reviewed-by: Matthias Kaehlcke
---
Changes since v1:
* base patch off of
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
kbuild branch, per Masahiro.
* Use $(KBUILD_CPPFLAGS) $(CC_OPT
ARCH's, etc before 0-day can be turned on? Such requirements can help
us set goals.
Also, is https://github.com/intel/lkp-tests the codebase for the 0-day bot?
Thanks,
~Nick Desaulniers
> 2017-10-29 0:00 GMT+09:00 Masahiro Yamada :
>>> 2017-10-28 5:13 GMT+09:00 Nick Desaulniers :
>>>> I was not seeing my linker flags getting added when using ld-option when
>>>> cross compiling with Clang. Upon investigation, this seems to be due to
>&
On Wed, Aug 1, 2018 at 5:49 PM John David Anglin wrote:
>
> On 2018-08-01 6:18 PM, Nick Desaulniers wrote:
> >> What about the uses in the fs support, etc?
> > Sorry, I don't see it?
> I mean _THIS_IP_.
I don't understand, I'm referring to current_text_add
On Fri, Aug 3, 2018 at 6:10 AM Jean Delvare wrote:
>
> Hi Nick,
>
> It seems that this linux kernel commit of yours:
>
> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7
> Author: Nick Desaulniers
> Date: Thu Jun 21 09:23:24 2018 -0700
>
> x86/paravirt: Make
compiled with -Werror=missing-prototypes produces this warning in gcc <
4.9, but not gcc >= 4.9.
Cc: sta...@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
Reported-by: David Laight
Reported-by: Jean Delvare
Signed-off-by: Nick Desaulniers
---
arch/x86/include/asm/irqflags.h | 2 ++
1 file ch
On Fri, Aug 3, 2018 at 10:57 AM John David Anglin wrote:
>
> On 2018-08-02 4:31 PM, Nick Desaulniers wrote:
> > If I understand your point correctly, is it that you're saying that
> > _THIS_IP_ should be implemented in terms of inline assembly (as in
> > what cur
On Fri, Aug 3, 2018 at 12:09 PM John David Anglin wrote:
>
> On 2018-08-03 2:11 PM, Nick Desaulniers wrote:
> > But the kernel uses the generic_THIS_IP_ *everywhere*, not parisc's
> > custom current_text_addr(). So if this did actually break unwinding,
> > you shou
On Sun, Aug 5, 2018 at 1:33 PM tip-bot for Nick Desaulniers
wrote:
>
> Commit-ID: 208cbb32558907f68b3b2a081ca2337ac3744794
> Gitweb:
> https://git.kernel.org/tip/208cbb32558907f68b3b2a081ca2337ac3744794
> Author: Nick Desaulniers
> AuthorDate: Fri, 3 Aug 2018 10:05:50
On Tue, Aug 7, 2018 at 12:29 AM Thomas Gleixner wrote:
>
> On Mon, 6 Aug 2018, Nick Desaulniers wrote:
> > On Sun, Aug 5, 2018 at 1:33 PM tip-bot for Nick Desaulniers
> > wrote:
> > > Cc: sta...@vger.kernel.org
> >
> > Not sure if this was going to
On Fri, Aug 3, 2018 at 3:34 PM Helge Deller wrote:
>
> On 03.08.2018 22:33, Nick Desaulniers wrote:
> > On Fri, Aug 3, 2018 at 12:09 PM John David Anglin
> > wrote:
> >>
> >> On 2018-08-03 2:11 PM, Nick Desaulniers wrote:
> >>> But the ker
On Tue, Aug 7, 2018 at 1:30 PM Helge Deller wrote:
>
> On 07.08.2018 20:11, Nick Desaulniers wrote:
> > On Fri, Aug 3, 2018 at 3:34 PM Helge Deller wrote:
> >> So, your patch is basically OK and doesn't break anything.
> >> But I agree with Dave and Andrew, th
ld potentially go into the end of attributes.h
> too (as another separate section).
>
> Compile-tested an x86 allmodconfig for a while with gcc 8.2.0 and 4.6.4.
It's important to test changes to compiler-clang.h with clang. ;)
>
> Cc: Eli Friedman
> Cc: Christopher Li
&
On Mon, Aug 27, 2018 at 10:43 AM Nick Desaulniers
wrote:
>
> On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda
> wrote:
> >
> > Instead of using version checks per-compiler to define (or not) each
> > attribute,
> > use __has_attribute to test for them, following th
ps off the useless code.
>
> Clang is not the only target audience of
> __compiletime_assert_fallback(). Instead of ripping out something that
> may benefit builds with gcc 4.2 and earlier, why not override its
Note that with commit cafa0010cd51 ("Raise the minimum required gcc
vers
On Mon, Aug 27, 2018 at 1:42 PM Daniel Santos wrote:
>
> Hello Nick,
>
> On 08/27/2018 03:09 PM, Nick Desaulniers wrote:
> >> Now we're back to the question of "what do you mean by 'constant'"? If
> >> you mean a C constant expression (as d
Signed-off-by: Nick Desaulniers
---
arch/x86/include/asm/irqflags.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index c14f2a74b2be..15450a675031 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/i
On Tue, Aug 28, 2018 at 8:04 AM Miguel Ojeda
wrote:
>
> Hi Nick,
>
> On Mon, Aug 27, 2018 at 7:43 PM, Nick Desaulniers
> wrote:
> > On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda
> > wrote:
> >>
> >> Instead of using version checks per-compiler to d
On Tue, Aug 28, 2018 at 8:10 AM Miguel Ojeda
wrote:
>
> Hi Nick,
>
> On Mon, Aug 27, 2018 at 7:48 PM, Nick Desaulniers
> wrote:
> > On Mon, Aug 27, 2018 at 10:43 AM Nick Desaulniers
> >> > +
> >> > +/*
> >> > + * Optio
On Tue, Aug 28, 2018 at 5:43 AM Greg Kroah-Hartman
wrote:
>
> On Tue, Aug 28, 2018 at 08:02:37AM +0200, Juergen Gross wrote:
> > On 28/08/18 07:13, Greg Kroah-Hartman wrote:
> > > On Mon, Aug 27, 2018 at 02:40:09PM -0700, Nick Desaulniers wrote:
> > >> Fixes c
On Mon, Aug 27, 2018 at 1:42 PM Daniel Santos wrote:
>
> Hello Nick,
>
> On 08/27/2018 03:09 PM, Nick Desaulniers wrote:
> >>> Let's give up __compiletime_assert_fallback(). This commit does not
> >>> change the current behavior since it just rips off the
es of (in
compiler_types.h):
#include /* potential new header for common
definitions (or just put them above) */
#if /* more proper check for gcc and JUST gcc */
#include
#elif /* compiler check for icc */
#include
#elif /* compiler check for clang */
#include
#endif
#ifndef /* something from the above that's not mission critical */
#warning "compiler missing foo"
#undef foo
#endif
#ifndef /* something from above that IS mission critical */
#error "compiler missing bar"
#endif
I appreciate the patch, but I think there's another way we can clean this up.
--
Thanks,
~Nick Desaulniers
On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet
wrote:
>
> Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC:
> > Thanks for noticing, and sending this patch. I'm happy to see others
> > testing with Clang. I noticed this too near the end of the day
> > https://git
rwise build a defconfig
> and errors out with
>
> $ make CC=clang
> arch/x86/Makefile:179: *** Compiler lacks asm-goto support.. Stop.
Sorry, we're working on implementing this in clang and llvm for x86.
I recently reviewed the design doc, and am trying to see how I can
actively
le:184: *** Compiler lacks asm-goto support.. Stop.
> arch/x86/Makefile:184: *** Compiler lacks asm-goto support.. Stop.
>
See commit e501ce9 ("x86: Force asm-goto").
$ git describe --contains e501ce9 | sed 's/~.*//'
v4.17-rc1
--
Thanks,
~Nick Desaulniers
On Tue, Aug 21, 2018 at 9:45 AM Joe Perches wrote:
>
> On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote:
> > On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet
> > wrote:
> > >
> > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC:
> > > > T
/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595,
can you please share with me your steps to test/verify that the patch
fixes the issue for eBPF? I'll go talk to a co-worker who know more
about eBPF, but I've not yet done anything with it.
Also, does anyone know who I should talk to about ICC testing?
--
Thanks,
~Nick Desaulniers
On Wed, Aug 22, 2018 at 11:31 AM Nick Desaulniers
wrote:
> Hi Dominique,
> I'm currently testing a fix in
> https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595,
Sorry, maybe https://github.com/ClangBuiltLinux/linux/commits/compiler_detection
is
On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote:
>
> On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote:
> > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet
> > wrote:
> > >
> > > Joe Perches wrote on Tue, Aug 21, 2018:
> > > > On We
eported-by: Masahiro Yamada
Suggested-by: Eli Friedman
Suggested-by: Joe Perches
Signed-off-by: Nick Desaulniers
---
arch/arm/kernel/asm-offsets.c | 13 +-
drivers/gpu/drm/i915/i915_utils.h | 2 +-
drivers/watchdog/kempld_wdt.c | 5 -
include/linux/compiler-clang.h| 20 ++-
in
One reply for a bunch of the various threads, to keep the number of emails down:
On Wed, Aug 22, 2018 at 5:20 PM Joe Perches wrote:
> On Wed, 2018-08-22 at 16:37 -0700, Nick Desaulniers wrote:
> > +/* Compiler specific macros. */
> > #ifdef __clang__
> > #include
&
On Thu, Aug 23, 2018 at 2:19 PM Joe Perches wrote:
>
> On Thu, 2018-08-23 at 14:03 -0700, Nick Desaulniers wrote:
> > One reply for a bunch of the various threads, to keep the number of emails
> > down:
> >
> > On Wed, Aug 22, 2018 at 5:20 PM Joe Perches wrote:
>
eter that just disables
> the creation of that file. Otherwise you will break usespace and that
> will be a definitely NAK from Linus, and for stable itself. This is a
> very minor security issue, and does not justify breaking userspace
> applications. I would be very upset if a new stabl
On Thu, Jul 26, 2018 at 8:32 AM Greg KH wrote:
>
> On Thu, Jul 26, 2018 at 08:14:08AM -0700, Mark Salyzyn wrote:
> > On 07/25/2018 06:07 PM, Steven Rostedt wrote:
> > > On Wed, 25 Jul 2018 13:22:36 -0700
> > > Mark Salyzyn wrote:
> > >
> > > >
On Thu, Jul 26, 2018 at 9:37 AM Steven Rostedt wrote:
>
> On Thu, 26 Jul 2018 09:32:07 -0700
> Nick Desaulniers wrote:
>
> > On Thu, Jul 26, 2018 at 8:22 AM Steven Rostedt wrote:
> > >
> > > On Thu, 26 Jul 2018 08:14:08 -0700
> > > Mark Salyzy
On Thu, Jul 26, 2018 at 9:59 AM Nick Desaulniers
wrote:
>
> On Thu, Jul 26, 2018 at 9:37 AM Steven Rostedt wrote:
> >
> > On Thu, 26 Jul 2018 09:32:07 -0700
> > Nick Desaulniers wrote:
> >
> > > On Thu, Jul 26, 2018 at 8:22 AM Steven Rostedt
> > &g
on is what governs access to files below
/sys/kernel/debug, and why was it missing from those kernels? I
assume some check was added, but either not backported to 3.10 stable
(or more likely not pulled in to Nexus 6's kernel through stable;
Android is now in a much better place for that kind of issue).
--
Thanks,
~Nick Desaulniers
c: sta...@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
Signed-off-by: Nick Desaulniers
---
include/linux/kernel.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 941dc0a5a877..5906f5727f90 100644
--- a/include/linux/ker
On Mon, Jul 30, 2018 at 11:39 AM Nathan Chancellor
wrote:
>
> On Mon, Jul 30, 2018 at 10:06:20AM -0700, Nick Desaulniers wrote:
> > Starting with Clang-7.0, _THIS_IP_ generates -Wreturn-stack-address
> > warnings for almost every translation unit. In general, I'd pref
nux/issues/16
Discussion:
https://bugs.llvm.org/show_bug.cgi?id=37512
https://lkml.org/lkml/2018/5/24/1371
Thanks to the many folks that participated in the discussion.
Acked-by: Juergen Gross
Debugged-by: Alistair Strachan
Debugged-by: Matthias Kaehlcke
Reported-by: Sedat Dilek
Signed-off-by: Nic
rop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Nick-Desaulniers/x86-paravirt-make-native_save_fl-extern-inline/20180721-073112
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reprod
On Mon, Jul 30, 2018 at 1:01 PM Nathan Chancellor
wrote:
>
> On Mon, Jul 30, 2018 at 12:48:06PM -0700, Nick Desaulniers wrote:
> > On Mon, Jul 30, 2018 at 11:39 AM Nathan Chancellor
> > wrote:
> > >
> > > On Mon, Jul 30, 2018 at 10:06:20AM -0700, Nick Desa
specific
_Pragma()'s.
__diag support based on commit 8793bb7f4a9d ("kbuild: add macro for
controlling warnings to linux/compiler.h")
Cc: sta...@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
Suggested-by: Nathan Chancellor
Signed-off-by: Nick Desaulniers
---
include/linux/compil
se in _THIS_IP_. current_text_addr will be
consolidated in a follow up series.
Nick Desaulniers (2):
compiler-clang.h: Add CLANG_VERSION and __diag macros
kernel.h: Disable -Wreturn-stack-address for _THIS_IP_
include/linux/compiler-clang.h | 19 +++
include/linux/compiler_types.h
e also can't use compiler specific pragma's without triggering
-Werror=unknown-pragmas in other compilers, so use __diag.
Cc: sta...@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
Suggested-by: Nathan Chancellor
Signed-off-by: Nick Desaulniers
---
include/linux/kernel.h | 10 +-
1 file c
ething to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc7 next-20180727]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/
> url:
> https://github.com/0day-ci/linux/commits/Nick-Desaulniers/compiler-clang-h-Add-CLANG_VERSION-and-__diag-macros/20180731-161932
> config: x86_64-fedora-25 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .con
o build test ERROR on linus/master]
> [also build test ERROR on v4.18-rc7 next-20180727]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Nick-Desaulniers/compiler-clang-h
On Tue, Jul 31, 2018 at 10:02 AM Kees Cook wrote:
>
> On Tue, Jul 31, 2018 at 9:48 AM, Nick Desaulniers
> wrote:
> > Does anyone understand this error? The code looks just fine to me,
> > and the source file doesn't conflict with any of the macros I've added
>
On Tue, Jul 31, 2018 at 10:02 AM Kees Cook wrote:
>
> On Tue, Jul 31, 2018 at 9:48 AM, Nick Desaulniers
> > On Tue, Jul 31, 2018 at 3:27 AM kbuild test robot wrote:
> >>drivers/net//wireless/intel/iwlwifi/iwl-trans.c: In function
> >> 'iwl_trans_send_
On Tue, Jul 31, 2018 at 11:58 AM Nick Desaulniers
wrote:
>
> On Tue, Jul 31, 2018 at 10:02 AM Kees Cook wrote:
> >
> > On Tue, Jul 31, 2018 at 9:48 AM, Nick Desaulniers
> > > On Tue, Jul 31, 2018 at 3:27 AM kbuild test robot wrote:
> > >>drivers/net/
ok to just use the
statement expression.
Does anyone know why this is the case?
--
Thanks,
~Nick Desaulniers
+ More maintainers and lists for visibility
On Tue, Jul 31, 2018 at 3:32 PM Nick Desaulniers
wrote:
>
> I'm currently looking into cleaning up the code duplication between
> current_text_addr() and _THIS_IP_, virtually every implementation of
> current_text_addr() and _TH
On Tue, Jul 31, 2018 at 10:41 PM Martin Schwidefsky
wrote:
>
> On Tue, 31 Jul 2018 16:09:06 -0700
> Nick Desaulniers wrote:
>
> > + More maintainers and lists for visibility
> >
> > On Tue, Jul 31, 2018 at 3:32 PM Nick Desaulniers
> > wrote:
> > >
As part of the effort to reduce the code duplication between _THIS_IP_
and current_text_addr(), let's consolidate callers of
current_text_addr() to use _THIS_IP_.
Signed-off-by: Nick Desaulniers
---
arch/parisc/kernel/unwind.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
As part of the effort to reduce the code duplication between _THIS_IP_
and current_text_addr(), let's consolidate callers of
current_text_addr() to use _THIS_IP_.
Signed-off-by: Nick Desaulniers
---
arch/sh/kernel/dwarf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
tracks previous and new email addresses, which get_maintainer.pl
would parse, that way we have a record of movement between committer
email addresses allowing get_maintainer.pl to make more accurate
recommendations. Thoughts?
--
Thanks,
~Nick Desaulniers
On Wed, Aug 1, 2018 at 11:29 AM Nick Desaulniers
wrote:
>
> As part of the effort to reduce the code duplication between _THIS_IP_
> and current_text_addr(), let's consolidate callers of
> current_text_addr() to use _THIS_IP_.
>
> Signed-off-by: Nick Desaulniers
> ---
As part of the effort to reduce the code duplication between _THIS_IP_
and current_text_addr(), let's consolidate callers of
current_text_addr() to use _THIS_IP_.
Signed-off-by: Nick Desaulniers
---
arch/sh/include/asm/kexec.h | 3 ++-
arch/sh/kernel/dwarf.c | 2 +-
2 files chang
On Wed, Aug 1, 2018 at 11:53 AM Adam Borowski wrote:
>
> On Wed, Aug 01, 2018 at 11:36:23AM -0700, Nick Desaulniers wrote:
> > It seems that get_maintainer.pl will make recommendations based on
> > commit history to a file, but over time, people change emails that
> >
1 - 100 of 2032 matches
Mail list logo
