s!
Duncan Laurie (6):
CHROMIUM: cros_ec: Remove cros_ec dependency in lpc_mec
CHROMIUM: wilco_ec: Add new driver for Wilco EC
CHROMIUM: wilco_ec: Add sysfs attributes
CHROMIUM: wilco_ec: Add support for raw commands in sysfs
CHROMIUM: wilco_ec: Add RTC class driver
CHROMIUM: wilco_
now passes in the 0x800 base address this way.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
drivers/platform/chrome/cros_ec_lpc_mec.c | 54 +++
drivers/platform/chrome/cros_ec_lpc_mec.h | 45 +++
drivers/platform/chrome/cros_ec_lpc_reg.c | 43
/GOOG000C\:00/raw
00 37 33 38 65 64 00...
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Kconfig| 10 ++
drivers/platform/chrome/wilco_ec.h | 6 +
drivers/platform/chrome/wilco_ec_mailbox.c | 6 -
drivers/platform/chrome/wilco_ec_sysfs.
ned-off-by: Nick Crews
---
drivers/platform/chrome/Makefile | 3 +-
drivers/platform/chrome/wilco_ec.h | 14 +++
drivers/platform/chrome/wilco_ec_mailbox.c | 12 ++
drivers/platform/chrome/wilco_ec_sysfs.c | 121 +
4 files changed, 148 insertions(+)
-29 17:08:00.780793-08:00
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Makefile | 3 +-
drivers/platform/chrome/wilco_ec.h | 29
drivers/platform/chrome/wilco_ec_mailbox.c | 15 ++
drivers/platform/chrome/wilco_ec_rtc.c
> properties/peakshift/peakshift_monday
-bash: echo: write error: Invalid argument
> dmesg | tail -n1
[40.34534] wilco_ec GOOG00C:00: minutes must be at the quarter hour
> echo "16 0 20 45 0 0" > properties/peakshift/peakshift_monday
> cat properties/peakshift/peakshift_m
, #include-ing them in wilco_ec_sysfs.c,
and then defining where to actually place the attributes in
wilco_ec_sysfs.c
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Makefile | 3 +-
drivers/platform/chrome/wilco_ec_legacy.c | 204 ++
drivers/platform/chrome
-- SYN_REPORT
Event: type 1 (EV_KEY), code 225 (KEY_BRIGHTNESSUP), value 0
Event: -- SYN_REPORT
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Makefile | 4 +-
drivers/platform/chrome/wilco_ec.h | 3
cros_ec device type.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Kconfig| 14 +-
drivers/platform/chrome/Makefile | 3 +
drivers/platform/chrome/wilco_ec.h | 97 +
drivers/platform/chrome/wilco_ec_mailbox.c | 395
> echo 1 > properties/global_mic_mute_led
[mic mute led on keyboard turns on]
> cat properties/global_mic_mute_led
1
> cat properties/wireless_sw_wlan
cat: wireless_sw_wlan: Permission denied
[Good, that is supposed to be write-only]
> echo 0 > properties/wireless_sw_wlan
Signed-off-by: Nick Crews
change for
comments, until the EC code is implemented.
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Makefile | 3 +-
drivers/platform/chrome/wilco_ec_sysfs.c | 17 -
drivers/platform/chrome/wilco_ec_telemetry.c | 66
drivers/platform/chrome
get()ting
Signed-off-by: Nick Crews
---
.../ABI/testing/sysfs-class-power-wilco | 30 +++
drivers/platform/chrome/wilco_ec/Kconfig | 9 +
drivers/platform/chrome/wilco_ec/Makefile | 2 +
drivers/platform/chrome/wilco_ec/core.c | 16 ++
drivers/platform/chrome/wilco_ec
ESHOLD.
v4 changes:
- Add documentation for the new properties, and add documentation for
the the previously missing charge_control_limit and
charge_control_limit_max properties.
Signed-off-by: Nick Crews
---
Documentation/ABI/testing/sysfs-class-power | 51 +++--
drivers/p
cumentation to Documentation/ABI/testing/sysfs-platform-wilco-ec
- Zero out reserved bytes in requests.
Signed-off-by: Nick Crews
---
.../ABI/testing/sysfs-platform-wilco-ec | 16
drivers/platform/chrome/wilco_ec/sysfs.c | 92 +++
2 files changed, 108 insertions(+)
v2 changes:
- Move documentation to Documentation/ABI/testing/sysfs-platform-wilco-ec
Signed-off-by: Nick Crews
---
.../ABI/testing/sysfs-platform-wilco-ec | 11 +++
drivers/platform/chrome/wilco_ec/Makefile | 2 +-
drivers/platform/chrome/wilco_ec/core.c | 9 +++
drivers/plat
There's one error that Guenter just found...
> +
> +int wilco_ec_add_sysfs(struct wilco_ec_device *ec)
> +{
> + return sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group);
> +}
> +
> +void wilco_ec_remove_sysfs(struct wilco_ec_device *ec)
> +{
> + sysfs_create_group(&ec->dev->kob
_limit and
charge_control_limit_max properties.
Signed-off-by: Nick Crews
---
Documentation/ABI/testing/sysfs-class-power | 20
drivers/power/supply/power_supply_sysfs.c | 2 ++
include/linux/power_supply.h| 2 ++
3 files changed, 24 insertions(+)
diff --git a/Doc
The existing POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT and
POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX properties
don't have documentation. I add that documentation here.
v5 changes:
- Split this commit out from the previous two commits.
Signed-off-by: Nick Crews
---
Documentation/ABI/te
L_END_THRESHOLD properties into
two different commits.
v4 changes:
- Add documentation for the new properties, and add documentation for
the the previously missing charge_control_limit and
charge_control_limit_max properties.
Signed-off-by: Nick Crews
---
Documentation/ABI/testing/sys
On Wed, Apr 17, 2019 at 3:40 PM Sebastian Reichel wrote:
>
> Hi,
>
> The changes itself look all good to me, but this does multiple
> things in a single patch, so please split it into multiple commits.
Thanks Sebastian!
I split this into 3 commits:
-add more charge_type's
-add more CHARGE_CONTRO
Add control of the charging algorithm used on Wilco devices.
See Documentation/ABI/testing/sysfs-class-power-wilco for the
userspace interface and other info.
Signed-off-by: Nick Crews
Reviewed-by: Enric Balletbo i Serra
---
v8 changes:
-Several documentation and comment fixups.
v6 changes
more
complex binary data.
This patch adds support for getting and setting properties.
This will be useful for setting the charge algorithm and charge
schedules, which all use properties.
Signed-off-by: Nick Crews
Acked-for-chrome-by: Enric Balletbo i Serra
---
v7 changes:
-Remove bogus gerrit
> > > Some Wilco devices do not support a keyboard backlight. This
> > > is checked in probe(), and in this case the sysfs entry will
> > > not appear, and everything will behave normally.
> >
> > It would be even better if we did not register platform device if EC
> > does not support backlight.
Hi Rushikesh, I know I've been reviewing this on Chromium, but I have
some more larges-scale design thoughts.
> > diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> > b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> > new file mode 100644
> > index 000..85d71d3
> > --- /dev/null
> > +++
On Tue, Mar 26, 2019 at 8:22 PM Srinivas Pandruvada
wrote:
>
> On Tue, 2019-03-26 at 18:39 -0600, Nick Crews wrote:
> > Hi Rushikesh, I know I've been reviewing this on Chromium, but I have
> > some more larges-scale design thoughts.
> Hi Nick.
>
> Does this fun
r the
clarifications!
On Sat, Mar 30, 2019 at 10:27 AM Joe Perches wrote:
>
> On Sat, 2019-03-30 at 15:52 +0530, Rushikesh S Kadam wrote:
> > On Fri, Mar 29, 2019 at 04:30:18PM -0700, Nick Crews wrote:
> > > On Fri, Mar 29, 2019 at 1:03 PM Rushikesh S Kadam
> > > wrote:
> >
if (rv < 0) {
> + dev_err(ishtp_device(cl_device), "Reset Failed\n");
> + return;
> + }
> +
> + /* ISH firmware loading from host */
> + load_fw_from_host(client_data);
> +}
> +
> +/**
> + * loader_ishtp_cl_probe() -
callback, as EC never changes brightness
by itself.
-Use a __packed struct as message instead of opaque array
-Add exported wilco_ec_keyboard_leds_exist() so the core driver
now only creates a platform _device if relevant
-Fix use of keyboard_led_set_brightness() since it can sleep
Signed-off
ommand and result from wilco_ec_message.
This results in the reduction of total code, and makes it much more
maintainable and understandable.
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/debugfs.c | 43 ---
drivers/platform/chrome/wilco_ec/mailbox.c | 53
river
now only creates a platform _device if relevant
-Fix use of keyboard_led_set_brightness() since it can sleep
Signed-off-by: Nick Crews
Acked-by: Jacek Anaszewski
---
drivers/platform/chrome/wilco_ec/Kconfig | 9 +
drivers/platform/chrome/wilco_ec/Makefile | 2 +
drivers/
ommand and result from wilco_ec_message.
This results in the reduction of total code, and makes it much more
maintainable and understandable.
Signed-off-by: Nick Crews
Acked-by: Alexandre Belloni
---
drivers/platform/chrome/wilco_ec/debugfs.c | 43 ---
drivers/platform/chrome/wilco_ec/
v3 changes:
- Made commit description more accurate and useful.
- Added an exclusive lock for opening the char device,
so only one userspace process can read events at a time.
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/Kconfig | 10 +
drivers/platform/chrome/wilco_ec/Makef
I've just found a few [embarrassing :)] bugs in this version,
so after we figure out the naming, please wait for me to send
out another patch that fixes these.
Thanks, Nick
On Thu, Apr 4, 2019 at 11:10 AM Nick Crews wrote:
>
> We want all backlights for the system keyboard to
>
eep
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/Kconfig | 9 +
drivers/platform/chrome/wilco_ec/Makefile | 2 +
drivers/platform/chrome/wilco_ec/core.c | 58 ++
.../chrome/wilco_ec/kbd_led_backlight.c | 166 ++
include/linux/plat
Hi!
I know people had questions with the structure/uses of the events in the
previous versions of this patch. Does this clear things up?
Thanks, Nick
On Wed, Apr 3, 2019 at 6:31 PM Nick Crews wrote:
>
> The Wilco Embedded Controller can create custom events that
> are not handled as
or really even related
to the AP. The GPIO runs between the EC and the H1 security chip.
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/debugfs.c | 66 +-
1 file changed, 65 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c
or really even related
to the AP. The GPIO runs between the EC and the H1 security chip.
Changes in v2:
- Zero out the unused fields in the request.
- Format result as "%02x\n" instead of as a decimal.
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/debugfs.c | 64 +
or really even related
to the AP. The GPIO runs between the EC and the H1 security chip.
Changes in v3:
- Fix documentation to correspond with formatting change in v2.
Changes in v2:
- Zero out the unused fields in the request.
- Format result as "%02x\n" instead of as a decimal.
Signe
Boot on AC is a policy which makes the device boot from S5 when AC
power is connected. This is useful for users who want to run their
device headless or with a dock.
v2 changes:
- Move documentation to Documentation/ABI/testing/sysfs-platform-wilco-ec
Signed-off-by: Nick Crews
---
.../ABI
sts.
Signed-off-by: Nick Crews
---
.../ABI/testing/sysfs-platform-wilco-ec | 16
drivers/platform/chrome/wilco_ec/sysfs.c | 93 +++
2 files changed, 109 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-platform-wilco-ec
b/Documentation/ABI/testing/sy
; to "QSET"
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/Kconfig | 9 +
drivers/platform/chrome/wilco_ec/Makefile | 2 +
drivers/platform/chrome/wilco_ec/event.c | 511 ++
3 files changed, 522 insertions(+)
create mode 100644 drivers/platform/chr
Thanks for the patch Daniel! A few thoughts that I didn't
have on the review on Gerrit, sorry :) After those changes,
Reviewed-by: Nick Crews
On Fri, Sep 6, 2019 at 4:42 PM Daniel Campello wrote:
>
> This change introduces a new debugfs file 'test_event' that when written
answers below as you see fit? Also, sorry if I make some beginner
> >>>> mistakes here, I'm just getting familiar with the USB subsystem, and
> >>>> thanks for
> >>>> your patience.
> >>>>
> >>>> On Wed, Aug 14, 201
Friendly bump on this :)
On Mon, Aug 5, 2019 at 2:22 PM Nick Crews wrote:
>
> Add the GET_BATT_PPID_INFO=0x8A command to the allowlist of accepted
> telemetry commands. In addition, since this new command requires
> verifying the contents of some of the arguments, I also restr
Check that the time received from the RTC HW is valid,
otherwise the computation of rtc_year_days() in the next
line could, and sometimes does, crash the kernel.
While we're at it, fix the license to plain "GPL".
Signed-off-by: Nick Crews
---
drivers/rtc/rtc-wilco-ec.c | 12
Hi Alexandre, thanks for the thoughts.
On Thu, Sep 12, 2019 at 9:09 AM Alexandre Belloni
wrote:
>
> Hi Nick,
>
> On 10/09/2019 16:19:29+0100, Nick Crews wrote:
> > Check that the time received from the RTC HW is valid,
> > otherwise the computation of rtc_year_days() in
On Mon, Sep 16, 2019 at 2:02 AM Alexandre Belloni
wrote:
>
> On 15/09/2019 23:44:03+0100, Nick Crews wrote:
> > Hi Alexandre, thanks for the thoughts.
> >
> > On Thu, Sep 12, 2019 at 9:09 AM Alexandre Belloni
> > wrote:
> > >
> > > Hi Nick,
>
The tm_yday and tm_wday fields are not used by userspace,
so since they aren't needed within the driver, don't
bother calculating them. This is especially needed since
the rtc_year_days() call was crashing if the HW returned
an invalid time.
Signed-off-by: Nick Crews
---
drivers/rtc
Signed-off-by: Nick Crews
---
drivers/rtc/rtc-wilco-ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
index e84faa268caf..951268f5e690 100644
--- a/drivers/rtc/rtc-wilco-ec.c
+++ b/drivers/rtc/rtc-wilco-ec.c
@@ -184,5
> >
> > > > Hi Nick,
> > > >
> > > > On 25/09/2019 14:32:09-0600, Nick Crews wrote:
> > > > > If the RTC HW returns an invalid time, the rtc_year_days()
> > > > > call would crash. This patch adds error logging in this
>
> - In S0ix, if usb_charge is enabled, then power will be supplied to
> the port when on AC or if battery is > 50%. Else no power is supplied.
> - In S5, if usb_charge is enabled, then power will be supplied to
> the port when on AC. Else no power is supplied.
>
> Signed-off-by: Da
them.
Signed-off-by: Nick Crews
---
drivers/rtc/rtc-wilco-ec.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
index 8ad4c4e6d557..ff46066a68a4 100644
--- a/drivers/rtc/rtc-wilco-ec.c
+++ b/drivers/rtc/rtc-wilco
Assuming that the Kbuild bot doesn't get mad about the format string
now, LGTM. Thanks Daniel!
Reviewed-by: Nick Crews
On Wed, Sep 18, 2019 at 2:43 PM Daniel Campello wrote:
>
> This change introduces a new debugfs file 'test_event' that when written
> to causes the EC
On Tue, Sep 24, 2019 at 1:55 AM Pavel Machek wrote:
>
> On Sun 2019-09-22 22:43:53, Alexandre Belloni wrote:
> > On 22/09/2019 22:29:48+0200, Pavel Machek wrote:
> > > On Mon 2019-09-16 12:12:17, Nick Crews wrote:
> > > > Signed-off-by: Nick Crews
> > >
send_ec_cmd
> to be a common helper between h1_gpio_get and test_event_set.
>
> Signed-off-by: Daniel Campello
Reviewed-by: Nick Crews
> ---
> Changes for v2:
> - Cleaned up and added comments.
> - Renamed and updated function signature from write_to_mailbox to
>
d calls to rtc_valid_tm(), but we feel that it is
required.
Thanks,
Nick
On Mon, Sep 23, 2019 at 2:19 PM Alexandre Belloni
wrote:
>
> On 23/09/2019 11:20:42-0600, Nick Crews wrote:
> > > This is coming from struct tm, it is part of C89 but I think I was not
> > > born when this d
them.
Signed-off-by: Nick Crews
---
drivers/rtc/rtc-wilco-ec.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
index 8ad4c4e6d557..53da355d996a 100644
--- a/drivers/rtc/rtc-wilco-ec.c
+++ b/drivers/rtc/rtc-wilco
On Thu, Sep 26, 2019 at 4:43 PM Benson Leung wrote:
>
> Hey Nick,
> On Fri, Jun 21, 2019 at 7:51 AM Nick Crews wrote:
> >
> > Thanks Yue, looks good to me.
> >
> > Nick
> >
> > On Fri, Jun 21, 2019 at 7:59 AM YueHaibing wrote:
> > >
> &
/09/2019 22:29:48+0200, Pavel Machek wrote:
> > On Mon 2019-09-16 12:12:17, Nick Crews wrote:
> > > Signed-off-by: Nick Crews
> > > ---
> > > drivers/rtc/rtc-wilco-ec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > &g
On Sun, Sep 22, 2019 at 1:05 PM Alexandre Belloni
wrote:
>
> On 22/09/2019 18:13:06+0200, Pavel Machek wrote:
> > On Mon 2019-09-16 12:12:15, Nick Crews wrote:
> > > The tm_yday and tm_wday fields are not used by userspace,
> > > so since they aren't needed wi
Many thanks Enric!
On Fri, Oct 11, 2019 at 9:08 AM Enric Balletbo i Serra
wrote:
>
> Hi Daniel, Nick
>
> On 9/10/19 17:00, Nick Crews wrote:
> > On Tue, Oct 8, 2019 at 4:18 PM Daniel Campello
> > wrote:
> >>
> >> USB PowerShare is a policy which
Hi Richard!
Thanks for the patch. I'm not familiar with these batteries, but I have
a few thoughts. For others, the SBS battery spec is at
http://sbs-forum.org/specs/sbdat110.pdf, and section 5.1.21 at page 28
is useful.
On Thu, Jul 25, 2019 at 2:55 AM Richard Tresidder
wrote:
>
> When a battery
On Mon, Jul 29, 2019 at 2:07 AM Richard Tresidder
wrote:
>
> When a battery or batteries in a system are in parallel then one or more
> may not be providing any current to the system.
> This fixes an incorrect status indication of FULL for the battery simply
> because it wasn't discharging at that
Fixes: 46c7fd06f8c9 ("platform/chrome: wilco_ec: Add support for raw commands
in debugfs")
Signed-off-by: Nick Crews
---
drivers/platform/chrome/wilco_ec/debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c
b/drivers/
: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
Signed-off-by: Nick Crews
---
drivers/platform/chrome/Kconfig | 2 +-
drivers/platform/chrome/wilco_ec/Kconfig | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/chrome/Kconfig
Hi Enric,
On Wed, Feb 20, 2019 at 3:06 PM Enric Balletbo i Serra
wrote:
>
> Hi Nick,
>
> Thanks for the patch.
>
> On 20/2/19 22:58, Nick Crews wrote:
> > Before, in debugfs.c it was possible to supply only the message type,
> > and not supply any other argum
esponse
> cat raw
00 31 32 2f 32 31 2f 31 38 00 00 0f 01 00 01 00 .12/21/18...
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v6:
- s/4.19/5.1/ for kernel version in documentation, since that is
the version this patch should land in.
- Instead of requiring at
how --rtc /dev/rtc1
2018-11-29 17:08:00.780793-08:00
> hwclock --show --rtc /dev/rtc1
2007-12-31 16:01:20.460959-08:00
> hwclock --systohc --rtc /dev/rtc1
> hwclock --show --rtc /dev/rtc1
2018-11-29 17:08:00.780793-08:00
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Chang
OX_DATA_SIZE defs
- Make docstrings follow kernel style
- Fix tags in commit msg
- Move Kconfig to subdirectory
- Reading raw now includes ASCII translation
- rm license boiler plate
- rm "wilco_ec_rtc -" prefix in docstring
- Make rtc driver its own module within the drivers/rtc/ director
ng code for this fix. Maybe we'll come back through later and fix
this.
Signed-off-by: Duncan Laurie
Acked-for-chrome-platform-by: Enric Balletbo i Serra
Signed-off-by: Nick Crews
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Change <= t
commit exports the wilco_ec_mailbox()
function so that other modules can use it to communicate with the EC.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v6:
- Re-added WILCO_EC_FLAG_EXTENDED_DATA and went back to always
reading either EC_MAILBOX_DATA_SIZE or
Hi Enric and Alexandre,
On Fri, Feb 8, 2019 at 5:18 AM Enric Balletbo i Serra
wrote:
>
> Hi,
>
> On 8/2/19 2:23, Nick Crews wrote:
> > This Embedded Controller has an internal RTC that is exposed
> > as a standard RTC class driver with read/write functionality.
> >
ot;wilco_ec_rtc -" prefix in docstring
- Make rtc driver its own module within the drivers/rtc/ directory
- Register a rtc device from core.c that is picked up by this driver
Nick Crews (4):
cros_ec: Remove cros_ec dependency in lpc_mec
platform/chrome: Add new driver for Wilco EC
platform/chr
ng code for this fix. Maybe we'll come back through later and fix
this.
Signed-off-by: Duncan Laurie
Acked-for-chrome-platform-by: Enric Balletbo i Serra
Signed-off-by: Nick Crews
---
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Change <= t
commit exports the wilco_ec_mailbox()
function so that other modules can use it to communicate with the EC.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v7: None
Changes in v6:
- Re-added WILCO_EC_FLAG_EXTENDED_DATA and went back to always
reading either
esponse
> cat raw
00 31 32 2f 32 31 2f 31 38 00 00 0f 01 00 01 00 .12/21/18...
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v7:
- Switch to #define for MAX_WORD_SIZE so array size
can be determined at compile time.
Changes in v6:
- s/4.19/5.1/ for kernel version
cked-by: Alexandre Belloni
Signed-off-by: Nick Crews
---
Changes in v7: None
Changes in v6:
- In the core, actually unregister the RTC child platform_device.
Changes in v5: None
Changes in v4:
- Change me email to @chromium.org from @google.com
- Move "Add RTC driver" before "Add sys
I just sent out a fixed version. Thanks!
On Fri, Feb 8, 2019 at 10:18 AM Enric Balletbo Serra
wrote:
>
> Hi Nick,
> Missatge de Nick Crews del dia dv., 8 de febr.
> 2019 a les 2:24:
> >
> > Add a debugfs attribute that allows sending raw commands to the EC.
> >
cked-by: Alexandre Belloni
Signed-off-by: Nick Crews
---
Changes in v8: None
Changes in v7: None
Changes in v6:
- In the core, actually unregister the RTC child platform_device.
Changes in v5: None
Changes in v4:
- Change me email to @chromium.org from @google.com
- Move "Add RTC driver"
raw now includes ASCII translation
- rm license boiler plate
- rm "wilco_ec_rtc -" prefix in docstring
- Make rtc driver its own module within the drivers/rtc/ directory
- Register a rtc device from core.c that is picked up by this driver
Nick Crews (4):
cros_ec: Remove cros_ec dependency
esponse
> cat raw
00 31 32 2f 32 31 2f 31 38 00 00 0f 01 00 01 00 .12/21/18...
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v8:
- Fix a comment about registering the debugfs driver
Changes in v7:
- Switch to #define for MAX_WORD_SIZE so array size
can be dete
ng code for this fix. Maybe we'll come back through later and fix
this.
Signed-off-by: Duncan Laurie
Acked-for-chrome-platform-by: Enric Balletbo i Serra
Signed-off-by: Nick Crews
---
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in
commit exports the wilco_ec_mailbox()
function so that other modules can use it to communicate with the EC.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v8: None
Changes in v7: None
Changes in v6:
- Re-added WILCO_EC_FLAG_EXTENDED_DATA and went back to always
reading
Sorry all, there is one more error in here I just found, I just sent
out v8 that corrects it.
Sorry Enric if you already started trying to merge this version.
On Fri, Feb 8, 2019 at 12:38 PM Nick Crews wrote:
>
> This Embedded Controller has an internal RTC that is exposed
> as a sta
cros_ec device type.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- Removed COMPILE_TEST from Kconfig because inb()/outb()
won't work on anything but X86
- Moved everything to wilco_ec/ subdirectory
- Moved header file to include/platform_data/
so could be used by f
lpc_mec
platform/chrome: Add new driver for Wilco EC
platform/chrome: Add sysfs attributes
platform/chrome: Add support for raw commands in sysfs
platform/chrome: rtc: Add RTC driver for Wilco EC
platform/chrome: Add event handling
Nick Crews (3):
platform/chrome: Add EC propert
with all the
calling code for this fix. Maybe we'll come back through later and fix
this.
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- Fixed kernel-doc comments
- Fixed include of linux/mfd/cros_ec_lpc_mec.h
- cros_ec_lpc_mec_in_range() returns -EINVAL on er
> properties/peakshift/peakshift_monday
-bash: echo: write error: Invalid argument
> dmesg | tail -n1
[40.34534] wilco_ec GOOG00C:00: minutes must be at the quarter hour
> echo "16 0 20 45 0 0" > properties/peakshift/peakshift_monday
> cat properties/peakshift/peakshift_monday
1
SVN Revision : 738ed.99
Model Number : 08;8
Build Date : 08/30/18
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- Remove license boiler plate
- Remove "wilco_ec_sysfs -" docstring prefix
- Fix accidental Makefile deletion
- Add documentation for sysfs entri
; hwclock --show --rtc /dev/rtc1
2018-11-29 17:08:00.780793-08:00
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- rm license boiler plate
- rm "wilco_ec_rtc -" prefix in docstring
- Make rtc driver its own module within the drivers/rtc/ directory
- Registe
/GOOG000C\:00/raw
00 37 33 38 65 64 00...
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- Add sysfs documentation
- rm duplicate EC_MAILBOX_DATA_SIZE defs
- Make docstrings follow kernel style
- Fix tags in commit msg
- Reading raw now includes ASCII translation
.../AB
> echo 1 > properties/global_mic_mute_led
[mic mute led on keyboard turns on]
> cat properties/global_mic_mute_led
1
> cat properties/wireless_sw_wlan
cat: wireless_sw_wlan: Permission denied
[Good, that is supposed to be write-only]
> echo 0 > properties/wireless_sw_wlan
Signed-off-by: Nick Crews
change for
comments, until the EC code is implemented.
Signed-off-by: Nick Crews
---
Changes in v2:
- rm "wilco_ec_telemetry - " prefix from docstring
- rm license boiler plate
- Fix commit msg tag
.../ABI/testing/sysfs-platform-wilcoec| 6 ++
drivers/platform/chrome/wilco_e
-- SYN_REPORT
Event: type 1 (EV_KEY), code 225 (KEY_BRIGHTNESSUP), value 0
Event: -- SYN_REPORT
Signed-off-by: Duncan Laurie
Signed-off-by: Nick Crews
---
Changes in v2:
- rm "wilco_ec_event -" prefix from docstring
- rm license boiler plat
Thanks for the comments Alexandre, I've responded to your comments
inline. I'll send out a new version of the patch in a bit
On Mon, Jan 14, 2019 at 3:26 PM -700 Alexandre Belloni wrote:
>
> Hello,
>
> On 14/01/2019 15:03:52-0700, Nick Crews wrote:
> > diff --git a/
Hi Alexandre, thanks for taking the time to review this. I've responded to your
comments inline below. I'll send out a new version of this patch soon.
On Mon, Jan 14, 2019 at 3:26 PM Alexandre Belloni
wrote:
>
> Hello,
>
> On 14/01/2019 15:03:52-0700, Nick Crews wrote:
&g
Hi Enric, thanks for the comments. I'll send out a new version soon,
with this moved to debugfs.
On Tue, Jan 15, 2019 at 12:37 PM Enric Balletbo Serra
wrote:
>
> Hi Nick,
>
> Missatge de Nick Crews del dia dl., 14 de gen.
> 2019 a les 23:07:
> >
> > From: Du
Wilco EC
platform/chrome: Add support for raw commands in debugfs
platform/chrome: Add sysfs attributes
platform/chrome: rtc: Add RTC driver
platform/chrome: Add event handling
Nick Crews (3):
platform/chrome: Add EC properties
platform/chrome: Add peakshift and adv_batt_charging
platfo
From: Nick Crews
Create "peakshift" and "advanced_battery_charging" directories
within the "properties" directory, and create the relevant
attributes within these. These properties have to do with
configuring some of the advanced power management options that
pro
From: Nick Crews
A Property is typically a data item that is stored to NVRAM.
Each of these data items has an index associated with it
known as the Property ID (PID). The Property ID is
used by the system BIOS (and EC) to refer to the Property.
Properties may have variable lengths. Many features
1 - 100 of 201 matches
Mail list logo
