there is anything else to change.
It is still not as thoroughly checked over as my PATCH v2 series for
small typos, but I cannot find any problems. All patches pass the
scripts/checkpatch.pl perfectly with no warnings.
Thank you for your continued patience and understanding.
Nicholas Johnson (4
ion, and
potentially others which are yet to be encountered.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 203 ++--
1 file changed, 110 insertions(+), 93 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index ec44a0
assigns resources.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index a1ca8a11f..5b9ee9945 100644
--- a/drivers/pci/setup-bus.c
+++ b
Change block comments to accepted style with asterisks on each line.
Justify block comments to 80-character limit to reduce the number of
lines where possible.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 248 +++-
1 file changed, 120
.
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 5 +++-
drivers/pci/pci.c | 12 ++---
drivers/pci/setup-bus.c | 25 +++
include/linux/pci.h | 3 ++-
4 files changed, 29
comment to reflect the
changes, and checkpatch.pl got really angry and yelled at me. So I
figured I may as well fix the lot.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 82 +
1 file changed, 51 insertions(+), 31 deletions(-)
diff --git a/d
nd this message
does not pertain to a particular device.
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 21 --
drivers/pci/pci.c | 39 +--
drivers/pci/setup-bus.c | 26 +++--
On Mon, Mar 15, 2021 at 11:05:21AM -0400, Alex Deucher wrote:
> On Mon, Mar 15, 2021 at 4:04 AM Nicholas Johnson
> wrote:
> >
> > When using some Thunderbolt hosts using BIOS-assisted PCI enumeration
> > with IO BAR assigned, we get an atombios timeout, such as:
> >
When using some Thunderbolt hosts using BIOS-assisted PCI enumeration
with IO BAR assigned, we get an atombios timeout, such as:
[drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 20secs
aborting
[drm:amdgpu_atom_execute_table_locked [amdgpu]] *ERROR* atombios stuck
executi
experienced this
issue for a long time, and have finally decided to do something about
it. I do not see a downside to using MMIO, which is required to be
assigned.
Kind regards,
Nicholas Johnson
Nicholas Johnson (1):
amdgpu: use MMIO to init atombios if device is Thunderbolt / USB4
attached
On Thu, Apr 30, 2020 at 05:14:56PM +0200, Takashi Iwai wrote:
> On Wed, 29 Apr 2020 18:19:57 +0200,
> Alex Deucher wrote:
> >
> > On Wed, Apr 29, 2020 at 12:05 PM Takashi Iwai wrote:
> > > Well, but the code path there is the runtime PM resume of the audio
> > > device and it means that GPU must
On Thu, Apr 30, 2020 at 07:01:08PM +0200, Takashi Iwai wrote:
> On Thu, 30 Apr 2020 18:52:20 +0200,
> Nicholas Johnson wrote:
> >
> > On Thu, Apr 30, 2020 at 05:14:56PM +0200, Takashi Iwai wrote:
> > > On Wed, 29 Apr 2020 18:19:57 +0200,
> > > Alex Deucher wr
very important for my goal, I realised that they are just a heap of
patches that are not Thunderbolt-specific. The only thing that is
Thunderbolt-related is the intended use case.
I hope that posting this alone can ease the difficulty of reviewing it.
Nicholas Johnson (1):
PCI: Add hp_mmio_size and
MMIO and MMIO_PREF to the same size.
The two new parameters conform to the style of pci=hpiosize=nn[KMG].
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 9 ++-
drivers/pci/pci.c | 17 ++---
drivers/pci/pci.h
i, Jul 26, 2019 at 12:53:19PM +, Nicholas Johnson wrote:
> > Rewrite pci_bus_distribute_available_resources to better handle bridges
> > with different resource alignment requirements. Pass more details
> > arguments recursively to track the resource start and end addresses
On Tue, Oct 08, 2019 at 03:09:07PM +0300, mika.westerb...@linux.intel.com wrote:
> On Fri, Jul 26, 2019 at 12:54:22PM +0000, Nicholas Johnson wrote:
> > Remove checks for resource size in extend_bridge_window(). This is
> > necessary to allow the pci_bus_distribute_available
On Wed, Oct 23, 2019 at 12:34:19PM +0300, mika.westerb...@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 09:08:42AM +0000, Nicholas Johnson wrote:
> > On Tue, Oct 08, 2019 at 02:38:12PM +0300, mika.westerb...@linux.intel.com
> > wrote:
> > > Hi Nicholas,
> >
>
On Wed, Oct 23, 2019 at 12:47:43PM +0300, mika.westerb...@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 08:37:48AM +0000, Nicholas Johnson wrote:
> > } else if (!strncmp(str, "hpmemsize=", 10)) {
> > - pci_hotplug_mem_size
On Wed, Oct 23, 2019 at 01:03:59PM +0300, mika.westerb...@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 09:57:17AM +0000, Nicholas Johnson wrote:
> > On Wed, Oct 23, 2019 at 12:47:43PM +0300, mika.westerb...@linux.intel.com
> > wrote:
> > > On Wed, Oct 23, 2019 at 08
On Wed, Oct 23, 2019 at 12:45:22PM +0300, mika.westerb...@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 08:36:59AM +0000, Nicholas Johnson wrote:
> > This patch adds support for two new kernel parameters. This patch has
> > been in the making for quite some time, and has change
MMIO and MMIO_PREF to the same size.
The two new parameters conform to the style of pci=hpiosize=nn[KMG].
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 9 ++-
drivers/pci/pci.c | 13 +++---
drivers/pci/pci.h
problems in testing.
Fixed the alignment of some overflow lines.
It turns out Outlook is causing my encoding issues with git send-email.
If I get a new email for kernel development, what should it be? Gmail
works, but looks tackier.
Nicholas Johnson (1):
PCI: Add hp_mmio_size and hp_mmio_pref_size
rote:
> > > >
> > > > On Mon, Apr 27, 2020 at 2:07 PM Nicholas Johnson
> > > > wrote:
> > > > >
> > > > > On Mon, Apr 27, 2020 at 05:15:55PM +0200, Takashi Iwai wrote:
> > > > > > On Mon, 27 Apr 2020 16:22:21 +020
:
Link: https://bugzilla.kernel.org/show_bug.cgi?id=199581
Tested-by: Mika Westerberg
Signed-off-by: Nicholas-Johnson-opensource
---
drivers/pci/setup-bus.c | 172
1 file changed, 88 insertions(+), 84 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/driver
ed to be dropped from the kernel at some point. The docks have
four bridges each, with 4096-byte alignment. The IO BARs do not do
anything, crash the system if not claimed and spam dmesg when not
assigned.
Signed-off-by: Nicholas-Johnson-opensource
---
drivers/pci/setup-bus.c | 188 +
more space.
Nicholas Johnson (4):
PCI: Consider alignment of hot-added bridges when distributing
available resources
PCI: Modify extend_bridge_window() to set resource size directly
PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
window
PCI: Add pci=hpmemprefsize
ion, and
potentially others which are yet to be encountered.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 169
1 file changed, 84 insertions(+), 85 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 0cdd5f
uired to prevent the bridge not being enabled due
to resources with zero size. This is a direct requirement to prevent the
change away from using add_list from introducing a regression - because
before, it was not possible to end up with zero size.
Signed-off-by: Nicholas Johnson
---
drivers/
assigned
in a previous pass. This fixes the existing behaviour where space for a
resource could be reserved multiple times in different parent bridge
windows. This also greatly reduces the number of failed BAR messages in
dmesg when Linux assigns resources.
Signed-off-by: Nicholas Johnson
documentation to reflect the above changes.
The effect of the above changes is to allow for MMIO and MMIO_PREF to be
specified independently, whilst ensuring no changes in functionality are
noticed by the user if updating kernel version with hpmemsize specified.
Signed-off-by: Nicholas Johnson
initial hotplug bridge. This is especially
useful for Thunderbolt with native PCI enumeration, enabling external
graphics cards and other devices with bridge alignment higher than
0x10 bytes.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 164
.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 310 +++-
1 file changed, 151 insertions(+), 159 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 4386ca941..400cf616c 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers
documentation to reflect the above changes.
The effect of the above changes is to allow for MMIO and MMIO_PREF to be
specified independently, whilst ensuring no changes in functionality are
noticed by the user if updating kernel version with hpmemsize specified.
Signed-off-by: Nicholas Johnson
than
globally.
Please let me know if anything else needs changing.
Nicholas Johnson (5):
PCI: Consider alignment of hot-added bridges when distributing
resources
PCI: Modify extend_bridge_window() to set resource size directly
PCI: Fix bug resulting in double hpmemsize being assigned to
assigned
in a previous pass. This fixes the existing behaviour where space for a
resource could be reserved multiple times in different parent bridge
windows. This also greatly reduces the number of failed BAR messages in
dmesg when Linux assigns resources.
Signed-off-by: Nicholas Johnson
uired to prevent the bridge not being enabled due
to resources with zero size. This is a direct requirement to prevent the
change away from using add_list from introducing a regression - because
before, it was not possible to end up with zero size.
Signed-off-by: Nicholas Johnson
---
drivers/
Patch series rebased to 5.3-rc1.
If possible, please have a quick read over while I am away (2019-07-27
to mid 2019-08-04), so I can fix any mistakes or make simple changes to
get problems out of the way for a more thorough examination later.
Thanks!
Kind regards,
Nicholas
Nicholas Johnson (6
In extend_bridge_window() change "available" parameter name to new_size.
This makes more sense as this parameter represents the new size for the
window.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
and
potentially others which are yet to be encountered.
Solves bug report: https://bugzilla.kernel.org/show_bug.cgi?id=199581
Reported-by: Mika Westerberg
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 148 +++-
1 file changed, 71 insertions(+),
it is set to zero size and left,
it can cause significant problems when it comes to assigning resources.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup
bridge is extended or shrunken and adjust pci_dbg to
reflect this.
Reset the resource if its new size is zero (if we have run out of a
bridge window resource). If it is set to zero size and left, it can
cause significant problems when it comes to enabling devices.
Signed-off-by: Nicholas Johnson
MMIO and MMIO_PREF to the same size.
The two new parameters conform to the style of pci=hpiosize=nn[KMG].
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 9 ++-
drivers/pci/pci.c | 17 ++---
drivers/pci/setup-bus.c
/20190531171216.20532-2-log...@deltatee.com/T/#u
Solves bug report: https://bugzilla.kernel.org/show_bug.cgi?id=203243
Reported-by: Kit Chow
Reported-by: Nicholas Johnson
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 29 +++--
1 file changed, 19 insertions(+), 10
d in 1a5767725cec ("PCI:
> Distribute available resources to hotplug-capable bridges"). Is there
> any chance you could help review this?
>
> On Wed, May 22, 2019 at 02:30:44PM +, Nicholas Johnson wrote:
> > Rewrite pci_bus_distribute_available_resources to better h
.
___
On Mon, Jun 17, 2019 at 12:35:13PM +0300, mika.westerb...@linux.intel.com wrote:
> On Wed, May 22, 2019 at 02:30:44PM +0000, Nicholas Johnson wrote:
> > Rewrite pci_bus_distribute_available_resources to better handle bridges
> > with different resource alignme
the requested changes.
My apologies in advance if any slip through.
Bjorn Helgaas (2):
PCI: Simplify pci_bus_distribute_available_resources()
PCI: Skip resource distribution when no hotplug bridges
Nicholas Johnson (5):
PCI: Consider alignment of hot-added bridges when distributing
availab
Reorder pci_bus_distribute_available_resources() to group related code
together. No functional change intended.
Link:
https://lore.kernel.org/r/ps2p216mb0642c7a485649d2d787a1c6f80...@ps2p216mb0642.korp216.prod.outlook.com
Based-on-patch-by: Nicholas Johnson
[bhelgaas: extracted from larger
ining resources. No functional change intended.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index af28af898..04adeebe8 100644
--- a/drivers/pci/setup-bus.c
++
and
potentially others which are yet to be encountered.
Solves bug report: https://bugzilla.kernel.org/show_bug.cgi?id=199581
Reported-by: Mika Westerberg
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 148 +++-
1 file changed, 71 insertions(+),
In extend_bridge_window() change "available" parameter name to new_size.
This makes more sense as this parameter represents the new size for the
window.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
it is set to zero size and left,
it can cause significant problems when it comes to assigning resources.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup
bridge is extended or shrunken and adjust pci_dbg to
reflect this.
Reset the resource if its new size is zero (if we have run out of a
bridge window resource). If it is set to zero size and left, it can
cause significant problems when it comes to enabling devices.
Signed-off-by: Nicholas Johnson
MMIO and MMIO_PREF to the same size.
The two new parameters conform to the style of pci=hpiosize=nn[KMG].
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 9 ++-
drivers/pci/pci.c | 17 ++---
drivers/pci/setup-bus.c
/20190531171216.20532-2-log...@deltatee.com/T/#u
Solves bug report: https://bugzilla.kernel.org/show_bug.cgi?id=203243
Reported-by: Kit Chow
Reported-by: Nicholas Johnson
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 29 +++--
1 file changed, 19 insertions(+), 10
On Sun, Jun 16, 2019 at 03:56:19AM +0800, Bjorn Helgaas wrote:
> [+cc Ben, Logan]
>
> Ben, Logan, since you're looking at the resource code, maybe you'd be
> interested in this as well?
>
> On Wed, May 22, 2019 at 02:30:30PM +, Nicholas Johnson wrote:
> >
his will also make at least one other person
very happy, providing a solution where none previously existed (if this
is accepted, I will be answering their question with this patch):
https://superuser.com/questions/1054657/how-can-i-reserve-hotplug-bridges-memory-only-for-prefetchable-memory
ion, and
potentially others which are yet to be encountered.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 203 ++--
1 file changed, 110 insertions(+), 93 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index ed9604
Change block comments to accepted style with asterisks on each line.
Justify block comments to 80-character limit to reduce the number of
lines where possible.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 265
1 file changed, 130
is easy to remove old kernel parameters from the source
when it is deemed that sufficient time has passed to allow users to
migrate to the new kernel parameters.
Update documentation to reflect changes.
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 21
assigns resources.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 0ce641282..efe899b02 100644
--- a/drivers/pci/setup-bus.c
+++ b
.
Nicholas Johnson (5):
PCI: Consider alignment of hot-added bridges when distributing
available resources
PCI: Cleanup comments in setup-bus.c to meet kernel coding style
guidelines
PCI: Fix serious bug when sizing bridges with additional size
PCI: modify kernel parameters to
ion, and
potentially others which are yet to be encountered.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 203 ++--
1 file changed, 110 insertions(+), 93 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index ed9604
assigns resources.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 0ce641282..efe899b02 100644
--- a/drivers/pci/setup-bus.c
+++ b
Change block comments to accepted style with asterisks on each line.
Justify block comments to 80-character limit to reduce the number of
lines where possible.
Signed-off-by: Nicholas Johnson
---
drivers/pci/setup-bus.c | 265
1 file changed, 130
reflect the naming changes and become
more readable.
Signed-off-by: Nicholas Johnson
---
.../admin-guide/kernel-parameters.txt | 10
drivers/pci/pci.c | 23 ++-
drivers/pci/setup-bus.c | 23
Add kernel parameter pci=hpmemprefsize=nn[KMG] to control MMIO_PREF
size.
Change behaviour of pci=hpmemsize=nn[KMG] to only control MMIO size,
rather than controlling both MMIO and MMIO_PREF sizes.
Update kernel-parameters documentation to reflect the above changes.
Signed-off-by: Nicholas
al but least user-facing one planned. The most exciting changes
are yet to come.
Signed-off-by: Nicholas-Johnson-opensource
---
drivers/pci/setup-bus.c | 172
1 file changed, 88 insertions(+), 84 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/driver
On Sat, May 02, 2020 at 12:09:13PM +0200, Takashi Iwai wrote:
> On Sat, 02 May 2020 09:27:31 +0200,
> Takashi Iwai wrote:
> >
> > On Sat, 02 May 2020 09:17:28 +0200,
> > Lukas Wunner wrote:
> > >
> > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote:
> > > > --- a/drivers/gpu/drm/amd
68 matches
Mail list logo
