Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-29 Thread Neil Horman
On Thu, Jun 28, 2018 at 02:37:09PM -0600, Jason Gunthorpe wrote: > On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > > On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > > >

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-29 Thread Neil Horman
On Thu, Jun 28, 2018 at 09:15:46PM +, Adit Ranadive wrote: > On 6/28/18, 1:37 PM, "Jason Gunthorpe" wrote: > > On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > > > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > > >

[PATCH v2] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-29 Thread Neil Horman
accordingly. This solution has been tested by myself and the reporter with successful results. This fix also allows the pvrdma driver to find its underlying ethernet device in the event that vmxnet3 is loaded after pvrdma, which it was not able to do before. Signed-off-by: Neil Horman Reported-by: ruq

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-14 Thread Neil Horman
On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: > On Mon, Apr 30, 2018 at 8:09 PM, syzbot > wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:5d1365940a68 Merge > > git://git.kernel.org/pub/scm/linux/kerne... > > git tree: net-next > > cons

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-19 Thread Neil Horman
On Mon, Jun 18, 2018 at 02:58:59PM -0700, Andy Lutomirski wrote: > On Tue, Jun 12, 2018 at 10:45 AM Neil Horman wrote: > > > > On Mon, Jun 11, 2018 at 09:55:29PM -0700, Andy Lutomirski wrote: > > > On Mon, Jun 11, 2018 at 4:52 AM Neil Horman wrote: > > > > &

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-19 Thread Neil Horman
On Tue, Jun 19, 2018 at 05:57:53PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 11:24:12AM -0700, Dave Hansen wrote: > > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > > SGX has a set of data structures to maintain information about the > > > enclaves > > > and their security proper

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-12 Thread Neil Horman
On Mon, Jun 11, 2018 at 09:55:29PM -0700, Andy Lutomirski wrote: > On Mon, Jun 11, 2018 at 4:52 AM Neil Horman wrote: > > > > On Sun, Jun 10, 2018 at 10:17:13PM -0700, Andy Lutomirski wrote: > > > > On Jun 9, 2018, at 10:39 PM, Andy Lutomirski wrote: > > > &g

Re: [PATCHv2 net 0/3] net: add support for flex_array_resize in flex_array

2018-12-12 Thread Neil Horman
On Tue, Dec 11, 2018 at 10:50:00PM -0800, David Miller wrote: > From: Xin Long > Date: Fri, 7 Dec 2018 14:30:32 +0800 > > > Without the support for the total_nr_elements's growing or shrinking > > dynamically, flex_array is not that 'flexible'. Like when users want > > to change the size, they h

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-13 Thread Neil Horman
On Wed, Dec 12, 2018 at 05:40:23PM +, Xue Chaojing wrote: > There is no need to schedule a different tasklet for refill, > This patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing > --- > drivers/net/ethernet/huawei/

Re: [PATCH 6/6] Drop flex_arrays

2018-12-13 Thread Neil Horman
On Thu, Dec 13, 2018 at 06:41:11AM -0800, Matthew Wilcox wrote: > On Thu, Dec 13, 2018 at 09:30:47PM +0900, Xin Long wrote: > > On Sat, Sep 8, 2018 at 1:57 AM Kent Overstreet > > wrote: > > > > > > All existing users have been converted to generic radix trees > > NAK, SCTP is still using flex_arra

Re: [PATCH 6/6] Drop flex_arrays

2018-12-13 Thread Neil Horman
On Thu, Dec 13, 2018 at 08:45:33AM -0800, Matthew Wilcox wrote: > On Thu, Dec 13, 2018 at 10:51:49AM -0500, Neil Horman wrote: > > On Thu, Dec 13, 2018 at 06:41:11AM -0800, Matthew Wilcox wrote: > > > On Thu, Dec 13, 2018 at 09:30:47PM +0900, Xin Long wrote: > > > >

Re: [PATCH 6/6] Drop flex_arrays

2018-12-18 Thread Neil Horman
On Mon, Dec 17, 2018 at 07:50:11AM -0500, Kent Overstreet wrote: > On Thu, Dec 13, 2018 at 01:09:17PM -0500, Neil Horman wrote: > > On Thu, Dec 13, 2018 at 08:45:33AM -0800, Matthew Wilcox wrote: > > > On Thu, Dec 13, 2018 at 10:51:49AM -0500, Neil Horman wrote: > > > &

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-17 Thread Neil Horman
On Sun, Dec 16, 2018 at 10:32:34PM +, Xue Chaojing wrote: > In rx_alloc_pkts(), there is no need to schedule a different tasklet for > refill and it will cause some extra overhead. this patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing >

Re: [PATCH net] sctp: initialize sin6_flowinfo for ipv6 addrs in sctp_inet6addr_event

2018-12-10 Thread Neil Horman
gned long ev, > if (addr) { > addr->a.v6.sin6_family = AF_INET6; > addr->a.v6.sin6_port = 0; > + addr->a.v6.sin6_flowinfo = 0; > addr->a.v6.sin6_addr = ifa->addr; > addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex; > addr->valid = 1; > -- > 2.1.0 > > Acked-by: Neil Horman

Re: [Lksctp-developers] [2.6 patch] make sctp_addto_param() static

2007-09-10 Thread Neil Horman
On Sun, Sep 09, 2007 at 10:25:50PM +0200, Adrian Bunk wrote: > sctp_addto_param() can become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > ACK, seems reasonable to me. Neil -- /*** *Neil Horman [EMAIL PROT

Re: [Lksctp-developers] [-mm patch] net/sctp/socket.c: make 3 variables static

2007-09-10 Thread Neil Horman
kes the following needlessly globalvariables static: > - sctp_memory_pressure > - sctp_memory_allocated > - sctp_sockets_allocated > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Looks fine to me Acked-by: Neil Horman <[EMAIL PROTECTED]> Neil -- /***

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-08-17 Thread Neil Horman
d *)0) != 0) { > perror("ptrace"); > } > if (waitpid(kid, &rval, 0) != kid) { > perror("waitpid"); > } > if (ptrace(PTRACE_CONT, kid, (void *)0, (void *)0) != 0) { > perror("ptrac

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-17 Thread Neil Horman
On Fri, Aug 17, 2007 at 12:45:47PM -0700, Andrew Morton wrote: > On Fri, 17 Aug 2007 06:59:18 -0400 > Neil Horman <[EMAIL PROTECTED]> wrote: > > > Currently, there exists no method for a process to query the resource > > limits of another process. They can be infer

Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

2007-08-18 Thread Neil Horman
On Sat, Aug 18, 2007 at 02:22:28AM +0400, Oleg Nesterov wrote: > Neil Horman wrote: > > > > +static int proc_pid_limits(struct task_struct *task, char *buffer) > > +{ > > + unsigned int i; > > + int count = 0; > > + char *bufptr = buffer; > &

Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

2007-08-18 Thread Neil Horman
determined. Given that this information can be usefull to know during the debugging of an application, I've written this patch which exports all of a processes limits via /proc//limits. Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> ba

Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

2007-08-18 Thread Neil Horman
top of 2.6.23-rc2-mm1. Signed-off-by: Neil Horman <[EMAIL PROTECTED]> base.c | 77 + 1 file changed, 77 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index ed2b224..86130b0 100644 --- a/fs/proc/base.c +++ b/f

Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

2007-08-19 Thread Neil Horman
itten this patch which exports all of a processes limits via /proc//limits. Signed-off-by: Neil Horman <[EMAIL PROTECTED]> base.c | 75 + 1 file changed, 75 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c in

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-23 Thread Neil Horman
On Wed, Aug 22, 2007 at 09:40:37PM -0500, Matt Mackall wrote: > On Tue, Aug 21, 2007 at 11:56:11AM -0700, Andy Isaacson wrote: > > On Fri, Aug 17, 2007 at 12:45:47PM -0700, Andrew Morton wrote: > > > On Fri, 17 Aug 2007 06:59:18 -0400 > > > Neil Horman <[EMAIL PROTEC

Re: Fwd: Question on SCTP ABORT chunk is generated when the association_max_retrans is reached

2015-01-26 Thread Neil Horman
On Fri, Jan 23, 2015 at 01:30:55PM -0500, Vlad Yasevich wrote: > On 01/23/2015 12:10 PM, Daniel Borkmann wrote: > > On 01/23/2015 05:05 PM, Vlad Yasevich wrote: > >> On 01/23/2015 06:50 AM, Daniel Borkmann wrote: > >>> On 01/23/2015 11:25 AM, Sun Paul wrote: > >>> ... > I would like to check t

Re: [PATCH v10 0/2] crypto: AF_ALG: add AEAD and RNG support

2015-01-14 Thread Neil Horman
On Wed, Jan 14, 2015 at 04:52:29AM +0100, Stephan Mueller wrote: > Hi, > > This patch set adds AEAD and RNG support to the AF_ALG interface > exported by the kernel crypto API. By extending AF_ALG with AEAD and RNG > support, all cipher types the kernel crypto API allows access to are > now access

Re: [PATCH v10 0/2] crypto: AF_ALG: add AEAD and RNG support

2015-01-14 Thread Neil Horman
On Wed, Jan 14, 2015 at 04:31:44PM +0100, Stephan Mueller wrote: > Am Mittwoch, 14. Januar 2015, 22:00:11 schrieb Herbert Xu: > > Hi Herbert, > > > On Wed, Jan 14, 2015 at 04:46:31AM -0500, Neil Horman wrote: > > > On Wed, Jan 14, 2015 at 04:52:29AM +0100, Stepha

Re: [PATCH] netxen_nic: use spin_[un]lock_bh around tx_clean_lock

2015-04-30 Thread Neil Horman
gt; } > cmd_buf++; > } > - spin_unlock(&adapter->tx_clean_lock); > + spin_unlock_bh(&adapter->tx_clean_lock); > } > > void netxen_free_sw_resources(struct netxen_adapter *adapter) > -- > 1.8.3.1 > Acked-by: N

Re: [PATCH v4] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-18 Thread Neil Horman
_priomap. > > > >2. only call extend_netdev_table when map->priomap_len < max_len, > >this will make sure array size of dev->map->priomap always > >bigger than any prioidx. > > > >3. add a function write_update_netdev_table to make codes clear. > >

Re: [PATCH v4] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-18 Thread Neil Horman
On Wed, Jul 18, 2012 at 07:10:18AM -0700, John Fastabend wrote: > On 7/18/2012 5:21 AM, Neil Horman wrote: > >On Tue, Jul 17, 2012 at 01:47:25PM -0700, John Fastabend wrote: > >>On 7/12/2012 12:50 AM, Gao feng wrote: > >>>there are some out of bound accesses in

Re: [PATCH v4] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-19 Thread Neil Horman
On Thu, Jul 19, 2012 at 09:00:51AM +0800, Li Zefan wrote: > > static struct cgroup_subsys_state *cgrp_create(struct cgroup *cgrp) > > > { > > struct cgroup_netprio_state *cs; > > - int ret; > > + int ret = -EINVAL; > > > > cs = kzalloc(size

Re: [PATCH] net, cgroup: Fix boot failure due to iteration of uninitialized list

2012-07-19 Thread Neil Horman
On Thu, Jul 19, 2012 at 09:57:37PM +0530, Srivatsa S. Bhat wrote: > After commit ef209f15 (net: cgroup: fix access the unallocated memory in > netprio cgroup), boot fails with the following NULL pointer dereference: > > Initializing cgroup subsys devices > Initializing cgroup subsys freezer > Init

Re: [PATCH] net, cgroup: Fix boot failure due to iteration of uninitialized list

2012-07-20 Thread Neil Horman
On Fri, Jul 20, 2012 at 03:34:47PM +0530, Srivatsa S. Bhat wrote: > On 07/19/2012 10:14 PM, Neil Horman wrote: > > On Thu, Jul 19, 2012 at 09:57:37PM +0530, Srivatsa S. Bhat wrote: > >> After commit ef209f15 (net: cgroup: fix access the unallocated memory in > >> netpr

Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

2015-06-05 Thread Neil Horman
ion directly and thus remove the no longer > required if statement due to this function now being declared > as bool. > > Signed-off-by: Nicholas Krause Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

2015-06-06 Thread Neil Horman
is only way for rest > of us to see what is in his patch. > > Thanks. Sure, though that begs the question, why is he banned from vger? Is it his gmail address, or something more directed? Neil > > On 06/05/2015 03:16 PM, Neil Horman wrote: > >> This makes the fun

Re: [PATCH] sctp: Make the function sctp_chunk_abandoned bool

2015-06-03 Thread Neil Horman
return 0; > + return false; > > if (time_after(jiffies, msg->expires_at)) > - return 1; > + return true; > > - return 0; > + return false; > } > > /* This chunk (and consequently entire message) has failed in it

Re: [PATCH] sctp:Make the function sctp_assoc_lookup_laddr bool

2015-06-04 Thread Neil Horman
On Wed, Jun 03, 2015 at 08:51:07AM -0400, Nicholas Krause wrote: > This makes the function sctp_assoc_lookup_laddr bool due to this > function only returning either one or zero as its return value. > > Signed-off-by: Nicholas Krause > --- > include/net/sctp/structs.h | 4 ++-- > net/sctp/associo

Re: [PATCH 25/98] sctp.h: use __u8 and __u32 from linux/types.h

2015-06-01 Thread Neil Horman
h_chunks[]; > + __u8gauth_chunks[]; > }; > > /* The broken spelling has been released already in lksctp-tools header, > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majo

Re: [PATCH] [net-next] sctp: fix unused lable warning

2018-03-28 Thread Neil Horman
> > +#ifdef CONFIG_PROC_FS > err_init_proc: > cleanup_sctp_mibs(net); > +#endif > err_init_mibs: > sctp_sysctl_net_unregister(net); > err_sysctl_register: > -- > 2.9.0 > > Acked-by: Neil Horman

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > Make sctp_setsockopt_events() able to accept sctp_event_subscribe > structures longer than the current definitions. > > This should prevent unjustified setsockopt() failures due to struct > sctp_event_subscribe extensions (as in 4.11

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe > >> structures longer than the current d

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make sctp_setsockopt_e

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: > > > On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > >> > >> > >> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > >>> On Wed, Feb 06, 2019 at 12:14:30PM -0800,

[PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-04-02 Thread Neil Horman
be filled (owing to the fact that it expects indexes 14 and 15 to be filled). Bring the expected behavior into alignment by casting index 14 to an unsignled long pointer, and xoring that in instead. Tested successfully by myself Signed-off-by: Neil Horman Reported-by: Steve Grubb CC: "Theod

Re: [PATCH ghak90 V6 05/10] audit: add contid support for signalling the audit daemon

2019-04-09 Thread Neil Horman
ow for just this message. A better approach would be to do this now, and in a subsequent patch, create an AUDIT version 2 netlink protocol that converts all the messages we send to that format for consistency. Such a change would be large and warrant its own patch set and review. I'm go

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-25 Thread Neil Horman
On Mon, Feb 25, 2019 at 09:20:44PM +0800, Xin Long wrote: > On Mon, Feb 25, 2019 at 8:47 PM Neil Horman wrote: > > > > On Mon, Feb 25, 2019 at 07:25:37PM +0800, Xin Long wrote: > > > sctp_hdr(skb) only works when skb->transport_header is set properly. >

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-26 Thread Neil Horman
On Tue, Feb 26, 2019 at 12:15:54AM +0800, Xin Long wrote: > On Mon, Feb 25, 2019 at 10:08 PM Neil Horman wrote: > > > > On Mon, Feb 25, 2019 at 09:20:44PM +0800, Xin Long wrote: > > > On Mon, Feb 25, 2019 at 8:47 PM Neil Horman wrote: > > > > > > > &g

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-27 Thread Neil Horman
On Wed, Feb 27, 2019 at 08:53:26PM +0800, Xin Long wrote: > On Tue, Feb 26, 2019 at 8:29 PM Neil Horman wrote: > > > > On Tue, Feb 26, 2019 at 12:15:54AM +0800, Xin Long wrote: > > > On Mon, Feb 25, 2019 at 10:08 PM Neil Horman > > > wrote: > > > &g

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-05 Thread Neil Horman
On Tue, Aug 04, 2020 at 04:14:14PM -0700, David Miller wrote: > From: izabela.bakoll...@gmail.com > Date: Tue, 4 Aug 2020 18:09:08 +0200 > > > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > > return -EOPNOTSUPP; > > } > > > > +static int net_dm_interface_start(st

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-11-01 Thread Neil Horman
On Fri, Nov 01, 2013 at 12:45:29PM -0700, Joe Perches wrote: > On Fri, 2013-11-01 at 13:37 -0400, Neil Horman wrote: > > > I think it would be better if we just did the prefetch here > > and re-addressed this area when AVX (or addcx/addox) instructions were > > avai

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-11-01 Thread Neil Horman
On Fri, Nov 01, 2013 at 01:26:52PM -0700, Joe Perches wrote: > On Fri, 2013-11-01 at 15:58 -0400, Neil Horman wrote: > > On Fri, Nov 01, 2013 at 12:45:29PM -0700, Joe Perches wrote: > > > On Fri, 2013-11-01 at 13:37 -0400, Neil Horman wrote: > > > > > > > I

Re: [RFC PATCH] PCI: export MSI mode using attributes, not kobjects

2013-11-01 Thread Neil Horman
On Fri, Nov 01, 2013 at 05:40:02PM -0600, Bjorn Helgaas wrote: > On Tue, Oct 29, 2013 at 3:46 PM, Greg Kroah-Hartman > wrote: > > From: Greg Kroah-Hartman > > > > The PCI MSI sysfs code is a mess with kobjects for things that don't > > really need to be kobjects. This patch creates attributes dy

x86: Enhance perf checksum profiling and x86 implementation

2013-11-06 Thread Neil Horman
500B Bytes ... 0.955977 Cycle/Byte With prefetch: [root@rdma-dev-02 perf]# ./perf bench mem csum -r x86-64-csum -l 1500B -s 512MB -i 100 -c # Running mem/csum benchmark... # Copying 1500B Bytes ... 0.922540 Cycle/Byte About a 3% improvement. Signed-off-by: Neil Horman CC: sebastien.du...@b

[PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-06 Thread Neil Horman
do_csum was identified via perf recently as a hot spot when doing receive on ip over infiniband workloads. After alot of testing and ideas, we found the best optimization available to us currently is to prefetch the entire data buffer prior to doing the checksum Signed-off-by: Neil Horman CC

[PATCH v2 1/2] perf: Add csum benchmark tests to perf

2013-11-06 Thread Neil Horman
Adding perf benchmarks to test the arch independent and x86[64] versions of do_csum to the perf suite. Other arches can be added as needed. To avoid creating a new suite instance (as I didn't think it was warranted), the csum benchmarks have been added to the mem suite Signed-off-by:

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-06 Thread Neil Horman
On Wed, Nov 06, 2013 at 10:34:29AM -0500, Dave Jones wrote: > On Wed, Nov 06, 2013 at 10:23:19AM -0500, Neil Horman wrote: > > do_csum was identified via perf recently as a hot spot when doing > > receive on ip over infiniband workloads. After alot of testing and > > ide

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-06 Thread Neil Horman
On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: > On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 10:34:29AM -0500, Dave Jones wrote: > > > On Wed, Nov 06, 2013 at 10:23:19AM -0500, Neil Horman wrote: > > > > do_csum wa

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-06 Thread Neil Horman
On Wed, Nov 06, 2013 at 10:23:10AM -0800, Eric Dumazet wrote: > On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote: > > > My guess was that the whole comment was made in reference to the fact that > > checksum offload negated all these advantages. Thats not so true a

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-06 Thread Neil Horman
On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: > On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 10:34:29AM -0500, Dave Jones wrote: > > > On Wed, Nov 06, 2013 at 10:23:19AM -0500, Neil Horman wrote: > > > > do_csum wa

[PATCH] x86: adjust irq remapping quirk for older revisions of 5500/5520 chipsets

2014-03-12 Thread Neil Horman
A while back I posted this commit: commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 Author: Neil Horman Date: Tue Apr 16 16:38:32 2013 -0400 iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets Which properly disables irq remapping on the 5500/5520 chipsets that don&#

Re: [PATCH] x86: adjust irq remapping quirk for older revisions of 5500/5520 chipsets

2014-03-12 Thread Neil Horman
On Wed, Mar 12, 2014 at 02:44:33PM -0400, Neil Horman wrote: > A while back I posted this commit: > > commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 > Author: Neil Horman > Date: Tue Apr 16 16:38:32 2013 -0400 > > iommu/vt-d: add quirk for broken interrupt remap

[PATCH v2] x86: adjust irq remapping quirk for older revisions of 5500/5520 chipsets

2014-03-12 Thread Neil Horman
A while back I posted this commit: commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 Author: Neil Horman Date: Tue Apr 16 16:38:32 2013 -0400 iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets Which properly disables irq remapping on the 5500/5520 chipsets that don&#

Re: [PATCH v2] x86: adjust irq remapping quirk for older revisions of 5500/5520 chipsets

2014-03-13 Thread Neil Horman
On Wed, Mar 12, 2014 at 11:18:29PM +0100, Thomas Gleixner wrote: > On Wed, 12 Mar 2014, Neil Horman wrote: > > > A while back I posted this commit: > > > > commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 > > Author: Neil Horman > > Date: Tue Apr 16 16:38:3

Re: [PATCH] vmxnet3: fix building without CONFIG_PCI_MSI

2014-03-13 Thread Neil Horman
; > To fix this, use the same #ifdef in the caller that exists around > the function definition. > > Signed-off-by: Arnd Bergmann > Cc: Neil Horman > Cc: Shreyas Bhatewara > Cc: "VMware, Inc." > Cc: "David S. Miller" > Cc: sta...@vger.kernel.org

Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/

2014-04-07 Thread Neil Horman
On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote: > Hi, > > I'm using cscope to browse kernel sources, but I'm facing warnings from > the tool since following commit: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=22d651dcef536c75f75537290bf3da5038e68b6

Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/

2014-04-07 Thread Neil Horman
On Mon, Apr 07, 2014 at 02:42:59PM +0200, Gerhard Sittig wrote: > On Mon, 2014-04-07 at 06:42 -0400, Neil Horman wrote: > > > > On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote: > > > > > > [ ... ] > > > > > > cscope reports

Re: [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-07 Thread Neil Horman
On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jason Wang wrote: > On 01/06/2014 08:42 PM, Neil Horman wrote: > > On Mon, Jan 06, 2014 at 11:21:07AM +0800, Jason Wang wrote: > >> Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). > >> The >

Re: [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-08 Thread Neil Horman
On Wed, Jan 08, 2014 at 11:21:21AM +0800, Jason Wang wrote: > On 01/07/2014 09:17 PM, Neil Horman wrote: > > On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jason Wang wrote: > >> On 01/06/2014 08:42 PM, Neil Horman wrote: > >>> On Mon, Jan 06, 2014 at 11:2

Re: [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-09 Thread Neil Horman
On Thu, Jan 09, 2014 at 04:28:49PM +0800, Jason Wang wrote: > On 01/08/2014 10:40 PM, Neil Horman wrote: > > On Wed, Jan 08, 2014 at 11:21:21AM +0800, Jason Wang wrote: > >> On 01/07/2014 09:17 PM, Neil Horman wrote: > >>> On Tue, Jan 07, 2014 at 11:42:24AM +0800, Jas

Re: [PATCH net V2 1/2] macvlan: forbid L2 fowarding offload for macvtap

2014-01-09 Thread Neil Horman
onization. > > Fix this by forbidding L2 forwarding for macvtap. > > Cc: John Fastabend > Cc: Neil Horman > Signed-off-by: Jason Wang > --- > drivers/net/macvlan.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/net

Re: [PATCH net V2 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-09 Thread Neil Horman
gt; > In the future, it was also required for macvtap l2 forwarding support since it > provides a necessary synchronization method. > > Cc: John Fastabend > Cc: Neil Horman > Cc: e1000-de...@lists.sourceforge.net > Signed-off-by: Jason Wang > > --- > Changes from

Re: [PATCH net V2 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-10 Thread Neil Horman
On Fri, Jan 10, 2014 at 03:03:01PM +0800, Jason Wang wrote: > On 01/09/2014 08:31 PM, Neil Horman wrote: > > On Thu, Jan 09, 2014 at 05:37:32PM +0800, Jason Wang wrote: > >> Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). > >> The >

Re: [PATCH net V3 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-10 Thread Neil Horman
o_dfwd_start_xmit() and we can just reuse the code of > dev_queue_xmit() to do the transmission. > > In the future, it was also required for macvtap l2 forwarding support since it > provides a necessary synchronization method. > > Cc: John Fastabend > Cc: Neil Horman

Re: [PATCH v3 1/3] msi: free msi_desc entry only after we've released the kobject

2013-11-26 Thread Neil Horman
ched. > > > > > > Also, remove the same functionality from populate_msi_sysfs(), cause on > > > failure we anyway call free_msi_irqs(), which will take care of all the > > > kobjects properly. > > > > > > And add the forgotten pci_dev_put(pd

Re: Supporting 4 way connections in LKSCTP

2013-11-27 Thread Neil Horman
On Wed, Nov 27, 2013 at 07:10:49AM +0800, Sun Paul wrote: > Hi Vlad > > Thank for your reply. If it is based on the destination IP to find the > best route, why the problem didn't happen on single-homing sample? > Because You only ever use one address from NODE A (12.1.1.1) > In the single-homin

Re: [PATCH] PCI: export MSI mode using attributes, not kobjects

2013-11-28 Thread Neil Horman
to see if irqbalance works as-is or not? > ACK, Testing with git-head irqbalance on F19 with this patch and it works fine. Thanks! Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-07 Thread Neil Horman
On Wed, Nov 06, 2013 at 12:19:52PM -0800, Andi Kleen wrote: > Neil Horman writes: > > > do_csum was identified via perf recently as a hot spot when doing > > receive on ip over infiniband workloads. After alot of testing and > > ideas, we found the best optimization avai

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-08 Thread Neil Horman
On Wed, Nov 06, 2013 at 12:07:38PM -0800, Joe Perches wrote: > On Wed, 2013-11-06 at 15:02 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: > [] > > > __always_inline instead of inline > > > static __always_inline void p

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-08 Thread Neil Horman
On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: > On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 10:34:29AM -0500, Dave Jones wrote: > > > On Wed, Nov 06, 2013 at 10:23:19AM -0500, Neil Horman wrote: > > > > do_csum wa

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-08 Thread Neil Horman
On Fri, Nov 08, 2013 at 08:51:07AM -0800, Joe Perches wrote: > On Fri, 2013-11-08 at 11:25 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 12:07:38PM -0800, Joe Perches wrote: > > > On Wed, 2013-11-06 at 15:02 -0500, Neil Horman wrote: > > > > On Wed, Nov 06,

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-08 Thread Neil Horman
On Fri, Nov 08, 2013 at 11:17:39AM -0800, Joe Perches wrote: > On Fri, 2013-11-08 at 14:07 -0500, Neil Horman wrote: > > On Fri, Nov 08, 2013 at 08:51:07AM -0800, Joe Perches wrote: > > > On Fri, 2013-11-08 at 11:25 -0500, Neil Horman wrote: > > > > On Wed, Nov 06,

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-08 Thread Neil Horman
On Fri, Nov 08, 2013 at 11:33:13AM -0800, Joe Perches wrote: > On Fri, 2013-11-08 at 14:01 -0500, Neil Horman wrote: > > On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: > > > On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote: > > > > On Wed, Nov 06,

Re: [PATCH v2 2/2] x86: add prefetching to do_csum

2013-11-11 Thread Neil Horman
On Fri, Nov 08, 2013 at 12:29:07PM -0800, Joe Perches wrote: > On Fri, 2013-11-08 at 15:14 -0500, Neil Horman wrote: > > On Fri, Nov 08, 2013 at 11:33:13AM -0800, Joe Perches wrote: > > > On Fri, 2013-11-08 at 14:01 -0500, Neil Horman wrote: > > > > On Wed, Nov 06,

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
0.8150 0.8147 0.8149 0.8147 > 64KB 128MB 100 0.8013 0.8014 0.8013 0.8020 0.8041 0.8015 0.8033 > 64KB 256MB 100 0.7956 0.7959 0.7956 0.7976 0.7981 0.7967 0.7973 > 64KB 512MB 100 0.7934 0.7932 0.7937 0.7951 0.7954 0.7943 0.7948 > > Forwar

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > Hi again Neil. > > Forwarding on to netdev with a concern as to how often > do_csum is used via csum_partial for very short headers > and what impact any prefetch would have there. > > Also, what changed in your test environment? > >

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Tue, Nov 12, 2013 at 09:33:35AM -0800, Joe Perches wrote: > On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: > > On Mon, Nov 11, 2013 at 05:42:22PM -0800, Joe Perches wrote: > > > Hi again Neil. > > > > > > Forwarding on to netdev with a concern as to

Re: [Fwd: Re: [PATCH v2 2/2] x86: add prefetching to do_csum]

2013-11-12 Thread Neil Horman
On Tue, Nov 12, 2013 at 12:38:01PM -0800, Joe Perches wrote: > On Tue, 2013-11-12 at 14:50 -0500, Neil Horman wrote: > > On Tue, Nov 12, 2013 at 09:33:35AM -0800, Joe Perches wrote: > > > On Tue, 2013-11-12 at 12:12 -0500, Neil Horman wrote: > [] > > > > So, t

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-16 Thread Neil Horman
On Mon, Oct 14, 2013 at 03:18:47PM -0700, Eric Dumazet wrote: > On Mon, 2013-10-14 at 14:19 -0700, Eric Dumazet wrote: > > On Mon, 2013-10-14 at 16:28 -0400, Neil Horman wrote: > > > > > So, early testing results today. I wrote a test module that, allocated a > >

Re: linux-next: manual merge of the net-next tree

2013-10-18 Thread Neil Horman
On Fri, Oct 18, 2013 at 01:58:14PM +0100, Mark Brown wrote: > Today's linux-next merge of the next-next tree got a conflict in > include/net/dst.h between e87b3998d (net: dst: provide accessor function > to dst->xfrm) in the net tree and a4023dd01 (dst.h: Remove extern from > function prototypes) i

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-18 Thread Neil Horman
On Sat, Oct 12, 2013 at 03:29:24PM -0700, H. Peter Anvin wrote: > On 10/11/2013 09:51 AM, Neil Horman wrote: > > Sébastien Dugué reported to me that devices implementing ipoib (which don't > > have > > checksum offload hardware were spending a significant amo

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-18 Thread Neil Horman
> > Your benchmark uses a single 4K page, so data is _super_ hot in cpu > caches. > ( prefetch should give no speedups, I am surprised it makes any > difference) > > Try now with 32 huges pages, to get 64 MBytes of working set. > > Because in reality we never csum_partial() data in cpu cache. >

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-18 Thread Neil Horman
On Fri, Oct 18, 2013 at 10:20:35AM -0700, Eric Dumazet wrote: > On Fri, 2013-10-18 at 12:50 -0400, Neil Horman wrote: > > > > > > for(i=0;i<10;i++) { > > sum = csum_partial(buf+offset, PAGE_SIZE, sum); > > offset = (offset &l

Re: [PATCH] net: sctp: find the correct highest_new_tsn in sack

2013-11-22 Thread Neil Horman
tsn; > + if (TSN_lt(*highest_new_tsn_in_sack, tsn)) > + *highest_new_tsn_in_sack = tsn; > bytes_acked += sctp_data_size(tchunk); > if (!tchunk->transport) > migrate_bytes += s

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Neil Horman
if (tchunk->tsn_gap_acked) { > pr_debug("%s: receiver reneged on data > TSN:0x%x\n", > -- > 1.8.4.3 > > Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-11 Thread Neil Horman
n hardware that has only a single alu (an extra addition is introduced). Since addition in commutative, the result is the same, only faster Signed-off-by: Neil Horman CC: sebastien.du...@bull.net CC: Thomas Gleixner CC: Ingo Molnar CC: "H. Peter Anvin" CC: x...@kernel.org --

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-13 Thread Neil Horman
On Sat, Oct 12, 2013 at 07:21:24PM +0200, Ingo Molnar wrote: > > * Neil Horman wrote: > > > Sébastien Dugué reported to me that devices implementing ipoib (which > > don't have checksum offload hardware were spending a significant amount > > of time comput

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-13 Thread Neil Horman
On Sat, Oct 12, 2013 at 03:29:24PM -0700, H. Peter Anvin wrote: > On 10/11/2013 09:51 AM, Neil Horman wrote: > > Sébastien Dugué reported to me that devices implementing ipoib (which don't > > have > > checksum offload hardware were spending a significant amo

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-14 Thread Neil Horman
On Sun, Oct 13, 2013 at 09:38:33PM -0700, Andi Kleen wrote: > Neil Horman writes: > > > Sébastien Dugué reported to me that devices implementing ipoib (which don't > > have > > checksum offload hardware were spending a significant amount of time > > computing

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-14 Thread Neil Horman
On Sat, Oct 12, 2013 at 07:21:24PM +0200, Ingo Molnar wrote: > > * Neil Horman wrote: > > > Sébastien Dugué reported to me that devices implementing ipoib (which > > don't have checksum offload hardware were spending a significant amount > > of time comput

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-15 Thread Neil Horman
On Tue, Oct 15, 2013 at 09:32:48AM +0200, Ingo Molnar wrote: > > * Neil Horman wrote: > > > On Sat, Oct 12, 2013 at 07:21:24PM +0200, Ingo Molnar wrote: > > > > > > * Neil Horman wrote: > > > > > > > Sébastien Dugué reported to me that

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-15 Thread Neil Horman
On Mon, Oct 14, 2013 at 02:07:48PM -0700, Eric Dumazet wrote: > On Mon, 2013-10-14 at 09:49 +0200, Ingo Molnar wrote: > > * Andi Kleen wrote: > > > > > Neil Horman writes: > > > > > > > Sébastien Dugué reported to me that devices implementing ipoi

<    1   2   3   4   5   6   7   >