Re: [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver

2012-11-27 Thread Naveen Krishna Ch
Hello Felipe, Thomas, Thanks for your time and valuable comments, I will post the next version with you comments addressed. On 27 November 2012 19:04, Thomas Abraham wrote: > > On 27 November 2012 18:30, Naveen Krishna Chatradhi > wrote: > > Adds support for High Speed I2C driver found in Exyno

Re: [PATCH] i2c: exynos5: add High Speed I2C controller driver

2013-03-20 Thread Naveen Krishna Ch
On 12 March 2013 18:43, Simon Glass wrote: > [please excuse my mailer html confusion] > > Hi Naveen, > > On Mon, Mar 11, 2013 at 9:32 PM, Naveen Krishna Chatradhi > wrote: >> >> Adds support for High Speed I2C driver found in Exynos5 and later >> SoCs from Samsung. This driver currently supports

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-12 Thread Naveen Krishna Ch
On 13 February 2013 02:37, Guenter Roeck wrote: > On Wed, Jan 23, 2013 at 04:58:06AM -, Naveen Krishna Chatradhi wrote: >> This patch add an ADC IP found on EXYNOS5 series socs from Samsung. >> Also adds the Documentation for device tree bindings. >> >> Signed-off-by: Naveen Krishna Chatradhi

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-29 Thread Naveen Krishna Ch
On 26 January 2013 16:27, Jonathan Cameron wrote: > On 01/24/2013 04:58 AM, Naveen Krishna Chatradhi wrote: >> This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 >> from Samsung. Also adds the Documentation for device tree bindings. >> >> Signed-off-by: Naveen Krishna Chatradhi

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Naveen Krishna Ch
On 24 January 2013 15:24, Lars-Peter Clausen wrote: > > On 01/24/2013 01:42 AM, Doug Anderson wrote: > > Lars, > > > > On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen wrote: > >>> Few doubts regarding the mappings and child device handling. > >>> Kindly, suggest me better methods. > >> > >> T

Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc

2013-03-15 Thread Naveen Krishna Ch
Doug, On 14 March 2013 02:09, Doug Anderson wrote: > The exynos ADC won't work without a regulator called "vdd" and a clock > called "adc". Document this fact in the device tree bindings. > > Signed-off-by: Doug Anderson Thanks for the correction. Clocks and regulator is needed. I missed it out

Re: [PATCH v2 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow

2013-03-15 Thread Naveen Krishna Ch
Doug, On 14 March 2013 02:10, Doug Anderson wrote: > Hook up the exynos5250-snow thermistors via the device tree now that > there's a driver available to use them. > > Signed-off-by: Doug Anderson > --- > Changes in v2: > - Match 'uV' -> 'uv' change in Naveen's bindings. > > arch/arm/boot/dts/c

Re: [PATCH v2 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc

2013-03-15 Thread Naveen Krishna Ch
On 14 March 2013 02:10, Doug Anderson wrote: > Without this change the exynos adc controller needed to have its phy > enabled in some out-of-driver C code. Add support for specifying the > phy enable register by listing it in the reg list. > > Signed-off-by: Doug Anderson Worked for me, Its nee

Re: [PATCH v2 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow

2013-03-15 Thread Naveen Krishna Ch
On 15 March 2013 15:54, Naveen Krishna Ch wrote: > Doug, > > On 14 March 2013 02:10, Doug Anderson wrote: >> Hook up the exynos5250-snow thermistors via the device tree now that >> there's a driver available to use them. >> >> Signed-off-by: Doug Anderso

Re: [PATCH v2 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc

2013-03-15 Thread Naveen Krishna Ch
On 15 March 2013 17:15, Naveen Krishna Ch wrote: > On 14 March 2013 02:10, Doug Anderson wrote: >> Without this change the exynos adc controller needed to have its phy >> enabled in some out-of-driver C code. Add support for specifying the >> phy enable register by listi

Re: [PATCH v2 3/4] ARM: dts: Add adc to exynos5250 device tree file

2013-03-15 Thread Naveen Krishna Ch
On 14 March 2013 02:10, Doug Anderson wrote: > Add the device tree entry for the device-tree enabled ADC driver that > recently landed in the iio tree. > > Signed-off-by: Doug Anderson I've not used the "clock" binding yet, Will test with that and give a tag. > --- > Changes in v2: None > > arc

Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume

2013-08-27 Thread Naveen Krishna Ch
On 23 May 2013 10:55, Naveen Krishna Ch wrote: > On 23 May 2013 02:46, Jonathan Cameron wrote: >> On 05/20/2013 06:09 PM, Doug Anderson wrote: >>> Naveen, >>> >>> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi >>> wrote: >>>&

Re: [PATCH 3/3] thermal: exynos: Handle the misplaced TRIMINFO register

2013-08-27 Thread Naveen Krishna Ch
On 28 August 2013 11:33, amit daniel kachhap wrote: > Hi Naveen > > On Wed, Aug 28, 2013 at 11:15 AM, Naveen Krishna Chatradhi > wrote: >> This patch adds code to handle the misplaced TRIMINFO register >> incase of Exynos5420. >> >> On Exynos5420 we have a TRIMINFO register being misplaced for >>

Re: [PATCH 3/3] thermal: exynos: Handle the misplaced TRIMINFO register

2013-08-28 Thread Naveen Krishna Ch
On 28 August 2013 14:13, amit daniel kachhap wrote: > Hi Naveen, > > On Wed, Aug 28, 2013 at 11:49 AM, Naveen Krishna Ch > wrote: >> On 28 August 2013 11:33, amit daniel kachhap wrote: >>> Hi Naveen >>> >>> On Wed, Aug 28, 2013 at 11:15 AM, Naveen

Re: [PATCH 3/3] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-10-03 Thread Naveen Krishna Ch
On 4 September 2013 09:53, Naveen Krishna Chatradhi wrote: > This patch adds the neccessary register changes and arch information > to support Exynos5420 SoCs > Exynos5420 has 5 TMU channels one for each CPU 0, 1, 2 and 3 and GPU > > Also updated the Documentation at > Documentation/devicetree/bin

Re: [PATCH 3/3] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-10-09 Thread Naveen Krishna Ch
Hello Bartlomiej, On 3 October 2013 18:12, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > I would like to see few minor cleanup changes, please see below: Sure. > > On Thursday, October 03, 2013 05:31:42 PM Naveen Krishna Ch wrote: >> On 4 September 2013 09:53, Naveen Kri

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Naveen Krishna Ch
On 4 December 2012 05:41, Olof Johansson wrote: > On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown > wrote: >> On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: >>> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: >> >>> > It was originally done separately but I think it was felt that

Re: [PATCH 1/2] i2c: exynos5: add High Speed I2C controller driver

2012-12-27 Thread Naveen Krishna Ch
Hello Balbi, On 28 December 2012 04:27, Felipe Balbi wrote: > Hi, > > On Tue, Dec 25, 2012 at 04:55:54PM +0530, Naveen Krishna Chatradhi wrote: >> Adds support for High Speed I2C driver found in Exynos5 and later >> SoCs from Samsung. This driver currently supports Auto mode. >> >> Driver only su

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2012-12-28 Thread Naveen Krishna Ch
On 28 December 2012 16:57, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method of passing platform data. > Note: Added debugfs support for regi

Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-06-10 Thread Naveen Krishna Ch
On 17 May 2013 15:40, Naveen Krishna Chatradhi wrote: > > Adds support for High Speed I2C driver found in Exynos5 and > later SoCs from Samsung. > > Driver only supports Device Tree method. > > Changes since v1: > 1. Added FIFO functionality > 2. Added High speed mode functionality > 3. Remove SMB

Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

2013-08-15 Thread Naveen Krishna Ch
On 15 August 2013 12:32, Zhang Rui wrote: > > On δΈ‰, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote: > > The error check is checking for a "base" mapped memory base > > instead of "base_common". Fixing the same. > > > > Signed-off-by: Naveen Krishna Chatradhi > > applied. Thanks! > BTW,

Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

2013-08-15 Thread Naveen Krishna Ch
On 15 August 2013 18:42, Wolfram Sang wrote: > On Mon, Jul 01, 2013 at 12:25:19PM +0200, Tomasz Figa wrote: >> Hi Naveen, >> >> Looks mostly good, but see some comments inline. > > Ping? Hello Wolfram, I made a patch fixing your comments and from Thomas Figa as well. Meanwhile, we hit a random c

Re: [PATCH] thermal: exynos: Handle the misplaced TRIMINFO register

2013-08-01 Thread Naveen Krishna Ch
On 1 August 2013 14:02, amit daniel kachhap wrote: > Hi Naveen, > > Can you rebase these patches against > https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next. > All these patches have been queued for 3.12 merge and contains the new > re-structured TMU driver. S

Re: [PATCH] ARM: dts: exynos5420: add ADC device tree node

2013-08-01 Thread Naveen Krishna Ch
On 2 August 2013 10:20, sunil joshi wrote: > Hi Naveen, > exynos5250.dtsi also needs this entry. > Pls consider adding adc node in exynos5250.dtsi as well, and move the > common content of adc node to exynos5.dtsi. Sure, sunil will run a boot test and submit the code > > Regards > Sunil > > > On T

Re: [PATCH v2] thermal: exynos: Handle the misplaced TRIMINFO register

2013-08-06 Thread Naveen Krishna Ch
On 7 August 2013 12:06, amit daniel kachhap wrote: > Hi Naveen, > > On Thu, Aug 1, 2013 at 4:06 PM, Naveen Krishna Chatradhi > wrote: >> This patch adds code to handle the misplaced TRIMINFO register >> incase of Exynos5420. >> >> On Exynos5420 we have a TRIMINFO register being misplaced for >> T

Re: [PATCH V5 17/30] thermal: exynos: Remove non DT based support

2013-08-07 Thread Naveen Krishna Ch
On 11 June 2013 18:23, Amit Daniel Kachhap wrote: > Recently non DT support from Exynos platform is removed and hence > removing non DT support from the driver also. This will help in easy > maintainence. > > Signed-off-by: Amit Daniel Kachhap Hello Amit, When you remove the non-DT support why h

Re: [PATCH V7 23/30] thermal: exynos: Add thermal configuration data for exynos5440 TMU sensor

2013-08-07 Thread Naveen Krishna Ch
On 26 June 2013 06:54, Jungseok Lee wrote: > On Monday, June 24, 2013 7:51 PM, Amit Daniel Kachhap wrote: >>This patch adds configuration data for exynos5440 soc. Also register >>definations for the controller are added. >> >>Acked-by: Jonghwa Lee >>Acked-by: Kukjin Kim >>Signed-off-by: Amit Dan

Re: [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-03-05 Thread Naveen Krishna Ch
On 16 February 2013 04:46, Doug Anderson wrote: > We need to use the i2c-arbitrator to talk to any of the devices on i2c > bus 4 on exynos5250-snow so that we don't confuse the embedded > controller (EC). Add the i2c-arbitrator to the device tree. As we > add future devices (keyboard, sbs, tps65

Re: [PATCH v3 3/3] ARM: dts: Add sbs-battery for exynos5250-snow

2013-03-05 Thread Naveen Krishna Ch
On 16 February 2013 04:46, Doug Anderson wrote: > Now that we have i2c-arbitrator in place on bus 4 we can add the > sbs-battery driver. Future devices will be added onto bus 4 once > drivers are in good shape. > > Signed-off-by: Doug Anderson Tested-by: Naveen Krishna Chatradhi The patchset v3

Re: [PATCH] iio: adc: exynos5_adc: fix compilation warnings

2013-03-06 Thread Naveen Krishna Ch
On 6 March 2013 17:44, Lars-Peter Clausen wrote: > On 03/06/2013 05:11 AM, Naveen Krishna Chatradhi wrote: >> From: Naveen Krishna Ch >> >> Fixes the compilation warnings and potential NULL pointer >> dereferencing pointed out by "Dan Carpenter". >> &g

Fwd: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-05-01 Thread Naveen Krishna Ch
On 16 April 2013 15:59, Wolfram Sang wrote: > Hi, > > thanks for the submission. > > On Thu, Apr 04, 2013 at 09:52:01PM -0700, Naveen Krishna Chatradhi wrote: >> From: Naveen Krishna Chatradhi >> >> Adds support for High Speed I2C driver found in Exynos5 and >> later SoCs from Samsung. >> This dr

Re: Fwd: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-05-02 Thread Naveen Krishna Ch
On 2 May 2013 16:57, Wolfram Sang wrote: > Hi, > >> >> + - Samsung GPIO variant (deprecated): >> >> +- gpios: The order of the gpios should be the following: . >> >> + The gpio specifier depends on the gpio controller. >> > >> > Huh? Why should we support a deprecated method with a new d

Re: [PATCH] iio: adc: exynos_adc: use devm_ioremap_resource()

2013-05-02 Thread Naveen Krishna Ch
On 2 May 2013 14:10, Laurent Navet wrote: > Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. > > Found with coccicheck and this semantic patch: > scripts/coccinelle/api/devm_request_and_ioremap.cocci. > > Signed-off-by: Laurent Navet Hello Laurent, But, we already

Re: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-04-12 Thread Naveen Krishna Ch
On 5 April 2013 10:22, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Chatradhi > > Adds support for High Speed I2C driver found in Exynos5 and > later SoCs from Samsung. > This driver currently supports Auto mode. > > Driver only supports Device Tree method. > Note: Added debugfs support

Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume

2013-05-22 Thread Naveen Krishna Ch
On 23 May 2013 02:46, Jonathan Cameron wrote: > On 05/20/2013 06:09 PM, Doug Anderson wrote: >> Naveen, >> >> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi >> wrote: >>> The exynos_adc device structure was wrongly extracted from the dev* >>> correcting the same. >>> >>> Using the reg

Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-05-22 Thread Naveen Krishna Ch
On 17 May 2013 15:40, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and > later SoCs from Samsung. > > Driver only supports Device Tree method. > > Changes since v1: > 1. Added FIFO functionality > 2. Added High speed mode functionality > 3. Remove SMBUS

Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc

2013-03-27 Thread Naveen Krishna Ch
On 13 March 2013 13:39, Doug Anderson wrote: > The exynos ADC won't work without a regulator called "vdd" and a clock > called "adc". Document this fact in the device tree bindings. > > Signed-off-by: Doug Anderson Reviewed-by: Naveen Krishna Chatradhi Lars, any update on this patch set. This

Re: [PATCH v2 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow

2013-03-27 Thread Naveen Krishna Ch
On 15 March 2013 08:42, Naveen Krishna Ch wrote: > On 15 March 2013 15:54, Naveen Krishna Ch wrote: >> Doug, >> >> On 14 March 2013 02:10, Doug Anderson wrote: >>> Hook up the exynos5250-snow thermistors via the device tree now that >>> there's a driv

Re: [PATCH v2 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc

2013-03-27 Thread Naveen Krishna Ch
On 13 March 2013 13:40, Doug Anderson wrote: > Without this change the exynos adc controller needed to have its phy > enabled in some out-of-driver C code. Add support for specifying the > phy enable register by listing it in the reg list. > > Signed-off-by: Doug Anderson > --- > Changes in v2:

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Naveen Krishna Ch
Hello All, On 22 January 2013 15:14, Lars-Peter Clausen wrote: > > Hi, > > On 01/21/2013 02:37 PM, Naveen Krishna Chatradhi wrote: > > This patch add an ADC IP found on EXYNOS5 series socs from Samsung. > > Also adds the Documentation for device tree bindings. > >[...] > > diff --git a/drivers/ii

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2013-01-22 Thread Naveen Krishna Ch
On 28 December 2012 16:57, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method of passing platform data. > Note: Added debugfs support for regi

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-13 Thread Naveen Krishna Ch
Hello Guenter, I've s setup like the below one, kindly, help me find the right device tree not params ADC 0 1 1 1 1 On 13 February 2013 08:18, Naveen Krishna Ch wrote: > On 13 February 2013 02:37, Guenter Roeck wrote: >> On Wed, Jan 23, 2013 at 04

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-13 Thread Naveen Krishna Ch
Please ignore the unfinished previous mail. On 13 February 2013 08:18, Naveen Krishna Ch wrote: > On 13 February 2013 02:37, Guenter Roeck wrote: >> On Wed, Jan 23, 2013 at 04:58:06AM -, Naveen Krishna Chatradhi wrote: >>> This patch add an ADC IP found on EXYNOS5 series

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-13 Thread Naveen Krishna Ch
On 13 February 2013 19:00, Lars-Peter Clausen wrote: > On 02/13/2013 02:16 PM, Naveen Krishna Ch wrote: >> Please ignore the unfinished previous mail. >> >> >> >> On 13 February 2013 08:18, Naveen Krishna Ch >> wrote: >>> On 13 February 2013

Re: [PATCH v7] iio: adc: add exynos adc driver under iio framwork

2013-02-15 Thread Naveen Krishna Ch
On 15 February 2013 18:43, Lars-Peter Clausen wrote: > On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote: >> This patch adds New driver to support: >> 1. Supports ADC IF found on EXYNOS4412/EXYNOS5250 >>and future SoCs from Samsung >> 2. Add ADC driver under iio/adc framework >> 3. Also a

Re: [PATCH v7] iio: adc: add exynos adc driver under iio framwork

2013-02-15 Thread Naveen Krishna Ch
On 15 February 2013 18:56, Lars-Peter Clausen wrote: > On 02/15/2013 02:17 PM, Naveen Krishna Ch wrote: >> On 15 February 2013 18:43, Lars-Peter Clausen wrote: >>> On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote: >>>> This patch adds New driver to support: &g

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2013-01-14 Thread Naveen Krishna Ch
On 28 December 2012 22:06, Naveen Krishna Ch wrote: > On 28 December 2012 16:57, Naveen Krishna Chatradhi > wrote: >> Adds support for High Speed I2C driver found in Exynos5 and later >> SoCs from Samsung. This driver currently supports Auto mode. >> >> Driver only

Re: [PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use

2013-01-07 Thread Naveen Krishna Ch
On 29 November 2012 20:14, Kyungmin Park wrote: > Acked-by: Kyungmin Park I don't see this patch landed any where in linux-i2c tree, Though it was acked. Was it missed or should i be doing something for this to be merged ?? > > On Thu, Nov 29, 2012 at 2:05 PM, Naveen Krishna Chatradhi > wrote:

Re: [PATCH 1/2] ARM: exynos5: Add gate clocks for HS-I2C

2013-01-07 Thread Naveen Krishna Ch
On 28 December 2012 17:10, Naveen Krishna Chatradhi wrote: > Adds clock gating bits for High Speed I2C channels 0, 1, 2 and 3. > > Signed-off-by: Naveen Krishna Chatradhi > --- > arch/arm/mach-exynos/clock-exynos5.c | 24 > 1 file changed, 24 insertions(+) > > diff --g

Re: [PATCH 1/3 v6] thermal: samsung: add intclr_fall_shift bit in exynos_tmu_register

2013-11-06 Thread Naveen Krishna Ch
Hello Bartlomiej, My reply is very long delayed sorry. On 17 October 2013 15:33, Bartlomiej Zolnierkiewicz wrote: > > Hi Naveen, > > On Thursday, October 17, 2013 08:41:13 AM Naveen Krishna Chatradhi wrote: >> On Exynos5250, the FALL interrupt related en, status and clear bits are >> available a

Re: [PATCH 1/3 v8] thermal: samsung: add intclr_fall_shift bit in exynos_tmu_register struct

2013-11-07 Thread Naveen Krishna Ch
Hi Bartlomiej, On 7 November 2013 16:18, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, November 07, 2013 11:22:42 AM Naveen Krishna Chatradhi wrote: >> On Exynos5250, the FALL interrupt related en, status and clear bits are >> available at an offset of >> 16 in INTEN, INTSTAT register

Re: [PATCH] ARM: dts: Exynos5420: Add device nodes for HSI2C blocks

2013-11-07 Thread Naveen Krishna Ch
On 7 November 2013 18:52, Naveen Krishna Chatradhi wrote: > Exynos5420 SoC has 7 High speed I2C channels, This patch adds > the device tree nodes to the DT device list. > > Signed-off-by: Naveen Krishna Chatradhi > Signed-off-by: Andrew Bresticker > --- > arch/arm/boot/dts/exynos5420.dtsi | 9

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2013-11-07 Thread Naveen Krishna Ch
On 7 November 2013 19:48, Tomasz Figa wrote: > Hi Naveen, > > On Thursday 07 of November 2013 18:12:34 Naveen Krishna Chatradhi wrote: >> On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from >> the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second >> should be a

Re: [PATCH 0/9 v7] crypto:s5p-sss: Add DT and Exynos support

2014-03-19 Thread Naveen Krishna Ch
for which ARCH code is under review) >> I couldn't test on Exynos4412 and Exynos4210 boards, Should be able to >> test with addition of DT node and clocks support. >> >> Naveen Krishna Ch (7): [crypto-2.6.git] >> crypto:s5p-sss: Use platform_get_irq() instead

Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420

2014-03-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 March 2014 00:58, Tomasz Figa wrote: > Hi Leela, > > > On 19.03.2014 12:19, Leela Krishna Amudala wrote: >> >> Hi All, >> >> I didn't see this series in mainline, Any comments for this ? > > > Naveen had posted v12 of this series and I believe all the patches got my > Reviewed

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch set adds use of clk_prepare/clk_unprepare as > required by generic clock framework. > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > --- > Changes since v3: > None > > drivers/crypto/s5p-s

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds the device tree node for SSS module > found on Exynos5420 and Exynos5250 > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > TO: > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1. M

Re: [PATCH 1/8 v4] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > This patch uses the platform_get_irq() instead of the > platform_get_irq_byname(). Making feeder control interrupt > as resource "0" and hash interrupt as "1"

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch adds code to validate "iv" buffer before trying to > memcpy the contents > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > None > > drivers/crypto/s5p-sss.c |3 ++- > 1 file changed, 2 in

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds gating clock for SSS(Security SubSystem) > module on Exynos5250/5420. > > Signed-off-by: Naveen Krishna Chatradhi > TO: > TO: Tomasz Figa > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1. Rebased on to

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S. M

[PATCH 1/5] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-07 Thread Naveen Krishna Ch
e the feeder control interrupt 3. Patches adding support for DT and H/W version are in pipeline Signed-off-by: Naveen Krishna Ch CC: Herbert Xu CC: David S. Miller CC: Vladimir Zapolskiy TO: CC: --- drivers/crypto/s5p-sss.c | 22 +++--- 1 file changed, 11 insertions(+), 11 dele

[PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver

2014-01-07 Thread Naveen Krishna Ch
This patch modifies Kconfig such that ARCH_EXYNOS5 SoCs can also select Samsung SSS(Security SubSystem) driver. Signed-off-by: Naveen Krishna Ch CC: Herbert Xu CC: David S. Miller CC: Vladimir Zapolskiy TO: CC: --- drivers/crypto/Kconfig |8 1 file changed, 4 insertions(+), 4

[PATCH 2/5] crypto:s5p-sss: Add device tree and Exynos5 support

2014-01-07 Thread Naveen Krishna Ch
This patch adds device tree support along with a new compatible string to support Exynos5 SoCs (SSS_VER_5). Also, Documentation under devicetree/bindings added. Signed-off-by: Naveen Krishna Ch CC: Herbert Xu CC: David S. Miller CC: Vladimir Zapolskiy TO: CC: --- .../devicetree/bindings

[PATCH 3/5] crypto:s5p-sss: Add support for SSS module on Exynos5

2014-01-07 Thread Naveen Krishna Ch
The differences between SSS modules on S5PV210 and Exynos5 (AFA the driver supports) 1. AES register are at an offset of 0x200 on Exynos5 2. hash interrupt is no longer needed on Exynos5 This patch adds code needed to address the above changes. Signed-off-by: Naveen Krishna Ch CC: Herbert Xu

[PATCH 0/5] crypto:s5p-sss: Add DT and Exynos5 support

2014-01-07 Thread Naveen Krishna Ch
device tree node to Exynos5420 4. Also adds the DT binding documentation Naveen Krishna Ch (4): [crypto-2.6.git] crypto:s5p-sss: Use platform_get_irq() instead of _byname() crypto:s5p-sss: Add device tree and Exynos5 support crypto:s5p-sss: Add support for SSS module on Exynos5 crypto:s5p-sss

[PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-07 Thread Naveen Krishna Ch
From: Naveen Krishna Chatradhi this patch adds the device tree nodes for SSS module found on Exynos5420 Signed-off-by: Naveen Krishna Chatradhi TO: CC: Kukjin Kim CC: --- arch/arm/boot/dts/exynos5420.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/ex

Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:02, Tomasz Figa wrote: > On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote: >> From: Naveen Krishna Chatradhi >> >> this patch adds the device tree nodes for SSS module found on Exynos5420 > > nit: Sentences in English

Re: [PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:00, Tomasz Figa wrote: > On Tuesday 07 of January 2014 17:21:48 Naveen Krishna Ch wrote: >> This patch modifies Kconfig such that ARCH_EXYNOS5 SoCs >> can also select Samsung SSS(Security SubSystem) driver. >> >> Signed-off-by: Naveen

Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-09 Thread Naveen Krishna Ch
; Also, Documentation under devicetree/bindings added. >> >> Signed-off-by: Naveen Krishna Ch >> CC: Herbert Xu >> CC: David S. Miller >> CC: Vladimir Zapolskiy >> TO: >> CC: >> --- >> Changes since v1: >> 1. Added description of the

Re: [PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-11-25 Thread Naveen Krishna Ch
Hello Doug, On 26 November 2013 05:11, Doug Anderson wrote: > Naveen, > > On Mon, Nov 18, 2013 at 10:18 PM, Naveen Krishna Chatradhi > wrote: >> For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based >> on a fixed 66 MHz peripheral clock, and therefore is completely >> independent of t

Re: [PATCH 1/2 v2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2013-11-26 Thread Naveen Krishna Ch
Hello Sachin, On 26 November 2013 16:59, Sachin Kamat wrote: > On 26 November 2013 09:56, Naveen Krishna Chatradhi > wrote: >> This patch adds new compatible to support HSI2C module on Exynos5260 >> HSI2C module on Exynos5260 needs to be reset during during initialization. >> >> Signed-off-by: N

Re: [PATCH 3/8 v3] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-13 Thread Naveen Krishna Ch
hi wrote: >>> >>> This patch adds new compatible and variant struct to support the SSS >>> module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) >>> for which >>> 1. AES register are at an offset of 0x200 and >>> 2. hash interrupt

Re: [PATCH 7/8 v3] crypto:s5p-sss: validate iv before memcpy

2014-01-14 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:33, Tomasz Figa wrote: > Hi Naveen, > > > On 10.01.2014 12:45, Naveen Krishna Chatradhi wrote: >> >> This patch adds code to validate "iv" buffer before trying to >> memcpy the contents >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> Changes since v2:

Re: [PATCH 5/8 v3] clk:exynos-5250: Add gate clock for SSS module

2014-01-15 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:28, Tomasz Figa wrote: > Hi Naveen, > > > On 10.01.2014 12:43, Naveen Krishna Chatradhi wrote: >> >> This patch adds gating clock for SSS(Security SubSystem) >> module on Exynos5250. >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> Changes since v2: >>

Re: [PATCH 3/3 v8] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-11-11 Thread Naveen Krishna Ch
Hello Tomasz, On 7 November 2013 20:39, Tomasz Figa wrote: > Hi Naveen, > > On Thursday 07 of November 2013 11:23:32 Naveen Krishna Chatradhi wrote: >> This patch adds the neccessary register changes and arch information >> to support Exynos5420 SoCs >> Exynos5420 has 5 TMU channels one for each

Re: [PATCH 1/2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2013-11-21 Thread Naveen Krishna Ch
Hello Yuvaraj, On 22 November 2013 12:16, Yuvaraj Cd wrote: > On Fri, Nov 22, 2013 at 11:42 AM, Naveen Krishna Chatradhi > wrote: >> This patch adds new compatible to support HSI2C module on Exynos5260 >> HSI2C module on Exynos5260 needs to be reset during during initialization. >> >> Signed-off

Re: [PATCH 2/4 v10] thermal: samsung: change base_common to more meaningful base_second

2013-11-22 Thread Naveen Krishna Ch
Hello All, On 19 November 2013 18:34, Naveen Krishna Chatradhi wrote: > On Exynos5440 and Exynos5420 there are registers common > across the TMU channels. > > To support that, we introduced a ADDRESS_MULTIPLE flag in the > driver and the 2nd set of register base and size are provided > in the "re

Re: [PATCH 3/4 v10] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-11-22 Thread Naveen Krishna Ch
Hello All, On 19 November 2013 18:35, Naveen Krishna Chatradhi wrote: > Exynos5420 has 5 TMU channels, the TRIMINFO register is > misplaced for TMU channels 2, 3 and 4 > TRIMINFO at 0x1006c000 contains data for TMU channel 3 > TRIMINFO at 0x100a contains data for TMU channel 4 > TRIMINFO at 0

Re: [PATCH] i2c: exynos5: add High Speed I2C controller driver

2013-10-11 Thread Naveen Krishna Ch
On 8 September 2013 22:33, Wolfram Sang wrote: > > On Wed, Aug 21, 2013 at 02:54:37PM +0530, Naveen Krishna Ch wrote: >> Adds support for High Speed I2C driver found in Exynos5 and >> later SoCs from Samsung. >> >> Highspeed mode is a minor change in the i2c protoc

Re: [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-11 Thread Naveen Krishna Ch
On 12 October 2013 11:12, Tomasz Figa wrote: > On Saturday 12 of October 2013 04:28:51 Tomasz Figa wrote: >> [Fixing incorrent mail addresses and dropping the old DT ML.] >> >> On Saturday 12 of October 2013 04:22:04 Tomasz Figa wrote: >> > Hi Naveen, >> > >> > On Friday 11 of October 2013 16:56:5

Re: [PATCH v3] iio: exynos_adc: use wait_for_completion_timeout instead of interruptible

2013-10-11 Thread Naveen Krishna Ch
On 11 October 2013 20:00, Lars-Peter Clausen wrote: > On 10/11/2013 10:23 AM, Naveen Krishna Chatradhi wrote: >> This patch does the following >> 1. use wait_for_completion_timeout instead of >>wait_for_completion_interruptible_timeout >> 2. Reset software if a timeout happens. >> 3. Also redu

Re: [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly

2013-10-14 Thread Naveen Krishna Ch
On 15 October 2013 11:36, Heiko Schocher wrote: > Hello Naveen, > > Am 15.10.2013 07:12, schrieb Naveen Krishna Chatradhi: > >> The Exynos5 i2c driver does not handle NACKs properly. This change: >> >> - fixes the NACK processing problem (do not continue transaction if >>address cycle was NACK

Re: [PATCH 1/3 v4] thermal: samsung: correct the fall interrupt en, status bit fields

2013-10-15 Thread Naveen Krishna Ch
On 14 October 2013 21:31, Bartlomiej Zolnierkiewicz wrote: > On Monday, October 14, 2013 10:18:03 AM Eduardo Valentin wrote: >> On 11-10-2013 11:57, Bartlomiej Zolnierkiewicz wrote: >> > >> > Hi, >> > >> > On Friday, October 11, 2013 11:10:38 AM Eduardo Valentin wrote: >> >> Hi Naveen, >> >> >> >>

Re: [PATCHv6 1/4] iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:12, Arnd Bergmann wrote: > On Friday 18 July 2014 14:59:43 Chanwoo Choi wrote: >> This patchset add 'exynos_adc_data' structure which includes some functions >> to control ADC operation and specific data according to ADC version (v1 or >> v2). >> > > This new struc

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:08, Arnd Bergmann wrote: > On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: >> This patchset support Exynos3250 ADC (Analog Digital Converter) because >> Exynos3250 has additional special clock for ADC IP. >> > > by coincidence, I have just looked at the same dri

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello All, On 18 July 2014 15:43, Naveen Krishna Ch wrote: > Hello Arnd, > > On 18 July 2014 15:08, Arnd Bergmann wrote: >> On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: >>> This patchset support Exynos3250 ADC (Analog Digital Converter) because >>> Exynos

Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

2014-04-26 Thread Naveen Krishna Ch
gt; On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi >> wrote: >>> >>> From: Naveen Krishna Ch >>> >>> Using pdev->dev with device_for_each_child() would iterate over all >>> of the children of the platform device and delete them

Re: [PATCH 2/2 v4] i2c: exynos5: configure fifo_depth based on HSI2C module variant

2014-04-27 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:50, Wolfram Sang wrote: > On Fri, Feb 07, 2014 at 10:13:15AM +0530, Naveen Krishna Chatradhi wrote: >> fifo_depth of the HSI2C is not constant >> Exynos5420 and Exynos5250 supports fifo_depth of 64bytes >> Exynos5260 supports fifo_depth of 16bytes. >> >> This pa

Re: [PATCH 1/2 v4] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:48, Wolfram Sang wrote: > On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote: >> This patch adds a new compatible and uses variant struct to support >> HSI2C module on Exynos5260. Updates the Documentation dt bindings. >> Also resets the mo

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-13 Thread Naveen Krishna Ch
Hello Kukjin, On 14 February 2014 05:02, Kukjin Kim wrote: > On 02/14/14 08:28, Kukjin Kim wrote: >> >> On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: >>> >>> This patch adds the device tree node for SSS module >>> found on Exynos5420 and Exynos5250 >>> >>> Signed-off-by: Naveen Krishna Chatr

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-17 Thread Naveen Krishna Ch
Hello Tomasz, On 14 February 2014 16:24, Tomasz Figa wrote: > Hi Kukjin, > > > On 14.02.2014 00:28, Kukjin Kim wrote: >> >> On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: >>> >>> This patch adds the device tree node for SSS module >>> found on Exynos5420 and Exynos5250 >>> >>> Signed-off-by:

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello All, On 28 April 2014 16:14, Naveen Krishna Chatradhi wrote: > SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added > features to the one on S5PV210. However with minor changes the s5p-sss.c > driver can be reused to support SSS modules on Exynos4 and 5 SoCs. > > This patch se

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello Herbert, On 30 April 2014 17:44, Herbert Xu wrote: > On Wed, Apr 30, 2014 at 04:38:05PM +0530, Naveen Krishna Ch wrote: >> Hello All, >> >> On 28 April 2014 16:14, Naveen Krishna Chatradhi >> wrote: >> > SSS module on Exynos4210, Exynos5250 and Exynos

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 24 April 2014 21:55, Mark Brown wrote: > On Thu, Apr 24, 2014 at 08:18:36PM +0530, Naveen Krishna Chatradhi wrote: >> This patch moves initialization code to subsys_initcall() to ensure >> that the i2c bus is available early so the regulators can be quickly >> probed and available

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 9 May 2014 19:21, Mark Brown wrote: > On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote: >> On 24 April 2014 21:55, Mark Brown wrote: > >> >> Such solution has been proposed by Mark Brown to fix the problem of >> >> the re

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 June 2014 06:00, Tomasz Figa wrote: > On 20.06.2014 02:28, Chanwoo Choi wrote: >> On 06/20/2014 09:24 AM, Tomasz Figa wrote: >>> On 20.06.2014 02:22, Chanwoo Choi wrote: Hi Tomasz, On 06/18/2014 04:58 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

2014-07-11 Thread Naveen Krishna Ch
Hello Sachin, On 11 July 2014 14:47, Sachin Kamat wrote: > Hi Naveen, > > On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi > wrote: >> The DT bindings in exynos-adc.txt applies to the ADC >> driver (exynos-adc.c) developed based on IIO framework. >> >> The bindings are more appropriate

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Ch
Hello Sachin, On 25 June 2014 16:19, Sachin Kamat wrote: > Hi Naveen, > > On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi > wrote: >> This patch removes an extra line and fixes a styling nit >> in exynos5_i2c_message_start() >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> dri

Re: [PATCH v4 00/14] Add Maxim 77802 PMIC support

2014-06-26 Thread Naveen Krishna Ch
Hello Javier, On 26 June 2014 00:33, Javier Martinez Canillas wrote: > MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, > 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, > a Real-Time-Clock (RTC) and a I2C interface to program the individual > regulators, cl

  1   2   >