Re: [PATCH] bus: imx-weim: remove __init from 2 functions

2019-08-26 Thread Nathan Chancellor
x27;t seem to be used anywhere else. > > Signed-off-by: Ilie Halip > Reported-by: "kernelci.org bot" > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: clang-built-li...@googlegroups.com > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Nathan Chancellor

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-08-26 Thread Nathan Chancellor
Hi Jason, On Fri, Aug 23, 2019 at 11:24:27AM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 10:30:30AM -0700, Nathan Chancellor wrote: > > On Thu, Jul 11, 2019 at 02:18:08PM -0300, Jason Gunthorpe wrote: > > > On Thu, Jul 11, 2019 at 10:16:44AM -0700, Nick Desaulniers

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-08-26 Thread Nathan Chancellor
On Mon, Aug 26, 2019 at 12:42:28PM -0300, Jason Gunthorpe wrote: > On Mon, Aug 26, 2019 at 08:38:00AM -0700, Nathan Chancellor wrote: > > On Fri, Aug 23, 2019 at 11:24:27AM -0300, Jason Gunthorpe wrote: > > > The latest clang-9 packages from apt.llvm.org do seem to build the &

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-08-26 Thread Nathan Chancellor
On Sun, Aug 11, 2019 at 07:32:15PM -0700, Nathan Chancellor wrote: > Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when > setjmp is used") disabled -Wbuiltin-requires-header because of a warning > about the setjmp and longjmp declarations. > > r3673

[PATCH] kbuild: Do not enable -Wimplicit-fallthrough for clang for now

2019-08-26 Thread Nathan Chancellor
d resolved. Suggested-by: Masahiro Yamada Signed-off-by: Nathan Chancellor --- Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index f125625efd60..6007a56bdbee 100644 --- a/Makefile +++ b/Makefile @@ -751,6 +751,11 @@ else # These warnings gene

Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-04 Thread Nathan Chancellor
On Wed, Sep 04, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > On Sat, Aug 31, 2019 at 6:26 PM Masahiro Yamada > wrote: > > > +# Some diagnostics enabled by default are noisy. > > +# Suppress them by using -Wno... except for W=1. > > + > > ifdef CONFIG_CC_IS_CLANG > > KBUILD_CFLAGS += -Wno-in

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-04 Thread Nathan Chancellor
On Wed, Sep 04, 2019 at 08:01:35AM -0500, Segher Boessenkool wrote: > On Wed, Sep 04, 2019 at 08:16:45AM +, David Laight wrote: > > From: Nathan Chancellor [mailto:natechancel...@gmail.com] > > > Fair enough so I guess we are back to just outright disabling the > >

[PATCH] net/mlx5: Fix rt's type in dr_action_create_reformat_action

2019-09-04 Thread Nathan Chancellor
right type for rt, which is mlx5_reformat_ctx_type so there are no warnings about mismatched types. Fixes: 9db810ed2d37 ("net/mlx5: DR, Expose steering action functionality") Link: https://github.com/ClangBuiltLinux/linux/issues/652 Signed-off-by: Nathan Chancellor --- drivers/net/e

[PATCH] net/mlx5: Fix addr's type in mlx5dr_icm_dm

2019-09-04 Thread Nathan Chancellor
PHYS_ADDR_T_64BIT is set, which is always when CONFIG_64BIT is set. Fixes: 29cf8febd185 ("net/mlx5: DR, ICM pool memory allocator") Link: https://github.com/ClangBuiltLinux/linux/issues/653 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.c | 2

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-10 Thread Nathan Chancellor
On Wed, Sep 11, 2019 at 04:30:38AM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > On Wed, Sep 04, 2019 at 08:01:35AM -0500, Segher Boessenkool wrote: > >> On Wed, Sep 04, 2019 at 08:16:45AM +, David Laight wrote: > >> > From: Nathan Chancellor [m

[PATCH v3 0/3] LLVM/Clang fixes for pseries_defconfig

2019-09-11 Thread Nathan Chancellor
Hi all, This series includes a set of fixes for LLVM/Clang when building pseries_defconfig. These have been floating around as standalone patches so I decided to gather them up as a series so it was easier to review/apply them. The versioning is a bit wonky because of this reason, I have included

[PATCH v3 1/3] powerpc: Don't add -mabi= flags when building with Clang

2019-09-11 Thread Nathan Chancellor
thub.com/ClangBuiltLinux/linux/issues/240 Reviewed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message v2 -> v3: * Rebase and merge into a single series. arch/powerpc/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/pow

[PATCH v3 2/3] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-11 Thread Nathan Chancellor
/625 Link: https://github.com/llvm/llvm-project/commit/3be25e79477db2d31ac46493d97eca8c20592b07 Suggested-by: Segher Boessenkool Signed-off-by: Nathan Chancellor --- v1 -> v3: * Use -ffreestanding instead of outright disabling the warning because it is legitimate. I skipped v2 because the

[PATCH v3 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-09-11 Thread Nathan Chancellor
so it is not free to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/5c9f3cfec78f9e9ae013de9a0d092a68e3e79e002 Signed-off-by: Nathan Chancellor --- New patch in the series so no previous version. arch/powerpc/kerne

Re: [PATCH v3 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-09-11 Thread Nathan Chancellor
On Wed, Sep 11, 2019 at 02:01:59PM -0700, Nick Desaulniers wrote: > On Wed, Sep 11, 2019 at 11:21 AM Nathan Chancellor > wrote: > > > > r370454 gives LLVM the ability to convert certain loops into a reference > > to bcmp as an optimization; this breaks prom_init_check.sh

Re: [PATCH] [v2] arm64: fix unreachable code issue with cmpxchg

2019-09-17 Thread Nathan Chancellor
#x27; > > Mark all of the cmpxchg() style functions as __always_inline to > ensure that the compiler can see the result. > > Acked-by: Nick Desaulniers > Reported-by: Nathan Chancellor > Link: https://github.com/ClangBuiltLinux/linux/issues/648 > Reviewed-by: Nathan Chance

[PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident

2019-09-17 Thread Nathan Chancellor
ds") Link: https://github.com/ClangBuiltLinux/linux/issues/658 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/

[PATCH] libnvdimm/nfit_test: Fix acpi_handle redefinition

2019-09-17 Thread Nathan Chancellor
inux/issues/660 Signed-off-by: Nathan Chancellor --- I know that every maintainer has their own thing with the number of includes in each header file; this issue can be solved in a various number of ways, I went with the smallest diff stat. Please solve it in a different way if you see fit :) tools/te

[PATCH] usercopy: Add parentheses around assignment in test_copy_struct_from_user

2019-10-03 Thread Nathan Chancellor
ttps://github.com/ClangBuiltLinux/linux/issues/731 Signed-off-by: Nathan Chancellor --- lib/test_user_copy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_user_copy.c b/lib/test_user_copy.c index 950ee88cd6ac..e365ace06538 100644 --- a/lib/test_user_copy.c +++ b/l

Re: [PATCH AUTOSEL 4.14 08/23] ARM: 8875/1: Kconfig: default to AEABI w/ Clang

2019-09-29 Thread Nathan Chancellor
On Sun, Sep 29, 2019 at 01:35:18PM -0400, Sasha Levin wrote: > From: Nick Desaulniers > > [ Upstream commit a05b9608456e0d4464c6f7ca8572324ace57a3f4 ] > > Clang produces references to __aeabi_uidivmod and __aeabi_idivmod for > arm-linux-gnueabi and arm-linux-gnueabihf targets incorrectly when AE

Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Nathan Chancellor
On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: > Since we link purgatory.ro with -r aka we enable "incremental linking" > no checks for unresolved symbols is done while linking purgatory.ro. > > Changes to the sha256 code has caused the purgatory in 5.4-rc1 to have > a missing symb

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Nathan Chancellor
On Tue, Oct 08, 2019 at 04:59:25PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > On Tue, Oct 8, 2019 at 4:31 PM Andrew Murray wrote: > > This looks good to me. I can build and boot in a model with both Clang > > (9.0.6) and GCC (7.3.1) and boot a guest without anything going bang. > > Gr

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Nathan Chancellor
On Fri, Oct 04, 2019 at 10:53:41AM -0700, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > >The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition wi

Re: [PATCH] lib: test_user_copy: style cleanup

2019-10-05 Thread Nathan Chancellor
er") > Signed-off-by: Aleksa Sarai I assume the comment diff is a line length/alignment thing? The commit message does not mention it. Regardless, thank you for providing the fix that I should have. Reviewed-by: Nathan Chancellor

Re: [PATCH] [v2] arm64: fix unreachable code issue with cmpxchg

2019-09-18 Thread Nathan Chancellor
On Wed, Sep 18, 2019 at 10:02:41AM +0100, Will Deacon wrote: > On Tue, Sep 17, 2019 at 01:34:25PM -0700, Nathan Chancellor wrote: > > On Tue, Sep 10, 2019 at 01:56:22PM +0200, Arnd Bergmann wrote: > > > On arm64 build with clang, sometimes the __cmpxchg_mb is not

Re: [PATCH] hugetlbfs: hugetlb_fault_mutex_hash cleanup

2019-09-18 Thread Nathan Chancellor
issue, noticed that the 'address' parameter > to hugetlb_fault_mutex_hash is no longer used. So, remove it from the > definition and all callers. > > No functional change. > > Reported-by: Nathan Chancellor > Signed-off-by: Mike Kravetz Thanks for the patch! Reviewed-by: Nathan Chancellor

Re: [PATCH] x86, realmode: explicitly set ENTRY in linker script

2019-09-24 Thread Nathan Chancellor
On Mon, Sep 23, 2019 at 03:24:02PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > Linking with ld.lld via $ make LD=ld.lld produces the warning: > ld.lld: warning: cannot find entry symbol _start; defaulting to 0x1000 > > Linking with ld.bfd shows the default entry is 0x1000: > $ readel

Request for inclusion of f73b3cc39c84 ("objtool: Clobber user CFLAGS variable") in -stable

2019-09-25 Thread Nathan Chancellor
Hi Greg and Sasha, We received a report of an objtool build failure with clang related to -Wunused-parameter [1], which turned out to be related to the distro's CFLAGS. Josh patched this up in commit f73b3cc39c84 ("objtool: Clobber user CFLAGS variable"), could it be added to -stable whenever appl

[PATCH] tracing: Fix clang -Wint-in-bool-context warnings in IF_ASSIGN macro

2019-09-25 Thread Nathan Chancellor
27;!= 0' to the WARN_ON statement to fix the warnings. Link: https://github.com/llvm/llvm-project/commit/28b38c277a2941e9e891b2db30652cfd962f070b Link: https://github.com/ClangBuiltLinux/linux/issues/686 Signed-off-by: Nathan Chancellor --- kernel/trace/trace.h | 10 +- 1 file chang

[PATCH v2] tracing: Fix clang -Wint-in-bool-context warnings in IF_ASSIGN macro

2019-09-26 Thread Nathan Chancellor
= 0' to the WARN_ON statement to fix the warnings and find potential issues in the future. Link: https://github.com/llvm/llvm-project/commit/28b38c277a2941e9e891b2db30652cfd962f070b Link: https://github.com/ClangBuiltLinux/linux/issues/686 Reviewed-by: Nick Desaulniers Signed-off-by: Na

[PATCH] tools/power/cpupower: Fix initializer override in hsw_ext_cstates

2019-09-27 Thread Nathan Chancellor
PC8,9,10 states") Link: https://github.com/ClangBuiltLinux/linux/issues/718 Signed-off-by: Nathan Chancellor --- tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c b/too

Re: [PATCH] powerpc/pmac/smp: avoid unused-variable warnings

2019-09-20 Thread Nathan Chancellor
3_cache' [-Wunused-variable] > > They are only used when CONFIG_PPC64 is not defined. Move > them into a section which does the same macro check. > > Reported-by: Nathan Chancellor > Signed-off-by: Ilie Halip Reviewed-by: Nathan Chancellor

[PATCH] test_bpf: Fix a new clang warning about xor-ing two numbers

2019-08-18 Thread Nathan Chancellor
ssues/643 Link: https://github.com/llvm/llvm-project/commit/920890e26812f808a74c60ebc14cc636dac661c1 Signed-off-by: Nathan Chancellor --- I highly doubt that 1e300 was intented but if it was (or something else was), please let me know. Commit history wasn't entirely clear on why this expre

Re: [PATCH] kbuild: enable unused-function warnings for W= build with Clang

2019-08-19 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 07:51:38PM +0900, Masahiro Yamada wrote: > GCC and Clang have different policy for -Wunused-function; GCC does > not report unused-function warnings at all for the functions marked > as 'static inline'. Clang does report unused-function warnings if they > are defined in sour

Re: [PATCH] kbuild: enable unused-function warnings for W= build with Clang

2019-08-19 Thread Nathan Chancellor
On Tue, Aug 20, 2019 at 01:58:26AM +0900, Masahiro Yamada wrote: > Hi Nathan, > > On Tue, Aug 20, 2019 at 1:09 AM Nathan Chancellor > wrote: > > > > On Mon, Aug 19, 2019 at 07:51:38PM +0900, Masahiro Yamada wrote: > > > GCC and Clang have different polic

Re: [PATCH] powerpc: Don't add -mabi= flags when building with Clang

2019-08-19 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote: > On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote: > > When building pseries_defconfig, building vdso32 errors out: > > > > error: unknown target ABI 'elfv1' > > &

Re: Enabling UBSAN breaks KCOV in clang (8.0.*) on arm64

2019-08-20 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 05:59:48PM +0100, Mark Rutland wrote: > Hi, > > I found that when I enable both KCOV and UBSAN on arm64, clang fails to > emit any __sanitizer_cov_trace_*() calls in the resulting binary, > rendering KCOV useless. > > For example, when building v5.3-rc3's arch/arm64/kernel

Re: [PATCH] powerpc: Don't add -mabi= flags when building with Clang

2019-08-20 Thread Nathan Chancellor
On Tue, Aug 20, 2019 at 07:40:33AM -0500, Segher Boessenkool wrote: > On Mon, Aug 19, 2019 at 08:15:38PM -0700, Nathan Chancellor wrote: > > On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote: > > > On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor w

Re: [PATCH] phy-rockchip-inno-hdmi: Fix RK3328_TERM_RESISTOR_CALIB_SPEED_7_0's third value

2019-08-20 Thread Nathan Chancellor
On Wed, Aug 07, 2019 at 12:23:05PM -0700, Nathan Chancellor wrote: > After commit "linux/bits.h: Add compile time sanity check of GENMASK > inputs" [1], arm64 defconfig builds started failing: > > In file included from ../include/linux/bits.h:22, > from

[PATCH v2] powerpc: Don't add -mabi= flags when building with Clang

2019-08-20 Thread Nathan Chancellor
thub.com/ClangBuiltLinux/linux/issues/240 Reviewed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message wording and explanation. * Add Daniel's reviewed-by. arch/powerpc/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/p

Re: [PATCH net v2] skbuff: fix compilation warnings in skb_dump()

2019-07-16 Thread Nathan Chancellor
27;unsigned > short' but the argument has type 'unsigned int' [-Wformat] >level, sk->sk_family, sk->sk_type, > sk->sk_protocol); > ^~~ > > Fix them by using the proper types. > > Fixes: 6413139dfc64 ("skbuff: increase verbosity when dumping skb data") > Signed-off-by: Qian Cai Reviewed-by: Nathan Chancellor

Re: kbuild: Fail if gold linker is detected

2019-07-16 Thread Nathan Chancellor
On Tue, Jul 16, 2019 at 02:47:56PM +0200, Thomas Gleixner wrote: > The gold linker has known issues of failing the build in random and > predictible ways. H.J. stated: > > "Since building a workable kernel for different kernel configurations >isn't a requirement for gold, I don't recommend g

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Nathan Chancellor
thout support from the gold folks, fail > the build when gold is detected. > > Signed-off-by: Thomas Gleixner > Acked-by: Peter Zijlstra (Intel) > Link: > https://lore.kernel.org/r/came9roqmqkq0lnpm25ye_yt0fkp05wmhorwc0ardb53mifk...@mail.gmail.com Based on the crude little t

[PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load}

2020-05-01 Thread Nathan Chancellor
so the module build breaks. Export them so that they can be used in modules properly. Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs") Signed-off-by: Nathan Chancellor --- drivers/firmware/xilinx/zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff -

[PATCH] drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_audio

2020-05-01 Thread Nathan Chancellor
drm/amdgpu: put the audio codec into suspend state before gpu reset V3") Link: https://github.com/ClangBuiltLinux/linux/issues/1017 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

Re: [PATCH] x86/boot: allow a relocatable kernel to be linked with lld

2020-05-01 Thread Nathan Chancellor
ompilers and their respective linkers did not regress. Tested-by: Nathan Chancellor > --- > arch/x86/boot/compressed/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/boot/compressed/Makefile > b/arch/x86/boot/compressed/Makefile > index 5f7c262bcc9

Re: [PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-05-02 Thread Nathan Chancellor
On Sat, May 02, 2020 at 02:50:34PM +0100, Maciej W. Rozycki wrote: > On Tue, 28 Apr 2020, Nathan Chancellor wrote: > > > Before this patch, LD=ld.lld did nothing: > > > > $ llvm-readelf -p.comment arch/mips/vdso/vdso.so.dbg | sed 's/(.*//' > > String

Re: [PATCH v4 1/5] kbuild: add CONFIG_LD_IS_LLD

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:13:40AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > > From: Sami Tolvanen > > > > Similarly to the CC_IS_CLANG config, add LD_IS_LLD to avoid GNU ld > > specific logic such as ld-

Re: [PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:04:42AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > Patch 1 adds ld.lld support to Kconfig so that we can avoid certain > > ld.bfd checks. > > > > Is it possible to introduce and ad

Re: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 06:46:33PM +0100, Maciej W. Rozycki wrote: > On Mon, 27 Apr 2020, Nathan Chancellor wrote: > > > > Can you actually record in the change description what the difference in > > > the relevant link command is, as shown where `V=1' ha

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-29 Thread Nathan Chancellor
Hi Michael, On Thu, Apr 30, 2020 at 12:06:09AM +, Michael Kelley wrote: > From: Nathan Chancellor Sent: Tuesday, April 28, > 2020 10:55 AM > > > > Do note that netvsc_xmit still returns int because netvsc_xmit has a > > potential return from netvsc_vf_xmi

[PATCH] clk: sunxi: Fix operator precedence in sunxi_divs_clk_setup

2019-10-22 Thread Nathan Chancellor
could be added to clkflags if the critical boolean was set; right now, | is being evaluated first. Add parentheses around the ?: block to have it be evaluated first. Fixes: 9919d44ff297 ("clk: sunxi: Use CLK_IS_CRITICAL flag for critical clks") Link: https://github.com/ClangBuiltLinux/linu

[PATCH -next] dmaengine: fsl-dpaa2-qdma: Remove unnecessary local variables in DPDMAI_CMD_CREATE macro

2019-10-22 Thread Nathan Chancellor
them to fix this warning. Fixes: f2835adf8afb ("dmaengine: fsl-dpaa2-qdma: Add the DPDMAI(Data Path DMA Interface) support") Link: https://github.com/ClangBuiltLinux/linux/issues/746 Signed-off-by: Nathan Chancellor --- drivers/dma/fsl-dpaa2-qdma/dpdmai.c | 4 +--- 1 file changed, 1

[PATCH] kernel/profile: Use cpumask_available to check for NULL cpumask

2019-10-22 Thread Nathan Chancellor
troduced in commit f7e30f01a9e2 ("cpumask: Add helper cpumask_available()") to fix warnings like this while keeping the code the same. Link: https://github.com/ClangBuiltLinux/linux/issues/747 Signed-off-by: Nathan Chancellor --- kernel/profile.c | 6 +++--- 1 file changed, 3 insert

[PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-22 Thread Nathan Chancellor
r DVFS") Link: https://github.com/ClangBuiltLinux/linux/issues/748 Signed-off-by: Nathan Chancellor --- drivers/cpufreq/s3c64xx-cpufreq.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c index af0c00dabb22..c6bdfc30

[PATCH] usb: gadget: udc: bdc: Remove unnecessary NULL checks in bdc_req_complete

2019-10-22 Thread Nathan Chancellor
ontroller IP BDC") Link: https://github.com/ClangBuiltLinux/linux/issues/749 Signed-off-by: Nathan Chancellor --- Note: I am not sure if these checks were intended to check if the contents of these arrays were NULL or if there should be some other checks in lieu of these; I am not familiar wit

[PATCH] rtlwifi: Remove unnecessary NULL check in rtl_regd_init

2019-10-22 Thread Nathan Chancellor
ver") Link:https://github.com/ClangBuiltLinux/linux/issues/750 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/realtek/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c b/drivers/net/wireless/realtek/rtlw

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > > On 22-10-19, 17:09, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-pointer-compare: > > > > > > dri

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also have supported s3c6400 as well. > > > Kc

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:59:23PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > >

[PATCH] mips: Fix unroll macro when building with Clang

2019-10-10 Thread Nathan Chancellor
e that as a lower limit for this check with Clang (although MIPS wasn't buildable until Clang 9); building a kernel with Clang 9.0.0 has no issues after this change. Fixes: 6baaeadae911 ("MIPS: Provide unroll() macro, use it for cache ops") Link: https://github.com/ClangBuiltLinux/linu

[PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop_hc

2019-10-11 Thread Nathan Chancellor
r in at91_stop_hc()") Signed-off-by: Nathan Chancellor --- drivers/usb/host/ohci-at91.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 513e48397743..b635c6a1b1a9 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/hos

Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-13 Thread Nathan Chancellor
On Sat, Oct 12, 2019 at 05:59:18PM +0530, Shyam Saini wrote: > This parameters are not changed after early boot. > By making them __ro_after_init will reduce any attack surface in the > kernel. > > Link: https://lwn.net/Articles/676145/ > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin

[PATCH v4 1/3] powerpc: Don't add -mabi= flags when building with Clang

2019-10-13 Thread Nathan Chancellor
tLinux/linux/issues/240 Reviewed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message v2 -> v3: * Rebase and merge into a single series. v3 -> v4: * Rebase on v5.4-rc3. * Update links to point to llvmorg-9.0.0 instead of llvmorg-9.0.0-rc2. a

[PATCH v4 2/3] powerpc: Avoid clang warnings around setjmp and longjmp

2019-10-13 Thread Nathan Chancellor
/625 Link: https://github.com/llvm/llvm-project/commit/3be25e79477db2d31ac46493d97eca8c20592b07 Link: https://godbolt.org/z/B2oQnl Suggested-by: Segher Boessenkool Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v3 (I skipped v2 because the first patch in the series alr

[PATCH v4 0/3] LLVM/Clang fixes for pseries_defconfig

2019-10-13 Thread Nathan Chancellor
Hi all, This series includes a set of fixes for LLVM/Clang when building pseries_defconfig. These have been floating around as standalone patches so I decided to gather them up as a series so it was easier to review/apply them. This has been broken for a bit now, it would be nice to get these rev

[PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-13 Thread Nathan Chancellor
so it is not free to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/76cdcf25b883751d83402baea6316772aa73865c Reviewed-by: Nick Desaulneris Signed-off-by: Nathan Chancellor --- v1 -> v3: * New patch in the series

[PATCH] dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show

2020-04-28 Thread Nathan Chancellor
dd channel stat to debugfs") Link: https://github.com/ClangBuiltLinux/linux/issues/1012 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dp

[PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-28 Thread Nathan Chancellor
s: fceaf24a943d8 ("Staging: hv: add the Hyper-V virtual network driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1009 Signed-off-by: Nathan Chancellor --- v1 -> v2: * Move splat into commit message rather than issue. Comment from previous version: Do note that netvsc_x

Re: linux-next: Tree for Apr 28

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 06:10:06PM +1000, Stephen Rothwell wrote: > Hi all, > > Changes since 20200424: > > The qcom tree still had its build failure for which I reverted a commit. > > The hwmon-staging tree gained a build failure for which I reverted > a commit. > > The mac80211-next tree gain

[PATCH v4 5/5] MIPS: VDSO: Allow ld.lld to link the VDSO

2020-04-28 Thread Nathan Chancellor
IPS_PC32 _start Reported-by: Dmitry Golovin Signed-off-by: Nathan Chancellor Link: https://github.com/ClangBuiltLinux/linux/issues/785 Link: https://github.com/llvm/llvm-project/commit/e364e2e9ce50c12eb2bf093560e1a1a8544d455a --- v3 -> v4: * No changes. v2 -> v3: * No changes. v1 ->

[PATCH v4 3/5] MIPS: Unconditionally specify '-EB' or '-EL'

2020-04-28 Thread Nathan Chancellor
/elf.o: compiled for a big endian system and target is little endian mips64-linux-ld: arch/mips/vdso/elf.o: endianness incompatible with that of the selected emulation mips64-linux-ld: failed to merge target specific data of file arch/mips/vdso/elf.o ... Remove this legacy hack and just use

[PATCH v4 2/5] MIPS: VDSO: Move disabling the VDSO logic to Kconfig

2020-04-28 Thread Nathan Chancellor
f the MIPS VDSO binutils warning and linking the VDSO when LD is ld.lld. Wrapping the call to ld-ifversion with CONFIG_LD_IS_LLD does not work because the config values are wiped away during 'make clean'. Signed-off-by: Nathan Chancellor --- v3 -> v4: * No changes. v2 -> v3: * Fix

[PATCH v4 1/5] kbuild: add CONFIG_LD_IS_LLD

2020-04-28 Thread Nathan Chancellor
: Masahiro Yamada [nc: Reword commit message] Signed-off-by: Nathan Chancellor --- v3 -> v4: * No changes. v2 -> v3: * Add Masahiro's ack. v1 -> v2: * No changes. Sami, please scream if you are unhappy with how I worded this commit. init/Kconfig | 3 +++ 1 file changed, 3 insertions(

[PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-28 Thread Nathan Chancellor
llvm-readelf -p.comment arch/mips/vdso/vdso.so.dbg | sed 's/(.*//' String dump of section '.comment': [ 0] Linker: LLD 11.0.0 [62] ClangBuiltLinux clang version 11.0.0 Link: https://github.com/ClangBuiltLinux/linux/issues/785 Signed-off-by: Nathan Chancellor --- v3 -> v4: *

[PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-04-28 Thread Nathan Chancellor
Hi all, This series allows ld.lld to properly and completely link the MIPS vDSO. Patch 1 adds ld.lld support to Kconfig so that we can avoid certain ld.bfd checks. Patch 2 moves disabling of the VDSO to Kconfig. This allows us to avoid a warning with LD=ld.lld during the clean phase, when we do

Re: [PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 03:54:01PM -0700, Fangrui Song wrote: > > On 2020-04-28, Nathan Chancellor wrote: > > Currently, the VDSO is being linked through $(CC). This does not match > > how the rest of the kernel links objects, which is through the $(LD) > > variable. >

Re: linux-next: Tree for Apr 28

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 06:24:21PM -0700, Minchan Kim wrote: > Hello, > > On Tue, Apr 28, 2020 at 12:04:59PM -0700, Nathan Chancellor wrote: > > On Tue, Apr 28, 2020 at 06:10:06PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since

[PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Nathan Chancellor
d, it seems this one should have been assigned to rpcurupei. Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies") Link: https://github.com/ClangBuiltLinux/linux/issues/1016 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gt/debugfs_gt_

[PATCH -next] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
1 warning generated. Add an ifdef around the variable to fix this. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- arch/arm64/mm/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.

Re: [PATCH -next] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
On Wed, Oct 16, 2019 at 04:00:52AM +0100, Will Deacon wrote: > On Tue, Oct 15, 2019 at 03:43:04PM -0700, Nathan Chancellor wrote: > > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32 > > get disabled so there is a warning about max_dma being unused. > >

[PATCH -next v2] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
1 warning generated. Add an ifdef around the variable to fix this. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix check for CONFIG_ZONE_DMA32 as pointed out by Will. arch/arm64/mm/init.c | 2 ++ 1 file changed, 2 in

[PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-16 Thread Nathan Chancellor
1 warning generated. Add __maybe_unused to make this clear to the compiler. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix check for CONFIG_ZONE_DMA32 as pointed out by Will. v2 -> v3: * Use __maybe_u

Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-16 Thread Nathan Chancellor
On Wed, Oct 16, 2019 at 05:09:30PM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2019-10-16 at 16:08 +0100, Catalin Marinas wrote: > > On Wed, Oct 16, 2019 at 07:47:14AM -0700, Nathan Chancellor wrote: > > > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32

Re: [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-18 Thread Nathan Chancellor
On Mon, Oct 14, 2019 at 02:11:41PM -0500, Segher Boessenkool wrote: > On Mon, Oct 14, 2019 at 08:56:12AM -0700, Nick Desaulniers wrote: > > On Mon, Oct 14, 2019 at 2:35 AM Segher Boessenkool > > wrote: > > > > > > On Sun, Oct 13, 2019 at 07:51:01PM -0700, Nathan

[PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to_bootloader

2019-10-18 Thread Nathan Chancellor
hwell Signed-off-by: Nathan Chancellor --- drivers/bluetooth/btintel.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h index d2311156f778..a69ea8a87b9b 100644 --- a/drivers/bluetooth/btintel.h +++ b/drivers/bluetooth/btintel.h @@ -185,6 +18

Re: [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-21 Thread Nathan Chancellor
On Fri, Oct 18, 2019 at 03:02:10PM -0500, Segher Boessenkool wrote: > On Fri, Oct 18, 2019 at 12:00:22PM -0700, Nathan Chancellor wrote: > > Just as an FYI, there was some more discussion around the availablity > > and use of bcmp in this LLVM bug which spawned > > comm

[PATCH] drivers: net: xgene: Move status variable declaration into CONFIG_ACPI block

2019-07-26 Thread Nathan Chancellor
ion into the CONFIG_ACPI block so that there are no compiler warnings. Fixes: 570d785ba46b ("drivers: net: xgene: Remove acpi_has_method() calls") Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 3 ++- drivers/net/ethernet/apm/xgene/xgene_enet_s

Re: mmotm 2019-07-24-21-39 uploaded (mm/memcontrol)

2019-07-26 Thread Nathan Chancellor
On Thu, Jul 25, 2019 at 04:39:59PM -0700, Andrew Morton wrote: > On Thu, 25 Jul 2019 15:02:59 -0700 Randy Dunlap wrote: > > > On 7/24/19 9:40 PM, a...@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2019-07-24-21-39 has been uploaded to > > > > > >http://www.ozlabs.org/~akpm/

Re: mmotm 2019-07-24-21-39 uploaded (mm/memcontrol)

2019-07-26 Thread Nathan Chancellor
On Fri, Jul 26, 2019 at 09:19:52PM -0700, Andrew Morton wrote: > On Fri, 26 Jul 2019 20:42:05 -0700 Nathan Chancellor > wrote: > > > > @@ -2414,8 +2414,9 @@ void mem_cgroup_handle_over_high(void) > > >*/ > > > clamped_high = max(high, 1UL); > >

Re: [PATCH] kbuild: initialize CLANG_FLAGS correctly in the top Makefile

2019-07-29 Thread Nathan Chancellor
; Kbuild will recompile everything needlessly due to the build command > change. > > Fix this by correctly initializing CLANG_FLAGS. > > Fixes: 238bcbc4e07f ("kbuild: consolidate Clang compiler flags") > Cc: # v4.20+ > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor

[PATCH] arm64/neon: Disable -Wincompatible-pointer-types when building with Clang

2019-02-14 Thread Nathan Chancellor
egration running is more important so new warnings/errors or boot failures can be caught and fixed quickly. Link: https://github.com/ClangBuiltLinux/linux/issues/283 Suggested-by: Ard Biesheuvel Signed-off-by: Nathan Chancellor --- arch/arm64/include/asm/neon-intrinsics.h | 4 1 file changed

[PATCH] tee: optee: Initialize some structs using memset instead of braces

2019-02-19 Thread Nathan Chancellor
sues/370 Signed-off-by: Nathan Chancellor --- drivers/tee/optee/device.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index 5e4938bbef2b..167839b371f2 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee

[PATCH] iwlwifi: mvm: Use div64_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-19 Thread Nathan Chancellor
nd. Use div64_s64, which expects a signed dividend. Fixes: 937b10c0de68 ("iwlwifi: mvm: add debug prints for FTM") Link: https://github.com/ClangBuiltLinux/linux/issues/372 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c | 2 +- 1 file chan

Re: [PATCH] iwlwifi: mvm: Use div64_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-20 Thread Nathan Chancellor
On Wed, Feb 20, 2019 at 11:51:34AM +0100, Arnd Bergmann wrote: > On Tue, Feb 19, 2019 at 7:22 PM Nathan Chancellor > wrote: > > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c > > b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiat

Re: [PATCH] kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig

2019-02-20 Thread Nathan Chancellor
d warning >for "make W=1"") turned off this option for GCC < 4.9 >Arnd provided more explanation in https://lkml.org/lkml/2017/3/14/903 > > I think this looks better by shifting the logic from Makefile to Kconfig. > I agree! > Signed-off-by: Masahiro Ya

[PATCH] staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-20 Thread Nathan Chancellor
uot;) Link: https://github.com/ClangBuiltLinux/linux/issues/375 Signed-off-by: Nathan Chancellor --- drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c b/

[PATCH v2] iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-21 Thread Nathan Chancellor
dend. Use div_s64, which expects a signed dividend. Fixes: 937b10c0de68 ("iwlwifi: mvm: add debug prints for FTM") Link: https://github.com/ClangBuiltLinux/linux/issues/372 Suggested-by: Arnd Bergmann Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix logic (as the return value

[PATCH v5] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-02-07 Thread Nathan Chancellor
es/85 Link: https://github.com/ClangBuiltLinux/linux/issues/154 Link: https://github.com/ClangBuiltLinux/linux/issues/157 Signed-off-by: Nathan Chancellor Acked-by: Bradley Grove Acked-by: Don Brace Reviewed-by: Bart Van Assche Tested-by: Nick Desaulniers --- v4 -> v5: * Collect tags. * Fix

Re: [PATCH v10, RESEND 4/6] tpm: move tpm_chip definition to include/linux/tpm.h

2019-02-07 Thread Nathan Chancellor
On Wed, Feb 06, 2019 at 05:24:50PM +0100, Roberto Sassu wrote: > The tpm_chip structure contains the list of PCR banks currently allocated > in the TPM. When support for crypto agility will be added to the TPM > driver, users of the driver have to provide a digest for each allocated > bank to tpm_p

<    2   3   4   5   6   7   8   9   10   11   >