Re: [PATCH 4.9 00/32] 4.9.113-stable review

2018-07-16 Thread Nathan Chancellor
On Mon, Jul 16, 2018 at 09:36:08AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.113 release. > There are 32 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.4 00/43] 4.4.141-stable review

2018-07-16 Thread Nathan Chancellor
On Mon, Jul 16, 2018 at 09:36:05AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.141 release. > There are 43 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.17 00/67] 4.17.7-stable review

2018-07-16 Thread Nathan Chancellor
On Mon, Jul 16, 2018 at 09:33:38AM -0700, Guenter Roeck wrote: > On Mon, Jul 16, 2018 at 09:34:29AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.17.7 release. > > There are 67 patches in this series, all will be posted as a response > > to this one. I

Re: Linux 4.17.7

2018-07-17 Thread Nathan Chancellor
On Tue, Jul 17, 2018 at 12:59:29PM +0200, Greg KH wrote: > NOTE, this kernel release is broken for i386 systems. If you are > running such a machine, do NOT update to this release, you will not be > able to boot properly. > > I did this release anyway with this known problem as there is a fix in

Re: [PATCH 1/6] tools/rtla: Fix Makefile compiler options for clang

2024-02-06 Thread Nathan Chancellor
On Tue, Feb 06, 2024 at 12:05:29PM +0100, Daniel Bristot de Oliveira wrote: > The following errors are showing up when compiling rtla with clang: > > $ make HOSTCC=clang CC=clang LLVM_IAS=1 > [...] > > clang -O -g -DVERSION=\"6.8.0-rc1\" -flto=auto -ffat-lto-objects > -fexceptions -fsta

Re: [PATCH] tracing: Use strcmp() in __assign_str() WARN_ON() check

2024-03-13 Thread Nathan Chancellor
On Tue, Mar 12, 2024 at 11:30:02AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The WARN_ON() check in __assign_str() to catch where the source variable > to the macro doesn't match the source variable to __string() gives an > error in clang: > > >> include/trace/events/sun

Re: net/sunrpc/sched.c: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead)

2024-03-18 Thread Nathan Chancellor
Hi Naresh, On Mon, Mar 18, 2024 at 02:55:54PM +0530, Naresh Kamboju wrote: > The following build warnings / errors noticed on x86 kselftests build with > clang nightly / clang-17 on Linux next tag next-20240318. > > This build config is generated from kselftest merge configs [1]. > > Reported-

[PATCH 1/2] compiler_types: Ensure __diag_clang() is always available

2024-03-19 Thread Nathan Chancellor
oth compiler-clang.h and compiler-gcc.h. Add an empty stub for __diag_clang() in compiler_types.h, so that it is always defined and just becomes a no-op when using GCC. Fixes: f014a00bbeb0 ("compiler-clang.h: Add __diag infrastructure for clang") Signed-off-by: Nathan Chancellor --- incl

[PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
to make the merge window so that this warning does not proliferate into other trees that base on -rc1. --- Nathan Chancellor (2): compiler_types: Ensure __diag_clang() is always available tracing: Ignore -Wstring-compare with diagnostic macros include/linux/compiler_types.h

[PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros

2024-03-19 Thread Nathan Chancellor
ARN_ON() check") Reported-by: Linux Kernel Functional Testing Closes: https://lore.kernel.org/all/CA+G9fYs=otkazs6g1p1ewadfr0qoe6lgovsohqkxmfxoteo...@mail.gmail.com/ Signed-off-by: Nathan Chancellor --- include/trace/stages/stage6_event_callback.h | 5 + 1 file changed, 5 insertions(

Re: [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
On Tue, Mar 19, 2024 at 06:15:09PM -0400, Steven Rostedt wrote: > On Tue, 19 Mar 2024 09:07:51 -0700 > Nathan Chancellor wrote: > > > Hi all, > > > > This series fully resolves the new instance of -Wstring-compare from > > within the __assign_str() macro.

Re: [PATCH] drivers: remoteproc: xlnx: Add Versal and Versal-NET support

2024-04-23 Thread Nathan Chancellor
Hi Tanmay, On Thu, Apr 18, 2024 at 03:01:25PM -0700, Tanmay Shah wrote: > AMD-Xilinx Versal platform is successor of ZynqMP platform. > Real-time Processing Unit R5 cluster IP on Versal is same as > of ZynqMP Platform. Power-domains ids for Versal platform is > different than ZynqMP. > > AMD-Xili

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-06 Thread Nathan Chancellor
E) part. > > Signed-off-by: Michal Suchanek This appears to work for me. Reviewed-by: Nathan Chancellor > --- > scripts/package/kernel.spec | 8 > scripts/package/mkspec | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/scripts/p

Re: [PATCH 5/5] kbuild: unify no-compiler-targets and no-sync-config-targets

2023-10-09 Thread Nathan Chancellor
On Mon, Oct 09, 2023 at 09:42:10PM +0900, Masahiro Yamada wrote: > Now that vdso_install does not depend on any in-tree build artifact, > it no longer invokes a compiler, making no-compiler-targets the same > as no-sync-config-targets. > > Signed-off-by: Masahiro Yamada > --- > > Makefile | 13

[PATCH] eventfs: Use ERR_CAST() in eventfs_create_events_dir()

2023-10-18 Thread Nathan Chancellor
Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Nathan Chancellor --- fs/tracefs/event_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 1ccd100bc565..9f19b6

Re: [PATCH 4/8] riscv: ftrace: align patchable functions to 4 Byte boundary

2024-06-13 Thread Nathan Chancellor
Hi Andy, On Thu, Jun 13, 2024 at 03:11:09PM +0800, Andy Chiu wrote: > We are changing ftrace code patching in order to remove dependency from > stop_machine() and enable kernel preemption. This requires us to align > functions entry at a 4-B align address. > > However, -falign-functions on older

Re: [PATCH 3/8] riscv: ftrace: support fastcc in Clang for WITH_ARGS

2024-06-13 Thread Nathan Chancellor
event ftrace from clobbering them. > > - [1]: https://reviews.llvm.org/D68559 > Reported-by: Evgenii Shatokhin > Closes: > https://lore.kernel.org/linux-riscv/7e7c7914-445d-426d-89a0-59a9199c4...@yadro.com/ > Signed-off-by: Andy Chiu Acked-by: Nathan Chancellor > --- >

Re: [PATCHv8 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe

2024-06-14 Thread Nathan Chancellor
Hi Jiri, On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote: > Adding uretprobe syscall instead of trap to speed up return probe. ... > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 2c83ba776fc7..2816e65729ac 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/eve

Re: [PATCHv8 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe

2024-06-14 Thread Nathan Chancellor
On Fri, Jun 14, 2024 at 09:26:59PM +0200, Jiri Olsa wrote: > On Fri, Jun 14, 2024 at 10:48:22AM -0700, Nathan Chancellor wrote: > > Hi Jiri, > > > > On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote: > > > Adding uretprobe syscall instead of

Re: [PATCH 4/8] riscv: ftrace: align patchable functions to 4 Byte boundary

2024-06-17 Thread Nathan Chancellor
On Mon, Jun 17, 2024 at 10:38:55AM +0800, Andy Chiu wrote: > On Fri, Jun 14, 2024 at 3:09 AM Nathan Chancellor wrote: > > > > Hi Andy, > > > > On Thu, Jun 13, 2024 at 03:11:09PM +0800, Andy Chiu wrote: > > > We are changing ftrace code patchin

Re: [PATCH 0/2] kmod /usr support

2024-08-21 Thread Nathan Chancellor
On Tue, Dec 19, 2023 at 05:37:31PM +0900, Masahiro Yamada wrote: > On Thu, Dec 7, 2023 at 3:37 AM Lucas De Marchi > wrote: > > > > On Fri, Nov 10, 2023 at 01:13:53PM +0100, Michal Suchanek wrote: > > >Hello, > > > > > >This is resend of the last patch in the series that adds prefix support > > >t

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-14 Thread Nathan Chancellor
On Sun, Feb 14, 2021 at 07:49:22PM +0800, Stephen Zhang wrote: > Masahiro Yamada 于2021年2月13日周六 下午8:46写道: > > This is the steps I tested. > > > > > > masahiro@oscar:~/ref/linux$ make O=build defconfig all -j24 > > [ snip ] > > masahiro@oscar:~/ref/linux$ > > ./scripts/clang-tools/gen_compile_com

Re: [PATCH mips-next] vmlinux.lds.h: catch more UBSAN symbols into .data

2021-02-16 Thread Nathan Chancellor
On Tue, Feb 16, 2021 at 09:56:32AM -0800, 'Nick Desaulniers' via Clang Built Linux wrote: > On Tue, Feb 16, 2021 at 12:55 AM Alexander Lobakin wrote: > > > > LKP triggered lots of LD orphan warnings [0]: > > Thanks for the patch, just some questions. > > With which linker? Was there a particul

Re: [PATCH 1/2] kbuild: remove ld-version macro

2021-02-16 Thread Nathan Chancellor
On Tue, Feb 16, 2021 at 12:10:03PM +0900, Masahiro Yamada wrote: > There is no direct user of ld-version; you can use CONFIG_LD_VERSION > if needed. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > scripts/Kbuild.include | 6 +- > 1 f

Re: [PATCH 2/2] kbuild: check the minimum linker version in Kconfig

2021-02-16 Thread Nathan Chancellor
cconfig] Error 1 > make[1]: *** [Makefile:600: syncconfig] Error 2 > make: *** [Makefile:708: include/config/auto.conf] Error 2 > > Thanks to David Laight for suggesting shell script improvements. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor Tested-by

[PATCH] drm/i915: Enable -Wuninitialized

2021-02-16 Thread Nathan Chancellor
ea4a7ba9bf6 ("drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show") References: 2034c2129bc4 ("drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state") Reported-by: Arnd Bergmann Signed-off-by: Nathan Chancellor --- drivers/g

[PATCH] Makefile: Remove # characters from compiler string

2021-02-16 Thread Nathan Chancellor
ltLinux/linux/issues/1298 Reported-by: Michael Fuckner Signed-off-by: Nathan Chancellor --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index de1acaefe87e..9bfe1307447e 100644 --- a/Makefile +++ b/Makefile @@ -581,7 +581,7 @@ endif # Some architect

Re: [PATCH 1/2] gcov: re-fix clang-11+ support

2021-04-07 Thread Nathan Chancellor
r, in clang-11, the additional checksum is no longer optional. > > Link: https://reviews.llvm.org/rG25544ce2df0daa4304c07e64b9c8b0f7df60c11d > Cc: sta...@vger.kernel.org #5.4+ > Reported-by: Prasad Sodagudi > Tested-by: Prasad Sodagudi > Signed-off-by: Nick Desaulniers Review

Re: [PATCH 2/2] gcov: re-drop support for clang-10

2021-04-07 Thread Nathan Chancellor
d in GCOV support. > > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > kernel/gcov/clang.c | 40 > 1 file changed, 40 deletions(-) > > diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c > index 1747204541bf

[PATCH] ACPI / CPPC: Replace cppc_attr with kobj_attribute

2021-04-07 Thread Nathan Chancellor
158c998ea44b ("ACPI / CPPC: add sysfs support to compute delivered performance") Link: https://github.com/ClangBuiltLinux/linux/issues/1343 Signed-off-by: Nathan Chancellor --- drivers/acpi/cppc_acpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/dr

Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure

2021-04-07 Thread Nathan Chancellor
cs/UsersManual.html#profile-guided-optimization > > Signed-off-by: Sami Tolvanen > Co-developed-by: Bill Wendling > Signed-off-by: Bill Wendling > Tested-by: Nick Desaulniers > Reviewed-by: Nick Desaulniers > Reviewed-by: Fangrui Song Few small nits below, not sure they wa

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-04-08 Thread Nathan Chancellor
1 at 3:06 PM Nick Desaulniers > wrote: > > > > On Wed, Mar 31, 2021 at 2:58 PM Nathan Chancellor wrote: > > > > > > On Wed, Mar 31, 2021 at 02:27:03PM -0700, Jian Cai wrote: > > > > > > > > I just realized you already proposed so

[PATCH] block: Disable -Walign-mismatch for blk-mq.c

2021-04-08 Thread Nathan Chancellor
0310182307.zzcbi5w5jrmveld4@archlinux-ax161/ Link: https://lore.kernel.org/r/20210330230249.709221-1-jian...@google.com/ Signed-off-by: Nathan Chancellor --- block/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/block/Makefile b/block/Makefile index 8d841f5f986f..d69ac0bd8e61 100644 --- a

[PATCH] arm64: vdso32: Use full path to Clang instead of relying on PATH

2018-05-22 Thread Nathan Chancellor
sembler command failed with exit code 1 Signed-off-by: Nathan Chancellor --- Hi everyone, I noticed this issue when building the Pixel 2's kernel. Since this is a supplement to https://patchwork.kernel.org/patch/10186671/, I was instructed by Mark to push it here. I could not find a public git

Re: [PATCH v2] phy: tegra: Remove self cast in tegra_xusb_port_find_lane

2018-04-03 Thread Nathan Chancellor
On Tue, Apr 03, 2018 at 12:49:16PM +0200, Thierry Reding wrote: > On Sun, Apr 01, 2018 at 04:04:10AM -0700, Nathan Chancellor wrote: > > Clang warns about casting variables to themselves because it is rarely > > necessary. Removing the cast should not change anything regarding t

Re: [PATCH 4.4 00/43] 4.4.125-stable review

2018-03-27 Thread Nathan Chancellor
On Tue, Mar 27, 2018 at 06:27:04PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.125 release. > There are 43 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.4 20/43] mm/vmalloc: add interfaces to free unmapped page table

2018-03-27 Thread Nathan Chancellor
On Tue, Mar 27, 2018 at 03:17:00PM -0500, Dan Rue wrote: > On Tue, Mar 27, 2018 at 06:27:24PM +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Toshi Kani > > > > commit b6bdb7517c3d3f41f20e5

Re: [PATCH 4.4 20/43] mm/vmalloc: add interfaces to free unmapped page table

2018-03-27 Thread Nathan Chancellor
On Tue, Mar 27, 2018 at 08:40:56PM +, Kani, Toshi wrote: > On Tue, 2018-03-27 at 13:31 -0700, Nathan Chancellor wrote: > > On Tue, Mar 27, 2018 at 03:17:00PM -0500, Dan Rue wrote: > > > On Tue, Mar 27, 2018 at 06:27:24PM +0200, Greg Kroah-Hartman wrote: > > > >

Re: [PATCH 4.4 20/43] mm/vmalloc: add interfaces to free unmapped page table

2018-03-27 Thread Nathan Chancellor
On Wed, Mar 28, 2018 at 08:32:02AM +0200, gre...@linuxfoundation.org wrote: > On Tue, Mar 27, 2018 at 01:47:55PM -0700, Nathan Chancellor wrote: > > On Tue, Mar 27, 2018 at 08:40:56PM +, Kani, Toshi wrote: > > > On Tue, 2018-03-27 at 13:31 -0700, Nathan Chancellor wrote: >

Re: [PATCH 4.4 00/20] 4.4.126-stable review

2018-03-29 Thread Nathan Chancellor
On Thu, Mar 29, 2018 at 08:00:36PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.126 release. > There are 20 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.4 00/50] 4.4.130-stable review

2018-04-27 Thread Nathan Chancellor
On Fri, Apr 27, 2018 at 03:58:02PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.130 release. > There are 50 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.14 00/80] 4.14.38-stable review

2018-04-27 Thread Nathan Chancellor
On Fri, Apr 27, 2018 at 03:57:53PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.38 release. > There are 80 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.4 00/44] 4.4.131-stable review

2018-04-30 Thread Nathan Chancellor
On Mon, Apr 30, 2018 at 12:24:11PM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.131 release. > There are 44 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.14 00/91] 4.14.39-stable review

2018-04-30 Thread Nathan Chancellor
On Mon, Apr 30, 2018 at 12:23:42PM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.39 release. > There are 91 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 3.18 000/185] 3.18.111-stable review

2018-05-28 Thread Nathan Chancellor
On Mon, May 28, 2018 at 12:00:41PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.111 release. > There are 185 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCH 4.14 000/496] 4.14.45-stable review

2018-05-28 Thread Nathan Chancellor
On Mon, May 28, 2018 at 11:56:25AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.45 release. > There are 496 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kno

Re: [PATCH 4.4 000/268] 4.4.134-stable review

2018-05-28 Thread Nathan Chancellor
On Mon, May 28, 2018 at 11:59:34AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.134 release. > There are 268 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kno

Re: [PATCH 4.4 00/37] 4.4.136-stable review

2018-06-05 Thread Nathan Chancellor
On Tue, Jun 05, 2018 at 07:01:05PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.136 release. > There are 37 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.14 000/183] 4.14.37-stable review

2018-04-25 Thread Nathan Chancellor
On Wed, Apr 25, 2018 at 12:33:40PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.37 release. > There are 183 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kno

Re: [PATCH] tmpfs: fix uninitialized return value in shmem_link

2019-02-28 Thread Nathan Chancellor
On Wed, Feb 27, 2019 at 09:09:40AM -0500, Qian Cai wrote: > On Mon, 2019-02-25 at 16:07 -0800, Linus Torvalds wrote: > > On Mon, Feb 25, 2019 at 4:03 PM Qian Cai wrote: > > > > > > > > Of course, that's just gcc. I have no idea what llvm ends up doing. > > > > > > Clang 7.0: > > > > > > # clang

Re: [PATCH] x86/boot: clean up headers

2019-03-01 Thread Nathan Chancellor
BuiltLinux/linux/issues/347 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > Note that this only regresses for us on linux-next (not mainline). > > arch/x86/boot/string.c | 7 --- > 1 file changed, 4 insertions(+), 3 deleti

Re: [PATCH] x86/KASLR: always return a value from process_mem_region

2019-03-02 Thread Nathan Chancellor
ould probably have been placed > outside the #endif, so move it there > > Link: https://github.com/ClangBuiltLinux/linux/issues/360 > Signed-off-by: Louis Taylor Reviewed-by: Nathan Chancellor Thanks for the patch! > --- > arch/x86/boot/compressed/kaslr.c | 2 +- >

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-15 Thread Nathan Chancellor
On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > From: Will Deacon > > commit 045afc24124d80c6998d9c770844c67912083506 upstream. > > Rather embarrassingly, our futex() FUTEX_WAKE_OP implementation doesn't > explicitly set the return value on the non-faulting path and instead

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > From: Will Deacon > > > > > > commit 045a

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Tue, Apr 16, 2019 at 10:13:40AM +0100, Will Deacon wrote: > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > From: Will Deacon > > [...] > > > > @@ -53,2

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Wed, Apr 17, 2019 at 08:15:08AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wro

[PATCH] arm64: futex: Restore oldval initialization to work around buggy compilers

2019-04-17 Thread Nathan Chancellor
form/prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9/ Cc: sta...@vger.kernel.org Fixes: 045afc24124d ("arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value") Signed-off-by: Nathan Chancellor --- arch/arm64/include/asm/futex.h | 2 +- 1 file changed, 1 inse

Re: [PATCH 3.18 055/104] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-24 Thread Nathan Chancellor
1, %w4", > + __futex_atomic_op("and %w3, %w1, %w4", > ret, oldval, uaddr, tmp, ~oparg); > break; > case FUTEX_OP_XOR: > - __futex_atomic_op("eor %w0, %w1, %w4", > +

[PATCH] thunderbolt: Make priority unsigned in struct tb_path

2019-04-24 Thread Nathan Chancellor
nnel.c:504: path->priority = 5; Furthmore, that value is only assigned to an unsigned integer in tb_path_activate (the priority member in struct tb_regs_hop). Fixes: 44242d6c9703 ("thunderbolt: Add support for DMA tunnels") Link: https://github.com/ClangBuiltLinux/linux/issues/4

[PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nathan Chancellor
l.org/lkml/022e41c0-8465-dc7a-a45c-64187ecd9...@amd.com/ [2]: https://lore.kernel.org/lkml/20181128.215241.702406654469517539.da...@davemloft.net/ Link: https://github.com/ClangBuiltLinux/linux/issues/455 Signed-off-by: Nathan Chancellor --- drivers/staging/kpc2000/kpc2000/cell_probe.c

Re: [PATCH] thunderbolt: Make priority unsigned in struct tb_path

2019-04-24 Thread Nathan Chancellor
On Wed, Apr 24, 2019 at 11:49:37AM -0700, Nick Desaulniers wrote: > On Wed, Apr 24, 2019 at 11:34 AM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/thunderbolt/tunnel.c:504:17: warning: implicit truncation from > > 'int' to bit-fi

Re: [PATCH] bcache: avoid clang -Wunintialized warning

2019-04-25 Thread Nathan Chancellor
On Fri, Mar 22, 2019 at 03:35:00PM +0100, Arnd Bergmann wrote: > clang has identified a code path in which it thinks a > variable may be unused: > > drivers/md/bcache/alloc.c:333:4: error: variable 'bucket' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-unin

Re: -Wsometimes-uninitialized Clang warning in drivers/net/ethernet/broadcom/bnxt/bnxt.c

2019-04-25 Thread Nathan Chancellor
ot;). Looks like Michael wrote and is still maintaining > > the driver. > > > > On Wed, Mar 20, 2019 at 12:08 PM Nathan Chancellor > > wrote: > > > > > > On Thu, Mar 07, 2019 at 05:57:35PM -0700, Nathan Chancellor wrote: > > > > Hi all, > > &

Re: -Wsometimes-uninitialized Clang warning in drivers/net/ethernet/broadcom/bnxt/bnxt.c

2019-04-25 Thread Nathan Chancellor
On Thu, Apr 25, 2019 at 11:33:04AM -0700, Michael Chan wrote: > On Thu, Apr 25, 2019 at 11:14 AM Nathan Chancellor > wrote: > > > > Hi Arnd, > > > > On Fri, Mar 22, 2019 at 03:32:50PM +0100, Arnd Bergmann wrote: > > > On Wed, Mar 20, 2019 at 9:41 PM 'N

[PATCH] Makefile: Add '-fno-builtin-bcmp' to CLANG_FLAGS

2019-03-12 Thread Nathan Chancellor
builds/104027249 Link: https://github.com/ClangBuiltLinux/linux/issues/416 Link: https://bugs.llvm.org/show_bug.cgi?id=41035 Cc: sta...@vger.kernel.org Signed-off-by: Nathan Chancellor --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 9ef547fc7

Re: [PATCH] Makefile: Add '-fno-builtin-bcmp' to CLANG_FLAGS

2019-03-13 Thread Nathan Chancellor
On Wed, Mar 13, 2019 at 09:13:11AM +0100, Rasmus Villemoes wrote: > On 12/03/2019 22.52, Nathan Chancellor wrote: > > After LLVM revision r355672 [1], all known working kernel configurations > > fail to link [2]: > > > > ld: init/do_mounts.o: in function `prepare_

Re: [PATCH] Makefile: Add '-fno-builtin-bcmp' to CLANG_FLAGS

2019-03-13 Thread Nathan Chancellor
On Wed, Mar 13, 2019 at 02:48:49PM +0100, Arnd Bergmann wrote: > On Wed, Mar 13, 2019 at 2:44 PM Nathan Chancellor > wrote: > > On Wed, Mar 13, 2019 at 09:13:11AM +0100, Rasmus Villemoes wrote: > > > Wouldn't it be better to just define bcmp as an alias for memcm

Re: [PATCH v4] lib/string.c: implement a basic bcmp

2019-03-13 Thread Nathan Chancellor
nk: https://code.woboq.org/userspace/glibc/string/memcmp.c.html#bcmp > Link: > https://github.com/llvm/llvm-project/commit/8e16d73346f8091461319a7dfc4ddd18eedcff13 > Link: https://github.com/ClangBuiltLinux/linux/issues/416 > Cc: sta...@vger.kernel.org > Reported-by: Nathan Chancello

Re: [PATCH] kbuild, LLVMLinux: Don't suppress format warnings

2019-02-06 Thread Nathan Chancellor
On Tue, Feb 05, 2019 at 05:26:05PM +0900, Masahiro Yamada wrote: > On Sat, Feb 2, 2019 at 6:10 AM wrote: > > > > From: Jon Flatley > > > > gcc produces format warnings that clang suppresses. To keep behavior > > consistent between gcc and clang, don't suppress format warnings in > > clang. > > >

Re: [PATCH] kbuild, LLVMLinux: Don't suppress format warnings

2019-02-06 Thread Nathan Chancellor
On Wed, Feb 06, 2019 at 09:36:55AM -0800, Nick Desaulniers wrote: > On Wed, Feb 6, 2019 at 9:32 AM Jon Flatley wrote: > > > > On Wed, Feb 6, 2019 at 8:45 AM Nathan Chancellor > > wrote: > > > > > > On Tue, Feb 05, 2019 at 05:26:05PM +0900, Masahiro Yamada

Re: [PATCH] kbuild, LLVMLinux: Don't suppress format warnings

2019-02-06 Thread Nathan Chancellor
On Wed, Feb 06, 2019 at 04:30:21PM -0800, Nick Desaulniers wrote: > On Wed, Feb 6, 2019 at 4:28 PM Masahiro Yamada > wrote: > > BTW, it would be nice if kbuild test robot > > could test building with clang ... > > Is "kbuild test robot" different than 0day, kernelCI, or ClangBuiltLinux's CI? > --

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-01-25 Thread Nathan Chancellor
On Fri, Dec 14, 2018 at 08:09:00PM +, Wentland, Harry wrote: > On 2018-12-11 5:07 p.m., Nick Desaulniers wrote: > > On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor > > wrote: > >> > >> On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: >

[PATCH RESEND] ARM: Ensure that NEON code always compiles with Clang

2019-01-25 Thread Nathan Chancellor
e beginning of the NEON_FLAGS definitions so that __ARM_NEON__ always gets definined by Clang. This doesn't functionally change anything because that code will only run where NEON is supported, which is implicitly armv7. Link: https://github.com/ClangBuiltLinux/linux/issues/287 Suggested-by:

[PATCH RESEND] fs/exofs: Remove ignored __weak attribute

2019-01-25 Thread Nathan Chancellor
xofs: Kbuild, Headers and osd utils"). Reported-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor Acked-by: Boaz Harrosh --- Andrew, could you please pick this up? This warning is rather noisy when doing allyesconfig builds. fs/exofs/common.h | 2 +- 1 f

[PATCH RESEND] libosd: Remove ignored __weak attribute

2019-01-25 Thread Nathan Chancellor
^ Just remove the attribute because it hasn't been correct since the initial addition of this file in commit de258bf5e638 ("[SCSI] libosd: OSDv1 Headers"). Reported-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- Resending as there wa

[PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
({ init_waitqueue_head(&name); name; }) ^~~~ 1 error generated. Explicitly disable the warning like commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings"). Link: https://github.com/ClangBuiltLinux/linux/issues/220 Signed-off-by: Nathan Chan

Re: [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
On Sat, Jan 26, 2019 at 12:11:23AM -0700, Nathan Chancellor wrote: > This warning is disabled by default in scripts/Makefile.extrawarn when > W= is not provided but this Makefile adds -Wall after this warning is > disabled so it shows up in the build when it shouldn't: > > I

[PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-25 Thread Nathan Chancellor
es/85 Link: https://github.com/ClangBuiltLinux/linux/issues/154 Link: https://github.com/ClangBuiltLinux/linux/issues/157 Signed-off-by: Nathan Chancellor Reviewed-by: Bart Van Assche --- v3 -> v4: * Repost with Bart's suggested change and his reviewed by (mainly as an excuse to repost with the bel

Re: [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
On Fri, Jan 25, 2019 at 11:34:19PM -0800, Nick Desaulniers wrote: > On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor > wrote: > > > > This warning is disabled by default in scripts/Makefile.extrawarn when > > W= is not provided but this Makefile adds -Wall after this wa

Re: Clang warnings in net/phonet

2019-01-26 Thread Nathan Chancellor
On Mon, Jan 07, 2019 at 07:54:20PM -0700, Nathan Chancellor wrote: > Hi all, > > When building the kernel with Clang, this warning comes up in net/phonet. > > net/phonet/pep.c:224:16: warning: array index 1 is past the end of the array > (which contains 1 element) [-Warray-bo

Re: [PATCH] soc: ti: knav_dma: Use proper enum in pktdma_init_chan

2019-01-26 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 05:41:14PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/soc/ti/knav_dma.c:601:20: warning: implicit conversion from > enumeration type 'enum dma_data_direction' to different en

Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

2019-01-26 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of > variable of type 'unsigned char' to itself [-Wself-assign] > offset = offset; >

Re: [PATCH] pcmcia: Remove unnecessary parentheses

2019-01-26 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:55:40PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/scsi/pcmcia/nsp_cs.c:1137:27: warning: equality comparison with > extraneous parentheses [-Wparentheses-equality] > if ((tmpSC->SCp.Message == MS

Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

2019-01-27 Thread Nathan Chancellor
On Sun, Jan 27, 2019 at 05:42:01PM +0900, Masanori Goto wrote: > Thanks for the fix! > > 2019年1月27日(日) 4:11 Nathan Chancellor : > > > > On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > > > Clang warns: > > > > > > drivers/scs

Re: [PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-28 Thread Nathan Chancellor
s the ioctls inline with the reset of the kernel, and it removes > ambiguity, which is never good when dealing with compilers. > > Link: https://github.com/ClangBuiltLinux/linux/issues/85 > Link: https://github.com/ClangBuiltLinux/linux/issues/154 > Link: https://github.com/ClangBuilt

[PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-03-26 Thread Nathan Chancellor
s: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") Signed-off-by: Nathan Chancellor --- My apologies if this has already been sent, I didn't see anything in tip or on LKML. drivers/clocksource/timer-ti-dm.c | 28 -

Re: [PATCH v3] Makefile: lld: tell clang to use lld

2019-04-02 Thread Nathan Chancellor
s://github.com/ClangBuiltLinux/linux/issues/357 > Suggested-by: Nathan Chancellor > Suggested-by: Masahiro Yamada > Signed-off-by: Nick Desaulniers > --- > Changes V2->V3: > * Use absolute path based on `which $LD` as per Masahiro. > * Add -Qunused-arguments. > * Drop teste

Re: [PATCH v3] Makefile: lld: tell clang to use lld

2019-04-02 Thread Nathan Chancellor
-c) such as when cc-option is used. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/342 > > Link: https://github.com/ClangBuiltLinux/linux/issues/366 > > Link: https://github.com/ClangBuiltLinux/linux/issues/357 > > Suggested-by: Nathan Chancellor > >

Re: [PATCH v4] Makefile: lld: tell clang to use lld

2019-04-02 Thread Nathan Chancellor
ltLinux/linux/issues/366 > Link: https://github.com/ClangBuiltLinux/linux/issues/357 > Suggested-by: Nathan Chancellor > Suggested-by: Masahiro Yamada > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > Changes V3->V4: >

Re: [PATCH -next] pinctrl: artpec6: Make two functions static

2019-04-08 Thread Nathan Chancellor
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warnings: > > drivers/pinctrl/pinctrl-artpec6.c:691:5: warning: > symbol 'artpec6_pmx_enable' was not declared. Should it be static? > drivers/pinctrl/pinctrl-artpec6.c:705:6: warning: > symbol 'artp

Re: [PATCH 03/12] s390: purgatory: pass --target option to clang

2019-04-08 Thread Nathan Chancellor
0 > Would ifdef CONFIG_CC_IS_CLANG KBUILD_CFLAGS += --target=s390x-linux endif be a little clearer (and save a cc-option call)? Otherwise, makes sense. Reviewed-by: Nathan Chancellor

Re: [PATCH 04/12] s390: qeth: address type mismatch warning

2019-04-08 Thread Nathan Chancellor
problem. > > Signed-off-by: Arnd Bergmann I wonder if it is better to just change the func parameter to type long. I guess it's better to keep the type safety to make sure values aren't unintentionally mixed but the body of the functions is the same so does the ty

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Nathan Chancellor
^ > > Add initializations to all affected code paths to shut up the warning > and make the warning output consistent. > > Signed-off-by: Arnd Bergmann I'll never get used to seeing negative numbers assigned to unsigned integers... Reviewed-by: Nathan Chance

Re: [PATCH 06/12] s390: ctcm: fix ctcm_new_device error return code

2019-04-08 Thread Nathan Chancellor
already eliminated the assignment of the return code > based on some earlier optimization step. > > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drivers/s390/net/ctcm_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/s390/ne

Re: [PATCH 07/12] s390: cio: fix cio_irb declaration

2019-04-08 Thread Nathan Chancellor
> ../include/linux/percpu-defs.h:49:26: note: expanded from macro '__PCPU_ATTRS' > __percpu __attribute__((section(PER_CPU_BASE_SECTION sec))) \ > ^ > Use DECLARE_PER_CPU_ALIGNED() here, to make the two match. > > Signed-off-by: Arnd

Re: [PATCH][next] acpi/hmat: fix uninitialized pointer dereference on pointer 'target'

2019-04-08 Thread Nathan Chancellor
y: ("Uninitialized pointer read") > Signed-off-by: Colin Ian King Reviewed-by: Nathan Chancellor > --- > drivers/acpi/hmat/hmat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c > index

Re: [PATCH 03/12] s390: purgatory: pass --target option to clang

2019-04-09 Thread Nathan Chancellor
On Tue, Apr 09, 2019 at 08:43:09AM +0200, Arnd Bergmann wrote: > On Tue, Apr 9, 2019 at 12:03 AM Nathan Chancellor > wrote: > > > > On Mon, Apr 08, 2019 at 11:26:16PM +0200, Arnd Bergmann wrote: > > > The purgatory Makefile does not inherit the original cflags, >

Re: Clang patches for 4.9

2019-02-25 Thread Nathan Chancellor
On Mon, Feb 25, 2019 at 03:47:19PM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 25, 2019 at 03:45:13PM +0100, Greg Kroah-Hartman wrote: > > On Sun, Feb 24, 2019 at 11:13:01PM -0700, Nathan Chancellor wrote: > > > Hi Greg and Sasha, > > > > > > Attached are

Re: Clang patches for 4.9

2019-02-25 Thread Nathan Chancellor
On Mon, Feb 25, 2019 at 09:46:56AM -0800, Nick Desaulniers wrote: > On Mon, Feb 25, 2019 at 9:35 AM Nathan Chancellor > wrote: > > > > On Mon, Feb 25, 2019 at 03:47:19PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Feb 25, 2019 at 03:45:13PM +0100, Greg Kroah-Hartman

[PATCH] powerpc/xmon: Fix opcode being uninitialized in print_insn_powerpc

2019-02-25 Thread Nathan Chancellor
c/xmon: Enable disassembly files (compilation changes)") Link: https://github.com/ClangBuiltLinux/linux/issues/390 Signed-off-by: Nathan Chancellor --- arch/powerpc/xmon/ppc-dis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/xmon/ppc-dis.c b/arch/powerpc/xmon

<    1   2   3   4   5   6   7   8   9   10   >