;
Signed-off-by: Nadim Almas
Acked-by: Julia Lawall
---
Makefile| 2 +-
drivers/staging/octeon-usb/octeon-hcd.c | 16
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index 4fb6bea..3d9d77a6 100644
--- a/Makefile
From: Nadim Almas
Fixed a coding style issue.
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 95ec729..8c0432a 100644
--- a
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df..271395b
:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret
Signed-off-by: Nadim Almas
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
b/drivers/staging/comedi/drivers
=
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df..271395b 100644
--- a
From: sarique
fixed a coding style issue.
Signed-off-by: Nadim almas
---
drivers/staging/android/ion/ion.c| 3 ++-
drivers/staging/comedi/drivers/ssv_dnp.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging
CTIONAL
+ DMA_BIDIRCTIONAL
|
- PCI_DMA_TODEVICE
+ DMA_TO_DEVICE
|
- PCI_DMA_FROMDEVICE
+ DMA_FROM_DEVICE
|
- PCI_DMA_NONE
+ DMA_NONE_DEVICE
)
)
Signed-off-by: Nadim Almas
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 ++
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 12 ++--
fixed trailing */ Block comments and 80 character line limit coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/greybus/arche-apb-ctrl.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging
>Someone else already sent this same patch in before you, sorry
But sir how can i come to know that Someone else already sent
particular patch before sending that particular patch
On Wed, Oct 12, 2016 at 6:55 PM, Greg KH wrote:
> On Tue, Oct 11, 2016 at 12:49:54PM -0700, Nadim Almas
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/ks7010/eap_packet.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/eap_packet.h
b/drivers/staging/ks7010/eap_packet.h
index df7f760..90432ff 100644
--- a/drivers/staging
Fixed coding style issue
Signed-off-by: Nadim Almas
---
Changes in v2:
-Comment is taken from below line.
drivers/staging/ks7010/eap_packet.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/eap_packet.h
b/drivers/staging/ks7010
fixed trailing */ Block comments and 80 character line limit coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/ks7010/ks7010_sdio.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_neo.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
index abddd48..65994e3 100644
--- a/drivers/staging
May be it is not looking better than yours but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend
On Thu, Oct 6, 2016 at 10:51 AM, Greg KH wrote:
> On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wr
May be it is not looking better than it did before but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend
than why it is not acceptable
On Thu, Oct 6, 2016 at 1:52 PM, Nadim Almas wrote:
> May be it i
style issue
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/fbtft/fb_s6d02a1.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fbtft/fb_s6d02a1.c
b/drivers/staging/fbtft/fb_s6d02a1.c
index 774b0ff
wrote:
> On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote:
>> style issue
>>
>> Fixed coding style issue
>
> This does not seem like valid sentances that mean much to me. Do they
> to you?
>
>>
>> Signed-off-by: Nad
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/greybus/arche-apb-ctrl.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging/greybus/arche-apb-ctrl.c
index 70323aa..eeba912 100644
Fixed coding style issue
Signed-off-by: Nadim Almas
---
Changes in v2:
- Used space after leading * in block comments.
drivers/staging/greybus/arche-apb-ctrl.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/wlan-ng/hfa384x.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
index 6337b1d..cca2652 100644
--- a/drivers/staging/wlan
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 0c5dea7..6e6540f 100644
--- a
Block comments should align the * on each line as reported by checkpatch.pl
Signed-off-by: Nadim Almas
---
drivers/staging/vt6656/main_usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index
implicit declaration of function ‘of_find_all_nodes’ reported by sparse
Signed-off-by: Nadim Almas
---
drivers/staging/board/board.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
index 86dc411..6978db5 100644
--- a/drivers
Removing struct sk_buff *skb from capi.c
The Coccinelle semantic patch used to make this change is as follows:
@@
type T;
identifier D;
@@
- T D;
...when != D
Signed-off-by: Nadim Almas
---
drivers/staging/i4l/act2000/capi.c | 13 -
1 file changed, 13 deletions(-)
diff --git a
;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/emxx_udc/emxx_udc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index abe2aaf..31f4206 100644
--- a
.+>
}
@rem depends on prb@
identifier platform.removefn;
expression prb.e;
@@
removefn(...) {
<...
- kzfree(e);
...>
}
//
Signed-off-by: Nadim Almas
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dr
.+>
}
@rem depends on prb@
identifier platform.removefn;
expression prb.e;
@@
removefn(...) {
<...
- kfree(e);
...>
}
//
Signed-off-by: Nadim Almas
---
drivers/crypto/mv_cesa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_c
Block comments should align the * on each line as reported by checkpatch.pl
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index cf8aefd
ERROR: Use 4 digit octal (0777) not decimal permissions
This error was detected by checkpatch.pl
Signed-off-by: Nadim Almas
---
drivers/staging/fbtft/fb_ili9325.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ili9325.c
b/drivers
Block comments should align the * on each line as reported by checkpatch.pl
Signed-off-by: Nadim Almas
---
Changes in v2:
- Made subject better
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b
en != g(...);
}
@rem depends on prb@
identifier platform.removefn;
expression prb.e;
@@
removefn(...) {
<...
- kfree(e);
...>
}
//
Signed-off-by: Nadim Almas
---
drivers/mfd/t7l66xb.c | 4 +---
drivers/mfd/tc6387xb.c | 4 +---
drivers/mfd/tc6393xb.c | 4 +---
3 files changed, 3 ins
en != g(...);
}
@rem depends on prb@
identifier platform.removefn;
expression prb.e;
@@
removefn(...) {
<...
- kfree(e);
...>
}
//
Signed-off-by: Nadim Almas
---
drivers/mfd/t7l66xb.c | 4 +---
drivers/mfd/tc6387xb.c | 4 +---
drivers/mfd/tc6393xb.c | 4 +---
3 files changed, 3 ins
=
+return
e;
-return ret;
Signed-off-by: Nadim Almas
---
drivers/staging/android/ion/ion.c | 8 +++-
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 52345df..271395b 100644
--- a
-off-by: Nadim Almas
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1f9c08a..d30cf3d 100644
--- a/drivers/staging/comedi
Fixed coding style issue.
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_neo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e794056..bc15584 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
Fixed coding style issue
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_neo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 0974986..f07f69c 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
sir i am new in linux kernel hacking so I just want to start with
something very simple ,so for sake of simplicity and learning I fixed
only one of these warning
So my first patch is correct?
On Sun, Oct 2, 2016 at 9:39 PM, Greg KH wrote:
> On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
>> sir i am new in linux kernel hacking so I just want to start with
>> something very simple ,so for sake of simplicity and learning I fi
42 matches
Mail list logo
