[PATCH net-next] netcp driver fixes to build as dynamic modules

2015-01-29 Thread Murali Karicheri
for netcp :- [1] https://lkml.org/lkml/2015/1/28/1102 [2] https://lkml.org/lkml/2015/1/29/881 [3] https://lkml.org/lkml/2015/1/29/882 Murali Karicheri (1): drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone drivers/net/ethernet/ti/Kconfig | 19

[PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-29 Thread Murali Karicheri
calls provided by netcp_core so that both the above can be dynamic modules. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/Kconfig | 19 +-- drivers/net/ethernet/ti/Makefile |8 +--- drivers/net/ethernet/ti/cpsw_ale.c| 26

Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support

2015-01-29 Thread Murali Karicheri
On 01/29/2015 05:00 PM, Arnd Bergmann wrote: On Thursday 29 January 2015 12:21:36 Murali Karicheri wrote: I think the solution is to make the cpsw_ale as a module and configured through a Kconfig option. I am working on a fix for this now. Similar fix is required for cpts.o. Currently we are

Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-30 Thread Murali Karicheri
: On Wednesday 28 January 2015 12:29:42 Will Deacon wrote: On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote: On Wednesday 28 January 2015 11:33:00 Will Deacon wrote: On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote: On 01/25/2015 08:32 AM, Laurent Pinchart wrote

Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-30 Thread Murali Karicheri
On 01/30/2015 04:56 AM, Mugunthan V N wrote: On Friday 30 January 2015 01:48 PM, Mugunthan V N wrote: On Friday 30 January 2015 04:45 AM, Murali Karicheri wrote: NetCP on Keystone has cpsw ale function similar to other TI SoCs and this driver is re-used. To allow both ti cpsw and keystone

[PATCH net-next v1] netcp driver fixes to build as dynamic modules

2015-01-30 Thread Murali Karicheri
Tested-by: Mugunthan V N Murali Karicheri (1): drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone drivers/net/ethernet/ti/Kconfig | 19 +-- drivers/net/ethernet/ti/Makefile |8 +--- drivers/net/ethernet/ti/cpsw_ale.c

[PATCH net-next v1] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-30 Thread Murali Karicheri
calls provided by netcp_core so that both the above can be dynamic modules. Acked-by: Arnd Bergmann Acked-by: Lad, Prabhakar Acked-by: Mugunthan V N Tested-by: Mugunthan V N Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/Kconfig | 19 +-- drivers/net

Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-30 Thread Murali Karicheri
On 01/29/2015 06:47 PM, Arnd Bergmann wrote: On Thursday 29 January 2015 18:15:51 Murali Karicheri wrote: NetCP on Keystone has cpsw ale function similar to other TI SoCs and this driver is re-used. To allow both ti cpsw and keystone netcp to re-use the driver, convert the cpsw ale to a module

Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-30 Thread Murali Karicheri
On 01/30/2015 03:03 AM, Lad, Prabhakar wrote: On Thu, Jan 29, 2015 at 11:15 PM, Murali Karicheri wrote: NetCP on Keystone has cpsw ale function similar to other TI SoCs and this driver is re-used. To allow both ti cpsw and keystone netcp to re-use the driver, convert the cpsw ale to a module

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-30 Thread Murali Karicheri
On 01/28/2015 12:30 PM, Catalin Marinas wrote: On Wed, Jan 28, 2015 at 03:55:57PM +, Robin Murphy wrote: On 28/01/15 11:05, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote: How about having the logic like this? ret = of_dma_get_range(np

[RFC PATCH 2/2] PCI: get device dma configuration from parent

2014-12-17 Thread Murali Karicheri
device's device structure in order for getting the dma_mask right for the device. Signed-off-by: Murali Karicheri --- drivers/pci/probe.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index c8ca98c..8f4d55b 1

[RFC PATCH 0/2] PCI: get DMA configuration from parent device

2014-12-17 Thread Murali Karicheri
have side effects that I am unware of. So sending as a RFC patch to get feedback before sending the formal patch. Please review and provide me the comment so that I can incorporate the same. [1] http://www.gossamer-threads.com/lists/linux/kernel/2024591 Murali Karicheri (2): common: dma-mapping:

[RFC PATCH 1/2] common: dma-mapping: introduce dma_get_parent_cfg() helper

2014-12-17 Thread Murali Karicheri
w DMA configuration is represented in device data structure not only by DMA mask and DMA params, it also includes dma_pfn_offset at least. Hence introduce common dma_get_parent_cfg() helper to apply dma configuration from parent to child, and use __weak to allow arch to override it if needed. Signed-off-by: M

Re: How to fix CHECK warning: testing a 'safe expression' ?

2014-12-17 Thread Murali Karicheri
On 12/17/2014 01:49 PM, Bjorn Helgaas wrote: [+cc Christopher, linux-kernel (this doesn't sound like a PCI-specific question)] On Wed, Dec 17, 2014 at 9:18 AM, Murali Karicheri wrote: I am trying to address CHECK warnings in my driver and wondering how to resolve 'warning: testi

Re: How to fix CHECK warning: testing a 'safe expression' ?

2014-12-17 Thread Murali Karicheri
On 12/17/2014 05:35 PM, Murali Karicheri wrote: On 12/17/2014 01:49 PM, Bjorn Helgaas wrote: [+cc Christopher, linux-kernel (this doesn't sound like a PCI-specific question)] On Wed, Dec 17, 2014 at 9:18 AM, Murali Karicheri wrote: I am trying to address CHECK warnings in my drive

Re: [RFC PATCH 1/2] common: dma-mapping: introduce dma_get_parent_cfg() helper

2014-12-17 Thread Murali Karicheri
On 12/17/2014 04:56 PM, Arnd Bergmann wrote: On Wednesday 17 December 2014 13:02:23 Murali Karicheri wrote: Now, in Kernel, parent device's DMA parameters has to be applied to the child as is - to enable DMA support for the device. Usually this is happened in places where parent device man

Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support

2015-01-20 Thread Murali Karicheri
On 01/19/2015 03:11 PM, David Miller wrote: From: Murali Karicheri Date: Thu, 15 Jan 2015 19:10:03 -0500 The Network Coprocessor (NetCP) is a hardware accelerator that processes Ethernet packets. NetCP has a gigabit Ethernet (GbE) subsystem with a ethernet switch sub-module to send and receive

Re: [PATCH net-next v8 2/4] net: netcp: Add Keystone NetCP core ethernet driver

2015-01-20 Thread Murali Karicheri
On 01/20/2015 03:18 AM, Paul Bolle wrote: Murali, Wingman, On Thu, 2015-01-15 at 19:12 -0500, Murali Karicheri wrote: The network coprocessor (NetCP) is a hardware accelerator available in Keystone SoCs that processes Ethernet packets. NetCP consists of following hardware components 1

Re: [PATCH net-next v8 2/4] net: netcp: Add Keystone NetCP core ethernet driver

2015-01-20 Thread Murali Karicheri
On 01/20/2015 03:18 AM, Paul Bolle wrote: Murali, Wingman, On Thu, 2015-01-15 at 19:12 -0500, Murali Karicheri wrote: The network coprocessor (NetCP) is a hardware accelerator available in Keystone SoCs that processes Ethernet packets. NetCP consists of following hardware components 1

[net-next] net: netcp: remove unused kconfig option and code

2015-01-20 Thread Murali Karicheri
Currently CPTS is built into the netcp driver even though there is no call out to the CPTS driver. This patch removes the dependency in Kconfig and remove cpts.o from the Makefile for NetCP. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/Kconfig |2 +- drivers/net/ethernet/ti

Re: [PATCH net-next v8 2/4] net: netcp: Add Keystone NetCP core ethernet driver

2015-01-20 Thread Murali Karicheri
On 01/20/2015 12:26 PM, Paul Bolle wrote: On Tue, 2015-01-20 at 12:10 -0500, Murali Karicheri wrote: On 01/20/2015 03:18 AM, Paul Bolle wrote: On Thu, 2015-01-15 at 19:12 -0500, Murali Karicheri wrote: diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index

[RESEND: PATCH net-next] net: netcp: remove unused kconfig option and code

2015-01-20 Thread Murali Karicheri
Currently CPTS is built into the netcp driver even though there is no call out to the CPTS driver. This patch removes the dependency in Kconfig and remove cpts.o from the Makefile for NetCP. Signed-off-by: Murali Karicheri --- - Resend with PATCH prefix. drivers/net/ethernet/ti/Kconfig |2

Re: [PATCH v1] of: calculate masks of the device based on dma-range size

2015-02-27 Thread Murali Karicheri
On 02/25/2015 07:20 PM, Bjorn Helgaas wrote: [+cc Catalin] On Wed, Feb 11, 2015 at 12:53:35PM -0500, Murali Karicheri wrote: This patch update of_dma_configure() API to calculate the masks (dma_mask and coherent_dma_mask) based on the dma-range values set in DT for the device. Also limit the

Re: [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default

2015-02-27 Thread Murali Karicheri
On 02/27/2015 11:29 AM, Tony Lindgren wrote: * Murali Karicheri [150224 13:31]: Keystone netcp driver re-uses davinci mdio driver. So enable it by default for keystone netcp driver. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/Kconfig |1 + 1 file changed, 1 insertion

Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver

2014-12-11 Thread Murali Karicheri
On 12/10/2014 08:41 PM, David Miller wrote: From: Murali Karicheri Date: Wed, 10 Dec 2014 16:31:02 -0500 Are you referring to the static code analyser sparse that is invoked through? You have to explicitly enable endian checking, it's not on by default. Thanks David and others who resp

Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver

2014-12-11 Thread Murali Karicheri
On 12/11/2014 12:01 PM, David Miller wrote: From: Murali Karicheri Date: Thu, 11 Dec 2014 09:14:37 -0500 BTW, could you provide any suggestions that would help us merge this series to upstream? This has been sitting on this list for a while now. You simply have to continue going through the

Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver

2014-12-11 Thread Murali Karicheri
On 12/11/2014 01:34 PM, Joe Perches wrote: On Thu, 2014-12-11 at 12:17 -0500, Murali Karicheri wrote: On 12/11/2014 12:01 PM, David Miller wrote: From: Murali Karicheri Date: Thu, 11 Dec 2014 09:14:37 -0500 BTW, could you provide any suggestions that would help us merge this series to

Re: [PATCH next v2 1/2] PCI: keystone: add pci error irq handler

2016-04-20 Thread Murali Karicheri
On 04/19/2016 09:03 PM, Bjorn Helgaas wrote: > Hi Murali, > > On Mon, Apr 11, 2016 at 10:50:30AM -0400, Murali Karicheri wrote: >> Keystone PCI hardware generates error interrupts at RC using platform >> irq instead of standard msi/legacy irq. Add a simple error handler t

Re: [PATCH next v2 2/2] PCI: keystone: remove unnecessary goto statement

2016-04-20 Thread Murali Karicheri
On 04/19/2016 09:06 PM, Bjorn Helgaas wrote: > Hi Murali, > > On Mon, Apr 11, 2016 at 10:50:31AM -0400, Murali Karicheri wrote: >> Fix the misuse of goto statement in ks_pcie_get_irq_controller_info() >> as simple return is more appropriate for this function. While at >&

Export clocks_calc_mult_shift() function

2016-03-08 Thread Murali Karicheri
driver as well. Can you merge the patch please. Or do you suggest me to repost the same? http://lkml.iu.edu/hypermail/linux/kernel/1502.2/01641.html Thanks -- Murali Karicheri Linux Kernel, Keystone

Re: [PATCH 0/5] Modularize PCI_DW related drivers.

2016-03-15 Thread Murali Karicheri
s here. The patch looks right to me, but the problem > looks unchanged. > > Arnd > Was there any progress since this last response from Arnd? or is it a TBD? -- Murali Karicheri Linux Kernel, Keystone

Re: [PATCH next 1/2] PCI: keystone: add pci error irq handler

2016-04-06 Thread Murali Karicheri
On 03/22/2016 06:23 PM, kbuild test robot wrote: > Hi Murali, > > [auto build test ERROR on next-20160322] > > url: > https://github.com/0day-ci/linux/commits/Murali-Karicheri/PCI-keystone-add-pci-error-irq-handler/20160323-035516 > config: arm-multi_v7_defconfig

Re: Export clocks_calc_mult_shift() function

2016-03-30 Thread Murali Karicheri
On 03/14/2016 11:27 AM, Murali Karicheri wrote: > On 03/08/2016 05:25 PM, Murali Karicheri wrote: >> Hi, >> >> I found a patch posted sometime back to export the clocksource >> function clocks_calc_mult_shift() so that it can be called by >> drivers that are dyna

Re: Export clocks_calc_mult_shift() function

2016-03-31 Thread Murali Karicheri
On 03/30/2016 01:02 PM, John Stultz wrote: > On Wed, Mar 30, 2016 at 10:01 AM, John Stultz wrote: >> On Wed, Mar 30, 2016 at 9:46 AM, Murali Karicheri >> wrote: >>> I didn't see any response? Can I send a patch to export >>> clocks_calc_mult_shift()

Re: [PATCH next 1/2] PCI: keystone: add pci error irq handler

2016-03-31 Thread Murali Karicheri
On 03/22/2016 03:52 PM, Murali Karicheri wrote: > Keystone PCI hardware generates error interrupts at RC using platform > irq instead of standard msi/legacy irq. Add a simple error handler that > logs the fatal interrupt status to the console. > > Signed-off-by: Murali Karic

[PATCH next v2 1/2] PCI: keystone: add pci error irq handler

2016-04-11 Thread Murali Karicheri
Keystone PCI hardware generates error interrupts at RC using platform irq instead of standard msi/legacy irq. Add a simple error handler that logs the fatal interrupt status to the console. Signed-off-by: Murali Karicheri Acked-by: Rob Herring Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland

[PATCH next v2 2/2] PCI: keystone: remove unnecessary goto statement

2016-04-11 Thread Murali Karicheri
Fix the misuse of goto statement in ks_pcie_get_irq_controller_info() as simple return is more appropriate for this function. While at it add an error log for absence of interrupt controller node. Signed-off-by: Murali Karicheri Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell

[PATCH] ARM: dts: keystone: k2l: fix kernel crash when clk_ignore_unused is not in bootargs

2015-11-23 Thread Murali Karicheri
39936 0 0 -cut Signed-off-by: Murali Karicheri --- Applies to Linux 4.4-rc2 Documentation/arm/keystone/Overview.txt | 18 -- arch/arm/boot/dts/k2l-netcp.dtsi| 2 +- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a

[PATCH] ARM: keystone: allow FORCE_MAX_ZONEORDER to be configurable on Keystone

2015-07-01 Thread Murali Karicheri
Currently for Keystone devices, user can't change the value of CONFIG_FORCE_MAX_ZONEORDER option in defconfig. Users require capability to tune the value of this option on a target board. So this patch adds this capability Signed-off-by: Murali Karicheri --- arch/arm/Kconfig | 2 +- 1

Re: [PATCH] ARM: keystone: allow FORCE_MAX_ZONEORDER to be configurable on Keystone

2015-07-02 Thread Murali Karicheri
Russell, On 07/01/2015 02:48 PM, Russell King - ARM Linux wrote: On Wed, Jul 01, 2015 at 01:53:02PM -0400, Murali Karicheri wrote: Currently for Keystone devices, user can't change the value of CONFIG_FORCE_MAX_ZONEORDER option in defconfig. Users require capability to tune the value of

Re: [PATCH v1 1/2] soc: ti: display firmware file name as part of boot log

2015-09-15 Thread Murali Karicheri
On 09/09/2015 12:38 PM, Murali Karicheri wrote: On 09/04/2015 11:53 PM, santosh.shilim...@oracle.com wrote: On 9/4/15 5:46 PM, Murali Karicheri wrote: To help the user, print the PDSP file name as part of knav_queue_load_pdsp(). This will be useful for users to know what version of the

[PATCH] linux-firmware: Add qmss accumulator pdsp firmware for keystone SoCs

2015-09-15 Thread Murali Karicheri
managed by the Accumulator PDSP. For more details on hardware, please refer http://www.ti.com/lit/ug/sprugr9h/sprugr9h.pdf and DT documentation below in linux kernel source tree Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt Signed-off-by: Murali Karicheri --- LICENCE.ti

Re: [PATCH v1 1/2] soc: ti: display firmware file name as part of boot log

2015-09-16 Thread Murali Karicheri
On 09/15/2015 05:20 PM, santosh shilimkar wrote: On 9/15/2015 11:14 AM, Murali Karicheri wrote: On 09/09/2015 12:38 PM, Murali Karicheri wrote: On 09/04/2015 11:53 PM, santosh.shilim...@oracle.com wrote: On 9/4/15 5:46 PM, Murali Karicheri wrote: To help the user, print the PDSP file name as

Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags

2015-09-30 Thread Murali Karicheri
hat? Believe it or not, user space tools that are custom to a specific SoC would require such knowledge. So I agree on this front that a SoC specific compatibility is cool to have. I think that should have been clear in the commit description. My Acked-By: Murali Karicheri Why the user space sho

Re: [PATCH] hsr: fix don't prune the master node from the node_db

2019-05-21 Thread Murali Karicheri
Hi Andreas, On 05/21/2019 06:52 AM, Andreas Oetken wrote: Don't prune master node in the hsr_prune_nodes function. Neither time_in[HSR_PT_SLAVE_A], nor time_in[HSR_PT_SLAVE_B], will ever be updated by hsr_register_frame_in for the master port. Thus the master node will be repeatedly pruned leadi

Re: [PATCH] hsr: fix don't prune the master node from the node_db

2019-05-22 Thread Murali Karicheri
== So after fixing the above, you may add below for next revision. Tested-by: Murali Karicheri

[PATCH] net: netcp: Fix ethss driver probe issue

2019-02-18 Thread Murali Karicheri
rt to using %pOFn instead of device_node.name") Signed-off-by: Murali Karicheri --- Failure log: https://pastebin.ubuntu.com/p/cGCFZC4WkC/ With fix: https://pastebin.ubuntu.com/p/G9qYzXXNbw/ drivers/net/ethernet/ti/netcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next PATCH v3 11/11] net: netcp: support probe deferral

2018-04-02 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethern

[net-next PATCH v3 06/11] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-04-02 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ti

[net-next PATCH v3 04/11] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-04-02 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make call to gbe_sgmii_config() conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 6

[net-next PATCH v3 10/11] Revert "net: netcp: remove dead code from the driver"

2018-04-02 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 9 + 1 file

[net-next PATCH v3 02/11] soc: ti: K2G: provide APIs to support driver probe deferral

2018-04-02 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri --- drivers/soc/ti/knav_dma.c| 8 drivers/soc/ti/knav_qmss_queue.c | 8

[net-next PATCH v3 09/11] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-04-02 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v3 01/11] soc: ti: K2G: enhancement to support QMSS in K2G NAVSS

2018-04-02 Thread Murali Karicheri
tors with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok --- .../bindings/soc/ti/keystone-navigator-qmss.txt| 9 ++- drivers/soc

[net-next PATCH v3 08/11] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-04-02 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next PATCH v3 03/11] net: netcp: ethss: use macro for checking ss_version consistently

2018-04-02 Thread Murali Karicheri
similar issue with checking XBE version by re-using existing macro IS_SS_ID_XGBE(). Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b

[net-next PATCH v3 07/11] net: netcp: ethss: map vlan priorities to zero flow

2018-04-02 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net

[net-next PATCH v3 00/11] Add support for netcp driver on K2G SoC

2018-04-02 Thread Murali Karicheri
Andrew Lunn and Grygorii Strashko against v2. v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (11): soc: ti: K2G: enhancement to support QMSS in K2G NAVSS soc: ti: K2G: provide APIs to support driver probe

[net-next PATCH v3 05/11] net: netcp: ethss: add support for handling sgmii link interface

2018-04-02 Thread Murali Karicheri
2u cpsw hardware on K2G uses sgmii link to interface with Phy. So add support for this interface in the code so that drover can be re-used for 2u hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ethernet/ti/netcp_ethss.c | 15

Re: [net-next PATCH v3 00/11] Add support for netcp driver on K2G SoC

2018-04-02 Thread Murali Karicheri
On 04/02/2018 10:40 AM, David Miller wrote: > > The net-next tree is closed, please resubmit this after the merge window and > the net-next tree is open back up again. > Ok. Will do. Thanks -- Murali Karicheri Linux Kernel, Keystone

[net-next 1/2] net: netcp: add api to support set rx mode in netcp modules

2018-04-02 Thread Murali Karicheri
modes supported are PROMISCUOUS and NON_PROMISCUOUS modes. Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/net

[net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
This patch adds support for promiscuous mode in network driver for K2G SoC. This depends on v3 of my series at https://www.spinics.net/lists/kernel/msg2765942.html I plan to fold this to the above series and submit again when the net-next merge windows opens. At this time, please review and let me

[net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
will not flood all unicast packets to host port, while in promiscuous mode, it will pass all received unicast packets to host port. Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 56 +++ 1 file change

Re: [net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
Andrew, Thanks for reviewing this! On 04/02/2018 12:47 PM, Andrew Lunn wrote: > On Mon, Apr 02, 2018 at 12:17:19PM -0400, Murali Karicheri wrote: >> +static int gbe_set_rx_mode(void *intf_priv, bool promisc) >> +{ >> +struct gbe_intf *gbe_intf = intf_priv; >> +

Re: [net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
On 04/02/2018 12:28 PM, David Miller wrote: > From: Murali Karicheri > Date: Mon, 2 Apr 2018 12:17:17 -0400 > >> This patch adds support for promiscuous mode in network driver for K2G >> SoC. This depends on v3 of my series at >> https://www.spinics.net/lists/kernel/m

[net-next PATCH v4 03/13] net: netcp: ethss: use macro for checking ss_version consistently

2018-04-17 Thread Murali Karicheri
similar issue with checking XBE version by re-using existing macro IS_SS_ID_XGBE(). Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b

[net-next PATCH v4 09/13] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-04-17 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v4 05/13] net: netcp: ethss: add support for handling rgmii link interface

2018-04-17 Thread Murali Karicheri
2u cpsw hardware on K2G uses rgmii link to interface with Phy. So add support for this interface in the code so that driver can be re-used for 2u hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ethernet/ti/netcp_ethss.c | 15

[net-next PATCH v4 13/13] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-17 Thread Murali Karicheri
will not flood all unicast packets to host port, while in promiscuous mode, it will pass all received unicast packets to host port. Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 56 +++ 1 file change

[net-next PATCH v4 06/13] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-04-17 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ti

[net-next PATCH v4 12/13] net: netcp: add api to support set rx mode in netcp modules

2018-04-17 Thread Murali Karicheri
modes supported are PROMISCUOUS and NON_PROMISCUOUS modes. Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/net

[net-next PATCH v4 11/13] net: netcp: support probe deferral

2018-04-17 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethern

[net-next PATCH v4 02/13] soc: ti: K2G: provide APIs to support driver probe deferral

2018-04-17 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri --- drivers/soc/ti/knav_dma.c| 8 drivers/soc/ti/knav_qmss_queue.c | 8

[net-next PATCH v4 01/13] soc: ti: K2G: enhancement to support QMSS in K2G NAVSS

2018-04-17 Thread Murali Karicheri
tors with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok Reviewed-by: Rob Herring --- .../bindings/soc/ti/keystone-navigator-qmss.txt| 9 +

[net-next PATCH v4 08/13] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-04-17 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next PATCH v4 10/13] Revert "net: netcp: remove dead code from the driver"

2018-04-17 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 9 + 1 file

[net-next PATCH v4 04/13] net: netcp: ethss: make sgmii configuration conditional

2018-04-17 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make sgmii configuration conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 18

[net-next PATCH v4 00/13] Add support for netcp driver on K2G SoC

2018-04-17 Thread Murali Karicheri
Addressed comments from Andrew Lunn and Grygorii Strashko against v2. v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (11): soc: ti: K2G: enhancement to support QMSS in K2G NAVSS soc: ti: K2G: provide APIs

[net-next PATCH v4 07/13] net: netcp: ethss: map vlan priorities to zero flow

2018-04-17 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net

[PATCH] PCI: designware: fix asynchronous external abort in keystone PCIe h/w

2017-01-04 Thread Murali Karicheri
24/0x380 [0.823083] LR is at ks_pcie_host_init+0x10/0x170 Fixes: 416379f9ebde ("PCI: designware: Check for iATU unroll support after initializing host") Signed-off-by: Murali Karicheri Tested-by: Kishon Vijay Abraham I --- - Applies to pci/master - Bug was introduced in v4.9 - Test

Re: [PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

2017-01-05 Thread Murali Karicheri
On 12/20/2016 08:01 PM, Santosh Shilimkar wrote: > On 12/20/2016 2:24 PM, Murali Karicheri wrote: >> This patch fixes some typos in the trace message >> >> Signed-off-by: Murali Karicheri >> Signed-off-by: Sekhar Nori >> --- > Patch 1 and 2 looks fine. Wi

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
Rob, On 12/22/2016 04:24 PM, Rob Herring wrote: > On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >> From: WingMan Kwok >> >> 10gbe phy driver needs to access the 10gbe subsystem control >> register during phy initialization. To facilitate the shared

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
On 01/05/2017 03:42 PM, Murali Karicheri wrote: > Rob, > > On 12/22/2016 04:24 PM, Rob Herring wrote: >> On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >>> From: WingMan Kwok >>> >>> 10gbe phy driver needs to access the 10gbe

[net-next v1 1/8] net: netcp: extract eflag from desc for rx_hook handling

2017-01-06 Thread Murali Karicheri
processing. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 20 +--- include/linux/soc/ti/knav_dma.h | 2 ++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ti

[net-next v1 2/8] net: netcp: remove the redundant memmov()

2017-01-06 Thread Murali Karicheri
The psdata is populated with command data by netcp modules to the tail of the buffer and set_words() copy the same to the front of the psdata. So remove the redundant memmov function call. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 6 +++--- 1 file changed, 3

[net-next v1 7/8] net: netcp: ale: use ale_status to size the ale table

2017-01-06 Thread Murali Karicheri
to 2048 per User guide http://www.ti.com/lit/ug/spruhj5/spruhj5.pdf Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/cpsw_ale.c| 31 ++- drivers/net/ethernet/ti/netcp_ethss.c | 4 +--- 2 files changed, 31 insertions(+), 4

[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

2017-01-06 Thread Murali Karicheri
Currently to parse phy-handle, driver doesn't check if the interface is MAC to PHY. This patch add this check for all MAC to PHY interface types supported by the driver. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/netcp_ethss.c | 4 +++- 1

[net-next v1 8/8] net: netcp: ale: add proper ale entry mask bits for netcp switch ALE

2017-01-06 Thread Murali Karicheri
the macros. The parameter nu_switch_ale is configured by the caller driver to indicate the ALE is for that switch and is used in the ALE driver to do customization as needed. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/cpsw_ale.c | 99

[net-next v1 0/8] netcp: enhancements and minor fixes

2017-01-06 Thread Murali Karicheri
in 64 bits Murali Karicheri (7): net: netcp: extract eflag from desc for rx_hook handling net: netcp: remove the redundant memmov() net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY net: netcp: use hw capability to remove FCS word from rx packets net: netcp: ale

[net-next v1 6/8] net: netcp: ale: update to support unknown vlan controls for NU switch

2017-01-06 Thread Murali Karicheri
just 3 port. The version mask is 3 bits in NU Switch ALE vs 8 bits on other ALE types. While at it, change the debug print to info print so that ALE version gets displayed in boot log. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/cpsw_ale.c| 50

[net-next v1 5/8] net: netcp: use hw capability to remove FCS word from rx packets

2017-01-06 Thread Murali Karicheri
Some of the newer Ethernet switch hw (such as that on k2e/l/g) can strip the Etherenet FCS from packet at the port 0 egress of the switch. So use this capability instead of doing it in software. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/netcp.h

[net-next v1 3/8] net: netcp: store network statistics in 64 bits

2017-01-06 Thread Murali Karicheri
From: Michael Scherban Previously the network statistics were stored in 32 bit variable which can cause some stats to roll over after several minutes of high traffic. This implements 64 bit storage so larger numbers can be stored. Signed-off-by: Michael Scherban Signed-off-by: Murali Karicheri

[PATCH] net: phy: dp83867: allow RGMII_TXID/RGMII_RXID interface types

2017-01-13 Thread Murali Karicheri
bindings. Also update the DT document accordingly. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori --- - I had sent this earlier and some how it didn't get through and I haven't seen any comment for this. So sending this again. - Applies to master. Documentation/devicetree/bi

Re: [PATCH] PCI: designware: fix asynchronous external abort in keystone PCIe h/w

2017-01-09 Thread Murali Karicheri
On 01/04/2017 02:32 PM, Murali Karicheri wrote: > Recent fixes for iATU unroll support introduced a bug that causes > asynchronous external abort in Keystone PCIe h/w which doesn't have > ATU port and the corresponding register. So the check should be moved > below where dw_pcie_

Re: [PATCH] PCI: designware: fix asynchronous external abort in keystone PCIe h/w

2017-01-10 Thread Murali Karicheri
On 01/10/2017 10:12 AM, Bjorn Helgaas wrote: > Hi Murali, > > On Wed, Jan 04, 2017 at 02:32:30PM -0500, Murali Karicheri wrote: >> Recent fixes for iATU unroll support introduced a bug that causes >> asynchronous external abort in Keystone PCIe h/w which doesn'

Re: [PATCH 06/14] PCI: keystone: make it explicitly non-modular

2016-07-06 Thread Murali Karicheri
ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Murali Ka

[PATCH 2/2] ARM: dts: keystone: add interrupt property to PCI controller bindings

2016-06-02 Thread Murali Karicheri
Now that Keystone PCIe controller supports error interrupt handling add interrupt property to PCI controller DT bindings to enable error interrupt handling. Signed-off-by: Murali Karicheri --- - applies to master v4.7-rcx at kernel.org git repo arch/arm/boot/dts/keystone-k2e.dtsi | 2 ++ arch

[PATCH 1/2] ARM: dts: keystone: fix to PCI bindings

2016-06-02 Thread Murali Karicheri
remove it from the dts. While at it also add a bus-range value that eliminates following log at boot up. [0.420659] No bus range found for /soc/pcie@2102, using [bus 00-ff] Signed-off-by: Murali Karicheri --- - applies to master v4.7-rcx at kernel.org git repo arch/arm/boot/dts/keystone-k2e.dtsi

[PATCH v1 2/2] ARM: dts: keystone: add interrupt property to PCI controller bindings

2016-06-02 Thread Murali Karicheri
Now that Keystone PCIe controller supports error interrupt handling add interrupt property to PCI controller DT bindings to enable error interrupt handling. Signed-off-by: Murali Karicheri --- - v1 - no change from initial version - applies to master v4.7-rcx at kernel.org git repo arch/arm

[PATCH v1 1/2] ARM: dts: keystone: remove bogus IO resource entry from PCI binding

2016-06-02 Thread Murali Karicheri
remove it from the dts. While at it also add a bus-range value that eliminates following log at boot up. [0.420659] No bus range found for /soc/pcie@2102, using [bus 00-ff] Signed-off-by: Murali Karicheri --- v1 - fixed subject to something more meaningful applies to master v4.7-rcx at

<    2   3   4   5   6   7   8   9   >