Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-28 Thread Murali Karicheri
Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote: On 01/25/2015 08:32 AM, Laurent Pinchart wrote: On Friday 23 January 2015 17:32:34 Murali Karicheri wrote: Function of_iommu_configure() is called from of_dma_configure() to setup iommu ops using DT property. This API is currently

Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support

2015-01-28 Thread Murali Karicheri
On 01/28/2015 01:20 PM, Murali Karicheri wrote: On 01/28/2015 12:43 PM, Murali Karicheri wrote: On 01/28/2015 11:49 AM, Murali Karicheri wrote: On 01/27/2015 05:28 PM, Arnd Bergmann wrote: On Tuesday 20 January 2015 10:53:36 Murali Karicheri wrote: On 01/19/2015 03:11 PM, David Miller wrote

Re: [PATCH v5 3/8] of: fix size when dma-range is not used

2015-01-28 Thread Murali Karicheri
On 01/28/2015 06:21 AM, Robin Murphy wrote: Hi Murali, [sorry, missed replying to yesterday's version] On 27/01/15 21:00, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mas

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-28 Thread Murali Karicheri
On 01/28/2015 10:45 AM, Rob Herring wrote: On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote: On 01/27/2015 06:27 AM, Robin Murphy wrote: On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT

Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support

2015-01-28 Thread Murali Karicheri
On 01/27/2015 05:28 PM, Arnd Bergmann wrote: On Tuesday 20 January 2015 10:53:36 Murali Karicheri wrote: On 01/19/2015 03:11 PM, David Miller wrote: From: Murali Karicheri Date: Thu, 15 Jan 2015 19:10:03 -0500 The Network Coprocessor (NetCP) is a hardware accelerator that processes Ethernet

Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support

2015-01-28 Thread Murali Karicheri
+ Felipe, Mugunthan for commenting on TI_CPSW, ALE. On 01/28/2015 04:03 PM, Arnd Bergmann wrote: On Wednesday 28 January 2015 15:43:57 Murali Karicheri wrote: this. Hope I am on the right track. Reproduced this. Following errors seen when building the modules. LD [M] drivers/net

[PATCH net-next 0/5] NetCP: Add support for version 1.5

2015-03-20 Thread Murali Karicheri
tland CC: Pawel Moll CC: Rob Herring Murali Karicheri (4): net: netcp: fix forward port number usage for 10G ethss net: netcp: use separate reg region for individual ethss modules net: netcp: select davinci_mdio driver by default net: netcp: enclose macros in parentheses WingMan

[PATCH net-next 5/5] net: netcp: ethss: enhancement to support NetCP 1.5 ethss

2015-03-20 Thread Murali Karicheri
reading on the details of this peripheral, please refer to the User Guide available at http://www.ti.com/lit/pdf/spruhz3 Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok CC: "David S. Miller" CC: Mugunthan V N CC: "Lad, Prabhakar" CC: Grygorii Strashko CC: Christop

[PATCH net-next 1/5] net: netcp: fix forward port number usage for 10G ethss

2015-03-20 Thread Murali Karicheri
number for forwarding the packet. Add a flag to hold the new flag, SWITCH_TO_PORT_IN_TAGINFO which will be set for 10G. This can also used in the future for other flags for the tx_pipe. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok CC: "David S. Miller" CC: Mugunthan V N

[PATCH net-next 4/5] net: netcp: enclose macros in parentheses

2015-03-20 Thread Murali Karicheri
Fix following checkpatch error. It seems to have passed checkpatch last time when original code was introduced. ERROR: Macros with complex values should be enclosed in parentheses #172: FILE: drivers/net/ethernet/ti/netcp_ethss.c:869: Signed-off-by: Murali Karicheri Signed-off-by: WingMan

[PATCH net-next 3/5] net: netcp: select davinci_mdio driver by default

2015-03-20 Thread Murali Karicheri
Keystone netcp driver re-uses davinci mdio driver. So enable it by default for keystone netcp driver. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok CC: "David S. Miller" CC: Mugunthan V N CC: "Lad, Prabhakar" CC: Grygorii Strashko CC: Christoph Jaeger

[PATCH net-next 2/5] net: netcp: use separate reg region for individual ethss modules

2015-03-20 Thread Murali Karicheri
modules it manages. Use range property to define register space of NetCP and use reg property to define individual reg spaces. So MDIO will have its own reg space to map. This is a pre-requisite to enable MDIO driver for NetCP. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok CC: "Da

Re: [PATCH v1] of/pci : fix of_pci_dma_configure parent ptr NULL

2015-03-20 Thread Murali Karicheri
On 03/19/2015 11:01 AM, Bjorn Helgaas wrote: On Wed, Mar 11, 2015 at 12:40:03PM -0400, Murali Karicheri wrote: On some platforms such as that based on x86, ia64 etc, root bus is created with parent node passed in as NULL to pci_create_root_bus(). On these platforms, the patch series "PCI

[PATCH] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-23 Thread Murali Karicheri
Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c |8

[PATCH 1/4] ARM: keystone: defconfig: enable netcp driver by default

2015-04-23 Thread Murali Karicheri
Enable netcp driver in defconfig for keystone SoCs. Signed-off-by: Murali Karicheri --- arch/arm/configs/keystone_defconfig |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig index f8a1c8f..95ce128 100644 --- a

[PATCH 4/4] ARM: dts: k2l-evm: Add device bindings for netcp driver

2015-04-23 Thread Murali Karicheri
This patch enables networking on k2l evm by providing device bindings for netcp, knav, and qmss. See device binding documentation at Documentation/devicetree/bindings/net/keystone-netcp.txt Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- arch/arm/boot/dts/k2l-evm.dts|1

[PATCH 2/4] ARM: dts: k2hk-evm: Add device bindings for netcp driver

2015-04-23 Thread Murali Karicheri
This patch enables networking on k2hk evm by adding device bindings for netcp, knav and qmss. See device binding documentation below for details. Documentation/devicetree/bindings/net/keystone-netcp.txt Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- arch/arm/boot/dts/k2hk

[PATCH 0/4] ARM: keystone: Enable Netcp driver on K2 EVMs

2015-04-23 Thread Murali Karicheri
NetCP driver support patches are already merged to v4.0.nd v4.1. This series introduce patches to update the DTS bindings and defconfig so that the network driver is fully functional on K2 EVMs :- K2HK, K2L and K2E. It will be great if this can be merged to v4.1. Murali Karicheri (4): ARM

[PATCH 3/4] ARM: dts: k2e-evm: Add device bindings for netcp driver

2015-04-23 Thread Murali Karicheri
This patch enables networking on k2e evm by adding device bindings for netcp, knav and qmss. See device binding documentation below for details. Documentation/devicetree/bindings/net/keystone-netcp.txt Signed-off-by: WingMan Kwok Signed-off-by: Murali Karicheri --- arch/arm/boot/dts/k2e

Re: [PATCH 0/4] ARM: keystone: Enable Netcp driver on K2 EVMs

2015-04-24 Thread Murali Karicheri
On 04/23/2015 04:43 PM, santosh shilimkar wrote: On 4/23/2015 12:37 PM, Murali Karicheri wrote: NetCP driver support patches are already merged to v4.0.nd v4.1. This series introduce patches to update the DTS bindings and defconfig so that the network driver is fully functional on K2 EVMs

Re: [PATCH] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-24 Thread Murali Karicheri
On 04/24/2015 09:33 AM, Sergei Shtylyov wrote: Hello. On 4/23/2015 10:17 PM, Murali Karicheri wrote: Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other

[PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-24 Thread Murali Karicheri
Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri --- - Fixed comment against initial version - Ok to apply

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/27/2015 01:23 PM, David Miller wrote: From: Murali Karicheri Date: Mon, 27 Apr 2015 13:07:35 -0400 On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called

[PATCH v2] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri --- - v2: re-send to apply this on v4.1 - Fixed comment

Re: [PATCH 1/2] clk: keystone: add support for post divider register for main pll

2015-06-15 Thread Murali Karicheri
On 05/29/2015 12:04 PM, Murali Karicheri wrote: Main PLL controller has post divider bits in a separate register in pll controller. Use the value from this register instead of fixed divider when available. Signed-off-by: Murali Karicheri --- .../devicetree/bindings/clock/keystone-pll.txt

Re: [PATCH 1/2] clk: keystone: add support for post divider register for main pll

2015-06-22 Thread Murali Karicheri
On 06/18/2015 06:55 PM, santosh shilimkar wrote: On 6/18/2015 3:37 PM, Michael Turquette wrote: Quoting Murali Karicheri (2015-05-29 09:04:12) Main PLL controller has post divider bits in a separate register in pll controller. Use the value from this register instead of fixed divider when

Re: [PATCH] ARM: keystone: ecc: add ddr3 ecc interrupt handling

2015-06-22 Thread Murali Karicheri
-by: Hao Zhang Signed-off-by: Murali Karicheri Signed-off-by: Vitaly Andrianov --- arch/arm/mach-keystone/Makefile | 2 +- arch/arm/mach-keystone/keystone.c | 63 -- arch/arm/mach-keystone/keystone.h | 1 + arch/arm/mach-keystone/keystone_ecc.c | 85

Re: [PATCH] ARM: keystone: ecc: add ddr3 ecc interrupt handling

2015-06-22 Thread Murali Karicheri
-by: Hao Zhang Signed-off-by: Murali Karicheri Signed-off-by: Vitaly Andrianov --- arch/arm/mach-keystone/Makefile | 2 +- arch/arm/mach-keystone/keystone.c | 63 -- arch/arm/mach-keystone/keystone.h | 1 + arch/arm/mach-keystone/keystone_ecc.c | 85

[PATCH 2/2] ARM: dts: keystone: fix dt bindings to use post div register for mainpll

2015-05-29 Thread Murali Karicheri
bindings for the same. Signed-off-by: Murali Karicheri --- arch/arm/boot/dts/k2e-clocks.dtsi | 5 ++--- arch/arm/boot/dts/k2hk-clocks.dtsi | 5 ++--- arch/arm/boot/dts/k2l-clocks.dtsi | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/k2e-clocks.dtsi b/arch

[PATCH 1/2] clk: keystone: add support for post divider register for main pll

2015-05-29 Thread Murali Karicheri
Main PLL controller has post divider bits in a separate register in pll controller. Use the value from this register instead of fixed divider when available. Signed-off-by: Murali Karicheri --- .../devicetree/bindings/clock/keystone-pll.txt | 8 drivers/clk/keystone/pll.c

Re: [PATCH 0/4] ARM: keystone: Enable Netcp driver on K2 EVMs

2015-05-29 Thread Murali Karicheri
On 05/11/2015 12:00 PM, Russell King - ARM Linux wrote: On Mon, May 11, 2015 at 11:55:41AM -0400, Murali Karicheri wrote: On 04/24/2015 11:36 AM, santosh shilimkar wrote: On 4/24/2015 8:15 AM, Murali Karicheri wrote: On 04/23/2015 04:43 PM, santosh shilimkar wrote: On 4/23/2015 12:37 PM

Re: [PATCH 1/2] clk: keystone: add support for post divider register for main pll

2015-06-09 Thread Murali Karicheri
On 05/29/2015 12:04 PM, Murali Karicheri wrote: Main PLL controller has post divider bits in a separate register in pll controller. Use the value from this register instead of fixed divider when available. Signed-off-by: Murali Karicheri --- .../devicetree/bindings/clock/keystone-pll.txt

[PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1

2015-06-10 Thread Murali Karicheri
SPI hardware spec for Keystone specifies a lower value of 0 for pre-scale divider that is used for generating spi clock which translates to a clock divider of 2. So fix the lower limit to allow using a higher SPI clock. Signed-off-by: Murali Karicheri Acked-by: Sekhar Nori --- drivers/spi/spi

Re: [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1

2015-06-10 Thread Murali Karicheri
On 06/10/2015 03:18 AM, Murali Karicheri wrote: SPI hardware spec for Keystone specifies a lower value of 0 for pre-scale divider that is used for generating spi clock which translates to a clock divider of 2. So fix the lower limit to allow using a higher SPI clock. Signed-off-by: Murali

[PATCH v1] spi: davinci: change the lower limit of pre-scale divider to 1

2015-06-10 Thread Murali Karicheri
() function to 1 so that a maximum of spi device clock rate / 2 is possible to be set for spi-max-frequency. Signed-off-by: Murali Karicheri Acked-by: Sekhar Nori --- - Re-send with updates to commit log and PATCH prefix - Applies to v4.1 drivers/spi/spi-davinci.c | 2 +- 1 file changed, 1

[PATCH] mtd: nand: davinci: add support for 4K page size nand devices.

2015-06-10 Thread Murali Karicheri
K2L EVM uses NAND with 4K page size. This patch add support for ECC layout requires to enable Micron MT29F16G08ADBCAH4 NAND available on this EVM. Signed-off-by: Murali Karicheri Signed-off-by: Hao Zhang --- drivers/mtd/nand/davinci_nand.c | 30 ++ 1 file changed

[PATCH - v1] mtd: nand: davinci: add support for 4K page size nand devices.

2015-06-10 Thread Murali Karicheri
K2L EVM uses NAND with 4K page size. This patch add support for ECC layout requires to enable Micron MT29F16G08ADBCAH4 NAND available on this EVM. Signed-off-by: Murali Karicheri Signed-off-by: Hao Zhang --- - v1 - Remove the comment as well from the code as now 4K page is supported

Re: [linux-next PATCH 0/4] Enable network driver on K2G ICE and GP EVMs

2018-05-22 Thread Murali Karicheri
On 05/20/2018 11:17 PM, santosh.shilim...@oracle.com wrote: > On 5/11/18 12:29 PM, Murali Karicheri wrote: >> Now that NetCP driver patches for K2G SoC is merged to linux-next master >> this series add patches to enable network driver on K2G ICE and GP EVMs. >> >> Thank

[net-next PATCH v2 09/10] Revert "net: netcp: remove dead code from the driver"

2018-03-27 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 9 + 1 file

[net-next PATCH v2 01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-27 Thread Murali Karicheri
te, descriptors with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri Signed-off-by: WingMan Kwok --- .../bindings/soc/ti/keystone-navigator-qmss.txt| 7 ++ drivers/soc

[net-next PATCH v2 04/10] net: netcp: ethss: add support for handling sgmii link interface

2018-03-27 Thread Murali Karicheri
2u cpsw hardware on K2G uses sgmii link to interface with Phy. So add support for this interface in the code so that drover can be re-used for 2u hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ethernet/ti/netcp_ethss.c | 18

[net-next PATCH v2 10/10] net: netcp: support probe deferral

2018-03-27 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethern

[net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-03-27 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make call to gbe_sgmii_config() conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 7

[net-next PATCH v2 06/10] net: netcp: ethss: map vlan priorities to zero flow

2018-03-27 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net

[net-next PATCH v2 02/10] soc: ti: K2G: provide APIs to support driver probe deferral

2018-03-27 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri --- drivers/soc/ti/knav_dma.c| 8 drivers/soc/ti/knav_qmss_queue.c | 8

[net-next PATCH v2 07/10] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-03-27 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-27 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c

[net-next PATCH v2 00/10] Add support for netcp driver on K2G SoC

2018-03-27 Thread Murali Karicheri
https://pastebin.ubuntu.com/p/6Vh55DW8vT/ This series applies to net-next master branch. Change history: v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (10): soc: ti: K2G: enhancement to support QMSS in NSS soc

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:13 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:18 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

Re: [net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:29 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:44PM -0400, Murali Karicheri wrote: >> Introduce rgmii link status to handle link state events for 2u >> cpsw hardware on K2G. >> >> Signed-off-by: Murali Karicheri >> --- >> dri

Re: [net-next,v2,01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-29 Thread Murali Karicheri
Hi Grygorii, Thanks for reviewing this! On 03/28/2018 03:01 PM, Grygorii Strashko wrote: > Hi Murali, > > On 03/27/2018 11:31 AM, Murali Karicheri wrote: >> Navigator Subsystem (NSS) available on K2G SoC has a cut down >> version of QMSS with less number of queues, interna

Re: [net-next,v2,01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-29 Thread Murali Karicheri
gt; @@ -1700,6 +1749,10 @@ static int knav_queue_probe(struct platform_device >> *pdev) >> return -ENOMEM; >> } >> >> +match = of_match_device(of_match_ptr(keystone_qmss_of_match), dev); >> + if (match && match->data) >> +kdev->version = QMSS_LITE; > > if (match) > kdev->version = match->data; > else > error? Similar to above. This private memory is allocated using kzalloc which initializes everything to zero. So the else part is unnecessary. Murali > [...] > -- Murali Karicheri Linux Kernel, Keystone

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-29 Thread Murali Karicheri
On 03/27/2018 01:18 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

Re: [net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-29 Thread Murali Karicheri
On 03/27/2018 01:29 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:44PM -0400, Murali Karicheri wrote: >> Introduce rgmii link status to handle link state events for 2u >> cpsw hardware on K2G. >> >> Signed-off-by: Murali Karicheri >> --- >> dri

Re: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-03-29 Thread Murali Karicheri
t; something which is not RGMII? > Ok. Make sense. > Andrew > -- Murali Karicheri Linux Kernel, Keystone

Re: [PATCH net-next 02/19] net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option

2019-04-25 Thread Murali Karicheri
Jakub, On 04/23/2019 08:27 PM, Jakub Kicinski wrote: On Tue, 23 Apr 2019 16:08:53 +0300, Grygorii Strashko wrote: Both drivers CPSW and EMAC can't work without CPDMA, hence simplify build of those drivers by always linking davinci_cpdma and drop TI_DAVINCI_CPDMA config option. Note. the davinci

Re: [PATCH v2 01/14] dt-bindings: remoteproc: Add TI PRUSS bindings

2019-02-05 Thread Murali Karicheri
Hi Roger, On 02/05/2019 04:39 AM, Roger Quadros wrote: Hi Tony & Suman, On 04/02/19 18:33, Tony Lindgren wrote: Hi, * Roger Quadros [190204 14:23]: From: Suman Anna ... +Example: + +1. /* AM33xx PRU-ICSS */ + + pruss: pruss@0 { + compatible = "ti,am3356-pr

Re: [PATCH v2 01/14] dt-bindings: remoteproc: Add TI PRUSS bindings

2019-02-05 Thread Murali Karicheri
Roger, On 02/05/2019 10:41 AM, Roger Quadros wrote: Murali, On 05/02/19 17:08, Murali Karicheri wrote: Hi Roger, On 02/05/2019 04:39 AM, Roger Quadros wrote: Hi Tony & Suman, On 04/02/19 18:33, Tony Lindgren wrote: Hi, * Roger Quadros [190204 14:23]: From: Suman Anna ... +Exa

Re: [net-next v5 PATCH 0/7] Add PRP driver

2020-07-30 Thread Murali Karicheri
Hi Dave, On 7/27/20 3:21 PM, David Miller wrote: From: Murali Karicheri Date: Wed, 22 Jul 2020 10:40:15 -0400 This series is dependent on the following patches sent out to netdev list. All (1-3) are already merged to net/master as of sending this, but not on the net-next master branch. So

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-07-30 Thread Murali Karicheri
Hi Dave, On 7/17/20 11:22 AM, Murali Karicheri wrote: This patch enhances the iplink command to add a proto parameters to create PRP device/interface similar to HSR. Both protocols are quite similar and requires a pair of Ethernet interfaces. So re-use the existing HSR iplink command to create

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-21 Thread Murali Karicheri
Hi David, et all, On 5/13/20 8:27 AM, Murali Karicheri wrote: Hello netdev experts, On 5/6/20 12:30 PM, Murali Karicheri wrote: This RFC series add support for Parallel Redundancy Protocol (PRP) as defined in IEC-62439-3 in the kernel networking subsystem. PRP Uses a Redundancy Control

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-19 Thread Murali Karicheri
Hi, Stephen, On 8/17/20 5:17 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to v5.9 master v5 - addressed comment from Stephen Hemminger - Sending this with a

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
Hi Stephen, Alexey, On 7/17/20 11:22 AM, Murali Karicheri wrote: This patch enhances the iplink command to add a proto parameters to create PRP device/interface similar to HSR. Both protocols are quite similar and requires a pair of Ethernet interfaces. So re-use the existing HSR iplink command

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
On 8/6/20 1:12 PM, David Ahern wrote: On 8/6/20 10:04 AM, Murali Karicheri wrote: that the maintainers are different than the netdev maintainers. My bad. The PRP driver support in kernel is merged by Dave to net-next and this iproute2 change has to go with it. So please review and apply this

[net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
differentiate the two protocols. Signed-off-by: Murali Karicheri --- ip/iplink_hsr.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index 7d9167d4e6a3..6ea138a23cbc 100644 --- a/ip/iplink_hsr.c +++ b/ip/iplink_hsr.c @@ -25,7

[net-next iproute2 PATCH v4 2/2] ip: iplink: prp: update man page for new parameter

2020-08-06 Thread Murali Karicheri
PRP support requires a proto parameter which is 0 for hsr and 1 for prp. Default is hsr and is backward compatible. Signed-off-by: Murali Karicheri --- man/man8/ip-link.8.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in

[net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device

2020-08-06 Thread Murali Karicheri
at git://git.kernel.org/pub/scm/network/iproute2/iproute2-next and send as v4. Please apply this if looks good. Murali Karicheri (2): iplink: hsr: add support for creating PRP device similar to HSR ip: iplink: prp: update man page for new parameter ip/iplink_hsr.c | 19

Re: [net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device

2020-08-10 Thread Murali Karicheri
iproute2 maintainers, On 8/6/20 4:37 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to net-next and the same can be referenced at https://www.spinics.net/lists/linux-api

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-02 Thread Murali Karicheri
Arnd, Thanks for reviewing the RFC patch. Please see below my response. On 3/25/2014 3:44 AM, Arnd Bergmann wrote: On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: + +int k2_pcie_platform_setup(struct platform_device *pdev) +{ + struct resource *phy_base_r, *devstat_r

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-02 Thread Murali Karicheri
On 4/2/2014 12:47 PM, Andrew Murray wrote: On 2 April 2014 16:43, Murali Karicheri wrote: Keystone pcie driver is developed based on other dw based pcie drivers such as pci-exynos that uses subsys_initcall(). I am new to this list, probably Jingoo (copied) has some history on why we can&#

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-04 Thread Murali Karicheri
On 4/3/2014 4:32 AM, Lucas Stach wrote: Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri: Arnd, Thanks for reviewing the RFC patch. Please see below my response. On 3/25/2014 3:44 AM, Arnd Bergmann wrote: On Monday 24 March 2014 20:35:26 Murali Karicheri wrote

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-07 Thread Murali Karicheri
On 3/25/2014 12:54 PM, Jason Gunthorpe wrote: On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: I have no idea how this would work with the standard interrupt-map property, since the legacy interrupt host is now the same device as the pci host. Maybe it's better to move the legacy

[PATCH v6 2/5] PCI: designware: refactor MSI code to work with v3.65 dw hardware

2014-07-18 Thread Murali Karicheri
this register so that common code can be re-used on old h/w. Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit Kumar Acked-by: Jingoo Han Acked-by: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Bjorn Helgaas CC: Richard Zhu CC: Kishon

[PATCH v6 5/5] PCI: keystone: Update maintainer information

2014-07-18 Thread Murali Karicheri
Update the MAINTAINERS file for the keystone PCIe driver Signed-off-by: Murali Karicheri CC: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Mohit Kumar CC: Jingoo Han CC: Bjorn Helgaas CC: Pratyush Anand CC: Richard Zhu CC: Kishon Vijay Abraham I CC: Marek

[PATCH v6 3/5] PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW hardware

2014-07-18 Thread Murali Karicheri
scan bus API callback. Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit KUMAR CC: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Jingoo Han CC: Bjorn Helgaas CC: Richard Zhu CC: Kishon Vijay Abraham I CC: Marek Vasut CC: Arnd Bergman

[PATCH v6 1/5] PCI: designware: add rd[wr]_other_conf API

2014-07-18 Thread Murali Karicheri
v3.65 version of the designware h/w, requires application space registers to be configured to access the remote EP config space. To support this, add rd[wr]_other_conf API in the pcie_host_opts Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit Kumar Acked-by: Jingoo

[PATCH v6 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-18 Thread Murali Karicheri
side. All of the Application register space handing code are organized into pci-keystone-dw.c and the functions are called from pci-keystone.c to implement PCI controller driver. Also add necessary DT documentation for the driver. Signed-off-by: Murali Karicheri Acked-by: Santosh Shilimkar CC

[PATCH v6 0/5] Add Keystone PCIe controller driver

2014-07-18 Thread Murali Karicheri
mmit log and re-send. Patch 1-3 has Acks from maintainers and I believe this can be merged to upstream branch. Patch 4 is waiting for Ack from DT maintainer. Please provide the same at the earliest. Thanks Signed-off-by: Murali Karicheri CC: Russell King CC: Grant Likely CC: Rob Herring CC: Mohit K

Re: [PATCH v6 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-18 Thread Murali Karicheri
On 07/18/2014 03:50 PM, Arnd Bergmann wrote: On Friday 18 July 2014 14:31:39 Rob Herring wrote: + + Example: + pcie_msi_intc: msi-interrupt-controller { + interrupt-controller; + #interrupt-cells =<1>; + interrupt-parent =<&

Re: [PATCH v6 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-18 Thread Murali Karicheri
Rob, On 07/18/2014 03:31 PM, Rob Herring wrote: On Fri, Jul 18, 2014 at 10:14 AM, Murali Karicheri wrote: --- Cut --- + +Optional properties:- + phys: phandle to Generic Keystone SerDes phy for PCI + phy-names: name of the Generic Keystine SerDes phy for PCI + - If boot

Re: [PATCH v6 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-21 Thread Murali Karicheri
On 07/20/2014 09:44 PM, Jingoo Han wrote: On Saturday, July 19, 2014 5:29 AM, Murali Karicheri wrote: On 07/18/2014 03:31 PM, Rob Herring wrote: On Fri, Jul 18, 2014 at 10:14 AM, Murali Karicheri wrote: --- Cut --- + +Optional properties:- + phys: phandle to Generic Keystone SerDes

[PATCH v7 1/5] PCI: designware: add rd[wr]_other_conf API

2014-07-21 Thread Murali Karicheri
v3.65 version of the designware h/w, requires application space registers to be configured to access the remote EP config space. To support this, add rd[wr]_other_conf API in the pcie_host_opts Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit Kumar Acked-by: Jingoo

[PATCH v7 5/5] PCI: keystone: Update maintainer information

2014-07-21 Thread Murali Karicheri
Update the MAINTAINERS file for the keystone PCIe driver Signed-off-by: Murali Karicheri CC: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Mohit Kumar CC: Jingoo Han CC: Bjorn Helgaas CC: Pratyush Anand CC: Richard Zhu CC: Kishon Vijay Abraham I CC: Marek

[PATCH v7 3/5] PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW hardware

2014-07-21 Thread Murali Karicheri
scan bus API callback. Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit KUMAR CC: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Jingoo Han CC: Bjorn Helgaas CC: Richard Zhu CC: Kishon Vijay Abraham I CC: Marek Vasut CC: Arnd Bergman

[PATCH v7 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-21 Thread Murali Karicheri
side. All of the Application register space handing code are organized into pci-keystone-dw.c and the functions are called from pci-keystone.c to implement PCI controller driver. Also add necessary DT documentation for the driver. Signed-off-by: Murali Karicheri Acked-by: Santosh Shilimkar CC

[PATCH v7 0/5] Add Keystone PCIe controller driver

2014-07-21 Thread Murali Karicheri
mmit log and re-send. Patch 1-3 has Acks from maintainers and I believe this can be merged to upstream branch. Patch 4 is waiting for Ack from DT maintainer. Please provide the same at the earliest. Thanks Signed-off-by: Murali Karicheri CC: Russell King CC: Grant Likely CC: Rob Herring CC: Mohit K

[PATCH v7 2/5] PCI: designware: refactor MSI code to work with v3.65 dw hardware

2014-07-21 Thread Murali Karicheri
this register so that common code can be re-used on old h/w. Signed-off-by: Murali Karicheri Reviewed-by: Pratyush Anand Acked-by: Mohit Kumar Acked-by: Jingoo Han Acked-by: Santosh Shilimkar CC: Russell King CC: Grant Likely CC: Rob Herring CC: Bjorn Helgaas CC: Richard Zhu CC: Kishon

Re: [PATCH v7 4/5] PCI: add PCI controller for keystone PCIe h/w

2014-07-30 Thread Murali Karicheri
On 07/23/2014 01:42 PM, Jason Gunthorpe wrote: On Tue, Jul 22, 2014 at 05:52:00PM -0600, Bjorn Helgaas wrote: If there is a hardware defect, a PCI quirk is a reasonable way to work around it, since that's the main purpose of quirks. fixup_mpss_256() is an example of something that sounds superf

Re: [PATCH - v4] PCI: keystone: add a pci quirk to limit mrrs

2014-09-17 Thread Murali Karicheri
On 09/16/2014 05:54 PM, Bjorn Helgaas wrote: On Mon, Sep 08, 2014 at 01:03:34PM -0400, Murali Karicheri wrote: Keystone PCI controller has a limitation that memory read request size must not exceed 256 bytes. This is a hardware limitation and add a quirk to force this limit on all downstream

Re: [RESEND: PATCH] ahci: add pcid for Marvel 0x9182 controller

2014-09-10 Thread Murali Karicheri
On 09/05/2014 01:53 PM, Tejun Heo wrote: On Fri, Sep 05, 2014 at 01:21:00PM -0400, Murali Karicheri wrote: Keystone K2E EVM uses Marvel 0x9182 controller. This requires support for the ID in the ahci driver. Signed-off-by: Murali Karicheri Applied to libata/for-3.17-fixes w/ stable cc&#

[PATCH] ARM: keystone: dts: fix bindings for pcie and usb clock nodes

2014-09-11 Thread Murali Karicheri
Fix incorrect clock names for usb1, pcie1 and domain register offset for pcie1 clock nodes on K2E EVM Signed-off-by: Murali Karicheri --- arch/arm/boot/dts/k2e-clocks.dtsi |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/k2e-clocks.dtsi b/arch/arm

Re: [PATCH - v4] PCI: keystone: add a pci quirk to limit mrrs

2014-09-11 Thread Murali Karicheri
On 09/08/2014 01:03 PM, Murali Karicheri wrote: Keystone PCI controller has a limitation that memory read request size must not exceed 256 bytes. This is a hardware limitation and add a quirk to force this limit on all downstream devices by updating mrrs. Signed-off-by: Murali Karicheri

Re: [PATCH v3 1/2] PCI: keystone: remove handle of PCI mode configuration

2014-09-11 Thread Murali Karicheri
On 09/10/2014 01:12 PM, Murali Karicheri wrote: Keystone PCI hardware supports both RC and EP modes and devcfg register has bits to boot strap the device to either of these modes. It seems proper to add this functionality to the boot loader rather than in the driver as device will be operating

Re: [PATCH v1 5/5] pci: keystone: add pcie driver based on designware core driver

2014-05-16 Thread Murali Karicheri
On 5/15/2014 2:20 PM, Arnd Bergmann wrote: On Thursday 15 May 2014 13:45:08 Murali Karicheri wrote: +#ifdef CONFIG_PCI_KEYSTONE +/* + * The KeyStone PCIe controller has maximum read request size of 256 bytes. + */ +static void quirk_limit_readrequest(struct pci_dev *dev) +{ +int readrq

Re: [PATCH v1 5/5] pci: keystone: add pcie driver based on designware core driver

2014-05-16 Thread Murali Karicheri
On 5/15/2014 12:28 PM, Arnd Bergmann wrote: On Thursday 15 May 2014 12:01:32 Murali Karicheri wrote: +Sample bindings shown below:- + + - Remove ti,enable-linktrain if boot loader already does Link training and do EP + configuration. + - Remove ti,init-phy if boot loader already initialize

Re: [PATCH v1 2/5] pci: designware: enhancements to support keystone pcie

2014-05-16 Thread Murali Karicheri
On 5/16/2014 6:15 PM, Kumar Gala wrote: On May 15, 2014, at 11:01 AM, Murali Karicheri wrote: keystone pcie hardware is based on designware hw version 3.65. There is no support for ATU port and has registers in application space to configure inbound/outbound access. Also doesn't suppor

Re: [PATCH v1 5/5] pci: keystone: add pcie driver based on designware core driver

2014-05-19 Thread Murali Karicheri
On 5/19/2014 8:06 AM, Arnd Bergmann wrote: On Friday 16 May 2014 16:26:51 Murali Karicheri wrote: On 5/15/2014 2:20 PM, Arnd Bergmann wrote: On Thursday 15 May 2014 13:45:08 Murali Karicheri wrote: +#ifdef CONFIG_PCI_KEYSTONE +/* + * The KeyStone PCIe controller has maximum read request size

<    1   2   3   4   5   6   7   8   9   >