Add param get command which gets data per parameter.
Option to dump the parameters data per device.
Signed-off-by: Moshe Shemesh
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 11 ++
net/core/devlink.c | 250 +++
2 files changed
On 7/28/2020 3:58 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:22 +0300 Moshe Shemesh wrote:
Expose devlink reload supported levels and driver's default level to the
user through devlink dev get command.
Examples:
$ devlink dev show
pci/:82:00.0:
reload_levels
On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets that can be initiated by other hosts. This
parameter is useful for setups where a device is shared by
On 7/28/2020 11:06 PM, Jakub Kicinski wrote:
On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote:
On 7/28/2020 11:44 AM, Jakub Kicinski wrote:
From user perspective what's important is what the reset achieves (and
perhaps how destructive it is). We can define the reset levels as:
$ devlin
On 7/30/2020 12:11 AM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:37:41 +0300 Moshe Shemesh wrote:
The fact that the driver supports fw_live_patch, does not necessarily
mean that the currently running FW can be live upgraded to the
currently flashed one, right?
That's correct, thoug
On 7/29/2020 11:57 PM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:42:12 +0300 Moshe Shemesh wrote:
On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets
On 7/30/2020 12:07 AM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:54:08 +0300 Moshe Shemesh wrote:
On 7/28/2020 11:06 PM, Jakub Kicinski wrote:
On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote:
On 7/28/2020 11:44 AM, Jakub Kicinski wrote:
From user perspective what's importa
On 7/31/2020 2:11 AM, Jakub Kicinski wrote:
On Thu, 30 Jul 2020 15:30:45 +0300 Moshe Shemesh wrote:
My expectations would be that the driver must perform the lowest
reset level possible that satisfies the requested functional change.
IOW driver may do more, in fact it should be acceptable for
On 8/3/2020 1:24 PM, Vasundhara Volam wrote:
On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote:
On 7/27/2020 10:25 PM, Vasundhara Volam wrote:
On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote:
Introduce new option on devlink reload API to enable the user to select the
reload level
On 8/3/2020 3:47 PM, Vasundhara Volam wrote:
On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote:
On 8/3/2020 1:24 PM, Vasundhara Volam wrote:
On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote:
On 7/27/2020 10:25 PM, Vasundhara Volam wrote:
On Mon, Jul 27, 2020 at 4:36 PM Moshe
On 8/6/2020 9:25 PM, Jakub Kicinski wrote:
On Wed, 5 Aug 2020 13:02:58 +0200 Jiri Pirko wrote:
Tue, Aug 04, 2020 at 10:39:46PM CEST, k...@kernel.org wrote:
AFAIU the per-driver default is needed because we went too low
level with what the action constitutes. We need maintain the higher
level
On 8/17/2020 7:16 PM, Jakub Kicinski wrote:
On Mon, 17 Aug 2020 12:37:40 +0300 Moshe Shemesh wrote:
Add devlink reload action to allow the user to request a specific reload
action. The action parameter is optional, if not specified then devlink
driver re-init action is used (backward
On 8/17/2020 7:36 PM, Jiri Pirko wrote:
Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote:
Add devlink reload action to allow the user to request a specific reload
action. The action parameter is optional, if not specified then devlink
driver re-init action is used (backward compa
On 8/17/2020 7:39 PM, Jiri Pirko wrote:
Mon, Aug 17, 2020 at 11:37:52AM CEST, mo...@mellanox.com wrote:
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions
-off-by: Moshe Shemesh
---
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_activate,fw_live_patch
---
.../networking/devlink/devlink-reload.rst | 54 +++
Documentation/networking/devlink/index.rst| 1 +
2 files changed, 55
On 8/19/2020 3:10 AM, Jakub Kicinski wrote:
On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote:
On 8/17/2020 7:36 PM, Jiri Pirko wrote:
Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote:
Add devlink reload action to allow the user to request a specific reload
action. The
On 8/19/2020 3:46 PM, Jiri Pirko wrote:
Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote:
On 8/19/2020 3:10 AM, Jakub Kicinski wrote:
On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote:
On 8/17/2020 7:36 PM, Jiri Pirko wrote:
Mon, Aug 17, 2020 at 11:37:40AM CEST, mo
quot;unspecified": 2
},
"fw_activate": {
"unspecified": 1,
"no_reset": 0
}
}
Fixes: a254c264267e ("devlink: Add reload stats")
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/uapi/linux/devlink.
On 11/22/2020 12:53 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Fri, 20 Nov 2020 15:40:37 +0200 Moshe Shemesh wrote:
Fix reload stats structure exposed to the user. Change stats structure
hierarchy to have the reload action as a parent of the stat
quot;unspecified": 2
},
"fw_activate": {
"unspecified": 1,
"no_reset": 0
}
}
Fixes: a254c264267e ("devlink: Add reload stats")
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
v1 -> v2:
- Fold comment at 80 c
Please don't change that.
On command timeout we don't release ent, since the FW event on
completion can occur after timeout, so it is released on the
completion handler mlx5_cmd_comp_handler().
See commit 73dd3a4839c1d ("net/mlx5: Avoid using pending command
interface slots").
On Tue, Aug 13, 2019
Implement support for devlink health reporters on per-port basis. First
part in the series prepares common functions parts for health reporter
implementation. Second introduces required API to devlink-health and
mlx5e ones demonstrate its usage and effectively implement the feature
for mlx5 driver.
From: Vladyslav Tarasiuk
Add a generic __devlink_health_reporter_find_by_name() that can be used
with arbitrary devlink health reporter list.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 18 ++
1 file changed
the port index attribute in devlink-health response to
allow devlink userspace utility to distinguish between device and port
reporters.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/net/devlink.h | 2 ++
net/core/devlink.c| 94
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index dfd7fe2..dcf8006 100644
---
Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
b/drivers/net/ethernet/mellanox/mlx5/core
From: Vladyslav Tarasiuk
In order to use new devlink port health reporters infrastructure, add
corresponding constructor and destructor functions.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/net/devlink.h | 9 +
net/core
From: Vladyslav Tarasiuk
Utilize new devlink-health port reporters API to move rx and tx
reporters from device to port.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 9 +++--
drivers
From: Vladyslav Tarasiuk
Prepare a common routine in devlink_health_reporter_create() for usage
in similar functions for devlink port health reporters.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 45
On 7/2/2020 7:40 PM, Jakub Kicinski wrote:
On Thu, 2 Jul 2020 18:08:11 +0300 Moshe Shemesh wrote:
From: Vladyslav Tarasiuk
In order to use new devlink port health reporters infrastructure, add
corresponding constructor and destructor functions.
Signed-off-by: Vladyslav Tarasiuk
Reviewed
From: Vladyslav Tarasiuk
Prepare a common routine in devlink_health_reporter_create() for usage
in similar functions for devlink port health reporters.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 45
Implement support for devlink health reporters on per-port basis. First
part in the series prepares common functions parts for health reporter
implementation. Second introduces required API to devlink-health and
mlx5e ones demonstrate its usage and effectively implement the feature
for mlx5 driver.
From: Vladyslav Tarasiuk
Utilize new devlink-health port reporters API to move rx and tx
reporters from device to port.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 9 +++--
drivers
Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
b/drivers/net/ethernet/mellanox/mlx5/core
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index dfd7fe2..dcf8006 100644
---
From: Vladyslav Tarasiuk
Add a generic __devlink_health_reporter_find_by_name() that can be used
with arbitrary devlink health reporter list.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 18 ++
1 file changed
the port index attribute in devlink-health response to
allow devlink userspace utility to distinguish between device and port
reporters.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/net/devlink.h | 2 ++
net/core/devlink.c| 94
From: Vladyslav Tarasiuk
In order to use new devlink port health reporters infrastructure, add
corresponding constructor and destructor functions.
Signed-off-by: Vladyslav Tarasiuk
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
include/net/devlink.h | 9 +
net/core
database to help debugging an issue.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 52 +++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c| 24 +
include/linux
"driver_reinit": 1
},{
"fw_activate": 0
},{
"fw_activate_no_reset": 0
} ]
}
}
}
}
Signed-off-by: Moshe Shemesh
Change devlink_reload_supported() function to get devlink_ops pointer
param instead of devlink pointer param.
This change will be used in the next patch to check if devlink reload is
supported before devlink instance is allocated.
Signed-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- New pa
-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- Rename supported_reload_actions to reload_actions.
- Rename devlink_nl_reload_actions_performed_fill() to
devlink_nl_reload_actions_performed_snd() and add genlmsg_reply() to it
- Actions_performed sent to user space as a mask
- Driver can initial
it moves to reset
requested mode and if it gets PCI reset triggered by the other PF it
detect the reset and reloads.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv1 -> RFCv2:
- Moved handling of sync reset recovery from health to fw_reset
---
.../ethernet/mellanox/mlx5/c
} ],
"remote_reload_stats": [ {
"driver_reinit": 1
},{
"fw_activate": 1
},{
"fw_activate_no_reset": 0
} ]
}
}
}
}
Signed-off-by: Moshe
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- Rename reload_action_limit_level to reload_limit
RFCv4 -> RFCv5:
- Rephrase namespace chnage section
- Rephrase note on actions performed
RFCv3 -> RFCv4:
- Remo
Add functions to query and set the MFRL reset options supported by
firmware.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv5 -> v1:
- Renamed non-static functions to have module prefix
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../ethernet/mellanox/mlx5/c
of action and limit are invalid. For example, driver
can not reinitialize its entities without any downtime.
The no_reset reload limit will have usecase in this patchset to
implement restricted fw_activate on mlx5.
Signed-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- Rena
firmware update reset is enabled.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv1 -> RFCv2:
- Have MLX5_FW_RESET_FLAGS_NACK_RESET_REQUEST instead of
MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 21 ++
.../ether
devlink-reload.rst
Moshe Shemesh (16):
devlink: Change devlink_reload_supported() param type
devlink: Add reload action option to devlink reload command
devlink: Add devlink reload limit option
devlink: Add reload stats
devlink: Add remote reload stats
net/mlx5: Add functions to set/query
synchronizes all PFs on coming reset and driver reload.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv4 -> RFCv5:
- Add remote actions stats
- If devlink reload is not supported, show only remote_stats
RFCv3 -> RFCv4:
- Renamed DEVLINK_ATTR_RELOAD_ACTION_
bridge by checking that all the PF functions under the same PCI
bridge have same device ID. If no other device it uses PCI bridge link
control to turn link down and up.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 119
NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
Documentation/networking/devlink/devlink-params.rst | 6 ++
include/net/devlink.h | 4
net/core/devlink.c
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net
. If it is then it triggers firmware live patching flow.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv5 -> v1:
- Renamed reload_action_limit_level to reload_limit
RFCv3 -> RFCv4:
- Have action fw_activate with limit level no_reset instead of action
fw_activate_no_reset
On 10/2/2020 12:14 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Thu, 1 Oct 2020 16:59:06 +0300 Moshe Shemesh wrote:
@@ -3032,6 +3064,7 @@ devlink_nl_reload_actions_performed_snd(struct devlink
*devlink,
static int devlink_nl_cmd_reload(struct
On 10/2/2020 12:25 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Thu, 1 Oct 2020 16:59:07 +0300 Moshe Shemesh wrote:
Add reload stats to hold the history per reload action type and limit.
For example, the number of times fw_activate has been
On 10/2/2020 12:52 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Thu, 1 Oct 2020 16:59:18 +0300 Moshe Shemesh wrote:
+ err = mlx5_fw_reset_set_live_patch(dev);
+ if (err)
+ return err;
+
+ return 0;
nit return mlx...
Right
On 10/2/2020 6:19 PM, Jiri Pirko wrote:
Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote:
[...]
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 1c286e9a3590..ddba63bce7ad 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -1077,10 +1077,11 @@ st
On 10/3/2020 10:51 AM, Jiri Pirko wrote:
Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote:
[...]
enum devlink_attr {
/* don't change the order or add anything between, this is ABI! */
DEVLINK_ATTR_UNSPEC,
@@ -507,6 +524,7 @@ enum devlink_attr {
DEVLINK_
On 10/3/2020 10:52 AM, Jiri Pirko wrote:
Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote:
[...]
+static int
+devlink_nl_reload_actions_performed_snd(struct devlink *devlink,
+ unsigned long actions_performed,
+
},{
"fw_activate": 0
},{
"fw_activate_no_reset": 0
} ]
}
}
}
}
Signed-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- Changed the stats output structure, have 2 stats, one for local and
one for remote
- Resplit
"fw_activate_no_reset": 0
} ],
"remote_reload_stats": [ {
"driver_reinit": 1
},{
"fw_activate": 1
},{
On 10/3/2020 12:14 PM, Jiri Pirko wrote:
Thu, Oct 01, 2020 at 03:59:19PM CEST, mo...@mellanox.com wrote:
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
RFCv5 -> v1:
- Rename reload_action_limit_level to reload_limit
RF
On 10/3/2020 6:04 PM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote:
enum devlink_attr {
/* don't change the order or add anything between, this is ABI! */
DEVLINK_ATTR_UNSPEC,
@@ -507,6 +524,7 @@ e
On 10/5/2020 10:12 PM, Jacob Keller wrote:
On 10/4/2020 12:09 AM, Moshe Shemesh wrote:
On 10/3/2020 12:05 PM, Jiri Pirko wrote:
Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote:
Add remote reload stats to hold the history of actions performed due
devlink reload commands
it moves to reset
requested mode and if it gets PCI reset triggered by the other PF it
detect the reset and reloads.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv1 -> RFCv2:
- Moved handling of sync reset recovery from health to fw_reset
---
.../ethernet/mellanox/mlx5/c
synchronizes all PFs on coming reset and driver reload.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv4 -> RFCv5:
- Add remote actions stats
- If devlink reload is not supported, show only remote_stats
RFCv3 -> RFCv4:
- Renamed DEVLINK_ATTR_RELOAD_ACTION_
-off-by: Moshe Shemesh
Reviewed-by: Jakub Kicinski
Reviewed-by: Jacob Keller
---
v1 -> v2:
- Changes actions_performed attr to nla_bitfield32
- Change reload_up() parameters order, extack should be last
RFCv5 -> v1:
- Rename supported_reload_actions to reload_actions
-
mlx5 add devlink reload limit no_reset support for
fw_activate reload action.
Patch 16 adds documentation file devlink-reload.rst
Moshe Shemesh (16):
devlink: Change devlink_reload_supported() param type
devlink: Add reload action option to devlink reload command
devlink: Add
Change devlink_reload_supported() function to get devlink_ops pointer
param instead of devlink pointer param.
This change will be used in the next patch to check if devlink reload is
supported before devlink instance is allocated.
Signed-off-by: Moshe Shemesh
Reviewed-by: Jakub Kicinski
"driver_reinit": 1,
"fw_activate": 1,
"fw_activate_no_reset": 0
}
}
}
}
}
Signed-off-by: Moshe Shemesh
Reviewed-by: Jakub Kicinski
---
v1 -> v2:
- Add devlink_dev_stat
NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
Documentation/networking/devlink/devlink-params.rst | 6 ++
include/net/devlink.h | 4
net/core/devlink.c
multiselection.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Changed limit uapi parameter to bitfield32 for future support of
multiselection
- Fixed reverse xmas tree
RFCv5 -> v1:
- Renamed supported_reload_actions_limit_levels to reload_limits
- Renamed reload_action_limit_level to reload_limit
-
Add functions to query and set the MFRL reset options supported by
firmware.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv5 -> v1:
- Renamed non-static functions to have module prefix
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../ethernet/mellanox/mlx5/c
vate": 1,
"fw_activate_no_reset": 0
}
}
},
"pci/:82:00.1": {
"stats": {
"reload": {
"driver_reinit": 1,
"fw_activate": 0,
"fw_
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net
firmware update reset is enabled.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
RFCv1 -> RFCv2:
- Have MLX5_FW_RESET_FLAGS_NACK_RESET_REQUEST instead of
MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 21 ++
.../ether
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions
bridge by checking that all the PF functions under the same PCI
bridge have same device ID. If no other device it uses PCI bridge link
control to turn link down and up.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 119
. If it is then it triggers firmware live patching flow.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
v1 ->v2:
- Shorten return flow in mlx5_devlink_trigger_fw_live_patch()
RFCv5 -> v1:
- Renamed reload_action_limit_level to reload_limit
RFCv3 -> RFCv4:
- Have action fw_acti
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Split first paragraph of devlink reload description to 2 sentences
RFCv5 -> v1:
- Rename reload_action_limit_level to reload_limit
RFCv4 -> RFCv5:
- Rephrase namespa
database to help debugging an issue.
Signed-off-by: Moshe Shemesh
Reviewed-by: Saeed Mahameed
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 52 +++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c| 24 +
include/linux
On 10/7/2020 3:41 PM, Vasundhara Volam wrote:
On Wed, Oct 7, 2020 at 11:32 AM Moshe Shemesh wrote:
Add reload limit to demand restrictions on reload actions.
Reload limits supported:
no_reset: No reset allowed, no down time allowed, no link flap and no
configuration is lost.
By
On 9/2/2020 3:01 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Tue, 1 Sep 2020 22:05:36 +0300 Moshe Shemesh wrote:
+void devlink_reload_actions_cnts_update(struct devlink *devlink, unsigned long
actions_done)
+{
+ int action;
+
+ for (action = 0
},
"pci/:82:00.1": {
"reload_actions_stats": [ {
"driver_reinit": 1
},{
"fw_activate": 1
},{
"fw_activate_no_reset": 0
} ]
}
}
}
Signed-
firmware activation
was done with or without reset.
The function devlink_reload_actions_cnts_update() is exported to enable
also drivers update on reload actions done, for example in case firmware
activation with reset finished successfully but was initiated by remote
host.
Signed-off-by: Moshe
:
driver_reinit fw_activate
Signed-off-by: Moshe Shemesh
---
v2 -> v3:
- Replace fw_live_patch action by fw_activate_no_reset
- Devlink reload returns the actions done over netlink reply
v1 -> v2:
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_ac
levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_activate,fw_live_patch
- Remove driver default level, the action driver_reinit is the default
action for all drivers
Moshe Shemesh (14):
devlink: Add reload action option to devlink reload command
devlink: Add reload actions cou
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/net
it moves to reset
requested mode and if it gets PCI reset triggered by the other PF it
detect the reset and reloads.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Moved handling of sync reset recovery from health to fw_reset
---
.../ethernet/mellanox/mlx5/core/fw_reset.c|
firmware update reset is enabled.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Have MLX5_FW_RESET_FLAGS_NACK_RESET_REQUEST instead of
MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 21 +
.../ethernet/mellanox/mlx5/core/fw_rese
;supported_reload_actions": [
"fw_live_patch","driver_reinit","fw_activate" ]
}
}
}
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Removed DEVLINK_ATTR_RELOAD_DEFAULT_LEVEL
- Removed DEVLINK_ATTR_RELOAD_LEVELS_INFO
- Have actions instead of levels
---
include
bridge by checking that all the PF functions under the same PCI
bridge have same device ID. If no other device it uses PCI bridge link
control to turn link down and up.
Signed-off-by: Moshe Shemesh
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 121 ++
1 file changed, 121
synchronizes all PFs on coming reset and driver reload.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Have fw_activate action instead of fw_reset level
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 53 --
.../ethernet/mellanox/mlx5/core/fw_reset.c|
patching.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_activate,fw_live_patch
- Remove driver default level, the action driver_reinit is the default
action for all drivers
---
drivers/net/ether
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core
database to help debugging an issue.
Signed-off-by: Moshe Shemesh
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 31 +++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c| 27
include/linux/mlx5/device.h
Add support for devlink reload action fw_live_patch which does live
patching to firmware.
The driver checks if the firmware is capable of handling the pending
firmware changes as a live patch. If it is then it triggers
fw_live_patch flow.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- H
NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh
---
Documentation/networking/devlink/devlink-params.rst | 6 ++
include/net/devlink.h | 4
net/core/devlink.c | 5 +
3 files
1 - 100 of 195 matches
Mail list logo
