Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-03-25 Thread Miroslav Lichvar
timekeeping_forward(tk, tk->tkr_mono.cycle_last + offset); > + tk->ntp_error = 0; > + return 0; > + } -- Miroslav Lichvar

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-04-04 Thread Miroslav Lichvar
On Thu, Mar 27, 2025 at 04:42:49PM +0100, Miroslav Lichvar wrote: > Maybe I could simply patch the kernel to force a small clock > multiplier to increase the rate at which the error accumulates. I tried that and it indeed makes the issue clearly visible. The COARSE fix makes the clock less

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-03-27 Thread Miroslav Lichvar
On Thu, Mar 27, 2025 at 10:22:31AM +0100, Thomas Gleixner wrote: > On Tue, Mar 25 2025 at 12:32, Miroslav Lichvar wrote: > > Resetting the NTP error causes a small time step. An NTP/PTP client > > can be setting the frequency very frequently, e.g. up to 128 times per > > se

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-04-01 Thread Miroslav Lichvar
On Tue, Apr 01, 2025 at 08:34:23AM +0200, Thomas Gleixner wrote: > On Mon, Mar 31 2025 at 16:53, Miroslav Lichvar wrote: > > Mult reduction Updates/sec Skew before Skew after > > 16 4 0.004 0.009 > > 16 16

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-03-31 Thread Miroslav Lichvar
On Thu, Mar 27, 2025 at 06:32:27PM +0100, Thomas Gleixner wrote: > On Thu, Mar 27 2025 at 16:42, Miroslav Lichvar wrote: > > On Thu, Mar 27, 2025 at 10:22:31AM +0100, Thomas Gleixner wrote: > > To clearly see the difference with the new code, I made an attempt > > to update

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-04-03 Thread Miroslav Lichvar
On Tue, Apr 01, 2025 at 08:29:23PM +0200, Thomas Gleixner wrote: > On Tue, Apr 01 2025 at 13:19, Miroslav Lichvar wrote: > > It seems to improve the worst cases, but overall it's still > > a regression. > > > > Mult reduction Updates/sec Skew > > 16

[tip:timers/urgent] timekeeping: Remove CONFIG_GENERIC_TIME_VSYSCALL_OLD

2017-11-14 Thread tip-bot for Miroslav Lichvar
Commit-ID: aea3706cfc4d952ed6d32b6d5845b5ecd99ed7f5 Gitweb: https://git.kernel.org/tip/aea3706cfc4d952ed6d32b6d5845b5ecd99ed7f5 Author: Miroslav Lichvar AuthorDate: Mon, 13 Nov 2017 14:51:31 -0800 Committer: Thomas Gleixner CommitDate: Tue, 14 Nov 2017 11:20:25 +0100 timekeeping

[tip:timers/core] timekeeping/ntp: Don't align NTP frequency adjustments to ticks

2018-03-10 Thread tip-bot for Miroslav Lichvar
Commit-ID: c2cda2a5bda9f1369c9d1ab54a20571c13cf2743 Gitweb: https://git.kernel.org/tip/c2cda2a5bda9f1369c9d1ab54a20571c13cf2743 Author: Miroslav Lichvar AuthorDate: Fri, 9 Mar 2018 10:42:47 -0800 Committer: Ingo Molnar CommitDate: Sat, 10 Mar 2018 09:12:41 +0100 timekeeping/ntp: Don&#

[tip:timers/core] timekeeping/ntp: Determine the multiplier directly from NTP tick length

2018-03-10 Thread tip-bot for Miroslav Lichvar
Commit-ID: 78b98e3c5a66d569a53b8f57b6a698f912794a43 Gitweb: https://git.kernel.org/tip/78b98e3c5a66d569a53b8f57b6a698f912794a43 Author: Miroslav Lichvar AuthorDate: Fri, 9 Mar 2018 10:42:48 -0800 Committer: Ingo Molnar CommitDate: Sat, 10 Mar 2018 09:12:41 +0100 timekeeping/ntp

[tip:timers/urgent] ntp: Allow TAI-UTC offset to be set to zero

2019-05-09 Thread tip-bot for Miroslav Lichvar
Commit-ID: fdc6bae940ee9eb869e493990540098b8c0fd6ab Gitweb: https://git.kernel.org/tip/fdc6bae940ee9eb869e493990540098b8c0fd6ab Author: Miroslav Lichvar AuthorDate: Wed, 17 Apr 2019 10:48:33 +0200 Committer: Thomas Gleixner CommitDate: Thu, 9 May 2019 10:46:58 +0200 ntp: Allow TAI-UTC

[tip:timers/core] ntp: Limit TAI-UTC offset

2019-06-22 Thread tip-bot for Miroslav Lichvar
Commit-ID: d897a4ab11dc8a9fda50d2eccc081a96a6385998 Gitweb: https://git.kernel.org/tip/d897a4ab11dc8a9fda50d2eccc081a96a6385998 Author: Miroslav Lichvar AuthorDate: Tue, 18 Jun 2019 17:47:13 +0200 Committer: Thomas Gleixner CommitDate: Sat, 22 Jun 2019 11:28:53 +0200 ntp: Limit TAI

[tip:timers/core] kselftests: timers: freq-step: Update maximum acceptable precision and errors

2019-06-22 Thread tip-bot for Miroslav Lichvar
Commit-ID: d21e43f2ef32ba3242687dbedb3c4b9a76b3eebc Gitweb: https://git.kernel.org/tip/d21e43f2ef32ba3242687dbedb3c4b9a76b3eebc Author: Miroslav Lichvar AuthorDate: Tue, 18 Jun 2019 18:06:12 +0200 Committer: Thomas Gleixner CommitDate: Sat, 22 Jun 2019 11:28:53 +0200 kselftests

<    1   2