On Thu, Dec 04, 2014 at 12:32:49PM +0200, Mika Westerberg wrote:
> If the user has selected CONFIG_DEBUG_PINCTRL=y make sure that Intel
> pinctrl drivers will be compiled with that option as well.
>
> Signed-off-by: Mika Westerberg
Gentle ping on these two.
--
To unsubscribe fr
On Mon, Jan 26, 2015 at 04:39:30PM +, Mark Rutland wrote:
> What I don't follow is why GpioInt seems to be translated as a GPIO
> rather than as an interrupt which happens to be backed by a GPIO. Were
> it not for that, the DT and ACPI cases would align better.
Because it *is* a GPIO.
In my e
On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote:
> > If the above is not the right way to use GPIOs as interrupt, can you
> > please tell me how it is done then?
>
>
> So lets say we have a device which generates an interrupt:
>
> device@f00 {
> compatible = "som
On Tue, Jan 27, 2015 at 11:14:58AM +, Mark Rutland wrote:
> On Tue, Jan 27, 2015 at 10:59:31AM +0000, Mika Westerberg wrote:
> > On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote:
> > > > If the above is not the right way to use GPIOs as interrupt, can you
>
On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote:
> Ok, that allays my fear w.r.t. ordering of the resources.
>
> As I see it, the fact that we convert GpioInt entries to GPIOs rather
> than irqs when parsing _CRS is the issue here, and to me it makes no
> sense that we do so. Were we
On Tue, Jan 27, 2015 at 03:06:06PM +, Mark Rutland wrote:
> On Tue, Jan 27, 2015 at 02:41:27PM +0000, Mika Westerberg wrote:
> > On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote:
> > > Ok, that allays my fear w.r.t. ordering of the resources.
> > >
>
On Tue, Jan 27, 2015 at 03:57:47PM +, Mark Rutland wrote:
> On Tue, Jan 27, 2015 at 03:21:27PM +0000, Mika Westerberg wrote:
> > On Tue, Jan 27, 2015 at 03:06:06PM +, Mark Rutland wrote:
> > > On Tue, Jan 27, 2015 at 02:41:27PM +0000, Mika Westerberg wrote:
> > >
On Wed, Apr 01, 2015 at 10:01:45AM -0700, Feng Kan wrote:
> On Wed, Apr 1, 2015 at 12:45 AM, Mika Westerberg
> wrote:
> > On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote:
> >> This will add support for ACPI parsing of the mboxes attribute
> >> when booti
On Thu, Apr 02, 2015 at 11:04:24AM -0700, Feng Kan wrote:
> On Thu, Apr 2, 2015 at 2:07 AM, Mika Westerberg
> wrote:
> > On Wed, Apr 01, 2015 at 10:01:45AM -0700, Feng Kan wrote:
> >> On Wed, Apr 1, 2015 at 12:45 AM, Mika Westerberg
> >> wrote:
> >> >
;
> > and reduce the log level of the "broken _DSD" message to
> > "debug" (noise reduction).
> >
> > Signed-off-by: Rafael J. Wysocki
Looks good,
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&q
On Tue, Apr 14, 2015 at 12:55:20AM +0200, Gabriele Mazzotta wrote:
> Hi,
>
> my touchpad stopped working because of a485923efbb8 ("HID: i2c-hid:
> Add support for ACPI GPIO interrupts"). It turned out that I need
> CONFIG_GPIOLIB. I think this dependency should be made explicit or the
> driver sho
count that acpi_dev_add_driver_gpios()
returns -ENXIO when !CONFIG_GPIOLIB.
Fix this by checking the return value against -ENXIO and 0 and only in that
case fail the probe.
Reported-by: Gabriele Mazzotta
Signed-off-by: Mika Westerberg
---
drivers/hid/i2c-hid/i2c-hid.c | 5 -
1 file changed, 4 insertions(+),
On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote:
> On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg
> wrote:
> > On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote:
>
> >> For the sleep case I think the GPIO controller needs to do the pin
&
On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote:
> On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg
> wrote:
> > On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote:
> >> On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg
> >> wrote:
>
On Mon, Mar 30, 2015 at 04:52:49PM +0300, Octavian Purdila wrote:
> What if we can do the pin configuration in gpiolib right after the
> GPIO controller is initialized. I am thinking of searching the ACPI
> namespace and looking for resources that have GpioInt entries for that
> particular GPIO con
hardware that is
based on the same host controller design.
Signed-off-by: Mathias Nyman
Signed-off-by: Mika Westerberg
---
drivers/pinctrl/intel/Kconfig| 17 +
drivers/pinctrl/intel/Makefile |2 +
drivers/pinctrl/intel/pinctrl-intel.c| 1149
On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote:
> This will add support for ACPI parsing of the mboxes attribute
> when booting with ACPI table. The client will have a attribute
> mimic the dts call "mboxes". In the ACPI case, the client will
> mark "mboxes" with the ACPI HID of the mbox
On Tue, Apr 28, 2015 at 02:32:59PM +0100, Lee Jones wrote:
> On Tue, 31 Mar 2015, Andy Shevchenko wrote:
>
> > The new coming Intel platforms such as Skylake will contain Sunrisepoint
> > PCH.
> > The main difference to the previous platforms is that the LPSS devices are
> > compound devices wher
resource to Linux IRQ number.
This requires that the boot firmware (BIOS/coreboot) configures these pins
correctly (input, etc) before handing over to OS. I've tested this on Intel
Baytrail, Braswell and Skylake based machines where this is true.
[1] https://lkml.org/lkml/2015/3/25/103
Int
and then translate that to Linux IRQ number. This adds unnecessary lines of
boiler-plate code.
We can ease this a bit by introducing acpi_dev_gpio_irq_get() analogous to
of_irq_get(). This function translates given GpioInt resource under the
device in question to the suitable Linux IRQ number.
the don't need to care about GPIOs at
all if only thing they need is interrupt.
Signed-off-by: Mika Westerberg
---
drivers/i2c/i2c-core.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 987c124432c5..01ef731
On Tue, Apr 07, 2015 at 03:18:20PM +0200, Linus Walleij wrote:
> On Mon, Mar 30, 2015 at 4:31 PM, Mika Westerberg
> wrote:
>
> > This driver supports pinctrl/GPIO hardware found on Intel Sunrisepoint (a
> > Skylake PCH) providing users a pinctrl and GPIO interfaces (includin
On Tue, Apr 07, 2015 at 01:37:56PM +0200, Rafael J. Wysocki wrote:
> To be precise, PRP0001 specifically means "Use the 'compatible' property
> to find the driver for this device", so if *that* is what you want to do,
> you can use PRP0001 as the _HID. For Windows (and such) compatibility, you
> c
On Thu, Apr 09, 2015 at 02:22:10AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Currently, the ACPI modalias creation covers two mutually exclusive
> cases: If the PRP0001 device ID is present in the device's list of
> ACPI/PNP IDs and the "compatible" property is present in _DSD
On Tue, Apr 28, 2015 at 06:57:35PM +0100, Lee Jones wrote:
> On Tue, 28 Apr 2015, Mika Westerberg wrote:
> > On Tue, Apr 28, 2015 at 02:32:59PM +0100, Lee Jones wrote:
> > > On Tue, 31 Mar 2015, Andy Shevchenko wrote:
> > >
> > > > The new coming Intel
On Tue, Apr 28, 2015 at 10:36:48AM -0700, sathyanarayanan kuppuswamy wrote:
> >This requires that the boot firmware (BIOS/coreboot) configures these pins
> >correctly (input, etc) before handing over to OS. I've tested this on Intel
> >Baytrail, Braswell and Skylake based machines where this is tru
On Wed, Apr 29, 2015 at 11:56:06AM +0200, Wolfram Sang wrote:
>
> > - if (!client->irq && dev->of_node) {
> > - int irq = of_irq_get(dev->of_node, 0);
> > + if (client->irq <= 0) {
> > + int irq = -ENOENT;
>
> Why the move from !client->irq to <= 0? If I didn't miss someth
On Wed, Apr 29, 2015 at 04:06:19PM +0100, Lee Jones wrote:
> > >> +static const struct mfd_cell intel_lpss_uart_devs[] = {
> > >> + {
> > >> + .name = "dw_dmac",
> > >> + .num_resources = ARRAY_SIZE(intel_lpss_idma_resources),
> > >> + .resources = intel_lpss
On Wed, May 27, 2015 at 11:22:41AM +0100, Lee Jones wrote:
> > +static int resume_lpss_device(struct device *dev, void *data)
> > +{
> > + pm_runtime_resume(dev);
> > + return 0;
> > +}
> > +
> > +int intel_lpss_prepare(struct device *dev)
> > +{
> > + /*
> > +* Resume both child devices
On Thu, Jun 11, 2015 at 02:08:22AM +0200, Tobias Diedrich wrote:
> In create_gpio_led only the legacy pass propagates the label by passing it
> into
> devm_gpio_request_one.
>
> On the newer devicetree/acpi path the label is lost as far as the GPIO
> subsystem goes (it is only retained as name in
On Fri, Jun 12, 2015 at 07:45:00PM -0300, Lucas De Marchi wrote:
> Hi Mika,
>
> On Wed, Jun 10, 2015 at 4:55 AM, Mika Westerberg
> wrote:
> > On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.mar...@gmail.com wrote:
> >> @@ -320,7 +320,7 @@ static int dw_i2
SYMBOL_GPL(__gpiod_get_index);
> * fwnode_get_named_gpiod - obtain a GPIO from firmware node
> * @fwnode: handle of the firmware node
> * @propname:name of the firmware property representing the GPIO
> + * @label: label for the GPIO
ditto.
Otherwise this is f
On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.rupp...@alitech.com wrote:
> Dear Lucas,
>
> Lucas De Marchi wrote on 23.06.2015 19:02:03:
> > On Tue, Jun 23, 2015 at 1:45 PM, wrote:
> > > Hello,
> > >
> > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> > [...]
> > > The res
Ping on this.
On Fri, May 08, 2015 at 02:31:30PM +0300, Mika Westerberg wrote:
> Using -1 as platform device id means that the platform driver core will not
> assign any id to the device (the device name will not have id at all). This
> results problems on systems that have mult
On Tue, Jun 02, 2015 at 03:53:40PM +0200, Linus Walleij wrote:
> On Mon, Jun 1, 2015 at 11:23 AM, Mika Westerberg
> wrote:
> > On Fri, May 22, 2015 at 10:56:08AM +0300, Mika Westerberg wrote:
> >> BIOS/platform may use some of the pins by themselves, such as providing SCI
le, since
> acpi_bind_one uses's the companion ACPI device's wakeup flags to set the
> device as wake capable. Which results in power/wakeup files in sysfs for
> the HID device which do not do anything.
>
> Signed-off-by: Andrew Duggan
Acked-by: Mika Westerberg
--
To unsubsc
igned-off-by: Octavian Purdila
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
igned-off-by: Octavian Purdila
In addition to Alexandre's comments, the change itself looks good to me
so once you address them,
Reviewed-by: Mika Westerberg
Thanks for taking care of this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
On Fri, May 22, 2015 at 10:56:08AM +0300, Mika Westerberg wrote:
> BIOS/platform may use some of the pins by themselves, such as providing SCI
> (System Control Interrupt) from the embedded controller. The driver masks
> all interrupts at probe time which prevents those pins from t
On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.mar...@gmail.com wrote:
> From: Fabio Mello
>
> According to documentation and tests, initialization is not
> necessary on module resume, since the controller keeps its state
> between disable/enable. Change the target address is also allowed.
>
lementation code into its own
> file.
>
> With generic DMA available for PXA, we can now just trash this file.
>
> Signed-off-by: Daniel Mack
> Cc: Mika Westerberg
Acked-by: Mika Westerberg
> Acked-by: Mark Brown
> [respin after pxa dmaengine support upstream]
> S
the subsequent device creations will fail because there already exists
platform device with the same name.
Fix this by passing PLATFORM_DEVID_AUTO as platform device id. This makes
the platform device core to allocate new ids automatically.
Signed-off-by: Mika Westerberg
---
v1 -> v2:
On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote:
> Hi Mika,
>
> On Tue, Jun 9, 2015 at 5:51 AM, Mika Westerberg
> wrote:
> > On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.mar...@gmail.com wrote:
> >> From: Fabio Mello
> >>
>
On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.mar...@gmail.com wrote:
> @@ -320,7 +320,7 @@ static int dw_i2c_resume(struct device *dev)
> clk_prepare_enable(i_dev->clk);
>
> if (!i_dev->pm_runtime_disabled)
> - i2c_dw_init(i_dev);
> + i2c_dw_enable(i_dev)
: Tobias Diedrich
Signed-off-by: Mika Westerberg
---
drivers/gpio/gpiolib-acpi.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 19b99d0c2bf0..b49006c81a7f 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers
On Wed, Jun 10, 2015 at 05:05:16PM +0200, christian.rupp...@alitech.com wrote:
>We should understand why the controller was disabled after successful
>transfers in the first place, however. Maybe some quirk with older
>versions of the hardware? Mika, do you have any memories about this?
:-) Thank you
for doing this,
Acked-by: Mika Westerberg
One typo found, see below.
> ---
> Documentation/acpi/enumeration.txt | 49
> +
> 1 file changed, 49 insertions(+)
>
> Index: linux-p
On Wed, Apr 08, 2015 at 04:58:27PM -0700, Feng Kan wrote:
> This will add support for ACPI parsing of the mboxes attribute
> when booting with ACPI table. The client will have a attribute
> mimic the dts call "mboxes". In the ACPI case, the client will
> mark "mboxes" with the ACPI reference of the
_BUILD.BRANCH.PATCH which is not well suited for DMI matching as
> we do not have "less than" match mode for DMI data.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Signed-off-by: Dmitry Torokhov
Acked-by: Mika Westerberg
On Wed, Apr 04, 2018 at 03:03:10PM +0300, Bernat, Yehezkel wrote:
> Soon I'll not be available by my Intel email address, so switching to my
> personal email address instead.
>
> Signed-off-by: Yehezkel Bernat
Applied, thanks!
On Thu, Apr 26, 2018 at 03:23:17PM +0100, John Garry wrote:
> Not that I know about. Can you describe this method? I guess I also don't
> need to set the mfd_cell pnpid either for this special case device.
There is some documentation in "MFD devices" chapter of
Documentation/acpi/enumeration.txt a
If the boot ACL entry is already NULL we should not fill in the upper
two DWs with 0xf. Otherwise they are not shown as empty entries
when the sysfs attribute is read.
Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
Signed-off-by: Mika Westerberg
---
drivers/t
If the boot ACL entry is already NULL we should not fill in the upper
two DWs with 0xf. Otherwise they are not shown as empty entries
when the sysfs attribute is read.
Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
Signed-off-by: Mika Westerberg
---
Chang
(2018-05-07 15:14:16 +0300)
Mika Westerberg (1):
thunderbolt: Handle NULL boot ACL entries properly
drivers/thunderbolt/icm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.0
If the boot ACL entry is already NULL we should not fill in the upper
two DWs with 0xf. Otherwise they are not shown as empty entries
when the sysfs attribute is read.
Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
Signed-off-by: Mika Westerberg
Acked-by
r.
>
> More information is available in this [1] blog post.
>
> [1]: https://davmac.wordpress.com/2010/02/26/c99-revisited/
>
> Acked-by: Ard Biesheuvel
> Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
On Sat, Apr 21, 2018 at 09:50:07AM +0100, Javier Arteaga wrote:
> +static const struct acpi_device_id upboard_acpi_match[] = {
> + { "AANT0F01", (kernel_ulong_t) &upboard_up2_data },
No space after cast so write it like,
{ "AANT0F01", (kernel_ulong_t)&upboard_up2_data },
> + { }
On Sat, Apr 21, 2018 at 09:50:06AM +0100, Javier Arteaga wrote:
> [linux-kernel correctly Cc'd on the series now. Sorry for the noise.]
>
> Hi all,
>
> This series adds platform support for AAEON's UP Squared, a x86 SBC
> based on Apollo Lake [1]. Specifically, it enables control for the board
>
s: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Cc: Mika Westerberg
Acked-by: Mika Westerberg
; Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 2d4611e..b04425b 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -18,6 +18,8 @@
> #include
> #include
> #include
> +#include
> +#includ
ark. As the result, IOMMU driver will block
> any translated requests from any device marked as untrusted.
>
> Cc: Jacob Pan
> Cc: Mika Westerberg
Reviewed-by: Mika Westerberg
after resume.
>
> Signed-off-by: Chris Chiu
Acked-by: Mika Westerberg
On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote:
> Hi Srinivas,
>
> Thanks for the patch,
> By default NVMEM_SYSFS should be set true, those whose don't want they can
> disable the same.
>
> If we go with disable option, there are chances of eeprom may break in below
> case:
>
> if
On Tue, Apr 16, 2019 at 10:44:01AM +0100, Srinivas Kandagatla wrote:
> As Kohli suggested we could make NVMEM_SYSFS default to y so that the sysfs
> file is available by default like before and user/board specific can decide
> to deselect it.
>
> Let me know if thats Okay with you, I can spin that
e to a new file so that its
> not compiled in when its not really required.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Mika Westerberg
+Rafael and linux-acpi.
On Thu, Apr 18, 2019 at 11:23:49AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka
>
> Validated on the Quark platform, this adds interrupt support on rising
> and/or falling edges.
The irqchip parts look good to me but but the ACPI SCI handling seems
weird. This is typicall
On Wed, Apr 24, 2019 at 10:12:42AM +0200, Jan Kiszka wrote:
> On 24.04.19 09:58, Mika Westerberg wrote:
> > +Rafael and linux-acpi.
> >
> > On Thu, Apr 18, 2019 at 11:23:49AM +0200, Jan Kiszka wrote:
> > > From: Jan Kiszka
> > >
> > > Validated on
On Wed, Apr 24, 2019 at 10:25:40AM +0200, Jan Kiszka wrote:
> On 24.04.19 10:18, Mika Westerberg wrote:
> > On Wed, Apr 24, 2019 at 10:12:42AM +0200, Jan Kiszka wrote:
> > > On 24.04.19 09:58, Mika Westerberg wrote:
> > > > +Rafael and linux-acpi.
> > > &
On Wed, Apr 24, 2019 at 11:36:58AM +0200, Jan Kiszka wrote:
> OK, there is that table, but what is it supposed to tell me about the
> event and where to hook into it better?
...
> [02Eh 0046 2]SCI Interrupt : 0009
This is the SCI interrupt GSI number. IIRC it maps 1:1 to Linux
in
On Wed, Apr 24, 2019 at 11:48:09AM +0200, Jan Kiszka wrote:
> On 24.04.19 11:45, Mika Westerberg wrote:
> > On Wed, Apr 24, 2019 at 11:36:58AM +0200, Jan Kiszka wrote:
> > > OK, there is that table, but what is it supposed to tell me about the
> > > event and w
On Wed, Apr 24, 2019 at 12:19:02PM +0200, Jan Kiszka wrote:
> > I think what you want is "GPIO signaled ACPI event". It works so that
> > you declare _AEI method below the GPIO controller listing the GPIOs you
> > want to trigger events for and then either _Lxx, _Exx or _EVT method for
> > each of
On Wed, Apr 24, 2019 at 12:39:35PM +0200, Jan Kiszka wrote:
> On 24.04.19 12:33, Mika Westerberg wrote:
> > On Wed, Apr 24, 2019 at 12:19:02PM +0200, Jan Kiszka wrote:
> > > > I think what you want is "GPIO signaled ACPI event". It works so that
> > >
On Wed, Apr 24, 2019 at 02:41:02PM +0200, Jan Kiszka wrote:
> On 24.04.19 12:46, Mika Westerberg wrote:
> > On Wed, Apr 24, 2019 at 12:39:35PM +0200, Jan Kiszka wrote:
> > > On 24.04.19 12:33, Mika Westerberg wrote:
> > > > On Wed, Apr 24, 2019 at 12:19:02PM +0200, J
On Wed, Apr 24, 2019 at 04:24:16PM +0200, Jan Kiszka wrote:
> > I'm trying to say that for the sysfs access (well or char dev) you
> > should not need the sch_sci_handler() thing that is in your current
> > patch.
>
> Then I'm still missing the black magic where - in my case - CGTS or RGTS are
> r
the fix, which can solve weird
> IRQ triggering issues on I2C touchpad ELAN1200.
>
> Signed-off-by: Kai-Heng Feng
Acked-by: Mika Westerberg
On Wed, Apr 24, 2019 at 12:00:05PM -0700, Nathan Chancellor wrote:
> On Wed, Apr 24, 2019 at 11:49:37AM -0700, Nick Desaulniers wrote:
> > On Wed, Apr 24, 2019 at 11:34 AM Nathan Chancellor
> > wrote:
> > >
> > > Clang warns:
> > >
> > > drivers/thunderbolt/tunnel.c:504:17: warning: implicit trunc
On Tue, Mar 12, 2019 at 03:33:28AM -0500, Kangjie Lu wrote:
> In case kzalloc fails, the fix releases resources and returns
> -ENOMEM to avoid the NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu
Applied, thanks!
On Thu, Mar 14, 2019 at 01:55:31AM -0500, Kangjie Lu wrote:
> kmemdup may fail and return NULL. The fix adds a check and returns
> NULL in case it fails to avoid NULL pointer dereferecen.
>
> Signed-off-by: Kangjie Lu
Applied, thanks!
in next read.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/cap.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/thunderbolt/cap.c b/drivers/thunderbolt/cap.c
index 0de548bda663..8aceb0d97a63 100644
--- a/drivers/thunderbolt/cap.c
+++ b/drivers/thunderbolt
Currently the software connection manager (tb.c) has only supported
creating a single PCIe tunnel, no PCIe device daisy chaining has been
supported so far. This updates the software connection manager so that
it now can create PCIe tunnels for full chain of six devices.
Signed-off-by: Mika
In order to tunnel non-PCIe traffic as well rename tunnel_pci.[ch] to
tunnel.[ch] to reflect this fact. No functional changes.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/Makefile | 2 +-
drivers/thunderbolt/tb.c | 2 +-
drivers/thunderbolt
unregistering the ThunderboltIP protocol handler when
suspending and registering it back on resume.
Signed-off-by: Mika Westerberg
Acked-by: David S. Miller
---
drivers/net/thunderbolt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c
port has HPD set before tunnels can be established. This
adds Display Port tunneling support to the software connection manager.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/switch.c | 111 ++
drivers/thunderbolt/tb.c | 119 ---
drivers/thunderbolt/tb.h
that if
the remote domain UUID is not filled in the core will query it first and
only then start the normal property exchange flow.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/tb_msgs.h | 11 +++
drivers/thunderbolt/xdomain.c | 136 +++---
include/linux
the software connection manager as well.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/switch.c | 29 ++--
drivers/thunderbolt/tb.c | 131 ++-
2 files changed, 153 insertions(+), 7 deletions(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers
).
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/ctl.c| 2 +-
drivers/thunderbolt/icm.c| 2 +-
drivers/thunderbolt/path.c | 30 +++---
drivers/thunderbolt/switch.c | 19 +--
drivers/thunderbolt/tb.c | 11 +--
drivers/thunderbolt
We will be needing these routines to find Display Port adapters as well
so modify them to take port type as the second parameter.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/switch.c | 16
drivers/thunderbolt/tb.c | 35 +--
drivers
hardware when trying to access the possible switch.
Convert all the current call sites to handle this properly.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/icm.c| 6 +++---
drivers/thunderbolt/switch.c | 36
drivers/thunderbolt/tb.c | 6
already up.
By doing this we can properly tear down tunnels when devices are
disconnected. Also this allows us to resume the existing tunnels after
system suspend/resume cycle.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/path.c | 144 +--
drivers
packets.
To support this we introduce another tunnel type (TB_TUNNEL_DMA) that
supports paths from NHI to NULL port and back.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/path.c| 20 ++--
drivers/thunderbolt/switch.c | 22
drivers/thunderbolt/tb.h | 2 +
drivers
Titan Ridge flow to start the firmware is the same as Alpine Ridge so we
can do the same on Titan Ridge based Apple systems.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/icm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
We can't be sure the paths are actually properly deactivated when a
tunnel is restarted after resume. So instead of marking all paths as
inactive we go ahead and deactivate them explicitly.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/tunnel.c | 9 -
1 file chang
unplugged.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/switch.c | 20 +---
drivers/thunderbolt/tb_regs.h | 3 +++
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index 29bf9119e0ae..7cc1f534e776
software connection manager code
when hotplug event is handled.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/tb.c | 10 ++
drivers/thunderbolt/tb.h | 5 +
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
Thunderbolt 2 devices and beyond need to have additional bits set in
link controller specific registers. This includes two bits in LC_SX_CTRL
that tell the link controller which lane is connected and whether it is
upstream facing or not.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt
Maximum depth in Thunderbolt topology is 6 so make sure it is not
possible to allocate switches that exceed the depth limit.
While at it update tb_switch_alloc() to use upper/lower_32_bits()
following tb_switch_alloc_safe_mode().
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/icm.c
Thunderbolt 2 devices and beyond link controller needs to be notified
when a switch is going to be suspended by setting bit 31 in LC_SX_CTRL
register. Add this functionality to the software connection manager.
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/lc.c | 44
her domain as soon as possible
run tb_xdp_handle_request() in system workqueue instead. Since the
device can be hot-removed in the middle we need to make sure the domain
structure is still around when the function is run so increase reference
count before we schedule the reply work.
Signed-off-by: M
We need to be able to walk from one port to another when we are creating
paths where there are multiple switches between two ports. For this
reason introduce a new function tb_port_get_next() and a new macro
tb_for_each_port().
Signed-off-by: Mika Westerberg
---
drivers/thunderbolt/switch.c
801 - 900 of 2936 matches
Mail list logo
