[PATCH v2 09/10] spi/pxa2xx: add support for Intel Low Power Subsystem SPI

2013-01-21 Thread Mika Westerberg
d a new type LPSS_SSP that can be used to distinguish the LPSS devices from others. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 133 ++-- drivers/spi/spi-pxa2xx.h |6 ++ include/linux/pxa2xx_ssp.h |9 +++ include/linux/

[PATCH v2 06/10] spi/pxa2xx: add support for DMA engine

2013-01-21 Thread Mika Westerberg
and channel numbers can be passed to the driver from the platform specific data. Signed-off-by: Mika Westerberg --- Linus W, there haven't been any comments from Vinod/Dan about the alignment thing so I added a comment 'REVISIT: ..' so that we remember to change this once it has

[PATCH v2 08/10] spi/pxa2xx: add support for SPI_LOOP

2013-01-21 Thread Mika Westerberg
This is useful when testing the functionality of the controller from userspace and there aren't any real SPI slave devices connected to the bus. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/sp

[PATCH v2 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-01-21 Thread Mika Westerberg
ile tested on PXA (due to lack of hardware). Mika Westerberg (10): spi/pxa2xx: allow building on a 64-bit kernel spi/pxa2xx: fix warnings when compiling a 64-bit kernel spi/pxa2xx: convert to the pump message infrastructure spi/pxa2xx: convert to the common clk framework spi/pxa2xx: use t

[PATCH v2 04/10] spi/pxa2xx: convert to the common clk framework

2013-01-21 Thread Mika Westerberg
drv_data->max_clk_rate at probe time because clk_get_rate() cannot be called in tasklet context. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 33 - include/linux/spi/pxa2xx_spi.h | 18 -- 2 files changed, 20 insertions(+),

[PATCH v2 01/10] spi/pxa2xx: allow building on a 64-bit kernel

2013-01-21 Thread Mika Westerberg
We are going to use it on 64-bit kernel on Intel Lynxpoint so make sure we can build it into such kernel. Signed-off-by: Mika Westerberg --- drivers/spi/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 2e188e1

[PATCH v2 02/10] spi/pxa2xx: fix warnings when compiling a 64-bit kernel

2013-01-21 Thread Mika Westerberg
size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:34: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Mika Westerberg

Re: [PATCH v2 06/10] spi/pxa2xx: add support for DMA engine

2013-01-21 Thread Mika Westerberg
On Mon, Jan 21, 2013 at 03:44:36PM +, Russell King - ARM Linux wrote: > On Mon, Jan 21, 2013 at 11:31:59AM +0200, Mika Westerberg wrote: > > +bool dma_is_possible(size_t len) > > +int map_dma_buffers(struct driver_data *drv_data) > > +irqreturn_t dma_transfer(struct

Re: [PATCH 1/4] ACPI / PM: Make acpi_bus_init_power() more robust

2013-01-21 Thread Mika Westerberg
configuration of device power > resources indicates power state Dn. > > Reported-by: Mika Westerberg You can add also, Tested-by: Mika Westerberg if you like. Thanks for fixing this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[PATCH v3 01/10] spi/pxa2xx: allow building on a 64-bit kernel

2013-01-22 Thread Mika Westerberg
We are going to use it on 64-bit kernel on Intel Lynxpoint so make sure we can build it into such kernel. Signed-off-by: Mika Westerberg --- drivers/spi/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 2e188e1

[PATCH v3 07/10] spi/pxa2xx: add support for runtime PM

2013-01-22 Thread Mika Westerberg
Drivers should put the device into low power states proactively whenever the device is not in use. Thus implement support for runtime PM and use the autosuspend feature to make sure that we can still perform well in case we see lots of SPI traffic within short period of time. Signed-off-by: Mika

[PATCH v3 02/10] spi/pxa2xx: fix warnings when compiling a 64-bit kernel

2013-01-22 Thread Mika Westerberg
size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:34: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Mika Westerberg

[PATCH v3 08/10] spi/pxa2xx: add support for SPI_LOOP

2013-01-22 Thread Mika Westerberg
This is useful when testing the functionality of the controller from userspace and there aren't any real SPI slave devices connected to the bus. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/sp

[PATCH v3 10/10] spi/pxa2xx: add support for Lynxpoint SPI controllers

2013-01-22 Thread Mika Westerberg
Intel Lynxpoint PCH Low Power Subsystem has two general purpose SPI controllers that are LPSS_SSP compatible. These controllers are enumerated from ACPI namespace with ACPI IDs INT33C0 and INT33C1. Signed-off-by: Mika Westerberg --- drivers/spi/Kconfig |2 +- drivers/spi/spi-pxa2xx.c

[PATCH v3 03/10] spi/pxa2xx: convert to the pump message infrastructure

2013-01-22 Thread Mika Westerberg
The SPI core provides infrastructure for standard message queueing so use that instead of handling everything in the driver. This simplifies the driver. Signed-off-by: Mika Westerberg Acked-by: Linus Walleij --- drivers/spi/spi-pxa2xx.c | 212 +++--- 1

[PATCH v3 05/10] spi/pxa2xx: break out the private DMA API usage into a separate file

2013-01-22 Thread Mika Westerberg
allows usage of any DMA controller that implements DMA engine API. Signed-off-by: Mika Westerberg --- This patch was already acked by Linus W but since I changed this by breaking out the PXA private implementation into a separate file, I'm hoping to get new ack from him ;-) drivers/spi/Kc

[PATCH v3 09/10] spi/pxa2xx: add support for Intel Low Power Subsystem SPI

2013-01-22 Thread Mika Westerberg
d a new type LPSS_SSP that can be used to distinguish the LPSS devices from others. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 133 ++-- drivers/spi/spi-pxa2xx.h |6 ++ include/linux/pxa2xx_ssp.h |9 +++ include/linux/

[PATCH v3 06/10] spi/pxa2xx: add support for DMA engine

2013-01-22 Thread Mika Westerberg
. The DMA engine implementation will be selected by default even on PXA platform. User can select the legacy DMA API by enabling Kconfig option CONFIG_SPI_PXA2XX_PXADMA. Signed-off-by: Mika Westerberg --- Linus W, there haven't been any comments from Vinod/Dan about the alignment thing so I

[PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-01-22 Thread Mika Westerberg
A and DMA engine. I've dropped the two patches that are already applied in Mark's SPI tree. Tested on Haswell machine with both DMA and PIO modes. Only compile tested on PXA (due to lack of hardware). Mika Westerberg (10): spi/pxa2xx: allow building on a 64-bit kernel spi/pxa2x

[PATCH v3 04/10] spi/pxa2xx: convert to the common clk framework

2013-01-22 Thread Mika Westerberg
drv_data->max_clk_rate at probe time because clk_get_rate() cannot be called in tasklet context. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 33 - include/linux/spi/pxa2xx_spi.h | 18 -- 2 files changed, 20 insertions(+),

Re: [PATCH v2 2/3] clk: x86: add support for Lynxpoint LPSS clocks

2013-01-23 Thread Mika Westerberg
On Tue, Jan 22, 2013 at 10:47:54AM -0800, Mike Turquette wrote: > Quoting Mika Westerberg (2013-01-18 05:46:00) > > Intel Lynxpoint Low Power Subsystem hosts peripherals like UART, I2C and > > SPI controllers. For most of these there is a configuration register that > > allo

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-14 Thread Mika Westerberg
On Thu, Feb 14, 2013 at 03:27:38PM +0530, Vinod Koul wrote: > Not in the CSRT parser. Once your plaform devices are created, you can add > your > own board handler for each platform device. This board code, using the > data availble from CSRT can go ahead and do the translation and present the > a

Re: [PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Mika Westerberg
On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote: > This patch implements interrupt sharing and SDA hold time configuration in > the designware i2c driver. Both functions are enabled through platform data > or device tree. Tested with Linux-3.8rc4 (Synopsys ARC port, see > https://

Re: [PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Mika Westerberg
On Fri, Feb 15, 2013 at 02:05:10PM +0100, Christian Ruppert wrote: > On Fri, Feb 15, 2013 at 01:50:37PM +0200, Mika Westerberg wrote: > > On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote: > > > This patch implements interrupt sharing and SDA hold time configur

Re: [PATCH v2] i2c-designware: make SDA hold time configurable

2013-02-18 Thread Mika Westerberg
On Mon, Feb 18, 2013 at 11:14:27AM +0100, Christian Ruppert wrote: > This patch makes the SDA hold time configurable through device tree. > It was tested on a hybrid of i2c/next and arc-3.8-baseline (see > https://github.com/foss-for-synopsys-dwc-arc-processors/linux/commits/arc-3.8-baseline) > si

Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-18 Thread Mika Westerberg
On Mon, Feb 18, 2013 at 12:03:04PM +0100, Alexander Holler wrote: > Am 11.02.2013 11:31, schrieb Mika Westerberg: > >We now have two transport mediums: USB and I2C, where sensor hubs can > >exists. So instead of constraining the driver to only these two we let it > >to match a

Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-18 Thread Mika Westerberg
On Mon, Feb 18, 2013 at 12:22:58PM +0100, Alexander Holler wrote: > Am 18.02.2013 12:12, schrieb Mika Westerberg: > >On Mon, Feb 18, 2013 at 12:03:04PM +0100, Alexander Holler wrote: > >>Am 11.02.2013 11:31, schrieb Mika Westerberg: > >>>We now have two transport medi

Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-18 Thread Mika Westerberg
On Mon, Feb 18, 2013 at 12:37:52PM +0100, Alexander Holler wrote: > Am 18.02.2013 12:33, schrieb Mika Westerberg: > >On Mon, Feb 18, 2013 at 12:22:58PM +0100, Alexander Holler wrote: > >>Am 18.02.2013 12:12, schrieb Mika Westerberg: > >>>On Mon, Feb 18, 2013 at 12:0

Re: [PATCH v3] i2c-designware: make SDA hold time configurable

2013-02-18 Thread Mika Westerberg
-baseline) > since our platform is ARC based and this architecture is not yet > supported by i2c/next. > > Signed-off-by: Christian Ruppert > Signed-off-by: Pierrick Hascoet Reviewed-by: Mika Westerberg Thanks! -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Mika Westerberg
On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi wrote: > > > On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > > >> On Wed, Oct 10, 2012 at 1

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:24:33PM +0100, Rafael J. Wysocki wrote: > On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: > > On 22/11/12 15:55, Chris Ball wrote: > > > Hi, > > > > > > On Thu, Nov 22 2012, Adrian Hunter wrote: > > >> Here is SDHCI ACPI driver. It is dependent on new AC

Re: [PATCH 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:43:50AM +0200, Adrian Hunter wrote: > +static int __devinit sdhci_acpi_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + acpi_handle handle = dev->acpi_handle; This is not going to work anymore, you'll have to use ACPI_HANDLE(dev)

Re: [PATCH v2 2/3] ACPI: add SDHCI to ACPI platform devices

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:00PM +0200, Adrian Hunter wrote: > Signed-off-by: Adrian Hunter Reviewed-by: Mika Westerberg > --- > drivers/acpi/scan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index 8c4ac6d..6

Re: [PATCH v2 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:01PM +0200, Adrian Hunter wrote: > Signed-off-by: Adrian Hunter > Acked-by: Chris Ball Looks like you left that redundant check in place but it doesn't hurt anyway. Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "u

Re: [PATCH 0/2] ACPI / platform: Put devices enumerated via ACPI into D0 before probing drivers

2012-11-25 Thread Mika Westerberg
PI PM attach/detach routines to change device power states. > [2/2] - Call the ACPI PM attach/detach routines in the platform probe and > remove/shutdown callbacks (and change power states of devices as > necessary). Reviewed-by: Mika Westerberg Tested-by: Mika Westerberg -

Re: [PATCH 1/16] ACPI: Separate adding ACPI device objects from probing ACPI drivers

2013-01-11 Thread Mika Westerberg
(Sorry to jump in late but I noticed one problem with this series while testing). On Thu, Dec 20, 2012 at 02:47:47AM +0100, Rafael J. Wysocki wrote: > +static acpi_status acpi_bus_probe_start(acpi_handle handle, u32 lvl, > + void *context, void **not_used) > +{

Re: [PATCH 1/16] ACPI: Separate adding ACPI device objects from probing ACPI drivers

2013-01-11 Thread Mika Westerberg
On Fri, Jan 11, 2013 at 09:31:43PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: ACPI / scan: Fix check of device_attach() return value. > > Since device_attach() returns 1 on success and 0 on failure, > the check against its return value in acpi_bus_device_attach() > shoul

Re: [PATCH 1/16] ACPI: Separate adding ACPI device objects from probing ACPI drivers

2013-01-11 Thread Mika Westerberg
On Fri, Jan 11, 2013 at 09:58:50PM +0100, Rafael J. Wysocki wrote: > On Friday, January 11, 2013 10:37:59 PM Mika Westerberg wrote: > > On Fri, Jan 11, 2013 at 09:31:43PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Subject: ACPI / scan: Fix chec

[PATCH] ACPI: add support for CSRT table

2013-01-14 Thread Mika Westerberg
number to the actual request line understood by the hardware. This range is passed as IORESOURCE_DMA resource. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- drivers/acpi/Makefile |1 + drivers/acpi/csrt.c | 156 + 2 files

[PATCH 3/3] ACPI: create Lynxpoint clocks if LPSS devices are found during scan

2013-01-14 Thread Mika Westerberg
to be passed via acpi_platform_device_ids[] table which is called whenever the corresponding device is found. Signed-off-by: Mika Westerberg --- drivers/acpi/scan.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drivers/acpi/scan.c b/dr

[PATCH 1/3] x86: enable common clk on x86

2013-01-14 Thread Mika Westerberg
so on x86. This allows us to re-use the drivers with little or no modification wrt. clock API usage. This patch was originally proposed by Mark Brown. Signed-off-by: Mika Westerberg --- arch/x86/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig

[PATCH 2/3] clk: x86: add support for Lynxpoint LPSS clocks

2013-01-14 Thread Mika Westerberg
hat we can pass clock rate to the drivers as well. Signed-off-by: Heikki Krogerus Signed-off-by: Mika Westerberg --- drivers/clk/Makefile |1 + drivers/clk/x86/Makefile |2 + drivers/clk/x86/clk-lpss.c | 99 drivers/clk/x86/clk-lps

[PATCH 0/3] x86: enable common clk and add support for Lynxpoint clocks

2013-01-14 Thread Mika Westerberg
ACPI scan rework by Rafael. Please review. Mika Westerberg (3): x86: enable common clk on x86 clk: x86: add support for Lynxpoint LPSS clocks ACPI: create Lynxpoint clocks if LPSS devices are found during scan arch/x86/Kconfig |1 + drivers/acpi/scan.c|

Re: [PATCH 0/3] x86: enable common clk and add support for Lynxpoint clocks

2013-01-14 Thread Mika Westerberg
On Mon, Jan 14, 2013 at 04:46:25PM +0200, Mika Westerberg wrote: > Hi all, > > The discussion that lead to this patch series starts from the below thread: > > http://thread.gmane.org/gmane.linux.kernel/1417691 > > In summary, there is no point in adding a special cas

[PATCH 2/2] nfsd: fix compile warning about unused variable 'nn'

2013-01-14 Thread Mika Westerberg
-variable] Fix this by marking the 'nn' with __maybe_unused. Signed-off-by: Mika Westerberg --- fs/nfsd/nfs4state.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index ac8ed96..2d3011c 100644 --- a/fs/nfsd/nfs4state.c +++

[PATCH 1/2] svcrpc: fix compile warning about unused variable 'buf'

2013-01-14 Thread Mika Westerberg
] Fix this by marking the 'buf' with __maybe_unused. In addition make checkpatch.pl happy by removing space before tab after 'char'. Signed-off-by: Mika Westerberg --- net/sunrpc/svc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/svc.c b/ne

Re: [PATCH] ACPI / PM: Do not apply ACPI_SUCCESS() to acpi_bus_get_device() result

2012-12-16 Thread Mika Westerberg
by: Rafael J. Wysocki Reviewed-by: Mika Westerberg > --- > drivers/acpi/device_pm.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux/drivers/acpi/device_pm.c > === > --- linux.orig/dr

Re: [RFC PATCH 1/6] Introduce acpi_match_device_id().

2012-09-28 Thread Mika Westerberg
On Fri, Sep 28, 2012 at 03:38:30PM +0800, Zhang Rui wrote: > >From 72df5d1f51fb27a4ba7f70a3b07df759d32b8288 Mon Sep 17 00:00:00 2001 > From: Zhang Rui > Date: Thu, 27 Sep 2012 15:11:55 +0800 > Subject: [RFC PATCH 1/6] Introduce acpi_match_device_id(). > > This API is used to check if a device id

Re: [RFC PATCH 1/6] Introduce acpi_match_device_id().

2012-09-30 Thread Mika Westerberg
On Sat, Sep 29, 2012 at 01:31:52PM +, Zhang, Rui wrote: > > > > +{ > > > + acpi_handle handle = DEVICE_ACPI_HANDLE(dev); > > > > If the device is not bound to an ACPI handle this will return NULL. And > > I don't see you doing that in this series meaning that.. > > > > > You're right, I s

Re: [RFC PATCH 0/6] ACPI: ACPI 5.0 device enumeration proposal

2012-09-30 Thread Mika Westerberg
On Fri, Sep 28, 2012 at 03:37:43PM +0800, Zhang Rui wrote: > > the main idea is that, for Serial Buses like I2C and SPI, we enumerate > the controller as a platform device, and then enumerate the slaves via > i2c/spi_register_board_info. And then, when the controller is really > probed and enabled

Re: [RFC PATCH 2/6] Introduce ACPI style match in platform_match

2012-09-30 Thread Mika Westerberg
On Fri, Sep 28, 2012 at 03:39:15PM +0800, Zhang Rui wrote: > >From 5d7ecd12c2994b8c5905d52718c2870c3b62746e Mon Sep 17 00:00:00 2001 > From: Zhang Rui > Date: Fri, 28 Sep 2012 14:51:03 +0800 > Subject: [RFC PATCH 2/6] Introduce ACPI style match in platform_match > > Signed-off-by: Zhang Rui > --

Re: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration driver

2012-09-30 Thread Mika Westerberg
On Fri, Sep 28, 2012 at 03:40:32PM +0800, Zhang Rui wrote: > +acpi_status __init i2c_enumerate_slave(acpi_handle handle, u32 level, > +void *data, void **return_value) > +{ > + int result; > + acpi_status status; > + struct acpi_buffer buffer; > +

Re: [PATCH] ACPI: add support for CSRT table

2013-01-15 Thread Mika Westerberg
On Wed, Jan 16, 2013 at 12:35:56AM +0100, Rafael J. Wysocki wrote: > On Monday, January 14, 2013 11:51:51 AM Mika Westerberg wrote: > > Core System Resources Table (CSRT) is a proprietary ACPI table that > > contains resources for certain devices that are not found in the DSDT >

Re: [PATCH 1/3] x86: enable common clk on x86

2013-01-15 Thread Mika Westerberg
On Wed, Jan 16, 2013 at 12:59:17AM +0100, Rafael J. Wysocki wrote: > On Monday, January 14, 2013 04:46:26 PM Mika Westerberg wrote: > > We are starting to see traditional SoC peripherals also in the x86 world, > > things like UART, I2C and SPI controllers that might already

Re: [PATCH] ACPI: add support for CSRT table

2013-01-16 Thread Mika Westerberg
On Wed, Jan 16, 2013 at 04:05:13PM +0100, Rafael J. Wysocki wrote: > On Wednesday, January 16, 2013 06:42:16 AM Mika Westerberg wrote: > > On Wed, Jan 16, 2013 at 12:35:56AM +0100, Rafael J. Wysocki wrote: > > > On Monday, January 14, 2013 11:51:51 AM Mika Westerberg wrote: &

Re: [PATCH 1/3] x86: enable common clk on x86

2013-01-16 Thread Mika Westerberg
On Wed, Jan 16, 2013 at 04:01:20PM +0100, Rafael J. Wysocki wrote: > On Wednesday, January 16, 2013 07:20:54 AM Mika Westerberg wrote: > > On Wed, Jan 16, 2013 at 12:59:17AM +0100, Rafael J. Wysocki wrote: > > > On Monday, January 14, 2013 04:46:26 PM Mika Westerberg wrote: >

[PATCH v2] ACPI: add support for CSRT table

2013-01-16 Thread Mika Westerberg
number to the actual request line understood by the hardware. This range is passed as IORESOURCE_DMA resource. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- We got a report that compiling this as 32-bit gives the following warning: drivers/acpi/csrt.c:42:5: warning: left

Re: [PATCH v2] ACPI: add support for CSRT table

2013-01-16 Thread Mika Westerberg
On Thu, Jan 17, 2013 at 12:27:32AM +0100, Rafael J. Wysocki wrote: > > +static int __init acpi_csrt_init(void) > > +{ > > + struct acpi_csrt_group *grp, *end; > > + struct acpi_table_csrt *csrt; > > + acpi_status status; > > + int ret; > > + > > + status = acpi_get_table(ACPI_SIG_CSRT, 0,

Re: [PATCH 06/11] spi/pxa2xx: use the private DMA API only when CONFIG_ARCH_PXA is set

2013-01-17 Thread Mika Westerberg
On Thu, Jan 17, 2013 at 10:36:19AM +0100, Linus Walleij wrote: > On Mon, Jan 7, 2013 at 11:44 AM, Mika Westerberg > wrote: > > > The PXA SPI driver uses PXA platform specific private DMA implementation > > which does not work on non-PXA platforms. In order to use thi

[PATCH v3] ACPI: add support for CSRT table

2013-01-17 Thread Mika Westerberg
number to the actual request line understood by the hardware. This range is passed as IORESOURCE_DMA resource. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- Changes to v2: - instead of initcall we call acpi_csrt_init() directly from acpi_scan_init. drivers

[PATCH 2/4] i2c-designware: always set the STOP bit after last byte

2013-01-17 Thread Mika Westerberg
from the hardware registers, so we must make sure that the STOP bit is always set once the last byte of the last message is transferred. This patch is based on the work of Dirk Brandewie. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.c | 16 ++-- 1

[PATCH 1/4] i2c-designware: add missing MODULE_LICENSE

2013-01-17 Thread Mika Westerberg
The driver can also be built as a module so add MODULE_LICENSE for it. In addition add MODULE_DESCRIPTION as well. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-core.c b

[PATCH 4/4] i2c-designware: add support for Intel Lynxpoint

2013-01-17 Thread Mika Westerberg
Intel Lynxpoint has two I2C controllers. These controllers are enumerated from ACPI namespace with IDs INT33C2 and INT33C3. Add support for these to the I2C DesignWare platform driver. This is based on the work of Dirk Brandewie. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c

[PATCH 3/4] i2c-designware: add minimal support for runtime PM

2013-01-17 Thread Mika Westerberg
s can save more power by power gating the device etc. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-platdrv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c

[PATCH 0/4] i2c-designware: add Intel Lynxpoint support

2013-01-17 Thread Mika Westerberg
the designware platform driver. This is useful if the PM subsystem/domain implements runtime PM, like in case of ACPI. Patch [4/4] finally implements ACPI enumeration support for the designware platform driver and adds Lynxpoint ACPI IDs. Please review. Mika Westerberg (4): i2c-designware: add

Re: [PATCH 07/11] spi/pxa2xx: add support for DMA engine

2013-01-17 Thread Mika Westerberg
On Thu, Jan 17, 2013 at 10:48:15AM +0100, Linus Walleij wrote: > On Mon, Jan 7, 2013 at 11:44 AM, Mika Westerberg > wrote: > > > In order to use DMA with this driver on non-PXA platforms we implement > > support > > for the generic DMA engine API. This allows t

Re: [PATCH 2/4] i2c-designware: always set the STOP bit after last byte

2013-01-17 Thread Mika Westerberg
On Thu, Jan 17, 2013 at 12:32:48PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Jan 17, 2013 at 12:31:05PM +0200, Mika Westerberg wrote: > > If IC_EMPTYFIFO_HOLD_MASTER_EN is set to one, the DesignWare I2C controller > > doesn't generate STOP on the bus when the FIFO i

[PATCH v2 1/3] x86: add support for Intel Low Power Subsystem

2013-01-18 Thread Mika Westerberg
is is selected we enable common clk framework (and everything else) that is needed to support the Intel LPSS drivers. Enabling common clk framework on x86 was originally proposed by Mark Brown. Signed-off-by: Mika Westerberg --- arch/x86/Kconfig | 10 ++ 1 file changed, 10 insertions(+)

[PATCH v2 0/3] x86: enable common clk and add support for Lynxpoint clocks

2013-01-18 Thread Mika Westerberg
config option CONFIG_X86_INTEL_LPSS - pass flags to acpi_create_platform_device() instead of calling function in drivers/acpi/scan.c - create the clock platform devices in drivers/acpi/acpi_platform.c Please review. Mika Westerberg (3): x86: add support for Intel Low

[PATCH v2 2/3] clk: x86: add support for Lynxpoint LPSS clocks

2013-01-18 Thread Mika Westerberg
pass clock rate to the drivers as well. Signed-off-by: Heikki Krogerus Signed-off-by: Mika Westerberg Reviewed-by: Mark Brown --- drivers/clk/Makefile |1 + drivers/clk/x86/Makefile |2 + drivers/clk/x86/clk-lpss.c | 99 drivers/clk

[PATCH v2 3/3] ACPI / platform: create LPSS clocks if Lynxpoint devices are found during scan

2013-01-18 Thread Mika Westerberg
gs for all the Lynxpoint LPSS devices and make sure that when this flag is set we create the corresponding clock tree platform device. Signed-off-by: Mika Westerberg --- drivers/acpi/acpi_platform.c | 25 - drivers/acpi/internal.h |6 +- drivers/a

Re: Fwd: Hid over I2C and ACPI interaction

2012-07-09 Thread Mika Westerberg
On Mon, Jul 09, 2012 at 11:24:45AM +0800, Lan Tianyu wrote: > I think we can add new interface to get acpi specific resources. e.g > struct acpi_resource pnp_get_acpi_resource(...). When the pnp acpi devices > were initialized, put those acpi specific resources into a new resource list > pnpdev->ac

Re: [PATCH] SPI: SSP SPI Controller driver v3

2013-01-07 Thread Mika Westerberg
On Mon, Jan 07, 2013 at 11:21:04AM +0100, Linus Walleij wrote: > On Mon, Jan 7, 2013 at 9:05 AM, channing wrote: > > > Frankly I'm currently not sure whether they share same IP.. per your > > reminds, I tried to find but get > > limited info about PXA SSP's IP, from the code, looks like they hav

[PATCH 09/11] spi/pxa2xx: add support for SPI_LOOP

2013-01-07 Thread Mika Westerberg
This is useful when testing the functionality of the controller from userspace and there aren't any real SPI slave devices connected to the bus. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/sp

[PATCH 03/11] spi/pxa2xx-pci: switch to use pcim_* interfaces

2013-01-07 Thread Mika Westerberg
go, simplifying the error management. This a preparatory step for getting rid of pxa_ssp_request()/free() which we will do in the next patch. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx-pci.c | 86 +++--- 1 file changed, 30 insertions(+), 56

[PATCH 04/11] spi/pxa2xx: embed the ssp_device to platform data

2013-01-07 Thread Mika Westerberg
->port_id instead of platform device id. This way the supporting code that passes the ssp can decide the number (or it can set it to the same as pdev->id). Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx-pci.c | 73 +++- drivers/spi/spi-px

[PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-07 Thread Mika Westerberg
stubbed out on architectures where clk framework is not available. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx-pci.c |1 + drivers/spi/spi-pxa2xx.c | 28 +++- include/linux/spi/pxa2xx_spi.h | 19 +-- 3 files changed, 21 in

[PATCH 01/11] spi/pxa2xx: allow building on a 64-bit kernel

2013-01-07 Thread Mika Westerberg
different size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:34: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/spi/spi-pxa2xx.c:1572:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Mika Westerberg

[PATCH 08/11] spi/pxa2xx: add support for runtime PM

2013-01-07 Thread Mika Westerberg
Drivers should put the device into low power states proactively whenever the device is not in use. Thus implement support for runtime PM and use the autosuspend feature to make sure that we can still perform well in case we see lots of SPI traffic within short period of time. Signed-off-by: Mika

[PATCH 10/11] spi/pxa2xx: add support for Intel Low Power Subsystem SPI

2013-01-07 Thread Mika Westerberg
d a new type LPSS_SSP that can be used to distinguish the LPSS devices from others. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 148 ++-- include/linux/pxa2xx_ssp.h |9 +++ include/linux/spi/pxa2xx_spi.h |1 + 3 files chan

[PATCH 02/11] spi/pxa2xx: convert to the pump message infrastructure

2013-01-07 Thread Mika Westerberg
The SPI core provides infrastructure for standard message queueing so use that instead of handling everything in the driver. This simplifies the driver. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 212 +++--- 1 file changed, 12

[PATCH 00/11] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-01-07 Thread Mika Westerberg
o be consistent with the original style instead. Let me know if it is not acceptable and I'll change them. The series is based on 3.8-rc2. Mika Westerberg (11): spi/pxa2xx: allow building on a 64-bit kernel spi/pxa2xx: convert to the pump message infrastructure spi/pxa2xx-pci:

[PATCH 11/11] spi/pxa2xx: add support for Lynxpoint SPI controllers

2013-01-07 Thread Mika Westerberg
Intel Lynxpoint PCH Low Power Subsystem has two general purpose SPI controllers that are LPSS_SSP compatible. These controllers are enumerated from ACPI namespace with ACPI IDs INT33C0 and INT33C1. Signed-off-by: Mika Westerberg --- drivers/spi/Kconfig |2 +- drivers/spi/spi-pxa2xx.c

[PATCH 06/11] spi/pxa2xx: use the private DMA API only when CONFIG_ARCH_PXA is set

2013-01-07 Thread Mika Westerberg
we can kill the dummy DMA bits in pxa2xx_spi.h as they are not needed anymore for CE4100. Once this is done we can add the generic DMA engine support to the driver that allows usage of any DMA controller that implements DMA engine API. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c

[PATCH 07/11] spi/pxa2xx: add support for DMA engine

2013-01-07 Thread Mika Westerberg
. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 351 +++- include/linux/spi/pxa2xx_spi.h |6 + 2 files changed, 350 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 2e17679..9b438ad

Re: [PATCH 01/11] spi/pxa2xx: allow building on a 64-bit kernel

2013-01-08 Thread Mika Westerberg
On Tue, Jan 08, 2013 at 11:27:45AM +0800, Eric Miao wrote: > On Mon, Jan 7, 2013 at 6:44 PM, Mika Westerberg > wrote: > > In addition fix following warnings seen when compiling 64-bit: > > > > drivers/spi/spi-pxa2xx.c: In function ‘map_dma_buffers’: > > drivers/s

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-08 Thread Mika Westerberg
On Tue, Jan 08, 2013 at 11:02:28AM +, Mark Brown wrote: > On Mon, Jan 07, 2013 at 12:44:34PM +0200, Mika Westerberg wrote: > > If the architecture doesn't support clk framework (like x86) we need a way > > to > > pass the SSP clock rate to the driver. This

[PATCH] HID: i2c-hid: add ACPI support

2013-01-08 Thread Mika Westerberg
The HID over I2C protocol specification states that when the device is enumerated from ACPI the HID descriptor address can be obtained by executing "_DSM" for the device with function 1. Enable this. Signed-off-by: Mika Westerberg --- drivers/hid/i2c-hid/i2c-hi

Re: [PATCH] HID: i2c-hid: add ACPI support

2013-01-08 Thread Mika Westerberg
On Tue, Jan 08, 2013 at 02:51:53PM +0100, Benjamin Tissoires wrote: > Hi Mika, > > On Tue, Jan 8, 2013 at 2:05 PM, Mika Westerberg > wrote: > > The HID over I2C protocol specification states that when the device is > > enumerated from ACPI the HID descriptor ad

Re: [PATCH] HID: i2c-hid: add ACPI support

2013-01-09 Thread Mika Westerberg
On Tue, Jan 08, 2013 at 10:55:59PM +0100, Benjamin Tissoires wrote: > On Tue, Jan 8, 2013 at 7:09 PM, Mika Westerberg > wrote: > > On Tue, Jan 08, 2013 at 02:51:53PM +0100, Benjamin Tissoires wrote: > >> Hi Mika, > >> > >> On Tue, Jan 8, 2013 at 2:05 PM,

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-09 Thread Mika Westerberg
On Tue, Jan 08, 2013 at 10:33:55PM +0100, Rafael J. Wysocki wrote: > On 1/8/2013 2:10 PM, Mark Brown wrote: > >On Tue, Jan 08, 2013 at 02:41:53PM +0200, Mika Westerberg wrote: > >>On Tue, Jan 08, 2013 at 11:02:28AM +, Mark Brown wrote: > >>>No, the way to do th

Re: [PATCH] HID: i2c-hid: add ACPI support

2013-01-09 Thread Mika Westerberg
t; Also, I missed one point in my previous review: > >> > >> > > >> >> Please note that I can only compare this to my patch, based on the > >> >> DSDT example Microsoft gave in its spec. So sorry if I'm asking > >> &g

[PATCH v2] HID: i2c-hid: add ACPI support

2013-01-09 Thread Mika Westerberg
The HID over I2C protocol specification states that when the device is enumerated from ACPI the HID descriptor address can be obtained by executing "_DSM" for the device with function 1. Enable this. Signed-off-by: Mika Westerberg --- Changes to previous version: * platfo

Re: [resend][PATCH 01/16] dw_dmac: call .probe after we have a device in place

2013-01-09 Thread Mika Westerberg
On Wed, Jan 09, 2013 at 07:38:48AM -0800, Vinod Koul wrote: > On Wed, Jan 09, 2013 at 04:56:45PM +0200, Andy Shevchenko wrote: > > On Wed, Jan 9, 2013 at 3:47 PM, Vinod Koul wrote: > > > On Wed, Jan 09, 2013 at 10:17:00AM +0200, Andy Shevchenko wrote: > > >> If we don't yet have the platform devic

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Wed, Jan 09, 2013 at 11:07:26PM +0100, Rafael J. Wysocki wrote: > We hardcode different kinds of information into the kernel anyway, but it > would be good to be able to use some criteria to decide whether or not we need > that information on the given system. > > In this particular case, we'll

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Wed, Jan 09, 2013 at 10:52:12PM +0100, Rafael J. Wysocki wrote: > > > Other problem is that this setup needs manual maintenance as we can't get > > the configuration from ACPI. > > So we just happen to know what the rate is supposed to be? What's the source > of that information? We get it f

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Thu, Jan 10, 2013 at 11:58:03AM +0200, Mika Westerberg wrote: > On Wed, Jan 09, 2013 at 11:07:26PM +0100, Rafael J. Wysocki wrote: > > We hardcode different kinds of information into the kernel anyway, but it > > would be good to be able to use some criteria to decide wh

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Thu, Jan 10, 2013 at 12:51:59PM +, Mark Brown wrote: > On Thu, Jan 10, 2013 at 01:54:41PM +0100, Rafael J. Wysocki wrote: > > On Thursday, January 10, 2013 02:38:37 PM Mika Westerberg wrote: > > > > 3. We make the acpi_create_platform_device() match on, lets say &

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Thu, Jan 10, 2013 at 01:54:41PM +0100, Rafael J. Wysocki wrote: > > > > I'm not sure about the LPSS PCI case. Maybe we can forget that for now > > (except the CE4100 case which obviously must work)? Or add similar quirk to > > the PCI side that creates the platform device for clocks. > > I wou

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Thu, Jan 10, 2013 at 02:23:25PM +0100, Rafael J. Wysocki wrote: > On Thursday, January 10, 2013 03:07:40 PM Mika Westerberg wrote: > > On Thu, Jan 10, 2013 at 12:51:59PM +, Mark Brown wrote: > > > On Thu, Jan 10, 2013 at 01:54:41PM +0100, Rafael J. Wysocki wrote: &

<    1   2   3   4   5   6   7   8   9   10   >