On Fri, May 09, 2014 at 12:27:12PM +0100, Mark Brown wrote:
> On Fri, May 09, 2014 at 02:21:05PM +0300, Mika Westerberg wrote:
> > On Fri, May 09, 2014 at 11:33:15AM +0100, Mark Brown wrote:
>
> > > Is this definitely the case for all of the IPs using this driver? It
>
me data also in case of
> ACPI. The frequency is the same.
>
> Signed-off-by: Heikki Krogerus
No objections from me,
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.o
On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki wrote:
> > 2014-04-09 23:09 GMT+02:00 Josh Boyer :
> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
> >> module on the MacBookPro 10,2 I have here. This works fine wit
On Thu, Apr 10, 2014 at 08:47:23PM +0200, Linus Walleij wrote:
> On Thu, Apr 10, 2014 at 2:40 PM, Mika Westerberg
> wrote:
> > On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
> >> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki wrote:
> >> > 2014
On Mon, Mar 24, 2014 at 04:49:44PM +0100, Sabrina Dubroca wrote:
> Hi,
>
> With next-20140324, I get the BUG below when I modprobe ssb.
> I bisected it to aa92b6f689ac
> "gpio / ACPI: Allocate ACPI specific data directly in acpi_gpiochip_add()"
>
> The device that needs ssb is:
> 0c:00.0 Network
On Mon, Mar 24, 2014 at 08:00:33PM +0200, Mika Westerberg wrote:
> On Mon, Mar 24, 2014 at 04:49:44PM +0100, Sabrina Dubroca wrote:
> > Hi,
> >
> > With next-20140324, I get the BUG below when I modprobe ssb.
> > I bisected it to aa92b6f689ac
> > "gpio / ACPI
On Mon, Mar 24, 2014 at 07:31:11PM +0100, Sabrina Dubroca wrote:
> > Actually gpiolib seems to handle ->dev as optional. Can you try this patch
> > instead? Thanks.
> >
> > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > index bf0f8b476696..642b2bf3360e 100644
> > --- a/
; + { },
> +};
> +MODULE_DEVICE_TABLE(acpi, pwm_lpss_acpi_match);
> +
> +static struct platform_driver pwm_lpss_driver_platform = {
> .driver = {
> .name = "pwm-lpss",
> .acpi_match_table = pwm_lpss_acpi_match,
> },
> - .p
On Mon, Apr 14, 2014 at 02:05:25AM +, Chew, Chiau Ee wrote:
> > > MODULE_DESCRIPTION("PWM driver for Intel LPSS");
> > >MODULE_AUTHOR("Mika
> > > Westerberg ");
> > > MODULE_LICENSE("GPL v2");
> > > MODULE_ALIAS(&quo
On Tue, Apr 15, 2014 at 08:41:02AM +, Chew, Chiau Ee wrote:
>
>
> > > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
> > > + struct resource *r, struct pwm_lpss_boardinfo *info)
> > > {
> > > struct pwm_lpss_chip *lpwm;
> > > - struct resource *r;
> > >
On Tue, Jun 17, 2014 at 02:02:01PM -0700, Benson Leung wrote:
> Add support for the trackpad on HP Chromebook 14.
>
> Signed-off-by: Benson Leung
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
on these patches from the chromeos-3.8 kernel:
> https://chromium-review.googlesource.com/#/c/65320/
> https://chromium-review.googlesource.com/#/c/174664/
>
> Signed-off-by: Mohammed Habibulla
> Signed-off-by: Benson Leung
Reviewed-by: Mika Westerberg
--
To unsubscribe from th
from the chromeos-3.8 kernel:
> https://chromium-review.googlesource.com/168351
> https://chromium-review.googlesource.com/173445
>
> Signed-off-by: Gene Chen
> Signed-off-by: Benson Leung
> Tested-by: Scot Doyle
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send
enable PCI mode
> host pass in the clock rate information.
>
> Signed-off-by: Chew, Chiau Ee
> Acked-by: Kweh, Hock Leong
Looks reasonable,
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord..
the functions available to GPIO chip drivers via private gpiolib.h,
just in case generic irqchip helpers are not suitable.
Signed-off-by: Mika Westerberg
---
drivers/gpio/gpiolib-acpi.c | 38 --
drivers/gpio/gpiolib.c | 4
drivers/gpio/gpiolib.h
Hi,
As discussed in this thread:
https://www.mail-archive.com/linux-gpio%40vger.kernel.org/msg02929.html
This series converts the Intel Lynxpoint and Baytrail GPIO drivers to use
the new irqchip helper functions and then moves ACPI event registration to
happen in the helpers as well.
Mika
Instead of open-coding irqchip handling in the driver we can take advantage
of the new irqchip helpers provided by the gpiolib core.
While doing this we also make sure that we call gpiochip_irqchip_add()
after the gpiochip itself is registered as required.
Signed-off-by: Mika Westerberg
Instead of open-coding irqchip handling in the driver we can take advantage
of the new irqchip helpers provided by the gpiolib core.
While doing this we also make sure that we call gpiochip_irqchip_add()
after the gpiochip itself is registered as required.
Signed-off-by: Mika Westerberg
On Thu, Jul 24, 2014 at 05:06:20PM +0300, Mika Westerberg wrote:
> > On a related note, there seems to be a bug in this driver, which
> > attempts to set the slave_id through dmaengine_slave_config(), which
> > is wrong in both cases, ACPI and filter functions.
>
> Good
On Fri, Jul 25, 2014 at 09:58:42AM +0200, Arnd Bergmann wrote:
> On Friday 25 July 2014 10:11:38 Mika Westerberg wrote:
> > On Thu, Jul 24, 2014 at 05:06:20PM +0300, Mika Westerberg wrote:
> > > > On a related note, there seems to be a bug in this driver, which
> > >
On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote:
> On Friday 25 July 2014 11:22:49 Mika Westerberg wrote:
> > > All you need to do is change your filter function to take the
> > > slave id from pxa_spi_info and stick it in there, e.g.
> > >
> > &g
On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote:
> On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote:
> > On Friday 25 July 2014 11:22:49 Mika Westerberg wrote:
> > > > All you need to do is change your filter function to take the
> > > &g
On Fri, Jul 25, 2014 at 12:19:02PM +0200, Arnd Bergmann wrote:
> On Friday 25 July 2014 12:55:59 Mika Westerberg wrote:
> > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote:
> > > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote:
> > > > O
On Thu, Apr 17, 2014 at 02:18:58AM +0800, Chew Chiau Ee wrote:
> From: Alan Cox
>
> Not all systems enumerate the PWM devices via ACPI. They can also be exposed
> via the PCI interface.
>
> Signed-off-by: Alan Cox
> Signed-off-by: Chew, Chiau Ee
Reviewed-by: M
h. Reported by
> Lan Tianyu, Fixed by Lv Zheng.
>
> Signed-off-by: Lv Zheng
> Signed-off-by: Lan Tianyu
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
On Tue, Apr 22, 2014 at 02:24:08PM +0800, Lan Tianyu wrote:
> The acpi_buffer_to_resource is needed in i2c module
> to convert aml buffer to struct acpi_resource
>
> Signed-off-by: Lan Tianyu
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubsc
handle));
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(acpi_bus_attach_private_data);
When I added GPIO operation region support, Rafael mentioned that we might
want to add this private data to the struct acpi_devi
On Tue, Apr 22, 2014 at 02:24:10PM +0800, Lan Tianyu wrote:
> Use acpi_bus_attach_private_data() to attach private data
> instead of acpi_attach_data().
>
> Signed-off-by: Lan Tianyu
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe lin
On Tue, Apr 22, 2014 at 02:24:11PM +0800, Lan Tianyu wrote:
> Add i2c_smbus_quick_write/read() helper function. These will be used
> in the implementation of i2c ACPI address space handler.
>
> Signed-off-by: Lan Tianyu
Reviewed-by: Mika Westerberg
--
To unsubscribe from this li
On Tue, Apr 22, 2014 at 02:24:12PM +0800, Lan Tianyu wrote:
> Add i2c_smbus_word/block_proc_call() helper function. These will be used
> in the implementation of i2c ACPI address space handler.
>
> Signed-off-by: Lan Tianyu
Reviewed-by: Mika Westerberg
--
To unsubscribe from thi
On Tue, Apr 22, 2014 at 02:24:13PM +0800, Lan Tianyu wrote:
> diff --git a/drivers/i2c/i2c-acpi.c b/drivers/i2c/i2c-acpi.c
> new file mode 100644
> index 000..942abdf
> --- /dev/null
> +++ b/drivers/i2c/i2c-acpi.c
> @@ -0,0 +1,282 @@
> +/*
> + * I2C ACPI code
> + *
> + * Copyright (C) 2014 Inte
oid acpi_i2c_register_devices(struct i2c_adapter *adap) {};
Semicolon is not needed here.
Apart from that,
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, Apr 22, 2014 at 02:24:15PM +0800, Lan Tianyu wrote:
> This patch is to add CONFIG_I2C_ACPI. Current there is a race between
> removing I2C ACPI operation region and ACPI AML code accessing.
> So make i2c core built-in if CONFIG_I2C_ACPI is set.
>
> Signed-off-by: Lan Tianyu
> ---
> drive
On Fri, Apr 18, 2014 at 07:17:40PM +0800, Chew Chiau Ee wrote:
> From: Alan Cox
>
> Not all systems enumerate the PWM devices via ACPI. They can also be exposed
> via the PCI interface.
>
> Signed-off-by: Alan Cox
> Signed-off-by: Chew, Chiau Ee
Reviewed-by: M
On Wed, Apr 16, 2014 at 08:05:59PM +0800, Jin Yao wrote:
> A crash is triggered on the ASUS T100TA Baytrail-T because of a irq
> descriptor conflict. There are two gpio triggered acpi events in this
> device, GPIO 6 and 18. These gpios are translated to irqs by calling
> gpio_to_irq which in turn
On Fri, Apr 18, 2014 at 05:30:54PM +0100, Mark Brown wrote:
> On Fri, Apr 18, 2014 at 12:26:07AM +0800, Chew Chiau Ee wrote:
> > From: Chew, Chiau Ee
> >
> > Intel BayTrail PCI mode LPSS devices inclusive of SPI do not rely
> > on common clock framework. Thus, this patch allows the PCI mode
> > S
On Tue, Apr 22, 2014 at 01:09:48PM +0100, Mark Brown wrote:
> On Tue, Apr 22, 2014 at 02:57:17PM +0300, Mika Westerberg wrote:
> > On Fri, Apr 18, 2014 at 05:30:54PM +0100, Mark Brown wrote:
>
> > > As you mention we already have a clock API for passing around
> > >
ed with the introduction of gpiochip_request_own_desc
> and gpiochip_free_own_desc.
>
> Export both function so they can be used from modules and from
> platform initialization code.
>
> Cc: Mika Westerberg
Looks good to me, thanks.
Reviewed-by: Mika Westerberg
--
To unsubscribe fro
On Thu, Jul 24, 2014 at 01:42:10PM +0200, Arnd Bergmann wrote:
> On Thursday 24 July 2014 18:01:51 Kweh Hock Leong wrote:
> > From: "Chew, Chiau Ee"
> >
> > Intel LPSS Baytrail supports two DMA controllers and SPI is only
> > using one of the DMA controller. During DMA channel request,
> > we nee
On Fri, Jun 06, 2014 at 02:32:14PM +0200, Wolfram Sang wrote:
> Mika: Your review for ACPI specific details would be much appreciated
> here.
Sure. Srinivas, is this the latest version of the patch series?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
On Sat, Jun 07, 2014 at 12:48:13AM +0200, Rafael J. Wysocki wrote:
> Do I believe correctly that you have reviewed this patch already?
Yes, I did :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
pecific name in turn, until locating the expected hardware.
>
> Signed-off-by: Scot Doyle
> CC: Benson Leung
> CC: Mika Westerberg
I don't have anything against this approach.
One comment though, if you happen to have two devices with the same
address but in different buses th
On Thu, Apr 10, 2014 at 09:15:16PM -0700, Srinivas Pandruvada wrote:
> ACPI specification allows multiple i2c addresses defined under one
> ACPI device object. These addresses are defined using _CRS method.
> The current implementation will pickup the last entry in _CRS, and
> create an i2C device,
t; as appropriate.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=76901
> Fixes: 2d8b1d566a5f (ACPI / hotplug / PCI: Get rid of check_sub_bridges())
> Reported-and-tested-by: Gavin Guo
> Cc: 3.15+ # 3.15+
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Mika Westerberg
Thanks
pecific name in turn, until locating the expected hardware.
>
> Thanks to Mika Westerberg for identifying the need for unique bus addresses
> within each set of identically-named adapters.
>
> Signed-off-by: Scot Doyle
> CC: Benson Leung
> CC: Mika Westerberg
Few comments
On Tue, Jun 10, 2014 at 08:09:22AM -0700, Srinivas Pandruvada wrote:
> On 06/10/2014 02:24 AM, Mika Westerberg wrote:
> >On Thu, Apr 10, 2014 at 09:15:16PM -0700, Srinivas Pandruvada wrote:
> >>ACPI specification allows multiple i2c addresses defined under one
> >&g
d-off-by: Chew, Chiau Ee
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
p_request/free_interrupts().
Reported-by: Sabrina Dubroca
Signed-off-by: Mika Westerberg
---
Sabrina,
Can you please re-test this and provide your tested-by? I changed the patch
a bit to remove redundant checks. Just to be sure that I don't accidentally
break something.
Thanks.
driver
irst before
shift.
Reported-by: Dan Carpenter
Signed-off-by: Mika Westerberg
---
drivers/gpio/gpiolib-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index d5be56fe689e..401add28933f 100644
--- a/drivers/gpio/gp
On Wed, May 21, 2014 at 01:22:36PM +0800, Zhu, Lejun wrote:
> Devices based on Intel SoC products such as Baytrail have a Power
> Management IC. In the PMIC there are subsystems for voltage regulation,
> A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called
> Crystal Cove.
>
> T
On Thu, May 15, 2014 at 02:44:12PM +0800, Zhang Rui wrote:
> The new ACPI device enumeration mechanism, which will be introduced
> in a later patch, will enumerate the _HID devices w/o any scan
> handler attached to platform bus.
> This means that, for the devices that are attached to a configurabl
On Thu, May 15, 2014 at 02:44:14PM +0800, Zhang Rui wrote:
> For some ACPI device objects, they represent master devices,
> and their children devices are enumerated by bus controller drivers
> for the buses they are on.
>
> In this case, we do not want to enumerate their children devices to
> pla
On Wed, May 21, 2014 at 01:10:33PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, May 21, 2014 11:52:07 AM Mika Westerberg wrote:
> > On Thu, May 15, 2014 at 02:44:14PM +0800, Zhang Rui wrote:
> > > For some ACPI device objects, they represent master devices,
> > > and
On Wed, May 21, 2014 at 11:09:42PM +0800, Zhang Rui wrote:
> On 三, 2014-05-21 at 13:10 +0200, Rafael J. Wysocki wrote:
> > On Wednesday, May 21, 2014 11:52:07 AM Mika Westerberg wrote:
> > > On Thu, May 15, 2014 at 02:44:14PM +0800, Zhang Rui wrote:
> > > > For
On Wed, May 21, 2014 at 10:43:07PM +0800, Zhang Rui wrote:
> On 三, 2014-05-21 at 11:52 +0300, Mika Westerberg wrote:
> > On Thu, May 15, 2014 at 02:44:14PM +0800, Zhang Rui wrote:
> > > For some ACPI device objects, they represent master devices,
> > > and their childre
On Wed, May 21, 2014 at 10:56:59PM +0800, Zhang Rui wrote:
> On 三, 2014-05-21 at 11:48 +0300, Mika Westerberg wrote:
> > On Thu, May 15, 2014 at 02:44:12PM +0800, Zhang Rui wrote:
> > > The new ACPI device enumeration mechanism, which will be introduced
> > > in a late
On Thu, May 15, 2014 at 02:44:15PM +0800, Zhang Rui wrote:
> +static void acpi_do_default_enumeration(struct acpi_device *device)
> +{
> + /*
> + * Do not do enumeration for device object that has been/will be
> + * enumerated by its parent.
> + */
> + if (device->parent && d
arent;
> +
> + cg = devm_kzalloc(&pdev->dev, sizeof(*cg), GFP_KERNEL);
> + if (!cg) {
A minor comment here:
return -ENOMEM;
> + retval = -ENOMEM;
> + goto out;
> + }
Other than that this looks good to me,
Reviewed-by: Mika Westerberg
On Thu, May 22, 2014 at 11:50:00PM +0200, Linus Walleij wrote:
> On Thu, May 15, 2014 at 5:28 PM, Mika Westerberg
> wrote:
>
> > From: Jin Yao
> >
> > Now that the x86 dynamic IRQ allocation problem has been resolved with
> > commmit 62a08ae2a576 (genirq: x86: E
On Fri, May 23, 2014 at 02:02:32AM +0800, Zhang Rui wrote:
> Because of the growing demand for enumerating ACPI devices to
> platform bus, this patch changes the code to enumerate ACPI
> devices to platform bus by default, if the device
> 1. has _HID.
> 2. does not have a scan handler attached.
> 3
On Fri, May 23, 2014 at 02:02:30AM +0800, Zhang Rui wrote:
> The new ACPI device enumeration mechanism, which will be introduced
> in a later patch, will enumerate the _HID devices w/o any scan
> handler attached to platform bus.
> This means that, for the devices that are attached to a configurabl
On Mon, May 26, 2014 at 01:53:39PM +0200, Rafael J. Wysocki wrote:
> > I'm wondering whether it is worth the ugliness to get platform bus
> > enumeration the default?
> >
> > Since you already have the PNP whitelist, can't we just use that for PNP
> > and keep these files as they are? In other wor
On Mon, May 26, 2014 at 02:40:58PM +0200, Rafael J. Wysocki wrote:
> On Monday, May 26, 2014 02:52:35 PM Mika Westerberg wrote:
> > On Mon, May 26, 2014 at 01:53:39PM +0200, Rafael J. Wysocki wrote:
> > > > I'm wondering whether it is worth the ugliness to get platform b
On Tue, May 27, 2014 at 12:24:56PM +0300, Grygorii Strashko wrote:
> >> +
> >> + if (retval) {
> >> + dev_warn(&pdev->dev, "request irq failed: %d\n", retval);
> >> + goto out;
> >> + }
> >> +
> >> + retval = gpiochip_add(&cg->chip);
> >> + if (re
On Tue, May 27, 2014 at 03:04:09PM +0300, Grygorii Strashko wrote:
> Hi Mika,
>
> On 05/27/2014 11:46 AM, Mika Westerberg wrote:
> > On Tue, May 27, 2014 at 12:24:56PM +0300, Grygorii Strashko wrote:
> >>>> +
> >>>> + if (retval) {
> >&g
On Wed, May 28, 2014 at 04:19:55AM +0100, Al Viro wrote:
> On Tue, May 27, 2014 at 10:04:09AM +0300, Mika Westerberg wrote:
> > On Tue, May 27, 2014 at 05:00:26AM +0100, Al Viro wrote:
> > > On Tue, May 27, 2014 at 04:14:15AM +0100, Al Viro wrote:
> > >
> > >
On Wed, May 28, 2014 at 12:57:01PM +0100, Al Viro wrote:
> On Wed, May 28, 2014 at 10:37:51AM +0300, Mika Westerberg wrote:
>
> > I sent you the whole log privately so that I don't spam everyone.
> >
> > Summary is here:
> >
> > May 28 10:24:23 l
On Thu, May 29, 2014 at 01:51:07PM +0300, Mika Westerberg wrote:
> On Thu, May 29, 2014 at 06:34:44AM +0100, Al Viro wrote:
> > On Thu, May 29, 2014 at 04:52:33AM +0100, Al Viro wrote:
> > > On Thu, May 29, 2014 at 04:11:49AM +0100, Al Viro wrote:
> > > > On Wed, Ma
On Thu, May 29, 2014 at 02:30:36PM +0100, Al Viro wrote:
> On Thu, May 29, 2014 at 02:04:39PM +0300, Mika Westerberg wrote:
>
> > With your both patches applied the problem is gone :-)
> >
> > I did 20 plug/unplugs, rebooted the machine and another 20 plug/unplugs
> &g
On Thu, May 29, 2014 at 03:37:37PM +0200, Linus Walleij wrote:
> My idea is that you should call gpiochip_add() *first* and then
> add the IRQs to the chip. In succession.
>
> Rationale: with dynamic GPIO numbers, gpio_to_irq()
> cannot reasonably be working before the gpiochip is added,
> so it s
t != dentry)
> spin_lock(&dentry->d_lock);
> else
> parent = NULL;
> return parent;
> }
>
> That variant got force-pushed in place of the previous one, again at the
> head of #for-linus. And I'm definitely not foldi
On Thu, May 29, 2014 at 05:22:05PM +0200, Linus Walleij wrote:
> On Thu, May 29, 2014 at 6:03 PM, Grygorii Strashko
> wrote:
>
> > Also, I'd like to note that GPIO IRQs can be accessible not only
> > when GPIO chips is added, but also when IRQ domain is registered
> > (at least it's valid for DT
> It is mostly based on your patches, but reordered and with some major
> changes. Compiled only for now, so please let me know if there's any
> breakage in it. [The last patch will not apply without update of the
> device list being removed, but generally this is on top of linux-
On Tue, May 27, 2014 at 12:26:44PM -0700, eric.er...@linux.intel.com wrote:
> From: Eric Ernst
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode. When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not
On Mon, Jun 02, 2014 at 06:12:34PM +0200, Wolfram Sang wrote:
> On Thu, May 15, 2014 at 05:37:21PM +0300, Mika Westerberg wrote:
> > If the controller is already in desired state (enabled/disabled) there is
> > no point in setting its state again.
> >
> > Sig
On Mon, Jun 02, 2014 at 11:35:16AM -0700, eric ernst wrote:
> On 14-05-30 01:48 AM, Mika Westerberg wrote:
> >On Tue, May 27, 2014 at 12:26:44PM -0700, eric.er...@linux.intel.com wrote:
> >>From: Eric Ernst
> >>
> >>For Baytrail, you should never set a GPIO
On Mon, Jun 02, 2014 at 10:13:22PM +0300, Mika Westerberg wrote:
> On Mon, Jun 02, 2014 at 11:35:16AM -0700, eric ernst wrote:
> > On 14-05-30 01:48 AM, Mika Westerberg wrote:
> > >On Tue, May 27, 2014 at 12:26:44PM -0700, eric.er...@linux.intel.com wrote:
> > >>From
On Tue, Jun 03, 2014 at 10:10:13AM +0200, Linus Walleij wrote:
> On Fri, May 30, 2014 at 10:25 AM, Mika Westerberg
> wrote:
>
> > I'm thinking that could we solve this so that we call
> > acpi_gpiochip_request_interrupts() at the end of gpiochip_irqchip_add()
&g
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote:
> From: Eric Ernst
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode. When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not
On Tue, Jun 03, 2014 at 01:26:02PM +0800, Zhu, Lejun wrote:
> This patch provides the common I2C driver code for Intel SoC PMICs.
>
> Signed-off-by: Yang, Bin
> Signed-off-by: Zhu, Lejun
Looks good to me,
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: s
ed-off-by: Zhu, Lejun
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, Jun 02, 2014 at 02:12:07PM -0700, eric.er...@linux.intel.com wrote:
> + WARN((readl(conf_reg) & BYT_DIRECTIRQ),
> + "Potential Error: Setting GPIO with direct_irq_en to output");
Also you don't need parentheses here.
--
To unsubscribe from this list: send the line "unsubscr
code is based on following patch from Benson Leung:
https://patchwork.kernel.org/patch/3074411/
Signed-off-by: Mika Westerberg
Tested-by: Kirill A. Shutemov
Cc: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 45 ++-
1 file changed, 39 insertions(+), 6
d output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst
Looks good now thanks,
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
On Tue, Jun 03, 2014 at 12:46:00PM -0700, Benson Leung wrote:
> Hi Mika!
>
> Thanks for putting this patch together. It looks like this does the
> job of distinguishing the two busses apart. Thanks!
>
>
> On Tue, Jun 3, 2014 at 6:02 AM, Mika Westerberg
> wrote:
> &
On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote:
> > Currently this is a helper function for the I2C subsystem to aid the
> > matching of non-standard compatible strings and devices which use DT
> > and/or ACPI, but do not
On Wed, Jun 04, 2014 at 02:28:20PM +0100, Lee Jones wrote:
> On Wed, 04 Jun 2014, Mika Westerberg wrote:
> > On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote:
> > > > Currently this is
x27;" :
> 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 02 02
>
> Signed-off-by: Chew, Chiau Ee
> Cc: Mika Westerberg
Works for me (and individual chips can tune this by passing custom
dma_burst_size if needed).
Acked-by: Mika Westerberg
--
To unsubscribe from this l
On Thu, Jun 12, 2014 at 03:27:01PM +0200, Oliver Neukum wrote:
> I am looking at the patch set you posted for making
> the touchpad of those laptops work. Has anything happened
> regarding i2c so that the patches can go upstream?
Benson promised to send out the whole series once 3.16-rc1 is releas
On Mon, Jan 27, 2014 at 10:36:25PM -0500, Benjamin Tissoires wrote:
> On Tue, Jan 14, 2014 at 5:13 AM, Mika Westerberg
> wrote:
> > This patch adds runtime PM support for the HID over I2C driver. When the
> > i2c-hid device is first opened we power it on and on the last close w
On Mon, Jan 27, 2014 at 12:20:02PM +0200, Mika Westerberg wrote:
> On Sat, Jan 25, 2014 at 01:09:23AM -0800, Bin Gao wrote:
> > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index
> > > a3acbac2ee72$
> > > --- a/arch/x86/kernel/tsc.c
>
On Tue, Jan 28, 2014 at 07:30:35PM +0100, Wolfram Sang wrote:
> On Tue, Jan 28, 2014 at 01:48:28PM +0800, xinhui.pan wrote:
> > From: "xinhui.pan"
> >
> > i2c_dw_pci_runtime_idle should return -EBUSY rather than zero if it do
> > success.
>
> I don't understand...
>
> > Otherwise rpm_idle will
On Tue, Jan 28, 2014 at 09:19:33AM -0500, Benjamin Tissoires wrote:
> On Tue, Jan 28, 2014 at 4:12 AM, Mika Westerberg
> wrote:
> > On Mon, Jan 27, 2014 at 10:36:25PM -0500, Benjamin Tissoires wrote:
> >> On Tue, Jan 14, 2014 at 5:13 AM, Mika Westerberg
> >> wrote:
with devices that are not wake capable.
Signed-off-by: Mika Westerberg
---
v2:
- Update changelog to mention that ACPI power domain for example can
power off the device on suspend.
- Make i2c_hid_power to just call RPM get/put
drivers/hid/i2c-hid/i2c-hid.c | 68
On Wed, Jan 29, 2014 at 06:00:26PM +0800, xinhui.pan wrote:
>
>
> 于 2014年01月29日 16:35, Mika Westerberg 写道:
> > On Tue, Jan 28, 2014 at 07:30:35PM +0100, Wolfram Sang wrote:
> >> On Tue, Jan 28, 2014 at 01:48:28PM +0800, xinhui.pan wrote:
On Wed, Jan 29, 2014 at 09:57:00AM -0500, Benjamin Tissoires wrote:
> That's great. I hope this will also fix my Lenovo Miix 2 (the T100 is
> too expensive compared to the Dell Venue pro 8 and the Lenovo one) :)
> I think most of my problems are ACPI related (WIFI card not powered
> up, SD-ext read
On Wed, Jan 29, 2014 at 01:00:57AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Use the observation that the ACPI scan handler of the device object
> in acpi_hotplug_notify_cb() can be obtained from that device object's
> handler pointer and do not pass it as data to
> acpi_insta
On Fri, Jan 31, 2014 at 04:42:21PM +0100, Rafael J. Wysocki wrote:
> On Friday, January 31, 2014 05:28:36 PM Mika Westerberg wrote:
> > On Wed, Jan 29, 2014 at 01:00:57AM +0100, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki
> > >
> > > Use the obser
On Fri, Jan 31, 2014 at 05:40:11PM +0200, Mika Westerberg wrote:
> On Fri, Jan 31, 2014 at 04:42:21PM +0100, Rafael J. Wysocki wrote:
> > On Friday, January 31, 2014 05:28:36 PM Mika Westerberg wrote:
> > > On Wed, Jan 29, 2014 at 01:00:57AM +0100, Rafael J. Wysocki wrote:
>
On Fri, Jan 31, 2014 at 05:16:03PM +0100, Rafael J. Wysocki wrote:
> On Friday, January 31, 2014 06:01:57 PM Mika Westerberg wrote:
> > On Fri, Jan 31, 2014 at 05:40:11PM +0200, Mika Westerberg wrote:
> > > On Fri, Jan 31, 2014 at 04:42:21PM +0100, Rafael J. Wysocki wrote:
1201 - 1300 of 2936 matches
Mail list logo
