Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

2017-08-16 Thread Michal Suchánek
On Tue, 15 Aug 2017 18:02:57 -0400 Ken Goldman wrote: > On 8/13/2017 7:53 PM, msuchanek wrote: > > About 500 out of 700 mainboards sold today has a PS/2 port which is > > probably due to prevalence of legacy devices and usbhid limitations. > > > > Similarily many boards have serial and parallel

Re: [PATCH 5/5] Use __func__ instead of function name

2017-08-18 Thread Michal Suchánek
On 2017-07-29 09:24, SZ Lin wrote: Fix following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using the function's name, in a string Signed-off-by: SZ Lin --- drivers/char/tpm/tpm_ibmvtpm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-29 Thread Michal Suchánek
On Sun, 28 May 2017 10:55:40 -0700 Dmitry Torokhov wrote: > On Sun, May 28, 2017 at 11:47:58AM +0200, Michal Suchanek wrote: > > On Tue, 9 May 2017 17:43:27 -0700 > > Dmitry Torokhov wrote: > > > > If not then please do your job as maintainer and accept trivial > > patches for perfectly workin

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-30 Thread Michal Suchánek
On Mon, 29 May 2017 22:06:06 -0700 Dmitry Torokhov wrote: > On Mon, May 29, 2017 at 08:03:25PM +0200, Michal Suchánek wrote: > > On Sun, 28 May 2017 10:55:40 -0700 > > Dmitry Torokhov wrote: > > > > > On Sun, May 28, 2017 at 11:47:58AM +0200, Michal Suchanek

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-30 Thread Michal Suchánek
On Tue, 30 May 2017 12:33:21 +0200 Benjamin Tissoires wrote: > Hi Michal, > > On May 30 2017 or thereabouts, Michal Suchánek wrote: > > On Mon, 29 May 2017 22:06:06 -0700 > > Dmitry Torokhov wrote: > > > > > On Mon, May 29, 2017 at 08:03:25PM +0200, Mic

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-30 Thread Michal Suchánek
On Tue, 30 May 2017 14:02:55 +0200 Benjamin Tissoires wrote: > On May 30 2017 or thereabouts, Michal Suchánek wrote: > > On Tue, 30 May 2017 12:33:21 +0200 > > Benjamin Tissoires wrote: > > > > > Hi Michal, > > > > > > On May 30 2017 or ther

Re: Fixing CVE-2017-15361

2017-10-26 Thread Michal Suchánek
On Thu, 26 Oct 2017 13:16:32 +0200 Jarkko Sakkinen wrote: > On Thu, Oct 26, 2017 at 12:26:10AM +0200, Peter Huewe wrote: > > > > > > Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen > > : > > >On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote: > > >> On Wed, Oct 25, 2

Re: Fixing CVE-2017-15361

2017-10-26 Thread Michal Suchánek
On Thu, 26 Oct 2017 16:06:02 +0200 Jarkko Sakkinen wrote: > On Thu, Oct 26, 2017 at 02:59:02PM +0200, Michal Suchánek wrote: > > It does not really matter. People ignore the messages unless looking > > for something specific as you already noticed. Warn seems adequate > >

Re: char-TPM: Adjustments for ten function implementations

2017-10-18 Thread Michal Suchánek
On Wed, 18 Oct 2017 02:18:46 -0700 Joe Perches wrote: > On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote: > > > The printk removals do change the objects. > > > > > > The value of that type of change is only for resource limited > > > systems. > > > > I imagine that such small code

Re: [PATCH 3/5] powerpc-pseries: Delete an unnecessary variable initialisation in iommu_pseries_alloc_group()

2017-10-19 Thread Michal Suchánek
Hello, On Wed, 18 Oct 2017 21:24:25 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Oct 2017 19:14:39 +0200 > > The variable "table_group" will be set to an appropriate pointer. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring

Re: [PATCH 4/5] powerpc-pseries: Return directly after a failed kzalloc_node() in iommu_pseries_alloc_group()

2017-10-19 Thread Michal Suchánek
Hello, On Wed, 18 Oct 2017 21:26:10 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Oct 2017 20:15:32 +0200 > > Return directly after a call of the function "kzalloc_node" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > arch/powerpc/platforms/pseri

Re: [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after error detection

2017-10-19 Thread Michal Suchánek
Hello, On Mon, 16 Oct 2017 19:34:56 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 16 Oct 2017 19:00:34 +0200 > > Two pointer checks could be repeated by the tpm_ibmvtpm_probe() > function during error handling even if the relevant properties can be > determined for the in

Re: char/tpm: Improve a size determination in nine functions

2017-10-19 Thread Michal Suchánek
On Wed, 18 Oct 2017 21:03:13 +0300 Andy Shevchenko wrote: > On Wed, 2017-10-18 at 19:48 +0200, SF Markus Elfring wrote: > > > For 1/4 and 2/4: explain why the message can be omitted. > > > > That's all. > > > > I assume that there might be also some communication challenges > > involved. >

Re: [PATCH 4/5] powerpc-pseries: Return directly after a failed kzalloc_node() in iommu_pseries_alloc_group()

2017-10-19 Thread Michal Suchánek
On Thu, 19 Oct 2017 14:04:43 +0200 SF Markus Elfring wrote: > >> @@ -61,7 +61,7 @@ static struct iommu_table_group > >> *iommu_pseries_alloc_group(int node) table_group = > >> kzalloc_node(sizeof(*table_group), GFP_KERNEL, node); if > >> (!table_group) > >> - goto fail_exit; > >> +

Re: [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after error detection

2017-10-19 Thread Michal Suchánek
On Thu, 19 Oct 2017 14:36:09 +0200 SF Markus Elfring wrote: > >> @@ -683,13 +683,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev > >> *vio_dev, reg_crq_cleanup: > >>dma_unmap_single(dev, ibmvtpm->crq_dma_handle, > >> CRQ_RES_BUF_SIZE, DMA_BIDIRECTIONAL); > >> -cleanup: > >> - if (ibmvtpm)

Re: [PATCH 3/5] powerpc-pseries: Delete an unnecessary variable initialisation in iommu_pseries_alloc_group()

2017-10-19 Thread Michal Suchánek
On Thu, 19 Oct 2017 15:55:59 +0300 Dan Carpenter wrote: > On Thu, Oct 19, 2017 at 01:37:18PM +0200, Michal Suchánek wrote: > > Hello, > > > > On Wed, 18 Oct 2017 21:24:25 +0200 > > SF Markus Elfring wrote: > > > > > From: Markus Elfring &

Re: [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after error detection

2017-10-19 Thread Michal Suchánek
On Thu, 19 Oct 2017 16:36:46 +0300 Dan Carpenter wrote: > On Thu, Oct 19, 2017 at 01:56:32PM +0200, Michal Suchánek wrote: > > > > I think a single cleanup section is better than many labels that > > just avoid a single null check. > > > > I am not a big adv

Re: Regression: 18996f2db918 ("ACPICA: Events: Stop unconditionally clearing ACPI IRQs during suspend/resume" breaks resume from suspend

2018-08-21 Thread Michal Suchánek
On Tue, 21 Aug 2018 08:50:36 +0200 "Rafael J. Wysocki" wrote: > On Mon, Aug 20, 2018 at 6:29 PM Michal Suchánek > wrote: > > > > Hello, > > > > after commit 18996f2db918 ("ACPICA: Events: Stop unconditionally > > clearing ACPI IRQs during susp

Re: [PATCH] selftests/vm: Fix test for virtual address range mapping for arm64

2017-05-15 Thread Michal Suchánek
On Mon, 15 May 2017 09:31:49 +0530 Anshuman Khandual wrote: > On 05/10/2017 12:30 AM, Michal Suchanek wrote: > > Arm64 has 256TB address space so fix the test to pass on Arm as > > well. > > > > Also remove unneeded numaif include. > > > > Signed-off-by: Michal Suchanek > > --- > > tools/test

Re: [PATCH resend 3/6] cdrom: wait for tray to close

2018-01-31 Thread Michal Suchánek
On Mon, 29 Jan 2018 17:05:47 + Bart Van Assche wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > +static int cdrom_tray_close(struct cdrom_device_info *cdi) > > +{ > > + int ret; > > + > > + ret = cdi->ops->tray_move(cdi, 0); > > + if (ret || !cdi->ops->drive_status

Re: [PATCH resend 0/6] Fix cdrom autoclose

2018-01-27 Thread Michal Suchánek
On Fri, 26 Jan 2018 12:04:56 -0800 James Bottomley wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > First time I did not get any feedback for the patches. > > This is likely because no-one who might inspect the code saw the > patches ... what list are they going to?  I'm

Re: [PATCH 1/2] mmc: bcm2835: reset host on timeout

2018-03-06 Thread Michal Suchánek
Hello, On Sat, 3 Mar 2018 14:58:45 +0100 (CET) Stefan Wahren wrote: > Hi Michal, > > yesterday i finished my stress tests with Raspberry Pi 3. > > Scenario: > - copy Tumbleweed on SD card > (openSUSE-Tumbleweed-ARM-JeOS-raspberrypi3.aarch64-2018.02.02-Build1.2.raw, > Linux 4.14.15) > - setup

Regression: 18996f2db918 ("ACPICA: Events: Stop unconditionally clearing ACPI IRQs during suspend/resume" breaks resume from suspend

2018-08-20 Thread Michal Suchánek
Hello, after commit 18996f2db918 ("ACPICA: Events: Stop unconditionally clearing ACPI IRQs during suspend/resume") I am no longer able to resume from suspend. Reported in bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=200841 Reverting this on top of 4.18 fixes the issue. acpidump output is

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-09 Thread Michal Suchánek
Hello, On Mon, Oct 09, 2023 at 05:31:02PM +0900, Masahiro Yamada wrote: > On Fri, Oct 6, 2023 at 12:49 AM Michal Suchanek wrote: > > > > The default MODLIB value is composed of two variables and the hardcoded > > string '/lib/modules/'. > > > > MODLIB = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELREL

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-09 Thread Michal Suchánek
On Mon, Oct 09, 2023 at 09:34:10PM +0900, Masahiro Yamada wrote: > On Mon, Oct 9, 2023 at 5:52 PM Michal Suchánek wrote: > > > > Hello, > > > > On Mon, Oct 09, 2023 at 05:31:02PM +0900, Masahiro Yamada wrote: > > > On Fri, Oct 6, 2023 at 12:49 AM Michal

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-10 Thread Michal Suchánek
On Tue, Oct 10, 2023 at 12:14:01AM +0900, Masahiro Yamada wrote: > On Mon, Oct 9, 2023 at 11:07 PM Michal Suchánek wrote: > > > > On Mon, Oct 09, 2023 at 09:34:10PM +0900, Masahiro Yamada wrote: > > > On Mon, Oct 9, 2023 at 5:52 PM Michal Suchánek wrote: > > > &g

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-17 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 07:15:50PM +0900, Masahiro Yamada wrote: > > > > > > Let me add more context to my question. > > > > > > > > > I am interested in the timing when > > > 'pkg-config --print-variables kmod | grep module_directory' > > > is executed. > > > > > > > > > > > > 1. Build a SRPM on

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-17 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 09:05:29PM +0900, Masahiro Yamada wrote: > On Tue, Oct 17, 2023 at 7:44 PM Michal Suchánek wrote: > > > > On Tue, Oct 17, 2023 at 07:15:50PM +0900, Masahiro Yamada wrote: > > > > > > > > > > Let me add more context to my

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-17 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 11:46:45PM +0900, Masahiro Yamada wrote: > On Tue, Oct 17, 2023 at 9:27 PM Michal Suchánek wrote: > > > > On Tue, Oct 17, 2023 at 09:05:29PM +0900, Masahiro Yamada wrote: > > > On Tue, Oct 17, 2023 at 7:44 PM Michal Suchánek wrote: > > >

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-10-17 Thread Michal Suchánek
Hello, it has been a few months since these kmod patches have been posted, and a new kmod versio has been released since. Is there any interest in adding this to kmod? Thanks Michal On Tue, Jul 18, 2023 at 02:01:51PM +0200, Michal Suchanek wrote: > Hello, > > with these patches it is possible

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-10-17 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 11:18:23AM -0500, Lucas De Marchi wrote: > On Tue, Oct 17, 2023 at 05:45:39PM +0200, Michal Suchánek wrote: > > Hello, > > > > it has been a few months since these kmod patches have been posted, and > > a new kmod versio has been released s

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-11-09 Thread Michal Suchánek
On Wed, Oct 18, 2023 at 03:25:19AM +0200, Jan Engelhardt wrote: > On Tuesday 2023-10-17 19:50, Lucas De Marchi wrote: > >> +AC_ARG_WITH([module_directory], > >> +AS_HELP_STRING([--with-module-directory=DIR], [directory in which > >> to > >> look for kernel modules - typically '/lib/modules

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-11-09 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 12:50:15PM -0500, Lucas De Marchi wrote: > On Tue, Jul 18, 2023 at 02:01:56PM +0200, Michal Suchanek wrote: > > Now that modprobe.d is searched under ${prefix}/lib, allow a complete > > transition to files only under ${prefix} by adding a ${module_directory} > > configuratio

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-11-10 Thread Michal Suchánek
On Wed, Oct 18, 2023 at 03:12:41AM +0200, Jan Engelhardt wrote: > On Tuesday 2023-10-17 17:10, Michal Suchánek wrote: > > > >> In my system (Ubuntu), I see the directory paths > >> > >> /usr/aarch64-linux-gnu/lib/ > >> /usr/i686-linux-gnu/lib/ > &

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-11-13 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 12:50:15PM -0500, Lucas De Marchi wrote: > On Tue, Jul 18, 2023 at 02:01:56PM +0200, Michal Suchanek wrote: > > Now that modprobe.d is searched under ${prefix}/lib, allow a complete > > transition to files only under ${prefix} by adding a ${module_directory} > > configuratio

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-10 Thread Michal Suchánek
Hello! On Mon, Dec 11, 2023 at 03:43:44AM +0900, Masahiro Yamada wrote: > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > Some distributions aim at shipping all files in /usr. > > > > The path under which kernel modules are installed is hardcoded to /lib > > which conflicts with thi

Re: [PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-10 Thread Michal Suchánek
On Mon, Dec 11, 2023 at 03:44:35AM +0900, Masahiro Yamada wrote: > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > The default MODLIB value is composed of three variables > > > > MODLIB = $(INSTALL_MOD_PATH)$(KERNEL_MODULE_DIRECTORY)/$(KERNELRELEASE) > > > > However, the kernel.spec

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-12 Thread Michal Suchánek
On Mon, Dec 11, 2023 at 01:29:15PM +0900, Masahiro Yamada wrote: > On Mon, Dec 11, 2023 at 6:07 AM Michal Suchánek wrote: > > > > Hello! > > > > On Mon, Dec 11, 2023 at 03:43:44AM +0900, Masahiro Yamada wrote: > > > On Thu, Dec 7, 2023 at 4:48 AM Michal S

Re: [PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-12 Thread Michal Suchánek
On Mon, Dec 11, 2023 at 01:33:23PM +0900, Masahiro Yamada wrote: > On Mon, Dec 11, 2023 at 6:09 AM Michal Suchánek wrote: > > > > On Mon, Dec 11, 2023 at 03:44:35AM +0900, Masahiro Yamada wrote: > > > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > &

Re: [PATCH 0/2] kmod /usr support

2024-08-22 Thread Michal Suchánek
Hello, On Thu, Aug 22, 2024 at 01:05:11AM -0500, Lucas De Marchi wrote: > On Tue, Dec 19, 2023 at 05:37:31PM GMT, Masahiro Yamada wrote: > > On Thu, Dec 7, 2023 at 3:37 AM Lucas De Marchi > > wrote: > > > > > > On Fri, Nov 10, 2023 at 01:13:53PM +0100, Michal Suchanek wrote: > > > >Hello, > > >

Re: [PATCH 0/2] kmod /usr support

2024-08-23 Thread Michal Suchánek
On Fri, Aug 23, 2024 at 10:03:05PM +0900, Masahiro Yamada wrote: > On Thu, Aug 22, 2024 at 5:36 PM Michal Suchánek wrote: > > > > Hello, > > > > On Thu, Aug 22, 2024 at 01:05:11AM -0500, Lucas De Marchi wrote: > > > On Tue, Dec 19, 2023 at 05:37:31PM GMT, M

ndctl tests usable?

2022-04-26 Thread Michal Suchánek
Hello, there is some testsuite included with ndctl, and when following the instructions to build it most tests fail or are skipped: [ 95s] Ok: 3 [ 95s] Expected Fail: 0 [ 95s] Fail: 5 [ 95s] Unexpected Pass:0 [ 95s] Skipped:

Re: ndctl tests usable?

2022-04-26 Thread Michal Suchánek
On Tue, Apr 26, 2022 at 08:51:25AM -0700, Dan Williams wrote: > On Tue, Apr 26, 2022 at 5:39 AM Michal Suchánek wrote: > > > > Hello, > > > > there is some testsuite included with ndctl, and when following the > > instructions to build it most tests fail or

Re: ndctl tests usable?

2022-04-26 Thread Michal Suchánek
On Tue, Apr 26, 2022 at 09:32:24AM -0700, Dan Williams wrote: > On Tue, Apr 26, 2022 at 9:15 AM Michal Suchánek wrote: > > > > On Tue, Apr 26, 2022 at 08:51:25AM -0700, Dan Williams wrote: > > > On Tue, Apr 26, 2022 at 5:39 AM Michal Suchánek wrote: > > > >

Re: ndctl tests usable?

2022-04-26 Thread Michal Suchánek
On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote: > On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek wrote: > > > > On Tue, Apr 26, 2022 at 09:32:24AM -0700, Dan Williams wrote: > > > On Tue, Apr 26, 2022 at 9:15 AM Michal Suchánek wrote: > > > > &

Re: ndctl tests usable?

2022-04-27 Thread Michal Suchánek
On Tue, Apr 26, 2022 at 11:22:55AM -0700, Dan Williams wrote: > On Tue, Apr 26, 2022 at 11:10 AM Michal Suchánek wrote: > > > > On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote: > > > On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek wrote: > > > > &

Re: ndctl tests usable?

2022-04-28 Thread Michal Suchánek
On Thu, Apr 28, 2022 at 10:02:47AM +0530, Shivaprasad G Bhat wrote: > On 4/26/22 23:39, Michal Suchánek wrote: > > On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote: > > > On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek wrote: > > > > > > > >

Re: [PATCH] testing: nvdimm: iomap: make __nfit_test_ioremap a macro

2022-04-29 Thread Michal Suchánek
On Fri, Apr 29, 2022 at 03:40:39PM +0200, Michal Suchanek wrote: > The ioremap passed as argument to __nfit_test_ioremap can be a macro so > it cannot be passed as function argument. Make __nfit_test_ioremap into > a macro so that ioremap can be passed as untyped macro argument. Fixes: 6bc756193ff

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-09-11 Thread Michal Suchánek
On Sat, Aug 19, 2023 at 08:25:52PM +0900, Masahiro Yamada wrote: > On Fri, Aug 18, 2023 at 12:15 PM Michal Suchánek wrote: > > > > Hello, > > > > On Tue, Jul 18, 2023 at 02:01:51PM +0200, Michal Suchanek wrote: > > > Hello, > > > > > > with

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Michal Suchánek
On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote: > > On 9/7/23 13:32, Michal Suchánek wrote: > > Adding more CC's from the original patch, looks like get_maintainers is > > not that great for this file. > > > > On Thu, Sep 07, 2023 at 06:52:19PM +0200, Mi

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Michal Suchánek
On Tue, Sep 12, 2023 at 12:45:35AM +0300, Jarkko Sakkinen wrote: > On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote: > > No other platform needs CA_MACHINE_KEYRING, either. > > > > This is policy that should be decided by the administrator, not Kconfig > > s/administrator/distributor/ ?

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Michal Suchánek
On Tue, Sep 12, 2023 at 12:46:32PM +0300, Jarkko Sakkinen wrote: > On Tue Sep 12, 2023 at 10:51 AM EEST, Michal Suchánek wrote: > > On Tue, Sep 12, 2023 at 12:45:35AM +0300, Jarkko Sakkinen wrote: > > > On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote: > > >

Re: allmodconfig not working with dummy-tools

2021-04-08 Thread Michal Suchánek
On Sat, Apr 03, 2021 at 12:43:02PM +0200, Michal Suchánek wrote: > Hello, > > thanks for the fix. > > On Fri, Apr 02, 2021 at 01:26:38AM +0900, Masahiro Yamada wrote: > > On Thu, Apr 1, 2021 at 9:39 PM Michal Suchánek wrote: > > I squashed the following. Please wai

Re: [PATCH] powerpc/xmon: really enable xmon when a breakpoint is set

2018-05-23 Thread Michal Suchánek
On Tue, 22 May 2018 12:53:53 +0530 Vaibhav Jain wrote: > Thanks for the patch Michal, > > Michal Suchanek writes: > > > When single-stepping kernel code from xmon without a debug hook > > enabled the kernel crashes. This can happen when kernel starts with > > xmon on crash disabled but xmon is

Re: [PATCH 4/6] powerpc/64s: Enable barrier_nospec based on firmware settings

2018-04-26 Thread Michal Suchánek
Hello, On Tue, 24 Apr 2018 14:15:57 +1000 Michael Ellerman wrote: > From: Michal Suchanek > > Check what firmware told us and enable/disable the barrier_nospec as > appropriate. > > We err on the side of enabling the barrier, as it's no-op on older > systems, see the comment for more detail.

Re: [PATCH 2/6] powerpc/64s: Add support for ori barrier_nospec patching

2018-04-26 Thread Michal Suchánek
Hello, On Tue, 24 Apr 2018 14:15:55 +1000 Michael Ellerman wrote: > From: Michal Suchanek > > Based on the RFI patching. This is required to be able to disable the > speculation barrier. why do you not patch the nospec barrier which is included as part of the RFI flush code? I think when deb

Re: [PATCH 4/6] powerpc/64s: Enable barrier_nospec based on firmware settings

2018-05-02 Thread Michal Suchánek
On Tue, 01 May 2018 21:11:06 +1000 Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > On Tue, 24 Apr 2018 14:15:57 +1000 > > Michael Ellerman wrote: > > > >> From: Michal Suchanek > >> > >> Check what fi

Re: [PATCH v10 0/5] Kernel parameter parser cleanup/enhancement

2018-06-05 Thread Michal Suchánek
On Tue, 5 Jun 2018 20:05:50 +0300 Andy Shevchenko wrote: > On Tue, Jun 5, 2018 at 7:43 PM, Michal Suchanek > wrote: > > Hello, > > > > due to work on the fadump_extra_args I looked at the kernel > > parameter parser and found its grammar rather curious. > > > > It supports double quotes but not

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

2020-08-07 Thread Michal Suchánek
On Fri, Aug 07, 2020 at 08:58:09AM +0200, David Hildenbrand wrote: > On 07.08.20 06:32, Andrew Morton wrote: > > On Fri, 3 Jul 2020 18:28:23 +0530 Srikar Dronamraju > > wrote: > > > >>> The memory hotplug changes that somehow because you can hotremove numa > >>> nodes and therefore make the node

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-08 Thread Michal Suchánek
Hello On Sat, Dec 05, 2020 at 02:32:04PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 05, 2020 at 08:59:55AM +0100, Enrico Weigelt, metux IT consult > wrote: > > On 04.12.20 04:35, Jason Wang wrote: > > > > > > > > Let's use select, since there's no prompt for VIRTIO and it doesn't have > > >

Re: [PATCH] ibmvnic: fix: NULL pointer dereference.

2020-12-30 Thread Michal Suchánek
On Wed, Dec 30, 2020 at 03:23:14PM +0800, YANG LI wrote: > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, >"Invalid scrq reset. irq (%d) or msgs(%p).\n", > scrq->irq, scrq->msg

Re: [PATCH 1/2] kbuild: dummy-tools: Add elfedit.

2021-04-12 Thread Michal Suchánek
On Sun, Apr 11, 2021 at 08:37:03PM +0900, Masahiro Yamada wrote: > On Sun, Apr 11, 2021 at 7:18 PM Michal Suchánek wrote: > > > > On Sun, Apr 11, 2021 at 03:12:40AM +0900, Masahiro Yamada wrote: > > > On Fri, Apr 9, 2021 at 6:31 AM Michal Suchanek wrote: > >

Re: [RFC/PATCH] powerpc/smp: Add SD_SHARE_PKG_RESOURCES flag to MC sched-domain

2021-04-12 Thread Michal Suchánek
On Mon, Apr 12, 2021 at 04:24:44PM +0100, Mel Gorman wrote: > On Mon, Apr 12, 2021 at 02:21:47PM +0200, Vincent Guittot wrote: > > > > Peter, Valentin, Vincent, Mel, etal > > > > > > > > On architectures where we have multiple levels of cache access latencies > > > > within a DIE, (For example: one

allmodconfig not working with dummy-tools

2021-04-01 Thread Michal Suchánek
Hello, running allmodconfig with dumy-tools I get: which: no elfedit in (./scripts/dummy-tools) scripts/dummy-tools/gcc: unknown assembler invoked scripts/Kconfig.include:50: Sorry, this assembler is not supported. scripts/kconfig/Makefile:77: recipe for target 'allmodconfig' failed make[1]: ***

Re: [PATCH 1/2] kbuild: dummy-tools: Add elfedit.

2021-04-11 Thread Michal Suchánek
On Sun, Apr 11, 2021 at 03:12:40AM +0900, Masahiro Yamada wrote: > On Fri, Apr 9, 2021 at 6:31 AM Michal Suchanek wrote: > > > > elfedit is used in Makefile > > > > Makefile:GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit)) > > > > which causes this error getting printed > > > >

Re: [PATCH 1/2] kbuild: dummy-tools: Add elfedit.

2021-04-11 Thread Michal Suchánek
On Sun, Apr 11, 2021 at 08:37:03PM +0900, Masahiro Yamada wrote: > On Sun, Apr 11, 2021 at 7:18 PM Michal Suchánek wrote: > > > > On Sun, Apr 11, 2021 at 03:12:40AM +0900, Masahiro Yamada wrote: > > > On Fri, Apr 9, 2021 at 6:31 AM Michal Suchanek wrote: > >

Re: allmodconfig not working with dummy-tools

2021-04-03 Thread Michal Suchánek
Hello, thanks for the fix. On Fri, Apr 02, 2021 at 01:26:38AM +0900, Masahiro Yamada wrote: > On Thu, Apr 1, 2021 at 9:39 PM Michal Suchánek wrote: > I squashed the following. Please wait for tomorrow's linux-next. > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-too

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-09 Thread Michal Suchánek
On Tue, Dec 08, 2020 at 01:33:02PM +0100, Enrico Weigelt, metux IT consult wrote: > On 08.12.20 11:10, Michal Suchánek wrote: > > Hi, > > > The console driver provides early console which should initialize > > without any transport. I have not tested it actually works b

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-12-01 Thread Michal Suchánek
On Thu, Nov 12, 2020 at 08:08:49AM -0800, Ira Weiny wrote: > On Thu, Nov 12, 2020 at 04:10:46PM +0100, Jan Kara wrote: > > On Thu 12-11-20 12:12:17, Michal Suchánek wrote: > > > On Thu, Nov 12, 2020 at 12:49:52PM +1100, Dave Chinner wrote: > > > > On Wed, Nov 11, 20

Re: [PATCH] rpadlpar: fix potential drc_name corruption in store functions

2021-03-13 Thread Michal Suchánek
On Wed, Mar 10, 2021 at 04:30:21PM -0600, Tyrel Datwyler wrote: > Both add_slot_store() and remove_slot_store() try to fix up the drc_name > copied from the store buffer by placing a NULL terminator at nbyte + 1 > or in place of a '\n' if present. However, the static buffer that we > copy the drc_n

Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.

2021-03-10 Thread Michal Suchánek
On Wed, Mar 10, 2021 at 04:07:00AM +0900, Masahiro Yamada wrote: > On Wed, Mar 10, 2021 at 12:10 AM Michal Suchánek wrote: > > > > On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote: > > > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek wrote: > > >

Re: [PATCH 3/3] powerpc/qspinlock: Use generic smp_cond_load_relaxed

2021-03-09 Thread Michal Suchánek
On Mon, Mar 08, 2021 at 05:59:50PM -0800, Davidlohr Bueso wrote: > 49a7d46a06c3 (powerpc: Implement smp_cond_load_relaxed()) added > busy-waiting pausing with a preferred SMT priority pattern, lowering > the priority (reducing decode cycles) during the whole loop slowpath. > > However, data shows

Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.

2021-03-09 Thread Michal Suchánek
On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote: > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek wrote: > > > > When using dummy-tools STACKPROTECTOR_PER_TASK is unconditionally > > selected. This defeats the purpose of the all-enabled tool. > > > > Description copied from arm > >

Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.

2021-03-09 Thread Michal Suchánek
On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote: > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek wrote: > > > > On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote: > > > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek wrote: > > >

dummy-tools regression on Linux 5.12

2021-03-09 Thread Michal Suchánek
Hello, on 5.11 I can update the config with dummy-tools but in 5.12 it no longer works: make ARCH=powerpc CROSS_COMPILE=scripts/dummy-tools/ oldconfig scripts/dummy-tools/gcc: unknown compiler scripts/Kconfig.include:44: Sorry, this compiler is not supported. make[1]: *** [scripts/kconfig/Makefil

Re: [PATCH 3/3] powerpc/qspinlock: Use generic smp_cond_load_relaxed

2021-03-09 Thread Michal Suchánek
On Tue, Mar 09, 2021 at 07:46:11AM -0800, Davidlohr Bueso wrote: > On Tue, 09 Mar 2021, Michal Such�nek wrote: > > > On Mon, Mar 08, 2021 at 05:59:50PM -0800, Davidlohr Bueso wrote: > > > 49a7d46a06c3 (powerpc: Implement smp_cond_load_relaxed()) added > > > busy-waiting pausing with a preferred

Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.

2021-03-09 Thread Michal Suchánek
On Wed, Mar 10, 2021 at 04:07:00AM +0900, Masahiro Yamada wrote: > On Wed, Mar 10, 2021 at 12:10 AM Michal Suchánek wrote: > > > > On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote: > > > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek wrote: > > >

Re: [PATCH v2] nvdimm: Avoid race between probe and reading device attributes

2021-01-07 Thread Michal Suchánek
Ping? On Mon, Jun 15, 2020 at 08:47:23AM +0100, Richard Palethorpe wrote: > It is possible to cause a division error and use-after-free by querying the > nmem device before the driver data is fully initialised in nvdimm_probe. E.g > by doing > > (while true; do > cat /sys/bus/nd/devices/nmem

Re: [RFC PATCH] treewide: remove bzip2 compression support

2020-12-15 Thread Michal Suchánek
Hello, On Tue, Dec 15, 2020 at 02:03:15PM -0500, Alex Xu (Hello71) wrote: > bzip2 is either slower or larger than every other supported algorithm, > according to benchmarks at [0]. It is far slower to decompress than any > other algorithm, and still larger than lzma, xz, and zstd. > > [0] https:/

Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Michal Suchánek
On Wed, 28 Aug 2019 23:46:24 -0700 Christoph Hellwig wrote: > On Wed, Aug 28, 2019 at 06:43:50PM +0200, Michal Suchanek wrote: > > +ifdef CONFIG_COMPAT > > +obj-y += sys_ppc32.o ptrace32.o signal_32.o > > +endif > > This should be: > > obj-$(CONFIG_COMPAT)

Re: [PATCH 1/4] fs: always build llseek.

2019-08-29 Thread Michal Suchánek
On Wed, 28 Aug 2019 23:22:00 -0700 Christoph Hellwig wrote: > On Wed, Aug 28, 2019 at 06:15:40PM +0200, Michal Suchánek wrote: > > On Wed, 28 Aug 2019 08:15:52 -0700 > > Christoph Hellwig wrote: > > > > > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal S

Re: [PATCH v4 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 12:23:42 +0200 Michal Suchanek wrote: > There are numerous references to 32bit functions in generic and 64bit > code so ifdef them out. > > Signed-off-by: Michal Suchanek > --- > v2: > - fix 32bit ifdef condition in signal.c > - simplify the compat ifdef condition in vdso.c

Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 14:19:46 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 12:23 PM Michal Suchanek wrote: > > > > Fixes: aff850393200 ("powerpc: add system call table generation support") > > This patch needs a proper explanation. The Fixes tag doesn't seem right > here, since ppc64 h

Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 14:57:39 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 2:37 PM Michal Suchánek wrote: > > On Thu, 29 Aug 2019 14:19:46 +0200 Arnd Bergmann wrote: > > > On Thu, Aug 29, 2019 at 12:23 PM Michal Suchanek > > > wrote: > > > In pa

Re: [PATCH v4 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 19:40:55 +0200 Christophe Leroy wrote: > Le 29/08/2019 à 12:23, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef condit

Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 16:32:50 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 4:19 PM Michal Suchánek wrote: > > On Thu, 29 Aug 2019 14:57:39 +0200 Arnd Bergmann wrote: > > > On Thu, Aug 29, 2019 at 2:37 PM Michal Suchánek > > > wrote: > > > >

Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 15:34:08 -0500 Uma Krishnan wrote: > Below commit queued up for 5.4 includes these changes. > > commit 657bd277c162580674ddb86a90c4aeb62639bff5 > Author: Gustavo A. R. Silva > Date:   Sun Jul 28 19:21:19 2019 -0500 > > Thanks, > Uma Krishnan Works for me as well. Thanks

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-29 Thread Michal Suchánek
On Fri, 30 Aug 2019 06:35:11 + (UTC) Christophe Leroy wrote: > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > Building callchain.c with !COMPAT proved quite ugly with all the > > defines. Splitting out the 32bit and 64bit parts looks better. > > > > Also rewrite current_is_64bit as commo

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 08:42:25 +0200 Michal Suchánek wrote: > On Fri, 30 Aug 2019 06:35:11 + (UTC) > Christophe Leroy wrote: > > > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > obj-$(CONFIG_PPC_PERF_CTRS)+= core-book3s.o bhrb.o > > diff --git a/arc

Re: [PATCH v5 3/5] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 06:35:13 + (UTC) Christophe Leroy wrote: > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef co

Re: [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 09:49:35 +0200 Marcel Holtmann wrote: > Hi Michal, > > > This reverts commit a0085f2510e8976614ad8f766b209448b385492f. > > > > After this commit systems wake up at random, most commonly when > > > > - put to sleep while bluetooth audio stream is running > > - connected blue

Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 20:57:57 +0200 Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > BTW the powerpc callchain.c does not match any of the patterns of PERF CORE in MAINTAINERS (unlike call

Re: [PATCH v6 4/6] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 22:21:09 +0200 Christophe Leroy wrote: > Le 30/08/2019 à 20:57, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef condit

Re: [PATCH v7 4/6] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-31 Thread Michal Suchánek
On Fri, 30 Aug 2019 23:03:41 +0200 Michal Suchanek wrote: > There are numerous references to 32bit functions in generic and 64bit > code so ifdef them out. > > Signed-off-by: Michal Suchanek > --- > v2: > - fix 32bit ifdef condition in signal.c > - simplify the compat ifdef condition in vdso.c

Re: [PATCH v7 0/6] Disable compat cruft on ppc64le v7

2019-08-31 Thread Michal Suchánek
On Sat, 31 Aug 2019 08:41:58 +0200 Christophe Leroy wrote: > Le 30/08/2019 à 23:03, Michal Suchanek a écrit : > > Less code means less bugs so add a knob to skip the compat stuff. > > I guess on PPC64 you have Gigabytes of memory and thousands of bogomips, > hence you focus on bugs. > > My m

Re: [PATCH v7 6/6] powerpc/perf: split callchain.c by bitness

2019-08-31 Thread Michal Suchánek
On Fri, 30 Aug 2019 23:03:43 +0200 Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > > No code change intended. valid_user_sp is broken in compat. It needs to be ifdefed for the 32bit case

Re: [PATCH v7 3/6] powerpc/perf: consolidate read_user_stack_32

2019-09-02 Thread Michal Suchánek
On Mon, 02 Sep 2019 14:01:17 +1000 Michael Ellerman wrote: > Michael Ellerman writes: > > Michal Suchanek writes: > ... > >> @@ -295,6 +279,12 @@ static inline int current_is_64bit(void) > >> } > >> > >> #else /* CONFIG_PPC64 */ > >> +static int read_user_stack_slow(void __user *ptr, voi

Re: [PATCH v7 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default.

2019-09-02 Thread Michal Suchánek
On Mon, 02 Sep 2019 12:03:12 +1000 Michael Ellerman wrote: > Michal Suchanek writes: > > On bigendian ppc64 it is common to have 32bit legacy binaries but much > > less so on littleendian. > > I think the toolchain people will tell you that there is no 32-bit > little endian ABI defined at al

Re: [PATCH 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-27 Thread Michal Suchánek
On Tue, 27 Aug 2019 22:21:08 +0200 Michal Suchanek wrote: > There are numerous references to 32bit functions in generic and 64bit > code so ifdef them out. > > Signed-off-by: Michal Suchanek > --- > arch/powerpc/include/asm/syscall.h | 2 ++ > arch/powerpc/kernel/Makefile | 15 +

Re: [PATCH v2 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-28 Thread Michal Suchánek
On Wed, 28 Aug 2019 14:49:16 +0200 Christophe Leroy wrote: > Le 28/08/2019 à 12:30, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > As far as possible, avoid opting things out with ifdefs. Ref > https://www.ke

  1   2   >