[GIT PULL] kbuild misc fixes for v4.2-rc1

2015-07-02 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - usual make deb-pkg/rpm improvements - .gitignore additions - grammar cleansing in scripts/coccinelle - new coccinelle semantic patch Michal The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031: Linux 4.1-rc1 (2015-04-2

Re: [GIT PULL] kbuild misc fixes for v4.2-rc1

2015-07-03 Thread Michal Marek
On 2015-07-03 00:25, Linus Torvalds wrote: > So with all these changes to the build system fro 4.2, I'm *still* > getting that annoying > >X.509 certificate list changed > > issue. Which apparently people don't normally see, because it does to > stdout rather than to stderr, so it's hidden by

Re: [PATCH 1/2] linux/kconfig.h: generalize IS_ENABLED logic

2015-10-08 Thread Michal Marek
On 2015-10-07 23:33, Rasmus Villemoes wrote: > On Wed, Oct 07 2015, Michal Marek wrote: >> It should be accompanied by a patch to scripts/tags.sh teaching >> ctags/etags about the new macros. > > Do you mean that something like > > --regex-c='/COND_CONFIG\(

Re: [PATCH v2] kselftest: add kselftest-clean rule

2015-10-08 Thread Michal Marek
On Thu, Oct 08, 2015 at 02:52:04PM +1100, Michael Ellerman wrote: > On Thu, 2015-10-08 at 02:41 +, Wang Long wrote: > > We use > > > > $make TARGETS="size timers" kselftest > > > > to build and run selftests. but there is no rule > > for us to clean the kselftest generated files. > > > >

Re: [PATCH v4] kbuild: document recursive dependency limitation / resolution

2015-10-08 Thread Michal Marek
> Cc: Paul Bolle > Cc: Herbert Xu > Cc: Takashi Iwai > Cc: "Yann E. MORIN" > Cc: Michal Marek > Cc: Jonathan Corbet > Cc: Mate Soos > Cc: linux-kbu...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Lu

[GIT PULL] kbuild patch for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, the kbuild branch for v4.4-rc1 only has one commit: A new make kselftest-clean target cleans tools/testing/selftests. Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at

[GIT PULL] kconfig changes for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, please pull these kconfig changes for v4.4-rc1: - make xconfig ported to Qt5, dropping support for Qt3 - merge_config.sh supports a single-input-file mode and also respects $KCONFIG_CONFIG - Fix for incorrect display of >= and > in dependency expressions Thanks, Michal The following

[GIT PULL] kbuild misc update for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - several coccinelle updates - make deb-pkg creates an armhf package if CONFIG_VFP=y - make tags understands some more powerpc macros Thanks, Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2

Re: linux-next: clean up the kbuild tree?

2015-11-16 Thread Michal Marek
Dne 15.11.2015 v 18:58 Andi Kleen napsal(a): > On Sun, Nov 15, 2015 at 11:27:05AM +1100, Stephen Rothwell wrote: >> Hi Michal, >> >> I notice that the kbuild tree (relative to Linus' tree) only contains >> lots of merges and these 2 commits from April 2014: > > Really should get in that patch offi

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 17:28 Alexey Brodkin napsal(a): > On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote: >> Alexey, did this solve the problem for you? > > Yep, thanks a lot. > "make xconfig" now works for me! Thanks for testing, I will apply it to kbuild.git#kconfig. Thanks, Michal -- To un

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 20:23 Thiago Macieira napsal(a): > On Monday 02 November 2015 10:48:00 Randy Dunlap wrote: >> Hi, >> What does this patch apply to? >> I can't apply it cleanly to to 4.3 or linux-next of yesterday or today. > > Hmm... interesting, it doesn't apply on linux-next. The reason for that

[PATCH] nfcmrvl: Fix Kconfig dependency

2015-11-03 Thread Michal Marek
rvl_spi.ko] undefined! Signed-off-by: Michal Marek --- drivers/nfc/nfcmrvl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/nfcmrvl/Kconfig b/drivers/nfc/nfcmrvl/Kconfig index 444ca94..670af76 100644 --- a/drivers/nfc/nfcmrvl/Kconfig +++ b/drivers/nfc/

[PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-22 Thread Michal Marek
The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so the workaround is no longer needed. Signed-off-by: Michal Marek --- scripts/package/builddeb | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index

[PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Gupta Cc: linux-snps-...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arc/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 19cce226d1a8..44ef35d33956 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -

[PATCH 2/6] arm: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
King Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 6be9ee148b78..f3fa2cafca15 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Mak

[PATCH 4/6] sh: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Signed-off-by: Michal Marek --- arch/sh/Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sh/Makefile b/arch/sh/Makefile index 336f33a419d9..280bbff12102 100644 --- a/arch/sh/Makefile +++ b/arch/sh/Mak

[PATCH 5/6] unicore32: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
uetao Signed-off-by: Michal Marek --- arch/unicore32/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/Makefile b/arch/unicore32/Makefile index b6f5c4c1eaf9..98a5ca43ae87 100644 --- a/arch/unicore32/Makefile +++ b/arch/unicore32/Makefile @@ -43,9 +43,9 @@

[PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
rinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm64/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 3635b8662724..80b6866bcacb 100644 --- a/arch/arm64/Mak

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
asm/asm-prototypes.h >> create mode 100644 include/asm-generic/asm-prototypes.h > > Michal, I'm quite unhappy about how the offending commit that broke > modversions > for essentially _everyone_ who does more complex modular builds on x86 ended > up > upstream: >

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
On 2016-11-24 08:53, Nicholas Piggin wrote: > On Thu, 24 Nov 2016 08:36:39 +0100 > Greg Kroah-Hartman wrote: > >> On Thu, Nov 24, 2016 at 06:20:26PM +1100, Nicholas Piggin wrote: >>> But still, modversions is pretty complicated for what it gives us. It sends >>> preprocessed C into a C parser tha

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
Dne 24.11.2016 v 11:03 Nicholas Piggin napsal(a): > On Thu, 24 Nov 2016 10:32:12 +0100 > Michal Marek wrote: > >> On 2016-11-24 08:53, Nicholas Piggin wrote: >>> On Thu, 24 Nov 2016 08:36:39 +0100 >>> Greg Kroah-Hartman wrote: >>> >>>&

Re: [PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-05 Thread Michal Marek
On 2017-01-05 10:33, Borislav Petkov wrote: > On Tue, Jan 03, 2017 at 03:14:54PM +0100, Michal Marek wrote: >> During real build, this manifests itself by genksyms segfaulting. >> >> Reported-by: Borislav Petkov > > ... -and-tested-by: ... > > For all three. &g

[GIT PULL] kbuild fix for v4.10-rc3

2017-01-06 Thread Michal Marek
: Clear any CPP defines before declaring the functions (2017-01-05 12:57:42 +0100) Michal Marek (1): asm-prototypes: Clear any CPP defines before declaring the functions include/asm-generic/asm-prototypes.h | 6 ++ 1 file

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-18 Thread Michal Marek
On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > When building with separate object directories and driver specific > Makefiles that add additional header include paths, Kbuild adjusts > the gcc flags so that we include both the directory in the source > tree and in the object tree.

Re: [REPOST 2, PATCH] builddeb: really include objtool binary in headers package

2016-07-19 Thread Michal Marek
On Tue, Jun 28, 2016 at 12:21:33PM +, Wilfried Klaebe wrote: > [added linux-kbu...@vger.kernel.org to Cc:, added Fixes:] > > On May 4th, Bjørn Mork provided patch > 697bbc7b832048d3a679cd55caf2268a325efbe0 to include objtool binaries in > the headers package. However, that one only works if $s

Re: linux-next: build warnings after merge of the kbuild tree

2016-06-09 Thread Michal Marek
Dne 9.6.2016 v 06:05 Stephen Rothwell napsal(a): > On Wed, 8 Jun 2016 19:56:38 -0700 Kees Cook wrote: >> Ah, yes, that should default to off. We'll get a fix landed ASAP. > > Note that this was an allmodconfig build. The default is 'n', but > allmodconfig will turn it on (as will allyesconfig).

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-06-14 Thread Michal Marek
On 2016-06-14 06:32, Stephen Rothwell wrote: > Hi Kees, > > On Mon, 13 Jun 2016 16:57:15 -0700 Kees Cook wrote: >> >> On Mon, Jun 13, 2016 at 4:53 PM, Kees Cook wrote: >>> >>> Strange, I pulled these directly from linux-next. Michal had an >>> auto-responder saying he was going to be out-of-offi

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > +weight = (int(rel_specs['VERSION'])<< 32) + \ > + (int(rel_specs['PATCHLEVEL']) << 16) + \ > + (sublevel << 8 ) + \ > + (extra * 60) + (relmod * 2) This is going to

Re: [PATCH 3/4] coccicheck: enable use of the kernel's python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > Signed-off-by: Luis R. Rodriguez > --- > scripts/coccicheck | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index ba7301ab0a3d..a4d91d649ad9 100755 > --- a/scripts/coccicheck > +++ b/scripts/cocc

Re: kbuild: default n removals?

2016-06-15 Thread Michal Marek
On 2016-06-08 17:38, Joe Perches wrote: > (Adding Michal Marek and linux-kbuild) > > On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: >> On 08.06.2016 16:53, Guenter Roeck wrote: >>> On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: >>>>>&g

Re: [PATCH] kcov: reject open when kernel not instrumented

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 17:49 Mark Rutland napsal(a): > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > this option from CFLAGS_KCOV, and build the kernel without > instrumentation, even if CONFIG_KCOV was selected. However, we still > build the rest of the kcov infrastructure, an

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: >>> +weight = (int(rel_specs['VERSION'])<< 32) + \ >>> +

Re: [PATCHv2] builddeb: fix file permissions before packaging

2016-07-26 Thread Michal Marek
Dne 22.7.2016 v 14:46 Henning Schild napsal(a): > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting linux-he

Re: [PATCH] Coccinelle: Script to replace allocate and memcpy with zalloc functions

2016-07-26 Thread Michal Marek
Dne 23.7.2016 v 23:00 Amitoj Kaur Chawla napsal(a): > This script finds instances of allocate and memcpy which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > scripts/coccinelle/api/zalloc.cocci | 556 > +

Re: [RESEND][PATCH] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
On Tue, Jul 12, 2016 at 03:30:43PM -0700, Kees Cook wrote: > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown f

Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under ifndef force) > >

Re: [PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 23:26 Kees Cook napsal(a): > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown flag. This has ca

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Michal Marek
Dne 14.6.2016 v 18:39 Kees Cook napsal(a): > On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell > wrote: >> Hi Michal, >> >> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote: >>> >>> I won't :). Kees, are you going to keep the patch in your

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-27 Thread Michal Marek
On 2016-07-27 01:09, Kees Cook wrote: > On Tue, Jul 26, 2016 at 3:19 PM, Michal Marek wrote: >> Dne 14.6.2016 v 18:39 Kees Cook napsal(a): >>> On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell >>> wrote: >>>> Hi Michal, >>>> >>

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-08 Thread Michal Marek
On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: > Debian started to build the gcc with -fPIE by default so the kernel > build ends before it starts properly with: > |kernel/bounds.c:1:0: error: code model kernel does not support PIC mode > > Also add to KBUILD_AFLAGS due

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-09 Thread Michal Marek
Dne 9.11.2016 v 07:10 Ingo Molnar napsal(a): > > * Michal Marek wrote: > >> On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: >>> Debian started to build the gcc with -fPIE by default so the kernel >>> build ends before it starts proper

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

2016-10-11 Thread Michal Marek
On Fri, Oct 07, 2016 at 08:30:48PM +0200, Julia Lawall wrote: > > > On Fri, 7 Oct 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Fri, 7 Oct 2016 16:06:15 +0200 > > > > Use the current name (in a comment at the beginning of this script) for > > the file which was converted t

Re: [PATCH] Coccinelle: flag conditions with no effect

2016-10-11 Thread Michal Marek
On Sat, Oct 08, 2016 at 05:51:45PM +0200, Nicholas Mc Guire wrote: > Report code constructs where the if and else branch are functionally > identical. In cases where this is intended it really should be > documented - most reported cases probably are bugs. > > Signed-off-by: Nicholas Mc Guire A

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): > Hi all, > > On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot > wrote: >> >> FYI, we noticed the following commit: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> commit 784d5699eddc55878627da20d3fe0c8542e

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 11.10.2016 v 15:10 Michal Marek napsal(a): > Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): >> Hi all, >> >> On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot >> wrote: >>> >>> FYI, we noticed the following commit: >>> >>

Re: [PATCH -v1.1] kbuild: Steal gcc's pie from the very beginning

2016-11-15 Thread Michal Marek
our lowest supported gcc version is 3.2 right now. > > Signed-off-by: Borislav Petkov > Cc: sta...@vger.kernel.org > Cc: Ben Hutchings > Cc: Michal Marek > Cc: Sebastian Andrzej Siewior Thanks, applied to kbuild.git#rc-fixes. Michal

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: Kbuild: CC= handling broken for tools/

2016-11-11 Thread Michal Marek
On 2016-11-11 12:23, Jiri Slaby wrote: > Hi, > > I am trying a new gcc with new warnings enabled: > > make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o > EXTRA_CFLAGS='-Wimplicit-fallthrough=3' Note that EXTRA_CFLAGS is a makefile variable read by both kbuild and tools/build apparently. > > But t

Re: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-25 Thread Michal Marek
Dne 23.11.2016 v 20:40 Alexey Brodkin napsal(a): >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index 19cce226d1a8..44ef35d33956 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -123,9 +123,9 @@ libs-y += arch/arc/lib/ $(LIBGCC) >> boot:= arch/

Re: [PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-25 Thread Michal Marek
Dne 25.11.2016 v 13:12 Riku Voipio napsal(a): > On 22 November 2016 at 23:34, Michal Marek wrote: >> The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so >> the workaround is no longer needed. >> >> Signed-off-by: Michal Marek >> --- > Thanks

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-28 Thread Michal Marek
Dne 27.11.2016 v 17:28 Cheah Kok Cheong napsal(a): > Fix below warning when make nconfig is run initially > or after make clean. > > HOSTCC scripts/kconfig/nconf.o > scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined > #define _GNU_SOURCE > ^ > :0:0: note: this is the location of t

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-11-01 Thread Michal Marek
On 2016-10-18 03:34, Nicholas Piggin wrote: > Hi Adam, > > Thanks, this is looking good. powerpc will be able to use the generic > header. > > On Tue, 18 Oct 2016 02:16:26 +0200 > Adam Borowski wrote: > >> On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote: +#include +#

Re: [PATCH] kbuild: add %/built-in.o target in top Makefile

2016-11-01 Thread Michal Marek
On 2016-10-24 14:45, Wei Yang wrote: > diff --git a/Makefile b/Makefile > index addb235..546998e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1627,6 +1627,8 @@ endif > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > %.symtypes: %.c prepare scripts FORCE > $(Q)$(MAKE) $

[PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-03 Thread Michal Marek
); ^ ... During real build, this manifests itself by genksyms segfaulting. Reported-by: Borislav Petkov Cc: Adam Borowski Signed-off-by: Michal Marek --- include/asm-generic/asm-prototypes.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/asm

[PATCH 3/3] genksyms: Regenerate parser

2017-01-03 Thread Michal Marek
Regenerate the parser after 309d4cef4667 ("genksyms: Fix segfault with invalid declarations"). Reported-by: Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.tab.c_shipped | 474 +-- 1 file changed, 234 insertio

[PATCH 2/3] genksyms: Fix segfault with invalid declarations

2017-01-03 Thread Michal Marek
scripts/genksyms/genksyms The last one was a real-life bug with include/asm-generic/asm-prototypes.h on x86_64. Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.y | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/genksyms/parse.y b/scripts/genks

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Michal Marek
Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a): > Michal Marek writes: >> Please use the KBUILD_OUTPUT variable and not O. > Well, I can't as far as I know. I tried, see below ... > > Explanation : > - if I add just below the line "j=${i/\.[cS]/\.o}" the

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 9.12.2016 v 23:46 Dodji Seketeli napsal(a): > Hello, > > Nicholas Piggin a écrit: > > [...] > >> That said, a dwarf based checker tool should be able to do as good a job >> (maybe a bit better because report is very informative and it may pick up >> compiler alignments or padding options).

Re: [PATCH 2/2] kbuild: make modversion for exported asm symbols more convivial

2016-12-13 Thread Michal Marek
Dne 8.12.2016 v 05:24 Nicolas Pitre napsal(a): > Rather than having an asm-prototypes.h file where C prototypes for exported > asm symbols are centralized, let's have some macros that can be used > directly in the code where those symbols are exported for genksyms > consumption. Either the prototy

Re: [PATCH v3 1/1] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 11.12.2016 v 02:09 Adam Borowski napsal(a): > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 09:58, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> Does the abidiff tool handle the case when an exported symbol is moved >> between .c files? This is always a mess with genksyms, because the two >> .c files have different includ

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:36, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> A minimal example would be >> >> t1.c: >> struct s1; >> struct s2 { >> int i; >> } >> struct s3 { >> struct s1 *ptr1; >>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 11:02, Dodji Seketeli wrote: > Michal Marek a écrit: > >>> Libabigail does a "whole binary" analysis of types. >>> >>> So, consider the point of use of the type 'struct s1*'. Even if 'struct >>> s' is

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:15, Michal Marek wrote: > A minimal example would be > > t1.c: > struct s1; > struct s2 { > int i; > } > struct s3 { > struct s1 *ptr1; > struct s2 *ptr2; > } > void foo(struct s3*); > EXPORT_SYMBOL(foo); > > t2.c:

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 04:39, Nicholas Piggin wrote: > On Thu, 01 Dec 2016 02:35:54 + > Ben Hutchings wrote: >> As I understand it, genksyms incorporates the definitions of a >> function's parameter and return types - not just their names - and all >> the types they refer to, recursively. So a structu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 05:13, Don Zickus wrote: > Sorry for chiming in late, but yes RHEL is a big user of MODVERSIONS for our > kabi protection work. Despite our best intentions we still have lots of > partners and customers that provide value-add out-of-tree drivers to their > customers. These module bu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 14:58, Arnd Bergmann wrote: > On Tuesday, November 29, 2016 9:14:46 AM CET Linus Torvalds wrote: >> On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds >> wrote: >>> >>> So quite frankly, I don't want to make our kernel sources worse due to >>> broken shit tools getting something wrong t

Re: [PATCH v4] Fixes for compiling with clang

2016-12-02 Thread Michal Marek
On 2016-12-01 19:13, Peter Foley wrote: > On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek wrote: >> Dne 28.11.2016 v 07:44 Peter Foley napsal(a): >> This adds new -Wno-* options also for the gcc case, is there a reason >> for this? Also, the -Wno-missing-field-initi

[GIT PULL] kbuild misc updates for v4.10-rc1

2016-12-17 Thread Michal Marek
arm64 producing host-arch debs Andrew F. Davis (1): Coccinelle: Add misc/boolconv.cocci Anton Tikhomirov (1): kbuild/mkspec: avoid using brace expansion Michal Marek (1): Merge branch 'kbuild/rc-fixes' into kbuild/misc Vaishali Thakkar (3): Coccinelle: misc: Impr

[GIT PULL] kconfig update for v4.10-rc1

2016-12-17 Thread Michal Marek
Hi Linus, please pull these kconfig bits for v4.10-rc1: - make xconfig gui fixes - make nconfig fix for options with long prompts - fix make nconfig warning when pkg-config forces -D_GNU_SOURCE Michal The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1 (

[GIT PULL] kbuild updates for v4.10-rc1

2016-12-17 Thread Michal Marek
): x86/kbuild: enable modversions for symbols exported from asm Ard Biesheuvel (1): scripts/kallsyms: remove last remnants of --page-offset option Michal Marek (1): genksyms: Regenerate parser Nicholas Piggin (7): kbuild: kallsyms allow 3-pass generation if symbols size has

Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

2016-12-19 Thread Michal Marek
On 2016-12-18 13:35, Cheah Kok Cheong wrote: > If no duplicates found, inform user. > > Signed-off-by: Cheah Kok Cheong > --- > scripts/checkincludes.pl | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl > index 97b2c61..2

Re: default 0 if KASAN expression not working in kbuild

2016-12-19 Thread Michal Marek
On 2016-12-15 19:09, Nikolay Borisov wrote: > Hello, > > I was doing some kasan-related debugging and when I enabled it I started > getting warnings for large stackframes. So CONFIG_FRAME_WARN has : > > int "Warn for stack frames larger than (needs gcc 4.4)" > range 0 8192 > default 0 if

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri, 2016-11-25 at 10:01 -0800, Linu

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-29 Thread Michal Marek
On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote: > [Dropped Yann.] > > On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote: > > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote: > > > The Makefile does not specify -D_GNU_SOURCE. Are you add

Re: [PATCH v4] Fixes for compiling with clang

2016-11-29 Thread Michal Marek
Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > Fix reversed conditional checking if HOSTCC is clang. > Suppress warnings about unsupported optimization options. > Suppress warnings about unused functions, as they are generated for > every module and are therefore far too spammy. > Disable clang's

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it >> >> The actual logic

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > - ret

[GIT PULL] kbuild post v4.9-rc1 fixes

2016-11-18 Thread Michal Marek
Hi Linus, Here are some regression fixes for kbuild: - modversion support for exported asm symbols (Nick Piggin). The affected architectures need separate patches adding asm-prototypes.h. - fix rebuilds of lib-ksyms.o (Nick Piggin) - -fno-PIE builds (Sebastian Siewior and Borislav Petkov). This

Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

2016-12-10 Thread Michal Marek
On Mon, Oct 17, 2016 at 11:52:24AM -0500, Andrew F. Davis wrote: > Add a script to check for unneeded conversions to bool. > > Signed-off-by: Andrew F. Davis > Acked-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal

Re: [PATCH] kbuild/mkspec: avoid using brace expansion

2016-12-11 Thread Michal Marek
On Tue, Oct 25, 2016 at 06:00:44PM +0900, Anton Tikhomirov wrote: > Brace expansion might not work properly if _buildshell RPM macro > points to a shell other than bash. Particularly, with _bulidshell > defined to /bin/dash it leads to broken build and source symlinks. > > Signed-off-by: Anton Tik

Re: [PATCH] kbuild: cmd_export_list: tighten the sed script

2016-12-11 Thread Michal Marek
On Wed, Nov 16, 2016 at 07:28:39PM -0500, Nicolas Pitre wrote: > > When LTO is used, some ___ksymtab_string sections are seen by this sed > script, creating lines containing a single ) such as: > > EXPORT(foo) > ) > ) > EXPORT(bar) > > Let's make it so the + character is also required for any li

Re: [PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

2016-12-11 Thread Michal Marek
On Wed, Nov 23, 2016 at 02:12:58PM +0530, Vaishali Thakkar wrote: > Few changes to improve the results given by the irqf_oneshot.cocci: > > - Change in the matching rules to eliminate false postives in the > patch mode > - Change in the context mode to eliminate false postives in the > context

Re: [PATCH] scripts/kallsyms: remove last remnants of --page-offset option

2016-12-11 Thread Michal Marek
On Fri, Nov 25, 2016 at 08:43:55AM +, Ard Biesheuvel wrote: > On 28 October 2016 at 18:09, Ard Biesheuvel wrote: > > The implementation of the --page-offset kallsyms command line option has > > been removed, so remove it from the usage string as well. > > > > Signed-off-by: Ard Biesheuvel > >

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check doesn't work, and >> COMP

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-24 Thread Michal Marek
On 2017-03-23 13:51, Chao Peng wrote: > Compressed kernel has its own drawback: uncompressing takes time. Even > though the time is short enough to ignore for most cases but for cases that > time is critical this is still a big number. In our on-going optimization > for kernel boot time, the measur

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 09:58 Sebastian Andrzej Siewior napsal(a): > On 2017-03-24 13:35:40 [+0800], Chao Peng wrote: >> > kernel kernel sizetime in decompress_kernel > compressed (gzip)3.3M 53ms > uncompressed 14M3ms >> Exact

Re: [PATCH 0/5] Fix dead URLs to ftp.kernel.org

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 07:47 SeongJae Park napsal(a): > URLs to `ftp.kernel.org` exist here and there though `ftp.kernel.org` is > already dead [0]. This patchset fixes those URLs to use `www.kernel.org` > instead. > > The change is splitted into multiple patches for independent review and merge > of ea

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path

2017-03-15 Thread Michal Marek
Dne 15.3.2017 v 15:51 Tom Rini napsal(a): > I found https://patchwork.kernel.org/patch/9442211/ today and I see that > it was brought up again just before I sent my patch. I just want to > point out that 9442211 doesn't address arm, arc, and sh and they will > still not have a functional rpm build

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 03:07 Masahiro Yamada napsal(a): > Hello Kbuild contributors, > > > As you may notice, Michal has been busy since the beginning > of this year, and it has been getting difficult for him to > work on Kbuild on his regular basis. Yes, that's unfortunately the case. > Michal sent

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
On 2017-03-10 10:17, Stephen Rothwell wrote: > I assume that I will get a request to change the kbuild-current and > kbuilt trees in linux-next soon. In the meantime, should I remove the > current ones? There is one genksyms fix in kbuild.git#kbuild which is not in mainline. Masahiro, can you ple

Re: [PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 18:58 Will Deacon napsal(a): > Hi Michael, > > On Tue, Nov 22, 2016 at 10:34:29PM +0100, Michal Marek wrote: >> The KBUILD_IMAGE variable is used by the rpm and deb-pkg targets, which >> expect it to point to the image file in the build directory. The >

Re: Kbuild maintainership

2017-03-13 Thread Michal Marek
On 2017-03-11 06:45, Masahiro Yamada wrote: > Hi Michal, > > 2017-03-10 19:15 GMT+09:00 Michal Marek : >> On 2017-03-10 10:17, Stephen Rothwell wrote: >>> I assume that I will get a request to change the kbuild-current and >>> kbuilt trees in linux-next soon. In

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:46 SF Markus Elfring napsal(a): >> I like the code as is. > > Do you really prefer to ignore important return values in the discussed > function? You could define an xprintf() macro that checks if the return value is < 0 and simply calls perror() and exit(1) in such case. Mic

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf e

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-04 Thread Michal Marek
On 2016-11-03 20:48, SF Markus Elfring wrote: >> You could define an xprintf() macro that checks if the return value >> is < 0 and simply calls perror() and exit(1) in such case. > > Does such a macro belong to any general header file from the Linux > software library? No. Michal

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-02 Thread Michal Marek
On 2016-02-03 22:19, Al Viro wrote: > If everyone (including kbuild folks) is OK with the arch-independent parts of > this series, I'd like to put the first two commits into never-rebased branch > so that individual architecture trees could pull that and apply the > corresponding arch-dependent stu

[GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, please merge these kbuild changes for v4.8-rc1: - GCC plugin support by Emese Revfy from grsecurity, with a fixup from Kees Cook. The plugins are meant to be used for static analysis of the kernel code. Two plugins are provided already. - Reduction of the gcc commandline by Arnd Berg

[GIT PULL] kbuild misc changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, these is the non-critical part of kbuild for v4.8-rc1: - coccicheck script improvements by Luis R. Rodriguez and Deepa Dinamani - new coccinelle patches by Yann Droneaud and Vaishali Thakkar - debian packaging fixes by Wilfried Klaebe, Henning Schild and Marcin Mielniczuk. Thanks, Mic

Re: [GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Dne 2.8.2016 v 22:55 Kees Cook napsal(a): > On Tue, Aug 2, 2016 at 1:41 PM, Linus Torvalds > wrote: >> On Tue, Aug 2, 2016 at 3:00 PM, Michal Marek wrote: >>> >>> please merge these kbuild changes for v4.8-rc1: >> >> Merged. However, there were two sli

<    5   6   7   8   9   10   11   >