Re: [PATCH] kbuild: remove redundant -rR flag of hdr-inst

2014-12-03 Thread Michal Marek
On Tue, Dec 02, 2014 at 01:30:46PM +0900, Masahiro Yamada wrote: > Passing -rR for "make headers_install" is redundant because > the top Makefile has already set -rR to MAKEFLAGS. > > Signed-off-by: Masahiro Yamada > --- > > scripts/Kbuild.include | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] X.509: Fix certificate gathering again

2014-10-08 Thread Michal Marek
. Instead of prepending the absolute path and stripping it again, just check if $(srctree) and $(objtree) are different directories and add $(srctree)/*.x509 only in such case. Fixes: 7e1c047 (kbuild: Use relative path for $(objtree)) Cc: sta...@vger.kernel.org Signed-off-by: Michal Marek --- kernel

Re: [PATCH v8] checkkconfigsymbols.sh: reimplementation in python

2014-10-08 Thread Michal Marek
On 2014-10-04 11:29, Valentin Rothberg wrote: > On Wed, Oct 1, 2014 at 4:58 PM, Michal Marek wrote: >> On 2014-09-29 19:05, Valentin Rothberg wrote: >>> The scripts/checkkconfigsymbols.sh script searches Kconfig features >>> in the source code that are not defined i

Re: [PATCH v8 01/16] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel

2015-05-20 Thread Michal Marek
Dne 21.5.2015 v 07:04 Andreas Färber napsal(a): > Am 18.05.2015 um 13:47 schrieb Maxime Coquelin: > But this is definitely an improvement for ARMv7-M debugging, > > Tested-by: Andreas Färber > >> [Hi Michal, ...] could you consider >> taking it for v4.2? I applied it to kbuild.git#kbuild now.

Re: [PATCHv2] coccinelle: api: add vma_pages.cocci

2015-05-20 Thread Michal Marek
Dne 18.5.2015 v 04:25 Julia Lawall napsal(a): > On Sun, 17 May 2015, Dmitry Kalinkin wrote: >> This semantic patch replaces explicit computations of vma page count >> with explicit function call. >> >> Signed-off-by: Dmitry Kalinkin > Acked-by: Julia Lawall Thanks, applied to kbuild.git#misc. M

Re: [PATCH v6 0/2] kconfig: add xenconfig

2015-05-21 Thread Michal Marek
Dne 21.5.2015 v 02:53 Luis R. Rodriguez napsal(a): > From: "Luis R. Rodriguez" > > Michal Marek, Xen folks (David Vrabel, Konrad, Ian), which tree should > these go through? Not kbuild, if I may ask :). Otherwise people will find me in get_maintainer.pl output and keep

Re: [PATCH v2] scripts: fix link-vmlinux.sh bash-ism

2015-05-07 Thread Michal Marek
On 2015-05-07 02:36, sylvain.bertr...@gmail.com wrote: > While building linux with dash shell: > LINKvmlinux > trap: SIGHUP: bad trap > /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 > > See the following document for behavior of posix shell

Re: [PATCH] MODSIGN: Change default key details [ver #2]

2015-05-07 Thread Michal Marek
On 2015-05-07 13:00, David Howells wrote: > Michal Marek wrote: > >> are you fine with these two patches? >> >> https://lkml.org/lkml/2015/2/20/546 >> https://lkml.org/lkml/2015/5/4/614 > > Yeah, I think so. Your reasoning on the first one is sound - bu

Re: [PATCH] MODSIGN: Change default key details [ver #2]

2015-05-07 Thread Michal Marek
On Thu, May 07, 2015 at 02:15:46PM +0200, Michal Marek wrote: > That's the problem with allowing a file to be either user-supplied or > generated. We can use separate files for the user-supplied/generated > cases like below and solve this for good. Not signed off yet, because it >

Re: [PATCH] MODSIGN: Change default key details [ver #2]

2015-05-05 Thread Michal Marek
On 2015-05-04 20:45, Linus Torvalds wrote: > On Sun, May 3, 2015 at 6:45 PM, Linus Torvalds > wrote: >> >> I'd much rather see "x509.genkey" be generated with a move-if-changed >> pattern, so that it only changes if (a) it didn't exist before or (b) >> it actually has new content. > > Hmm. Someth

Re: [PATCH] MODSIGN: Change default key details [ver #2]

2015-05-06 Thread Michal Marek
On 2015-05-05 17:41, Linus Torvalds wrote: > On Tue, May 5, 2015 at 8:22 AM, Michal Marek wrote: >> On 2015-05-04 20:45, Linus Torvalds wrote: >>> >>> That still leaves the problem that the X509_CERTIFICATES variable >>> itself seems to be badly defined [..]

Re: [PATCH] builddeb: fix stripped module signatures if CONFIG_DEBUG_INFO and CONFIG_MODULE_SIG_ALL are set

2015-05-06 Thread Michal Marek
On 2015-05-04 17:37, Andrey Skvortsov wrote: > On 22 Apr, maximilian attems wrote: >> On Tue, Apr 21, 2015 at 03:58:48PM +0200, Michal Marek wrote: >>> (added Max to Cc) >>> >>> On 2015-03-16 09:20, Andrey Skvortsov wrote: >>>> If CONFIG_MODULE_SI

Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism

2015-05-06 Thread Michal Marek
On 2015-05-06 15:54, sylvain.bertr...@gmail.com wrote: > On Mon, Apr 27, 2015 at 03:25:25PM +, sylvain.bertr...@gmail.com wrote: >> On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: >>> Sorry if I wasn't clear. The changelog should contain the actu

[PATCH 1/3] X.509: Fix certificate gathering again

2015-05-19 Thread Michal Marek
separately, to ensure that signing_key.x509 appears before anything from $(srctree). Signed-off-by: Michal Marek --- kernel/Makefile | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/kernel/Makefile b/kernel/Makefile index 60c302c..dc78819 100644 --- a/kernel

[PATCH 2/3] MODSIGN: Use filechk to generate .x509.list

2015-05-19 Thread Michal Marek
From: Linus Torvalds Use the filechk Kbuild function instead of manually comparing the content of the generated file. Signed-off-by: Linus Torvalds --- kernel/Makefile | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/kernel/Makefile b/kernel/Makefile index dc7

[PATCH 3/3] MODSIGN: Split user-supplied and autogenerated signing key

2015-05-19 Thread Michal Marek
Allow the users to place signing_key.{x509,priv} and x509.genkey in the source tree. If any of these files is missing, generate the file in the build tree with an .auto suffix. This avoids problems with overwriting user-supplied files. Signed-off-by: Michal Marek --- .gitignore

Re: mod_devicetable: Make dmi_strmatch.substr const char *

2015-05-20 Thread Michal Marek
mi tables special? We use character arrays in other tables as well, to make them self-contained for modpost. > But it seems the file2alias code was rewritten in 2013 by Andreas Schwab > , and SOB Michal Marek , without > going through me. Annoying, since they had to hack it because peop

Re: Should we automatically generate a module signing key at all?

2015-05-20 Thread Michal Marek
Dne 20.5.2015 v 05:47 Jiri Kosina napsal(a): > On Tue, 19 May 2015, David Howells wrote: > >> That wouldn't very convenient for building our kernels in our build farm >> - we have a lot of machines and all of them would have to be equiped >> with the key. Besides, we *want* to discard the priva

Re: Should we automatically generate a module signing key at all?

2015-05-20 Thread Michal Marek
Dne 20.5.2015 v 00:23 David Howells napsal(a): > For my own purposes when running kernels on my test machines, I build kernels > with all the necessary drivers built in and boot them directly out of the > build tree by PXE. Then I copy any modules I'm testing by scp and use them. > I don't general

Re: [PATCH v3 1/3] x86, stackvalidate: Compile-time stack frame pointer validation

2015-05-13 Thread Michal Marek
| 11 ++ > scripts/Makefile | 1 + > scripts/Makefile.build| 22 ++- For the kbuild parts: Acked-by: Michal Marek > +int main(int argc, char *argv[]) > +{ > + struct args args; > + struct elf *elf; > + struct

Re: [PATCH] MODSIGN: Change default key details [ver #2]

2015-05-12 Thread Michal Marek
On 2015-05-08 15:05, David Howells wrote: > Michal Marek wrote: > >> +@echo >>$@ "[ req_distinguished_name ]" >> +@echo >>$@ "O = Magrathea" >> +@echo >>$@ "CN = Glacier signing key" >> +@echo >>

[GIT PULL] kbuild changes for v3.19-rc1

2014-12-19 Thread Michal Marek
defconfig targets in make help output Masahiro Yamada (2): kbuild: collect shorthands into scripts/Kbuild.include kbuild: remove redundant -rR flag of hdr-inst Michal Marek (3): kbuild: Remove duplicate $(cmd) definition in Makefile.clean kbuild: Automatically remove stale

[GIT PULL] kbuild misc changes for v3.19-rc1

2014-12-19 Thread Michal Marek
Hi Linus, there are only a few things in the misc branch: * Fix for bugon.cocci semantic patch * Kdevelop4 files are .gitignored * Put make binrpm-pkg on diet Michal The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1 (2014-10-19 18:08:38 -0700) are a

[PATCH 2/3] kconfig: Remove dead code

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/kconfig/expr.c | 4 scripts/kconfig/gconf.c | 24 scripts/kconfig/lkc.h | 1 - scripts/kconfig/util.c | 10 -- 4 files changed, 39 deletions(-) diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c index

[PATCH 3/3] kconfig: Remove unnecessary prototypes from headers

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/kconfig/confdata.c | 5 + scripts/kconfig/expr.c | 18 -- scripts/kconfig/expr.h | 5 - scripts/kconfig/lkc.h | 11 --- scripts/kconfig/lkc_proto.h | 3 --- scripts/kconfig/menu.c | 4 ++-- scripts

[PATCH 1/3] kconfig: Get rid of the P() macro in headers

2015-02-24 Thread Michal Marek
's/^P\(([^,]*), *([^,]*), *(.*)\);/\2 \1\3;/' Plus some manual adjustments. Signed-off-by: Michal Marek --- scripts/kconfig/lkc.h | 2 -- scripts/kconfig/lkc_proto.h | 88 ++--- 2 files changed, 43 insertions(+), 47 deletions(-) diff --git a/script

Re: Differences between builtins and modules

2015-02-25 Thread Michal Marek
On Tue, Feb 24, 2015 at 10:02:55PM -0300, Lucas De Marchi wrote: > On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek wrote: > > On 2015-02-23 15:30, Lucas De Marchi wrote: > >> My questions are: > >> 1) should we put *all* the "modules" in the builtin index? &

Re: [PATCH 0/5] MODSIGN: Use PKCS#7 for module signatures [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:58, David Howells wrote: > Note that the revised sign-file program no longer supports the "-s > " > option as I'm not sure what the best way to deal with this is. Do we generate > a PKCS#7 cert from the signature given, or do we get given a PKCS#7 cert? I > lean towards the latt

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:59, David Howells wrote: > + if (argc == 5) { > + dest_name = argv[4]; > + replace_orig = false; > + } else { > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0, > + "asprintf"); > + replace_orig = tr

Re: [PATCH] kconfig: fix a misspelling in scripts/kconfig/merge_config.sh

2015-02-25 Thread Michal Marek
On 2014-12-03 07:55, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/merge_config.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to kbuild.git#kconfig, sorry for the delay. Michal -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-25 Thread Michal Marek
On 2015-02-10 23:32, Paul Bolle wrote: > On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote: >> We need an update to the MAINTAINERS file if "Yann E. MORIN" >> isn't the active Kconfig maintainer anymore. > > Yes, we do. Michal, what update would you suggest? I'll revert the patch that add

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-11 Thread Michal Marek
On Sun, Mar 08, 2015 at 04:08:06PM -0700, Linus Torvalds wrote: > On Tue, Mar 3, 2015 at 5:07 PM, Valdis Kletnieks > wrote: > > > > Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps > > and forcing rebuilds even if the contents haven't changed. Add a bit of > > shell magic t

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-03-11 Thread Michal Marek
On 2015-03-10 23:44, Mikko Rapeli wrote: > On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote: >> On 2015-02-17 00:05, Mikko Rapeli wrote: >>> Exit with error if using undefined variables or if any sub command fails >>> with error return value. unidef needs

Re: [PATCH] kbuild: remove warning about "make depend"

2015-03-24 Thread Michal Marek
On 2015-02-03 11:43, Masahiro Yamada wrote: > Enough time has passed since "make depend" was deprecated. > Nobody would be in trouble without this hint. > > Signed-off-by: Masahiro Yamada I won't be surprised if some build script suddenly breaks. But such script has it coming :). Applied to kbui

Re: [PATCH 0/6] kbuild: mergeconfig: fix bugs, improve readability, and add generic entry point

2015-03-24 Thread Michal Marek
On 2015-03-13 22:29, Darren Hart wrote: > On 3/13/15, 1:27 AM, "Josh Triplett" wrote: > >> On Fri, Mar 13, 2015 at 03:21:37PM +0900, Masahiro Yamada wrote: >>> >>> This series is related to mergeconfig (scripts/kconfig/merge_config.sh): >>> >>> 1/6 and 2/6 fix bugs related to the parallel build.

Re: [PATCH 13/14] kdbus: add walk-through user space example

2015-03-24 Thread Michal Marek
Dne 24.3.2015 v 18:37 Jiri Slaby napsal(a): > On 03/24/2015, 06:15 PM, David Herrmann wrote: >> On Tue, Mar 24, 2015 at 5:46 PM, Jiri Slaby wrote: >>> Errr, no. Not only it causes build failures (even with KDBUS=n), it >>> definitely should not be built for everyone. >> >> It's only built if CONFI

Re: [PATCH] irqf_oneshot.cocci: add check of devm_request_threaded_irq()

2015-03-25 Thread Michal Marek
On Sun, Mar 22, 2015 at 11:29:13AM +0100, Julia Lawall wrote: > Acked-by: Julia Lawall > > Good fix, thanks! Applied to kbuild.git#misc. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism

2015-03-17 Thread Michal Marek
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a): > On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: >> On 2014-12-29 17:34, Sylvain BERTRAND wrote: >>> Chocked while compiling linux with dash shell instead of bash shell. >>> See: >>> http://pub

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-13 Thread Michal Marek
Dne 13.3.2015 v 05:59 Masahiro Yamada napsal(a): > 2015-03-11 19:01 GMT+09:00 Michal Marek : >> We already have it and it is called "filechk." Valdis, can you check if >> the below patch works equally well for you? > > This looks almost nice, but a few comment

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-02 Thread Michal Marek
Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a): > On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek wrote: >> On 2015-01-29 21:47, Paul Bolle wrote: >>> [Added Michal. Removed Yann.] >>> >>> On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: >>&

Re: [PATCH] kasan: fix build warnings

2015-02-04 Thread Michal Marek
On 2015-02-04 13:05, Andrey Ryabinin wrote: > Or maybe it would be be better always use -Werror in cc-option? Please don't do it. A couple of Makefiles call cc-option after we have added the user-supplied KCFLAGS to KBUILD_CFLAGS. Michal -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-28 Thread Michal Marek
On 2015-01-28 10:54, Paul Bolle wrote: > Now that we've been told Yann has disappeared, would you consider taking > this patch into one of your trees? It would be nice to have people > actually use it for a while. > > Or should we first clean up (most of) the warnings it generates? There It seems

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-29 Thread Michal Marek
On 2015-01-28 22:32, Paul Bolle wrote: > On Wed, 2015-01-28 at 16:26 +0100, Michal Marek wrote: >> On 2015-01-28 10:54, Paul Bolle wrote: >>> Now that we've been told Yann has disappeared, would you consider taking >>> this patch into one of your trees? It would be

Re: [PATCH v11 23/28] scripts/gdb: Ignore byte-compiled python files

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: > --- a/Makefile > +++ b/Makefile > @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version > .old_version $(version_h) \ > Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \ > signing_key.priv signing_key

Re: [PATCH v11 01/28] scripts/gdb: Add infrastructure

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: > --- a/scripts/Makefile > +++ b/scripts/Makefile > @@ -36,6 +36,7 @@ subdir-$(CONFIG_MODVERSIONS) += genksyms > subdir-y += mod > subdir-$(CONFIG_SECURITY_SELINUX) += selinux > subdir-$(CONFIG_DTC) += dtc > +subdir-$(CONFIG_GDB_

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-01-30 Thread Michal Marek
On 2015-01-29 21:47, Paul Bolle wrote: > [Added Michal. Removed Yann.] > > On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: >> On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez wrote: >>> On Fri, Jan 23, 2015 at 03:19:25PM +, Stefano Stabellini wrote: On Fri, 23 Jan 2015, Lu

Re: [PATCH v12 01/28] scripts/gdb: Add infrastructure

2015-01-30 Thread Michal Marek
object directory. > > Due to gdb.parse_and_eval and string redirection for gdb.execute, we > depend on gdb >= 7.2. > > This feature is enabled via CONFIG_GDB_SCRIPTS. > > CC: Michal Marek > CC: linux-kbu...@vger.kernel.org > Signed-off-by: Jan Kiszka > --- &

[PATCH] hid: Use Kbuild idiom in Makefiles

2015-01-21 Thread Michal Marek
Use -$(CONFIG_FOO) syntax to build multipart objects with optional parts, since all the config options are bool. Also, delete the obvious comments in the usbhid Makefile. Signed-off-by: Michal Marek --- drivers/hid/Makefile| 49 +++-- drivers/hid

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
On 2015-02-18 18:12, Arnd Bergmann wrote: > In the media drivers, the v4l2 core knows about all submodules > and calls into them from a common function. However this cannot > work if the modules that get called are loadable and the > core is built-in. In that case we get > > drivers/built-in.o: In

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
Dne 19.2.2015 v 15:53 Arnd Bergmann napsal(a): > On Thursday 19 February 2015 13:11:07 Michal Marek wrote: >> On 2015-02-18 18:12, Arnd Bergmann wrote: >>> In the media drivers, the v4l2 core knows about all submodules >>> and calls into them from a common function. Howe

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-20 Thread Michal Marek
On 2015-02-20 10:29, Arnd Bergmann wrote: > On Thursday 19 February 2015 16:06:18 Michal Marek wrote: >>> We have similar problems in other areas >>> of the kernel. In theory, we could enforce the VIDEO_TUNER driver to >>> be modular here by adding lots of depe

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On 2015-02-19 13:26, David Howells wrote: > Michal Marek wrote: > >> +X509_CERTIFICATES-y := $(wildcard *.x509) >> +ifneq ($(objtree),$(srctree)) >> +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509) >> +endif >> +X509_CERTIFICATES-$(CO

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On Fri, Feb 20, 2015 at 02:52:14PM +0100, Michal Marek wrote: > On 2015-02-19 13:26, David Howells wrote: > > Michal Marek wrote: > > > >> +X509_CERTIFICATES-y := $(wildcard *.x509) > >> +ifneq ($(objtree),$(srctree)) > >> +X509_CERTIFICATES-y +=

Re: Differences between builtins and modules

2015-02-23 Thread Michal Marek
On 2015-02-23 15:30, Lucas De Marchi wrote: > This could be particularly bad if in a kernel version an option was > tristate and in a new version it changed to boolean. I'm not sure if > this is common to happen in kernel. Any code that did "modprobe > " would start to fail. I think it's quite unc

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-02-17 Thread Michal Marek
On 2015-02-17 00:05, Mikko Rapeli wrote: > Exit with error if using undefined variables or if any sub command fails > with error return value. unidef needs special handling since but this can > be done without the trap. Enables exaniming intermediate files if some > commands failed. The intermedia

Re: [RFC] kbuild: make it possible to specify the module output dir

2015-02-18 Thread Michal Marek
On 2015-02-09 11:58, Kiran Raparthy wrote: > From: Rom Lemarchand > > kbuild: make it possible to specify the module output dir > > Make modinst_dir user-defined on the command line. > > This allows to do things like: > make MODLIB=output/ modinst_dir=. modules_install > > to ensure all the .k

[GIT PULL] kbuild changes for v3.20-rc1

2015-02-18 Thread Michal Marek
on to have the argument for false condition kbuild,gcov: simplify kernel/gcov/Makefile more Michal Marek (1): kbuild: Drop support for clean-rule Documentation/kbuild/makefiles.txt | 9 +++--- Kbuild | 61 +-

[GIT PULL] kbuild misc changes for v3.20-rc1

2015-02-18 Thread Michal Marek
oc of CONFIG_CC_OPTIMIZE_FOR_SIZE (2015-01-08 14:53:50 +0100) Masahiro Yamada (1): kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE Michal Marek (1): kbuild: Update documentation of clean-files and clean-dirs Sedat Dil

[GIT PULL] kconfig changes for v3.20-rc1

2015-02-18 Thread Michal Marek
Hi Linus, Yann E. Morin was supposed to take over kconfig maintainership, but this hasn't happened. So I'm sending a few kconfig patches that I collected for v3.20-rc1: - Fix for missing va_end in kconfig - merge_config.sh displays used if given too few arguments - s/boolean/bool/ in Kconfig file

Re: [PATCH v7 0/8]/[PULL REQUEST] Trim unused exported kernel symbols

2016-04-20 Thread Michal Marek
Dne 19.4.2016 v 05:32 Nicolas Pitre napsal(a): > Ping ! > > /me only hears back empty cave echoes ... Pulled now, sorry for the delay. Michal

Re: [PATCH V2 1/2] scripts: genksyms: fix resource leak

2016-04-20 Thread Michal Marek
On Tue, Apr 12, 2016 at 11:54:59PM +0300, Maxim Zhukov wrote: > This commit fixed resource leak at func main > > Signed-off-by: Maxim Zhukov Applied to kbuild.git#kbuild. Although the leak is harmless. Michal

Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses

2016-04-20 Thread Michal Marek
Dne 20.3.2016 v 13:25 Julia Lawall napsal(a): > > > On Sun, 20 Mar 2016, Vaishali Thakkar wrote: > >> Add space in front of the offending parentheses to silent the >> parse error for older Coccinelle versions. This makes the rule >> usable with all Coccinelle versions. >> >> Reported-by: Nishant

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

2016-04-20 Thread Michal Marek
On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rat

Re: [PATCH] kbuild/mkspec: support 'update-bootloader'-based systems

2016-04-20 Thread Michal Marek
On Thu, Apr 07, 2016 at 03:00:54PM +0200, Jiri Kosina wrote: > From: Jiri Kosina > > When uninstalling kernel RPM, we're unconditionally calling > "new-kernel-pkg --remove". There is of course a test whether the script exists. > This is useless on systems which are based on > 'update-bootloa

Re: [PATCH] kbuild: drop FORCE from PHONY targets

2016-04-20 Thread Michal Marek
Dne 13.3.2016 v 01:13 Masahiro Yamada napsal(a): > These targets are marked as PHONY. No need to add FORCE to their > dependency. > > Signed-off-by: Masahiro Yamada > --- > > Makefile | 8 > arch/arm/vdso/Makefile | 2 +- > arch/ia64/Makefile | 4 ++

Re: [PATCH] kbuild: specify modules(_install) as PHONY rather than FORCE

2016-04-20 Thread Michal Marek
On Sun, Mar 13, 2016 at 09:39:22AM +0900, Masahiro Yamada wrote: > As in other places, PHONY is a better fit for "modules" and > "modules_install". > > Signed-off-by: Masahiro Yamada Applied to kbuild.git#kbuild. Michal

Re: [PATCH] kbuild: mark help target as PHONY

2016-04-20 Thread Michal Marek
On Sun, Mar 13, 2016 at 09:39:55AM +0900, Masahiro Yamada wrote: > Obviously, the "help" should be a PHONY target. > > Signed-off-by: Masahiro Yamada Applied to kbuild.git#kbuild. Michal

Re: [PATCH] kbuild: delete unnecessary "@:"

2016-04-20 Thread Michal Marek
On Thu, Mar 31, 2016 at 08:14:16PM +0900, Masahiro Yamada wrote: > Since commit 2aedcd098a94 ('kbuild: suppress annoying "... is up to > date." message'), $(call if_changed,...) is evaluated to "@:" > when there is nothing to do. > > We no longer need to add "@:" after $(call if_changed,...) to >

Re: [PATCH] kbuild: drop redundant "PHONY += FORCE"

2016-04-20 Thread Michal Marek
On Fri, Apr 08, 2016 at 11:16:10AM +0900, Masahiro Yamada wrote: > "PHONY += FORCE" is already cared by scripts/Makefile.build, > which these files are included from. arch/ia64/Makefile is in fact included via the main Makefile. But this one also has the PHONY += FORCE statement. Maybe we should i

Re: [PATCH 1/2] kbuild: rename cmd_cc_i_c to cmd_cpp_i_c

2016-04-20 Thread Michal Marek
On Fri, Apr 08, 2016 at 12:00:57PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 08, 2016 at 11:24:47AM +0900, Masahiro Yamada escreveu: > > This command just preprocesses .c files into .i files, so cmd_cpp_i_c > > seems more suitable. > > Thanks for doing it to the tools/build/ copy, looks

[PATCH] kbuild: Get rid of KBUILD_STR

2016-04-20 Thread Michal Marek
The compiler can accept -DKBUILD_MODNAME="foo", it's just a matter of quoting. That way, we reduce the gcc command line a bit. Signed-off-by: Michal Marek --- scripts/Makefile.lib | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/Makefil

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

2016-03-15 Thread Michal Marek
This should go to the staging mailing list. Michal Dne 11.3.2016 v 10:22 laerdevstud...@gmail.com napsal(a): > From: Parth Sane > > Fixed netlogic checkpatch multiple assignment warning in platform_net.c > > Signed-off-by: Parth Sane > --- > drivers/staging/netlogic/platform_net.c | 3 ++- >

Re: [PATCH v6 5/8] kbuild: add fine grained build dependencies for exported symbols

2016-03-15 Thread Michal Marek
Dne 14.3.2016 v 03:42 Nicolas Pitre napsal(a): > +# Filter out exported kernel symbol names from the preprocessor output. > +# See also __KSYM_DEPS__ in include/linux/export.h. > +# We disable the depfile generation here, so as not to overwrite the existing > +# depfile while fixdep is parsing it >

Re: [PATCH v6 5/8] kbuild: add fine grained build dependencies for exported symbols

2016-03-15 Thread Michal Marek
Dne 15.3.2016 v 21:33 Michal Marek napsal(a): > Dne 14.3.2016 v 03:42 Nicolas Pitre napsal(a): >> +# Filter out exported kernel symbol names from the preprocessor output. >> +# See also __KSYM_DEPS__ in include/linux/export.h. >> +# We disable the depfile generation here, s

Re: [PATCH] kbuild: drop FORCE from PHONY targets

2016-03-15 Thread Michal Marek
Dne 15.3.2016 v 19:27 Andy Lutomirski napsal(a): > Fair enough, although I'm curious why this happens. It might be worth > changing the docs to say that .PHONY is *not* an substitute for FORCE > in that context, then. These two are unrelated, except that FORCE is redundant for a .PHONY target. FO

Re: [PATCH] kbuild: Add option to turn incompatible pointer check into error

2016-03-15 Thread Michal Marek
Dne 8.3.2016 v 10:19 Ingo Molnar napsal(a): > > * Thomas Gleixner wrote: > >> On Tue, 8 Mar 2016, Daniel Wagner wrote: >> >>> From: Daniel Wagner >>> >>> With the introduction of the simple wait API we have two very >>> similar APIs in the kernel. For example wake_up() and swake_up() >>> is onl

Re: [PATCH] kbuild: Add option to turn incompatible pointer check into error

2016-03-15 Thread Michal Marek
Dne 15.3.2016 v 22:34 Michal Marek napsal(a): > Dne 8.3.2016 v 10:19 Ingo Molnar napsal(a): >> Note that there will be a few build failures triggered by this, for example >> this >> fix from linux-next is needed: >> >>> commit db9b60400f9253c25ae639797df2d0ff

Re: linux-next: build failure after merge of the kbuild tree

2016-03-16 Thread Michal Marek
On 2016-03-16 08:53, Daniel Wagner wrote: > Hi, > > On 03/16/2016 12:58 AM, Stephen Rothwell wrote: >> After merging the kbuild tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from >> incompati

Re: [PATCH v6 5/8] kbuild: add fine grained build dependencies for exported symbols

2016-03-18 Thread Michal Marek
On 2016-03-16 00:14, Nicolas Pitre wrote: > On Tue, 15 Mar 2016, Michal Marek wrote: > >> Dne 14.3.2016 v 03:42 Nicolas Pitre napsal(a): >>> +# Filter out exported kernel symbol names from the preprocessor output. >>> +# See also __KSYM_DEPS__ in include/linux/e

Re: [PATCH 1/2] kconfig: add chomp like helper function

2016-03-19 Thread Michal Marek
On 2016-03-16 11:53, Paul Bolle wrote: > Add a helper function that strips trailing new lines and carriage > returns from strings. Call it chomp, after the perl function that > inspired it. > > Signed-off-by: Paul Bolle > --- > scripts/kconfig/confdata.c | 22 ++ > 1 file cha

Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd ... && pwd)

2016-04-18 Thread Michal Marek
On 2016-04-08 11:15, Thierry Reding wrote: > From: Thierry Reding > > Avoid forking off a shell to resolve the absolute path of the output > directory when make's builtin $(abspath ...) function will do an > adequate job. The abspath function is not available in make 3.80. Michal

Re: [PATCH] kbuild: drop redundant "PHONY += FORCE"

2016-04-25 Thread Michal Marek
On 2016-04-20 10:56, Masahiro Yamada wrote: > Hi Michal, > > 2016-04-20 17:47 GMT+09:00 Michal Marek : >> On Fri, Apr 08, 2016 at 11:16:10AM +0900, Masahiro Yamada wrote: >>> "PHONY += FORCE" is already cared by scripts/Makefile.build, >>> which the

Re: [PATCH v7 0/8]/[PULL REQUEST] Trim unused exported kernel symbols

2016-04-26 Thread Michal Marek
On 2016-04-20 21:26, Nicolas Pitre wrote: > On Wed, 20 Apr 2016, Nicolas Pitre wrote: > >> On Wed, 20 Apr 2016, Michal Marek wrote: >> >>> Dne 19.4.2016 v 05:32 Nicolas Pitre napsal(a): >>>> Ping ! >>>> >>>> /me only hears bac

Re: linux-next: Tree for Apr 22 (adjust_autoksyms.sh)

2016-04-26 Thread Michal Marek
On 2016-04-23 00:55, Randy Dunlap wrote: > On 04/22/16 12:44, Nicolas Pitre wrote: >> On Fri, 22 Apr 2016, Nicolas Pitre wrote: >> >>> On Fri, 22 Apr 2016, Randy Dunlap wrote: >>> Yes, this patch helps, but I think there is still a problem. I think that trim needs to be done after CONFIG_

Re: linux-next: build failure after merge of the block tree

2016-04-26 Thread Michal Marek
On 2016-04-26 05:38, Stephen Rothwell wrote: > Hi Nicolas, > > After merging the block tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > ERROR: ".blk_queue_write_cache" [drivers/block/virtio_blk.ko] undefined! > ERROR: ".blk_queue_write_cache" [drivers/block/ps3disk

Re: [GIT PULL] kconfig changes for v4.6-rc1

2016-03-30 Thread Michal Marek
On 2016-03-25 10:03, Geert Uytterhoeven wrote: > On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven >>> Al Viro (1): >>> unbreak allmodconfig KCONFIG_ALLCONFIG=... >> >> I can now indeed drop the >> >> CONFIG_MODULES=y >> >> line from my >> >> allmod.config >> >> However, this fix ha

Re: [PATCH 00/10] merge_config misc reworks and testcases

2015-11-06 Thread Michal Marek
On 2015-10-28 01:46, Olof Johansson wrote: > On Wed, Oct 28, 2015 at 9:42 AM, Olof Johansson wrote: >> Hi, >> >> Somewhat wide distribution list here, since I've added everyone who's >> touched the script, with the presumption that those have been the major >> users of it. Please make sure none of

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 04:20, Thiago Macieira wrote: > - qtver=`qmake -query QT_VERSION` || { \ > + qtver=`qmake -query QT_VERSION` || \ > + qtver=`qmake-qt5 -query QT_VERSION` || \ > + qtver=`qmake-qt4 -query QT_VERSION` || { \ The qtlibdir= etc assignments below still use qmake directly,

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
On 2015-11-02 04:11, Randy Dunlap wrote: > On 11/01/15 08:53, Stephen Rothwell wrote: >> Hi all, >> >> I start again a day early, and this is how you all repay me? ;-) >> >> Changes since 20151022: >> > > on x86_64: > > 'make xconfig' dies a quick death when I try to use it: > > linux-next-20151

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: > On Monday 02 November 2015 11:36:43 Michal Marek wrote: > > On 2015-11-02 04:20, Thiago Macieira wrote: > > > - qtver=`qmake -query QT_VERSION` || { \ > > > + qtver=`qmake -query QT_VERSION` || \ >

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 17:01, Thiago Macieira wrote: > On Monday 02 November 2015 16:50:33 Michal Marek wrote: >> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: >>> On Monday 02 November 2015 11:36:43 Michal Marek wrote: >>>> On 2015-11-02 04:20, Thiago

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-23 17:26, Arnd Bergmann wrote: > These are all false positives that either rob someone's time when trying > to figure out whether they are real, or they get people to send wrong > patches to shut up the warnings. [...] > diff --git a/Makefile b/Makefile > index 5e01a416c6e4..f8b921658f29

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-24 11:42, Arnd Bergmann wrote: > On Tuesday 24 November 2015 11:20:43 Michal Marek wrote: >>> diff --git a/Makefile b/Makefile >>> index 5e01a416c6e4..f8b921658f29 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -626,7 +626,11 @@ KBUIL

Re: subtle side effect of commit a1c48bb160f836

2015-07-01 Thread Michal Marek
On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: > On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: > > On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: > >> Uh, this is not what I meant. KCFLAGS is a *user* setting. It's meant to > >> be s

Re: linux-next: manual merge of the kbuild tree with Linus' tree

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 08:47 Geert Uytterhoeven napsal(a): > On Thu, Jul 2, 2015 at 2:30 AM, Stephen Rothwell > wrote: >> Today's linux-next merge of the kbuild tree got a conflict in: >> >> scripts/kconfig/Makefile >> >> between commits: >> >> 9bcd776d299e ("kconfig: clarify kvmconfig is for kvm") >

Re: ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 07:27 Vineet Gupta napsal(a): > On Wednesday 01 July 2015 08:49 PM, Michal Marek wrote: >> On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: >>> On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: >>>> On Thursday 18 June 2015 03:44 PM

Re: linux-next: manual merge of the kbuild tree with Linus' tree

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 11:18 Geert Uytterhoeven napsal(a): > On Thu, Jul 2, 2015 at 9:17 AM, Michal Marek wrote: >> Dne 2.7.2015 v 08:47 Geert Uytterhoeven napsal(a): >>> On Thu, Jul 2, 2015 at 2:30 AM, Stephen Rothwell >>> wrote: >>>> diff --cc scripts/k

Re: [PATCH 0/2] kconfig: allow use of relations other than (in)equality

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 15:04 Martin Walch napsal(a): > Hi, > >> 1: allow use of relations other than (in)equality > > I know it is a bit late for objections. Still, I want to point out that > this looks to me like a major extension to the language. > > Kconfig is a configuration language, and as far as

[GIT PULL] kconfig changes for v4.2-rc1

2015-07-02 Thread Michal Marek
Hi Linus, please pull this for v4.2-rc1: - kconfig conditions can use usual less/greater than comparisons - kconfig warns about stray characters in Kconfig files - Bogus expression simplification removed - some minor fixes The following changes since commit b787f68c36d49bb1d9236f403813641efa74a0

[GIT PULL] kbuild changes for v4.2-rc1

2015-07-02 Thread Michal Marek
Hi Linus, just a few kbuild core commits this time: - kallsyms fix for CONFIG_XIP_KERNEL - bashisms in scripts/link-vmlinux.sh fixed - Workaround to make DEBUG_INFO_REDUCED more useful yet still space efficient - clang is not wrongly detected when cross-compiling Michal The following changes s

<    4   5   6   7   8   9   10   11   >