[patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode

2007-05-30 Thread Michal Marek
i386 struct xfs_fsop_geom_v1 has no padding after the last member, so the size is different. Signed-off-by: Michal Marek <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_ioctl32.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) --- linux-2.6.o

[patch 2/3] Fix XFS_IOC_*_TO_HANDLE and XFS_IOC_{OPEN,READLINK}_BY_HANDLE in compat mode

2007-05-30 Thread Michal Marek
32bit struct xfs_fsop_handlereq has different size and offsets (due to pointers). TODO: case XFS_IOC_{FSSETDM,ATTRLIST,ATTRMULTI}_BY_HANDLE still not handled. Signed-off-by: Michal Marek <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_ioctl32.c | 63 +-

[patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-30 Thread Michal Marek
on i386 becaus of different padding). Create a new function xfs_ioctl32_bulkstat_wrap(), which allocates extra ->ubuffer and converts the elements to the 32bit format after the original ioctl returns. Same for i386 struct xfs_inogrp. Signed-off-by: Michal Marek <[EMAIL PROTECTED]>

Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode

2007-05-31 Thread Michal Marek
Arnd Bergmann wrote: > On Wednesday 30 May 2007, Chris Wedgwood wrote: >> On Wed, May 30, 2007 at 02:59:55PM +0200, Michal Marek wrote: >> >>> +typedef struct xfs_fsop_geom_v132 { >> wouldn't xfs_fsop_geom_v1_32 ... >> and xfs_fsop_geom_v1_32_t >>

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread Michal Marek
David Chinner wrote: > On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: >> +typedef struct xfs_bstat32 { >> +__u64 bs_ino; /* inode number */ >> +__u16 bs_mode;/* type and mode

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-29 Thread Michal Marek
sm for xfs_inumbers: the native formatter is just a copy_to_user, the compat formatter takes care of the different layout Signed-off-by: Michal Marek <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_ioctl.c |2 fs/xfs/linux-2.6/xfs_ioctl32.c | 259 +

Re: 2.6.22-rc6-mm1

2007-06-30 Thread Michal Marek
Andrew Morton wrote: > On Fri, 29 Jun 2007 14:32:09 +0200 > Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: >> anyway after unselecting XMON we can see: >> >> CC [M] fs/xfs/linux-2.6/xfs_ioctl32.o >> fs/xfs/linux-2.6/xfs_ioctl32.c: In function 'xfs_ioc_bulkstat_compat': >> fs/xfs/linux-2.6/xfs_ioct

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-07-02 Thread Michal Marek
David Chinner wrote: > On Tue, Jun 19, 2007 at 03:25:52PM +0200, [EMAIL PROTECTED] wrote: >> +static int xfs_bulkstat_one_compat( >> +xfs_mount_t *mp,/* mount point for filesystem */ >> +xfs_ino_t ino,/* inode number to get data for */ >> +void

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

2007-07-02 Thread Michal Marek
On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote: > David Chinner wrote: > > I think we can remove xfs_bulkstat_one_compat() completely by using > > the same method you used with the xfs_inumber_fmt functions. > > You mean xfs_ioc_bulkstat_compat() -> native

Re: [PATCH v4 0/9] coccicheck: modernize

2016-07-22 Thread Michal Marek
On 2016-07-13 23:45, Luis R. Rodriguez wrote: > On Wed, Jun 29, 2016 at 03:14:50PM -0700, Luis R. Rodriguez wrote: >> There were quite a bit of comments from the v3 series [0], since there >> was quite a bit of review needed for some other changes I've had discussions >> with Nicolas and Julia priv

Re: [PATCH 2/2] kbuild: add shell cache

2016-07-22 Thread Michal Marek
On 2016-06-27 20:28, Rabin Vincent wrote: > Running make results in over 40 invocations of the compiler just during > processing of the Makefile, before any actual rules are run. > > To reduce this overhead, cache the results of $(shell) calls to the > compiler. How do you detect when the compile

Re: [PATCH] kbuild: make samples depend on headers_install

2016-07-22 Thread Michal Marek
On 2016-07-04 16:39, Arnd Bergmann wrote: > Olof's build test setup keeps failing to compile arm64 kernels > because of a toolchain that uses outdated kernel headers: > > /work/build/batch/samples/seccomp/bpf-fancy.c:13:27: fatal error: > linux/seccomp.h: No such file or directory > > This is of

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

2016-07-22 Thread Michal Marek
es _size to be size_t instead. >> >> Note: >> >> Another way to fix the problem is to change the type of >> kexec_purgatory_size to be 'int' as there's this check in code: >> (kexec_purgatory_size <= 0) >> >> Signed-off-by: Michael Tautschnig >> Cc: Michal Marek >> Cc: Vivek Goyal [...] > Acked-by: Dave Young Applied to kbuild.git#kbuild. Michal

Re: [PATCH] builddeb: fix file permissions before packaging

2016-07-22 Thread Michal Marek
On 2016-07-07 16:50, Henning Schild wrote: > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting linux-headers

Re: Build failure in -next due to 'kbuild: allow archs to select link dead code/data elimination'

2016-09-22 Thread Michal Marek
On 2016-09-14 21:48, Guenter Roeck wrote: > On Wed, Sep 14, 2016 at 12:30:04PM +1000, Nicholas Piggin wrote: >> commit 0ae28be83b4d6cd03ef5b481487d042f2b91954e >> Author: Nicholas Piggin >> Date: Wed Sep 14 12:24:03 2016 +1000 >> >> kbuild: -ffunction-sections fix for archs with conflicting

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek
On 2016-09-15 08:08, Stephen Rothwell wrote: > Hi all, > > After merging the dax-misc tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages': > (___ksymtab+clear_pages+0x0): undefined reference to `clea

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-20 Thread Michal Marek
On 2016-05-23 17:18, Julia Lawall wrote: > > > On Mon, 23 May 2016, Yann Droneaud wrote: > >> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), >> kfree() is no more the only function to be considered: >> kzfree() should be recognized too. >> >> In particular, kzfree() must not be called o

Re: [PATCH v3] Coccinelle: noderef: Add new rules and correct the old rule

2016-06-20 Thread Michal Marek
On 2016-05-24 10:39, Julia Lawall wrote: > Acked-by: Julia Lawall > > On Tue, 24 May 2016, Vaishali Thakkar wrote: > >> Add new rules to detect the cases where sizeof is used in >> function calls as a argument. >> >> Also, for the patch mode third rule should behave same as >> second rule with a

Re: [PATCH] kbuild: setlocalversion: print error to STDERR

2016-06-20 Thread Michal Marek
On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote: > I tried to use 'make O=...' from an unclean source tree. This triggered > the error path of setlocalversion. But by printing to STDOUT, it created > a broken localversion which then caused another (unrelated) error: > > "4.7.0-rc2Erro

Re: [PATCH] coccicheck: Allow for overriding spatch flags

2016-06-20 Thread Michal Marek
On Sun, Jun 12, 2016 at 11:45:57PM +0200, Julia Lawall wrote: > > > On Sun, 12 Jun 2016, Nicolas Palix (LIG) wrote: > > > Le 12/06/16 à 21:04, Deepa Dinamani a écrit : > > > Documentation/coccinelle.txt suggests using the SPFLAGS > > > make variable to pass additional options to spatch. > > > >

Re: [PATCH 5/5] vmlinux.lds.h: replace config_enabled() with IS_ENABLED()

2016-06-20 Thread Michal Marek
Dne 14.6.2016 v 07:58 Masahiro Yamada napsal(a): > The use of config_enabled() against config options is ambiguous. > > Now, IS_ENABLED() is implemented purely with macro expansion, so > let's replace config_enabled() with IS_ENABLED(). > > Signed-off-by: Masahiro Yamada I applied the whole ser

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-21 Thread Michal Marek
Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > >> On 2016-05-23 17:18, Julia Lawall wrote: >>> >>> >>> On Mon, 23 May 2016, Yann Droneaud wrote: >>> >>>> Since commit 3ef0e5ba4

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-23 Thread Michal Marek
On 2016-09-19 22:00, Florian Fainelli wrote: > On 09/13/2016 12:24 AM, Michal Marek wrote: >> On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: >>> Hi, >>> >>> I have a root filesystem embedding filenames that look like these: >>> >&g

[PATCH] initramfs: Escape colons in depfile

2016-09-23 Thread Michal Marek
Special characters are problematic in depfiles, but we can fix colons easily. Reported-by: Florian Fainelli Signed-off-by: Michal Marek --- scripts/gen_initramfs_list.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/gen_initramfs_list.sh b/scripts

Re: [PATCH v2] Coccinelle: Script to replace allocate and memset with zalloc functions

2016-07-28 Thread Michal Marek
On 2016-07-28 10:29, Amitoj Kaur Chawla wrote: > This script finds instances of allocate and memset which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > Changes in v2: > -Modified commit message and subject There is

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-07 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for target

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-13 Thread Michal Marek
On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: > Hi, > > I have a root filesystem embedding filenames that look like these: > > /lib/data/: > > these are essentially files that can be matched against an USB > vendor/product id in an easy way. > > Now, the fun part is that thi

Re: [PATCH] scripts: Translate profile2linkerlist.

2016-08-07 Thread Michal Marek
Dne 7.8.2016 v 20:33 Jorge Natz napsal(a): > -while (<>) { > - my $line = $_; > - > - $_ =~ /\W*[0-9]+\W*([a-zA-Z\_0-9]+)\W*[0-9]+/; > - > - print "*(.text.$1)\n" [...] > + LINE=$( echo $LINE | sed -e s"/[0-9.][0-9.]*//" -e s"/[0-9.][0-9.]*$//" > | xargs) > + case $LINE in *unknown*|*to

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-24 Thread Michal Marek
On 2016-08-23 23:32, Luis R. Rodriguez wrote: > On Fri, Aug 19, 2016 at 11:07:36AM +0200, Michal Marek wrote: >> On 2016-08-18 19:55, Luis R. Rodriguez wrote: >>> On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: >>> >>>> This patchset imple

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-25 Thread Michal Marek
On 2016-08-25 09:43, Christoph Hellwig wrote: > The idea seems useful, but I reallt don't like the 'reverse-engineering' > approach. > > If we want to this properly from the ground up we should just split out > our CONFIG_ SYMBOLS into > > MODULE_* - builds exactly one module (tristate, or maybe

Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs

2016-08-26 Thread Michal Marek
On 2016-06-13 15:04, Arnd Bergmann wrote: > The genksyms helper in the kernel cannot parse a type definition > like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS > helper, causing the following EXPORT_SYMBOL() statement to be ignored > when computing the crcs, and triggering a w

Re: [PATCH 1/2] linux/kconfig.h: generalize IS_ENABLED logic

2015-10-07 Thread Michal Marek
On 2015-10-06 23:05, Rasmus Villemoes wrote: > It's not hard to generalize the macro magic used to build the > IS_ENABLED macro and friends to produce a few other potentially useful > macros: > > CHOOSE_EXPR(CONFIG_FOO, expr): if CONFIG_FOO is set expands to > expr, otherwise expands to nothing. >

Re: [GIT PULL] kbuild misc fixes for v4.2-rc1

2015-08-28 Thread Michal Marek
On 2015-08-28 00:16, Florian Fainelli wrote: > On 03/07/15 03:50, Michal Marek wrote: >> On 2015-07-03 00:25, Linus Torvalds wrote: >>> So with all these changes to the build system fro 4.2, I'm *still* >>> getting that annoying >>> >>>X

Re: [PATCH v3 0/4] scripts: add stack{usage,delta} scripts

2015-08-28 Thread Michal Marek
On 2015-08-20 11:53, Rasmus Villemoes wrote: > On Wed, Aug 19 2015, Michal Marek wrote: > >> Do you plan any new iterations, or is this final despite the [RFC]? >> If it's final, I will apply it. > > It's final, modulo a few typos I spotted. I took the opportun

Re: [PATCH 1/2] kconfig/merge_config.sh: Support KCONFIG_CONFIG

2015-10-14 Thread Michal Marek
e kvmconfig (which use merge_config.sh -m > then call a target that respects KCONFIG_CONFIG) and one for > direct use of the script without -m, which called make rules > that edit KCONFIG_CONFIG but verified a different file. > > Signed-off-by: Gabriel de Perthuis > Cc: Mic

Re: Port of [qx]config to Qt 5

2015-10-14 Thread Michal Marek
On 2015-09-22 20:36, Thiago Macieira wrote: > This patch set contains the port of qconfig to Qt 5. At the same time, > it removes Qt 2 and 3 support (the last Qt 3 release was in 2007). > > Most of the work was done by Boris Barbulovski, so many thanks! I've > reviewed and tested the changes. > >

Re: [PATCH 31/39] Port xconfig to Qt5 - Add horizontal scrollbar, and scroll per pixel.

2015-10-14 Thread Michal Marek
On 2015-09-22 20:36, Thiago Macieira wrote: > From: Boris Barbulovski > > Signed-off-by: Boris Barbulovski > Signed-off-by: Thiago Macieira > --- > scripts/kconfig/qconf.cc | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > inde

Re: [PATCH 1/2] kconfig/merge_config.sh: Support KCONFIG_CONFIG

2015-10-14 Thread Michal Marek
On 2015-10-14 15:50, Gabriel de Perthuis wrote: > Le 14/10/2015 à 12:56, Michal Marek a écrit : >> On 2015-09-09 19:33, Gabriel de Perthuis wrote: >>> All make targets support $KCONFIG_CONFIG because they >>> run scripts/kconf. Make sure merge_config.sh accesses the &g

Re: [PATCH 1/2] kconfig/merge_config.sh: Support KCONFIG_CONFIG

2015-10-14 Thread Michal Marek
e kvmconfig (which use merge_config.sh -m > then call a target that respects KCONFIG_CONFIG) and one for > direct use of the script without -m, which called make rules > that edit KCONFIG_CONFIG but verified a different file. > > Signed-off-by: Gabriel de Perthuis > Cc: Michal M

[GIT PULL] kbuild core changes for v4.3-rc1

2015-09-08 Thread Michal Marek
) Andi Kleen (1): kbuild: Fix .text.unlikely placement Masahiro Yamada (2): kbuild: fixdep: optimize code slightly kbuild: fixdep: drop meaningless hash table initialization Michal Marek (2): genksyms: Regenerate parser kbuild: Fix clang

[GIT PULL] kconfig changes for v4.3-rc1

2015-09-08 Thread Michal Marek
Hi Linux, please pull these kconfig changes for v4.3-rc1: - kconfig warns about junk characters in Kconfig files - merge_config.sh error handling - small cleanup Thanks, Michal The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754: Linux 4.2-rc1 (2015-07-05 11:01:52 -07

[GIT PULL] kbuild misc changes for v4.3-rc1

2015-09-08 Thread Michal Marek
Hi Linus, these are the non-core kbuild changes for 4.3-rc1: - deb-pkg: + module signing fix + dtb files are added to the package + do not require `hostname -f` to work during build + make deb-pkg generates a source package, bindeb-pkg has been added to only generate the binary packag

Re: [PATCH] scripts/kconfig/Makefile: Fix KBUILD_DEFCONFIG check when building with O=

2015-10-15 Thread Michal Marek
NFIG to be > a target") > Reported-by: Olof Johansson > Signed-off-by: Michael Ellerman Acked-by: Michal Marek I could have spotted it myself :-/. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [RFC, 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

2015-10-15 Thread Michal Marek
rget, using merge_config, as our defconfig, so >>>>>> adapt the logic in scripts/kconfig/Makefile to allow that. >>>>>> >>>>>> To minimise the chance of breaking anything, we first check if >>>>>> KBUILD_DEFCONFIG is a file, and if so

[PATCH 6/9] tags: Do not try to index defconfigs

2015-10-15 Thread Michal Marek
The defconfig files are in predictable locations, so there is no need to index them. Plus, the script was only looking for files named 'defconfig', which only works on a few architectures nowadays. Signed-off-by: Michal Marek --- scripts/tags.sh | 12 1 file changed, 12

[PATCH 0/9] scripts/tags.sh cleanup

2015-10-15 Thread Michal Marek
Do a cleanup of the tags.sh script, to make it easier to maintain. The main part is in patch 8/9, which unifies the rules for emacs etags and exuberant ctags . Some of the fixes uncovered coding style issues in random source files, which are also fixed by this series. Michal Marek (9): tags

[PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-15 Thread Michal Marek
of name pattern "\1" ctags: Warning: include/kvm/arm_vgic.h:317: null expansion of name pattern "\1" Cc: kvm...@lists.cs.columbia.edu Signed-off-by: Michal Marek --- include/kvm/arm_vgic.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include

[PATCH 5/9] tags: Process Kconfig files in a single pass

2015-10-15 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/tags.sh | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 996301c3883d..7d496f602c4b 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -219,10 +219,7 @@ exuberant

[PATCH 8/9] tags: Unify emacs and exuberant rules

2015-10-15 Thread Michal Marek
these versions of the tools: Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert etags (GNU Emacs 24.5) Signed-off-by: Michal Marek --- scripts/tags.sh | 200 ++-- 1 file changed, 108 insertions(+), 92 deletions(-) mode change

[PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-15 Thread Michal Marek
syncookies.c:44: null expansion of name pattern "\1" Cc: linux-i...@vger.kernel.org Cc: xen-de...@lists.xenproject.org Cc: linux-a...@vger.kernel.org Cc: rds-de...@oss.oracle.com Cc: net...@vger.kernel.org Signed-off-by: Michal Marek --- arch/ia64/kernel/smp.c | 3 +-- drivers/acpi/processo

[PATCH 7/9] tags: Drop the _PE rule

2015-10-15 Thread Michal Marek
We are not indexing the userspace tools, so the rules only match some false positives in the kernel code. Signed-off-by: Michal Marek --- scripts/tags.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 8a03c335d107..06246b64c0a1 100755 --- a/scripts

[PATCH 1/9] tags: Treat header files as C code

2015-10-15 Thread Michal Marek
macros in the code and the C and C++ parsers fail and recover at different points. Also, qconf.h is parsed as C, but that's a negligible regression. Signed-off-by: Michal Marek --- scripts/tags.sh | 64 - 1 file changed, 32 insertions(+

[PATCH 4/9] tags: Fix erroneous pattern match in a comment

2015-10-15 Thread Michal Marek
l a better solution is found. Signed-off-by: Michal Marek --- scripts/tags.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 5b7828756083..996301c3883d 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -204,7 +204,7 @@ exuberant()

[PATCH 3/9] aic7xxx: Avoid name collision with

2015-10-15 Thread Michal Marek
pansion of name pattern "\3" Cc: linux-s...@vger.kernel.org Signed-off-by: Michal Marek --- drivers/scsi/aic7xxx/aic79xx.h | 4 ++-- drivers/scsi/aic7xxx/aic79xx_osm.h | 5 - drivers/scsi/aic7xxx/aic7xxx.h | 2 +- drivers/scsi/aic7xxx/aic7xxx_osm.h | 5 - drivers/scsi/aic7x

Re: [PATCH 39/39] Update the buildsystem for KConfig finding Qt

2015-10-16 Thread Michal Marek
On 2015-10-16 06:12, Stefan Lippers-Hollmann wrote: > Hi > > On 2015-09-22, Thiago Macieira wrote: >> The buildsystem will now only search for Qt 4 and Qt 5. Support for Qt 2 >> and 3 was dropped in the previous commits (Qt 3 was EOL'ed in 2010 or >> so...). >> >> For Qt 5, to be future-proof with

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Michal Marek
Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): > On 10/15/2015 04:16 PM, Michal Marek wrote: >> Otherwise make tags can't parse them: >> >> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern >> "\1" >> ctags: Warning: driv

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 13:31, Prarit Bhargava wrote: > > > On 10/21/2015 03:52 PM, Michal Marek wrote: >> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>> On 10/15/2015 04:16 PM, Michal Marek wrote: >>>> Otherwise make tags can't parse them: >>>>

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 14:14, Prarit Bhargava wrote: > On 10/22/2015 08:06 AM, Michal Marek wrote: >> It used to require a closing parenthesis, so it would not match the >> multiline macro invocations at all. Now it matches them, but ctags >> correctly warns that the empty string is

Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling

2015-09-04 Thread Michal Marek
On 2015-08-27 10:37, Michal Marek wrote: > On 2015-08-27 03:49, Behan Webster wrote: >> Is there any reason you renamed COMPILER? Because it breaks all the >> other patches we have queued up which use it for cross compiling. >> >> And aren't we supposed to use all

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-18 22:34, Christoffer Dall wrote: > On Thu, Oct 15, 2015 at 10:16:28PM +0200, Michal Marek wrote: >> Besides being a coding style issue, it confuses make tags: >> >> ctags: Warning: include/kvm/arm_vgic.h:307: null expansion of name pattern >> "\1

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-19 14:05, Christoffer Dall wrote: > ok, I've taken the patch. Thank you! I will remove it from my series. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH] kconfig: Fix copy&paste error

2015-10-20 Thread Michal Marek
Dne 19.10.2015 v 16:57 Jan Beulich napsal(a): On 19.10.15 at 16:51, wrote: >> Signed-off-by: Michal Sojka > > Oops - yes of course. Thanks. > > Reviewed-by: Jan Beulich Applied to kbuild.git#kconfig. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH v2] coccinelle: misc: move constants to the right

2015-10-26 Thread Michal Marek
Dne 4.9.2015 v 21:27 Julia Lawall napsal(a): > Move constants to the right in binary operators. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [PATCH] coccinelle: tests: improve odd_ptr_err.cocci

2015-10-26 Thread Michal Marek
Dne 30.8.2015 v 22:18 Julia Lawall napsal(a): > The original version only considered the case where the then branch > contains only one call to PTR_ERR. Reimplement the whole thing to allow > multiple calls, with potentially different arguments. > > Signed-off-by: Julia Lawall Applied to kbuild

Re: [PATCH] kbuild: llvmlinux: Fix -fno-delete-null-pointer-checks compiler-flag

2015-10-26 Thread Michal Marek
Dne 15.9.2015 v 05:03 Sedat Dilek napsal(a): > CLANG (here: v3.7) does not support '-fno-delete-null-pointer-checks' > as a compiler-flag. > > Fix the HOSTCFLAGS and KBUILD_CFLAGS settings accordingly. > Furthermore, move and correct the $HOSTCC check. > > Tested against Linux v4.3-rc1 and a refr

Re: [PATCH v2] Coccinelle: fix incorrect -include option transformation

2015-10-26 Thread Michal Marek
Dne 22.9.2015 v 15:27 Julia Lawall napsal(a): > On Tue, 22 Sep 2015, Andrzej Hajda wrote: > >> kbuild/gcc uses -include option to include files and -I to provide paths for >> #include <> directive. In case of spatch latter option should be prefixed >> with That hash sign in the comment was not n

Re: [PATCH] scripts/package/Makefile: Restore the RPMOPTS variable

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 02:09 Jim Davis napsal(a): > Restore the RPMOPTS variable to the rpm-pkg and binrpm-pkg targets > that commit 21a59991ce0c ("scripts/package/Makefile: rpmbuild is > needed for rpm targets") removed. > > Reported-by: Alaa Hleihel > Signed-off-by: Jim Davis If this is a regressio

Re: [PATCH] scripts/coccinelle: fix typos

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 11:35 Julia Lawall napsal(a): > Fix a couple spelling mistakes. > > Signed-off-by: Julia Lawall Applied, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

2015-10-26 Thread Michal Marek
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a): >> Remove removal and re-addition of freeing functions. > > I find such a wording confusing for a commit message. It is also a bit confusing to use the same subject for two patches in a series. How about [PATCH 1/2] coccinelle: ifnullfree: Adju

Re: [PATCH] cocinelle: iterators: semantic patch to delete unneeded of_node_put

2015-10-26 Thread Michal Marek
Dne 22.10.2015 v 22:11 Julia Lawall napsal(a): > Device node iterators perform an of_node_put on each iteration, so putting > an of_node_put before a continue results in a double put. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: s

Re: [PATCH 2/2 v2] coccinelle: ifnullfree: handle various destroy functions

2015-10-26 Thread Michal Marek
Dne 26.10.2015 v 22:28 Julia Lawall napsal(a): > Extend ifnullfree to the various destroy functions that were recently > extended to tolerate NULL arguments. > > Signed-off-by: Julia Lawall Applied both to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH v6] coccinelle: Improve checking for missing NULL terminators

2015-10-26 Thread Michal Marek
Dne 23.10.2015 v 21:35 Julia Lawall napsal(a): > Acked-by: Julia Lawall > > On Fri, 23 Oct 2015, Daniel Granat wrote: > >> * Extend checking on tables containing structures which are >> initialized without specifying member name. Added new tables >> for checking: i2c_device_id and platform_d

Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

2015-09-30 Thread Michal Marek
On 2015-10-01 08:14, Michael Ellerman wrote: > On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote: >> Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): >>> >>> >>> On 23 September 2015 19:50:52 GMT+10:00, Michal Marek >>> wrote: >>>>

Re: [PATCH 1/2] kbuild: Fix removal of the debian/ directory

2015-01-02 Thread Michal Marek
On 2014-12-31 16:50, Sedat Dilek wrote: > On Wed, Dec 31, 2014 at 4:35 PM, Michal Marek wrote: >> scripts/Makefile.clean treats absolute path specially, but >> $(objtree)/debian is no longer an absolute path since 7e1c0477 (kbuild: >> Use relative path for $(objtree). Work ar

Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism

2015-01-02 Thread Michal Marek
On 2014-12-29 17:34, Sylvain BERTRAND wrote: > Chocked while compiling linux with dash shell instead of bash shell. > See: > http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html Please describe the actual problem in the changelog. I guess it's because of the 'ERR' trap? > Cc: Ingo

Re: [PATCH 1/2] kbuild: merge bounds.h and asm-offsets.h rules

2015-01-02 Thread Michal Marek
On 2014-12-24 07:49, Masahiro Yamada wrote: > The rules "cmd_bounds" and "cmd_offsets" are almost the same. > (The difference is only the include guards.) They can be merged. Good idea. > Signed-off-by: Masahiro Yamada > --- > > Kbuild | 59 +--

Re: [PATCH v2 0/2] kbuild: Refactor ./Kbuild

2015-01-05 Thread Michal Marek
On 2015-01-05 07:57, Masahiro Yamada wrote: > Changes in v2: > - Pass the include guard as an argument of cmd_offsets > as Michal Marek suggested. > > Masahiro Yamada (2): > kbuild: merge bounds.h and asm-offsets.h rules > kbuild: remove redundant line from b

Re: deb-pkg: Cleaning of debian/*tmp files when running 'make (dist)clean'

2015-01-05 Thread Michal Marek
On 2014-12-26 19:46, Ben Hutchings wrote: > On Fri, 2014-12-26 at 13:43 +0100, Sedat Dilek wrote: >> On Fri, Dec 26, 2014 at 1:02 PM, Sedat Dilek wrote: >> [...] >>> >>> Any other make (PHONY) target I don't know? >>> >> >> I fell over "clean-dirs"... >> >> scripts/package/Makefile:93:clean-dirs +

Re: [PATCH] kconfig: use bool instead of boolean for type definition attributes

2015-01-06 Thread Michal Marek
On 2015-01-06 02:11, Christoph Jaeger wrote: > On Mon, Jan 05, 2015 at 07:47:13PM -0500, Christoph Jaeger wrote: >> On Tue, Jan 06, 2015 at 12:06:37AM +0100, Paul Bolle wrote: >>> On Mon, 2015-01-05 at 14:43 -0500, Christoph Jaeger wrote: >>>> (adding Michal Marek) &g

Re: [PATCH] scripts/package: binrpm-pkg do not create source and devel package v3

2014-12-04 Thread Michal Marek
On 2014-12-02 21:45, j.gli...@gmail.com wrote: > From: Jérôme Glisse > > When doing make binrpm-pkg we only want to build the binary and header > package as the documentation of binrpm-pkg target claims. Hence this > patch avoid building the source and devel package. This makes binrpm-pkg > targe

Re: [PATCH] scripts/package: binrpm-pkg do not build source tar file v4

2014-12-08 Thread Michal Marek
Dne 4.12.2014 v 16:53 j.gli...@gmail.com napsal(a): > From: Jérôme Glisse > > When doing make binrpm-pkg we only want to build the binary and header > package as the documentation of binrpm-pkg target claims. Hence this > patch avoid building the source and devel package. This makes binrpm-pkg >

Re: Linux 3.19-rc1 - merge window closed

2014-12-23 Thread Michal Marek
rror 2 >>>> make: *** Waiting for unfinished jobs >>> >>> Your .config works for me. Does a `make mrproper' fix it? >>> >>> I've seen a few reports like this in recent months. Something's >>> up with the build dependency system.

Re: deb-pkg: Cleaning of debian/*tmp files when running 'make (dist)clean'

2014-12-31 Thread Michal Marek
On 2014-12-26 19:46, Ben Hutchings wrote: > On Fri, 2014-12-26 at 13:43 +0100, Sedat Dilek wrote: >> On Fri, Dec 26, 2014 at 1:02 PM, Sedat Dilek wrote: >> [...] >>> >>> Any other make (PHONY) target I don't know? >>> >> >> I fell over "clean-dirs"... >> >> scripts/package/Makefile:93:clean-dirs +

Re: deb-pkg: Cleaning of debian/*tmp files when running 'make (dist)clean'

2014-12-31 Thread Michal Marek
On 2014-12-31 15:16, Sedat Dilek wrote: > On Wed, Dec 31, 2014 at 2:56 PM, Michal Marek wrote: >> The problem is that >> >> clean-dirs += $(objtree)/debian/ >> >> results in >> >> clean-dirs += ./debian/ >> >> and scripts/Makefile.clean

[PATCH 2/2] kbuild: Drop support for clean-rule

2014-12-31 Thread Michal Marek
clean-rule has not been used since 94869f86 (kbuild: Accept absolute paths in clean-files and introduce clean-dirs) ten years ago. Signed-off-by: Michal Marek --- scripts/Makefile.clean | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean index

[PATCH 1/2] kbuild: Fix removal of the debian/ directory

2014-12-31 Thread Michal Marek
path for $(objtree) Signed-off-by: Michal Marek --- scripts/Makefile.clean | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean index 1bca180..627f8cb 100644 --- a/scripts/Makefile.clean +++ b/scripts/Makefile.clean

Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed

2015-01-23 Thread Michal Marek
On 2015-01-23 02:20, Alexander Holler wrote: > I usually throw away (delete) the key used to sign modules after having > called make -jN (b)zImage modules && make -jN modules_install. Because I've > got bored to always have to type rm signing_key.* afterwards, I've build > this patch some time ago.

Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed

2015-01-23 Thread Michal Marek
On 2015-01-23 11:15, Alexander Holler wrote: > Am 23.01.2015 um 10:39 schrieb Alexander Holler: >> Am 23.01.2015 um 10:24 schrieb Michal Marek: >> >>>> + @rm ./signing_key.priv >>>> + @rm ./signing_key.x509 >>> >>> Why do you need to d

[PATCH] DocBook: Do not exceed argument list limit

2015-01-26 Thread Michal Marek
Use find + xargs to compress the generated manpages. Without this patch, the build can fail with gzip -f Documentation/DocBook/man/*.9 /bin/bash: /usr/bin/gzip: Argument list too long This happened with qemu user mode emulation on aarch64. Signed-off-by: Michal Marek --- Documentation

Re: [PATCH v4 20/20] kbuild: add a new kselftest_install make target to install selftests

2015-01-15 Thread Michal Marek
KSFT_PATH >> -- runs selftests make install target >> >> Signed-off-by: Shuah Khan >> --- >> Makefile | 14 +- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > Hi Marek, > > Could you please Ack this patch, if this version loo

Re: [PATCH 1/2] merge_config.sh: Display usage if given too few arguments

2015-01-07 Thread Michal Marek
On Thu, Dec 11, 2014 at 12:55:03PM -0800, Olof Johansson wrote: > Two or more arguments are always expected. Show usage and exit if > given less. > > Signed-off-by: Olof Johansson Applied to kbuild.git#kconfig, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 2/2] merge_config.sh: add -? for help

2015-01-07 Thread Michal Marek
On Thu, Dec 11, 2014 at 12:55:04PM -0800, Olof Johansson wrote: > It's usual enough for help text that it makes sense to support it. It's quite unusual for a *nix utility to recognize '-?'. And -h is already supported. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: Linux 3.19-rc1 - merge window closed

2015-01-07 Thread Michal Marek
Dne 23.12.2014 v 00:19 David Drysdale napsal(a): > On 22 Dec 2014 18:02, "Linus Torvalds" > wrote: > When this occurred previously, I also failed to reproduce it. However, > it appeared (https://lkml.org/lkml/2014/11/25/542) to specifically > involve a stale copy of arch/x86/include/generated/asm

[GIT PULL] make mrproper fix for v3.19-rc4

2015-01-08 Thread Michal Marek
: git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git for you to fetch changes up to a16c5f99a28c9945165c46da27fff8e6f26f8736: kbuild: Fix removal of the debian/ directory (2015-01-02 14:51:27 +0100) Michal Marek (1

Re: [GIT PULL] make mrproper fix for v3.19-rc4

2015-01-08 Thread Michal Marek
On 2015-01-08 11:49, Michal Marek wrote: > Hi Linus, > > make mrproper / distclean stopped removing the generated debian/ > directory in v3.16. Please pull the fix. > > Thanks, > Michal > > The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

[PATCH] kbuild: Update documentation of clean-files and clean-dirs

2015-01-08 Thread Michal Marek
Commit a16c5f99 (kbuild: Fix removal of the debian/ directory) slightly changed the processing of the clean-files and clean-dirs variables. Also, use a current real-world example of clean-files usage. Signed-off-by: Michal Marek --- Documentation/kbuild/makefiles.txt | 11 +-- 1 file

Re: [PATCH] kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE

2015-01-08 Thread Michal Marek
On 2014-12-11 02:46, Masahiro Yamada wrote: > Hi Michal, > > Does this seem OK? > > > > On Tue, 5 Aug 2014 14:43:07 +0900 > Masahiro Yamada wrote: > >> Other than GCC, we have another choice, Clang for building the kernel >> these days. It seems better to say "compiler" rather than "gcc". >

Re: [PATCH] kbuild: use mixed-targets when two or more config targets are given

2015-01-08 Thread Michal Marek
On 2014-12-11 11:12, Masahiro Yamada wrote: > "make kvmconfig" expects that the .config has already been created, > but some people might want to create the .config and run kvmconfig > in one shot command, like this: > > $ make defconfig kvmconfig > > To make sure this command works correctly e

[PATCH] Makefile: include arch/*/include/generated/uapi before .../generated

2015-01-08 Thread Michal Marek
kernel code. Reported-by: "Nicholas A. Bellinger" Reported-by: David Drysdale Signed-off-by: Michal Marek --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index eb4eca5..87f0c05 100644 --- a/Makefile +++ b/Makefile @@ -391,6 +391,7 @@ U

Re: [PATCH] kbuild: drop $(version_h) from MRPROPER_FILES

2015-01-08 Thread Michal Marek
On 2015-01-08 09:29, Masahiro Yamada wrote: > Now $(version_h) is include/generated/uapi/linux/version.h. > > $(version_h) in MRPROPER_FILES is redundant because it is covered > by include/generated in MRPROPER_DIRS. > > Signed-off-by: Masahiro Yamada Applied to kbuild.git#kbuild, thanks. Mich

<    1   2   3   4   5   6   7   8   9   10   >