RE: [EXT] [PATCH] infiniband/qedr: Potential null ptr dereference of qp

qp = idr_find(&dev->qpidr.idr, conn_param->qpn); > + if (unlikely(!qp)) > + return -EINVAL; > > laddr = (struct sockaddr_in *)&cm_id->m_local_addr; > raddr = (struct sockaddr_in *)&cm_id->m_remote_addr; > -- > 2.17.1 Thanks, Acked-by: Michal Kalderon

RE: [PATCH -next] RDMA/qedr: Fix error return code in qedr_iw_connect()

oto err; /* QP already being destroyed */ > + } > > rc = dev->ops->iwarp_connect(dev->rdma_ctx, &in_params, > &out_params); > if (rc) { > -- > 2.9.4 Thanks,  Acked-by: Michal Kalderon 

RE: [PATCH 4/8] qed: remove unnecessary memsets

rams; > - struct qed_resc_alloc_in_params in_params; > + struct qed_resc_alloc_out_params out_params = {0}; > + struct qed_resc_alloc_in_params in_params = {0}; > int rc; > > - memset(&in_params, 0, sizeof(in_params)); > in_params.cmd = DRV_MSG_SET_RESOURCE_VALUE_MSG; > in_params.res_id = res_id; > in_params.resc_max_val = resc_max_val; > - memset(&out_params, 0, sizeof(out_params)); > rc = qed_mcp_resc_allocation_msg(p_hwfn, p_ptt, &in_params, >&out_params); > if (rc) > @@ -3302,14 +3280,12 @@ qed_mcp_get_resc_info(struct qed_hwfn > *p_hwfn, > enum qed_resources res_id, > u32 *p_mcp_resp, u32 *p_resc_num, u32 *p_resc_start) > { > - struct qed_resc_alloc_out_params out_params; > - struct qed_resc_alloc_in_params in_params; > + struct qed_resc_alloc_out_params out_params = {0}; > + struct qed_resc_alloc_in_params in_params = {0}; > int rc; > > - memset(&in_params, 0, sizeof(in_params)); > in_params.cmd = DRV_MSG_GET_RESOURCE_ALLOC_MSG; > in_params.res_id = res_id; > - memset(&out_params, 0, sizeof(out_params)); > rc = qed_mcp_resc_allocation_msg(p_hwfn, p_ptt, &in_params, >&out_params); > if (rc) > -- > 2.20.1 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH] DMA/qedr: Use true and false for bool variable

gt; - return 0; > + return false; > > - return 1; > + return true; > } > > static inline struct qedr_user_mmap_entry * > -- > 1.8.3.1 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] Re: drivers/infiniband/hw/qedr/verbs.c:1925 qedr_create_user_qp() error: we previously assumed 'ctx' could be null (see line 1900)

rdma_protocol_roce(&dev->ibdev, 1); > > 06e8d1df46ed52 Yuval Basson 2020-07-22 1841 struct qedr_ucontext > *ctx = NULL; > > 06e8d1df46ed52 Yuval Basson 2020-07-22 1842 struct qedr_pd *pd = > NULL; > > 06e8d1df46ed52 Yuval Basson 20

RE: [EXT] [PATCH 035/141] IB/qedr: Fix fall-through warnings for Clang

nlock_irqrestore(&dev->srqs, flags); > DP_NOTICE(dev, "SRQ event %d on handle %p\n", e_code, > srq); > + break; > default: > break; > } > -- > 2.27.0 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH] net: qed: Move static keyword to the front of declaration

qed/qed_iwarp.c > @@ -382,7 +382,7 @@ qed_iwarp2roce_state(enum qed_iwarp_qp_state > state) > } > } > > -const static char *iwarp_state_names[] = { > +static const char * const iwarp_state_names[] = { > "IDLE", > "RTS", > "TERMINATE", Thanks,  Acked-by: Michal Kalderon  > -- > 2.22.1

RE: [PATCH] infiniband: hw: qedr: Remove Unneeded variable rc

_id); > kfree(qp); > } > - return rc; > + return 0; > } > > int qedr_create_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr, u32 flags, > -- > 2.7.4 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH] qed: Prefer pcie_capability_read_word()

read_dword(cdev->pdev, PCI_EXP_DEVCTL2, > +&pci_status_control); > > if (pci_status_control & PCI_EXP_DEVCTL2_LTR_EN) > SET_FIELD(dev->dev_caps, > QED_RDMA_DEV_CAP_ATOMIC_OP, 1); > -- > 2.17.1 Thanks,  Acked-by: Michal Kalderon 

[PATCH] checkpatch: add test for empty line after Fixes statement

Check that there is no empty line after a fixes statement Reviewed-by: Leon Romanovsky Signed-off-by: Michal Kalderon --- scripts/checkpatch.pl | 13 + 1 file changed, 13 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a09333fd7cef..6cbc07364d4f

RE: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement

> From: Joe Perches > Sent: Monday, May 20, 2019 3:57 PM > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes > statement > > External Email > > -- > On Mon, 2019-05-20 at 1

RE: [PATCH] qed: Fix -Wmaybe-uninitialized false positive

s/net/ethernet/qlogic/qed/qed_dev.c > @@ -652,6 +652,7 @@ static int qed_llh_abs_ppfid(struct qed_dev *cdev, u8 > ppfid, u8 *p_abs_ppfid) > DP_NOTICE(cdev, > "ppfid %d is not valid, available indices are > 0..%hhd\n", > ppfid, p_llh_info->num_ppfid - 1); > + *p_abs_ppfid = 0; > return -EINVAL; > } > > -- > 2.20.0 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH net] qed: fix error return code in qed_iwarp_ll2_start()

!iwarp_info->mpa_bufs) > + if (!iwarp_info->mpa_bufs) { > + rc = -ENOMEM; > goto err; > + } > > INIT_LIST_HEAD(&iwarp_info->mpa_buf_pending_list); > INIT_LIST_HEAD(&iwarp_info->mpa_buf_list); > -- > 2.9.5 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH v3] qedr: fix resource leak in qedr_create_qp

ext); > - int rc; > - > - if (qp->qp_type != IB_QPT_GSI) { > - rc = dev->ops->rdma_destroy_qp(dev->rdma_ctx, qp- > >qed_qp); > - if (rc) > - return rc; > - } > - > - if (qp->create_type == QEDR_QP_CREATE_USER) > - qedr_cleanup_user(dev, ctx, qp); > - else > - qedr_cleanup_kernel(dev, qp); > - > - return 0; > -} > - > int qedr_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata) { > struct qedr_qp *qp = get_qedr_qp(ibqp); > -- > 2.17.1 Thanks,  Acked-by: Michal Kalderon 

RE: [EXT] [PATCH][next] qed: fix spelling mistake "inculde" -> "include"

; native_ppfid_idx, cdev->ppfid_bitmap); > cdev->ppfid_bitmap = 0x1 << native_ppfid_idx; > } > -- > 2.20.1 Thanks,  Acked-by: Michal Kalderon 

RE: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

TE > select CRC8 > + select NET_DEVLINK > ---help--- > This enables the support for ... > > -- > 2.7.4 > Thanks,  Acked-by: Michal Kalderon