the state is actually a value and not a bitfield.
>
> Fix the wait function to report either state as ready.
>
> Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Michael Tretter
> ---
On Wed, 10 Feb 2021 18:49:38 +, Colin King wrote:
> From: Colin Ian King
>
> The pointer 'divider' has previously been null checked followed by
> a return, hence the subsequent null check is redundant deadcode
> that can be removed. Clean up the code and remove it.
>
> Fixes: 9c789deea206 (
On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote:
> Quoting Colin King (2021-02-10 10:49:38)
> > From: Colin Ian King
> >
> > The pointer 'divider' has previously been null checked followed by
> > a return, hence the subsequent null check is redundant deadcode
> > that can be removed. Clea
On Thu, 11 Feb 2021 09:57:00 +, Colin King wrote:
> From: Colin Ian King
>
> Currently the check for failur on the call to clk_hw_get_parent
> is checking for a null return in the divider pointer instead of
> checking the mux pointer. Fix this.
>
> Thanks to Michael T
On Fri, 29 Jan 2021 23:54:41 +, David Laight wrote:
> From: Emmanuel Arias
> > Sent: 29 January 2021 20:02
> >
> > Fix coding style using __packed sentece instead of
> > __attribute__((__packed__)).
> >
> > Signed-off-by: Emmanuel Arias
> > ---
> > drivers/staging/media/allegro-dvt/allegro-
(dev);
> + pm_runtime_put_noidle(dev);
> + pm_runtime_set_suspended(dev);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused dwc3_xlnx_suspend_common(struct device *dev)
> +{
> + struct dwc3_xlnx *priv_data = dev_get_drvdata(dev);
> +
> + clk_bulk_disable(priv_data->num_clocks, priv_
avoids mixing the unregister calls
with get_parent calls and makes the code more readable.
Reported-by: Colin Ian King
Fixes: 9c789deea206 ("soc: xilinx: vcu: implement clock provider for output
clocks")
Signed-off-by: Michael Tretter
---
Hi,
This is a cleanup and rewrite of the function
On Thu, 18 Mar 2021 12:48:06 +, Colin Ian King wrote:
> On 11/02/2021 19:05, Stephen Boyd wrote:
> > Quoting Michael Tretter (2021-02-10 23:39:06)
> >> On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote:
> >>> Quoting Colin King (2021-02-10 10:49:3
Hello,
On Mon, 28 Sep 2020 17:20:59 -0700, Wesley Cheng wrote:
> In the DWC3 databook, for a device initiated disconnect or bus reset, the
> driver is required to send dependxfer commands for any pending transfers.
> In addition, before the controller can move to the halted state, the SW
> needs t
vent IRQs to be performed in the pullup routine.
>
> Fixes: ae7e86108b12 ("usb: dwc3: Stop active transfers before halting the
> controller")
>
> Reported-by: Michael Tretter
> Signed-off-by: Wesley Cheng
Tested-by: Michael Tretter
> ---
> drivers/usb/dwc3/
On Fri, 20 Nov 2020 16:08:04 +0100, Michael Tretter wrote:
> On Thu, 19 Nov 2020 16:13:21 -0800, Wesley Cheng wrote:
> > usb_gadget_deactivate/usb_gadget_activate does not execute the UDC start
> > operation, which may leave EP0 disabled and event IRQs disabled when
> > re-ac
On Wed, 22 May 2019 17:43:49 +0900, Tomasz Figa wrote:
> On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote:
> >
> > On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote:
> > >
> > > On 4/9/19 9:11 AM, Tomasz Figa wrote:
> > > > On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote:
> > > >
> > >
On Mon, 29 Jun 2020 17:30:12 -0700, Amit Sunil Dhamne wrote:
> From: Rajan Vaja
>
> Currently firmware passes CCF specific flags to ZynqMP clock driver.
> So firmware needs to be updated if CCF flags are changed. The firmware
> should have its own 'flag number space' that is distinct from the
> c
On Mon, 20 Jul 2020 17:38:04 +0100, Colin King wrote:
> From: Colin Ian King
>
> The pointer header is an alias to msg and msg is being null checked.
> However, if msg is null then header is also null and this can lead to
> a null pointer dereference on the assignment type = header->type. Fix
> t
coding")
> Signed-off-by: Colin Ian King
Reviewed-by: Michael Tretter
> ---
>
> V2: remove need for variable type, as suggested by Michael Tretter
>
> ---
> drivers/staging/media/allegro-dvt/allegro-mail.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions
On Tue, 21 Jul 2020 23:55:30 -0700, Amit Sunil Dhamne wrote:
> From: Rajan Vaja
>
> Currently firmware passes CCF specific flags to ZynqMP clock driver.
> So firmware needs to be updated if CCF flags are changed. The firmware
> should have its own 'flag number space' that is distinct from the
> c
On Tue, 21 Jul 2020 23:55:31 -0700, Amit Sunil Dhamne wrote:
> From: Rajan Vaja
>
> Use ZynqMP specific divider clock flags instead of using CCF flags.
>
> Signed-off-by: Rajan Vaja
> Signed-off-by: Tejas Patel
> Signed-off-by: Amit Sunil Dhamne
> ---
> drivers/clk/zynqmp/clk-zynqmp.h | 9 +
topology_type {
> TYPE_INVALID,
> TYPE_MUX,
> --
> 2.7.4
>
> This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copy
On Tue, 14 May 2019 17:12:04 +0900, Tomasz Figa wrote:
> Hi Michael,
>
> On Tue, Apr 30, 2019 at 07:34:12PM +0200, Michael Tretter wrote:
> > On Thu, 24 Jan 2019 19:04:19 +0900, Tomasz Figa wrote:
>
> [snip]
>
> > > +State machine
> > > +=
On Mon, 04 Mar 2019 15:19:10 -0800, Jolly Shah wrote:
> From: Rajan Vaja
>
> Versal EEMI APIs uses clock device ID which is combination of class,
> subclass, type and clock index (e.g. 0x8104006 in which 0-13 bits are
> for index(6 in given example), 14-19 bits are for clock type (i.e pll,
> out
On Fri, 12 Apr 2019 17:50:12 +, Jolly Shah wrote:
> Hi Michael,
>
> > -Original Message-
> > From: Michael Tretter
> > Sent: Friday, April 12, 2019 2:01 AM
> > To: Jolly Shah
> > Cc: mturque...@baylibre.com; sb...@codeaurora.org; Michal Simek
&g
21 matches
Mail list logo