Re: [PATCH 1/5] staging: rtl8723bs: refactor cckrates{only}_included

On 2020-09-12 20:22, Joe Perches wrote: On Sat, 2020-09-12 at 10:45 +0200, Michael Straube wrote: Refactor cckrates_included() and cckratesonly_included() to simplify the code and improve readability. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14

[PATCH 1/2] staging: rtl8723bs: remove cckrates{only}_included()

unused variable ratelen. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 34 ++- .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 -- 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c

[PATCH 2/2] staging: rtl8723bs: remove 5 GHz code

Acoording to the TODO code valid only for 5 GHz should be removed. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Remove code path only valid for channels > 14. Signed-off-by: Michael S

[PATCH] staging: rtl8188eu: remove extra indentations

Remove extra indentations to follow kernel coding style and clear checkpatch warnings. WARNING: suspect code indent for conditional statements Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +-- .../staging/rtl8188eu/core/rtw_wlan_util.c| 48

[PATCH 1/2] staging: rtl8712: clean up comparsions to NULL

Clean up comparsions to NULL Reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_cmd.c | 4 ++-- drivers/staging/rtl8712/rtl871x_io.c | 2 +- drivers/staging/r

[PATCH 2/2] staging: rtl8712: use shorter array initializations

Use empty brace syntax to initialize zero valued arrays. Simplifies and shortens the code a little bit. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_xmit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b

[PATCH 1/2] staging: rtl8188eu: clean up block comment style issues

Clean up block comment style issues to follow kernel coding style and clear checkpatch warnings. WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube

[PATCH 2/2] staging: rtl8188eu: clean up alignment style issues

Clean up alignment style issues to follow kernel coding style and clear checkpatch issues. CHECK: Alignment should match open parenthesis Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/hal/phy.c | 21 ++-- drivers

[PATCH 2/3] staging: rtl8192u: correct placement of else if

Move 'else if' to the same line as the closing brace of the corresponding 'if' to follow kernel coding style. Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/r8192U_wx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 3/3] staging: rtl8192u: clean up comparsions to NULL

Clean up comparsions to NULL reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/r8192U_wx.c | 6 +++--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phy.c| 2

[PATCH 1/3] staging: rtl8192u: clean up blank line style issues

nes aren't necessary after an open brace '{' Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/r8192U_dm.c | 12 +-- drivers/staging/rtl8192u/r8192U_hw.h | 1 + drivers/staging/rtl8192u/r8192U_wx.c | 31 ++- drivers/staging

[PATCH 2/2] staging: rtl8188eu: clean up comparsion style issues

Move constants to the right side of comparsions to follow kernel coding style and clear checkpatch warnings. In case of comparsion to _FAIL we can use '!' since _FAIL is defined as '0'. WARNING: Comparisons should place the constant on the right side of the test Signed-off

[PATCH 1/2] staging: rtl8188eu: use __func__ in hal directory

Use __func__ instead of hardcoded function names to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/hal_intf.c | 4 +- drivers/staging/rtl8188eu/hal/odm.c | 60 +-- drivers/staging/rtl8188eu/hal/phy.c | 2

[PATCH] staging: rtl8712: use common ieee80211 constants

Many defined constants in wifi.h are unused and/or available from , some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c

[PATCH] staging: rtl8188eu: remove unused parameter

Remove unused parameter 'padapter' from rtw_os_xmit_resource_alloc(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8188eu/include/xmit_osdep.h | 3 +-- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 3 +-- 3 files

[PATCH] staging: rtl8188eu: use common ieee80211 constants

Many defined constants in wifi.h are unused and/or available from , some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ap.c | 12 ++--- drivers/staging/rtl8188eu/core

[PATCH] staging: rtl8188eu: clean up blank line style issues

K: Please don't use multiple blank lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_security.c | 6 +- drivers/staging/rtl8188eu/hal/odm.c | 1 - drivers/staging/rtl8188eu/hal/rf.c| 1 + drivers/staging/rtl8188eu/include

[PATCH] staging: rtl8188eu: remove ODM_PhyStatusQuery() wrapper

Function ODM_PhyStatusQuery() is just a wrapper around ODM_PhyStatusQuery_92CSeries(). Rename ODM_PhyStatusQuery_92CSeries() to ODM_PhyStatusQuery() and remove the wrapper. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 15 +++ 1 file changed, 3

[PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN

ETH_ALEN is defined in linux/if_ether.h which is included by osdep_service.h, so remove the redundant definition from ieee80211.h. osdep_service.h:33:#include etherdevice.h:25:#include Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/ieee80211.h | 1 - 1 file changed, 1

[PATCH 2/2] staging: rtl8188eu: remove unused definitions from ieee80211.h

MGMT_QUEUE_NUM, ETH_TYPE_LEN and PAYLOAD_TYPE_LEN are defined but not used in the driver code, so remove them. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/ieee80211.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h

Re: [PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN

On 2019-06-02 22:07, Joe Perches wrote: On Sun, 2019-06-02 at 18:35 +0200, Michael Straube wrote: ETH_ALEN is defined in linux/if_ether.h which is included by osdep_service.h, so remove the redundant definition from ieee80211.h. [] diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b

[PATCH] staging: rtl8188eu: cleanup ODM_CmnInfoPtrArrayHook()

Convert single case switch to if statement to cleanup and simplify code in ODM_CmnInfoPtrArrayHook(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b

[PATCH] staging: rtl8188eu: remove blank lines in header files

Remove blank lines in header files to clear checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/drv_types.h | 1 - drivers/staging/rtl8188eu/include/hal_com.h | 1 - drivers/staging/rtl8188eu/in

[PATCH] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

Remove unnecessary comments in hal8188e_phy_cfg.h to improve readability and clear multiple blank lines checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_phy_cfg.h | 23 --- 1 file change

[PATCH v2] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

Remove unnecessary comments in hal8188e_phy_cfg.h to improve readability and clear multiple blank lines checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- v1 -> v2 Remove one more line as suggested by Dan Carpenter. .../rtl8188eu

[PATCH 2/2] staging: rtl8188eu: add spaces around operators

Add spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 70 ++-- drivers/staging/rtl8188eu/core/rtw_security.c | 102

Re: [PATCH] staging: rtl8188eu: include: ieee80211.h: fixed multiple blank line coding style issues.

On 2020-06-29 10:09, B K Karthik wrote: removed multiple blank lines to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/ieee80211.h | 9 - 1 file changed, 9 deletions(-) Hi, those lines are already removed in commit 5bfb7eadc5874a3a08dd

[PATCH 2/3] staging: rtl8723bs: remove some ieee80211 constants from wifi.h

The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/incl

[PATCH 3/3] staging: rtl8712: remove some ieee80211 constants from wifi.h

The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/wifi.h |

[PATCH 1/3] staging: rtl8188eu: remove some ieee80211 constants from wifi.h

The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/incl

[PATCH] staging: rtl8188eu: use common packet header constants

The driver replicates the definitions of rfc1042_header and bridge_tunnel_header available from cfg80211.h. Use the common ones from cfg80211.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_recv.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions

<    1   2   3   4   5   6