[PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c

Add spaces around '+', '<<' and '*' to follow kernel coding style. Reported by checkpatch. --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_in

[PATCH v2 1/2] staging: rtl8188eu: cleanup declarations in os_intfs.c

Replace tabs with spaces and/or remove extra spaces in declarations. Signed-off-by: Michael Straube --- v1 -> v2 added missing Signed-off-by drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl818

[PATCH v2 2/2] staging: rtl8188eu: add spaces around operators in os_intfs.c

Add spaces around '+', '<<' and '*' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH] staging: rtl8188eu: cleanup indenting issue in odm.c

Cleanup indenting issue reported by checkpatch. WARNING: suspect code indent for conditional statements (8, 17) Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b

[PATCH 4/4] staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses to improve readability. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ap.c | 6 +++--- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c

[PATCH 3/4] staging: rtl8188eu: add spaces around '-' in rtw_cmd.c

Add spaces around '-' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging

[PATCH 2/4] staging: rtl8188eu: replace subtraction with result

Replace subtraction with the result to improve readability and clear missing spaces around '-' checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH 1/4] staging: rtl8188eu: add spaces around operators in rtw_ap.c

Add spaces around '+', '-' and '|' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ap.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/s

[PATCH] staging: rtl8712: get rid of IS_MCAST

Use is_multicast_ether_addr instead of custom IS_MCAST and remove the now unused IS_MCAST. All buffers are properly aligned. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- drivers/staging/rtl8712/rtl871x_recv.c | 14 +++--- drivers/staging

[PATCH] staging: rtl8188eu: replace hal_EfusePgCheckAvailableAddr()

Function hal_EfusePgCheckAvailableAddr() contains just a single if test. Remove the function and replace the call to it with the if test. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH 1/2] staging: rtl8188eu: cleanup lines ending with a '('

Cleanup checkpatch issues in usb_halinit.c. CHECK: Lines should not end with a '(' Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 2/2] staging: rtl8188eu: remove hal_init_macaddr()

Function hal_init_macaddr() just calls rtw_hal_set_hwreg(). Use rtw_hal_set_hwreg() directly and remove hal_init_macaddr(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/hal_com.c | 6 -- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 ++- drivers/staging/rtl8188eu

[PATCH 2/2] staging: rtl8188eu: remove unused function is_ap_in_wep()

Function is_ap_in_wep() is not used in the driver code, so remove it. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 30 --- .../staging/rtl8188eu/include/rtw_mlme_ext.h | 1 - 2 files changed, 31 deletions(-) diff --git a/drivers/staging

[PATCH 1/2] staging: rtl8188eu: remove unused function get_bsstype()

Function get_bsstype() is not used in the driver code, so remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 -- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8188eu: remove unused code

Remove unused and/or commented code from rtw_wlan_util.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH] staging: rtl8188eu: remove unused definitions from hal8188e_phy_reg.h

Remove unused definitions from the file hal8188e_phy_reg.h. Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_phy_reg.h | 881 -- 1 file changed, 881 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/hal8188e_phy_reg.h b/drivers/staging/rtl8188eu

[PATCH] staging: rtl8723bs: remove unused file hal_phy.c

Remove the unused file hal_phy.c. No function from this file is used in the driver code and it is not listed in the Makefile. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_phy.c | 157 1 file changed, 157 deletions(-) delete mode 100644 drivers

[PATCH] staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses in rtl8188eu_xmit.c. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers

[PATCH] staging: rtl8188eu: cleanup long line in odm.c

Align a comment to clear a line over 80 characters checkpatch warning. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index

[PATCH 1/8] staging: rtl8188eu: simplify calculation

Simpliy calcualation: * 10 / 2 can be reduced to * 5 Also cleans missing spaces checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH 6/8] staging: rtl8188eu: add missing spaces around operators

Add missing spaces around '|', '-', and '&' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --gi

[PATCH 8/8] staging: rtl8188eu: simplify function comments

Simplify function comments to a single line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core

[PATCH 2/8] staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses as reported by checkpatch and from conditionals. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH 5/8] staging: rtl8188eu: fix comparsions to false

Use if(!x) instead of if(x == false). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c index

[PATCH 4/8] staging: rtl8188eu: fix comparsions to true

Use if(x) instead of if(x == true). Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core

[PATCH 7/8] staging: rtl8188eu: fix lines over 80 characters

Wrap lines over 80 characters where appropriate to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b

[PATCH 3/8] staging: rtl8188eu: remove whitespace

Replace tabs with spaces or just remove spaces in declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 34 +-- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers

[PATCH 1/2] staging: rtl8188eu: remove unused rtw_scan_abort()

The function rtw_scan_abort() is never used, so remove it. Discovered by cppcheck. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 23 drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 - 2 files changed, 24 deletions(-) diff --git a

[PATCH 2/2] staging: rtl8188eu: remove rtw_qos.h

There is only one struct in rtw_qos.h and it is only included from drv_types.h. Move the struct into drv_types.h to reduce the number of header files. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/drv_types.h | 7 ++- drivers/staging/rtl8188eu/include/rtw_qos.h

[PATCH 2/2] staging: rtl8188eu: remove unnecessary parentheses in rtw_led.c

Remove unnecessary parentheses from conditionals. Also clears 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

Remove empty if statement from 'if - else if' and replace the else if with if. Remove the now unused variable pmlmepriv. Also clears line over 80 characters and CamelCase checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 5 + 1 file

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

On 9/5/18 10:13 AM, Dan Carpenter wrote: On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: case LED_CTL_SITE_SURVEY: - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv,

[PATCH v2 2/2] staging: rtl8188eu: remove unnecessary parentheses in rtw_led.c

Remove unnecessary parentheses from conditionals. Also clears 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v2 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

Remove emtpy if statement from 'if - else if' by moving all conditions into a single if. Also clears a line over 80 characters checkpatch warning. Signed-off-by: Michael Straube --- v2: changed patch 1/2 that was wrong. drivers/staging/rtl8188eu/core/rtw_led.c | 6 +++--- 1 file

Re: [PATCH v2 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

On 9/6/18 12:41 PM, Joe Perches wrote: On Thu, 2018-09-06 at 13:32 +0300, Dan Carpenter wrote: Thanks. Reviewed-by: Dan Carpenter Trivial, but these case statement blocks should prefer unindented blocks instead of reformatting the test. Perhaps similar to the below for each of the cases:

[PATCH 11/19] staging: rtl8188eu: rename parameter of odm_SignalScaleMapping()

Rename parameter of odm_SignalScaleMapping() to avoid CamelCase. CurrSig -> currsig Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 31 ++-- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 16/19] staging: rtl8188eu: add spaces around '+' in fw.c

Add spaces around '+' in fw.c to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/fw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging

[PATCH 08/19] staging: rtl8188eu: rename odm_QueryRxPwrPercentage()

Rename odm_QueryRxPwrPercentage() to avoid CamelCase. odm_QueryRxPwrPercentage -> odm_query_rxpwrpercentage Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 19/19] staging: rtl8188eu: fix spelling mistake in comment

Fix a spelling mistake reported by checkpatch. Caculate -> Calculate Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c b/drivers/staging/rtl8188eu/

[PATCH 06/19] staging: rtl8188eu: replace tabs with spaces in odm_hwconfig.c

Replace tabs with spaces in odm_hwconfig.c where appropriate. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c b/drivers/staging/rtl8188eu/hal

[PATCH 01/19] staging: rtl8188eu: cleanup inconsistent indenting

Cleanup all inconsistent indenting reported by smatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 2 +- .../staging/rtl8188eu/core/rtw_ieee80211.c| 2 +- drivers/staging/rtl8188eu/core/rtw_led.c | 4 ++-- drivers/staging/rtl8188eu/core

[PATCH 18/19] staging: rtl8188eu: remove braces from single if statement

Remove braces from single line if statement. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c b/drivers/staging/rtl8188eu

[PATCH 17/19] staging: rtl8188eu: remove unnecessary parentheses in odm_rtl8188e.c

Remove unnecessary parentheses in odm_rtl8188e.c. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c b/drivers/staging

[PATCH 13/19] staging: rtl8188eu: rename odm_SignalScaleMapping()

Rename odm_SignalScaleMapping to avoid CamelCase. odm_SignalScaleMapping -> odm_signal_scale_mapping Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 14/19] staging: rtl8188eu: correct block comment in bb_cfg.c

Correct block comment to clear a checkpatch warning. WARNING: Block comments should align the * on each line Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 10/19] staging: rtl8188eu: rename odm_EVMdbToPercentage()

Rename odm_EVMdbToPercentage() to avoid CamelCase. odm_EVMdbToPercentage -> odm_evm_db_to_percentage Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 15/19] staging: rtl8188eu: simplify block comment in pwrseq.c

Simplify block comment to a single line to clear a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/pwrseq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 07/19] staging: rtl8188eu: rename parameter of odm_QueryRxPwrPercentage()

Rename parameter of odm_QueryRxPwrPercentage() to avoid CamelCase. AntPower -> antpower Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c

[PATCH 12/19] staging: rtl8188eu: rename variable in odm_SignalScaleMapping()

Rename variable in odm_SignalScaleMapping() to avoid CamelCase. RetSig -> retsig Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 04/19] staging: rtl8188eu: add spaces around '+' in odm_hwconfig.c

Add spaces around '+' in odm_hwconfig.c to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_

[PATCH 05/19] staging: rtl8188eu: add spaces around '*' in odm_hwconfig.c

Add spaces around '*' in odm_hwconfig.c to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 03/19] staging: rtl8188eu: remove wrapper odm_SignalScaleMapping()

The function odm_SignalScaleMapping() is just a wrapper for odm_SignalScaleMapping_92CSeries(). Rename odm_SignalScaleMapping_92CSeries() to odm_SignalScaleMapping() and remove the wrapper. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 7 +-- 1 file

[PATCH 09/19] staging: rtl8188eu: rename parameter of odm_EVMdbToPercentage()

Rename parameter of odm_EVMdbToPercentage() to avoid CamelCase. Value -> value Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c b/drivers/stag

[PATCH 02/19] staging: rtl8188eu: rename odm_HWConfig

Rename source and header file to avoid CamelCase. odm_HWConfig.c -> odm_hwconfig.c odm_HWConfig.h -> odm_hwconfig.h Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/Makefile | 2 +- .../staging/rtl8188eu/hal/{odm_HWConfig.c => odm_hwconfig.

[PATCH] staging: rtl8712: add SPDX identifiers

This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/basic_types.h | 10

[PATCH 1/3] staging: rtl8188eu: fix line over 80 characters - style

Line break array declaration to clear a 'line over 80 characters' checkpatch warning. For consistency replace 0x0 with 0x00. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

Cleanup array declaration to clear two 'line over 80 characters' checkpatch warnings and improve readability. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 32 --- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git

[PATCH 3/3] staging: rtl8188eu: rewrite if tests - style

Rewrite if tests to clear a 'line over 80 characters' and 'Comparisons should place the constant on the right side of the test' checkpatch warning. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 1/4] staging: rtl8188eu: remove 5 GHz code from Hal_GetChnlGroup88E()

Remove code valid only for 5 GHz from Hal_GetChnlGroup88E(). This addresses the below TODO item. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Michael Straube --- .../stag

[PATCH 2/4] staging: rtl8188eu: change return type of Hal_GetChnlGroup88E()

After the removal of code valid only for 5 GHz the function Hal_GetChnlGroup88E returns always true. Change the return type to void and remove the variable bIn24G. Remove the tests for the return value and the variable bIn24G from the only user Hal_ReadTxPowerInfo88E(). Signed-off-by: Michael

[PATCH 3/4] staging: rtl8188eu: rename parameter of Hal_GetChnlGroup88E()

Rename function parameter of Hal_GetChnlGroup88E() to avoid CamelCase. pGroup -> group Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 4/4] staging: rtl8188eu: clean function definitions - style

Do not line break function definitions where not needed and move the return type to the same line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 1/3] staging: rtl8188eu: refactor SwLedControlMode1()

Refactor switch cases in SwLedControlMode1() to reduce indentation level. Also clears line over 80 characters checkpatch warnings. Suggested-by: Joe Perches Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 223 --- 1 file changed, 113 insertions

[PATCH 3/3] staging: rtl8188eu: fix lines over 80 characters in rtw_led.c

Wrap lines over 80 characters where appropriate to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging

[PATCH 2/3] staging: rtl8188eu: remove unnecessary parentheses in rtw_led.c

Remove unnecessary parentheses from conditionals. Also clears 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH] staging: rtl8188eu: change array type to u8

The the last two parameters of write_cam() have type u8. Change the type of the passed arrays from unsigned char to u8. Clears a line over 80 characters checkpatch warning. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 +++--- 1 file changed, 3 insertions

[PATCH 2/4] staging: rtl8188eu: fix comparsions to true

Use if(x) instead of if(x == true). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH 3/4] staging: rtl8188eu: remove whitespace

Replace tabs with spaces where appropriate. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core

[PATCH 4/4] staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses to follow kernel coding style and clean checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH 1/4] staging: rtl8188eu: Remove code valid only for 5 GHz

Remove code that is only valid for channels > 14. This addresses the below TODO item. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Michael Straube --- .../staging/rtl8188e

[PATCH] staging: rtl8188eu: simplify function comment

Simplify function comment to a single line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 9d567838a43a

[PATCH] staging: rtl8188eu: remove pointless comment

This comment adds no useful information to the code, so remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index

[PATCH 2/2] staging: rtl8192u: remove copying file

All source and header files have a GPL-2.0 SPDX identifier. The 'copying' file with the whole GPL text is not needed, delete it. Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/copying | 340 --- 1 file changed, 340 deletions(-) delete m

[PATCH 1/2] staging: rtl8192u: remove GPL boiler plate text

The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. The file ieee80211_module.c has a proper SPDX line, so the GPL boiler plate text is not needed. Signed-off-by: Michael Straube --- .../rtl8192u/ieee80211/ieee80211_module.c| 16

[PATCH 1/2] staging: rtl8188eu: use compound assignment operators

Use compound assignment operators to simplify the code and clear missing spaces around operators checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH] staging: rtl8188eu: Reapply "staging:r8188eu: Use lib80211 to encrypt (CCMP) tx frames"

to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer. Cc: Ivan Safonov Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_security.c | 778 ++ 1 file changed, 72 insertions(+), 706 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.

[PATCH v2] staging: rtl8188eu: Reapply "staging:r8188eu: Use lib80211 to encrypt (CCMP) tx frames"

to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer. Cc: Ivan Safonov Signed-off-by: Michael Straube --- v1 -> v2: Added missing spaces around '+' and removed unnecessary parentheses. if ((curfragnum+1) == pattrib->nr_frags) if (curfragnum + 1 == pattrib->nr_

[PATCH 2/8] staging: rtl8188eu: clean up comparsions to NULL

Clean up remaining comparsions to NULL reported by checkpatch. x == NULL -> !x x != NULL -> x Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_security.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188e

[PATCH 1/8] staging: rtl8188eu: remove unused macros and definitions

Removep unused macros and definitions from rtw_security.h leftover from previous cleanup patches. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/include/rtw_security.h | 58 --- 1 file changed, 58 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH 6/8] staging: rtl8188eu: remove cckrates{only}_included()

: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 34 +++ .../staging/rtl8188eu/include/rtw_mlme_ext.h | 3 -- 2 files changed, 4 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core

[PATCH 7/8] staging: rtl8188eu: remove unused variable ratelen

After the removal of cckrates_included() and cckrates_only_included() from rtw_wlan_util.c the variable/parameter 'ratelen' is unused now. Remove it from update_wireless_mode() and judge_network_type(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_ut

[PATCH 5/8] staging: rtl8188eu: rename struct field bUsed -> used

Rename field of struct rt_pmkid_list to avoid camel case. bUsed -> used Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 2 +- drivers/staging/rtl8188eu/include/rtw_security.h | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6 +++--- 3 fi

[PATCH 3/8] staging: rtl8188eu: rename struct field Bssid -> bssid

Rename field of struct rt_pmkid_list to avoid camel case. Bssid -> bssid Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 2 +- drivers/staging/rtl8188eu/include/rtw_security.h | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 8 3 fi

[PATCH 8/8] staging: rtl8188eu: clean up indent style issue

Replace spaces with tab to clear checkpatch error. ERROR: code indent should use tabs where possible Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b

[PATCH 4/8] staging: rtl8188eu: use ETH_ALEN

Use ETH_ALEN instead of hard coded array size. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/rtw_security.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h b/drivers/staging/rtl8188eu/include

[PATCH] staging: rtl8188eu: clean up some declarations

Clean up some array declarations in phy_iq_calibrate() to reduce indentation and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/phy.c | 33 +++-- 1 file changed, 17 insertions(+), 16 deletions(-) diff

[PATCH v2 1/2] staging: rtl8188eu: clean up some declarations

Clean up some array declarations in phy_iq_calibrate() to reduce indentation and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- v1 -> v2 Added patch that makes arrays static const. drivers/staging/rtl8188eu/hal/phy.c | 33 +++--

[PATCH v2 2/2] staging: rtl8188eu: make some arrays static const

Make some arrays in phy_iq_calibrate() static const and adjust the functions that take these arrays as parameters accordingly. Reduces object file size by 84 bytes (GCC 9.3.1 x86_64). Suggested-by: Joe Perches Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/phy.c | 21

[PATCH] staging: rtl8188eu: clean up whitespace in wpa_set_encryption()

Clean up unnecessary whitespace in wpa_set_encryption() by removing extra spaces and replacing tabs with spaces. Clears a checkpatch error. ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/ioctl_li

[PATCH] staging: rtl8188eu: use __func__ in os_dep

Use __func__ instead of hardcoded function names to clear checkpatch warnings. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/os_dep/ioctl_linux.c| 80 +-- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 36 - drivers/staging/rtl8188eu/os_dep/usb_intf.c

[PATCH] staging: rtl8188eu: remove commented defines

Remove commented defines from ioctl_linux.c. They are included from include/uapi/linux/wireless.h. Also clears a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 11 --- 1 file

[PATCH] staging: rtl8188eu: clear tabstop style issues

Clear tabstop style issues reported by checkpatch. WARNING: Statements should start on a tabstop Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

[PATCH] staging: rtl8188eu: add spaces around operators in header files

Add spaces around operators in the header files to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_rate_adaptive.h | 4 ++-- drivers/staging/rtl8188eu/include/odm_types.h| 6 +++--- drivers/staging/rtl8188eu

[PATCH 1/2] staging: rtl8188eu: clear alignment style issues

Clear checkpatch alignment style issues in rtl8188eu_recv.c. CHECK: Alignment should match open parenthesis The file is now checkpatch clean. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 2/2] staging: rtl8188eu: cleanup whitespace in declarations

Replace tabs with spaces in declarations to cleanup whitespace in rtl8188eu_recv.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c

[PATCH 1/5] staging: rtl8723bs: refactor cckrates{only}_included

Refactor cckrates_included() and cckratesonly_included() to simplify the code and improve readability. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH 4/5] staging: rtl8723bs: remove comparsions to true

Remove unnecessary comparsions to boolean values. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core

[PATCH 5/5] staging: rtl8723bs: remove 5 GHz code

Acoording to the TODO code valid only for 5 GHz should be removed. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Remove code path only valid for channels > 14. Signed-off-by: Michael S

[PATCH 3/5] staging: rtl8723bs: convert cckrates{only}_included to bool

Functions cckrates_included() and cckratesonly_included() return boolean values. Convert the return type from int to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 2/5] staging: rtl8723bs: make cckrates{only}_included static

Functions cckrates_included() and cckratesonly_included() are used only in the file core/rtw_wlan_util.c. Make them static and remove extern declarations from include/rtw_mlme_ext.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++-- drivers/staging

<    1   2   3   4   5   6   >