Cleanup style/checkpatch issues in the file core/rtw_xmit.c.
Michael Straube (8):
staging: rtl8188eu: cleanup missing spaces around operators
staging: rtl8188eu: use __func__ in qos_acm()
staging: rtl8188eu: cleanup alignment issue
staging: rtl8188eu: remove commented code
staging
Line break lines over 80 characters in rtw_get_sta_pending() to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
Remove unused commented code in the file core/rte_xmit.c.
Clears 'please, no space before tabs' and 'line over 80
characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++-
1 file changed,
Rename Hal_MappingOutPipe() to avoid CamelCase.
Hal_MappingOutPipe -> hal_mapping_out_pipe
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 fi
Rename parameter of hal_com_get_channel_plan() in header to avoid
CamelCase and match the name used in the function definition in
hal_com.c. AutoLoadFail -> load_fail
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file changed, 1 insertion(+)
Remove extra space in variable declaration.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_com.c
b/drivers/staging/rtl8188eu/hal/hal_com.c
index 6db5c34ed02e
Rename HalSetBrateCfg() to avoid CamelCase.
HalSetBrateCfg -> hal_set_brate_cfg
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 files changed
Rename parameters of HalSetBrateCfg() in header to avoid CamelCase
and match the names used in the function definition in hal_com.c.
mBratesOS -> brates
BrateCfg -> rate_cfg
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file changed, 1 insertion
The parameter 'struct adapter *padapter' of hal_com_get_channel_plan()
is unused, so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 5 ++---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 +--
drivers/staging/rtl8188eu/include
Rename parameters of Hal_MappingOutPipe() in header to avoid CamelCase
and match the names used in the function definition in hal_com.c.
pAdapter -> adapter
NumOutPipe -> numoutpipe
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file chan
The parameter 'struct adapter *adapt' of HalSetBrateCfg() is unused,
so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 files
Cleanup remaining comparsions to false.
if(x == false) -> if(!x)
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 12 ++--
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 ---
driv
On 10/3/18 11:30 PM, Joe Perches wrote:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Cleanup array declaration to clear two 'line over 80 characters'
checkpatch warnings and improve readability.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drive
On 10/3/18 11:30 PM, Joe Perches wrote:
static struct mlme_handler mlme_sta_tbl[] = {
Perhaps const here too, and as well, the struct
declaration could use const char * instead of char *
Making it const gives following warning.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function
Am 03.10.18 um 23:26 schrieb Joe Perches:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Line break array declaration to clear a 'line over 80 characters'
checkpatch warning. For consistency replace 0x0 with 0x00.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlm
Change the type of MCS_rate_1R from unsigned char to const u8.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
NOTE:
This series depends on the previous sent series.
[1/3] staging: rtl8188eu: fix line over 80 characters - style
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2
The strings in the use of struct action_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Remove spaces and/or replace tabs with spaces in some declarations
in rtw_mlme_ext.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
The strings in the uses of struct mlme_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+),
The variable AntCombination is initialized to 2 and never changed.
So the else if path is never used. Remove the dead code and the
variable AntCombination.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 38
1 file changed, 7 insertions
Add spaces around '|', '>>' and '/' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff -
On 11/1/18 4:50 PM, Yangtao Li wrote:
Signed-off-by: Yangtao Li
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
b/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
index d5001920f77c.
The function rtl8188eu_xmitframe_complete() returns true or false.
Change the return type from s32 to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c| 3 ++-
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 4 ++--
2 files changed, 4 insertions
The field accept_addba_req of struct mlme_ext_info has type bool.
Use the value of accept_addba_req directly instead of the ternary
operator in an asignment.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
The function rtw_hal_xmit() returns true or false.
Change the return type from s32 to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_intf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
The field enable of struct recv_reorder_ctrl is only used for boolean
values, so change the type from u8 to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include
Cleanup a line over 80 characters in rtw_hal_xmit() by using
if(x) instead of if(x == true). Also clears a missing spaces
around '|' checkpatch issue.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/driv
Rename the variable Max_spatial_stream to avoid CamelCase.
Max_spatial_stream -> max_spatial_stream
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Use clamp() to simplify code in odm_evm_db_to_percentage().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/drivers/staging
The variable is_cck_rate is used for boolean values, so change the
type from u8 to bool. The initializations to zero and use of ternary
operator in the assignments are unnecessary, remove them as well.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal
Use clamp() to simplify code in odm_evm_db_to_percentage().
Signed-off-by: Michael Straube
---
v1 -> v2:
Added patch with suggestions from Joe Perches applied.
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --gi
Rename the variable Max_spatial_stream to avoid CamelCase.
Max_spatial_stream -> max_spatial_stream
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/driv
On 10/21/18 2:26 PM, Joe Perches wrote:
It would be sensible to convert is_cck_rate from u8 to bool at the
same
time and remove the ternary ? true : false too.
As well, perhaps remove its apparently unnecessary initialization.
I've added a patch and resent the series. Thank you.
Michael
Simplify calcualation: * 10 / 2 can be reduced to * 5
Also cleans missing spaces checkpatch issues.
Signed-off-by: Michael Straube
---
changes in v2: fixed typo in patch 1/8 commit message
Simpliy -> Simplify
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +-
1 f
Add missing spaces around '|', '-', and '&' to follow kernel coding
style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --gi
Wrap lines over 80 characters where appropriate to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b
Simplify function comments to a single line.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Remove unnecessary parentheses as reported by checkpatch
and from conditionals.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 26 +--
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Use if(!x) instead of if(x == false).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index
Replace tabs with spaces or just remove spaces in declarations.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 34 +--
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers
On 07/14/18 19:54, Ivan Safonov wrote:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_security.c | 778 +++---
1 file changed, 72 insertions(+), 706 deletions(-)
Hi Ivan
Use is_broadcast_ether_addr instead of the MacAddr_isBcst macro.
The macro is not used anywhere else, so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/include/wifi.h | 7 ---
2 files changed, 1 insertion(+), 8
Use is_multicast_ether_addr instead of IS_MCAST.
By definition the broadcast address is also a multicast address,
so checking for !multicast in the conditional is sufficient.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
1 file changed, 1 insertion(+), 1
Remove unrequired blank lines as reported by checkpatch.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ieee80211.c| 8
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 18
drivers/staging/rtl8188eu/core/rtw_led.c | 1 -
drivers/staging/rtl8188eu/core
Cleanup comments to avoid lines over 80 characters
and follow kernel style for block comments.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Replace tabs with spaces in declarations to cleanup whitespace.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/drivers/staging/rtl8188eu
Instead of first asign 'wrqu.data.length = p - buff' use 'p - buff'
directly in min_t() in the subsequent asignment. Clears a line over
80 characters checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 3 +--
1 file change
Move the declaration of 'psec_priv' out of the else path and use it
in the if path as well to improve readability. Also clears line over
80 characters checkpatch warnings.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_li
Change '&array[0]' to just 'array' in rtw_reset_securitypriv().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/d
The local variables backup_index, backup_counter and backup_time
in rtw_reset_securitypriv() are all asigned before their uses, so
initialization to zero is not necessary.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 6 +++---
1 file changed, 3 insertions
Function sta2sta_data_frame() is only used in rtw_recv.c.
So make it static.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging
The declaration of sta2sta_data_frame() is directly above
the function definition. Remove the unnecessary declaration.
This also clears a checkpatch issue.
CHECK: Lines should not end with a '('
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 6
Defined P2P_PRIVATE_IOCTL_SET_LEN is not used in the driver code,
so remove it from wifi.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu
Enumeration P2P_PROTO_WK_ID is not used in the driver code,
so remove it from wifi.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu
According to the TODO 5 GHz code should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Remove code for channels > 14 from rtw_get_center_ch().
Signed-off-by: Michael Straube
---
d
Hi,
with commit 97a6f772f36b7f52bcfa56a581bbd2470cffe23d ("drivers: most: add USB
adapter driver")
I get build errors.
$ LANG=C make clean drivers/staging/rtl8188eu/
scripts/Makefile.clean:15: drivers/staging/most/usb/Makefile: No such file or
directory
make[5]: *** No rule to make target 'dri
Add missing braces around else arm of if else statement to clear
style issues reported by checkpatch.
CHECK: braces {} should be used on all arms of this statement
CHECK: Unbalanced braces around else statement
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 3
Rename parameters of odm_phy_status_query() to avoid camel case.
pDM_Odm -> dm_odm
pPhyInfo -> phy_info
pPhyStatus -> phy_status
pPktinfo -> pkt_info
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 9 -
drivers/staging/rtl81
Rename ODM_PhyStatusQuery() to odm_phy_status_query() to avoid camel
case.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 6 +++---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 4 ++--
drivers/staging/rtl8188eu/include/odm_hwconfig.h | 8
3
All defined P2P* in wifi.h are unused in the driver code,
so remove them.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 110 ---
1 file changed, 110 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging
All defined WFD* in wifi.h are unused in the driver code,
so remove them.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu
Functions _rtl92{c,d}_evm_db_to_percentage are functionally identical
to the generic version rtl_evm_db_to percentage. This series converts
rtl8192ce, rtl8192cu and rtl8192de to use the generic version.
Michael Straube (3):
rtlwifi: rtl8192ce: replace _rtl92c_evm_db_to_percentage with generic
Function _rtl92c_evm_db_to_percentage is functionally identical
to the generic version rtl_evm_db_to_percentage, so remove
_rtl92c_evm_db_to_percentage and use the generic version instead.
Signed-off-by: Michael Straube
---
.../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 18
Function _rtl92d_evm_db_to_percentage is functionally identical
to the generic version rtl_evm_db_to_percentage, so remove
_rtl92d_evm_db_to_percentage and use the generic version instead.
Signed-off-by: Michael Straube
---
.../wireless/realtek/rtlwifi/rtl8192de/trx.c | 18
Function _rtl92c_evm_db_to_percentage is functionally identical
to the generic version rtl_evm_db_to_percentage, so remove
_rtl92c_evm_db_to_percentage and use the generic version instead.
Signed-off-by: Michael Straube
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 23
Remove comparsion to NULL and unnecessary parentheses to avoid line
length over 80 characters and follow kernel coding style.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Remove unnecessary return statements from void functions reported by
checkpatch.
WARNING: void function return statements are not generally useful
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 -
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
Add SPDX identifier to Kconfig.
Signed-off-by: Michael Straube
---
drivers/staging/exfat/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
index 290dbfc7ace1..59e07afe249c 100644
--- a/drivers/staging/exfat/Kconfig
+++ b
Rename the local varibles max_AMPDU_len and min_MPDU_spacing to avoid
mixed case.
max_AMPDU_len -> max_ampdu_len
min_MPDU_spacing -> min_mpdu_spacing
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 12 ++--
1 file changed, 6 insertions(+), 6 del
Cleanup comments in update_hw_ht_param to follow kernel coding style
and avoid line length over 80 characters.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu
Replace tabs with spaces in declarations and reomve two blank lines in
update_hw_ht_param to cleanup whitespace and improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
Cleanup code in function update_hw_ht_param().
Michael Straube (4):
staging: rtl8188eu: convert variables from unsigned char to u8
staging: rtl8188eu: rename variables to avoid mixed case
staging: rtl8188eu: cleanup whitespace in update_hw_ht_param
staging: rtl8188eu: cleanup comments in
Convert the local variables max_AMPDU_len and min_MPDU_spacing from
unsigned char to u8 and remove unnecessary castings to u8 pointer.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
Variable badworden is asigned in two subsequent lines. So the first
asignment is useless and not needed. Also the initialization to zero
is not needed. Remove the first asignment and the initialization.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 3 +--
1
Function write_cam_from_cache in rtw_wlan_util.c is never used,
so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 13 -
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/drivers
Comparsions evaluate to bool, explicit conversion with ternary
operator is overly verbose and unnecessary, so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Remove braces from single statement if block to comply with kernel
coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
Rename local variables to avoid mixed case.
max_AMPDU_len -> max_ampdu_len
min_MPDU_spacing -> min_mpdu_spacing
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 24 +--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/d
Remove blank lines to reduce whitespace and improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core
Convert the local variables max_ampdu_len and min_mpdu_spacing from
unsigned char to u8 and remove unnecessary castings to u8 pointer.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
Use if(!x) instead of if(x == NULL).
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal
Add spaces around '+' to improve readability and follow kernel
coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 76 ++---
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/drive
Add spaces around '&' to improve readability and follow kernel
coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 38 ++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/d
Add spaces around '-' and '*' to improve readability and follow kernel
coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
Add spaces around '<<' and '>>' to improve readability and follow
kernel coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(
Add spaces around '|' to improve readability and follow kernel
coding style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl
Remove unnecessary blank line between declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 8d96227b85f6
Replace tabs with spaces in declarations to cleanup whitespace.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers
Add spaces around '*' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
Use !x instead of x == NULL. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
b/drivers/staging/rtl8188eu/hal
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging
There are no definitions of odm_DIGbyRSSI_LPS(), ODM_PhyStatusQuery()
and ODM_MacStatusQuery() in the driver code. So remove the unused
declarations from the headers odm.h and odm_hwconfig.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/odm.h | 1 -
drivers
Cleanup indenting issue reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
Add spaces around '+' and '-' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlm
On 1/17/19 8:44 PM, Joe Perches wrote:
On Thu, 2019-01-17 at 20:23 +0100, Michael Straube wrote:
Cleanup indenting issue reported by checkpatch.
CHECK: Alignment should match open parenthesis
[]
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/drivers/staging/rtl8188eu/os_dep
Replace tabs with spaces and/or remove extra spaces in declarations.
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 668
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep
301 - 400 of 531 matches
Mail list logo
