On 07/16/18 15:30, Michael Straube wrote:
On 07/14/18 19:54, Ivan Safonov wrote:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_security.c | 778 +++---
1 file changed
Use is_multicast_ether_addr instead of custom IS_MCAST in
os_dep/recv_linux.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
b/drivers
Replace tabs with spaces and/or remove spaces where appropriate.
Add a missing blank line after declarations.
Also clears checkpatch warnings.
WARNING: Statements should start on a tabstop
WARNING: suspect code indent for conditional statements (8, 17)
Signed-off-by: Michael Straube
Use is_multicast_ether_addr instead of custom IS_MCAST in
hal/rtl8188eu_xmit.c.
There is only one use, so remove the extra variable for the
result of IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_sta_mgt.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging
Replace tabs with spaces and/or remove spaces where appropriate.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/hal/rtl8188eu_xmit.c| 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
b/drivers
Cleanup a block comment to conform with kernel coding style.
Also cleans 'line over 80 characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drive
In the header rtw_iol.h there is only one function declared.
Remove the include of rtw_iol.h from files that do not use
this function.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/mac_cfg.c| 1 -
drivers/staging/rtl8188eu/hal/phy.c| 1 -
drivers/staging
Remove unnecessary parentheses from if conditions.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c
b/drivers/staging/rtl8188eu/core/rtw_iol.c
index
Rename rtw_IOL_applied to be all lowercase.
rtw_IOL_applied -> rtw_iol_applied
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_iol.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
The header osdep_service.h is included from drv_types.h,
so remove the redundant include.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_iol.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_iol.h
b/drivers/staging/rtl8188eu
the rtl8188eu code.
rtl8188eu: #define ODM_REG_RX_PATH_11N 0xC04
rtlwifi: #defnie ODM_REG_BB_RX_PATH_11N 0xC04
Signed-off-by: Michael Straube
---
.../rtl8188eu/include/odm_RegDefine11N.h | 158 --
.../staging/rtl8188eu/include/odm_precomp.h | 2 +-
2 files changed, 1
Replace tabs with spaces and/or remove spaces where appropriate.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/hal/rtl8188eu_xmit.c| 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
b/drivers
Use is_multicast_ether_addr instead of custom IS_MCAST in
hal/rtl8188eu_xmit.c.
There is only one use, so remove the extra variable for the
result of IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_sta_mgt.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging
Cleanup a block comment to conform with kernel coding style.
Also cleans 'line over 80 characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drive
Replace tabs with spaces and/or remove spaces where appropriate.
Add a missing blank line after declarations.
Also clears checkpatch warnings.
WARNING: Statements should start on a tabstop
WARNING: suspect code indent for conditional statements (8, 17)
Signed-off-by: Michael Straube
Use is_multicast_ether_addr instead of custom IS_MCAST in
os_dep/recv_linux.c.
Signed-off-by: Michael Straube
---
v2: changed duplicate subjects
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu
14
[ 22.621025] R10: R11: 0293 R12: 559278761700
[ 22.621026] R13: 0148 R14: R15: 5592787aa860
Revert the commit fixes the issues and dmesg looks good again.
Fixes: 515ce733e86e ("staging:r8188eu: Use lib80211 to encryp
On 08/05/18 16:07, Greg Kroah-Hartman wrote:
On Thu, Aug 02, 2018 at 06:35:05PM +0200, Michael Straube wrote:
On 07/16/18 15:30, Michael Straube wrote:
On 07/14/18 19:54, Ivan Safonov wrote:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Signed-off-by: Ivan
Fix comparsion to NULL issues found by checkpatch.
Use !x instead of x == NULL.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers
Remove braces from single line if statements.
Also fix a comparsion to NULL in one of the conditions.
Issues found by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
Fix checkpatch error 'do not use assignment in if condition'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers/staging
The function rtw_set_tx_chksum_offload() has empty definition.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 --
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 -
3 files changed, 9 deletions
On 06/22/18 12:57, Dan Carpenter wrote:
On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote:
On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote:
On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote:
Fix checkpatch error 'do not use assignment in if condition'.
On 06/22/18 12:28, Dan Carpenter wrote:
if (count < 1)
return -EFAULT;
- if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) {
+ if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp)))
sscanf(tmp, "%u", &g_wait_hiq_empty);
- }
The o
On 06/22/18 19:28, Joe Perches wrote:
On Fri, 2018-06-22 at 14:48 +0200, Michael Straube wrote:
On 06/22/18 12:57, Dan Carpenter wrote:
On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote:
On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote:
On Thu, Jun 21, 2018 at 08:22:30PM
ress use a random one to reduce the
likelihood of mac address collision.
Thanks to Joe Perches and Dan Carpenter.
Signed-off-by: Michael Straube
---
.../staging/rtl8723bs/core/rtw_ieee80211.c| 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drive
The function rtw_set_tx_chksum_offload() has empty definition.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 --
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 -
3 files changed, 9 deletions
Fix comparsion to NULL issues found by checkpatch.
Use !x instead of x == NULL.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers
Use the mac_pton() helper to convert the mac address string.
The functions key_char2num() and key_2char2num() are not used
anywhere else and can be removed.
This also has the benefit of validating the input since mac_pton()
returns false if the string is not valid.
Signed-off-by: Michael
Use ether_addr_copy() instead of memcpy() to copy the mac address.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers/staging
ress use a random one to reduce the
likelihood of mac address collision.
Thanks to Joe Perches and Dan Carpenter.
Signed-off-by: Michael Straube
---
.../staging/rtl8723bs/core/rtw_ieee80211.c| 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drive
The header mp_custom_oid.h is not used, so remove it.
'git grep mp_custom_oid.h drivers/staging/rtl8188eu/'
returns nothing.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/mp_custom_oid.h | 339 --
1 file changed, 339 deletions(-)
delete mode 1006
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_security.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_security.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_recv.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 35 ---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b
Use rtlwifi/phydm/phydm_reg.h instead of odm_reg.h and
remove the now unused odm_reg.h.
All defines from odm_reg.h are defined with the same values
in rtlwifi/phydm/phydm_reg.h.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/odm_precomp.h | 2 +-
drivers/staging/rtl8188eu
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_xmit.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 35 +++
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b
Remove the now unused IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/include/wifi.h
index 4a56e54e38f6..0a952edf8a81 100644
On 8/9/18 7:13 PM, Joe Perches wrote:
On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote:
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_xmit.c.
Have you verified that all accesses are __aligned(2) ?
If so, please state that in the patch description.
diff --git a
On 8/9/18 7:51 PM, Joe Perches wrote:
On Thu, 2018-08-09 at 19:42 +0200, Michael Straube wrote:
On 8/9/18 7:13 PM, Joe Perches wrote:
On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote:
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_xmit.c.
Have you verified that
On 8/9/18 8:03 PM, Michael Straube wrote:
On 8/9/18 7:51 PM, Joe Perches wrote:
On Thu, 2018-08-09 at 19:42 +0200, Michael Straube wrote:
On 8/9/18 7:13 PM, Joe Perches wrote:
On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote:
Use is_multicast_ether_addr instead of custom IS_MCAST in
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_recv.c. In all uses the address array/memory is
properly aligned.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 35 ---
1 file changed, 18 insertions(+), 17 deletions(-)
diff
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_xmit.c. In all uses the address array is properly
aligned.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 35 +++
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_security.c. In all uses the address array is properly
aligned.
Signed-off-by: Michael Straube
---
v2: checked that in all uses of is_multicast_ether_addr
the address array/memory is properly aligned and
updated the commit
Use rtlwifi/phydm/phydm_reg.h instead of odm_reg.h and
remove the now unused odm_reg.h.
All defines from odm_reg.h are defined with the same values
in rtlwifi/phydm/phydm_reg.h.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/odm_precomp.h | 2 +-
drivers/staging/rtl8188eu
Remove the now unused IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/wifi.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/include/wifi.h
index 4a56e54e38f6..0a952edf8a81 100644
On 10.08.18 11:44, Dan Carpenter wrote:
Looks good. Thanks! I reviewed the series.
Reviewed-by: Dan Carpenter
Thanks,
Michael
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_xmit.c. In all uses the address array is properly
aligned.
Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 35 +++
1 file changed, 16 insertions
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_security.c. In all uses the address array is properly
aligned.
Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
---
v2: checked that in all uses of is_multicast_ether_addr
the address array/memory is properly
Remove the now unused IS_MCAST.
Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
---
drivers/staging/rtl8188eu/include/wifi.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/include/wifi.h
index
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_recv.c. In all uses the address array/memory is
properly aligned.
Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 35 ---
1 file changed, 18
Use rtlwifi/phydm/phydm_reg.h instead of odm_reg.h and
remove the now unused odm_reg.h.
All defines from odm_reg.h are defined with the same values
in rtlwifi/phydm/phydm_reg.h.
Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
---
.../staging/rtl8188eu/include/odm_precomp.h | 2
On 08/10/18 13:31, Dan Carpenter wrote:
No no... I only gave it a Reviewed-by tag because I didn't want you to
resend again... :P
Ah, sorry. So I shouldn't have added the tag?
Should I remove it again? I guess not..
How are those tags (reviewed, acked, etc.) handled normaly?
I'm a bit confuse
The function sreset_get_wifi_status() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_sreset.c | 27 ---
.../staging/rtl8188eu/include/rtw_sreset.h| 1 -
2 files changed, 28 deletions(-)
diff
Use !x instead of x == NULL.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 89843201a338
The function rtw_calculate_wlan_pkt_size_by_attribue() also defined as
rtw_wlan_pkt_size() is never used, so remove it. Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c| 18 --
drivers/staging/rtl8188eu/include/rtw_xmit.h
Replace tabs with spaces, clears a checkpatch 'line over 80 characters'
warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drive
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/recv_osdep.h| 2 --
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 ---
2 files changed, 38 deletions(-)
diff
Replace tabs with spaces in function definition and variable
declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu
The function should_forbid_n_rate() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 35 ---
.../staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 36 deletions(-)
diff --git
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index c43e7b438058
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the code and improves readability.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/os_dep/ioctl_linux.c| 34 ++-
1 file changed, 10 insertions(+), 24 deletions(-)
diff
The function dump_txrpt_ccx_88e() is nerver used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c | 22 ---
.../staging/rtl8188eu/include/rtl8188e_xmit.h | 1 -
2 files changed, 23 deletions(-)
diff --git a
Remove unnecessary parentheses, also clears checkpatch issues about
missing spaces around '-'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal
Both osdep_service.h and drv_types.h are included from hal_intf.h,
so remove the redundant includes from hal_intf.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the code and improves readability.
You should show in the commit log that sta_addr is __aligned(2
On 07/29/18 19:59, Joe Perches wrote:
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the
On 07/29/18 20:21, Michael Straube wrote:
On 07/29/18 19:59, Joe Perches wrote:
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte
Remove unnecessary parentheses, also clears checkpatch issues about
missing spaces around '-'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index c43e7b438058
Both osdep_service.h and drv_types.h are included from hal_intf.h,
so remove the redundant includes from hal_intf.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b
Replace tabs with spaces in function definition and variable
declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/recv_osdep.h| 2 --
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 ---
2 files changed, 38 deletions(-)
diff
The function should_forbid_n_rate() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 35 ---
.../staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 36 deletions(-)
diff --git
The function dump_txrpt_ccx_88e() is nerver used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
v2: removed last patch (8/8) from the series
drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c | 22 ---
.../staging/rtl8188eu/include/rtl8188e_xmit.h | 1
On 07/30/18 11:02, Greg KH wrote:
On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote:
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
That's a bad tool then, as this is used, and the build breaks when this
patch is applied :(
On 07/30/18 11:27, Michael Straube wrote:
On 07/30/18 11:02, Greg KH wrote:
On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote:
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
That's a bad tool then, as this is used, and the
On 07/29/18 22:05, Joe Perches wrote:
On Sun, 2018-07-29 at 20:21 +0200, Michael Straube wrote:
On 07/29/18 19:59, Joe Perches wrote:
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use
Fix two lines over 80 characters by removing unnecessary parentheses.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
b/drivers/staging
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 6 +++---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211
Refactor rtw_is_cckratesonly_included() to improve readability and
slightly reduce object file size.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Refactor rtw_is_cckrates_included() to improve readability and
slightly reduce object file size.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Remove unrequired blank lines reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm.c | 1 -
drivers/staging/rtl8188eu/hal/phy.c | 3 ---
drivers/staging/rtl8188eu/hal/rf.c | 1 -
drivers/staging/rtl8188eu/hal
Replace tabs with spaces or just remove tabs where appropriate.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
b/drivers/staging
Remove unnecessary parentheses.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ieee80211.c| 20 +--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
b/drivers/staging/rtl8188eu/core
Both rtw_is_cckrates_included() and rtw_is_cckratesonly_included()
return true or false. Change the return type from uint to bool.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++--
drivers/staging/rtl8188eu/include/ieee80211.h | 4 ++--
2 files changed
Rename source and header file to avoid CamelCase.
odm_RTL8188E.c -> odm_rtl8188e.c
odm_RTL8188E.h -> odm_rtl8188e.h
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/Makefile | 2 +-
.../staging/rtl8188eu/hal/{odm_RTL8188E.c => odm_rtl8188e.
The function rtw_add_bcn_ie() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 66 --
drivers/staging/rtl8188eu/include/rtw_ap.h | 2 -
2 files changed, 68 deletions(-)
diff --git a/drivers
The function rtw_remove_bcn_ie() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 40 --
drivers/staging/rtl8188eu/include/rtw_ap.h | 2 --
2 files changed, 42 deletions(-)
diff --git a
Use x instead of x != NULL.
Use !x instead of x == NULL.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 6 +++---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 10 +-
drivers/staging
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the code and improves readability.
As required by is_broadcast_ether_addr, the address array sta_addr
is properly aligned in all uses. Thanks to Joe Perches.
Signed-off-by: Michael Straube
Remove unnecessary parentheses to improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
b/drivers/staging/rtl8188eu/os_dep
Fix indentation to clear checkpatch warnings.
WARNING: suspect code indent for conditional statements
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
drivers/staging/rtl8188eu/os_dep/usb_intf.c| 2 +-
2 files changed, 3 insertions(+), 3 deletions
Use is_multicast_ether_addr instead of custom IS_MCAST.
The variable for the result of IS_MCAST was only used in the
if conditional. So remove the extra variable and move the call
to is_multicast_ether_addr into the conditional.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core
The function rtw_get_oper_choffset() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers
The function rtw_get_oper_bw() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers
The function CAM_empty_entry() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers
The function ODM_RASupport_Init() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 10 --
.../staging/rtl8188eu/include/hal8188e_rate_adaptive.h | 2 --
2 files changed, 12 deletions
On 07/08/18 19:36, Michael Straube wrote:
On 07/08/18 18:46, Joe Perches wrote:
On Sun, 2018-07-08 at 12:38 +0200, Michael Straube wrote:
uint rtw_is_cckratesonly_included(u8 *rate)
{
while (*rate) {
u8 r = *rate & 0x7f;
if (r != 2 && r != 4 &&
1 - 100 of 531 matches
Mail list logo
