Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-10 Thread Michael Schmitz
Hi Finn, On Fri, May 11, 2018 at 11:55 AM, Finn Thain wrote: >> > What's worse, if you do pass a dma_mask in struct >> > platform_device_info, you end up with this problem in >> > platform_device_register_full(): >> > >> > if (pdevinfo->dma_mask) { >> > /* >> >

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-10 Thread Michael Schmitz
Hi Finn, Am 11.05.2018 um 15:28 schrieb Finn Thain: > On Fri, 11 May 2018, Michael Schmitz wrote: > >>>> Which begs the question: why can' you set up all Nubus bus devices' >>>> DMA masks in nubus_device_register(), or nubus_add_board()? >>> &g

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-11 Thread Michael Schmitz
Hi Finn, Am 11.05.2018 um 17:28 schrieb Finn Thain: > On Fri, 11 May 2018, Michael Schmitz wrote: > >> >> I'm afraid using platform_device_register() (which you already use for >> the SCC devices) is the only option handling this on a per-device basis >>

Re: moving affs + RDB partition support to staging?

2018-05-06 Thread Michael Schmitz
Al, I don't think there is USB sticks with affs on them as yet. There isn't even USB host controller support for Amiga hardware (yet). Last I tried USB on m68k (Atari, 060 accelerator) the desktop experience was such that I'd rather not repeat that in a hurry (and that was a simple FAT USB stick)

Re: moving affs + RDB partition support to staging?

2018-05-07 Thread Michael Schmitz
Martin, On Mon, May 7, 2018 at 7:08 PM, Martin Steigerwald wrote: > Michael Schmitz - 07.05.18, 04:40: >> Al, >> >> I don't think there is USB sticks with affs on them as yet. There >> isn't even USB host controller support for Amiga hardware (yet). >&

Re: [PATCH] nubus: Unconditionally register bus type

2018-05-08 Thread Michael Schmitz
Hi Greg, Am 08.05.2018 um 19:25 schrieb Greg Kroah-Hartman: > On Tue, May 08, 2018 at 09:07:27AM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman >> wrote: >>> On Mon, May 07, 2018 at 09:51:12AM +1200, Micha

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-05 Thread Michael Schmitz
Hi Bartlomiej, thanks for caring to support our legacy PATA systems! On Sat, Dec 31, 2016 at 3:01 AM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset adds m68k/Atari Falcon PATA support to libata. > The major difference in the new libata's pata_falcon host > driver when compared to lega

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Michael Schmitz
Hi Finn, Am 13.01.2017 um 15:33 schrieb Finn Thain: >> The case I'm worried about is both IDE and SCSI raising an interrupt. We >> don't currently mask the IDE/ST-DMA interrupt so a stacked interrupt >> must be processed in the same pass as the initial interrupt or it will >> get dropped. We'd

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Michael Schmitz
Hi Finn, Am 15.01.2017 um 12:47 schrieb Finn Thain: > For the sake of discussion, I'll assume that the FDC driver will not > be using DMA. (Perhaps FDC and SCSI can share the ST-DMA chip, using > the present locking mechanism, but it would not simplify things much: > when IDE no longer participat

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-01 Thread Michael Schmitz
Hi Finn, Am 01.02.2017 um 21:40 schrieb Finn Thain: > > On Fri, 27 Jan 2017, Michael Schmitz wrote: > >> Am 26.01.2017 um 21:47 schrieb Finn Thain: >> >>> This would imply CPU overhead that is half of that which mac_scsi >>> incurs. That's the be

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Michael Schmitz
Martin, Finn, I'll get to that on the weekend - Auckland Anniversary Day coming up so plenty of time. Cheers, Michael Am 26.01.2017 um 12:25 schrieb Martin K. Petersen: >> "Finn" == Finn Thain writes: > > Finn> Michael, Ondrej, can I get you to review/test please? > > Pretty plea

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-19 Thread Michael Schmitz
Hi Finn, Am 15.01.2017 um 17:42 schrieb Finn Thain: >> No, we can't check either FDC or SCSI interrupts (or indeed any chip >> registers) without touching the ST-DMA. The moment we select a FDC or >> SCSI register for read, DMA is terminated no questions asked. >> > > Perhaps we can convert DM

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-23 Thread Michael Schmitz
Hi Finn, Am 21.01.2017 um 20:37 schrieb Finn Thain: >> The MFP interrupt in question is the same as the one used by IDE >> (wired-OR of IDE, FDC and SCSI), so we would still have to figure out >> where the interrupt originated. > > I thought you said the driver you're testing does not use any

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-26 Thread Michael Schmitz
Hi Finn, Am 26.01.2017 um 21:47 schrieb Finn Thain: >> I hadn't considered that. Can PDMA for Falcon SCSI coexist with >> interrupt-using DMA for TT SCSI in the same driver (i.e. as runtime >> options)? > > Sure, why not? > >> How much overhead and latency would polling for DMA completion ad

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-29 Thread Michael Schmitz
been tested as well. No change in the weird behaviour of my SCSI-SATA adapter, but perhaps that wasn't unexpected. Targets: Disks Seagate ST34520W and IBM DORS-32160W, CD-ROM Plextor PX-40TS. Tested-by: Michael Schmitz > > > Finn Thain (6): > ncr5380: Shorten host info str

Re: [PATCH v2 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

2016-10-09 Thread Michael Schmitz
t; scsi/ncr5380: Expedite register polling > scsi/ncr5380: Use correct types for DMA routines > scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message Tested on Atari SCSI (Falcon) - no regressions. Tested-by: Michael Schmitz

Re: [PATCH 01/22] m68k/atari: Modernize printing of kernel messages

2016-12-09 Thread Michael Schmitz
Hi Geert, Am 09.12.2016 um 01:22 schrieb Geert Uytterhoeven: > On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain > wrote: >> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: >>> - Convert from printk() to pr_*(), >>> - Add missing continuations, to fix user-visible breakage, >>> - Drop useless WARN

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-10 Thread Michael Schmitz
Bartlomiej, >> How is polling implemented in libata? Sleeping for something >> approximating the average seek latency shouldn't hurt but spinning >> wont be acceptable for a low performance single CPU architecture like >> the Falcon. > > You can find actual implementation in libata-sff.c. > > Ple

Re: [PATCH v3 66/77] ncr5380: Fix soft lockups

2015-12-22 Thread Michael Schmitz
I'd like to think that, too - probably true for the Atari TT SCSI case (can do scatter-gather, can do more than one command per LUN). Worse for the Falcon SCSI which is the only one I can test (no scatter-gather, one command per LUN, interrupt shared with IDE and IDE driver locked out while SCSI co

Re: [PATCH v4 34/78] atari_NCR5380: Use arbitration timeout

2016-01-25 Thread Michael Schmitz
Hi Geert, On Mon, Jan 25, 2016 at 9:05 PM, Geert Uytterhoeven wrote: >>> Perhaps this is an ARAnyM quirk? > >> The MR_ARBITRATE bit should remain set until the driver clears it (or the >> reset logic clears it). But it looks like aranym simply discards writes to >> the mode register, such that r

Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM

2020-10-28 Thread Michael Schmitz
Hi Mike, On 29/10/20 12:16 AM, Mike Rapoport wrote: Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: Hi Mike, On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: From: Mike Rapoport The pg_data_t node structures and their initialization currently depends on

Re: [PATCH] ide/macide: Convert Mac IDE driver to platform driver

2020-09-09 Thread Michael Schmitz
Hi Finn, Am 10.09.2020 um 12:23 schrieb Finn Thain: + return 0; + +release_mem: + release_mem_region(mem->start, resource_size(mem)); Not needed, as you used devm_*() for allocation. OK, I'll remove this. I put it there after I looked at falconide.c and wondered whether the auto

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-23 Thread Michael Schmitz
Hi Finn, On 24/09/20 1:07 PM, Finn Thain wrote: Looking further at the drivers using ide_host_register(), I see that falconide.c is missing a set_drvdata() call, while tx4939ide.c calls set_drvdata() after ide_host_register(). The latter example is not a bug. The pattern I used, that is, callin

Re: [PATCH] ide/falconide: Fix module unload

2020-09-24 Thread Michael Schmitz
Hi Finn, thanks for catching this! Reviewed-By: Michael Schmitz Am 25.09.2020 um 13:39 schrieb Finn Thain: Unloading the falconide module results in a crash: Unable to handle kernel NULL pointer dereference at virtual address Oops: Modules linked in: falconide(-) PC

Re: [PATCH v2 2/7] scsi: NCR5380: Always re-enable reselection interrupt

2019-06-11 Thread Michael Schmitz
Hi Finn, On 11/06/19 9:33 PM, Finn Thain wrote: On Tue, 11 Jun 2019, Michael Schmitz wrote: Hi Finn, IIRC I'd tested that change as well - didn't change broken target behaviour but no regressions in other respects. Add my tested-by if needed. Unfortunately I can't confirm t

Re: [PATCH] NCR5380: Support chained sg lists

2019-06-11 Thread Michael Schmitz
On 11/06/19 3:25 PM, Finn Thain wrote: My understanding is that support for chained scatterlists is to become mandatory for LLDs. Cc: Michael Schmitz Signed-off-by: Finn Thain Reviewed-by: Michael Schmitz --- drivers/scsi/NCR5380.c | 41 ++--- 1 file

Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-03 Thread Michael Schmitz
Hi Finn, On 3/06/19 7:40 PM, Finn Thain wrote: There are several other drivers that contain pieces of assembler code. Does any driver contain assembler code for multiple architectures? I was trying to avoid that -- though admittedly I don't yet have actual code for the PDMA implementation fo

Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock

2017-04-24 Thread Michael Schmitz
Martin, looks good to me, so: Reviewed-By: Michael Schmitz Am 25.04.2017 um 10:29 schrieb Martin K. Petersen: > > Finn, > >> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips") >> added mac_scsi_esp_intr() to handle the IRQ lines from

Re: [PATCH v3 0/4] g_NCR5380: PDMA fixes and cleanup

2017-06-27 Thread Michael Schmitz
Ondrej, could this be a partial write (target did not transfer the last byte)? One would suppose the chip posts a phase mismatch in that case ... Cheers, Michael Am 27.06.2017 um 18:28 schrieb Ondrej Zary: > On Monday 26 June 2017, Ondrej Zary wrote: >> On Monday 26 June 2017 09:30:33

[RFC] fix race in drivers/char/random.c:get_reg()

2017-04-30 Thread Michael Schmitz
the race by disabling interrupts in get_reg(). Tested on m68k (Atari Falcon, and ARAnyM emulator). Kudos to Geert Uytterhoeven for helping to trace this race. Signed-off-by: Michael Schmitz --- drivers/char/random.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --gi

<    1   2