Re: [SCSI] qla4xxx: support iscsiadm session mgmt

2012-08-09 Thread Michael Christie
On Aug 8, 2012, at 11:57 AM, Dan Carpenter wrote: > On Wed, Aug 08, 2012 at 10:35:44AM -0500, Mike Christie wrote: >> On 08/08/2012 10:00 AM, Dan Carpenter wrote: >>> I never heard back on this. This buffer overflow is still present >>> in the current code. >>> >> >> Qlogic just sent a patch

Re: [PATCH] tcmu: Fix trailing semicolon

2018-01-16 Thread Michael Christie
On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > After fixing the same t

Re: [PATCH] target: Fix a double put in transport_free_session

2021-03-23 Thread michael . christie
On 3/22/21 9:58 PM, Lv Yunlong wrote: > In transport_free_session, se_nacl is got from se_sess > with the initial reference. If se_nacl->acl_sess_list is > empty, se_nacl->dynamic_stop is set to true. Then the first > target_put_nacl(se_nacl) will drop the initial reference > and free se_nacl. Late

Re: [PATCH V2] scsi: iscsi_tcp: Fix use-after-free when do get_host_param

2021-03-21 Thread michael . christie
On 3/21/21 1:47 AM, Wu Bo wrote: > From: Wu Bo > > iscsid(cpu1): Logout of iscsi session, will do destroy session, > tcp_sw_host->session is not set to NULL before release the iscsi session. > in the iscsi_sw_tcp_session_destroy(). > > iscsadm(cpu2): Get host parameters access to tcp_sw_host->

Re: [PATCH] iscsi: Do Not set param when sock is NULL

2020-11-23 Thread Michael Christie
> On Nov 4, 2020, at 11:40 PM, Gulam Mohamed wrote: > > Description > = > 1. This Kernel panic could be due to a timing issue when there is a race > between the sync thread and the initiator was processing of a login response > from the target. The session re-open can be invoked from

Re: [PATCH] scsi: tcmu: Simplify 'tcmu_update_uio_info()'

2019-06-18 Thread Michael Christie
On 06/16/2019 02:02 AM, Christophe JAILLET wrote: > Use 'kasprintf()' instead of: >- snprintf(NULL, 0... >- kmalloc(... >- snprintf(... > > This is less verbose and saves 7 bytes (i.e. the space for '/(null)') if > 'udev->dev_config' is NULL. > > Signed-off-by: Christophe JAILLET > -

Re: [PATCH] nbd: add missed destroy_workqueue when nbd_start_device fails

2020-07-25 Thread Michael Christie
> On Jul 24, 2020, at 9:27 PM, Li Heng wrote: > > destroy_workqueue() should be called to destroy ndev->tx_wq > when nbd_start_device init resources fails. > > Reported-by: Hulk Robot > Signed-off-by: Li Heng > --- > drivers/block/nbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-19 Thread Michael Christie
> On Jun 19, 2020, at 1:41 PM, Henry Willard wrote: > > tcmu_flush_dcache_range() gets called with addresses from both kernel > linear space and vmalloc space, so virt_to_page() or vmalloc_to_page() > have to be used as appropriate to get the proper page struct. On x86_64 > flush_dcache_page()

Re: [PATCH v3 4/9] vhost: Add kthread support in function vhost_worker_create

2024-11-26 Thread michael . christie
On 11/5/24 1:25 AM, Cindy Lu wrote: > static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev) > { > struct vhost_worker *worker; > - struct vhost_task *vtsk; > + struct vhost_task *vtsk = NULL; > + struct task_struct *task = NULL; > char name[TASK_COMM_LEN];

Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-12 Thread michael . christie
On 1/10/25 9:34 PM, Haoran Zhang wrote: > Since commit 3f8ca2e115e55 ("vhost scsi: alloc cmds per vq instead of > session"), a bug can be triggered when the host sends a duplicate > VHOST_SCSI_SET_ENDPOINT ioctl command. I don't think that git commit is correct. It should be: 25b98b64e284 ("vho