Kernel panic in IPv6 ndisc/redirect in kernel 3.9.4

2013-05-29 Thread Matthias Schiffer
Hi, we've hit the following panic several times in the last days on some of our servers running kernel 3.9.4. Is seems to be a regression in the 3.9 series, as we never hit it with 3.8.x or earlier. Please let me know if there is anything more I can do to help fix this; I probably won't have time

[PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Matthias Schiffer
Since some refactoring in 5f5a011, ndisc_send_redirect called ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or in the worst case a panic when the skb_put failed. Signed-off-by: Matthias Schiffer --- net/ipv6/ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-07 Thread Matthias Schiffer
On 05/31/2013 10:42 AM, David Miller wrote: > From: Cong Wang > Date: Fri, 31 May 2013 11:23:11 +0800 > >> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer >> wrote: >>> Since some refactoring in 5f5a011, ndisc_send_redirect called >>> ndisc_fill_redire

Re: [PATCH 4.14 222/246] ext4: fix check to prevent initializing reserved inodes

2018-08-07 Thread Matthias Schiffer
On 08/01/2018 06:52 PM, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. It seems this patch is still missing from the 4.4.y and 4.9.y branches. Matthias > > -- > > From: Theodore Ts'o > > commit 5012284700775a4e6e3fbe7

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

2018-03-12 Thread Matthias Schiffer
On 02/06/2018 09:44 PM, Jacek Anaszewski wrote: > On 02/06/2018 03:02 AM, Sasha Levin wrote: >> On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: >>> *** if brightness=0, led off *** else apply brightness if next timer <--- timer is stop, and will never apply

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

2018-03-12 Thread Matthias Schiffer
On 03/12/2018 04:28 PM, Greg KH wrote: > On Mon, Mar 12, 2018 at 04:00:01PM +0100, Matthias Schiffer wrote: >> On 02/06/2018 09:44 PM, Jacek Anaszewski wrote: >>> On 02/06/2018 03:02 AM, Sasha Levin wrote: >>>> On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek

ftrace on MIPS/ath79

2018-03-23 Thread Matthias Schiffer
Hi, I'm currently trying to debug a performance bottleneck on low-end ath79 hardware running OpenWrt/LEDE, but it seems that ftrace is not working correctly on these systems. I have tried this with recent 4.4.y and 4.9.y with similar results; unfortunately, switching to a newer kernel is not easily

[PATCH] ftrace: fix stddev calculation in function profiler (again)

2018-03-24 Thread Matthias Schiffer
rs. Ruling out the above alternatives, I chose the present approach to fix the issue. Fixes: e330b3bcd831 ("tracing: Show sample std dev in function profiling") Fixes: 52d85d763086 ("ftrace: Fix stddev calculation in function profiler") Signed-off-by: Matthias Schiff

[PATCH] mips: ftrace: fix static function graph tracing

2018-03-24 Thread Matthias Schiffer
orted before: https://www.linux-mips.org/archives/linux-mips/2014-11/msg00295.html Signed-off-by: Matthias Schiffer --- Caveats: I've only tested this on 32bit; it would be great if someone with MIPS64 hardware or a working emulator setup could give it a spin. My test device runs on kernel 4.

Re: [PATCH] ftrace: fix stddev calculation in function profiler (again)

2018-03-24 Thread Matthias Schiffer
On 03/24/2018 05:26 PM, Matthias Schiffer wrote: > It is well-known that it is not possible to accurately calculate variances > just by accumulating squared samples; in fact, such an approach can even > result in negative numbers. An earlier attempt to fix the calculation > referred

Re: [PATCH] ftrace: fix stddev calculation in function profiler (again)

2018-03-25 Thread Matthias Schiffer
On 03/24/2018 11:03 PM, Matthias Schiffer wrote: > On 03/24/2018 05:26 PM, Matthias Schiffer wrote: >> It is well-known that it is not possible to accurately calculate variances >> just by accumulating squared samples; in fact, such an approach can even >> result in negativ

Re: [PATCH] ftrace: fix stddev calculation in function profiler (again)

2018-03-27 Thread Matthias Schiffer
On 03/26/2018 06:51 PM, Steven Rostedt wrote: > On Sat, 24 Mar 2018 17:26:38 +0100 > Matthias Schiffer wrote: > >> @@ -905,8 +898,20 @@ static void profile_graph_return(struct >> ftrace_graph_ret *trace) >> >> rec = ftrace_find_profiled_func(st

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-22 Thread Matthias Schiffer
On 06/22/2015 07:58 AM, Steven Barth wrote: > On 22.06.2015 00:35, Matthias Schiffer wrote: >> Could you explain in detail what you mean with "If you want specific SA, >> add same route with higher metric and/or (more) specific src match."? >> Routes aren't bo

Re: A race condition between debugfs and seq_file operation

2015-06-10 Thread Matthias Schiffer
On 06/10/2015 07:20 AM, gre...@linuxfoundation.org wrote: > On Wed, Jun 10, 2015 at 05:00:03AM +, Lisa Du wrote: >>> -Original Message- >>> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] >>> Sent: 2015年6月10日 5:12 >>> To: Lisa Du >>> Cc: linux-kernel@vger.kernel.org

musl-libc/MIPS: detached thread exit broken since kernel commit 46e12c07b

2015-06-18 Thread Matthias Schiffer
Hi, I've come across the issue that applications with detached threads (using pthread_detach or a pthread_attr_t with pthread_attr_setdetachstate) will segfault using musl-libc on MIPS as soon as the detached thread exits. As far as I can tell, the underlying issue is the following: To clean up af

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Matthias Schiffer
On 05/05/2015 12:36 PM, Markus Stenberg wrote: > If there are only IPv6 source specific default routes present, the > host gets -ENETUNREACH on e.g. connect() because ip6_dst_lookup_tail > calls ip6_route_output first, and given source address any, it fails, > and ip6_route_get_saddr is never calle

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Matthias Schiffer
On 06/22/2015 12:05 AM, Markus Stenberg wrote: > Prefsrc is essentially historic non IPv6 construct. IPv6 SAS is based on dst, > src, metric ordered lookup just like the routing is too ( lookup rfc, some > src specific routing drafts for details ). > > Therefore I do not see a problem. If you w

[PATCH 2/3] power: supply: bq27xxx: fix power_avg

2021-02-23 Thread Matthias Schiffer
't have to extend it to store both a signed value and an error code. Always getting an up-to-date value may be desirable anyways, as it avoids inconsistent current and power readings when switching between charging and discharging. Signed-off-by: Matthias Schiffer --- drivers/power/supply/bq

[PATCH 3/3] power: supply: bq27xxx: make status more robust

2021-02-23 Thread Matthias Schiffer
device known to Linux We can solve both issues by deriving the status from the current instead of the flags field. The flags are now only used to distinguish "full" from "not charging", and to determine the sign of the current on BQ27XXX_O_ZERO devices. Signed-off-by:

[PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-02-23 Thread Matthias Schiffer
o I assume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer --- @Andreas Kemnade: It would be great to get a confirmation that the Openmoko ba

Re: [PATCH 2/3] power: supply: bq27xxx: fix power_avg

2021-02-24 Thread Matthias Schiffer
On Tue, 2021-02-23 at 15:11 +0100, Matthias Schiffer wrote: > On all newer bq27xxx ICs, the AveragePower register contains a signed > value; in addition to handling the raw value as unsigned, the driver > code also didn't convert it to µW as expected. > > At least for the BQ2

[PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-20 Thread Matthias Schiffer
Based-on-patch-by: Sascha Hauer Link: https://lkml.org/lkml/2020/8/5/194 Signed-off-by: Matthias Schiffer --- v2: fix missing symbols for modular mmcblock drivers/mmc/core/block.c | 13 +++-- drivers/mmc/core/core.c | 40 drivers/mmc/core/core.h

[PATCH] drm: fsl-dcu: enable PIXCLK on LS1021A

2020-08-20 Thread Matthias Schiffer
The PIXCLK needs to be enabled in SCFG before accessing the DCU on LS1021A, or the access will hang. Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 25 +++ drivers/gpu/drm/fsl-dcu

[PATCH mmc-next] mmc: allow setting slot index via device tree alias

2020-08-19 Thread Matthias Schiffer
Based-on-patch-by: Sascha Hauer Signed-off-by: Matthias Schiffer Link: https://lkml.org/lkml/2020/8/5/194 --- drivers/mmc/core/block.c | 13 +++-- drivers/mmc/core/core.c | 38 ++ drivers/mmc/core/core.h | 3 +++ drivers/mmc/core/host.c

[PATCH] dt-bindings: vendor-prefixes: correct the spelling of TQ-Systems GmbH

2020-12-07 Thread Matthias Schiffer
From: Max Merchel "TQ-Systems" is written with a dash, as can be seen on https://www.tq-group.com/en/imprint/ Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as a default instead of listing each new module individually. Signed-off-by: Matthias Schiffer --- drivers/mfd/tqmx86.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/tqmx86.c b

[PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

2021-03-31 Thread Matthias Schiffer
The driver was registering IRQ 0 when no IRQ was set. This leads to warnings with newer kernels. Clear the resource flags, so no resource is registered at all in this case. Signed-off-by: Matthias Schiffer --- drivers/mfd/tqmx86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH 0/3] tqmx86: TQMxE40M support

2021-03-31 Thread Matthias Schiffer
This fixes a bug in the IRQ setup of the tqmx86 MFD / GPIO drivers and adds support for our upcoming Elkhart Lake module TQMxE40M (as well as future SoMs). As patch 2 depends on patch 1, it would make sense to push the whole series through the same tree. Matthias Schiffer (3): gpio: tqmx86

[PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This causes warnings with newer kernels. Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a missing IRQ properly. Signed-off-by: Matthias Schiffer --- drivers/gpio/gpio-tqmx86.c | 6 +++--- 1 file

Re: (EXT) Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > wrote: > > > > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > > causes warnings with newer kernels. > > > > Pr

Re: [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:35 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:39 PM Matthias Schiffer > wrote: > > > > The driver was registering IRQ 0 when no IRQ was set. This leads to > > warnings with newer kernels. > > > > Clear the resource fl

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > wrote: > > > > All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as > > a default instead of listing each new module individually. >

Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:39 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 3:37 PM Matthias Schiffer > wrote: > > On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > > > wrote: &

[PATCH v2 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-03-03 Thread Matthias Schiffer
o I assume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer --- v2: no changes drivers/power/supply/bq27xxx_battery.c | 2 +- 1 file c

[PATCH v2 3/3] power: supply: bq27xxx: make status more robust

2021-03-03 Thread Matthias Schiffer
device known to Linux We can solve both issues by deriving the status from the current instead of the flags field. The flags are now only used to distinguish "full" from "not charging", and to determine the sign of the current on BQ27XXX_O_ZERO devices. Signed-o

[PATCH v2 2/3] power: supply: bq27xxx: fix power_avg for newer ICs

2021-03-03 Thread Matthias Schiffer
't have to extend it to store both a signed value and an error code. Always getting an up-to-date value may be desirable anyways, as it avoids inconsistent current and power readings when switching between charging and discharging. Signed-off-by: Matthias Schiffer --- v2: fixed units in

[PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Matthias Schiffer
e759cda51b ("l2tp: use standard API for warning log messages") Signed-off-by: Matthias Schiffer --- v2: - Add counter for invalid packets - Reduce loglevel of more messages that can be abused for log spam include/uapi/linux/l2tp.h | 1 + net/l2tp/l

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Matthias Schiffer
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote: > On Wed, 31 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > > wrote: > > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > > On Wed, Ma

[PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-19 Thread Matthias Schiffer
2TP version are checked before the T flag. Reduce all warnings debug level when packets are passed to userspace. Fixes: 5ee759cda51b ("l2tp: use standard API for warning log messages") Signed-off-by: Matthias Schiffer --- I'm unsure what to do about the pr_warn_ratelimited() i

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-20 Thread Matthias Schiffer
Hi Tom, On 2/19/21 9:12 PM, Tom Parkin wrote: Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it was possible for userspace applications to use

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Matthias Schiffer
On 2/22/21 12:49 PM, Tom Parkin wrote: On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: On 2/19/21 9:12 PM, Tom Parkin wrote: On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages&

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-03-01 Thread Matthias Schiffer
On 2/23/21 10:47 AM, Tom Parkin wrote: On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote: On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: This will not be sufficient for my usecase: To stay compatible with older versions of fastd, I can't set the T flag in the

Re: [PATCH 1/2] mtd: spi-nor: disable software protection for Macronix flash at startup

2016-05-23 Thread Matthias Schiffer
On 05/23/2016 04:01 PM, Cyrille Pitchen wrote: > Hi Matthias, > > Le 18/05/2016 15:32, Matthias Schiffer a écrit : >> This patch has been tested in OpenWrt for a few months and seems to work >> correctly. >> >> Signed-off-by: Felix Fietkau >> Signed-off-by

[PATCH 2/2] mtd: spi-nor: disable software protection for Winbond flash at startup (again)

2016-05-18 Thread Matthias Schiffer
Spansion manufacturer ID. All tested Spansion flash chips showed the same behaviour: without 32321e9 and edf891e, subsequent reads only returned zeros (as reported by Felix Fietkau, leading to 67b9bcd), but with 32321e9 and edf891e, the chip continued to work correctly. Cc: Felix Fietkau Signed-of

[PATCH 1/2] mtd: spi-nor: disable software protection for Macronix flash at startup

2016-05-18 Thread Matthias Schiffer
This patch has been tested in OpenWrt for a few months and seems to work correctly. Signed-off-by: Felix Fietkau Signed-off-by: Matthias Schiffer --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c

Re: [PATCH modules 1/2] module: allow arch overrides for .exit section names

2019-06-06 Thread Matthias Schiffer
On Thu, 2019-06-06 at 17:09 +0200, Jessica Yu wrote: > +++ Matthias Schiffer [03/06/19 12:57 +0200]: > > Some archs like ARM store unwind information for .exit.text in > > sections > > with unusual names. As this unwind information refers to > > .exit.text, it

[PATCH modules v2 2/2] ARM: module: recognize unwind exit sections

2019-06-07 Thread Matthias Schiffer
efer to the .exit.text section: imx_sdma: section 16 reloc 0 sym '': relocation 42 out of range (0x7f015260 -> 0xc0f5a5e8) where 0x7F00 is the module load area and 0xC000 is the vmalloc area. Relocation 42 refers to R_ARM_PREL31, which is limited to signed 31bit offsets. Signed-of

[PATCH modules v2 1/2] module: allow arch overrides for .exit section names

2019-06-07 Thread Matthias Schiffer
. Signed-off-by: Matthias Schiffer --- v2: Use __weak function as suggested by Jessica include/linux/moduleloader.h | 5 + kernel/module.c | 7 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/linux/moduleloader.h b/include/linux/moduleloader.h index

[PATCH modules v2 0/2] Fix handling of exit unwinding sections (on ARM)

2019-06-07 Thread Matthias Schiffer
.IA_64.unwind.exit.text and .IA_64.unwind_info.exit.text appear in the ld script - but I don't know much about that arch. Also, I'm not sure if this is stable-worthy - just enabling CONFIG_MODULE_UNLOAD should be a viable workaround on affected kernels. v2: Use __weak function as suggest

[PATCH RESEND net-next] ipv6: provide Kconfig switch to disable accept_ra by default

2018-04-17 Thread Matthias Schiffer
disabling all.accept_ra would preclude users from explicitly enabling accept_ra on individual interfaces. Signed-off-by: Matthias Schiffer --- net/ipv6/Kconfig| 12 net/ipv6/addrconf.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/ipv6/Kconfig b/net

Re: [PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-03-15 Thread Matthias Schiffer
On 03/14/2017 04:28 PM, Jiri Benc wrote: > On Fri, 10 Mar 2017 23:39:44 +0100, Matthias Schiffer wrote: >> @@ -233,17 +234,30 @@ static struct vxlan_dev *vxlan_vs_find_vni(struct >> vxlan_sock *vs, __be32 vni) >> vni = 0; >> >> hlist_for_each_

[PATCH net-next 0/3] VXLAN over IPv6 link-local

2017-03-10 Thread Matthias Schiffer
laces. The final patch lifts the limitation of not allowing multiple VXLANs with the same VNI and port, as long as link-local IPv6 addresses are used and different interfaces are specified. Again, this brings VXLAN a bit closer to VLANs feature-wise. Matthias Schiffer (3): vxlan: don't allow

[PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-03-10 Thread Matthias Schiffer
to respect the ifindex when link-local IPv6 addresses are used, so using the same VNI on multiple interfaces can actually work. Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 88 - 1 file changed, 60 insertions(+), 28 deletions

[PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses

2017-03-10 Thread Matthias Schiffer
If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 20 +++- 1 file changed

[PATCH net-next 1/3] vxlan: don't allow link-local IPv6 local/remote addresses without interface

2017-03-10 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e375560cc74e..cc0ace73d02e 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2922,6 +2922,18 @@ static int

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

2016-03-26 Thread Matthias Schiffer
On 12/15/2015 07:48 PM, Brian Norris wrote: > Spansion and Winbond have occasionally used the same manufacturer ID, > and they don't support the same features. Particularly, writing SR=0 > seems to break read access for Spansion's s25fl064k. Unfortunately, we > don't currently have a way to differe

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

2016-03-27 Thread Matthias Schiffer
On 03/26/2016 07:57 PM, Matthias Schiffer wrote: > On 12/15/2015 07:48 PM, Brian Norris wrote: >> Spansion and Winbond have occasionally used the same manufacturer ID, >> and they don't support the same features. Particularly, writing SR=0 >> seems to break read acces

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

2016-03-29 Thread Matthias Schiffer
On 03/28/2016 10:56 PM, Brian Norris wrote: > On Mon, Mar 28, 2016 at 12:52:51AM +0200, Matthias Schiffer wrote: >> On 03/26/2016 07:57 PM, Matthias Schiffer wrote: >>> On 12/15/2015 07:48 PM, Brian Norris wrote: >>>> Spansion and Winbond have occasionally used the

Re: Nonterministic hang during bootconsole/console handover on ath79

2016-03-22 Thread Matthias Schiffer
On 03/22/2016 06:40 AM, Antony Pavlov wrote: > On Tue, 22 Mar 2016 00:02:57 +0100 > Matthias Schiffer wrote: > >> Hi, >> we're experiencing weird nondeterministic hangs during bootconsole/console >> handover on some ath79 systems on OpenWrt. I've seen t

Re: Nonterministic hang during bootconsole/console handover on ath79

2016-03-22 Thread Matthias Schiffer
>> My theory is the following: >> >> As soon as ttyS0 is detected and installed as the console, there are two >> console drivers active on the serial port at the same time: early0 and >> ttyS0. I suspect that the hang occurs when the primitive early0 >> implementation prom_putchar_ar71xx waits inde

Re: Nonterministic hang during bootconsole/console handover on ath79

2016-03-23 Thread Matthias Schiffer
On 03/22/2016 04:38 PM, Peter Hurley wrote: > On 03/22/2016 06:07 AM, Matthias Schiffer wrote: >> I've tried your patch and I can't reproduce the issue anymore with it; I >> have no idea if this actually has to do something with the issue, or the >> change of the c

Re: Nonterministic hang during bootconsole/console handover on ath79

2016-03-23 Thread Matthias Schiffer
>> autoconfig_16550a() is doing all kinds of weird checks to detect different >> hardware by writing a lot of register values which are documented as >> reserved in the AR7242 datasheet (there's a leaked version going around >> that can be easily googled...), no idea if any of those are problematic

[PATCH] MIPS: ath79: make bootconsole wait for both THRE and TEMT

2016-03-24 Thread Matthias Schiffer
patch will disable 8250 autoconfig for ath79 altogether (the serial controller is detected as a 16550A, which is not fully compatible with the ath79 serial, and the autoconfig may lead to undefined behavior on ath79.) Cc: Signed-off-by: Matthias Schiffer --- arch/mips/ath79/early_printk.c | 6

Nonterministic hang during bootconsole/console handover on ath79

2016-03-21 Thread Matthias Schiffer
Hi, we're experiencing weird nondeterministic hangs during bootconsole/console handover on some ath79 systems on OpenWrt. I've seen this issue myself on kernel 3.18.23~3.18.27 on a AR7241-based system, but according to other reports ([1], [2]) kernel 4.1.x is affected as well, and other SoCs like Q

Re: Nonterministic hang during bootconsole/console handover on ath79

2016-03-21 Thread Matthias Schiffer
On 03/22/2016 12:08 AM, Greg KH wrote: > On Tue, Mar 22, 2016 at 12:02:57AM +0100, Matthias Schiffer wrote: >> Hi, >> we're experiencing weird nondeterministic hangs during bootconsole/console >> handover on some ath79 systems on OpenWrt. I've seen this issue myself

[PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

2020-06-10 Thread Matthias Schiffer
From: Michael Krummsdorf Set SPI_NOR_4B_OPCODES, as the flash supports 4-byte opcodes. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- drivers/mtd/spi-nor/micron-st.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/micron-st.c

[PATCH] clk: qoriq: add LS1021A core pll mux options

2020-06-10 Thread Matthias Schiffer
From: Michael Krummsdorf This allows to clock the cores with 1 GHz, 500 MHz and 250 MHz. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- drivers/clk/clk-qoriq.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-qoriq.c b

[PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/panel/panel-sim

[PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33

2020-06-10 Thread Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bin

[PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-10 Thread Matthias Schiffer
From: Max Merchel Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to panel-simple. Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/panel/panel-simple.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/driver

[PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33

2020-06-10 Thread Matthias Schiffer
From: Matthias Schiffer This adds a few panels TQ-Systems uses with various starterkit mainboards. Device trees actually using these panels will be added with a later submission. Matthias Schiffer (2): dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 dt

[PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- .../devicetree/bindings/display/panel/panel-simple.yaml | 4 1 file changed, 4 insertions(+) di

Consistent block device references for root= cmdline

2020-06-10 Thread Matthias Schiffer
Hello all, there have been numerous attempts to make the numbering of mmcblk devices consistent, mostly by using aliases from the DTS ([1], [2], [3]), but all have been (rightfully) rejected. Unless I have overlooked a more recent development, no attempts for a different solution were made. As fa

Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Matthias Schiffer
On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > Hi Matthias. > > Thanks, a few details you need to fix. See below. > > Sam > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > From: Michael Krummsdorf > > > > Add supp

Re: (EXT) Re: Consistent block device references for root= cmdline

2020-06-11 Thread Matthias Schiffer
On Wed, 2020-06-10 at 16:52 +0200, Ulf Hansson wrote: > On Wed, 10 Jun 2020 at 15:15, Matthias Schiffer > wrote: > > > > Hello all, > > > > there have been numerous attempts to make the numbering of mmcblk > > devices consistent, mostly by using aliases from

Re: (EXT) Re: Consistent block device references for root= cmdline

2020-06-11 Thread Matthias Schiffer
0, 2020 at 11:51 AM Ulf Hansson > wrote: > > > > On Wed, 10 Jun 2020 at 15:15, Matthias Schiffer > > wrote: > > > > > > Hello all, > > > > > > there have been numerous attempts to make the numbering of mmcblk > > > devices cons

[PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- v2: no changes .../devicetree/bindings/display/panel/panel-simple.yaml | 4 1 file changed, 4

[PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- v2: - removed vrefresh - added connector_type drive

[PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33

2020-06-11 Thread Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- v2: no changes .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Document

[PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-11 Thread Matthias Schiffer
From: Max Merchel Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to panel-simple. Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- v2: - added connector_type - fixed bus_format drivers/gpu/drm/panel/panel-simple.c | 15 +++ 1

Re: [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
On Thu, 2020-06-11 at 14:42 +0200, Matthias Schiffer wrote: > Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and > S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. > > Signed-off-by: Matthias Schiffer > --- > > v2: no change

[PATCH RESEND v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-12 Thread Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- v2: no changes .../devicetree/bindings/display/panel/panel-simple.yaml | 4 1 file changed, 4

[PATCH RESEND v2 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33

2020-06-12 Thread Matthias Schiffer
From: Matthias Schiffer This adds a few panels TQ-Systems uses with various starterkit mainboards. Device trees actually using these panels will be added with a later submission. Matthias Schiffer (2): dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 dt

[PATCH RESEND v2 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-12 Thread Matthias Schiffer
From: Max Merchel Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to panel-simple. Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- v2: - added connector_type - fixed bus_format drivers/gpu/drm/panel/panel-simple.c | 15 +++ 1

[PATCH RESEND v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33

2020-06-12 Thread Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- v2: no changes .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Document

[PATCH RESEND v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-12 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- v2: - removed vrefresh - added connector_type drive

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > > wrote: > > > + > > > +static void __init mmc_of_reserve_idx(void) > > > +{ > &

Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > On Thu, 20 Aug 2020 at 09:59, Matthias Schiffer > > wrote: > > > --- a/drivers/mmc/core/host.c > > > +++ b/drivers/mmc/core/host.c > >

Re: (EXT) Re: (EXT) Re: [PATCH mmc-next v2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 14:27 +0200, Ulf Hansson wrote: > On Tue, 25 Aug 2020 at 14:00, Matthias Schiffer > wrote: > > > > On Tue, 2020-08-25 at 11:39 +0200, Matthias Schiffer wrote: > > > On Tue, 2020-08-25 at 11:14 +0200, Ulf Hansson wrote: > > > > On Thu,

[PATCH mmc-next v3 2/2] mmc: allow setting slot index via device tree alias

2020-08-25 Thread Matthias Schiffer
x-mmc/msg26588.html . Based-on-patch-by: Sascha Hauer Link: https://lkml.org/lkml/2020/8/5/194 Signed-off-by: Matthias Schiffer --- v3: - remove unneeded mmcblock changes - remove most helper functions to simplify code - extended commit message v2: - fix missing symbols for modular mmcblock dr

[PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example

2020-08-25 Thread Matthias Schiffer
As for I2C and SPI, it now is possible to reserve a fixed index for mmc/mmcblk devices. Signed-off-by: Matthias Schiffer --- v3: new patch Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings

Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:24 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Tue, Aug 25, 2020 at 4:22 AM Matthias Schiffer > wrote: > > > Hmm, unless I'm overlooking something, this is not going to work: > > > > - spi_get_gpio_descs() set

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > wrote: > > > Makes sense. Does the following logic sound correct? > > > > - If num-cs is set, use that (and add it to the docs) > > I would not add nu

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 12:32 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > > wrote: > > > > > Makes sense. Does the following logic sound correct? > > >

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 07:59 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Wed, Aug 26, 2020 at 7:32 AM Matthias Schiffer > wrote: > > > But the previous platform data that was removed in 8cdcd8aeee281 > > ("spi: > > imx/fsl-lpspi: Convert to GPIO desc

[PATCH] of: skip disabled CPU nodes

2020-08-26 Thread Matthias Schiffer
re the CPU nodes are referenced, e.g. a cooling map). Signed-off-by: Matthias Schiffer --- drivers/of/base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index ea44fea99813..d547e9deced1 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -79

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 10:01 -0300, Fabio Estevam wrote: > On Wed, Aug 26, 2020 at 8:54 AM Matthias Schiffer > wrote: > > > Before 8cdcd8aeee281, num_chipselect was set to 3 for spi0 and to 1 > > for > > spi1 in arch/arm/mach-imx/mach-mx31lite.c. My understanding is

Re: (EXT) Re: [PATCH] of: skip disabled CPU nodes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 08:01 -0500, Frank Rowand wrote: > On 2020-08-26 07:02, Matthias Schiffer wrote: > > Allow disabling CPU nodes using status = "disabled". > > > > This allows a bootloader to change the number of available CPUs > > (for > > example

Re: (EXT) Re: (EXT) Re: [PATCH] of: skip disabled CPU nodes

2020-08-27 Thread Matthias Schiffer
On Wed, 2020-08-26 at 13:26 -0600, Rob Herring wrote: > On Wed, Aug 26, 2020 at 8:47 AM Frank Rowand > wrote: > > > > Hi Rob, > > > > On 2020-08-26 08:54, Matthias Schiffer wrote: > > > On Wed, 2020-08-26 at 08:01 -0500, Frank Rowand wrote: > > >

[PATCH tty-next] tty: serial: imx: clear Ageing Timer Interrupt in handler

2020-05-28 Thread Matthias Schiffer
issue is trivially reproducible by any RX without DMA that doesn't fill the FIFO up to the configured level. Signed-off-by: Matthias Schiffer --- drivers/tty/serial/imx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 6b

  1   2   3   >