Re: [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes

2021-02-25 Thread Matthias Kaehlcke
On Thu, Feb 25, 2021 at 02:13:01PM -0800, Douglas Anderson wrote: > Let's avoid a bit of duplication by pushing this up to the trogdor.dtsi > file. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke

Re: [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject

2021-02-25 Thread Matthias Kaehlcke
-off-by: Stephen Boyd > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke

Re: [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default

2021-02-25 Thread Matthias Kaehlcke
bled for all trogdor. > > Cc: Tomasz Figa > Signed-off-by: Stephen Boyd > [dianders:adjusted since no coachz upstream yet] > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke

Re: [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz

2021-02-25 Thread Matthias Kaehlcke
M Stan > [dianders: adjusted since coachz isn't upstream yet] > Signed-off-by: Douglas Anderson We have essentially the same patch downstream, so I suppose the AP FW indeed takes care of configuring the FP pins as needed :) Reviewed-by; Matthias Kaehlcke

Re: [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor

2021-02-25 Thread Matthias Kaehlcke
On Thu, Feb 25, 2021 at 02:13:05PM -0800, Douglas Anderson wrote: > From: Venkata Lakshmi Narayana Gubba > > Removed voting for RPMH_RF_CLK2 which is not required as it is > getting managed by BT SoC through SW_CTRL line. > > Cc: Matthias Kaehlcke > Signed-off-by: Ven

Re: [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor

2021-02-25 Thread Matthias Kaehlcke
7;GO_LAZOR' BDF variant, so this must be awesome! Reviewed-by: Matthias Kaehlcke

Re: [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus

2021-02-25 Thread Matthias Kaehlcke
istributed, but since a few > people have them we might as well. If it ever causes problems we > can delete it. > > Cc: Stephen Boyd > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke

Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus

2021-02-25 Thread Matthias Kaehlcke
ut upstream. > - I remove sound node since sound hasn't landed upstream yet. > - In incorporate the pending <https://crrev.com/c/2719075> for the > keyboard. > > Cc: Philip Chen > Cc: Matthias Kaehlcke > Cc: Stephen Boyd > Cc: Tzung-Bi Shih > Cc: Judy Hsia

Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus

2021-02-26 Thread Matthias Kaehlcke
ove sound node since sound hasn't landed upstream yet. > > Cc: Gwendal Grignou > Cc: Matthias Kaehlcke > Cc: Stephen Boyd > Cc: Tzung-Bi Shih > Cc: Judy Hsiao > Signed-off-by: Douglas Anderson > --- Matches downstream except for the sound node and -rev0, whic

[PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

2020-07-29 Thread Matthias Kaehlcke
For disabled paths the 'interconnect_summary' in debugfs currently shows the orginally requested bandwidths. This is confusing, since the bandwidth requests aren't active. Instead show the bandwidths for disabled paths/requests as zero. Signed-off-by: Matthias Kaehlcke --- drive

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-08-11 Thread Matthias Kaehlcke
On Tue, Jul 28, 2020 at 04:49:05PM +0530, sbh...@codeaurora.org wrote: > On 2020-07-28 00:40, Matthias Kaehlcke wrote: > > Hi, > > > > On Mon, Jul 27, 2020 at 12:20:38PM +0530, sbh...@codeaurora.org wrote: > > > On 2020-07-24 22:40, Matthias Kaehlcke wrote: > &

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-11 Thread Matthias Kaehlcke
ndle freq = 0 to drop > performance votes") > Reported-by: Sajida Bhanu > Signed-off-by: Rajendra Nayak Tested-by: Matthias Kaehlcke Originally-reported-by: Matthias Kaehlcke https://patchwork.kernel.org/patch/11675369/#23514895 :P

Re: [PATCH V2] arm64: dts: qcom: sc7180: Add bandwidth votes for eMMC and SDcard

2020-08-12 Thread Matthias Kaehlcke
On Wed, Aug 12, 2020 at 04:26:08PM +0530, sbh...@codeaurora.org wrote: > On 2020-08-11 22:38, Matthias Kaehlcke wrote: > > On Tue, Jul 28, 2020 at 04:49:05PM +0530, sbh...@codeaurora.org wrote: > > > On 2020-07-28 00:40, Matthias Kaehlcke wrote: > > > > Hi, > >

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-19 Thread Matthias Kaehlcke
On Wed, Aug 19, 2020 at 07:19:25PM +0530, ska...@codeaurora.org wrote: > On 2020-08-17 23:31, Matthias Kaehlcke wrote: > > On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > > > Add sleep pin ctrl for BT uart, and also change the bias > > > configuratio

Re: [PATCH v4 1/5] usb: dwc3: core: Host wake up support from system suspend

2020-12-10 Thread Matthias Kaehlcke
On Sat, Nov 28, 2020 at 08:01:31AM +0530, mgau...@codeaurora.org wrote: > Hi, > > > On 2020-10-28 02:07, Sandeep Maheswaram wrote: > > Avoiding phy powerdown in host mode so that it can be woken up by > > devices. > > Added hs_phy_mode flag to check connection status and set phy mode > > and conf

Re: [PATCH v4 2/5] usb: dwc3: host: Add suspend_quirk for dwc3 host

2020-12-10 Thread Matthias Kaehlcke
> + dwc->hs_phy_mode |= PHY_MODE_USB_HOST_LS; > + > + if (DEV_SUPERSPEED(reg)) > + ss_phy_mode |= PHY_MODE_USB_HOST_SS; > + } > + } > + phy_set_mode(dwc->usb2_generic_phy, dwc->hs_phy_mode); > + phy_set_mode(dwc->usb3_generic_phy, ss_phy_mode); > +} > + > +int xhci_dwc3_suspend_quirk(struct usb_hcd *hcd) > +{ > + dwc3_set_phy_mode(hcd); > + return 0; > +} > + > void dwc3_host_exit(struct dwc3 *dwc) > { > platform_device_unregister(dwc->xhci); Other than the nit: Reviewed-by: Matthias Kaehlcke

Re: [PATCH v4 3/5] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag

2020-12-10 Thread Matthias Kaehlcke
On Wed, Oct 28, 2020 at 02:08:01AM +0530, Sandeep Maheswaram wrote: > Configure interrupts based on hs_phy_mode to avoid triggering of > interrupts during system suspend and suspends successfully. > Set genpd active wakeup flag for usb gdsc if wakeup capable devices > are connected so that wake up

[PATCH] arm64: dts: qcom: sc7180: Add labels for cpuN-thermal nodes

2021-01-08 Thread Matthias Kaehlcke
labels for CPU zones are added for now. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 22

Re: [RESEND PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

2021-03-24 Thread Matthias Kaehlcke
On Wed, Mar 24, 2021 at 03:48:35PM +0530, Roja Rani Yarubandi wrote: > This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect > support to fix earlycon crash") > > ICC core and platforms drivers supports sync_state feature, which > ensures that the default ICC BW votes from the boo

Re: [PATCH V2 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

2021-03-18 Thread Matthias Kaehlcke
ot;) in the intro. I tried to test by first reproducing the original issue without 'sync_state' in the ICC, but wasn't successful, probably something changed in the boot/ICC timing in the meantime ¯\_(ツ)_/¯. Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/2] arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path

2021-03-18 Thread Matthias Kaehlcke
gt; > Signed-off-by: Roja Rani Yarubandi > Signed-off-by: Akash Asthana Reviewed-by: Matthias Kaehlcke

Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add USB related nodes

2021-03-18 Thread Matthias Kaehlcke
On Wed, Mar 17, 2021 at 04:31:41PM +0530, Sandeep Maheswaram wrote: > Add nodes for DWC3 USB controller, QMP and HS USB PHYs. > > Signed-off-by: Sandeep Maheswaram > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 39 + > arch/arm64/boot/dts/qcom/sc7280.dtsi| 149 >

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Matthias Kaehlcke
35] gcc_disp_hf_axi_clk already unprepared Tested-by: Matthias Kaehlcke

Re: [PATCH v5 1/4] usb: dwc3: core: Host wake up support from system suspend

2021-03-23 Thread Matthias Kaehlcke
On Mon, Mar 22, 2021 at 11:01:17PM +0530, Sandeep Maheswaram wrote: > Avoiding phy powerdown when wakeup capable devices are connected. > > Signed-off-by: Sandeep Maheswaram > --- > drivers/usb/dwc3/core.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/

Re: [PATCH v5 2/4] usb: dwc3: host: Add suspend_quirk for dwc3 host

2021-03-23 Thread Matthias Kaehlcke
On Mon, Mar 22, 2021 at 11:01:18PM +0530, Sandeep Maheswaram wrote: > Adding suspend quirk function for dwc3 host which will be called > during xhci suspend. > Setting hs_phy_mode, ss_phy_mode , phy_power_off flags and phy mode > during host suspend. > > Signed-off-by: Sandeep Maheswaram > --- >

Re: [PATCH v5 3/4] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag

2021-03-23 Thread Matthias Kaehlcke
On Tue, Mar 23, 2021 at 01:11:18PM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 22, 2021 at 11:01:19PM +0530, Sandeep Maheswaram wrote: > > Configure interrupts based on hs_phy_mode to avoid triggering of > > interrupts during system suspend and suspends successfully. > > Set genpd active wakeup

Re: [PATCH v5 3/4] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag

2021-03-23 Thread Matthias Kaehlcke
On Tue, Mar 23, 2021 at 05:49:14PM -0700, Matthias Kaehlcke wrote: > On Tue, Mar 23, 2021 at 01:11:18PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Mar 22, 2021 at 11:01:19PM +0530, Sandeep Maheswaram wrote: > > > Configure interrupts based on hs_phy_mode to avoid triggering o

[PATCH 0/4] arm64: dts: qcom: sc7180: Disable the charger thermal zone on more trogdor boards

2021-03-04 Thread Matthias Kaehlcke
em. Disable the charger thermal zone for them too. This series is based on v2 of the 'arm64: dts: qcom: Update sc7180-trogdor variants from downstream' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=440315) Matthias Kaehlcke (4): arm64: dts: qcom: sc7180: laz

[PATCH 4/4] arm64: dts: qcom: sc7180: Disable charger thermal zone for coachz rev1 and rev2

2021-03-04 Thread Matthias Kaehlcke
CoachZ rev1 and rev2 are stuffed with a 47k NTC as thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. Disable the charger thermal zone to avoid the use of bogus temperature values. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts

[PATCH 3/4] arm64: dts: qcom: sc7180: pompom: Disable charger thermal zone for rev1 and rev2

2021-03-04 Thread Matthias Kaehlcke
Pompom rev1 and rev2 are stuffed with a 47k NTC as thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. Disable the charger thermal zone to avoid the use of bogus temperature values. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts

[PATCH 1/4] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-04 Thread Matthias Kaehlcke
newer ones that use a supported thermistor. Finally the thermistor won't be changed on newer revisions, hence the thermal zone should be disabled for all lazor (and limozeen) revisions. Instead of disabling it per revision do it once in the shared .dtsi for lazor. Signed-off-by: Matthias Kaehl

[PATCH 2/4] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-04 Thread Matthias Kaehlcke
The only kernel visible change with respect to rev2 is that pompom rev3 changed the charger thermistor from a 47k to a 100k NTC to use a thermistor which is supported by the PM6150 ADC driver. Signed-off-by: Matthias Kaehlcke --- .../dts/qcom/sc7180-trogdor-pompom-r2-lte.dts | 4 +- .../dts

[PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver

2021-03-05 Thread Matthias Kaehlcke
device is connected when suspending, and power it off otherwise. Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (5): dt-bindings: usb: Add binding for Realtek RTS5411 hub controller USB: misc: Add onboard_usb_hub driver of/platform: Add

[PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver

2021-03-05 Thread Matthias Kaehlcke
2.0 and another for USB 3.x). Note: the driver currently only works with hubs connected directly to a root hub, but it could be extended to support other configurations if needed. Co-developed-by: Ravi Chandra Sadineni Signed-off-by: Ravi Chandra Sadineni Signed-off-by: Matthias Kaehlcke --- Ope

[PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy()

2021-03-05 Thread Matthias Kaehlcke
Code for platform_device_create() and of_platform_device_create() is only generated if CONFIG_OF_ADDRESS=y. Add stubs to avoid unresolved symbols when CONFIG_OF_ADDRESS is not set. Signed-off-by: Matthias Kaehlcke --- Changes in v6: - patch added to the series include/linux/of_platform.h | 22

[PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller

2021-03-05 Thread Matthias Kaehlcke
The Realtek RTS5411 is a USB 3.0 hub controller with 4 ports. This initial version of the binding only describes USB related aspects of the RTS5411, it does not cover the option of connecting the controller as an i2c slave. Signed-off-by: Matthias Kaehlcke --- Changes in v6: - Realtek binding

[PATCH v6 4/5] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-03-05 Thread Matthias Kaehlcke
). Further the platform device is only created when CONFIG_USB_ONBOARD_HUB=y/m. Signed-off-by: Matthias Kaehlcke --- Changes in v6: - none Changes in v5: - patch added to the series drivers/usb/host/xhci-plat.c | 16 include/linux/usb/hcd.h | 2 ++ 2 files changed, 18

[PATCH v6 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub

2021-03-05 Thread Matthias Kaehlcke
Add nodes for the onboard USB hub on trogdor devices. Remove the 'always-on' and 'boot-on' properties from the hub regulator, since the regulator is now managed by the onboard_usb_hub driver. Signed-off-by: Matthias Kaehlcke --- Changes in v6: - added 'companion-hub&#

Re: [PATCH 1/4] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-05 Thread Matthias Kaehlcke
On Fri, Mar 05, 2021 at 10:36:49AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > > > Commit f73558cc83d1 ("arm64: dts: qcom: sc7180: Disable charger > > thermal zone for lazor") disables the charge

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-05 Thread Matthias Kaehlcke
On Fri, Mar 05, 2021 at 10:48:16AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > > > The only kernel visible change with respect to rev2 is that pompom > > rev3 changed the charger thermistor from a 47k to a 100k

Re: [PATCH 4/4] arm64: dts: qcom: sc7180: Disable charger thermal zone for coachz rev1 and rev2

2021-03-05 Thread Matthias Kaehlcke
On Fri, Mar 05, 2021 at 10:50:12AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > > > CoachZ rev1 and rev2 are stuffed with a 47k NTC as thermistor for the > > charger temperature which currently isn't suppor

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-30 Thread Matthias Kaehlcke
On Thu, Mar 25, 2021 at 10:50:57AM +0530, ska...@codeaurora.org wrote: > Hi Matthias, > > On 2021-03-22 23:04, Matthias Kaehlcke wrote: > > Hi Satya, > > > > On Mon, Mar 22, 2021 at 06:50:47PM +0530, ska...@codeaurora.org wrote: > > > Hi Matthias, > &

Re: [PATCH V3 2/5] regulator: qcom-rpmh: Add PM7325/PMR735A regulator support

2021-03-31 Thread Matthias Kaehlcke
On Wed, Mar 31, 2021 at 05:35:36PM +0530, satya priya wrote: > Add support for PM7325/PMR735A regulators. This ensures > that consumers are able to modify the physical state of PMIC > regulators. > > Signed-off-by: satya priya Reviewed-by: Matthias Kaehlcke

Re: [PATCH V3 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp

2021-03-31 Thread Matthias Kaehlcke
On Wed, Mar 31, 2021 at 05:35:37PM +0530, satya priya wrote: > Add regulator devices for SC7280 as RPMh regulators. This ensures > that consumers are able to modify the physical state of PMIC > regulators. > > Signed-off-by: satya priya Reviewed-by: Matthias Kaehlcke I did

Re: [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-22 Thread Matthias Kaehlcke
On Fri, Mar 19, 2021 at 08:12:40AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke wrote: > > > > The only kernel visible change with respect to rev2 is that pompom > > rev3 changed the charger thermistor from a 47k to a 100k

[PATCH v4 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-22 Thread Matthias Kaehlcke
newer ones that use a supported thermistor. Finally the thermistor won't be changed on newer revisions, hence the thermal zone should be disabled for all lazor (and limozeen) revisions. Instead of disabling it per revision do it once in the shared .dtsi for lazor. Signed-off-by: Matthias Kaehlc

[PATCH v4 0/3] arm64: dts: qcom: sc7180: Disable the charger thermal zone on more trogdor boards

2021-03-22 Thread Matthias Kaehlcke
em. Disable the charger thermal zone for them too. This series is based on v2 of the 'arm64: dts: qcom: Update sc7180-trogdor variants from downstream' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=440315) (no changes since v1) Matthias Kaehlcke (3): arm64:

[PATCH v4 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-22 Thread Matthias Kaehlcke
from the unsupported thermistor. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v4: - added missing '&' to phandle in rev1 - added Reviewed-by tag from Doug Changes in v3: - don't add LOCK key Changes in v2: - moved keyboard definitio

[PATCH v4 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

2021-03-22 Thread Matthias Kaehlcke
bogus temperature values. This also gets rid of the explicit DT files for rev2 and handles rev2 in the rev1 .dts instead. There was some back and forth downstream involving the 'dmic_clk_en' pin, after that was sorted out the DT for rev1 and rev2 is the same. Signed-off-by: Matthias Kaehlc

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-22 Thread Matthias Kaehlcke
Hi Satya, On Mon, Mar 22, 2021 at 06:50:47PM +0530, ska...@codeaurora.org wrote: > Hi Matthias, > > On 2021-03-13 02:10, Matthias Kaehlcke wrote: > > Hi Satya, > > > > On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: > > > Add PM7325/PM8350C/PMK

Re: [PATCH v2 1/2] arm64: dts: qcom: Add "dmic_clk_en" for sc7180-trogdor-coachz

2021-03-15 Thread Matthias Kaehlcke
> in the dtsi. > > Cc: Srinivasa Rao Mandadapu > Cc: Ajit Pandey > Cc: Judy Hsiao > Cc: Cheng-Yi Chiang > Cc: Stephen Boyd > Cc: Matthias Kaehlcke > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke

Re: [PATCH v2 2/2] arm64: dts: qcom: Add "dmic_clk_en" + sound model for sc7180-trogdor-pompom

2021-03-15 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 01:39:31PM -0700, Douglas Anderson wrote: > Match what's downstream for this board. > > Cc: Srinivasa Rao Mandadapu > Cc: Ajit Pandey > Cc: Judy Hsiao > Cc: Cheng-Yi Chiang > Cc: Stephen Boyd > Cc: Matthias Kaehlcke > Signed-off-by

Re: [PATCH v2 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-15 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 02:48:46PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > > > Commit f73558cc83d1 ("arm64: dts: qcom: sc7180: Disable charger > > thermal zone for lazor") disables the charge

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-15 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 02:48:55PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > > > + linux,keymap = < > > + MATRIX_KEY(0x00, 0x02, KEY_BACK) > > +

Re: [PATCH v2 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

2021-03-15 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 02:49:04PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > > > CoachZ rev3 uses a 100k NTC thermistor for the charger temperatures, > > instead of the 47k NTC that is stuffed in earlier revisi

[PATCH v3 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

2021-03-15 Thread Matthias Kaehlcke
bogus temperature values. This also gets rid of the explicit DT files for rev2 and handles rev2 in the rev1 .dts instead. There was some back and forth downstream involving the 'dmic_clk_en' pin, after that was sorted out the DT for rev1 and rev2 is the same. Signed-off-by: Ma

[PATCH v3 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-15 Thread Matthias Kaehlcke
newer ones that use a supported thermistor. Finally the thermistor won't be changed on newer revisions, hence the thermal zone should be disabled for all lazor (and limozeen) revisions. Instead of disabling it per revision do it once in the shared .dtsi for lazor. Signed-off-by: Matthias Kaehlc

[PATCH v3 0/3] arm64: dts: qcom: sc7180: Disable the charger thermal zone on more trogdor boards

2021-03-15 Thread Matthias Kaehlcke
em. Disable the charger thermal zone for them too. This series is based on v2 of the 'arm64: dts: qcom: Update sc7180-trogdor variants from downstream' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=440315) (no changes since v1) Matthias Kaehlcke (3): arm64:

[PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-15 Thread Matthias Kaehlcke
from the unsupported thermistor. Signed-off-by: Matthias Kaehlcke --- Changes in v3: - don't add LOCK key Changes in v2: - moved keyboard definition to sc7180-trogdor-pompom.dtsi instead of duplicating it, use cros-ec keyboard for rev1 - squashed with 'arm64: dts: qcom: sc7180: pompo

Re: [PATCH V2 4/5] dt-bindings: regulator: Convert regulator bindings to YAML format

2021-03-16 Thread Matthias Kaehlcke
Subject: dt-bindings: regulator: Convert regulator bindings to YAML format Make sure to mention that this is about the RPMh regulators, not the general regulator binding which was already converted. On Mon, Mar 15, 2021 at 07:24:13PM +0530, satya priya wrote: > Convert regulator bindings from .tx

Re: [PATCH V2 1/5] regulator: qcom-rpmh: Add pmic5_ftsmps520 buck

2021-03-16 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 07:24:10PM +0530, satya priya wrote: > Add pmic5_ftsmps520 buck as this is required for PM7325 > and PMR735A PMICs. > > Signed-off-by: satya priya Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/5] regulator: qcom-rpmh: Add PM7325/PMR735A regulator support

2021-03-16 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 07:24:11PM +0530, satya priya wrote: > Add support for PM7325/PMR735A regulators. This ensures > that consumers are able to modify the physical state of PMIC > regulators. > > Signed-off-by: satya priya > --- > Changes in V2: > - No change. > > drivers/regulator/qcom-rp

Re: [PATCH V2 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp

2021-03-16 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 07:24:12PM +0530, satya priya wrote: > Add regulator devices for SC7280 as RPMh regulators. This ensures > that consumers are able to modify the physical state of PMIC > regulators. > > Signed-off-by: satya priya > --- > Changes in V2: > - Corrected the indentation for "c

Re: [PATCH V2 5/5] dt-bindings: regulator: Add compatibles for PM7325/PMR735A

2021-03-16 Thread Matthias Kaehlcke
On Mon, Mar 15, 2021 at 07:24:14PM +0530, satya priya wrote: > Add PM7325/PMR735A compatibles for Qualcomm SC7280 platform. > > Signed-off-by: satya priya > Acked-by: Rob Herring Reviewed-by: Matthias Kaehlcke

[PATCH v1] arm64: dts: qcom: sc7180: coachz: Add thermal config for skin temperature

2021-04-14 Thread Matthias Kaehlcke
bogus temperature values. Signed-off-by: Matthias Kaehlcke --- .../dts/qcom/sc7180-trogdor-coachz-r1.dts | 9 +++ .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 63 +++ 2 files changed, 72 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts b

Re: [PATCH v6 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs

2021-04-19 Thread Matthias Kaehlcke
On Fri, Apr 16, 2021 at 03:31:51PM +0530, Sandeep Maheswaram wrote: > Adding helper functions to enable,disable wake irqs to make > the code simple and readable. > > Signed-off-by: Sandeep Maheswaram Reviewed-by: Matthias Kaehlcke

Re: [PATCH v6 1/5] usb: dwc3: host: Add suspend_quirk for dwc3 host

2021-04-19 Thread Matthias Kaehlcke
On Fri, Apr 16, 2021 at 03:31:49PM +0530, Sandeep Maheswaram wrote: > Subject: usb: dwc3: host: Add suspend_quirk for dwc3 host > > Adding suspend quirk function for dwc3 host which will be called > during xhci suspend. > Setting hs_phy_mode, ss_phy_mode , phy_power_off flags and phy mode > during

Re: [PATCH v6 2/5] usb: dwc3: core: Host wake up support from system suspend

2021-04-19 Thread Matthias Kaehlcke
; > Signed-off-by: Sandeep Maheswaram Reviewed-by: Matthias Kaehlcke

Re: [PATCH v6 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend

2021-04-19 Thread Matthias Kaehlcke
eup_irq(qcom->dm_hs_phy_irq); > + else { > + dwc3_qcom_enable_wakeup_irq(qcom->dp_hs_phy_irq); > + dwc3_qcom_enable_wakeup_irq(qcom->dm_hs_phy_irq); > + } ditto > dwc3_qcom_enable_wakeup_irq(qcom->ss_phy_irq); > } Other than the nits: Reviewed-by: Matthias Kaehlcke

Re: [PATCH v6 5/5] usb: dwc3: qcom: Set genpd active wakeup flag for usb gdsc

2021-04-19 Thread Matthias Kaehlcke
On Fri, Apr 16, 2021 at 03:31:53PM +0530, Sandeep Maheswaram wrote: > Subject: usb: dwc3: qcom: Set genpd active wakeup flag for usb gdsc > > Set genpd active wakeup flag for usb gdsc if wakeup capable devices > are connected so that wake up happens without reenumeration. Better describe things a

Re: [PATCH 1/3] dt-bindings: usb: qcom,dwc3: Add bindings for SC7280

2021-03-17 Thread Matthias Kaehlcke
.yaml > @@ -16,6 +16,7 @@ properties: >- qcom,msm8996-dwc3 >- qcom,msm8998-dwc3 >- qcom,sc7180-dwc3 > + - qcom,sc7280-dwc3 >- qcom,sdm845-dwc3 >- qcom,sdx55-dwc3 > - qcom,sm8150-dwc3 Reviewed-by: Matthias Kaehlcke

Re: [PATCH 2/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for SC7280

2021-03-17 Thread Matthias Kaehlcke
tation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > @@ -16,6 +16,7 @@ properties: >compatible: > enum: >- qcom,usb-snps-hs-7nm-phy > + - qcom,sc7280-usb-hs-phy >- qcom,sm8150-usb-hs-phy >- qcom,sm8250-usb-hs-phy > - qcom,sm8350-usb-hs-phy Reviewed-by: Matthias Kaehlcke

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-17 Thread Matthias Kaehlcke
GPM940B0 3.0" QVGA TFT LCD panel >- giantplus,gpm940b0 > +# A panel connected to a google,pompom board. Panel is guaranteed to > +# confirm to google,pompom-panel power sequencing requirements and > then s/confirm/conform/ ? > +# the specific panel will be probed via EDID. > + - google,pompom-panel > # HannStar Display Corp. HSD070PWW1 7.0" WXGA TFT LCD panel >- hannstar,hsd070pww1 > # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel FWIW: Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325

2021-04-02 Thread Matthias Kaehlcke
On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote: > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or similar? > Add temp-alarm and GPIO support for pm7325. nit: it's more than that, you are adding the .

Re: [PATCH V2 3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350

2021-04-02 Thread Matthias Kaehlcke
On Thu, Apr 01, 2021 at 02:43:14PM +0530, satya priya wrote: > subject: arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 same nit as for 1/5: maybe just 'arm64: dts: qcom: Add pml7350 support/.dtsi' or similar since this adds the initial .dtsi for the pmk8350? > Add PON, GPIO, RTC and

Re: [PATCH V2 4/5] arm64: dts: qcom: pmr735a: Add PMIC peripherals for pmr735a

2021-04-02 Thread Matthias Kaehlcke
Same comments as '[1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325', plus another nit: '[3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350' has an ADC config for the die temperature of the pmr735a, hence it seems this patch should be before the 'pmk8350' one in this s

Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325

2021-04-02 Thread Matthias Kaehlcke
On Fri, Apr 02, 2021 at 10:35:54AM -0700, Matthias Kaehlcke wrote: > On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote: > > > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 > > nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi'

[PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver

2021-04-05 Thread Matthias Kaehlcke
device is connected when suspending, and power it off otherwise. Changes in v7: - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (5): dt-bindings: usb: Add binding for Realtek RTS5411 hub controller USB:

[PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller

2021-04-05 Thread Matthias Kaehlcke
The Realtek RTS5411 is a USB 3.0 hub controller with 4 ports. This initial version of the binding only describes USB related aspects of the RTS5411, it does not cover the option of connecting the controller as an i2c slave. Signed-off-by: Matthias Kaehlcke --- Changes in v7: - added type ref

[PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver

2021-04-05 Thread Matthias Kaehlcke
2.0 and another for USB 3.x). Note: the driver currently only works with hubs connected directly to a root hub, but it could be extended to support other configurations if needed. Co-developed-by: Ravi Chandra Sadineni Signed-off-by: Ravi Chandra Sadineni Signed-off-by: Matthias Kaehlcke ---

[PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy()

2021-04-05 Thread Matthias Kaehlcke
Code for platform_device_create() and of_platform_device_create() is only generated if CONFIG_OF_ADDRESS=y. Add stubs to avoid unresolved symbols when CONFIG_OF_ADDRESS is not set. Signed-off-by: Matthias Kaehlcke --- Changes in v7: - none Changes in v6: - patch added to the series include

[PATCH v6 4/5] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-04-05 Thread Matthias Kaehlcke
). Further the platform device is only created when CONFIG_USB_ONBOARD_HUB=y/m. Signed-off-by: Matthias Kaehlcke --- Changes in v7: - none Changes in v6: - none Changes in v5: - patch added to the series drivers/usb/host/xhci-plat.c | 16 include/linux/usb/hcd.h | 2 ++ 2

[PATCH v6 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub

2021-04-05 Thread Matthias Kaehlcke
Add nodes for the onboard USB hub on trogdor devices. Remove the 'always-on' and 'boot-on' properties from the hub regulator, since the regulator is now managed by the onboard_usb_hub driver. Signed-off-by: Matthias Kaehlcke --- Changes in v7: - rebased on qcom/arm64-for-5.

Re: [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver

2021-04-05 Thread Matthias Kaehlcke
> Subject: [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver Argh, that should have been v7 :/ Not sure if it's worth/required to resend. On Mon, Apr 05, 2021 at 01:18:12PM -0700, Matthias Kaehlcke wrote: > This series adds: > - the onboard_usb_hub_driver > - glue in the xh

[PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4

2021-02-19 Thread Matthias Kaehlcke
Lazor rev3 and older are stuffed with a 47k NTC thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. A supported thermistor is used in rev4 and later revisions. Add rev4 .dts files to be able to account for this. Signed-off-by: Matthias Kae

[PATCH 3/3] arm64: dts: qcom: sc7180: Delete charger thermal zone and ADC channel for lazor <= rev3

2021-02-19 Thread Matthias Kaehlcke
Lazor rev3 and older are stuffed with a 47k NTC as thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. Delete the charger thermal zone and ADC channel to avoid the use of bogus temperature values. Signed-off-by: Matthias Kaehlcke --- arch/arm64

[PATCH 2/3] arm64: dts: qcom: sc7180: trogdor: Add labels to charger thermal zone and ADC channel

2021-02-19 Thread Matthias Kaehlcke
alues. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 07c8b2c926c0..fa996387715b 100644

Re: [PATCH v5 1/4] dt-bindings: usb: Add binding for discrete onboard USB hubs

2021-02-22 Thread Matthias Kaehlcke
On Fri, Feb 19, 2021 at 09:05:32AM -0600, Rob Herring wrote: > On Wed, Feb 17, 2021 at 7:33 PM Matthias Kaehlcke wrote: > > > > Hi Rob, > > > > thanks for your review! > > > > On Wed, Feb 17, 2021 at 03:04:41PM -0600, Rob Herring wrote: > > > On

[PATCH v4] arm64: dts: qcom: sc7180-trogdor: Make pp3300_a the default supply for pp3300_hub

2020-11-24 Thread Matthias Kaehlcke
e earlier revisions also allocated the GPIO to the purpose of controlling the power switch, so there is no need to limit the pinctrl config to newer revisions. Remove the platform-wide 'always/boot-on' properties from 'pp3300_l7c' and add them to the boards that use this supply. A

[PATCH v2 0/3] arm64: dts: qcom: sc7180: Disable the charger thermal zone on more trogdor boards

2021-03-12 Thread Matthias Kaehlcke
em. Disable the charger thermal zone for them too. This series is based on v2 of the 'arm64: dts: qcom: Update sc7180-trogdor variants from downstream' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=440315) (no changes since v1) Matthias Kaehlcke (3): arm64:

[PATCH v2 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

2021-03-12 Thread Matthias Kaehlcke
newer ones that use a supported thermistor. Finally the thermistor won't be changed on newer revisions, hence the thermal zone should be disabled for all lazor (and limozeen) revisions. Instead of disabling it per revision do it once in the shared .dtsi for lazor. Signed-off-by: Matthias Kaehlck

[PATCH v2 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

2021-03-12 Thread Matthias Kaehlcke
bogus temperature values. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - added CoachZ rev3 - updated subject and commit message arch/arm64/boot/dts/qcom/Makefile | 2 ++ .../boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 9 + .../dts/qcom/sc7180-trogdor-coachz-r2-lt

[PATCH v2 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-12 Thread Matthias Kaehlcke
from the unsupported thermistor. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - moved keyboard definition to sc7180-trogdor-pompom.dtsi instead of duplicating it, use cros-ec keyboard for rev1 - squashed with 'arm64: dts: qcom: sc7180: pompom: Disable charger thermal zone for rev

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-12 Thread Matthias Kaehlcke
Hi Satya, On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: > Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, > GPIOs, RTC and other PMIC infra modules for SC7280. > > Signed-off-by: satya priya > --- > This patch depends on base DT and board files for SC7280 to merge firs

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-12 Thread Matthias Kaehlcke
On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: > Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, > GPIOs, RTC and other PMIC infra modules for SC7280. > > Signed-off-by: satya priya > --- > This patch depends on base DT and board files for SC7280 to merge first > https:/

[PATCH v2] usb: dwc3: qcom: Honor wakeup enabled/disabled state

2021-03-02 Thread Matthias Kaehlcke
: Add Qualcomm DWC3 glue driver") Signed-off-by: Matthias Kaehlcke Reviewed-by: Bjorn Andersson --- Changes in v2: - rebased on top of v5.12-rc1 drivers/usb/dwc3/dwc3-qcom.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb

Re: [PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy()

2021-03-09 Thread Matthias Kaehlcke
On Mon, Mar 08, 2021 at 03:32:51PM -0700, Rob Herring wrote: > On Fri, Mar 05, 2021 at 11:38:51AM -0800, Matthias Kaehlcke wrote: > > Code for platform_device_create() and of_platform_device_create() is > > You mean of_platform_device_create and of_platform_device_des

[PATCH] arm64: dts: sdm845: Add dynamic CPU power coefficients

2019-02-11 Thread Matthias Kaehlcke
Add dynamic power coefficients for the Silver and Gold CPU cores of the Qualcomm SDM845. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845

Re: [PATCH] drivers: devfreq: change devfreq workqueue mechanism

2019-02-11 Thread Matthias Kaehlcke
Hi Lukasz, On Mon, Feb 11, 2019 at 11:05:27AM +0100, Lukasz Luba wrote: > Hi Matthias, > > My apologize for late response, I did not have access to mailbox. > Thank you for review, please check the comments below. > > On 2/5/19 1:39 AM, Matthias Kaehlcke wrote: > > Hi

Re: [PATCH v2 2/2] drivers: devfreq: change deferred work into delayed

2019-02-11 Thread Matthias Kaehlcke
esn't really depend on it. If -stable wants to integrate the fix, they also need to pick the improvement (or resolve a conflict), which might not be desired. Otherwise this looks sane to me: Reviewed-by: Matthias Kaehlcke

<    3   4   5   6   7   8   9   10   11   12   >