On Fri, Sep 07, 2012 at 09:47:01AM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 07, 2012 at 01:40:43PM +0200, Stefan Bader wrote:
> > When writing unsupported flags into CR4 (for some time the
> > xen_write_cr4 function would refuse to do anything at all)
> > older Xen hypervisors (and patch c
On Fri, Sep 07, 2012 at 11:00:22AM -0500, Justin M. Forbes wrote:
> On Fri, 2012-09-07 at 16:44 +0100, Jan Beulich wrote:
> >
> > All of this still doesn't provide evidence that a plain upstream
> > kernel is actually having any problems in the first place. Further,
> > if you say EC2 has a crippl
fig|9 +++--
> drivers/char/hpet.c | 25 +++--
> 3 files changed, 34 insertions(+), 4 deletions(-)
It doesn't seem like this patch got picked up and seems like a good
idea to me. Clemens, what do you think?
Acked-by: Matt Wilson
--msw
On Mon, Jul 08, 2013 at 03:28:54PM -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 08, 2013 at 08:28:24AM +0200, Michael Opdenacker wrote:
> > This patch proposes to remove the XEN_PRIVILEGED_GUEST kernel
> > configuration parameter defined in arch/x86/xen/Kconfig, but used
> > nowhere in the mak
On Wed, Jul 10, 2013 at 12:34:58AM +0200, Sander Eikelenboom wrote:
>
> Tuesday, July 9, 2013, 5:05:54 PM, you wrote:
>
> > On Tue, Jul 09, 2013 at 10:48:40AM -0400, Konrad Rzeszutek Wilk wrote:
> >> Then that should be discussed on grub2 to remove said check and modify
> >> the code so that it c
On Fri, Sep 07, 2012 at 10:54:33AM -0400, Konrad Rzeszutek Wilk wrote:
>
> Sure. Jan is asking though for actual confirmation that the upstream kernel
> does indeed go belly up without a workaround.
> And whether this patch (which I would did since Canonical is carrying it) does
> fix the issue.
>
On Mon, Jul 29, 2013 at 07:15:43PM +0200, Daniel Kiper wrote:
> Hi all,
>
> Here I am sending as attachments patches enabling kexec/kdump
> support in Xen PV domU. Only x84_64 architecture is supported.
> There is no support for i386 but some code could be easily reused.
> Here is a description of
in the list. If we add the same callback twice
> we end up with an infinite loop, were callback == callback->next.
>
> Replace this check with a proper one that iterates over the list to
> see if the callback has already been added.
Acked-by: Matt Wilson
> Signed-off-by: Roger
is controlled by the
> value in blkback).
>
> Signed-off-by: Roger Pau Monné
Acked-by: Matt Wilson
> Cc: Konrad Rzeszutek Wilk
> Cc: David Vrabel
> ---
> drivers/block/xen-blkfront.c | 33 +
> 1 files changed, 29 insertions(+), 4 delet
On Mon, Jul 22, 2013 at 11:33:15AM -0700, Greg KH wrote:
> On Mon, Jul 22, 2013 at 11:24:46AM -0700, H. Peter Anvin wrote:
> > On 07/22/2013 10:20 AM, Eric W. Biederman wrote:
> > >>>
> > >>> Also, in any virtualized environment the hypervisor can do a better job
> > >>> for things like kdump, simp
Harvey
Cc: net...@vger.kernel.org
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
Acked-by: Ian Campbell
Signed-off-by: Matt Wilson
---
Changes since v1:
* No code changes, only updated commit message
---
drivers/net/xen-netback/interface.c |2 ++
1 files changed, 2 insertions(+), 0
On Fri, Jan 11, 2013 at 04:35:50PM -0500, Konrad Rzeszutek Wilk wrote:
>
> With this patch I get:
>
> [2.555087] GHES: HEST is not enabled!
> [2.560522] ioatdma: Intel(R) QuickData Technology Driver 4.00
> [2.569651] [ cut here ]
> [2.570529] kernel BUG at
On Mon, Jan 14, 2013 at 04:58:54PM +0100, Stefan Bader wrote:
> Starting with kernel v3.7 the following commit added a quirk
> to obtain the real frequencies of certain AMD systems:
>
> commit f594065faf4f9067c2283a34619fc0714e79a98d
> Author: Matthew Garrett
> Date: Tue Sep 4 08:28:06 2012 +00
ame can be appropriately set. A few BUG_ON()s have
been added to prevent this type of bug from reoccurring in the future.
Signed-off-by: Matt Wilson
Reviewed-and-Tested-by: Steven Noonan
Signed-off-by: Ian Campbell
Cc: Konrad Rzeszutek Wilk
Cc: Annie Li
Cc: xen-de...@lists.xen.org
Cc: linux-kernel@vger.
On Tue, Jan 15, 2013 at 01:21:27PM +, Matt Wilson wrote:
> Commit 85ff6acb075a484780b3d763fdf41596d8fc0970 (xen/granttable: Grant
> tables V2 implementation) changed the GREFS_PER_GRANT_FRAME macro from
> a constant to a conditional expression. The expression depends on
> grant_t
On Tue, Jan 15, 2013 at 02:04:30PM +0100, Matt Wilson wrote:
> On Mon, Jan 14, 2013 at 04:58:54PM +0100, Stefan Bader wrote:
> > Starting with kernel v3.7 the following commit added a quirk
> > to obtain the real frequencies of certain AMD systems:
On Wed, Jan 16, 2013 at 04:22:49PM -0500, Konrad Rzeszutek Wilk wrote:
> We have the framework to use v2, but there are no backends that
> actually use it. The end result is that on PV we use v2 grants
> and on PVHVM v1. The v1 has a capacity of 512 grants per page while
> the v2 has 256 grants per
ame can be appropriately set. A few BUG_ON()s have
been added to prevent this type of bug from reoccurring in the future.
Signed-off-by: Matt Wilson
Reviewed-and-Tested-by: Steven Noonan
Cc: Ian Campbell
Cc: Konrad Rzeszutek Wilk
Cc: Annie Li
Cc: xen-de...@lists.xen.org
Cc: linux-kernel@vger.kernel.o
On Wed, Jan 09, 2013 at 12:02:09PM +, Ian Campbell wrote:
> On Wed, 2013-01-09 at 02:40 +, ANNIE LI wrote:
> > > @@ -1080,18 +1081,18 @@ static void gnttab_request_version(void)
> > > panic("we need grant tables version 2, but only version
> > > 1 is available");
> > >
This is because Jakub fixed it in GCC 3.0 CVS at the same time that he
fixed it in 2.96-82, which was on the same day it was reported. It
was broken in GCC CVS until that moment.
Cheers,
Matt
On Wed, May 09, 2001 at 09:56:24AM +0100, Alan Cox wrote:
> > As this is with Red Hat's version of gcc
From: Matt Wilson
Cc: sta...@vger.kernel.org
Signed-off-by: Matt Wilson
---
drivers/tty/serial/8250/8250_pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_pci.c
b/drivers/tty/serial/8250/8250_pci.c
index 0c101a7..d4e7be8 100644
--- a/drivers/tty/serial
From: Matt Wilson
This device will be used in future Amazon EC2 instances as the primary
serial port (i.e., data sent to this port will be available via the
GetConsoleOuput [1] EC2 API).
[1]
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetConsoleOutput.html
Cc: sta
On Tue, Nov 05, 2013 at 05:03:58PM +0100, Roger Pau Monné wrote:
> On 05/11/13 16:08, Ian Campbell wrote:
> > On Tue, 2013-11-05 at 16:01 +0100, Roger Pau Monné wrote:
> >> On 05/11/13 15:56, Konrad Rzeszutek Wilk wrote:
> >>> On Tue, Nov 05, 2013 at 03:47:08PM +0100, Roger Pau Monné wrote:
>
On Tue, Nov 05, 2013 at 02:09:53PM -0800, Anthony Liguori wrote:
> On Tue, Nov 5, 2013 at 1:16 PM, Konrad Rzeszutek Wilk
> wrote:
> > On Tue, Nov 05, 2013 at 12:53:17PM -0800, Anthony Liguori wrote:
> >> Matt Wilson writes:
> >>
> >> > On Tue, Nov 05,
On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote:
>
> Hey Jens,
>
> Please git pull the following branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git
> stable/for-jens-3.13
>
>
> which has a fix to the Xen block frontend driver. For the backends that
On Tue, Nov 05, 2013 at 02:52:29PM -0800, Matt Wilson wrote:
> On Tue, Nov 05, 2013 at 11:59:08AM -0500, Konrad Rzeszutek Wilk wrote:
> >
> > Hey Jens,
> >
> > Please git pull the following branch:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/k
On Wed, Nov 06, 2013 at 11:34:27AM +, David Vrabel wrote:
[...]
>
> Matt, Anthony, I presume you have profiling results or performance data
> that support this proposed change? Can you provide them?
I've measured 10-20% performance improvement in configurations where:
1) dom0 has a moderate
;
Cc: Ian Campbell
Cc: David Vrabel
Cc: linux-kernel@vger.kernel.org
Cc: xen-de...@lists.xen.org
Cc: Anthony Liguori
Signed-off-by: Matt Rushton
Signed-off-by: Matt Wilson
---
drivers/block/xen-blkback/blkback.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
On Thu, Jan 23, 2014 at 09:23:44PM +, Zoltan Kiss wrote:
> The grant mapping API does m2p_override unnecessarily: only gntdev needs it,
> for blkback and future netback patches it just cause a lock contention, as
> those pages never go to userspace. Therefore this series does the following:
> -
On Fri, Jan 24, 2014 at 03:36:22PM +, Ian Campbell wrote:
> On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote:
> > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote:
> > > From: Matt Rushton
> > >
> > > Currently shrink_free_pagepool()
nel/1590932 for a full
> analysis of current users.
>
> Signed-off-by: Anthony Liguori
Reviewed-by: Matt Wilson
One comment for discussion below.
> ---
> A backported version of this has been heavily tested but the testing
> against the latest Linux tree is light so far.
[...]
From: Matt Wilson
Commit f62805f1 introduced a bug where lazy MMU mode isn't exited if a
m2p_add/remove_override call fails.
Cc: Stefano Stabellini
Cc: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky
Cc: David Vrabel
Cc: Anthony Liguori
Cc: xen-de...@lists.xenproject.org
Cc: linux-k
use these IDs for something else.
> >
> > PCI-SIG assigns vendor IDs and 0x1d0f is assigned to Amazon. See
> > https://www.pcisig.com/membership/vid_search/
> >
> > Vendors self-manage device IDs and we have allocated 0x1000-0x103f to
> > virtio device
; >> red-black tree.
> >>
> >> Also, add some checks in xen_blkif_free to make sure we are cleaning
> >> everything.
> >>
> >> Signed-off-by: Roger Pau Monné
> >> Cc: Konrad Rzeszutek Wilk
> >> Cc: David Vrabel
> >> Cc
On Tue, Jan 28, 2014 at 03:38:37PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Jan 28, 2014 at 06:43:32PM +0100, Roger Pau Monne wrote:
> > blkback bug fixes for memory leaks (patches 1 and 2) and a race
> > (patch 3).
>
> They all look OK to me. I've stuck them in my 'stable/for-jens-3.14'
> b
On Mon, Feb 03, 2014 at 01:24:58PM +, Zoltan Kiss wrote:
> The grant mapping API does m2p_override unnecessarily: only gntdev needs it,
> for blkback and future netback patches it just cause a lock contention, as
> those pages never go to userspace. Therefore this series does the following:
> -
On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Feb 04, 2014 at 11:26:11AM +0100, Roger Pau Monne wrote:
> > This series contain blkback bug fixes for memory leaks (patches 1 and
> > 2) and a race (patch 3). Patch 4 removes blkif_request_segment_aligned
> > since
On Thu, Feb 06, 2014 at 11:20:04AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Feb 05, 2014 at 08:57:30PM -0800, Matt Wilson wrote:
> > On Tue, Feb 04, 2014 at 11:15:01AM -0400, Konrad Rzeszutek Wilk wrote:
> > > On Tue, Feb 04, 2014 at 11:26:11AM +0100, Roger Pau Monne w
On Mon, Aug 11, 2014 at 10:34:01AM -0700, Matt Rushton wrote:
> Instead of ballooning up and down dom0 memory this remaps the existing mfns
> that were replaced by the identity map. The reason for this is that the
> existing implementation ballooned memory up and and down which caused dom0
> to hav
On Fri, Aug 01, 2014 at 03:52:28PM +0100, David Vrabel wrote:
> On 31/07/14 18:43, David Vrabel wrote:
> > On 20/07/14 01:01, Matt Rushton wrote:
> >> Instead of ballooning up and down dom0 memory this remaps the existing mfns
> >> that were replaced by the identity map. The reason for this is that
Hi Netanel,
Looks like the last round of internal review went to {lkml,netdev,etc},
so this should be considered a RFC patch.
The description still needs work.
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote:
> This is a driver for the Amazon ethernet ENA family.
ethernet -> Et
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote:
[...]
> diff --git a/drivers/net/ethernet/amazon/Kconfig
> b/drivers/net/ethernet/amazon/Kconfig
> new file mode 100644
> index 000..bc4f240d
> --- /dev/null
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -0,0 +1,27 @@
> +#
>
On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote:
> On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote:
> > +
> > +The ENA driver supports industry standard TCP/IP offload features
> > such
> > +as checksum offload and TCP transmit segmentation offload (TSO).
> > +
> > +Receive-s
On Tue, Jun 14, 2016 at 10:25:16PM -0700, David Miller wrote:
> From: Netanel Belgazal
> Date: Mon, 13 Jun 2016 11:46:13 +0300
>
> > +#define ena_trc_dbg(format, arg...) \
> > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg)
> > +#define ena_trc_info(format, arg...) \
> > + pr_info("[ENA_
On Tue, Jun 14, 2016 at 11:27:09PM -0700, David Miller wrote:
> From: Matt Wilson
> Date: Tue, 14 Jun 2016 23:23:36 -0700
>
> > Point taken, though existing drivers (even fairly popular ones) also
> > aren't as clean as you might like. A quick look around...
>
>
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal
[...]
> +
> +struct ena_napi {
> + struct napi_struct napi cacheline_aligned;
> + struct ena_ring *tx_ring;
On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote:
>
> You also had a few typos in the email addresses on the Cc: line that
> I've corrected (d...@avemeloft.net -> da...@davemeloft.net,
Argh, and of course I typo'ed the correction. -> da...@davemloft.net.
--msw
end emails as plain
text only. Have a look at [1] for how to set up a mailer like mutt
with Gmail.
--msw
[1] https://www.kernel.org/doc/Documentation/email-clients.txt
> On 15 June 2016 at 21:22, Matt Wilson wrote:
>
> > On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote:
>
On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal
> ---
>
> Notes:
> Changes in v3:
> - Fix compilation warning for 32bit systems. [kbuild test rebot]
> - Replace netdev->
On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote:
> On 2016/07/14 08:22, Matt Wilson wrote:
> [...]
> >
> > Dave and Benjamin,
> >
> > Do you want to see the interrupt moderation extensions to ethtool and
> > the sysfs nodes removed befo
On Sun, Dec 04, 2016 at 09:37:43PM -0500, David Miller wrote:
>
> It is not appropriate to submit so many patches at one time.
Indeed, https://www.kernel.org/doc/Documentation/SubmittingPatches
recommends submitting no more than 15 or so at once.
> Please keep your patch series to no more than a
On Sun, Dec 04, 2016 at 03:19:19PM +0200, Netanel Belgazal wrote:
> Remove NETIF_F_NTUPLE from netdev->features.
> The ENA device driver does not support ntuple filtering.
>
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon
d 75 columns.
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.
ible_cpus(), num_online_cpus().
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/d
On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote:
> ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type
> treat the ena_flow_hash_to_flow_type enum as power of two values.
>
> Change the values of ena_admin_flow_hash_fields to be power of two values.
Then I generally prefer
On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote:
> ENA default hash configure IPv4_frag hash twice instead of
configure -> configures. You may want to include "erroneously". What
is the consequence of this bug?
> configure non ip packets.
configuring non-IP packets.
--msw
> Si
On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote:
> ndo_get_stat64 can be called from atomic context.
> However the current implementation sends an admin command to retrieve
> the statistics from the device.
> This admin commands uses sleep.
Suggest some comment edits:
ndo_get_sta
On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote:
> If for some reason the device stop responding and the device reset failed
> to recover the device, the mmio register read datastructure will not be
> reinitialized.
If for some reason the device stops responding, and the device re
On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote:
> The ENA device can update the ena driver about the desire timeouts.
> The hardware hints are transmitted as Asynchronous event to the driver.
This is really a new feature, not a bugfix - correct? If it is a new
feature, submit it
On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote:
... because? (they turned out to be too aggressive, I believe.)
> Signed-off-by: Netanel Belgazal
> ---
> drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++--
> drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 ---
> 2 file
On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote:
> Netanel Belgazal :
> [...]
>
> Very limited review below.
I'll comment on the documentation (since I edited it heavily) but will
leave some the other parts for Netanel to answer.
> > diff --git a/Documentation/networking/ena.txt
On Thu, Jun 16, 2016 at 07:06:52PM +0100, Ben Hutchings wrote:
> On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> > On 2016/06/13 11:46, Netanel Belgazal wrote:
> [...]
> > > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > > + struct device
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
Reviewed-by: Matt Wilson
> Signed-off-by: Netanel Belgazal
> ---
> Documentation/networking/00-INDEX |2 +
> Documenta
On Mon, Nov 13, 2017 at 11:31:31AM -0800, Matt Wilson wrote:
> From: Matt Wilson
>
> This device will be used in future Amazon EC2 instances as the primary
> serial port (i.e., data sent to this port will be available via the
> GetConsoleOuput [1] EC2 API).
Ping?
--msw
64 matches
Mail list logo
