[PATCH 2/3] fs: annotate implicit fall through

statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/locks.c b/fs/locks.c index ff6af2c32601..d958c3863b4b 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -1471,7 +1471,7 @@ static void

[PATCH 1/3] fs: annotate implicit fall throughs

statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/libfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/libfs.c b/fs/libfs.c index 0fb590d79f30..9efb647917e0 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -146,9 +146,11 @@ loff_t

[PATCH 3/3] fs/fcntl: annotate implicit fall through

statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/fcntl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index 083185174c6d..3d40771e8e7c 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -769,7 +769,7 @@ static

[PATCH 2/2] ext4: annotate implicit fall throughs

:6: warning: this statement may fall through [-Wimplicit-fallthrough=] fs/ext4/indirect.c:1432:6: warning: this statement may fall through [-Wimplicit-fallthrough=] fs/ext4/indirect.c:1440:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH 1/2] ext4: annotate implicit fall throughs

: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/ext4/hash.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c index e22dcfab308b..46b24da33a28 100644 --- a/fs/ext4/hash.c +++ b/fs/ext4/hash.c @@ -231,6

[PATCH] video: offb: annotate implicit fall throughs

/fbdev/offb.c:142:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/video/fbdev/offb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index 31f769d67195..e0f0c5351306

[PATCH] vt: annotate implicit fall throughs

:2237:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/tty/vt/vt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 41ec8e5010f3..e4f8caed26af 100644 --- a/drivers/tty/vt/vt.c +++ b

[PATCH 2/2] PCI: annotate implicit fall through

: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b0a413f3f7ca..9fabcef345ed 100644 --- a/drivers/pci

[PATCH 1/2] PCI: annotate implicit fall throughs

: drivers/pci/pci.c:861:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/pci/pci.c:2261:7: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/pci/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] mmc: core: annotate implicit fall through

to fit the max line length of 80 characters. This commit remove the following warning: drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 2/2] firewire: annotate implicit fall through

'set_broadcast_channel': ../drivers/firewire/core-device.c:969:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (data & cpu_to_be32(1 << 31)) { Signed-off-by: Mathieu Malaterre --- drivers/firewire/core-device.c | 2 +- 1 file changed, 1 inse

[PATCH 1/2] firewire: annotate implicit fall through

following warning: drivers/firewire/core-iso.c:308:7: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/firewire/core-iso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/core-iso.c b/drivers/fir

[PATCH] firewire: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: drivers/firewire/core-topology.c:69:23: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu

[PATCH] nvram: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > caused kernel panic on PowerPC if an external module is used with > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed > for the external module build. > >

[PATCH] video/hdmi: Change strncpy() into memcpy() in hdmi_spd_infoframe_init

: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation] drivers/video/hdmi.c:235:2: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation] Signed-off-by: Mathieu Malaterre --- drivers/video/hdmi.c | 4 ++-- 1 file changed

[PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

uncation] Cc: Nick Desaulniers Link: https://lore.kernel.org/patchwork/patch/910830/ Signed-off-by: Mathieu Malaterre --- include/trace/events/writeback.h | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/include/trace/events/writeback.h b

Re: [PATCH] video/hdmi: Change strncpy() into memcpy() in hdmi_spd_infoframe_init

On Fri, Jan 18, 2019 at 8:51 PM Joe Perches wrote: > > On Fri, 2019-01-18 at 20:32 +0100, Mathieu Malaterre wrote: > > Using strncpy() is less than perfect since the destination buffers do not > > need to be NUL terminated. Replace strncpy() with memcpy() to address a > >

[PATCH] powerpc: Remove trailing semicolon after curly brace

There is not point in having a trailing semicolon after a closing curly brace. Remove it. Signed-off-by: Mathieu Malaterre --- arch/powerpc/sysdev/tsi108_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c

[PATCH] Move static keyword at beginning of declaration

not at beginning of declaration [-Werror=old-style-declaration] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/ps3/os-area.c| 4 ++-- arch/powerpc/platforms/ps3/system-bus.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/ps3/os-ar

[PATCH] ASoC: Use __printf markup to silence compiler

Silence warnings (triggered at W=1) by adding relevant __printf attributes. sound/soc/soc-dapm.c:149:2: warning: function 'pop_dbg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- sound/soc/soc-

[PATCH] drivers: base: Use __printf markup to silence compiler

Silence warnings (triggered at W=1) by adding relevant __printf attributes. drivers/base/cpu.c:432:2: warning: function '__cpu_device_create' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers

[PATCH] ext2: Annotate implicit fall through in __ext2_truncate_blocks

statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/ext2/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index e4bb9386c045..e64029b1bd50 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1239,6 +1239,7

[PATCH] mac80211: Remove attribute packed from struct 'action'

ves the following warning (W=1): net/mac80211/rx.c:234:2: warning: alignment 1 of 'struct ' is less than 2 [-Wpacked-not-aligned] Cc: Johannes Berg Signed-off-by: Mathieu Malaterre --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net

[PATCH] regmap: Remove attribute packed from struct 'regcache_rbtree_node'

;struct regcache_rbtree_node' is less than 4 [-Wpacked-not-aligned] Cc: Dimitris Papastamos Cc: David Woodhouse Signed-off-by: Mathieu Malaterre --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-rbtre

[PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp

-off-by: Mathieu Malaterre --- net/bluetooth/l2cap_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 2a7fb517d460..a5b76e24940a 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4244,6 +4244,7 @@ static

[PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close

/bluetooth/rfcomm/core.c:479:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: Peter Hurley Signed-off-by: Mathieu Malaterre --- net/bluetooth/rfcomm/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth

Re: [PATCH] mac80211: Remove attribute packed from struct 'action'

On Thu, Jan 24, 2019 at 7:08 PM Johannes Berg wrote: > > On Thu, 2019-01-24 at 19:05 +0100, Mathieu Malaterre wrote: > > During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO > > follow-MAC mode") a new struct 'action' was declared with pac

[PATCH v2] mac80211: Add attribute aligned(2) to struct 'action'

N_SIZE + 1); This removes the following warning (W=1): net/mac80211/rx.c:234:2: warning: alignment 1 of 'struct ' is less than 2 [-Wpacked-not-aligned] Cc: Johannes Berg Suggested-by: Johannes Berg Signed-off-by: Mathieu Malaterre --- v2: It was suggested by Johannes that an arc

Re: [PATCH v8 00/26] Ingenic TCU patchset v8

Paul, On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil wrote: > > Hi, > > Here's the version 8 and hopefully final version of my patchset, which > adds support for the Timer/Counter Unit found in JZ47xx SoCs from > Ingenic. I can no longer boot my MIPS Creator CI20 with this series (merged opendin

Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp

> > net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall > > through [-Wimplicit-fallthrough=] > > > > Cc: Gustavo Padovan > > Signed-off-by: Mathieu Malaterre > > --- > > net/bluetooth/l2cap_core.c | 1 + > > 1 file changed, 1 inserti

Re: [PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close

On Thu, Jan 24, 2019 at 7:07 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > In this particular case put the fall through comment on a separate line so > as to match the

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers wrote: > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre wrote: > > > > In the past an attempt was made to remove a set of warnings triggered by > > gcc 8.x and W=1 by changing calls to strncpy() into strlcpy(). This

Re: [PATCH v8 00/26] Ingenic TCU patchset v8

Paul, On Thu, Jan 24, 2019 at 10:41 PM Paul Cercueil wrote: > > Hi Mathieu, > > Le jeu. 24 janv. 2019 à 18:26, Mathieu Malaterre a > écrit : > > Paul, > > > > On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil > > wrote: > >> > >> Hi, >

[PATCH] powerpc/32s: Include header file to fix a warning

ng-prototypes] Make sure to include to provide the following prototype: module_alloc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/mm/kasan/kasan_init_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.

[PATCH] powerpc: Remove variable ‘path’ since not used

e original patch and simplify the code, by removing the variable ‘path’ completely. Fix line over 90 characters. Suggested-by: Michael Ellerman Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/prom_init.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ar

[PATCH] powerpc/power: Expose pfn_is_nosave prototype

prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning in powerpc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/suspend.c | 1 + include/linux/suspend.h | 1

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

ping ? On Tue, Mar 12, 2019 at 10:23 PM Mathieu Malaterre wrote: > > Fix warnings treated as errors with W=1: > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy >

[PATCH] x86/tsc: Move inline keyword to the beginning of function declarations

line' is not at beginning of declaration [-Wold-style-declaration] Cc: Peter Zijlstra Signed-off-by: Mathieu Malaterre --- arch/x86/kernel/tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 0b29e58f288e..75a41bddbc

[PATCH] clocksource: Move inline keyword to the beginning of function declarations

#x27;inline' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Mathieu Malaterre --- kernel/time/clocksource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 3bcc19ceb073..fff5f

[PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning on powerpc. Also remove the duplicated prototypes since not required anymore. Cc: Christophe Leroy Signed-off-by: Mathieu

Re: [PATCH 2/7] rtc: jz4740: switch to rtc_time64_to_tm/rtc_tm_to_time64

On Thu, Apr 18, 2019 at 12:00 PM Alexandre Belloni wrote: > > Call the 64bit versions of rtc_tm time conversion now that the range is > enforced by the core. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-jz4740.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > >

Re: [PATCH 1/7] rtc: jz4740: set range

On Thu, Apr 18, 2019 at 12:01 PM Alexandre Belloni wrote: > > RTC_SEC is a 32-bit seconds counter. For the entire series: Tested-by: Mathieu Malaterre Arch is MIPS Creator CI20 > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-jz4740.c | 12 ++-- >

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

On Wed, Jun 19, 2019 at 4:18 PM Benjamin Herrenschmidt wrote: > > On Wed, 2019-06-19 at 22:32 +1000, Michael Ellerman wrote: > > Christoph Hellwig writes: > > > Any chance this could get picked up to fix the regression? > > > > Was hoping Ben would Ack it. He's still powermac maintainer :) > > >

Re: [RFC PATCH v1 11/13] powerpc/ptrace: create ppc_gethwdinfo()

On Tue, Jun 25, 2019 at 1:22 PM Christophe Leroy wrote: > > Create ippc_gethwdinfo() to handle PPC_PTRACE_GETHWDBGINFO and s/ippc_gethwdinfo/ppc_gethwdinfo/ > reduce ifdef mess > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/ptrace/ptrace-adv.c | 15 +++ > arch/po

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

On Wed, Jun 5, 2019 at 1:32 PM Mathieu Malaterre wrote: > > On Mon, Jun 3, 2019 at 3:00 PM Christophe Leroy > wrote: > > > > When booting through OF, setup_disp_bat() does nothing because > > disp_BAT are not set. By change, it used to work because BOOTX > >

Help: Regression in v4.19 : do_IRQ: 0.37 No irq handler for vector

[cc me please] Hi there, I recently upgraded my desktop to Debian/buster. Now when I start my xfce session I can hear the system bell, and my dmesg is filled with numerous: [ 920.728347] do_IRQ: 0.37 No irq handler for vector The symptoms seems to be gone using git/master: 3a1d5384b7decbff651

Re: Help: Regression in v4.19 : do_IRQ: 0.37 No irq handler for vector

On Fri, Jul 19, 2019 at 1:32 PM Mathieu Malaterre wrote: > > [cc me please] > > Hi there, > > I recently upgraded my desktop to Debian/buster. Now when I start my > xfce session I can hear the system bell, and my dmesg is filled with > numerous: > > [ 920.728347] d

Re: [PATCH 2/2] MIPS: Fix CONFIG_CMDLINE handling

t early_init_dt_scan_chosen() from using CONFIG_CMDLINE. Sorry I cannot test this patch ATM. I've simply CCed Paul C. just in case. > Signed-off-by: Paul Burton > Fixes: 8ce355cf2e38 ("MIPS: Setup boot_command_line before plat_mem_setup") > References: https://patchwork.linux

Re: [PATCH 1/3] MIPS: jz4780: Allow access to jz4740-i2s

On Fri, Aug 31, 2018 at 10:59 PM Paul Burton wrote: > > On Fri, Aug 31, 2018 at 01:37:52PM -0700, Paul Burton wrote: > > Further to that, this series doesn't seem to work for me. With > > v4.19-rc1, with the patch from [1] & then this series applied I see the > > following when booting a ci20_defc

Re: [PATCH 00/19] powerpc/ppc32: make W=1 compilation errors free

Any chance this could be applied to powerpc/next ? On Thu, Mar 22, 2018 at 9:19 PM, Mathieu Malaterre wrote: > Here is another batch for warnings treated as error on ppc32. Tested with: > > $ make ARCH=powerpc ppc32_defconfig > $ make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-li

[PATCH v2 01/21] powerpc: Remove warning on array size when empty

ed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/prom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index 4dffef947b8a..330c65f04820 100644 --- a/arch/powerpc/kernel/prom.c +++ b/arch/powerpc/kernel/prom.c @@ -

[PATCH v2 06/21] powerpc: Avoid comparison of unsigned long >= 0 in __access_ok

] cc1: all warnings being treated as errors Suggested-by: Segher Boessenkool Signed-off-by: Mathieu Malaterre --- arch/powerpc/include/asm/uaccess.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/

Re: [PATCH 05/21] powerpc: Avoid comparison of unsigned long >= 0 in pfn_valid

On Mon, Feb 26, 2018 at 9:46 AM, Segher Boessenkool wrote: > On Mon, Feb 26, 2018 at 07:32:03AM +0100, Christophe LEROY wrote: >> Le 25/02/2018 à 18:22, Mathieu Malaterre a écrit : >> >-#define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < >&

Re: [PATCH] kernel/module: silence a gcc warning

On Thu, Apr 19, 2018 at 7:15 PM, Mathieu Malaterre wrote: > Hi Jessica, > > On Mon, Apr 16, 2018 at 7:11 PM, Jessica Yu wrote: >> +++ Mathieu Malaterre [11/04/18 21:05 +0200]: >>> >>> In commit 8c8ef42aee8f ("module: include other structures in module

Tracking: radeon 0000:00:10.0: ring 0 stalled for more than 10240msec

Hi there, I am pretty sure I was able to run kodi on an old Mac Mini G4 (big endian) with AMD RV280. Today it is failing to start with: [ 162.971551] radeon :00:10.0: ring 0 stalled for more than 10240msec [ 162.971568] radeon :00:10.0: GPU lockup (current fence id 0x01d6 la

Re: [PATCH] powerpc/mm/radix: add missing braces for single statement block

On Sun, Apr 8, 2018 at 10:34 PM, Randy Dunlap wrote: > On 04/08/2018 12:44 PM, Mathieu Malaterre wrote: >> In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for >> disable_radix") an `if` statement was added for a possible empty body >> (prom_

Re: [PATCH] powerpc/mm/radix: add missing braces for single statement block

On Mon, Apr 23, 2018 at 9:31 PM, Mathieu Malaterre wrote: > On Sun, Apr 8, 2018 at 10:34 PM, Randy Dunlap wrote: >> On 04/08/2018 12:44 PM, Mathieu Malaterre wrote: >>> In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for >>> disable_radix&q

[PATCH v2] powerpc/mm/radix: use do/while(0) trick for single statement block

mpty body in an ‘if’ statement [-Werror=empty-body] Suggested-by: Randy Dunlap Signed-off-by: Mathieu Malaterre --- v2: update macro directly arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powe

[PATCH] powerpc/wii: Make hlwd_pic_init function static

The function hlwd_pic_init can be made static, so do it. Fix the following warning treated as error (W=1): ../arch/powerpc/platforms/embedded6xx/hlwd-pic.c:158:20: error: no previous prototype for ‘hlwd_pic_init’ [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre --- arch/powerpc

[PATCH] kbuild/debian: Use KBUILD_BUILD_* when set

Be nice to the user and check env vars KBUILD_BUILD_USER & KBUILD_BUILD_HOST when those are set. Signed-off-by: Mathieu Malaterre --- scripts/package/mkdebian | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian index 6adb3a16

Re: [PATCH] powerpc/signal32: Use fault_in_pages_readable() to prefault user context

On Tue, Apr 24, 2018 at 4:17 PM, Christophe Leroy wrote: > Use fault_in_pages_readable() to prefault user context > instead of open coding > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/signal_32.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --

Re: [PATCH] powerpc/signal32: Use fault_in_pages_readable() to prefault user context

On Tue, Apr 24, 2018 at 4:45 PM, Mathieu Malaterre wrote: > On Tue, Apr 24, 2018 at 4:17 PM, Christophe Leroy > wrote: >> Use fault_in_pages_readable() to prefault user context >> instead of open coding >> >> Signed-off-by: Christophe Leroy >> --- >

Re: [PATCH v2] kbuild/debian: Use KBUILD_BUILD_* when set

On Wed, May 2, 2018 at 10:01 PM, Mathieu Malaterre wrote: > Be nice to the user and check env vars KBUILD_BUILD_USER & > KBUILD_BUILD_HOST when those are set. > > Since DEBEMAIL accept a syntax where the full name is present, be extra > nice to user and extract email address

[PATCH v3] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation

rning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") Reported-by: David Daney Suggested-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-

Re: [PATCH v2] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation

On Thu, May 3, 2018 at 6:35 PM, Krzysztof Kozlowski wrote: > On Wed, May 02, 2018 at 10:11:52PM +0200, Mathieu Malaterre wrote: >> Improve the DTS files by removing all the leading "0x" and zeros to fix the >> following dtc warnings: >> >> Warning (unit_addres

Re: [PATCH 1/6] powerpc/syscalls: Switch trivial cases to SYSCALL_DEFINE

On Wed, May 2, 2018 at 3:20 PM, Michael Ellerman wrote: > From: Al Viro Maybe add: Link: https://github.com/linuxppc/linux/issues/131 For the series: compile, build without error (W=1), and works on my system. > Signed-off-by: Al Viro > --- > arch/powerpc/kernel/pci_32.c | 6 +

Re: [PATCH v3] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation

On Thu, May 3, 2018 at 8:53 PM, Krzysztof Kozlowski wrote: > On Thu, May 03, 2018 at 08:44:53PM +0200, Mathieu Malaterre wrote: >> Improve the DTS files by removing all the leading "0x" and zeros to fix the >> following dtc warnings: >> >> Warning (unit_addres

[PATCH] agp: uninorth: make two functions static

:6: warning: no previous prototype for ‘null_cache_flush’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- drivers/char/agp/uninorth-agp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c index

[PATCH] driver core: add __printf verification to device_create_groups_vargs

__printf is useful to verify format and arguments. Remove the following warning (with W=1): drivers/base/core.c:2435:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers/base/core.c | 2

[PATCH] driver core: add __printf verification to __ata_ehi_pushv_desc

__printf is useful to verify format and arguments. Remove the following warning (with W=1): drivers/ata/libata-eh.c:183:10: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers/ata/libata

[PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static, make it so. Remove the following gcc warning (W=1): fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- fs/ext4

[PATCH] slub: add __printf verification to ‘slab_err’:

__printf is useful to verify format and arguments. Remove the following warning (with W=1): mm/slub.c:721:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- mm/slub.c | 2 +- 1 file changed, 1

[PATCH] mm: move function ‘is_pageblock_removable_nolock’ inside blockers

-prototypes] Signed-off-by: Mathieu Malaterre --- mm/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 905db9d7962f..94ca579938e5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7701,6 +7701,7 @@ bool has_unmovable_pages(struct zone *zone

[PATCH] nvmem: properly handle returned value nvmem_reg_read

-variable] Signed-off-by: Mathieu Malaterre --- drivers/nvmem/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index b05aa8e81303..f34f2363925a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -1107,6 +1107,8 @@ static void

[PATCH] acpi: add missing prototype for ‘arch_post_acpi_subsys_init’

rning (W=1): init/main.c:484:20: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- include/linux/acpi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 15bfb15c2fa5..cb

Re: [PATCH] kernel/module: silence a gcc warning

Hi Jessica, On Mon, Apr 16, 2018 at 7:11 PM, Jessica Yu wrote: > +++ Mathieu Malaterre [11/04/18 21:05 +0200]: >> >> In commit 8c8ef42aee8f ("module: include other structures in module >> version >> check"), the function `struct_module` was renamed to `modu

[PATCH v2] powerpc/sparse: fix plain integer as NULL pointer warning

|| pp == NULL) CHECK: Comparison to NULL could be written "!pp" #306: FILE: drivers/macintosh/via-pmu.c:2167: + if (pp == NULL) CHECK: Comparison to NULL could be written "pp" #315: FILE: drivers/macintosh/via-pmu.c:2183: + if (pp != NULL) { Link: https://github.

[PATCH v2] nvmem: properly handle returned value nvmem_reg_read

-variable] Signed-off-by: Mathieu Malaterre --- v2: prefer ERR_PTR(-EINVAL) over a simple return NULL drivers/nvmem/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index b05aa8e81303..f7b6c85cf393 100644 --- a/drivers/nvmem/core.c +++ b

[PATCH v2] mm: move function ‘is_pageblock_removable_nolock’ to mm/memory_hotplug.c

‘is_pageblock_removable_nolock’ [-Wmissing-prototypes] Suggested-by: Michal Hocko Signed-off-by: Mathieu Malaterre --- v2: this function can be made static, make it so include/linux/memory_hotplug.h | 1 - mm/memory_hotplug.c| 23 +++ mm/page_alloc.c| 23

[PATCH v3] nvmem: properly handle returned value from nvmem_reg_read

-variable] Signed-off-by: Mathieu Malaterre --- v3: return exact error code instead of EINVAL, tweak commit message a bit v2: prefer ERR_PTR(-EINVAL) over a simple return NULL drivers/nvmem/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c

Re: [PATCH v2] nvmem: properly handle returned value nvmem_reg_read

On Thu, May 10, 2018 at 11:58 AM, Srinivas Kandagatla wrote: > > > On 09/05/18 19:57, Mathieu Malaterre wrote: >> >> Function nvmem_reg_read can return a non zero value indicating an error. >> This returned value must be read and error propagated to >> nvmem_cell_

Re: [PATCH] powerpc: Mark the variable earlycon_acpi_spcr_enable maybe_unused

On Thu, Mar 15, 2018 at 1:54 AM, Michael Ellerman wrote: > Mathieu Malaterre writes: >> Subject: Re: [PATCH] powerpc: Mark the variable earlycon_acpi_spcr_enable >> maybe_unused > > You're fixing an error on powerpc, but the patch is to the serial code, > so the su

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

On Tue, Apr 17, 2018 at 12:49 PM, Christophe Leroy wrote: > This option does dead code and data elimination with the linker by > compiling with -ffunction-sections -fdata-sections and linking with > --gc-sections. > > By selecting this option on mpc885_ads_defconfig, > vmlinux LOAD segment size ge

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

On Tue, Apr 17, 2018 at 6:49 PM, Christophe LEROY wrote: > > > Le 17/04/2018 à 18:45, Mathieu Malaterre a écrit : >> >> On Tue, Apr 17, 2018 at 12:49 PM, Christophe Leroy >> wrote: >>> >>> This option does dead code and data elimination with the lin

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

Christophe, On Wed, Apr 18, 2018 at 8:34 AM, Christophe LEROY wrote: > > > Le 17/04/2018 à 19:10, Mathieu Malaterre a écrit : >> >> On Tue, Apr 17, 2018 at 6:49 PM, Christophe LEROY >> wrote: >>> >>> >>> >>> Le 17/04/2018 à 18:45,

Re: [PATCH v2] of: fix memory leak related to safe_name()

I only tested v2. I confirm this solve the symptoms I was seeing in the bug report. Tested-by: Mathieu Malaterre thanks, your patch is actually much cleaner! On Wed, Jun 15, 2016 at 10:42 PM, Frank Rowand wrote: > From: Frank Rowand > > Fix a memory leak resulting from memory allo

Re: [PATCH v2] of: fix memory leak related to safe_name()

t 0xdf5586c0 (size 32): comm "swapper", pid 1, jiffies 4294892300 (age 2564.708s) hex dump (first 32 bytes): 6c 32 2d 63 61 63 68 65 23 31 00 ac c0 21 02 f4 l2-cache#1...!.. On Thu, Jun 16, 2016 at 9:15 AM, Mathieu Malaterre wrote: > I only tested v2. I confirm this solve th

Re: [PATCH v3] of: fix memory leak related to safe_name()

v3 tested here multiple times ! memleak is now gone. Tested-by: Mathieu Malaterre Thanks On Thu, Jun 16, 2016 at 7:51 PM, Frank Rowand wrote: > From: Frank Rowand > > Fix a memory leak resulting from memory allocation in safe_name(). > This patch fixes all call sites

Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

ev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2307,7 +2307,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev, > > ret = radeon_kick_out_firmware_fb(pdev); > if (ret) > - return ret; > + goto err_release_fb; G

RIP: 0010:g84_gr_tlb_flush+0x2eb/0x300 [nouveau]

Hi there, Could someone please comment on the following hard-lock (*). Staring at the code, I see `nvkm_rd32` calls are enclosed in a timeout detection, except one. drivers/gpu/drm/nouveau/nvkm/engine/gr/g84.c#L171 ... nvkm_msec(device, 2000, if (!(nvkm_rd32(device, 0x100c80) & 0x0001)) b

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

erspace Access Protection (KUAP) because it is within user > address space. > > This patch fixes those issues by properly setting disp_BAT through > a call to btext_prepare_BAT(), allowing setup_disp_bat() to > properly setup BAT3 for early bootx screen buffer access. > > Reported

[PATCH] powerpc/32: Add .data..LASAN* sections explicitly

powerpc-linux-gnu-ld: warning: orphan section `.data..LASANLOC1' from `net/core/filter.o' being placed in section `.data..LASANLOC1' This commit remove those warnings produced at W=1. Reported-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/vmlinux

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

On Tue, May 28, 2019 at 1:40 PM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > > Fix warnings treated as errors with W=1: > > > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > > [-Werror=unused-but-set-varia

[PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn

Remove this warning from W=2 completely. Signed-off-by: Mathieu Malaterre --- scripts/Makefile.extrawarn | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 3ab8d1a303cd..98081ab300e5 100644 --- a/scripts/Makefile.extrawarn +++ b/script

[PATCH] hfsplus: Replace strncpy with memcpy

truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] Signed-off-by: Mathieu Malaterre --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index d5403b4004c9..bb0b27d88

[PATCH] crypto: Fix build for clang

~ Cc: Joel Stanley Cc: Masahiro Yamada Signed-off-by: Mathieu Malaterre --- lib/mpi/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/mpi/Makefile b/lib/mpi/Makefile index d5874a7f5ff9..de4d96e988a3 100644 --- a/lib/mpi/Makefile +++ b/lib/mpi/Makefi

Re: [PATCH] crypto: Fix build for clang

Joel, On Fri, Jun 21, 2019 at 9:30 AM Joel Stanley wrote: > > On Fri, 21 Jun 2019 at 07:13, Mathieu Malaterre wrote: > > > > The header file `longlong.h` makes uses of GNU extensions, this trigger > > an error when compiling this code with clang. Add a special flag to

[PATCH] powerpc/lib/xor_vmx: Relax frame size for clang

clang") until a proper fix is implemented upstream in clang and relax requirement for clang. Link: https://github.com/ClangBuiltLinux/linux/issues/563 Cc: Joel Stanley Signed-off-by: Mathieu Malaterre --- arch/powerpc/lib/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/

[PATCH v2] lib/mpi: fix build with clang

Update macros from GCC"). Suggested-by: Joel Stanley Cc: Segher Boessenkool Signed-off-by: Mathieu Malaterre --- v2: Instead of passing compat flag to clang to behave as gcc, remove the superfluous cast lib/mpi/longlong.h | 105 +++-- 1 file changed

<    1   2   3   4   5   >