Re: [PATCH] staging: rtl8192e: rtl_wx: fix negative noise value

wstats->qual.level = 0; > - wstats->qual.noise = -100; > + wstats->qual.noise = 0x100 - 100; /* -100 dBm */ > wstats->qual.updated = IW_QUAL_ALL_UPDATED | IW_QUAL_DBM; > return wstats; > } > Tes

Re: [PATCH] etherdevice: Add ether_addr_copy_unaligned

On 20.04.2015 20:19, David Miller wrote: (...) > I'd rather see something like this submitted in a patch series alongside > some actual uses. > > So I'm tossing this for now. > Ok; I'll add it to a series where I need it (rtl8192e) Regards, Mateusz -- To unsubscribe from this list: send the lin

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Hi Joe, On 20.04.2015 03:13, Joe Perches wrote: > On Mon, 2015-04-20 at 00:16 +0200, Mateusz Kulikowski wrote: >> Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). > > Hi again Mateusz > >> diff --git a/scripts/checkpatch.pl b/scripts/checkpat

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

On 21.04.2015 23:22, Joe Perches wrote: > On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote: (...) >> >> Perhaps it would be smarter to use (for both patches) $stat instead. >> This applies also to existing checks (like PREFER_ETHER_ADDR_COPY) >> so we can

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

On 22.04.2015 00:27, Joe Perches wrote: > On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote: >> On 21.04.2015 23:22, Joe Perches wrote: >>> On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote: >> (...) (...) >> True, True; If you prefer $line and ab

Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()

On 14.04.2015 10:00, Dan Carpenter wrote: > BAReq->addr1 is part of struct rtllib_hdr_2addr. It's 4 bytes into > the struct so it's fine. You're right - should I explicitly add __aligned() in such places or just leave comment in that case (for future commiters)? > I sort of like the ether_addr_c

Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

On 14.04.2015 10:07, Dan Carpenter wrote: > On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote: >> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. >> Replace printk() with pr_* where possible. (...) >> #define RTLLIB_DEBUG_DATA(level, data, data

Re: [PATCH v2 15/21] staging: rtl8192e: Fix LONG_LINE warnings - modify variables

On 14.04.2015 10:40, Dan Carpenter wrote: > On Mon, Apr 13, 2015 at 11:47:38PM +0200, Mateusz Kulikowski wrote: >> +if (*rfa_pti_r > 4) { >> +(*rfa_pti_r)--; > > > Honestly, I thought that patch 14 was too hard to revie

[PATCH v2 09/13] staging: rtl8192e: Divide rtllib_rx_auth()

Move authentication response processing to rtllib_rx_auth_resp() function. No logic is affected. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 112 -- 1 file changed, 58 insertions(+), 54 deletions(-) diff --git a/drivers/staging

[PATCH v2 01/13] staging: rtl8192e: Fix UNNECESSARY_ELSE warning

Fix checkpatch warnings 'else is not generally useful after a break or return' Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 72 +++--- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 +- drivers/staging/rtl8192e/rtl8192e/rtl_cam.

[PATCH v2 00/13] staging: rtl8192e: checkpatch.pl cleanups

rtl8192e card vs staging-next: - Module load/unload - Interface up/down For now I'm not able to do more tests as I don't have proper antennas Mateusz Kulikowski (13): staging: rtl8192e: Fix UNNECESSARY_ELSE warning staging: rtl8192e: Fix RETURN_VOID warnings staging: rtl81

[PATCH v2 10/13] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()

Return from rtllib_rx_auth_resp() if auth_parse() fails. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 89 --- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers

[PATCH v2 13/13] staging: rtl8192e: Remove dead code

Remove commented-out code Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c| 3 +-- drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 7 --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 5 + drivers/staging/rtl8192e/rtllib_rx.c

[PATCH v2 02/13] staging: rtl8192e: Fix RETURN_VOID warnings

Fix 'void function return statements are not generally useful' checkpatch.pl warnings Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 8 drivers/staging/rtl8192e/rtl8192e/rtl_co

[PATCH v2 11/13] staging: rtl8192e: Fix indentation in rtllib_rx_auth_resp()

Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 9a4179c..c043d8c

[PATCH v2 03/13] staging: rtl8192e: remove unused EXPORT_SYMBOL_RSL macro

This macro caused checkpatch.pl warning and is not used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index dc9f675..5363b6f 100644 --- a

[PATCH v2 12/13] staging: rtl8192e: Comment cleanup (style/format)

- Multiline comments use "network subsystem comment style" - Merge short multiline comments - Remove empty comments - Remove function name comment at the end of small (<1 screen) functions - Reformat 802.11 data frame format to use spaces and network format Signed-off-by: Mateu

[PATCH v2 06/13] staging: rtl8192e: Fix BRACES warning

Fix 'braces {} are not necessary for single statement blocks' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192

[PATCH v2 08/13] staging: rtl8192e: Fix PRINTK_WITHOUT_KERN_LEVEL warnings

Replace custom hex dumping function with print_hex_dump_bytes() to make checkpatch.pl happy Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging

[PATCH v2 04/13] staging: rtl8192e: Fix UNNECESSARY_PARENTHESES warnings

Fix 'Unnecessary parentheses' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 3 files changed, 9

[PATCH v2 05/13] staging: rtl8192e: Fix LINE_CONTINUATIONS warning

Fix 'Avoid unnecessary line continuations' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/stagin

[PATCH v2 07/13] staging: rtl8192e: Fix DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON warning

Fix 'do {} while (0) macros should not be semicolon terminated' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_debug.h b/drive

[PATCH v3 3/4] checkpatch: Fix processing of MEMSET issues

Remove 's' modifier to avoid reporting the same warning several times. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 263e831..c05befe 100755 ---

[PATCH v3 0/4] new ethernet address manipulation checks

ADDR_EQUAL Replace memcmp(foo, bar, ETH_ALEN) with ether_addr_equal*() 2) PREFER_ETH_ZERO_ADDR Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr() 3) PREFER_ETH_BROADCAST_ADDR Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr() Mateusz Kulikowski (4): checkpatch: suggest using ether_

[PATCH v3 4/4] checkpatch: Add multi-line handling for PREFER_ETHER_ADDR_COPY

Handle multi-line memcpy() properly. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c05befe..6311950 100755 --- a/scripts/checkpatch.pl +++ b/scripts

[PATCH v3 2/4] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 23 +++ 1 file changed, 23 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0a511b7..263e831 100755 --- a

[PATCH v3 1/4] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

[PATCH 0/8] staging: rtl8192e: Fix more checkpatch.pl warnings

keep line length when variable names have 30 characters). Series should apply to staging-next/testing (c610f7f7). Smoke tested on rtl8192e card vs staging-next: - Module load/unload - Interface up/down Mateusz Kulikowski (8): staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings staging: rtl

[PATCH 4/8] staging: rtl8192e: Fix SPACING errors

Fix several SPACING errors to make checkpatch happy. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++--- drivers/staging/rtl8192e

[PATCH 8/8] staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtl_dm.c

Separate parts of dm_TXPowerTrackingCallback_TSSI() into two new functions: - dm_tx_update_tssi_weak_signal() - dm_tx_update_tssi_strong_signal() Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 176 +++-- 1 file changed, 93 insertions

[PATCH 5/8] staging: rtl8192e: Remove bb tx gains from r8192_priv

) variables. tx_bb_gain is also flattened - register values are stored in array; Amplification value can be calculated using dm_tx_bb_gain_idx_to_amplify(). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.h

[PATCH 3/8] staging: rtl8192e: remove r819xE_phyreg.h

This file is not used and its contents are duplicated in r8192E_phyreg.h. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 -- 1 file changed, 908 deletions(-) delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h

[PATCH 6/8] staging: rtl8192e: Fix LINE_SPACING warning

Trivial fix - add newline in dm_InitializeTXPowerTracking_TSSI() Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index

[PATCH 7/8] staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtllib_parse_info_param()

- Replace ?: with min_t - Remove condition that is always true Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e

[PATCH 2/8] staging: rtl8192e: Copy comments from r819XE_phyreg.h to r8192E_phyreg.h

Both files have the same contents (with the exception of comments). One of them will not survive future commits. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 92 --- 1 file changed, 65 insertions(+), 27 deletions(-) diff --git a

[PATCH 1/8] staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings

Reformat r8192E_phyreg.h to make checkpatch happy. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1442 ++--- 1 file changed, 721 insertions(+), 721 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers

[PATCH 0/2] checkpatch: new ethernet address manipulation checks

() Mateusz Kulikowski (2): checkpatch: suggest using ether_addr_equal*() checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() scripts/checkpatch.pl | 23 +++ 1 file changed, 23 insertions(+) -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubs

[PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used instead. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3a1a01e..1fc0819 100755 --- a

[PATCH 1/2] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

[PATCH] etherdevice: Add ether_addr_copy_unaligned

Some drivers require copying unaligned ethernet addresses. Using memcpy() causes checkpatch warnings and may cause regressions (someone will "fix" alignment of packed structure) Signed-off-by: Mateusz Kulikowski --- include/linux/etherdevice.h | 16 1 file c

Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Hi Joe, On 19.04.2015 22:20, Joe Perches wrote: (...) >> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr >> +if ($^V && $^V ge 5.10.0 && >> +$line =~ >> /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { > > Plea

[PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b9ea436..aee6d43 100755 --- a/scripts

[PATCH v2 1/2] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

[PATCH v2 0/2] checkpatch: new ethernet address manipulation checks

) with ether_addr_equal*() 2) PREFER_ETH_ZERO_ADDR Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr() 3) PREFER_ETH_BROADCAST_ADDR Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr() Mateusz Kulikowski (2): checkpatch: suggest using ether_addr_equal*() checkpatch: suggest using

[PATCH v2 00/21] staging: rtl8192e: Fix more checkpatch.pl warnings

ve 30 characters). Mateusz Kulikowski (21): staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings staging: rtl8192e: Copy comments from r819XE_phyreg.h to r8192E_phyreg.h staging: rtl8192e: remove r819xE_phyreg.h staging: rtl8192e: Fix SPACING errors staging: rtl8192e: Remove bb tx gains from r8192

[PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. Replace printk() with pr_* where possible. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 4 +- drivers/staging/rtl8192e/rtllib_crypt.c | 17 drivers/staging/rtl8192e

[PATCH v2 04/21] staging: rtl8192e: Fix SPACING errors

Fix several SPACING errors to make checkpatch happy. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++--- drivers/staging/rtl8192e

[PATCH v2 18/21] staging: rtl8192e: fix LONG_LINE warnings - replace ?: expressions

Replace temporary conditional (?:) with ordinary condition or max_t. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 30 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 2 files changed, 22 insertions(+), 10 deletions(-) diff

[PATCH v2 01/21] staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings

Reformat r8192E_phyreg.h to make checkpatch happy. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1442 ++--- 1 file changed, 721 insertions(+), 721 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers

[PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()

). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_BAProc.c| 12 ++--- drivers/staging/rtl8192e/rtllib.h| 3 ++ drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++ drivers/staging/rtl8192e/rtllib_rx.c | 74 +--- drivers

[PATCH v2 17/21] staging: rtl8192e: Fix LONG_LINE warnings (conditions)

Rework some conditions to bail out of functions faster therby decreasing overall indent. This patch should not cause any negative side effect (except for different execution time). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 +- drivers/staging

[PATCH v2 19/21] staging: rtl8192e: Fix LONG_LINE in rtllib_parse_mife_generic()

Simplify function to make checkpatch.pl happy. Changes: - Helper variables used - Local variable names compacted - Conditions were rephrased to return quickly (and decrease indent). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 170

[PATCH v2 16/21] staging: rtl8192e: Fix LONG_LING in rtllib_parse_info_param()

Take out MIFE_TYPE_HT_CAP processing into separate function - rtllib_parse_mfie_ht_cap() Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 50 +--- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8192e

[PATCH v2 20/21] staging: rtl8192e: Fix LONG_LINE in simplify rtl8192_process_phyinfo()

Simplify function to make checkpatch.pl happy. Changes: - Helper variables used - Conditions were rephrased to return quickly (and decrease indent). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 111 - 1 file changed, 53

[PATCH v2 15/21] staging: rtl8192e: Fix LONG_LINE warnings - modify variables

Further reduction of checkpatch.pl LONG_LINE warnings: - Local variables are compacted where it's needed - Helper (local) variables are used (to avoid expressions like a.b.c.d.e) Both changes should be optimized out by compilers.dd Signed-off-by: Mateusz Kulikowski --- .../staging/rtl

[PATCH v2 02/21] staging: rtl8192e: Copy comments from r819XE_phyreg.h to r8192E_phyreg.h

Both files have the same contents (with the exception of comments). One of them will not survive future commits. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 92 --- 1 file changed, 65 insertions(+), 27 deletions(-) diff --git a

[PATCH v2 07/21] staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtllib_parse_info_param()

- Replace ?: with min_t - Remove condition that is always true Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e

[PATCH v2 05/21] staging: rtl8192e: Remove bb tx gains from r8192_priv

) variables. tx_bb_gain is also flattened - register values are stored in array; Amplification value can be calculated using dm_tx_bb_gain_idx_to_amplify(). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.h

[PATCH v2 08/21] staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtl_dm.c

Separate parts of dm_TXPowerTrackingCallback_TSSI() into two new functions: - dm_tx_update_tssi_weak_signal() - dm_tx_update_tssi_strong_signal() Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 180 +++-- 1 file changed, 95 insertions

[PATCH v2 09/21] staging: rtl8192e: Fix DeviceID in rtl8192_pci_findadapter()

rtl8192_pci_findadapter() was looking for invalid DeviceID (0x8172), instead of proper for rtl8192e/se devices (0x8192) Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e

[PATCH v2 11/21] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()

Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function. Code was not altered significantly, therefore in some places it generates LONG_LINE checkpatch.pl warnings. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 365

[PATCH v2 12/21] staging: rtl8192e: replace memcmp() with ether_addr_equal_unaligned()

Use dedicated macro to compare ethernet addresses in probe_rq_parse(). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e

[PATCH v2 03/21] staging: rtl8192e: remove r819xE_phyreg.h

This file is not used and its contents are duplicated in r8192E_phyreg.h. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 -- 1 file changed, 908 deletions(-) delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h

[PATCH v2 14/21] staging: rtl8192e: Fix LONG_LINE warnings

cal and - a = b = c = d expressions are split - Replace if/then series with clamp_t() - Removed unneeded scopes Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/dot11d.h | 4 +- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 22 +- .../staging/rtl81

[PATCH v2 06/21] staging: rtl8192e: Fix LINE_SPACING warning

Trivial fix - add newline in dm_InitializeTXPowerTracking_TSSI() Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index

[PATCH v2 21/21] staging: rtl8192e: Remove unimplemented iwpriv handlers

Remove the following private variables: - force_mic_error - changes force_mic_error that is not used - radio - changes sw_radio_on that is not used - adhoc_peer_list - unimplemented - firm_ver - unimplemented Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c

Re: [PATCH v2 00/21] staging: rtl8192e: Fix more checkpatch.pl warnings

On 14.04.2015 00:12, Dan Carpenter wrote: > I don't know why you are doing a v2. I went back to the original thread > and I see that no one complained about it. > > Since no one replied to v1 thread, then probably Greg is going to apply > that one first because it is first in his inbox. Greg's i

Re: [PATCH 0/8] staging: rtl8192e: Fix more checkpatch.pl warnings

On 08.04.2015 01:08, Mateusz Kulikowski wrote: > This series of patches fixes another set of checkpatch.pl warnings. > Please ignore this patchset and use v2 once it is reviewed. Best Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2 00/21] staging: rtl8192e: Fix more checkpatch.pl warnings

On 14.04.2015 00:33, Dan Carpenter wrote: > On Tue, Apr 14, 2015 at 12:15:57AM +0200, Mateusz Kulikowski wrote: >> I made checkpatch regressions in v1 (that I missed at a time) > > As near as I can tell the only difference is that you left some curly > braces in on patch

[PATCH 05/16] staging: rtl8192e: Remove rtllib_stop_queue()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 12 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging

[PATCH 01/16] staging: rtl8192e: Remove unused code in rtl819x_HT.h

Delete unused enums, structures and macros. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HT.h | 128 -- 1 file changed, 128 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index

[PATCH 02/16] staging: rtl8192e: Remove unused code in rtllib.h

Delete macros, structure members and declarations etc. that are not referenced anywhere in code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 448 -- 1 file changed, 448 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h

[PATCH 00/16] staging: rtl8192e: Remove unused code

Another cleanup series. Most patches are pretty simple (fragmented a bit to make review easier). Series should apply cleanly into staging-next (5c1043984) and staging-testing (f996bd10). Target tested (802.11N/2.4G/WPA2 network, DHCP, 1MB download, ping). Mateusz Kulikowski (16): staging

[PATCH 07/16] staging: rtl8192e: Remove dequeue_mgmt() and rtllib_resume_tx()

Both functions are never used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index cb78782

[PATCH 04/16] staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference

ENABLE_LOCK_DEBUG macro was never set, so condition that used it can be resolved manually. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index

[PATCH 16/16] staging: rtl8192e: Remove rtllib_device::agregation

Variable is always true; Resolve condition where it is used (and change indentation of conditional expression). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_rx.c | 52 ++- drivers/staging

[PATCH 03/16] staging: rtl8192e: Remove rt_hi_throughput::ChnkOp

Field was initialized and never used. This patch also removes chnl_op enum that was only referenced by ChnkOp init code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HT.h | 8 drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 - 2 files changed, 9 deletions

[PATCH 06/16] staging: rtl8192e: Remove rtllib_wake_queue()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 41 --- 2 files changed, 42 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h

[PATCH 10/16] staging: rtl8192e: Remove rtllib_device::get_nic_desc_num()

This function/callback was initialized and never called. rtl8192_get_nic_desc_num() function that was default implementation was also removed. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 17 - drivers/staging/rtl8192e/rtllib.h

[PATCH 12/16] staging: rtl8192e: Remove rtllib_network::last_associate

Variable was initialized and never used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 1 - drivers/staging/rtl8192e/rtllib_rx.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index

[PATCH 13/16] staging: rtl8192e: Remove rt_pwr_save_ctrl members

Following members were removed: - tmpJoinAction - tmpSuppRateBuf - bTmpIbpm As a consequence several unused defines/enums/structs were also removed from rtllib.h Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 36 1 file changed

[PATCH 15/16] staging: rtl8192e: Remove softmac_hint11d_wq queue

This queue is never used, and function handler is empty Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 6 -- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging

[PATCH 14/16] staging: rtl8192e: Remove unused rtllib_device members

Delete several members of rtllib_device including their initializers if needed. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 -- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 - drivers/staging/rtl8192e/rtllib.h| 12

[PATCH 09/16] staging: rtl8192e: Remove rtllib_wx_get_encode_ext()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 3 -- drivers/staging/rtl8192e/rtllib_wx.c | 57 2 files changed, 60 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b

[PATCH 08/16] staging: rtl8192e: Remove rtllib_is_shortslot()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 5 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e

[PATCH 11/16] staging: rtl8192e: Remove WIRELESS_EXT checks

Current WIRELESS_EXT version is at least 22. Resolve ifdefs and delete dead code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index

Re: [PATCH 06/16] staging: rtl8192e: Remove rtllib_wake_queue()

On June 15, 2015 8:38:01 AM GMT+02:00, Sudip Mukherjee wrote: >On Mon, Jun 15, 2015 at 12:58:50AM +0200, Mateusz Kulikowski wrote: >> This function was declared but never unused. >After this patch we are getting two build warnings: > >warning: ‘dequeue_mgmt’ defined but

Re: [PATCH 06/16] staging: rtl8192e: Remove rtllib_wake_queue()

On 15 June 2015 at 08:52, Sudip Mukherjee wrote: > On Mon, Jun 15, 2015 at 08:41:17AM +0200, Mateusz Kulikowski wrote: >> >> >> On June 15, 2015 8:38:01 AM GMT+02:00, Sudip Mukherjee >> wrote: >> >On Mon, Jun 15, 2015 at 12:58:50AM +0200, Mateusz Kulik

[PATCH v2 00/15] staging: rtl8192e: Remove unused code

/2.4G/WPA2 network, DHCP, 1MB download, ping). Mateusz Kulikowski (15): staging: rtl8192e: Remove unused code in rtl819x_HT.h staging: rtl8192e: Remove unused code in rtllib.h staging: rtl8192e: Remove rt_hi_throughput::ChnkOp staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference staging

[PATCH v2 03/15] staging: rtl8192e: Remove rt_hi_throughput::ChnkOp

Field was initialized and never used. This patch also removes chnl_op enum that was only referenced by ChnkOp init code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HT.h | 8 drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 - 2 files changed, 9 deletions

[PATCH v2 01/15] staging: rtl8192e: Remove unused code in rtl819x_HT.h

Delete unused enums, structures and macros. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HT.h | 128 -- 1 file changed, 128 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index

[PATCH v2 08/15] staging: rtl8192e: Remove rtllib_wx_get_encode_ext()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 3 -- drivers/staging/rtl8192e/rtllib_wx.c | 57 2 files changed, 60 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b

[PATCH v2 07/15] staging: rtl8192e: Remove rtllib_is_shortslot()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 5 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e

[PATCH v2 05/15] staging: rtl8192e: Remove rtllib_stop_queue()

This function was declared but never unused. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 12 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging

[PATCH v2 09/15] staging: rtl8192e: Remove rtllib_device::get_nic_desc_num()

This function/callback was initialized and never called. rtl8192_get_nic_desc_num() function that was default implementation was also removed. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 17 - drivers/staging/rtl8192e/rtllib.h

[PATCH v2 06/15] staging: rtl8192e: Remove rtllib_wake_queue()

This function was declared but never unused. Also remove dequeue_mgmt() and rtllib_resume_tx() that are no longer used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - drivers/staging/rtl8192e/rtllib_softmac.c | 80 --- 2 files

[PATCH v2 10/15] staging: rtl8192e: Remove WIRELESS_EXT checks

Current WIRELESS_EXT version is at least 22. Resolve ifdefs and delete dead code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index

[PATCH v2 02/15] staging: rtl8192e: Remove unused code in rtllib.h

Delete macros, structure members and declarations etc. that are not referenced anywhere in code. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 448 -- 1 file changed, 448 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h

[PATCH v2 04/15] staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference

ENABLE_LOCK_DEBUG macro was never set, so condition that used it can be resolved manually. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index

[PATCH v2 12/15] staging: rtl8192e: Remove rt_pwr_save_ctrl members

Following members were removed: - tmpJoinAction - tmpSuppRateBuf - bTmpIbpm As a consequence several unused defines/enums/structs were also removed from rtllib.h Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 36 1 file changed

  1   2   3   4   5   >