Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013/4/25 Arnd Bergmann > > ARM cannot handle udelay for more than 2 miliseconds, so we > should use mdelay instead for those. > Singed-off-by: GOTO Masanori > Signed-off-by: Arnd Bergmann > Cc: GOTO Masanori > Cc: YOKOTA Hiroshi > Cc: "James E.J. Bottomley" > Cc: linux-s...@vger.kernel.org

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

Oops, you're absolutely correct. Thanks for the follow up! Please change it as follow as you mentioned: Acked-by: GOTO Masanori Best regrads, -- gotom 2013/4/29 Arnd Bergmann : > On Friday 26 April 2013, Masanori Goto wrote: >> 2013/4/25 Arnd Bergmann >> > >> &

Re: [PATCH] [347/2many] MAINTAINERS - NINJA SCSI-32Bi/UDE PCI/CARDBUS SCSI HOST ADAPTER DRIVER

2007/8/13, [EMAIL PROTECTED] <[EMAIL PROTECTED]>: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6f7fc81..378ad04 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3339,6 +3339,8 @@ P:YOKOTA Hir

Re: [PATCH] scsi: nsp32: fix logic bug in error handling

2017-09-05 16:51 GMT+09:00 Arnd Bergmann : > gcc-8 points out a logic error that has existed since the start > of the git history: > > drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': > drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to > false [-Werror=tautolo

Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

Thanks for the fix! 2019年1月27日(日) 4:11 Nathan Chancellor : > > On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of > > variable of type 'unsigned char' to itself [-Wself-assign] > >

Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.

nding it twice due to an error) Acked-by: Masanori Goto > --- > drivers/scsi/nsp32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 53c8477..1430b3c 100644 > --- a/drivers/scsi/nsp32.c > +