fix Touchpad cursor does not work after touching Touchpad
by 3 or more fingers.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 048befd..610df92 100644
"break" code, and move xyz input code to the correct place.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 048befd..610df92 100644
--- a/drivers
Hi, Nir,
Wow, thank you for fixing the bug.
Your code is correct!
Best Regards,
Masaki Ota
-Original Message-
From: Nir Perry [mailto:nirpe...@gmail.com]
Sent: Saturday, January 06, 2018 8:55 PM
To: 太田 真喜 Masaki Ota ; Dmitry Torokhov
; Pali Rohár
Cc: linux-kernel@vger.kernel.org
by both of EA F0 F0 E9
and F0 F0 E9.)
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Monday, March 26, 2018 6:26 AM
To: 太田 真喜 Masaki Ota
Cc: Dmitry Torokhov ; linux-in...@vger.kernel.org;
linux-kernel@vger.kernel.org; Aaron Ma
Subject
Hi, Dennis
I know your issue, and I added the solution for Thinkpad L/E system last year.
BTW, Pali also knows about it.
On Wednesday 29 November 2017 17:33:58 Masaki Ota wrote:
From: Masaki Ota mailto:dennis.wassenb...@secunet.com]
Sent: Tuesday, March 27, 2018 10:56 PM
To: Pali Rohár
Cc
Hi, Kai-Heng,
Sorry, I'm not in charge of Linux task now.
Hi, XiaoJian,
Please check the following mail.
If you have any question, please ask Kai-Heng.
Best Regards,
Masaki Ota
-Original Message-
From: Kai-Heng Feng
Sent: Wednesday, August 28, 2019 3:22 PM
To: 太田 真喜 Masaki Ot
Hi, Pali,
v3/v6 devices are T3 type, and it can use only Method 2.
P36 (At this time GLIDEPOINT_T3 uses the Method 2 )
T3 has the potential that uses Method2, but I think it needs to change Firmware.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro
tually, the cause is all the same.
E7=73 03 28 device does not get correct information from OTP.
OTP is the device information byte. I specified correct bit.
Then, I think it is also the issue.
#4. Stick Pointer cursor speed is fast.
I will check Stick parameter.
Best Regards,
Masaki Ota
-
Hi, Dmitry,
OK, I will do it.
Best Regards,
Masaki Ota
-Original Message-
From: dmitry.torok...@gmail.com [mailto:dmitry.torok...@gmail.com]
Sent: Wednesday, March 08, 2017 2:58 AM
To: 太田 真喜 Masaki Ota
Cc: Paul Donohue ; Nick Fletcher
; Joseph Salisbury ;
b...@smart-cactus.org; mho
From: Masaki Ota
-Fix the issue that V8(E7=73 03 28) devices are not assined correct device
information from OTP.
-Specified correct OTP bit for the V8 device setting of Button pad, DualPoint
and Touchpad size.
Signed-off-by: Masaki Ota
---
drivers/input/mouse/alps.c | 74
From: Masaki Ota
- V8 Button pad Stick Right and Middle button don't work.
- Alps stick devices have physical buttons absolutely, so delete
"ALPS_BUTTONPAD" check Flag from Stick button process.
Signed-off-by: Masaki Ota
---
drivers/input/mouse/alps.c | 6 ++
1 file change
From: Masaki Ota
-Fix the issue that V8(E7=73 03 28) devices are not assined correct device
information bit from OTP.
-Specified correct OTP bit for the V8 device setting of Button pad, DualPoint
and Touchpad size.
-Deleted extra code from alps_v8_protocol_data decision process.
Signed-off-by
From: Masaki Ota
-Fix the issue that V8(E7=73 03 28) devices are not assined correct device
information bit from OTP.
-Specified correct OTP bit for the V8 device setting of Button pad, DualPoint
and Touchpad size.
-Deleted extra code from alps_v8_protocol_data decision process.
Signed-off-by
From: Masaki Ota
- V8 Button pad Stick Right and Middle button don't work.
- Alps stick devices have physical buttons absolutely, so delete
"ALPS_BUTTONPAD" check Flag from Stick button process.
Signed-off-by: Masaki Ota
Acked-by: Pali Rohar
---
drivers/input/mouse/alps.c | 6
is_btnless = (otp[1][1] >> 3) & 0x01;
E7=73 03 28 device has to use below bit.
is_btnless = (otp[1][0] >> 1) & 0x01;
I will check other parts of source code.
Best Regards,
Masaki Ota
-Original Message-
From: Paul Donohue [mailto:linux-ker...@paulsd.com]
Sent: Monday,
& 0xf0) == 0xc0)) {
protocol = &alps_v7_protocol_data;}
}
E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data
E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data
Best Regards,
Masaki Ota
-Original Message-
F
-Add new Alps U1 Touchpad device ID
-Laptop names that use this Touchpad:HP Elitebook x360 1030 G2
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 3 +++
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-alps.c b
>From Masaki Ota
-Support Alps HID I2C T4 Touchpad device.
-Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1,
Elitebook 1030 G1, Elitebook 1040 G3
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 500 +++--
drivers/
Hi, Jiri,
This is the patch for new Alps HID I2C Touchpad device.
These devices are used for HP Laptop.
Best Regards,
Masaki Ota
From: Masaki Ota
-Add new Alps U1 Touchpad device ID
-Laptop names that use this Touchpad:HP Elitebook x360 1030 G2
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 3 +++
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers
From: Masaki Ota
-Support Alps HID I2C T4 Touchpad device.
-Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1,
Elitebook 1030 G1, Elitebook 1040 G3.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 345 ++---
drivers/hid
Hi, Benjamin,
I modified the patch and added the code that supports Alps USB Touchpad as
PATCH 4/4.
Best Regards,
Masaki Ota
>From Masaki Ota
- Separate U1 device initialization from common initialization.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 188 ++---
1 file changed, 99 insertions(+), 89 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/
From: Masaki Ota
-Support Alps T4 USB Touchpad device
-Laptop names that use this Touchpad:Elite x2 1012 G1 Tablet, HP Pro x2 612 G2
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 37 ++---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3
error.
What does dmesg show?
Best Regards,
Masaki Ota
-Original Message-
From: Nikolaus Rath [mailto:nikol...@rath.org]
Sent: Tuesday, April 04, 2017 12:09 PM
To: 太田 真喜 Masaki Ota ; linux-kernel
; linux-in...@vger.kernel.org
Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support
H
interface should work properly on Linux.
I tested it on Ubuntu +4.10 kernel.
If you don't apply my patch, does device work as I2C? (044E:120C appears?)
Best Regards,
Masaki Ota
-Original Message-
From: Nikolaus Rath [mailto:nikol...@rath.org]
Sent: Wednesday, April 05, 2017 2:09 AM
To:
Hi, Nikolaus,
Um, but demesg log does not have any error of this Touchpad.
It's a strange.
Best Regards,
Masaki Ota
-Original Message-
From: Nikolaus Rath [mailto:nikol...@rath.org]
Sent: Wednesday, April 05, 2017 8:43 AM
To: 太田 真喜 Masaki Ota
Cc: linux-kernel ; lin
./linux_kr_rebuild_tool_hid.sh /init linux-4.10.tar.gz
#sudo ./linux_kr_rebuild_tool_hid.sh /build DebugSrc
After that Touchpad all features should work.
If Touchpad does not work, something error appears on dmesg.
Best Regards,
Masaki Ota
-Original Message-
From: Nikolaus Rath [mailto:nikol...@rath.org
data->dev_type = U1;
break;
default:
data->dev_type = UNKNOWN;
}
Best Regards,
Masaki Ota
-Original Message-
From: Nikolaus Rath [mailto:nikol...@rath.org]
Sent: Thursday, April 06, 2017 3:36 AM
To: 太田 真喜 Masaki Ota
Cc: linux-kernel ; l
i) * 3] >> 3) & 0x0010) \
)
+#define SS4_PLUS_BTL_MF_X_V2(_b, _i) (SS4_PLUS_STD_MF_X_V2(_b, _i) | \
+((_b[0 + (_i) * 3] >> 4) & 0x0008) \
+ )
+
#define SS4_BTL_MF_Y_V2(_b, _i)(SS4_STD_MF_Y_
.
Original code meaning is Kernel 4.10.6, it seems not to have this issue.
Best Regards,
Masaki Ota
-Original Message-
From: Takashi Iwai [mailto:ti...@suse.de]
Sent: Thursday, July 20, 2017 6:35 PM
To: 太田 真喜 Masaki Ota
Cc: Paul Donohue ; Laura Abbott ;
Dmitry Torokhov ; Pali Rohar ;
Nick
From: Masaki Ota
Fixed the issue that two finger scroll does not work correctly
on V8 protocol. The cause is that V8 protocol X-coordinate decode
is wrong at SS4 PLUS device. I added SS4 PLUS X decode definition.
Signed-off-by: Masaki Ota
Tested-by: Takashi Iwai
---
drivers/input/mouse
setting is wrong. Sorry for our
mistake.
Is your laptop L570 ?
I will add code that supports the trackstick for this device.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Wednesday, November 15, 2017 5:35 PM
To: 太田 真喜 Masaki Ota
Cc
Hi, Pali,
OK, I got it.
So, the problem of structure will be solved next chance.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Monday, December 04, 2017 6:51 PM
To: 太田 真喜 Masaki Ota
Cc: Masaki Ota <012ne...@gmail.com>; dmitry
Hi, Jiri, Benjamin,
This is the patch for support new Alps HID Touchpad device.
I submitted these patch before, but it was not completed.
So I separate the patch to some parts and release it again.
Best Regards,
Masaki Ota
From: Masaki Ota
-Add T4 device code and Product ID
-This device is used on HP EliteBook 1000 series and Zbook Stduio
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 343 ++---
drivers/hid/hid-core.c | 3 +-
drivers/hid/hid-ids.h | 1 +
3
From: Masaki Ota
-Add new U1 device Product ID
-This device is used on HP Elite book x360 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 3 +++
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-alps.c b
From: Masaki Ota
-To support Alps T4 device, add x_min, y_min, max_fingers variables
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 38 --
1 file changed, 24 insertions(+), 14 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
From: Masaki Ota
-To support Alps T4 device, replace some variables
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 67 --
1 file changed, 27 insertions(+), 40 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
From: Masaki Ota
-Add T4 USB device code and Product ID
-This device is used on HP Elite x2 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 35 +--
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 27 insertions(+), 10
From: Masaki Ota
-To support Alps T4 device, clean up the source code
-Delete unnecessary structure
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 69 +-
1 file changed, 34 insertions(+), 35 deletions(-)
diff --git a/drivers/hid/hid
From: Masaki Ota
-To support Alps T4 device, separate U1 device code
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 120 +++--
1 file changed, 67 insertions(+), 53 deletions(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
Best Regards,
Masaki Ota
-Original Message-
From: Laura Abbott [mailto:labb...@redhat.com]
Sent: Wednesday, June 07, 2017 1:59 AM
To: Paul Donohue
Cc: 太田 真喜 Masaki Ota ; Dmitry Torokhov
; Pali Rohar ; Nick Fletcher
; linux-in...@vger.kernel.org;
linux-kernel@vger.kernel.org; scot
>From Masaki Ota
Support PTP Stick and Touchpad device.
This Touchpad is Precision Touchpad(PTP),
and Stick Pointer data is the same as Mouse.
So Stick Pointer works as Mouse.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-ids.h| 2 ++
drivers/hid/hid-multitouch.c |
From: Masaki Ota
-Define T4 device specification value for support T4 device.
-Create "t4_contact_data" and "t4_input_report" structure for decode T4 data
and store it.
-Create "t4_calc_check_sum()" function for calculate checksum value to send the
device. T4 need
From: Masaki Ota
-Add T4 USB device Product ID. (0x1216)
-Separate T4 USB device initialization code from T4 Standard device code.
-T4 USB device is used on HP Elite x2 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 35 +--
drivers/hid/hid-core.c
From: Masaki Ota
-Create x_min, y_min and max_fingers variables for set correct XY minimum value
and the number of max finger on each devices.
-Move the Button pad checking code to U1 init function, because this checking
code is for U1 device.
Signed-off-by: Masaki Ota
---
drivers/hid/hid
I have modified the Patch.
About __maybe_unused annotation, it was specified by Benjamin in previous
review.
So I added this annotation.
Best Regards,
Masaki OTa
From: Masaki Ota
-Move some variables(dev_ctrl, dev_type, sen_line_num_x, sen_line_num_y,
pitch_x, pitch_y, resolution, btn_info) from u1_dev structure to "u1_init()",
because these variables are only used in "u1_init()" function.
Signed-off-by: Masaki Ota
---
drivers
From: Masaki Ota
-Create "static int u1_init()" function for separate U1 device initialization
code from Main initialization.
-Create "has_sp" variable for checking whether it has SP device or not.
Signed-off-by: Masaki Ota
---
drivers/
From: Masaki Ota
-Add new U1 device Product ID
-This device is used on HP Elite book x360 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 3 +++
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-alps.c b
From: Masaki Ota
-Delete "struct u1_dev devInfo" structure, because u1_dev structure is already
declared as "struct u1_dev *data", and this structure is used for getting U1
data in [PATCH 2/7].
Signed-off-by: Masaki Ota
---
drivers
From: Masaki Ota
-Add T4 USB device Product ID. (0x1216)
-Separate T4 USB device initialization code from T4 Standard device code.
-T4 USB device is used on HP Elite x2 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 35 +--
drivers/hid/hid-core.c
From: Masaki Ota
-Create x_min, y_min and max_fingers variables for set correct XY minimum value
and the number of max finger on each devices.
-Move the Button pad checking code to U1 init function, because this checking
code is for U1 device.
Signed-off-by: Masaki Ota
---
drivers/hid/hid
From: Masaki Ota
-Define T4 device specification value for support T4 device.
-Create "t4_contact_data" and "t4_input_report" structure for decode T4 data
and store it.
-Create "t4_calc_check_sum()" function for calculate checksum value to send the
device. T4 need
From: Masaki Ota
-Add new U1 device Product ID
-This device is used on HP Elite book x360 series
Signed-off-by: Masaki Ota
---
drivers/hid/hid-alps.c | 3 +++
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-alps.c b
From: Masaki Ota
-Move some variables(dev_ctrl, dev_type, sen_line_num_x, sen_line_num_y,
pitch_x, pitch_y, resolution, btn_info) from u1_dev structure to "u1_init()",
because these variables are only used in "u1_init()" function.
Signed-off-by: Masaki Ota
---
drivers
From: Masaki Ota
-Create "static int u1_init()" function for separate U1 device initialization
code from Main initialization.
-Create "has_sp" variable for checking whether it has SP device or not.
Signed-off-by: Masaki Ota
---
drivers/
Hi, Jiri,
Sorry, I have fixed the build warning error, and send the patch again.
Best Regards,
Masaki Ota
From: Masaki Ota
-Delete "struct u1_dev devInfo" structure, because u1_dev structure is already
declared as "struct u1_dev *data", and this structure is used for getting U1
data in [PATCH 2/7].
Signed-off-by: Masaki Ota
---
drivers
s no effect, even if I set an abnormal value.(need
this code?)
I don't understand why these values have to do with this issue.
Can you guess the root cause of this issue?
Best Regards,
Masaki Ota
-Original Message-
From: Laura Abbott [mailto:labb...@redhat.com]
Sent: Thursday, June
From: Masaki Ota
- Support PTP Stick and Touchpad device.
- This Touchpad is Precision Touchpad(PTP),
and Stick Pointer data is the same as Mouse.
- Stick Pointer works as Mouse.
Signed-off-by: Masaki Ota
---
drivers/hid/hid-ids.h| 2 ++
drivers/hid/hid-multitouch.c | 23
Hi, Domitry,
I think we can add the code to HID for this device, but we will not use SMBus
interface for Touchpad in the future.
We should not do it.
Best Regards,
Masaki Ota
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Sunday, November 26, 2017 9
Hi, Pali,
I don't get your point.
Please modify the code if you have an idea.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Saturday, December 02, 2017 6:08 AM
To: Masaki Ota <012ne...@gmail.com>
Cc: dmitry.torok..
Hi, Pali,
It does not work in my test result.
BTW, other some functions also use both of "struct psmouse" and "struct
alps_data" argument.
I just followed it.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Monday,
From: Masaki Ota
- The issue is that Thinkpad L570 TrackStick does not work. Because the main
interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface
Firmware setting of TrackStick. The detail is that TrackStick otp bit is
disabled.
- Add the code that checks 0xD7 address
Hi, Pali,
1) Yes, but we don't have FW update plan.
And this device works as SMBus in Windows, so this issue happens on only Linux.
2) Yes.
Best Regards,
Masaki Ota
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Monday, November 20, 2017 5:30 PM
To: Masak
From: Masaki Ota
- The issue is that Thinkpad L570 TrackStick does not work. Because the main
interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface
Firmware setting of TrackStick. The detail is that TrackStick otp bit is
disabled.
- Add the code that checks 0xD7 address
From: Masaki Ota
- The issue is that Thinkpad L570 TrackStick does not work. Because the main
interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface
Firmware setting of TrackStick. The detail is that TrackStick otp bit is
disabled.
- Add the code that checks 0xD7 address
69 matches
Mail list logo
