Re: [PATCH] clk: probe common clock drivers earlier

2016-07-20 19:58 GMT+09:00 Geert Uytterhoeven : > On Sat, Jul 16, 2016 at 6:57 AM, Masahiro Yamada > wrote: >> 2016-07-16 11:11 GMT+09:00 Michael Turquette : >>> Quoting Masahiro Yamada (2016-05-05 00:57:17) >>>> Several SoCs implement platform drivers for clock

Re: [PATCH] kconfig: tinyconfig: provide whole choice blocks to avoid warnings

I prefer the same order as they appear in the .config file. Like this. +# CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE is not set CONFIG_CC_OPTIMIZE_FOR_SIZE=y +# CONFIG_KERNEL_GZIP is not set +# CONFIG_KERNEL_BZIP2 is not set +# CONFIG_KERNEL_LZMA is not set CONFIG_KERNEL_XZ=y +# CONFIG_KERNEL_LZO is not set +# CONFIG_KERNEL_LZ4 is not set CONFIG_OPTIMIZE_INLINING=y +# CONFIG_SLAB is not set +# CONFIG_SLUB is not set CONFIG_SLOB=y -- Best Regards Masahiro Yamada

[PATCH] reset: generate reset_control_get variants with macro expansion

blocks is error-prone. Signed-off-by: Masahiro Yamada --- drivers/reset/core.c | 36 ++ include/linux/reset.h | 306 +- 2 files changed, 86 insertions(+), 256 deletions(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index

[PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined

This has been inconsistent; some returns -EINVAL, some -ENOTSUPP. Make it consistent in this header, in favor of -ENOTSUPP. Signed-off-by: Masahiro Yamada --- include/linux/reset.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/reset.h b/include/linux

Re: [PATCH] reset: generate reset_control_get variants with macro expansion

Hi Philipp, 2016-07-21 17:41 GMT+09:00 Philipp Zabel : > Hi Masahiro, > > Am Donnerstag, den 21.07.2016, 14:05 +0900 schrieb Masahiro Yamada: >> The recent update in the reset subsystem requires all reset consumers >> to be explicit about the requested reset lines; _explici

[PATCH] usb: remove redundant dependency on USB_SUPPORT

The whole Kconfig entries of the USB subsystem are surrounded with "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met when these two Kconfig options are visible. Signed-off-by: Masahiro Yamada --- drivers/usb/core/Kconfig | 1 - drivers/usb/dwc3/Kconfig | 2

Why do we need reset_control_get_optional() ?

ll take some releases to complete this task, but I am happy to volunteer to it if we agree on this idea. -- Best Regards Masahiro Yamada

[PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER

The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig. Signed-off-by: Masahiro Yamada --- Philipp, IIRC, you mentioned that you were planning to consolidate the double gurad by CONFIG_RESET_CONTROLLER and

[PATCH] ARM: cache-uniphier: rename jump label to follow coding style guideline

Documentation/CodingStyle recommends to use label names which say what the goto does or why the goto exists. Signed-off-by: Masahiro Yamada --- arch/arm/mm/cache-uniphier.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/mm/cache-uniphier.c b/arch

Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER

Hi Philipp, 2016-09-20 16:30 GMT+09:00 Philipp Zabel : > Hi Masahiro, > > Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada: >> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been >> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kcon

Re: [PATCH] ARM: remove unused CONFIG_ARCH_HAS_BARRIERS

Hi. I have not had any comment on this patch, but it looks correct to me. I will put it into Russell's patch tracker if nobody is against it. 2016-06-13 21:25 GMT+09:00 Masahiro Yamada : > Since commit 2b749cb3a515 ("ARM: realview: remove private barrier > implementation"

Re: [PATCH 5/5] vmlinux.lds.h: replace config_enabled() with IS_ENABLED()

2016-06-21 5:45 GMT+09:00 Michal Marek : > Dne 14.6.2016 v 07:58 Masahiro Yamada napsal(a): >> The use of config_enabled() against config options is ambiguous. >> >> Now, IS_ENABLED() is implemented purely with macro expansion, so >> let's replace config_enabled()

[PATCH] arm64: add boot image dependencies to not generate invalid images

the dependency in arch/arm64/Makefile to avoid the race between "make Image" and "make Image.*". Signed-off-by: Masahiro Yamada --- arch/arm64/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 7085e3

Re: [PATCH] arm64: add boot image dependencies to not generate invalid images

2016-06-21 19:32 GMT+09:00 Catalin Marinas : > On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote: >> I fixed boot image dependencies for arch/arm in commit 3939f3345050 >> ("ARM: 8418/1: add boot image dependencies to not generate invalid >> images")

[PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition

kely to be false positive. Add wait code to relax the status register check. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2

[PATCH] clk: change the type of clk_hw_onecell_data.num to unsigned int

The "num" is the number of clk_hw entries in the structure, so "unsigned int" would be a better fit. (size_t looks like data size we count by byte.) Besides, struct clk_onecell_data already uses unsigned int for "clk_num". Signed-off-by: Masahiro Yamada --- in

Re: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition

Hi Wolfram, 2016-09-23 21:12 GMT+09:00 Wolfram Sang : > On Fri, Sep 23, 2016 at 09:04:01PM +0900, Masahiro Yamada wrote: >> Currently, the status register FI2C_SR is checked immediately after >> a STOP condition is issued in case of the deferred STOP condition. >> It take

[PATCH v2] i2c: uniphier-f: fix misdetection of incomplete STOP condition

kely to be false positive. Add wait code to relax the status register check. Signed-off-by: Masahiro Yamada --- Changes in v2: - use readl_poll_timeout() drivers/i2c/busses/i2c-uniphier-f.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/

Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER

Hi Philipp, 2016-09-20 19:44 GMT+09:00 Philipp Zabel : > Am Dienstag, den 20.09.2016, 17:47 +0900 schrieb Masahiro Yamada: >> Hi Philipp, >> >> >> 2016-09-20 16:30 GMT+09:00 Philipp Zabel : >> > Hi Masahiro, >> > >> > Am Dienstag, den 20.0

Re: debug tip after earlycon is closed?

Hi Arnd, 2016-07-27 16:32 GMT+09:00 Arnd Bergmann : > On Wednesday, July 27, 2016 10:23:09 AM CEST Masahiro Yamada wrote: >> [0.04] sched_clock: 56 bits at 50MHz, resolution 20ns, wraps >> every 4398046511100ns >> [0.008254] Console: colour dummy device 8

Re: [PATCH v5 0/2] clk: uniphier: add clock drivers for UniPhier SoCs

Hi. I will send v6, so please do not apply this version. (meantime review is very appreciated, though.) 2016-07-27 3:09 GMT+09:00 Masahiro Yamada : > I split into two patches to make review easier. > > 1/2: core support code > 2/2: data arrays > > > Changes in v5: &

Re: [PATCH v2] reset: uniphier: add reset controller drivers for UniPhier SoCs

es are > physically separate, please don't combine them in the driver. Right. >From the view of point of Device Tree interface, it should reflect the hardware design. I believe they are separate reset signals, so should be given with separate IDs. But, as a software engineer, it is sometimes difficult to fully understand the hardware structure. The hardware document often just says "how to use USB", but "how clock/reset signals are connected in each block" is not mentioned, or at least very unclear. Probably, I will come back with real per-reset-line ID, but I need some time to take a look. -- Best Regards Masahiro Yamada

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-07-28 18:43 GMT+09:00 Philipp Zabel : > Am Samstag, den 23.07.2016, 20:22 +0900 schrieb Masahiro Yamada: >> Hi. >> >> >> Now the reset subsystem provides >> a bunch of reset_control_get variants. >> >> I am still wondering why we n

Re: Why do we need reset_control_get_optional() ?

d return ERR_PTR(-ENOENT) if no "resets" property. I only want two types for functions that return a pointer. [1] return a valid pointer on success, or return NULL on failure (for example, kmalloc()) [2] return a valid pointer on success, or return error pointer on failure (many of _register() functions) Mixing [1] and [2] will be a mess. -- Best Regards Masahiro Yamada

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ

gt; + if (irq_domain_is_hierarchy(domain)) > + irq_domain_free_irqs(virq, 1); > + else > + irq_dispose_mapping(virq); > + return 0; > + } > + > + /* Store trigger type */ > + irqd_set_trigger_type(irq_data, type); > + > return virq; > } > EXPORT_SYMBOL_GPL(irq_create_fwspec_mapping); > -- > 2.1.4 > -- Best Regards Masahiro Yamada

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ

2016-07-29 17:10 GMT+09:00 Marc Zyngier : > On 29/07/16 04:53, Masahiro Yamada wrote: >> Hi. >> >> >> I noticed my board would not work any more >> when pulling recent updates. >> >> >> I did "git-bisect" and I found the following commit

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ

Hi Jon, 2016-07-29 17:31 GMT+09:00 Jon Hunter : > > On 29/07/16 04:53, Masahiro Yamada wrote: >> Hi. >> >> I noticed my board would not work any more >> when pulling recent updates. >> >> I did "git-bisect"

[Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer

r 1 (edge) or 4 (level) depending on the trigger type. As the CA72 Generic Timer provides active-low interrupts, the value of the 3rd cell should be 4. Signed-off-by: Masahiro Yamada Suggested-by: Marc Zyngier --- Arnd, Olof, I guess you are about to send pull-reqs for v4.8 cycle. Could you i

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ

Hi Marc, 2016-08-01 16:46 GMT+09:00 Marc Zyngier : > On 01/08/16 02:28, Masahiro Yamada wrote: >> 2016-07-29 17:10 GMT+09:00 Marc Zyngier : >>> On 29/07/16 04:53, Masahiro Yamada wrote: >>>> Hi. >>>> >>>> >>>> I noticed

Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer

Hi Marc, 2016-08-01 17:18 GMT+09:00 Marc Zyngier : > Please keep me cc-ed on this. Sorry, I automate patch-posting, but scripts/get_maintainer.pl did not pick you up. Also, I forgot to cc you explicitly. > On 01/08/16 09:12, Masahiro Yamada wrote: >> Since commit 1e2a7d78499e

Re: [PATCH v2 2/2] arm64: dts: Fix broken architected timer interrupt trigger

+++ > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 8 > arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi | 8 For uniphier-ph1-ld20.dtsi, Acked-by: Masahiro Yamada Thank you!! -- Best Regards Masahiro Yamada

[PATCH] scsi: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/scsi/aic7xxx/aic79xx_osm.c | 6 +- drivers/scsi/arcmsr/arcmsr_hba.c| 4 +--- drivers/scsi/esas2r/esas2r_ioctl.c | 20 drivers/scsi/lpfc/lpfc_attr.c | 8

[PATCH] [media] squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/media/dvb-core/dvb_frontend.c | 8 ++-- drivers/media/pci/meye/meye.c | 5 + drivers/media/pci/ttpci/av7110.c | 4 +--- drivers/media/platform/s5p

[PATCH] drm: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c| 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c| 6 +- drivers/gpu/drm/bridge

Re: [PATCH] drm: squash lines for simple wrapper functions

Hi Jani, 2016-09-07 17:34 GMT+09:00 Jani Nikula : > On Wed, 07 Sep 2016, Masahiro Yamada wrote: >> Remove unneeded variables and assignments. >> >> Signed-off-by: Masahiro Yamada > > ... > >> diff --git a/drivers/gpu/drm/i915/i915_drv.c >> b/driver

Re: [PATCH v2] treewide: fix a bunch of typos

2016-08-31 10:16 GMT+09:00 Joe Perches : > On Wed, 2016-08-31 at 08:57 +0900, Masahiro Yamada wrote: >> Spelling corrections for (among other things): >> * according > [] >> * width > > When possible and appropriate, can you please > update scripts/spelling.

Re: [PATCH] crypto: squash lines for simple wrapper functions

Hi Joe, 2016-09-13 4:44 GMT+09:00 Joe Perches : > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote: >> Remove unneeded variables and assignments. > > Was this found by visual inspection or some tool? > > If it's via a tool, it's good to mention that in the

[PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/qxl/qxl_draw.c| 7 ++- drivers/gpu/drm/qxl/qxl_release.c | 7 ++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl

[PATCH v2 1/5] drm/amdgpu: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 6 +- 3 files changed, 3 insertions(+), 15 deletions(-) diff

[PATCH v2 5/5] drm/i915: use i915_gem_open() directly instead of i915_driver_open()

i915_driver_open() is equivalent to i915_gem_open(). Replace the i915_driver_open with the direct use of i915_gem_open(). Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/i915/i915_drv.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v2 2/5] drm/radeon: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/radeon/cik.c | 6 +- drivers/gpu/drm/radeon/r100.c | 6 +- drivers/gpu/drm/radeon/r600.c | 6 +- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH v2 3/5] drm/bridge: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge

[PATCH v2 0/5] drm: clean up several wrapper functions

Changes in v2: - Split per-driver - Remove i915_driver_open() - Fix dce_virtual_hw_init() as well Masahiro Yamada (5): drm/amdgpu: squash lines for simple wrapper functions drm/radeon: squash lines for simple wrapper functions drm/bridge: squash lines for simple wrapper functions

[PATCH] mips: squash lines for simple wrapper functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- arch/mips/include/asm/mach-generic/floppy.h | 6 +- arch/mips/include/asm/pgalloc.h | 6 +- arch/mips/mti-malta/malta-platform.c| 8 +--- arch/mips/pnx833x/common/platform.c

[PATCH] fmc: clean up module_init functions

Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/fmc/fmc-chardev.c | 5 + drivers/fmc/fmc-trivial.c | 5 + drivers/fmc/fmc-write-eeprom.c | 5 + 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/fmc/fmc-chardev.c

Re: [PATCH v2 5/5] drm/i915: use i915_gem_open() directly instead of i915_driver_open()

2016-09-15 18:46 GMT+09:00 Jani Nikula : > On Wed, 14 Sep 2016, Masahiro Yamada wrote: >> i915_driver_open() is equivalent to i915_gem_open(). Replace the >> i915_driver_open with the direct use of i915_gem_open(). > > Sorry I know I asked for this, but there was oppos

[PATCH 1/3] i2c: uniphier: avoid WARN_ON() of clk_disable() in failure path

goto err" in case of error. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier.c | 73 +-- 1 file changed, 31 insertions(+), 42 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index d6e

[PATCH 2/3] i2c: uniphier-f: avoid WARN_ON() of clk_disable() in failure path

goto err" in case of error. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 73 - 1 file changed, 32 insertions(+), 41 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index 356

[PATCH 0/3] i2c: uniphier: updates for v4.9

Masahiro Yamada (3): i2c: uniphier: avoid WARN_ON() of clk_disable() in failure path i2c: uniphier-f: avoid WARN_ON() of clk_disable() in failure path i2c: uniphier-f: set the adapter to master mode when probing drivers/i2c/busses/i2c-uniphier-f.c | 85

[PATCH 3/3] i2c: uniphier-f: set the adapter to master mode when probing

Currently, the adapter is set to the master mode at the first use. Since then, it is kept in the slave mode, so unexpected glitch signals on the I2C lines may cause the adapter into insane state. Setting it to the master mode along with initialization solves the problem. Signed-off-by: Masahiro

Re: of_clk_add_(hw_)providers multipule times for one node?

Hi Stephen, 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > +Rob in case he has any insight > > On 07/09, Masahiro Yamada wrote: >> Hi. >> >> I think the current code allows to add >> clk_providers multiple times against one DT node. >> >> Are there cases

Re: [PATCH] clk: prevent __of_clk_get_hw_from_provider() from returning NULL

Hi Stephen, 2016-08-05 5:57 GMT+09:00 Stephen Boyd : > On 07/19, Masahiro Yamada wrote: >> The .get(_hw) callback of an OF clock provider can return a NULL >> pointer in some cases. >> >> For example, of_clk_src_onecell_get() returns NULL for index 1 of a >> sp

Re: [PATCH] treewide: fix a bunch of typos (part 2)

variables [2] slate -> state [3] Make it into a single line Do you mean they are all unneeded changes? -- Best Regards Masahiro Yamada

[PATCH 0/2] reset: uniphier: follow-up fix, clean-up

nitial one? Nobody would be bothered with this. Masahiro Yamada (2): reset: uniphier: add static qualifier to probe function reset: uniphier: use of_device_get_match_data() to get matched data drivers/reset/reset-uniphier.c | 81 +- 1 file changed, 40

[PATCH 1/2] reset: uniphier: add static qualifier to probe function

I missed this in the initial commit. Signed-off-by: Masahiro Yamada --- drivers/reset/reset-uniphier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c index 9de071f..41c62af 100644 --- a/drivers/reset/reset

[PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data

. Signed-off-by: Masahiro Yamada --- drivers/reset/reset-uniphier.c | 81 +- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c index 41c62af..9b3f2cd 100644 --- a/drivers/reset

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-08-16 23:36 GMT+09:00 Masahiro Yamada : > Hi Philipp, Arnd. > > > > 2016-08-09 1:39 GMT+09:00 Philipp Zabel : >> Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: >>> On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: >&

Re: of_clk_add_(hw_)providers multipule times for one node?

Hi Stephen, 2016-08-12 16:04 GMT+09:00 Masahiro Yamada : > 2016-08-11 8:08 GMT+09:00 Stephen Boyd : >> On 08/10, Masahiro Yamada wrote: >>> Hi Stephen, >>> >>> >>> >>> 2016-08-09 8:37 GMT+09:00 Stephen Boyd : >>> > On 08/08, Masa

Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data

Hi Philipp, 2016-08-24 21:27 GMT+09:00 Philipp Zabel : > Hi Masahiro, > > Am Mittwoch, den 24.08.2016, 15:40 +0900 schrieb Masahiro Yamada: >> Use of_device_get_match_data() instead of of_match_node(). With >> this, we can retrieve the .data field of the OF match table mor

[PATCH v3] clk: let clk_disable() return immediately if clk is NULL

Many of clk_disable() implementations just return for NULL pointer, but this check is missing from some. Let's make it tree-wide consistent. It will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada Acked-by: Greg Ungerer Acked-by

Re: [PATCH 03/10] reset: lpc18xx: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Joachim Eastwood > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 07/10] reset: stm32: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Maxime Coquelin > Cc: Gabriel Fernandez > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada Best Regards Masahiro Yamada

Re: [PATCH 02/10] reset: berlin: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Antoine Tenart > Cc: Sebastian Hesselbarth > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Dinh Nguyen > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 04/10] reset: meson: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Neil Armstrong > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 05/10] reset: pistachio: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Damien Horsley > Cc: James Hartley > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

2016-08-24 22:28 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Alban Bedel > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

FPGAs. > + Please move this below RESET_UNIPHIER as I assume you are sorting Kconfig entries alphabetically. Otherwise, Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 08/10] reset: sunxi: add driver Kconfig option

2016-08-24 22:29 GMT+09:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Signed-off-by: Philipp Zabel Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures

perhaps they might be planning to add more reset drivers for other Hisilicon SoCs in the future. Change to obj-y += hisilicon/ or create "config RESET_HISI" as a vendor-common option and obj-$(CONFIG_RESET_HISI) += hisilicon/ ? -- Best Regards Masahiro Yamada

Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

I think we should not care about such a rare case that may not happen. Let's start with only "if COMPILE_TEST", and take a look at it if a build error is detected. Anyway, depending on platform code is a sign of weird implementation. It might be better to find a potential issue rather than hide it. -- Best Regards Masahiro Yamada

Re: of_clk_add_(hw_)providers multipule times for one node?

Hi Stephen, 2016-08-25 3:08 GMT+09:00 Stephen Boyd : > (Please trim replies) > > On 08/24, Masahiro Yamada wrote: >> >> Looks like the whole of my series was rejected, >> but I was not sure why the following one was rejected. >> https://patchwork.kernel.org/patch

Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

2016-08-25 2:48 GMT+09:00 Masahiro Yamada : > 2016-08-24 22:29 GMT+09:00 Philipp Zabel : >> Visible only if COMPILE_TEST is enabled, this allows to include the >> driver in build tests. >> >> Cc: Moritz Fischer >> Cc: Michal Simek >> Cc: Sören Bri

Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

2016-08-25 5:06 GMT+09:00 Arnd Bergmann : > On Thursday, August 25, 2016 3:18:55 AM CEST Masahiro Yamada wrote: >> Hi Arnd, >> >> >> 2016-08-25 0:51 GMT+09:00 Arnd Bergmann : >> > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote: >> &

Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

2016-08-25 16:22 GMT+09:00 Philipp Zabel : > And the hi6220 > driver, which doesn't have a user yet. It does. See arch/arm64/configs/defconfig -- Best Regards Masahiro Yamada

Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

2016-08-25 16:23 GMT+09:00 Philipp Zabel : > Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada: >> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada : >> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel : >> >> Visible only if COMPILE_TEST is enabled, this allows

Re: [PATCH 4/6] arm64: dts: uniphier: use cross-arch include instead of symlinks

2017-08-10 1:43 GMT+09:00 Masahiro Yamada : > On UniPhier platform, some DTSI files are shared between arm and arm64. > Recently, inclusion of DT material of different architectures has been > supported by the build system level. Use #include , which > will work without relying on th

Re: [PATCH 5/6] ARM: dts: uniphier: add Denali NAND controller node

2017-08-10 1:43 GMT+09:00 Masahiro Yamada : > Add NAND controller node to LD4, Pro4, sLD8, Pro5, and PXs2. > Set up pinctrl to enable 2 chip select lines except Pro4. The CS1 > for Pro4 is multiplexed with other peripherals such as UART2, so > I did not enable it. > > Signe

Re: [PATCH 6/6] arm64: dts: uniphier: add Denali NAND controller nodes

2017-08-10 1:43 GMT+09:00 Masahiro Yamada : > Add NAND controller node to LD11 and LD20. Neither of them supports > the CS1 line, so pinctrl is set up for a single CS line. > > Signed-off-by: Masahiro Yamada > --- Applied to linux-uniphier. -- Best Regards Masahiro Yamada

[GIT PULL] ARM: dts: uniphier: UniPhier DT updates for v4.14

pin-mux node Masahiro Yamada (4): ARM: dts: uniphier: use SPDX-License-Identifier (2nd) ARM: dts: uniphier: remove sLD3 SoC support ARM: dts: uniphier use #include instead of /include/ ARM: dts: uniphier: add Denali NAND controller node arch/arm/boot/dts/Makefile

[GIT PULL] arm64: dts: uniphier: UniPhier DT updates (64bit) for v4.14

ier-pinctrl.dtsi mode change 12 => 100644 arch/arm64/boot/dts/socionext/uniphier-ref-daughter.dtsi mode change 12 => 100644 arch/arm64/boot/dts/socionext/uniphier-support-card.dtsi -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] kbuild: Also evaluate alternative option passed to cc-option, etc

valuation, we will need to support it in the common script somehow. Otherwise, could you solve the problem in local Makefile? (I was wondering if we can support multiple evaluation in a generic try-run implementation, for example using "for ... do ... done" loop of shell script, but it would introduce much complexity.) For example, one very ad-hoc solution: # For gcc stack alignment is specified with -mpreferred-stack-boundary, # clang has the option -mstack-alignment for that purpose. ifneq ($(call cc-option, -mpreferred-stack-boundary=4),) cc_stack_align4 := -mpreferred-stack-boundary=2 cc_stack_align8 := -mpreferred-stack-boundary=3 else cc_stack_align4 := -mstack-alignment=4 cc_stack_align8 := -mstack-alignment=8 endif -- Best Regards Masahiro Yamada

Re: [GIT PULL] ARM: dts: uniphier: UniPhier DT updates for v4.14

Hi Arnd, 2017-08-17 6:31 GMT+09:00 Arnd Bergmann : > On Wed, Aug 16, 2017 at 5:00 AM, Masahiro Yamada > wrote: > >> >> UniPhier ARM SoC DT updates for v4.14 >> >> - complete migrating to SPDX Licen

Re: [PATCH v4 1/3] kbuild: Add __cc-option macro

gt; Refactor cc-option and hostcc-option to use __cc-option and move > hostcc-option to scripts/Kbuild.include. > > Suggested-by: Arnd Bergmann > Suggested-by: Masahiro Yamada > Signed-off-by: Matthias Kaehlcke > Acked-by: Masahiro Yamada > --- > Changes in v4: > - R

[PATCH] clk: uniphier: provide NAND controller clock rate

This allows the NAND driver to get the clock rate via clk_get_rate(). Signed-off-by: Masahiro Yamada --- drivers/clk/uniphier/clk-uniphier-sys.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/uniphier/clk-uniphier-sys.c b/drivers/clk/uniphier

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

2017-06-14 15:45 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2017-06-13 19:21 GMT+09:00 Michael Ellerman : >>> Masahiro Yamada writes: >>>> >>>> (+Anatolij Gustschin ) >>>> >>>> Ping. >>>> I am not 100%

Re: [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning

#x27;clang > --std=gnu89' > and 'gcc --pedantic --std=gnu89' warn about both of b as well, and don't warn > for newer standards. > >Arnd I think we agreed to apply 1/2. How about 2/2? I think we mostly discussed preferable behavior of -Wduplicate-decl-specifier, but we did not come up with an idea to solve the problem for already shipped clang versions. (BTW, we have not defined the minimal supported version of clang yet.) -- Best Regards Masahiro Yamada

[PATCH] MAINTAINERS: add entry for Denali NAND controller driver

The Denali NAND controller driver (drivers/mtd/nand/denali*) has been largely reworked by me. Add myself as its maintainer now. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c82a2d790366..a83834aa9341

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

2017-06-21 18:48 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2017-06-14 15:45 GMT+09:00 Michael Ellerman : >>> >>> Acked-by: Michael Ellerman >> >> I have not seen it in linux-next yet. >> >> Who will pick it up? > > In

Re: [PATCH] kbuild: fix header installation under fakechroot environment

wildcard $(srcdir)/*/ > > And thanks to Yamada Masahiro who figured out the right > filter-out/patsubst order ! > > Fixes: fcc8487d477a ("uapi: export all headers under uapi directories") > Signed-off-by: Richard Genoud > --- Applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: replace genhdr-y with generated-y, deprecating genhdr-y

2017-06-09 17:29 GMT+09:00 Masahiro Yamada : > Prior to commit fcc8487d477a ("uapi: export all headers under uapi > directories"), genhdr-y was meant to specify generated UAPI headers. > > - generated-y: generated headers (other than asm-generic wrappers) > - header-y

Re: [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning

CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as >> the > > Though I'm no expert, after reading the discussion on this thread and > looking at the examples provided by Matthias, this seems sane to me. > Thus, FWIW: > > Reviewed-by: Douglas Anderson 1/2 applied to linux-kbuild/kbuild. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 0/2] kbuild: use relative path from $(srctree) instead of __FILE__

2017-10-12 18:56 GMT+09:00 Masahiro Yamada : > > Kbuild works in objtree, not in srctree. So, __FILE__ is prefixed > with $(srctree)/ for out-of-tree build. > > For example, WARN_ON() will look as follows if you built your kernel > out of source tree: > > WARNING: CPU: 1

Re: [PATCH 0/3] ARM, hexagon, c6x: build: fix usage of CFLAGS_MODULE, LDFLAGS_MODULE

2017-10-09 23:35 GMT+09:00 Masahiro Yamada : > CFLAGS_MODULE, AFLAGS_MODULE, and LDFLAGS_MODULE are supposed > to be set by users. > > In-kernel Makefile must use KBUILD_ prefixed variables. > > This is explained in Documentation/kbuild/{kbuild.txt, makefiles.txt} > > Most

Re: [PATCH v3 0/2] kbuild: Cache exploratory calls to the compiler

gt; - Rule to prevent make from trying to generate the cache > - Rule to clean .cache.mk > - No more doc changes > - Moved cache stuff below cc-cross-prefix > - Removed duplicate documentation of try-run (oops) > - Add Tested-by for Ingo and Guenter since v2 and v3 are very similar >

Re: [PATCH] kbuild: remove KBUILD_SUBDIR_ASFLAGS and KBUILD_SUBDIR_CCFLAGS

2017-10-10 20:43 GMT+09:00 Masahiro Yamada : > Accumulate subdir-{cc,as}flags-y directly to KBUILD_{A,C}FLAGS. > Remove KBUILD_SUBDIR_{AS,CC}FLAGS. > > Signed-off-by: Masahiro Yamada > --- > Applied to linux-kbuild/kbuild. Best Regards Masahiro Yamada

Re: [PATCH v2 1/3] dt-bindings: nvmem: add description for UniPhier eFuse

2017-10-14 3:42 GMT+09:00 Rob Herring : > On Fri, Oct 13, 2017 at 11:04 AM, Masahiro Yamada > wrote: >> Hi Rob, >> >> >> 2017-10-13 22:49 GMT+09:00 Rob Herring : >>> On Fri, Oct 06, 2017 at 02:02:58PM +0900, Keiji Hayashibara wrote: >>&g

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; > + }; > -- > 2.7.4 > I found the following code in 2/2. + /* get clock */ + priv->clk = clk_get(dev, NULL); + if (IS_ERR(priv->clk)) + priv->clk = NULL; + + /* get reset */ + priv->rst = reset_control_get(dev, NULL); + if (IS_ERR(priv->rst)) + priv->rst = NULL; + This doc needs to describe "clocks", "resets". -- Best Regards Masahiro Yamada

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

ove. > + priv->rst = reset_control_get(dev, NULL); > + if (IS_ERR(priv->rst)) > + priv->rst = NULL; reset_control_get() is deprecated. Do not use it in a new driver. Again, missing reset_control_put(). devm? The reset seems optional (again, ignoring EPROBE_DEFER) but you did not use reset_control_get_optional, why? >From your code, this reset is used as shared. priv->rst = devm_reset_control_get_optional_shared(dev, NULL); if (IS_ERR(priv->rst)) return PTR_ERR(priv->rst); -- Best Regards Masahiro Yamada

Re: [RESEND PATCH v4 0/2] add thermal nodes for UniPhier SoCs

2017-09-18 21:10 GMT+09:00 Masahiro Yamada : > 2017-09-04 15:58 GMT+09:00 Kunihiko Hayashi : >> This series adds thermal nodes for UniPhier PXs2 and LD20 SoCs. >> >> Resending the patches to apply the missing comments, >> please ignore previous v4. >> >> Cha

  1   2   3   4   5   6   7   8   9   10   >