Re: [PATCH] kconfig: Clarify menu and 'if' dependency propagation

2018-01-21 Thread Masahiro Yamada
No functional changes. Only comments added. > > Signed-off-by: Ulf Magnusson > --- > scripts/kconfig/menu.c | 2 ++ Applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH] kconfig: Clarify choice dependency propagation

2018-01-21 Thread Masahiro Yamada
2018-01-19 11:29 GMT+09:00 Masahiro Yamada : > Hi Ulf, > > > 2018-01-19 1:58 GMT+09:00 Ulf Magnusson : >> On Thu, Jan 18, 2018 at 5:47 PM, Masahiro Yamada >> wrote: >>> 2018-01-14 23:12 GMT+09:00 Ulf Magnusson : >>>> It's easy to miss that choic

Re: [PATCH v2 1/2] kconfig: Document 'if' flattening logic

2018-01-21 Thread Masahiro Yamada
; promptless symbols. > > scripts/kconfig/menu.c | 29 + > 1 file changed, 29 insertions(+) > Applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada

Re: [GIT PULL] ARM: uniphier: fixes for v4.15 (2nd)

2018-01-04 Thread Masahiro Yamada
Hi Arnd, 2018-01-05 1:10 GMT+09:00 Arnd Bergmann : > On Fri, Dec 29, 2017 at 1:30 PM, Masahiro Yamada > wrote: >> Hi Arnd, Olof, >> >> This is the 2nd bug-fix pull request for v4.15. >> Just one DT fix. Please pull! > > I've ended up cherry-picking t

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-04 Thread Masahiro Yamada
ginning of the git era. > printf(" --olddefconfig Same as silentoldconfig but sets > new symbols to their default value\n"); > printf(" --oldnoconfig An alias of olddefconfig\n"); > printf(" --defconfig New config with default defined in > \n"); > -- > 2.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

[PATCH 1/2] genl_magic: remove own BUILD_BUG_ON*() defines

2018-01-04 Thread Masahiro Yamada
Do not duplicate BUILD_BUG_ON*. Use ones from . Signed-off-by: Masahiro Yamada --- include/linux/genl_magic_func.h | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/genl_magic_func.h b/include/linux/genl_magic_func.h index 6049676..83f81ac 100644

[PATCH 0/2] Consolidate BUILD_BUG macros

2018-01-04 Thread Masahiro Yamada
Masahiro Yamada (2): genl_magic: remove own BUILD_BUG_ON*() defines build_bug.h: remove BUILD_BUG_ON_NULL() include/linux/build_bug.h | 2 -- include/linux/genl_magic_func.h | 12 +--- net/ipv6/mcast.c| 8 3 files changed, 5 insertions(+), 17

[PATCH 2/2] build_bug.h: remove BUILD_BUG_ON_NULL()

2018-01-04 Thread Masahiro Yamada
This macro is only used by net/ipv6/mcast.c, but there is no reason why it must be BUILD_BUG_ON_NULL(). Replace it with BUILD_BUG_ON_ZERO(), and remove BUILD_BUG_ON_NULL() definition from . Signed-off-by: Masahiro Yamada --- include/linux/build_bug.h | 2 -- net/ipv6/mcast.c | 8

[PATCH] pinctrl: remove redundant mux_setting clear in pinmux_disable_setting()

2018-01-05 Thread Masahiro Yamada
desc->mux_setting is set to NULL in pin_free() called just below. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/pinmux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 55502fc..82b18ef 100644 --- a/drivers/pinctrl/pinmu

[PATCH] of: unittest: refactor Makefile

2018-01-05 Thread Masahiro Yamada
Some cleanups: - use obj-$(CONFIG_OF_OVERLAY) instead of ifdef ... endif - compute targets from obj-y Signed-off-by: Masahiro Yamada --- drivers/of/unittest-data/Makefile | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/of/unittest-data

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-05 Thread Masahiro Yamada
x/v4.15-rc6/source/drivers/mmc/core/core.c#L2818 [2] http://elixir.free-electrons.com/linux/v4.15-rc6/source/drivers/mmc/host/tmio_mmc_core.c#L656 [3] http://elixir.free-electrons.com/linux/v4.15-rc6/source/drivers/mmc/core/core.c#L1995 [4] http://elixir.free-electrons.com/linux/v4.15-rc6/source/drivers/mmc/host/tmio_mmc_core.c#L1105 -- Best Regards Masahiro Yamada

Re: [PATCH] kconfig: fix relational operators for bool and tristate symbols

2018-01-05 Thread Masahiro Yamada
th bool/tristate > expressions as well and document them. If at least one symbol is an > actual string then the lexicographical compare works just as before. > > Signed-off-by: Nicolas Pitre > Applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada

[PATCH] libfdt: remove unnecessary include directive from

2018-01-06 Thread Masahiro Yamada
is a wrapper of ../../scripts/dtc/libfdt/libfdt.h It should not do more than its job. In fact, libfdt.h depends on fdt.h, and ../../scripts/dtc/libfdt/libfdt.h includes fdt.h already. Trust the work in the upstream DTC project. Signed-off-by: Masahiro Yamada --- include/linux/libfdt.h | 1

[PATCH v2] libfdt: remove unnecessary include directive from

2018-01-06 Thread Masahiro Yamada
is a wrapper of scripts/dtc/libfdt/libfdt.h It should not do more than its job. In fact, libfdt.h depends on fdt.h, and scripts/dtc/libfdt/libfdt.h includes fdt.h already. Trust the work in the upstream DTC project. Signed-off-by: Masahiro Yamada --- Changes in v2: - Rephrase commit-log a

Re: Mutli-directory module Makefiles

2018-01-27 Thread Masahiro Yamada
2018-01-26 4:47 GMT+09:00 Jakub Kicinski : > On Thu, 25 Jan 2018 22:08:34 +0900, Masahiro Yamada wrote: >> 2018-01-23 6:46 GMT+09:00 Jakub Kicinski : >> > Hi! >> > >> > in drivers/net/ethernet/netronome/nfp there is a module which is built >> > from

Re: [PATCH] kconfig: announce removal of oldnoconfig if used

2018-01-27 Thread Masahiro Yamada
2018-01-18 20:56 GMT+09:00 Ulf Magnusson : > On Thu, Jan 18, 2018 at 5:13 AM, Masahiro Yamada > wrote: >> The 'oldnoconfig' is really confusing due to its counter-intuitive name. >> It was renamed by commit fb16d8912db5 ("kconfig: replace 'oldnoconfig

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-27 Thread Masahiro Yamada
2018-01-27 8:00 GMT+09:00 Marc Herbert : > Masahiro, > > On 17/01/2018 20:31, Masahiro Yamada wrote: > >> Sorry for my late reply. > > I think we're even now :-) > >>> I'd like to keep that sentence because it's there to explain the lega

Re: [PATCH v3] Remove silentoldconfig from help and docs; fix kconfig/conf's help

2018-01-27 Thread Masahiro Yamada
ut sets > new symbols to their default value\n"); > + printf(" --silentoldconfig Similar to oldconfig but generates > configuration in\n" > + " include/{generated/,config/} > (oldconfig used to be more verbose)\n"); > + printf(" --olddefconfig Same as oldconfig but sets new > symbols to their default value\n"); > printf(" --oldnoconfig An alias of olddefconfig\n"); > printf(" --defconfig New config with default defined in > \n"); > printf(" --savedefconfig Save the minimal current > configuration to \n"); > -- > 2.13.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: fix W= option checks for extra DTC warnings

2018-01-27 Thread Masahiro Yamada
2018-01-18 12:31 GMT+09:00 Masahiro Yamada : > Kbuild supports 3 levels of extra warnings, and multiple levels can > be combined, like W=12, W=123. It was added by commit a6de553da01c > ("kbuild: Allow to combine multiple W= levels"). > > From the log of commit 8654cb8d0

Re: [PATCH 1/2] of: change overlay apply input data from EDT to FDT

2018-01-28 Thread Masahiro Yamada
t; DTC_FLAGS_overlay_bad_symbol := -@ > DTC_FLAGS_overlay_base := -@ > +DTC_FLAGS_testcases := -@ > This overwrites '-Wno-interrupts_property' a few lines above. Perhaps, do you want to do like this? DTC_FLAGS_testcases += -@ or DTC_FLAGS_testcases := -Wno-interrupts_property -@ -- Best Regards Masahiro Yamada

Re: [PATCH] Coccinelle: memdup: drop spurious line

2018-01-29 Thread Masahiro Yamada
\|kzalloc@p\)(size,flag); > - to = kmemdup(from,size,flag); > if (to==NULL || ...) S > * memcpy(to, from, size); > > Applied to linux-kbuild/misc. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH] Kbuild: suppress packed-not-aligned warning for default setting only

2018-01-16 Thread Masahiro Yamada
g-1 += $(call cc-disable-warning, missing-field-initializers) > warning-1 += $(call cc-disable-warning, sign-compare) Applied to linux-kbuild/kbuild. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/7] fixdep: remove unnecessary inclusion

2018-01-16 Thread Masahiro Yamada
2018-01-11 22:05 GMT+09:00 Masahiro Yamada : > was included for ntohl(), but it was removed by > commit dee81e988674 ("fixdep: faster CONFIG_ search"). > > Signed-off-by: Masahiro Yamada > --- > Series, applied to linux-kbuild/kbuild. -- Best Regards Masahiro Yamada

Re: [PATCH 3/6] kconfig: do not call conf_set_all_new_symbols() for (all)defconfig

2018-01-16 Thread Masahiro Yamada
Hi Ulf, 2018-01-12 23:28 GMT+09:00 Ulf Magnusson : > On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada > wrote: >> (all)defconfig does not need to call conf_set_all_new_symbols() because >> conf_write() calculates all symbols based on their default unless they >>

Re: [PATCH] Kbuild: suppress packed-not-aligned warning for default setting only

2018-01-17 Thread Masahiro Yamada
=== > > +KBUILD_CFLAGS += $(call cc-disable-warning, packed-not-aligned) > + I moved this to else case of KBUILD_ENABLE_EXTRA_GCC_CHECKS Please let me know if you see a problem. -- Best Regards Masahiro Yamada

[PATCH v3 04/16] mmc: tmio: remove dma_ops from tmio_mmc_host_probe() argument

2018-01-17 Thread Masahiro Yamada
Drivers need to set up various struct members for tmio_mmc_host before calling tmio_mmc_host_probe(). Do likewise for host->dma_ops instead of passing it as a function argument. Signed-off-by: Masahiro Yamada Reviewed-by: Wolfram Sang --- Changes in v3: None Changes in v2: None drivers/

[PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-01-17 Thread Masahiro Yamada
: new patches (cleanups of WP flag) Patch 12: updated per Wolfram Patch 13: repost (almost reviewed) Patch 14: updated Patch 15: new Patch 16: repost (almost reviewed) Masahiro Yamada (16): mmc: tmio: ioremap memory resource in tmio_mmc_host_alloc() mmc: tmio: move clk_enable/disable out

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-17 Thread Masahiro Yamada
;native_hogplug is 0. Then, my code does nothing, doesn't it? + if (_host->native_hotplug) + tmio_mmc_enable_mmc_irqs(_host, + TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT); -- Best Regards Masahiro Yamada

[PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property

2018-01-17 Thread Masahiro Yamada
e same thing. Let's remove the description from the dt-binding to prevent new boards from using it. I am keeping the driver code for existing DT files, but added comments that this is deprecated. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None Document

[PATCH v3 08/16] sh: kfr2r09: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag

2018-01-17 Thread Masahiro Yamada
P2_... returns 0 before calling ->get_ro() hook (i.e. it affects both IP own logic and GPIO detection). The TMIO MMC drivers do not set-up gpio_ro by themselves, so gpio_ro is obviously unused by legacy boards like this. So, this conversion should be safe. Signed-off-by: Masahiro Yamada --- C

[PATCH v3 13/16] mmc: tmio: fix never-detected card insertion bug

2018-01-17 Thread Masahiro Yamada
card is never detected. The card event IRQs must be enabled in probe/resume functions. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - Newly added drivers/mmc/host/tmio_mmc_core.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH v3 06/16] mmc: tmio: refactor .get_ro hook

2018-01-17 Thread Masahiro Yamada
the probe function, then set mmc_gpio_get_ro to .get_ro if it is the case. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None drivers/mmc/host/tmio_mmc_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host

[PATCH v3 03/16] mmc: tmio: move {tmio_}mmc_of_parse() to tmio_mmc_host_alloc()

2018-01-17 Thread Masahiro Yamada
handle capabilities before mmc_add_host(). Move tmio_mmc_of_parse() likewise. Signed-off-by: Masahiro Yamada Reviewed-by: Wolfram Sang --- Changes in v3: None Changes in v2: - Newly added drivers/mmc/host/tmio_mmc_core.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions

[PATCH v3 16/16] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe()

2018-01-17 Thread Masahiro Yamada
ask &= ~irq_mask; The logic is opposite between "->sdcard_irq_mask" and "irq_mask". The intention is not clear at a glance. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - Newly added drivers/mmc/host/tmio_mmc_core.c | 3 --- 1 file changed

[PATCH v3 07/16] mmc: renesas_sdhi: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag

2018-01-17 Thread Masahiro Yamada
ds with "wp-gpios". So, this conversion should be safe. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None drivers/mmc/host/renesas_sdhi_internal_dmac.c | 6 +++--- drivers/mmc/host/renesas_sdhi_sys_dmac.c | 16 2 files

[PATCH v3 10/16] mmc: tmio: remove TMIO_MMC_WRPROTECT_DISABLE

2018-01-17 Thread Masahiro Yamada
The use of this flag has been replaced with MMC_CAP2_NO_WRITE_PROTECT. No platform defines this flag any more. Remove. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None drivers/mmc/host/tmio_mmc_core.c | 5 ++--- include/linux/mfd/tmio.h | 1 - 2

[PATCH v3 02/16] mmc: tmio: move clk_enable/disable out of tmio_mmc_host_probe()

2018-01-17 Thread Masahiro Yamada
ta to tmio_mmc_host_alloc() because renesas_sdhi_clk_enable() needs it to get the private data from tmio_mmc_host. Signed-off-by: Masahiro Yamada Reviewed-by: Wolfram Sang --- Changes in v3: None Changes in v2: - Newly added drivers/mmc/host/renesas_sdhi_core.c | 13 ++--- drivers/mmc/host/tmio_

[PATCH v3 05/16] mmc: slot-gpio: add a helper to check capability of GPIO WP detection

2018-01-17 Thread Masahiro Yamada
Like mmc_can_gpio_cd(), mmc_can_gpio_ro() will also be useful for host drivers to know whether GPIO write-protect detection is supported. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None drivers/mmc/core/slot-gpio.c | 8 include/linux/mmc/slot

[PATCH v3 15/16] mmc: tmio: clear force_pio flag before starting data transfer

2018-01-17 Thread Masahiro Yamada
this flag. Signed-off-by: Masahiro Yamada --- Changes in v3: - newly added Changes in v2: None drivers/mmc/host/tmio_mmc_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 731552a..494f0b3

[PATCH v3 01/16] mmc: tmio: ioremap memory resource in tmio_mmc_host_alloc()

2018-01-17 Thread Masahiro Yamada
d-off-by: Masahiro Yamada Reviewed-by: Wolfram Sang --- Changes in v3: None Changes in v2: None drivers/mmc/host/renesas_sdhi_core.c | 4 ++-- drivers/mmc/host/tmio_mmc.c | 4 +++- drivers/mmc/host/tmio_mmc_core.c | 16 +--- 3 files changed, 14 insertions(+), 10 dele

[PATCH v3 12/16] mmc: tmio: support IP-builtin card detection logic

2018-01-17 Thread Masahiro Yamada
vel of the CD line. Allow to use it if the GPIO is unused. Signed-off-by: Masahiro Yamada --- Changes in v3: - split out GPIO CD Changes in v2: None drivers/mmc/host/tmio_mmc_core.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/tmio_mmc_cor

[PATCH v3 14/16] mmc: tmio: move TMIO_MASK_{READOP,WRITEOP} handling to correct place

2018-01-17 Thread Masahiro Yamada
s_ NULL because tmio_mmc_request_dma() is called after this code. Consequently, TMIO_MASK_{READOP,WRITEOP} are set here whether DMA is used or not. Remove this pointless code. Signed-off-by: Masahiro Yamada --- Changes in v3: - Remove the first paragraph of git-log - Clean up renesas drivers too Changes i

[PATCH v3 09/16] mmc: tmio: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag

2018-01-17 Thread Masahiro Yamada
operty and "toshiba,mmc-wrprotect-disable" at the same time. I checked under arch/arm/boot/dts/ and arch/arm64/boot/dts/renesas/, and I did not see any Renesas boards with "wp-gpios". So, this conversion should be safe. Signed-off-by: Masahiro Yamada --- Changes in v3: - new

Re: [PATCH v2 17/22] mmc: tmio: move TMIO_MASK_{READOP,WRITEOP} handling to correct place

2018-01-17 Thread Masahiro Yamada
Hi Wolfram, 2018-01-16 17:01 GMT+09:00 Wolfram Sang : > On Sat, Nov 25, 2017 at 01:24:52AM +0900, Masahiro Yamada wrote: >> This driver was largely extended by Renesas, but actually used by >> several SoC vendors. The current code does not work for UniPhier >> SoCs at lea

Re: [PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-17 Thread Masahiro Yamada
Hi Ulf, 2018-01-13 1:49 GMT+09:00 Ulf Magnusson : > On Fri, Jan 12, 2018 at 1:26 PM, Ulf Magnusson wrote: >> On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada >> wrote: >>> check_conf() traverses the menu tree, but it is completely no-op for >>> olddefconfig be

Re: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property

2018-01-17 Thread Masahiro Yamada
2018-01-18 1:28 GMT+09:00 Masahiro Yamada : > This property is equivalent to "disable-wp" defined in > Documentation/devicetree/bindings/mmc/tmio_mmc.txt This is mistake. "disable-wp" is defined in Documentation/devicetree/bindings/mmc/mmc.txt > The TMIO MMC c

[PATCH] kbuild: fix W= option checks for extra DTC warnings

2018-01-17 Thread Masahiro Yamada
, but not by W=12, or W=123. Use $(findstring ...) like scripts/Makefile.extrawarn. Signed-off-by: Masahiro Yamada --- Side Notes for possible additional works: [1] I implemented DTC extra warnings differently in U-Boot: https://github.com/u-boot/u-boot/blob/v2018.01/scripts/Makefile.extra

Re: [PATCH] Kbuild: suppress packed-not-aligned warning for default setting only

2018-01-17 Thread Masahiro Yamada
Hi Arnd, 2018-01-18 4:40 GMT+09:00 Arnd Bergmann : > On Wed, Jan 17, 2018 at 5:12 PM, Masahiro Yamada > wrote: >> 2018-01-11 18:22 GMT+09:00 Xiongfeng Wang : >>> From: Xiongfeng Wang >>> >>> gcc-8 reports many -Wpacked-not-aligned warnings. The below a

[PATCH] kconfig: announce removal of oldnoconfig if used

2018-01-17 Thread Masahiro Yamada
alias for enough period of time, and finally I am planning to remove it. Meanwhile, the following message will be displayed if oldnoconfig is used. WARNING: "oldnoconfig" target will be removed after Linux 4.19 Please use "olddefconfig" instead. Signed-off-by: Mas

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-17 Thread Masahiro Yamada
Hi Marc, Sorry for my late reply. 2018-01-13 7:49 GMT+09:00 Marc Herbert : > Masahiro, > > On 09/01/2018 23:17, Masahiro Yamada wrote: > >> > "(oldconfig used to be more verbose)" > >>The historical background is git. >>If people are inte

Re: [PATCH] kconfig: Document SYMBOL_OPTIONAL logic

2018-01-18 Thread Masahiro Yamada
if (sym && !sym_is_optional(sym) && parent->prompt) { > sym->rev_dep.expr = expr_alloc_or(sym->rev_dep.expr, > expr_alloc_and(parent->prompt->visible.expr, > -- Applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 2/2] kconfig: Improve auto. menu documentation accuracy

2018-01-18 Thread Masahiro Yamada
this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I squashed this into the previous patch: https://patchwork.kernel.org/patch/9991939/ Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 1/3] kconfig: make input_mode static

2018-01-18 Thread Masahiro Yamada
2018-01-11 22:39 GMT+09:00 Masahiro Yamada : > Sparse reports: > warning: symbol 'input_mode' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada > --- Applied all 3 patches to linux-kbuild/kconfig. -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] kconfig: use default 'yy' prefix for lexer and parser

2018-01-18 Thread Masahiro Yamada
2018-01-12 9:58 GMT+09:00 Masahiro Yamada : > Flex and Bison provide an option to change the prefix of globally- > visible symbols. This is useful to link multiple lexers and/or > parsers into the same executable. However, Kconfig (and any other > host programs in kernel) uses a sing

Re: [PATCH v3] fixdep: exit with error code in error branches of do_config_file()

2018-01-09 Thread Masahiro Yamada
git tree, i.e., > git://git.kernel.org/pub/scm/linux/kernel/git/history/history.git. > > This issue was identified during the review of a previous patch that > intended to address a memory leak detected by a static analysis tool. > > Link: https://lkml.org/lkml/2017/12/14/736 > >

[PATCH 4/6] fixdep: move global variables to local variables of main()

2018-01-09 Thread Masahiro Yamada
I do not mind global variables where they are useful enough. In this case, I do not see a good reason to use global variables since they are just referenced in shallow places. It is easy to pass them via function arguments. Signed-off-by: Masahiro Yamada --- scripts/basic/fixdep.c | 36

[PATCH 3/6] fixdep: remove unneeded memcpy() in parse_dep_file()

2018-01-09 Thread Masahiro Yamada
Each token in the depfile is copied to the temporary buffer 's' to terminate the token with zero. We do not need to do this any more because the parsed buffer is now writable. Insert '\0' directly in the buffer without calling memcpy(). Signed-off-by: Masahiro Yamada

[PATCH 2/6] fixdep: merge do_config_file() and print_deps() into load_file()

2018-01-09 Thread Masahiro Yamada
r an empty file. strstr() will just return NULL, and this is what we expect. On the other hand, empty dep_file should be treated as an error. In this case, parse_dep_file() will error out with "no targets found" and it is a correct error message. Signed-off-by: Masahiro Yamada

[PATCH 1/6] fixdep: use malloc() and read() to load dep_file to buffer

2018-01-09 Thread Masahiro Yamada
nto a malloc'ed buffer, we can insert '\0' after each token, and save memcpy(). (I will do this in the commit after next.) Signed-off-by: Masahiro Yamada --- scripts/basic/fixdep.c | 55 +- 1 file changed, 32 insertions(+),

[PATCH 6/6] fixdep: use existing helper to check modular CONFIG options

2018-01-09 Thread Masahiro Yamada
. Signed-off-by: Masahiro Yamada --- scripts/basic/fixdep.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 3881bf1..9642302 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -230,6

[PATCH 5/6] fixdep: refactor parse_dep_file()

2018-01-09 Thread Masahiro Yamada
ction argument. With this, we can swap the order of strrcmp() and "*p = \0;" Also, strrcmp() is an ambiguous function name. Flip the logic and rename it to str_ends_with(). I added a new helper is_ignored_file() - this returns 1 if the token represents a file that should be ignored.

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-09 Thread Masahiro Yamada
2018-01-08 19:17 GMT+09:00 Lukas Bulwahn : > > On Sun, 31 Dec 2017, Masahiro Yamada wrote: > >> 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : >>> >>> diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c >>> index bbf62cb..4274610 100644 >>> -

[PATCH 4/6] kconfig: remove unneeded input_mode test in conf()

2018-01-09 Thread Masahiro Yamada
conf() is never called for listnewconfig / olddefconfig. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 8364811..693cd5f 100644 --- a/scripts/kconfig/conf.c

[PATCH 2/6] kconfig: call sym_calc_value() for all symbols before writing to .config

2018-01-09 Thread Masahiro Yamada
hen calculating the visibility of its children (choice value). We can pass NULL to sym_calc_value() since it is no-op. This should give no impact on behavior, but make the logic more easier to understand. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 3 ++- 1 file change

[PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-09 Thread Masahiro Yamada
automatically sets new symbols to their default value. There is no room for manual intervention. So, calling check_conf() for olddefconfig is odd in the first place. Rather, olddefconfig belongs to the group of alldefconfig and defconfig. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c

[PATCH 3/6] kconfig: do not call conf_set_all_new_symbols() for (all)defconfig

2018-01-09 Thread Masahiro Yamada
change still produced the same .config for all ARCH. I also moved savedefconfig to collect the no-op cases at the end of the switch statement. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/scripts/kconfig/c

[PATCH 6/6] kconfig: hide irrelevant menu for oldconfig

2018-01-09 Thread Masahiro Yamada
ig: use long options in conf") made oldconfig as loud as [0] due to misconversion. [4] Commit 14828349719a ("kconfig: fix make oldconfig") addressed the misconversion of [3], but it made oldconfig quieter only to the same level as [1], not [2]. This commit is restoring

[PATCH 5/6] kconfig: remove redundant input_mode test for check_conf() loop

2018-01-09 Thread Masahiro Yamada
check_conf() never increments conf_cnt for listnewconfig, so conf_cnt is always zero. In other words, conf_cnt is not zero, "input_mode != listnewconfig" is met. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-09 Thread Masahiro Yamada
2018-01-06 7:21 GMT+09:00 Marc Herbert : > On 04/01/2018 09:21, Masahiro Yamada wrote: >> (+CC Michal's new address) >> >> 2017-12-19 10:26 GMT+09:00 Marc Herbert : >>> As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 >>> silentoldco

[PATCH] pinctrl: uniphier: refactor drive strength get/set functions

2018-01-10 Thread Masahiro Yamada
There is code duplication between uniphier_conf_pin_drive_get() and uniphier_conf_pin_drive_set(). Factor out the common code into uniphier_conf_get_drvctrl_data(). Signed-off-by: Masahiro Yamada --- drivers/pinctrl/uniphier/pinctrl-uniphier-core.c | 176 --- 1 file

Re: [PATCH] Coccinelle: alloc_cast: Add more memory allocating functions to the list

2018-01-16 Thread Masahiro Yamada
eletions(-) Applied to linux-kbuild/misc. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-16 Thread Masahiro Yamada
> Signed-off-by: Himanshu Jha > --- Applied to linux-kbuild/misc. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH v2] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-16 Thread Masahiro Yamada
0 insertions(+), 0 deletions(-) > rename scripts/coccinelle/api/alloc/{kzalloc-simple.cocci => > zalloc-simple.cocci} (100%) > Applied to linux-kbuild/misc. Thanks! -- Best Regards Masahiro Yamada

[PATCH] arm64: dts: uniphier: use proper SPDX-License-Identifier style

2018-03-10 Thread Masahiro Yamada
that document. [1] https://lkml.org/lkml/2017/11/25/133 Signed-off-by: Masahiro Yamada --- arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts | 16 +++- arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dts| 14 ++ arch/arm64/boot/dts/socionext/uniphier-ld11

[PATCH] ARM: dts: uniphier: use proper SPDX-License-Identifier style

2018-03-10 Thread Masahiro Yamada
that document. [1] https://lkml.org/lkml/2017/11/25/133 Signed-off-by: Masahiro Yamada --- arch/arm/boot/dts/uniphier-ld4-ref.dts | 14 ++ arch/arm/boot/dts/uniphier-ld4.dtsi | 14 ++ arch/arm/boot/dts/uniphier-ld6b-ref.dts | 14 ++ arc

[GIT PULL] Kbuild fixes for v4.16-rc5

2018-03-10 Thread Masahiro Yamada
+- 3 files changed, 10 insertions(+), 15 deletions(-) -- Best Regards Masahiro Yamada

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

2018-03-10 Thread Masahiro Yamada
Petr, Eugeniu, 2018-03-10 9:07 GMT+09:00 Eugeniu Rosca : > > It looks like expr_get_leftmost_symbol() has no more callers left and > could be removed with this patch? Thanks, I will send v3 with fixes pointed out. -- Best Regards Masahiro Yamada

[PATCH v3] kconfig: make unmet dependency warnings readable

2018-03-10 Thread Masahiro Yamada
B [=y] && (RALINK || COMPILE_TEST [=y]) - PHY_ROCKCHIP_PCIE [=y] && (ARCH_ROCKCHIP && OF [=y] || COMPILE_TEST [=y]) WARNING: unmet direct dependencies detected for OF_GPIO Depends on: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n] Selected by [y]: -

Re: [RFC PATCH v2 00/12] Rewrite asm-generic/bitops/{atomic,lock}.h and use on arm64

2018-03-11 Thread Masahiro Yamada
Hi Will, 2018-03-01 16:16 GMT+09:00 Masahiro Yamada : > 2018-02-27 0:04 GMT+09:00 Will Deacon : >> Hi everyone, >> >> This is version two of the RFC I previously posted here: >> >> https://www.spinics.net/lists/arm-kernel/msg634719.html >> >&

Re: [PATCH v3 0/2] kbuild: Fix corner caches with .cache.mk

2018-03-13 Thread Masahiro Yamada
10225437/ I do not know how to handle your patches since I am removing the addressed code for 4.17-rc1, which is comming in a month or so. If this is a fatal problem, we can queue it up only for 4.16, but I do not hear problem reports these days... > Changes in v3: > - Fix as per Masahiro

Re: [PATCH v3 5/5] linux/const.h: move BIT(_ULL) to linux/const.h for use in assembly

2018-03-13 Thread Masahiro Yamada
Hi Andrew, 2018-02-22 21:15 GMT+09:00 Masahiro Yamada : > Commit 2fc016c5bd8a ("linux/const.h: Add _BITUL() and _BITULL()") > introduced _BITUL() and _BITULL(). Its git-log says the difference > from the already existing BIT() are: > > 1. The namespace is such that

Re: [PATCH 3/3] fixdep: do not ignore kconfig.h

2018-03-05 Thread Masahiro Yamada
) || > - str_ends_with(s, len, "include/linux/kconfig.h") || >str_ends_with(s, len, ".ver"); > } > > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html The series, applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] kbuild: remove command line interface LDFLAGS_MODULE from makefiles.txt

2018-03-05 Thread Masahiro Yamada
2018-02-28 19:14 GMT+09:00 Masahiro Yamada : > Documentation/kbuild/makefiles.txt lists variables used in Makefile > whereas Documentation/kbuild/kbuild.txt describes user assignable > parameters given via environments or the command line. > > LDFLAGS_MODULE is a command line i

Re: [PATCH] arm64: dts: uniphier: add fixed regulators for audio codec

2018-03-05 Thread Masahiro Yamada
ator". > > Signed-off-by: Katsuhiro Suzuki Applied to linux-uniphier. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

2018-03-05 Thread Masahiro Yamada
(+To: Andrew) 2018-03-06 13:52 GMT+09:00 Ulf Magnusson : > On Sat, Feb 24, 2018 at 2:53 PM, Masahiro Yamada > wrote: >> 2018-02-23 10:30 GMT+09:00 Ulf Magnusson : >>> On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches wrote: >>>> On Fri, 2018-02-16 at 21:22 +0100,

Re: [PATCH v2 08/11] kconfig: unittest: test defconfig when two choices interact

2018-03-06 Thread Masahiro Yamada
2018-03-02 19:41 GMT+09:00 Ulf Magnusson : > On Fri, Mar 2, 2018 at 5:31 AM, Masahiro Yamada > wrote: >> Commit fbe98bb9ed3d ("kconfig: Fix defconfig when one choice menu >> selects options that another choice menu depends on") fixed defconfig >> when two choi

Re: [PATCH v2 09/11] kconfig: unittest: test randconfig for choice in choice

2018-03-06 Thread Masahiro Yamada
2018-03-03 18:34 GMT+09:00 Ulf Magnusson : > On Fri, Mar 2, 2018 at 10:29 PM, Luis R. Rodriguez wrote: >> >> >> On Fri, Mar 2, 2018, 3:14 AM Ulf Magnusson wrote: >>> >>> On Fri, Mar 2, 2018 at 5:31 AM, Masahiro Yamada >>> > This is compli

Re: [PATCH v3 2/2] kconfig: rename silentoldconfig to syncconfig

2018-03-06 Thread Masahiro Yamada
2018-03-01 15:34 GMT+09:00 Masahiro Yamada : > As commit cedd55d49dee ("kconfig: Remove silentoldconfig from help > and docs; fix kconfig/conf's help") mentioned, 'silentoldconfig' is a > historical misnomer. That commit removed it from help and docs since >

Re: [PATCH] kconfig: remove redundant streamline_config.pl prerequisite

2018-03-06 Thread Masahiro Yamada
2018-03-02 0:23 GMT+09:00 Ulf Magnusson : > On Thu, Mar 1, 2018 at 3:39 PM, Masahiro Yamada > wrote: >> 2018-03-01 20:18 GMT+09:00 Ulf Magnusson : >>> The local{yes,mod}config targets currently have streamline_config.pl as >>> a prerequisite. This is redundant, bec

[PATCH] kconfig: make unmet dependency warnings readable

2018-03-06 Thread Masahiro Yamada
ARCH_ROCKCHIP && OF [=y] || COMPILE_TEST [=y]) WARNING: Unmet direct dependencies detected for OF_GPIO Depends on: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n] Selected by [y]: - PINCTRL_MTK [=y] && PINCTRL [=y] && (ARCH_MEDIATEK || COMPILE_TEST [=y]) &

[PATCH v2] kconfig: make unmet dependency warnings readable

2018-03-06 Thread Masahiro Yamada
HIP && OF [=y] || COMPILE_TEST [=y]) WARNING: Unmet direct dependencies detected for OF_GPIO Depends on: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n] Selected by [y]: - PINCTRL_MTK [=y] && PINCTRL [=y] && (ARCH_MEDIATEK || COM

[PATCH] rtc: at91sam: add 'depends on HAS_IOMEM' to fix unmet dependency

2018-03-06 Thread Masahiro Yamada
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada --- Arnd Bergmann a

[PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency

2018-03-06 Thread Masahiro Yamada
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada --- Arnd Bergmann a

[PATCH] pinctrl: stm32: add 'depends on HAS_IOMEM' to fix unmet dependency

2018-03-06 Thread Masahiro Yamada
These configs select MFD_SYSCON, but do not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada --- Arnd Bergmann and I discus

[PATCH] phy: add 'depends on HAS_IOMEM' to fix unmet dependency

2018-03-06 Thread Masahiro Yamada
These configs select MFD_SYSCON, but do not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada --- Arnd Bergmann and I discus

[PATCH] clocksource: atmel-st: add 'depends on HAS_IOMEM' to fix unmet dependency

2018-03-06 Thread Masahiro Yamada
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada --- Arnd Bergmann a

Re: [PATCH v2 01/11] kbuild: define PYTHON2 and PYTHON3 variables instead of PYTHON

2018-03-06 Thread Masahiro Yamada
2018-03-07 2:16 GMT+09:00 Tony Luck : > On Thu, Mar 1, 2018 at 8:31 PM, Masahiro Yamada > wrote: >> arch/ia64/scripts/unwcheck.py is apparently written in Python 2, so >> it should be invoked by 'python2'. > > I pushed the patch from Corentin Labbe to update

Re: [PATCH v2] scripts/kconfig: cleanup symbol handling code

2018-03-25 Thread Masahiro Yamada
struct property *prop; > - char *p; > + char *env_val; > > sym = current_entry->sym; > sym->flags |= SYMBOL_AUTO; > for_all_properties(sym, prop, P_ENV) { > sym2 = prop_get_symbol(prop); > - if (strcmp(sym2->name, env)) > + if (strcmp(sym2->name, env_key)) > menu_warn(current_entry, "redefining environment > symbol from %s", > sym2->name); > return; > } > > prop = prop_alloc(P_ENV, sym); > - prop->expr = expr_alloc_symbol(sym_lookup(env, SYMBOL_CONST)); > + prop->expr = expr_alloc_symbol(sym_lookup(env_key, SYMBOL_CONST)); > > sym_env_list = expr_alloc_one(E_LIST, sym_env_list); > sym_env_list->right.sym = sym; > + env_val = getenv(env_key); > > - p = getenv(env); > - if (p) > - sym_add_default(sym, p); > - else > - menu_warn(current_entry, "environment variable %s undefined", > env); > + if (likely(env_val)) { > + sym_add_default(sym, env_val); > + return; > + } > + > + menu_warn(current_entry, "environment variable %s undefined", > env_key); > } > -- > 2.16.2 -- Best Regards Masahiro Yamada

Re: [RFC PATCH 0/3] Salted build ids via linker sections

2018-03-26 Thread Masahiro Yamada
++ > scripts/link-vmlinux.sh | 3 ++- > 7 files changed, 42 insertions(+), 4 deletions(-) > create mode 100644 scripts/build-id.lds.S > create mode 100755 scripts/gencomment > > -- > 2.16.2 > -- Best Regards Masahiro Yamada

Re: [PATCH 2/1] Kbuild: fix # escaping in .cmd files for future Make

2018-03-26 Thread Masahiro Yamada
O >$@ $(obj)/foo.txt: FORCE $(call if_changed,foo) | current | \$(pound) | \\$(pound) | $$(pound) -- test code1 |OK |OK | NG | OK test code2 |NG |NG | OK | OK test code3 |OK |OK | NG | OK test code4 |NG |NG | OK | OK -- Best Regards Masahiro Yamada

<    1   2   3   4   5   6   7   8   9   10   >