Am 2014-06-17 21:46, schrieb David Rientjes:
> On Tue, 17 Jun 2014, Martin Kepplinger wrote:
>
>> The one-bit bitfields are assigned true (1) or false (0) and checked
>> for them respectively. While it should work either way and -1 is true
>> as well it is more clear to
Am 2014-06-23 03:10, schrieb Zhang, Rui:
>
>
>> -Original Message-----
>> From: Martin Kepplinger [mailto:mart...@posteo.de]
>> Sent: Sunday, June 22, 2014 10:25 PM
>> To: Zhang, Rui
>> Cc: r...@rjwysocki.net; l...@kernel.org; linux-a...@vger.kernel.
Am 2014-06-23 15:14, schrieb Zhang Rui:
> On Mon, 2014-06-23 at 14:22 +0200, Martin Kepplinger wrote:
>> Am 2014-06-23 03:10, schrieb Zhang, Rui:
>>>
>>>
>>>> -Original Message-
>>>> From: Martin Kepplinger [mailto:mart...@posteo.de]
>&
trols work as well.
Signed-off-by: Martin Kepplinger
Tested-by: Martin Kepplinger
---
drivers/acpi/video.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f8bc5a7..acb0670 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/vi
remove a typedef that is not even really used.
Signed-off-by: Martin Kepplinger
---
builds in next-20140905.
drivers/staging/rtl8192u/r8192U_core.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
at it.
Signed-off-by: Martin Kepplinger
---
Yes, there were changes in the meantime. This applies to -next20140808
and builds. thanks.
drivers/staging/rtl8192u/r8192U_core.c | 757 +---
1 file changed, 408 insertions(+), 349 deletions(-)
diff --git a/drivers/staging/rtl
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
I don't have the device but this builds.
I think this is ok when it gets reviewed.
applies to -next20140801
drivers/staging/media/as102/as102_drv.c |
Use tabs for code indent and use the kernel coding style.
Signed-off-by: Martin Kepplinger
---
applies to -next20140801
drivers/staging/rtl8192ee/regd.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/regd.c b/drivers/staging/rtl8192ee/regd.c
Am 2014-08-03 18:27, schrieb Joe Perches:
> On Sun, 2014-08-03 at 18:06 +0200, Martin Kepplinger wrote:
>> Use tabs for code indent and use the kernel coding style.
> []
>> diff --git a/drivers/staging/rtl8192ee/regd.c
>> b/drivers/staging/rtl8192ee/regd.c
> []
>>
ff-by: Martin Kepplinger
---
This changes only a part of rtl8192u's comments. When this is desired,
one can go about and change the rest of the driver.
build-tested. applies to -next20140801
drivers/staging/rtl8192u/r8180_93cx6.c | 12 +-
drivers/staging/rtl8192u/r8192U_cor
This fixes sparse errors where 0 is used for non-integers.
Signed-off-by: Martin Kepplinger
---
applies to -next20140802
drivers/staging/lustre/lnet/lnet/api-ni.c |4 +-
drivers/staging/lustre/lustre/fld/fld_request.c|2 +-
drivers/staging/lustre/lustre/llite/llite_lib.c
Use %llu for u64 and %u for int. Not the other way round.
Signed-off-by: Martin Kepplinger
---
applies to -next20140801
drivers/scsi/u14-34f.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 4e76fe8..d8dcf36
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
Thanks Dan. And since it continues to succeed if (dev == NULL),
differntiate if (dev) or not.
drivers/staging/media/as102/as102_drv.c | 15 +++---
drivers
remove dprintk() and replace it with dev_dbg() or pr_debug()
in order to use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
Thanks for looking at it. So this doesn't add anything and actually does
what it says. If I haven't understood what you meant, or if I sho
r's open() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger
---
drivers/char/misc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ffa97d2..205ad4c 100644
--- a/driver
ux-kernel&m=141376535132316&w=2
Bonus: one could look for drivers that _do_ implement open()
and do the (in any case) redundant work themselves.
Martin Kepplinger (3):
misc: always assign miscdevice to file->private_data in open()
fbdev: pxa3xx-gcu: remove redundant implementation of open()
the miscdevice core now does the work in any case.
Signed-off-by: Martin Kepplinger
---
drivers/video/fbdev/pxa3xx-gcu.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4df3657..7678a94 100644
--- a
an open syscall now assignes file->private_data to a pointer to the
miscdevice structure. This reminds driver developers not to duplicate
code if they need this.
Signed-off-by: Martin Kepplinger
---
drivers/char/misc.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --gi
Am 2015-07-06 um 14:34 schrieb Martin Kepplinger:
> This is version 4 of the mma8452 driver improvements. This version removes
> one patch that changed the iio event type for existing users. It can be
> dealt with seperately and this series applies without it.
>
> Also, chang
Am 2015-07-28 um 11:28 schrieb Mark Rutland:
> On Tue, Jul 28, 2015 at 10:11:29AM +0100, Martin Kepplinger wrote:
>>
>>
>> On 2015-07-27 19:33, Mark Rutland wrote:
>>> On Mon, Jul 27, 2015 at 03:37:48PM +0100, Martin Kepplinger wrote:
>>>> Am 2015-07-27 u
ything
for existing users.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
.../devicetree/bindings/iio/accel/mma8452.txt| 4
drivers/iio/accel/mma8452.c | 20 +---
2 files changed, 17 insertions(+), 7 deletions(-)
di
Before I go away for holidays, this is version 5 of the mma8452 driver
improvements. This version removes the unnessasary DRIVER_NAME define and
improves the DT property "use_int2" to be extendible for any future additions
to the driver.
This is based on today's -next.
These changes add support
This adds support for the 10 bit version if Freescale's accelerometers
of this series. The datasheet is available at Freescale's website:
http://cache.freescale.com/files/sensors/doc/data_sheet/MMA8453Q.pdf
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
d
This adds a struct mma_chip_info to hold data that will remain specific to
the chip in use. It is provided during probe() and linked in
struct of_device_id.
Also this suggests that the driver is called "mma8452" and now handles the
MMA8452Q device, but is not limited to it.
Signed-off-
As we support more chips now, add a binding document and remove it from
i2c trivial-devices.txt list.
The binding document is further extended in a later patch of this series.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
.../devicetree/bindings/i2c/trivial
This doesn't actually change anything since the core names the sysfs folder
for the iio event attributes "events" anyways. It only leaves the job to the
core.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 1 -
1 file chan
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 5a8c738..dc66815 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio
;s
website:
http://cache.freescale.com/files/sensors/doc/data_sheet/MMA8652FC.pdf
http://cache.freescale.com/files/sensors/doc/data_sheet/MMA8653FC.pdf
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/Kconfig | 2 +-
drivers/iio/accel/mma8
occurs on positive and negative values
when the magnitude crosses the threshold value.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 45 -
1 file changed, 36 insertions(+), 9 deletions(-)
diff --git
Am 2015-07-27 um 16:23 schrieb Mark Rutland:
> On Mon, Jul 27, 2015 at 03:08:15PM +0100, Martin Kepplinger wrote:
>> For the devices supported by the mma8452 driver, two interrupt pins are
>> available to route the interrupt signals to. By default INT1 is assumed.
>>
>
ything
for existing users.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
PATCH v2 of the series' 5th version. DT cleanup and a little clearer
documentation.
.../devicetree/bindings/iio/accel/mma8452.txt| 3 +++
drivers/iio/accel/mma8452.c
As we support more chips now, add a binding document and remove it from
i2c trivial-devices.txt list.
The binding document is further extended in a later patch of this series.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
builds a nice list of supported compatible
On 2015-07-27 19:33, Mark Rutland wrote:
> On Mon, Jul 27, 2015 at 03:37:48PM +0100, Martin Kepplinger wrote:
>> Am 2015-07-27 um 16:23 schrieb Mark Rutland:
>>> On Mon, Jul 27, 2015 at 03:08:15PM +0100, Martin Kepplinger wrote:
>>>> For the devices supported by the
Am 2016-04-29 um 14:19 schrieb Constantin Musca:
> Minimal implementation of an IIO driver for the Freescale
> MMA7660FC 3-axis accelerometer. Datasheet:
> http://www.freescale.com.cn/files/sensors/doc/data_sheet/MMA7660FC.pdf
it's nxp.com now, which would probably be valid for a longer time.
The
Am 2016-04-25 um 14:08 schrieb Martin Kepplinger:
> This adds the following sysfs files according to the iio ABI:
>
> -rw-r--r--4096 in_accel_oversampling_ratio
> -r--r--r--4096 in_accel_oversampling_ratio_available
>
> Internally, the device knows about 4 differen
Am 2016-05-11 um 10:47 schrieb zengzhao...@163.com:
> From: Zhaoxiu Zeng
>
> Add generic parity functions, adapted from
> "https://graphics.stanford.edu/~seander/bithacks.html#ParityParallel";.
>
> The function parityN returns whether an odd or even number of bits are on
> in a N-bit word.
>
>
It's *really* fun to use as an input tablet though! So let's support this
for everybody.
Signed-off-by: Martin Kepplinger
---
Any advice or objections?
I'm sure this would be used if available like this. It was a quite popular
device.
I use it for quite some time and like it a lot.
Am 2016-05-23 um 14:26 schrieb Oliver Neukum:
> On Mon, 2016-05-23 at 13:39 +0200, Martin Kepplinger wrote:
>
>> It's *really* fun to use as an input tablet though! So let's support this
>> for everybody.
>
> Hi,
>
> I am afraid there are a few issues.
Am 2016-05-23 um 15:00 schrieb Oliver Neukum:
> On Mon, 2016-05-23 at 14:43 +0200, Martin Kepplinger wrote:
>> Am 2016-05-23 um 14:26 schrieb Oliver Neukum:
>>> On Mon, 2016-05-23 at 13:39 +0200, Martin Kepplinger wrote:
>>>
>>>> It's *really* fun to use
It's *really* fun to use as an input tablet though! So let's support this
for everybody.
Signed-off-by: Martin Kepplinger
---
Any thoughts on this yet? I'd be happy for review. I like it and I'm sure
others would use this too, if available like this.
revision history
It's *really* fun to use as an input tablet though! So let's support this
for everybody.
There's no way to disable the device. When the pen is out of range, we just
don't get any URBs and don't do anything.
Like all other mouses or input tablets, we don't use r
Am 2016-05-26 um 02:29 schrieb Dmitry Torokhov:
> Hi Martin,
>
> On Wed, May 25, 2016 at 09:44:34AM +0200, Martin Kepplinger wrote:
>> This adds a driver for the Pegasus Notetaker Pen. When connected,
>> this uses the Pen as an input tablet.
>>
>> This dev
It's *really* fun to use as an input tablet though! So let's support this
for everybody.
There's no way to disable the device. When the pen is out of range, we just
don't get any URBs and don't do anything.
Like all other mouses or input tablets, we don't use runtime PM
support this
for everybody.
There's no way to disable the device. When the pen is out of range, we just
don't get any URBs and don't do anything.
Like all other mouses or input tablets, we don't use runtime PM.
Signed-off-by: Martin Kepplinger
---
This is *exactly* v5 again, only
Hi Dmitry,
Thanks again for your help! Only one comment below...
Am 2016-05-27 um 23:59 schrieb Dmitry Torokhov:
> Hi Martin,
>
>> +static void pegasus_parse_packet(struct pegasus *pegasus)
>> +{
>> +unsigned char *data = pegasus->data;
>> +struct input_dev *dev = pegasus->dev;
>> +
support this
for everybody.
There's no way to disable the device. When the pen is out of range, we just
don't get any URBs and don't do anything.
Like all other mouses or input tablets, we don't use runtime PM.
Signed-off-by: Martin Kepplinger
---
Again, all is tested
It's *really* fun to use as an input tablet though! So let's support this
for everybody.
Signed-off-by: Martin Kepplinger
---
drivers/input/tablet/Kconfig | 15 ++
drivers/input/tablet/Makefile| 1 +
drivers/input/tablet/pegasus_notetaker.c | 407 +++
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 38652e1..eb2b2c2 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel
in_accel_x_mag_falling_en
-rw-r--r--4096 Oct 23 08:45 in_accel_x_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_y_mag_falling_en
-rw-r--r--4096 Oct 23 08:45 in_accel_y_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_z_mag_falling_en
-rw-r--r--4096 Oct 23 08:45 in_accel_z_ma
Use the newly added enum that numbers x, y and z axis.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio
Am 2015-11-11 um 20:08 schrieb Lars-Peter Clausen:
> On 11/11/2015 07:38 PM, Martin Kepplinger wrote:
>> This adds freefall event detection to the supported devices. It adds the
>> in_accel_x&y&z_mag_falling_en iio event attribute, which activates
>> freefall mode
Am 2015-11-14 um 19:03 schrieb Jonathan Cameron:
> On 11/11/15 18:38, Martin Kepplinger wrote:
>> This adds freefall event detection to the supported devices. It adds
>> the in_accel_x&y&z_mag_falling_en iio event attribute, which activates
>> freefall mode.
>&g
Am 2015-12-12 um 16:34 schrieb Jonathan Cameron:
> On 08/12/15 16:21, Martin Kepplinger wrote:
>> This adds freefall event detection to the supported devices. It adds
>> the in_accel_x&y&z_mag_falling_en iio event attribute, which activates
>> freefall mode.
>&g
On 2015-12-15 07:04, Martin Kepplinger wrote:
> Am 2015-12-12 um 16:34 schrieb Jonathan Cameron:
>> On 08/12/15 16:21, Martin Kepplinger wrote:
>>> This adds freefall event detection to the supported devices. It adds
>>> the in_accel_x&y&z_mag_falling_en i
_accel_scale
-rw-r--r--4096 Oct 23 08:45 in_accel_x&y&z_mag_falling_en
-rw-r--r--4096 Oct 23 08:45 in_accel_x_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_y_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_z_mag_rising_en
Signed-off-by: Martin Kepplinger
Signed-
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 116a6e4..162bbef 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel
This gets rid of some magic numbers by adding an enum.
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b
This is v2 of cleanup and freefall detection for mma8452 devices.
[PATCH 1/3] iio: mma8452: remove unused register description
[PATCH 2/3] iio: mma8452: use enum for channel index
[PATCH 3/3] iio: mma8452: add freefall detection for Freescale's
If freefall mode (x&y&z falling event) is enabled, c
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
drivers/iio/accel/mma8452.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 116a6e4..162bbef 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel
_accel_scale
-rw-r--r--4096 Oct 23 08:45 in_accel_x&y&z_mag_falling_en
-rw-r--r--4096 Oct 23 08:45 in_accel_x_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_y_mag_rising_en
-rw-r--r--4096 Oct 23 08:45 in_accel_z_mag_rising_en
Signed-off-by: Martin Kepplinger
Signed-
Am 2015-07-19 um 15:47 schrieb Jonathan Cameron:
> On 06/07/15 13:34, Martin Kepplinger wrote:
>> For the devices supported by the mma8452 driver, two interrupt pins are
>> available to route the interrupt signals to. By default INT1 is assumed.
>>
>> This adds a simp
On 2015-07-20 10:38, Martin Fuzzey wrote:
> On 19/07/15 15:47, Jonathan Cameron wrote:
>> On 06/07/15 13:34, Martin Kepplinger wrote:
>>> For the devices supported by the mma8452 driver, two interrupt pins are
>>> available to route the interrupt signals to.
Am 2016-01-16 um 15:35 schrieb Martin Kepplinger:
> This adds freefall event detection to the supported devices. It adds
> the in_accel_x&y&z_mag_falling_en iio event attribute, which activates
> freefall mode.
>
> In freefall mode, the current acceleration magnitude (A
The following change:
788d441 ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling
breaks audio over HDMI on my snd_hda_intel laptop. It is the first bad
commit.
This was merged for -rc1 and isn't fixed until now, so I got nervous.
There are
no errors in the log that stand out. I'm
Am 2016-02-09 um 12:44 schrieb Takashi Iwai:
> On Tue, 09 Feb 2016 07:34:48 +0100,
> Martin Kepplinger wrote:
>>
>> The following change:
>>
>> 788d441 ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling
>>
>> breaks audio over HDMI on my
Am 2016-02-23 um 17:57 schrieb Takashi Iwai:
> On Mon, 22 Feb 2016 22:37:28 +0100,
> Martin Kepplinger wrote:
>>
>> Am 2016-02-22 um 20:10 schrieb Takashi Iwai:
>>> On Mon, 22 Feb 2016 19:58:18 +0100,
>>> Martin Kepplinger wrote:
>>>>
>>>&g
Am 2016-02-23 um 18:14 schrieb Ville Syrjälä:
> On Tue, Feb 23, 2016 at 05:57:40PM +0100, Takashi Iwai wrote:
>> On Mon, 22 Feb 2016 22:37:28 +0100,
>> Martin Kepplinger wrote:
>>>
>>> Am 2016-02-22 um 20:10 schrieb Takashi Iwai:
>>>> On Mon, 22 Fe
Am 2016-02-24 um 10:13 schrieb Takashi Iwai:
> On Wed, 24 Feb 2016 08:51:32 +0100,
> Takashi Iwai wrote:
>>
>> Since dig_port_map[] is used only for the audio callback, we can
>> assign it dynamically just before the callbacks.
>>
>> Could you try the patch below? (It's totally untested.)
now it'
The miscdevice core now sets file->private_data to the struct miscdevice
so don't fail when this is not NULL.
Reported-by: Thierry Reding
Signed-off-by: Martin Kepplinger
---
This is a question: what does this check provide and does overwriting
file->private_data make any differenc
The miscdevice core now sets file->private_data to the struct miscdevice
so don't fail when this is not NULL.
Signed-off-by: Martin Kepplinger
---
This is a question: what does this check provide and does overwriting
file->private_data make any difference?
Is miscdevice's open()
Am 2014-11-12 um 17:31 schrieb Martin Kepplinger:
> The miscdevice core now sets file->private_data to the struct miscdevice
> so don't fail when this is not NULL.
>
> Reported-by: Thierry Reding
> Signed-off-by: Martin Kepplinger
> ---
> This is a question: wha
Am 2014-11-12 um 18:59 schrieb Chris Mason:
> On Wed, Nov 12, 2014 at 11:38 AM, Martin Kepplinger
> wrote:
>> The miscdevice core now sets file->private_data to the struct miscdevice
>> so don't fail when this is not NULL.
>>
>> Signed-off-by: Martin Keppling
The miscdevice core now sets file->private_data to the struct miscdevice
so don't fail when this is not NULL.
Reported-by: Giedrius Statkevicius
Signed-off-by: Martin Kepplinger
---
sorry, I can't read ;) Is this a fix for your problem (instead of the first
patch)?
in case of fuse
Am 13. November 2014 10:40:38 MEZ, schrieb Miklos Szeredi :
>On Wed, Nov 12, 2014 at 5:31 PM, Martin Kepplinger
>wrote:
>> The miscdevice core now sets file->private_data to the struct
>miscdevice
>> so don't fail when this is not NULL.
>
>Does it? Look:
&
Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi :
>On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger
>wrote:
>
>> In this week's -next this should have changed. My SSD broke down so i
>have to delay further work for a few days, i'm sorry.
>
>Please
Am 2014-10-09 17:50, schrieb Greg KH:
> On Thu, Oct 09, 2014 at 03:10:21PM +0200, Martin Kepplinger wrote:
>> Am 2014-10-08 15:43, schrieb Greg KH:
>>> On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
>>>> As of now, a miscdevice driver has t
Am 2014-10-09 17:50, schrieb Greg KH:
> On Thu, Oct 09, 2014 at 03:10:21PM +0200, Martin Kepplinger wrote:
>> Am 2014-10-08 15:43, schrieb Greg KH:
>>> On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
>>>> As of now, a miscdevice driver has t
hi
Just a question for understanding: open() is not implemented in
lguest_user.c's miscdevice. The miscdevice core, in this case, does
_not_ set file->private_data on a user's open() call. Is open() called
by the user here? and do you here _depend_ on file->private_data being
NULL after open()? (c
if we depend on private_data being NULL in write() before initialize()
make sure it is NULL after open().
Signed-off-by: Martin Kepplinger
---
I'm not completely sure if this patch is needed and am still investigating.
What do you think? open() could be called by the user I guess.
r's open() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger
---
The mentioned warning is appearently unrelated here, and happens on mainline
v3.17 awell -.- sorry for the confusion.
This applies to 3.17 and is a call for review
the miscdevice core now does the work in any case.
Signed-off-by: Martin Kepplinger
---
drivers/video/fbdev/pxa3xx-gcu.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4df3657..7678a94 100644
--- a
Am 2014-10-19 02:31, schrieb Martin Kepplinger:
> if we depend on private_data being NULL in write() before initialize()
> make sure it is NULL after open().
>
> Signed-off-by: Martin Kepplinger
> ---
>
> I'm not completely sure if this patch is needed and am still in
r's open() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger
---
This is really only a question: Do I understand this correctly, and,
could this change then hurt any existing driver?
As a driver developer it took me a while to figure out
Am 2014-10-08 15:43, schrieb Greg KH:
> On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
>> As of now, a miscdevice driver has to provide an implementation of
>> the open() file operation if it wants to have misc_open() assign a
>> pointer to stru
This might prevent code duplication in the future.
Signed-off-by: Martin Kepplinger
---
This is a suggestion for a place to put this information. I think this
makes sense but there might be a more appropriate place elsewhere.
drivers/char/misc.c |4
1 file changed, 4 insertions
Am 3. Mai 2015 21:14:02 MESZ, schrieb Jonathan Cameron :
>On 30/04/15 15:36, Martin Kepplinger wrote:
>> Since we have deviceX, we don't need accelX. This has no users as of
>now, so
>> correcting this is no problem.
>>
>> Signed-off-by: Martin Kepplinger
&
Am 2015-05-04 um 13:24 schrieb Jani Nikula:
> On Mon, 04 May 2015, Martin Kepplinger wrote:
>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
>> -rc2. It works exactly *one* first time and every subsequent lid-closing
>> is ignored.
>>
So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
-rc2. It works exactly *one* first time and every subsequent lid-closing
is ignored.
Biscted and tested first bad commit:
14aa02449064541217836b9f3d3295e241d5ae9c
This pulls in i915 changes as well as ACPI changes. I don't k
Signed-off-by: Martin Kepplinger
---
I was so angry now, I had to write a change. Please keep things greppable and
save unnecessary questions and time this way.
drivers/acpi/battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi
From: Martin Kepplinger
The MMA8653FC is a low-power, three-axis, capacitive micromachined
accelerometer with 10 bits of resolution with flexible user-programmable
options.
Embedded interrupt functions enable overall power savings, by relieving the
host processor from continuously polling data
Signed-off-by: Martin Kepplinger
---
Documentation/ABI/testing/sysfs-bus-iio | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b/Documentation/ABI/testing/sysfs-bus-iio
index 9a70c31..74a3493 100644
--- a/Documentation/ABI/testing/sysfs
only *if* the driver has it's own open() routine and
fops-entry, see https://lkml.org/lkml/2014/12/4/939 and commit
94e4fe2cab3d43b3ba7c3f721743006a8c9d913a
In short: If we rely on file->private_data being NULL, we should ensure
it is NULL ourselves.
Signed-off-by: Martin Kepplinger
an open syscall now assignes file->private_data to a pointer to the
miscdevice structure. This reminds people not to duplicate code if
they want this and not to depend on it being NULL.
Signed-off-by: Martin Kepplinger
---
drivers/char/misc.c | 4 +++-
1 file changed, 3 insertions(+)
the misc core does this now in any case.
Signed-off-by: Martin Kepplinger
---
drivers/video/fbdev/pxa3xx-gcu.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 86bd457..5b69dec 100644
--- a/drivers/video
only *if* the driver has it's own open() routine and
fops-entry, see https://lkml.org/lkml/2014/12/4/939
In short: If we rely on file->private_data being NULL, we should ensure
it is NULL ourselves.
Signed-off-by: Martin Kepplinger
---
drivers/lguest/lguest_user.c | 8
1 file
I've been trying this a few months ago, ( https://lkml.org/lkml/2014/10/8/98 )
in a very bad attempt that (thankfully) failed.
I'm happy to see you trying this now and got the change in drivers/fuse
merged now. I've been running a kernel with this change for quite some time,
it's obviously fine.
We depend on private_data being NULL to record transaction ioctl start and end.
This allows the misc core's misc_open() to do whatever it wants.
Signed-off-by: Martin Kepplinger
---
fs/btrfs/super.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/fs/btrfs/super.c b/fs/
From: Martin Kepplinger
Signed-off-by: Martin Kepplinger
Signed-off-by: Christoph Muellner
---
.../testing/sysfs-bus-i2c-devices-fsl-mma8653fc| 36 +
.../devicetree/bindings/misc/fsl,mma8653fc.txt | 95 +++
MAINTAINERS| 6 +
drivers/input
From: Martin Kepplinger
The MMA8653FC is a low-power, three-axis, capacitive micromachined
accelerometer with 10 bits of resolution with flexible user-programmable
options.
Embedded interrupt functions enable overall power savings, by relieving the
host processor from continuously polling data
Am 2015-03-18 um 17:21 schrieb Alexander Stein:
> On Wednesday 18 March 2015 16:55:57, Martin Kepplinger wrote:
>> From: Martin Kepplinger
>>
>> The MMA8653FC is a low-power, three-axis, capacitive micromachined
>> accelerometer with 10 bits of resolution with
301 - 400 of 731 matches
Mail list logo
