Another nit below:
On Jul 27, 2013, at 12:32 PM, ethan.ker...@gmail.com wrote:
> Cleanup the -EINVAL return value handling and add warning message for invalid
> start,end,addr parameters.
>
> V2: Corrected code style and tested for Linux v 3.11-rc2
>
> Signed-off-by: ethan.zhao
> ---
> arch/x8
Ulrich Windl wrote:
So without partition the throughput is about twice as high! Why?
My first thought is that by starting at block 0 the accesses were aligned
with the flash block size of the device. By starting at a partition, the
accesses probably were not so aligned.
--
Mark Rustad,
at 12:58 AM, Lee Jones wrote:
If you do:
do {
int pos;
pos = pci_find_next_ext_capability(pdev, pos,
PCI_EXT_CAP_ID_DVSEC);
if (!pos)
break;
Then you can invoke pci_find_next_ext_capability() once, no?
Part of
Avoid W=2 nested-externs warning by moving the nested extern to
a normal extern. This eliminates that warning which is generated
for every inclusion of sched.h in a kernel build when W=2 is used.
This also removes a point of maintenance if the definition of
delayacct_on were ever to change.
Signed
Rickard,
On Jul 26, 2014, at 7:18 AM, Rickard Strandqvist
wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> crypto/rng.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/rng.c b/
Rickard,
On Jul 26, 2014, at 7:15 AM, Rickard Strandqvist
wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> crypto/crypto_user.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --g
Rickard,
On Jul 26, 2014, at 7:09 AM, Rickard Strandqvist
wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> crypto/ablkcipher.c |8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/
Rickard,
On Jul 26, 2014, at 2:50 PM, Rickard Strandqvist
wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
> And use the sizeof on the to string rather than the from string.
>
> Signed-off-by: Rickard Strandqvist
> ---
> arch/x86/ia32/ia32_aout.c |2 +-
>
On Aug 9, 2014, at 4:40 PM, Rickard Strandqvist
wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/net/ethernet/myricom/myri10ge/myri10ge.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/myr
On Aug 9, 2014, at 4:45 PM, Rickard Strandqvist
wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/misc/ti-st/st_kim.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti
Brian,
On Aug 15, 2014, at 12:33 PM, Brian Norris wrote:
> Hi,
>
> On Fri, Aug 15, 2014 at 02:30:49AM -0700, Jeff Kirsher wrote:
>> Funny that you bring this up because I have ~60 patches in my queue to
>> resolve several thousand of these warnings. Half of the patches
>> actually resolve warn
On Aug 15, 2014, at 9:34 PM, Brian Norris wrote:
> Hi Mark,
>
> (BTW, your mailer is creating some pretty long, unwrapped lines. I've
> rewrapped them when quoting below.)
Sorry about that. I'll try to remember to deal with it on my end.
> On Fri, Aug 15, 2014 at
On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist
wrote:
> Changed from using strncpy to strlcpy to simplify the code
Actually you changed from using strncat to strlcat.
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/char/hw_random/core.c | 12
> 1 file changed, 4 insertion
Jarod Wilson wrote:
On Fri, May 06, 2016 at 11:43:17PM +, Rustad, Mark D wrote:
Denys Vlasenko wrote:
Users report that under VMWare, er32(TIMINCA) returns zero.
This causes division by zero at init time as follows:
==>incvalue = er32(TIMINCA) & E1000_TIMINCA_INCVALUE_MASK;
On Dec 1, 2014, at 3:12 AM, SF Markus Elfring
wrote:
> Hello,
>
> Would you like to know how many named function parameters are used in the
> source files?
>
> How do you think about to try the following semantic query approach out a bit
> more?
>
> @initialize:python@
> @@
> import sys
> i
On Feb 8, 2019, at 2:54 AM, Greg KH wrote:
diff --git a/Documentation/networking/ip-sysctl.txt
b/Documentation/networking/ip-sysctl.txt
index 2ea4c45cf1c8..7c229f59016f 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -112,14 +112,11 @@ min_a
On Feb 9, 2019, at 12:13 AM, Greg KH wrote:
On Fri, Feb 08, 2019 at 08:44:32PM -0800, Mark D Rustad wrote:
On Feb 8, 2019, at 2:54 AM, Greg KH wrote:
diff --git a/Documentation/networking/ip-sysctl.txt
b/Documentation/networking/ip-sysctl.txt
index 2ea4c45cf1c8..7c229f59016f 100644
--- a
> On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote:
>
> Drop static on a local variable, when the variable is initialized before
> any possible use. Thus, the static has no benefit.
I think in this case the use relies on the structure continuing to exist, so a
stack object is not an acceptable
> On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote:
>
> Drop static on a local variable, when the variable is initialized before
> any possible use. Thus, the static has no benefit.
I think this is in error like the other one. I believe that the irq_chip
structure needs a persistent lifetime.
> On Jul 15, 2017, at 1:59 PM, Julia Lawall wrote:
>
> On Sat, 15 Jul 2017, Mark D Rustad wrote:
>
>>
>>> On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote:
>>>
>>> Drop static on a local variable, when the variable is initialized before
>>&
> On Feb 11, 2018, at 2:59 AM, Adam Borowski wrote:
>
>> Does Debian make it easy to upgrade to a 64-bit kernel if you have a
>> 32-bit install?
>
> Quite easy, yeah. Crossgrading userspace is not for the faint of the heart,
> but changing just the kernel is fine.
ISTR that iscsi doesn't work
> On Feb 25, 2018, at 7:20 AM, Yan Vugenfirer wrote:
>
> Small mistake in the commit message. Red Hat (Qumranet) vendor ID is 1af4,
> virtio-net device ID is 1041.
> Should be:
> PF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 15fe
> VF: vendor: 1af4 device: 1041 subvendor: 8086 subdevi
Jonathan Corbet wrote:
On Mon, 25 Jul 2016 14:29:06 +0200
Jean Delvare wrote:
Chapter 7 (Centralized exiting of functions) of the coding style
documentation is unclear at times, and lacks some information (such
as the possibility to indent labels with a single space.) Clarify and
complete it
23 matches
Mail list logo
