Just a cleanup, not functional changes.
Signed-off-by: Marcos Paulo de Souza
---
Just compile test. Please double check.
drivers/video/jz4740_fb.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
index de36693
Hi guys,
This patchset is just a cleanup using devm_* functions. They were
tested in Dingoo A320 for two days, without any problems.
I hope you enjoy :)
Marcos Paulo de Souza (4):
Use devm_kzalloc instead of kzalloc/kfree
Use devm_* for reques_mem_region and ioremap
Use devm_request_irq
This don't change the rationale, just a cleanup.
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 72f6335..9d
This does not chnange the rationale, just a cleanup
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 8dbc7bf..72f6335
With this we can remove a lot of checks.
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 9d9b2a8
This commit simplifies the exit of probe function, by returning
directly when it don't need to release any resources.
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/
The third patch about irqs sent before was droped. This will
be reworked in the next patches.
I hope you enjoy :)
Marcos Paulo de Souza (2):
drivers: power: jz4740-battery: Use devm_kzalloc instead of
kzalloc/kfree
drivers: power: jz4740_battery: Use
Signed-off-by: Marcos Paulo de Souza
Acked-by: Lars-Peter Clausen
---
No changes from v1.
drivers/power/jz4740-battery.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 8dbc7bf..59900c6
And remove all checks abvout request_mem_region and ioremap.
This is just a cleanup. Not functional changes here.
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 23 +--
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/drivers/power
devm_ioremap_nocache.
Marcos Paulo de Souza (2):
drivers/power/jz4740-battery.c: Use devm_kzalloc
drivers/power/jz4740-battery.c: Use devm_request_and_ioremap
drivers/power/jz4740-battery.c | 41
1 file changed, 8 insertions(+), 33 deletions
This is just a cleanup.
Acked-by: Lars-Peter Clausen
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 8dbc7bf
No functional changes. Just a cleanup.
Signed-off-by: Marcos Paulo de Souza
---
drivers/power/jz4740-battery.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 59900c6
patches looks like OK.
This patchset is based in staging-next.
Thanks guys!
Marcos Paulo de Souza (3):
staging: bcm: Remove code that will never execute
staging: bcm: Remove all commented macros
staging: bcm: Misc.c: Remove unused macros
drivers/staging
This patch removes all references of "if 0" blocks in the bcm drivers.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/Misc.c | 63
1 file changed, 63 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/
All these macros are commented, and can be removed.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/CmHost.c |1 -
drivers/staging/bcm/Debug.h |5 -
drivers/staging/bcm/Macros.h |1 -
drivers/staging/bcm/PHSDefines.h |1 -
4 files changed, 8
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/Misc.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index d7c662d
it :)
Marcos Paulo de Souza (5):
staging: csr: Remove dead code
staging: csr: csr_util.h: Remove commented macros
staging: csr: netdev.c: Remove unused macros
staging: csr: unifi_sme.c: Remove unused macros
staging: csr: Remove unused macros
drivers/staging/csr/csr_util.h
All this code is dead, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/monitor.c | 57
drivers/staging/csr/unifi_native.h | 19
2 files changed, 76 deletions(-)
diff --git a/drivers/staging/csr/monitor.c b
These macros are not used, so we can remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/netdev.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/csr/netdev.c b/drivers/staging/csr/netdev.c
index cf19f11..55149df 100644
--- a/drivers/staging/csr
All these macros are commented, so we can removed it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/csr_util.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/csr/csr_util.h b/drivers/staging/csr/csr_util.h
index ce39c7e..5cd6cb4 100644
--- a/drivers
These macros are not used, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/unifi_sme.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/csr/unifi_sme.c b/drivers/staging/csr/unifi_sme.c
index 6e7cbbf..5ad1d5f 100644
--- a/drivers/staging/csr
These macros are not used, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/csr_wifi_hip_card_sdio.c |3 ---
drivers/staging/csr/drv.c|1 -
drivers/staging/csr/firmware.c |1 -
drivers/staging/csr/mlme.c
This patch removes all references of "if 0" blocks in the sbr-2t3e3.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/sbe-2t3e3/2t3e3.h|3 --
drivers/staging/sbe-2t3e3/cpld.c | 15 -
drivers/staging/sbe-2t3e3/ctrl.c | 19 +++
drivers/staging
This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/sbe-2t3e3/2t3e3.h|3 --
drivers/staging/sbe-2t3e3/cpld.c | 15 -
drivers/staging/sbe-2t3e3/ctrl.c | 19 +++
drive
nyone could test theses
changes.
All the changes were based in staging-next tree.
Comments are welcome!
Marcos Paulo de Souza (5):
staging: vt6656: desc.h: Remove commented macros and useless comments
staging: vt6656: hostap.c: Remove unused macros and some useless
comments
staging: v
The commented macros are reported by forgotten-macros
tool(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6656/desc.h | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/vt6656/desc.h b/drivers
The unused macros were reporteds by forgotten-macros
tool(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6656/hostap.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6656/hostap.c | 43 ---
1 file changed, 43 deletions(-)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c
index f578095..682002a 100644
--- a/drivers/staging/vt6656
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6656/80211hdr.h |2 --
drivers/staging/vt6656/bssdb.h|2 --
drivers/staging/vt6656/card.h |1 -
drivers/staging
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6656/card.c|1 -
drivers/staging/vt6656/channel.c |2 --
drivers/staging/vt6656/rxtx.c|2 --
3 files changed, 5
enjoy :)
Marcos Paulo de Souza (6):
staging: vt6655: Remove all "if 0" blocks from driver
staging: vt6655: mac.h: Remove all commented macros
staging: vt6655: rf.c: Remove all unused macros
staging: vt6655: baseband.h: Remove all unused macros
staging: vt6655: Remove all commented m
This commit removes code that will never be executed by vt6655 driver.
Was the forgotten-macros tool(https://github.com/marcosps/forgotten_macros)
who reported these blocks for us.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/device_main.c | 33
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/mac.h | 24
1 file changed, 24 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging
These macros were reported by forgotte-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/rf.c | 36
1 file changed, 36 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/baseband.h | 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.h
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/80211hdr.h|2 --
drivers/staging/vt6655/baseband.c|2 --
drivers/staging/vt6655/bssdb.c |1 -
drivers
All these macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/vt6655/hostap.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655
there is something that needs more polishment.
Thanks!
Marcos Paulo de Souza (2):
input/serio/i8042.c: Skipt selftest on ASUS laptops
kernel-parameters: Update i8042.reset parameter documentation
Documentation/kernel-parameters.txt | 7 ++-
drivers/input/serio/i8042-x86ia64io.h | 94
Signed-off-by: Marcos Paulo de Souza
---
Documentation/kernel-parameters.txt | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/kernel-parameters.txt
b/Documentation/kernel-parameters.txt
index a4f4d69..5ee70bd 100644
--- a/Documentation/kernel
gzilla.kernel.org/show_bug.cgi?id=107971)
Signed-off-by: Marcos Paulo de Souza
---
drivers/input/serio/i8042-x86ia64io.h | 94 ++-
drivers/input/serio/i8042.c | 39 ---
2 files changed, 125 insertions(+), 8 deletions(-)
diff --git a/drivers
Signed-off-by: Marcos Paulo de Souza
---
Documentation/kernel-parameters.txt | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/kernel-parameters.txt
b/Documentation/kernel-parameters.txt
index 82b42c9..24dd5cc 100644
--- a/Documentation/kernel
Elantech Touchpad dies after resume from suspend"
(https://bugzilla.kernel.org/show_bug.cgi?id=107971)
Signed-off-by: Marcos Paulo de Souza
---
drivers/input/serio/i8042-x86ia64io.h | 70 ++-
drivers/input/serio/i8042.c | 38 ---
2 f
Hi guys,
second version of the patch, addressing comments of Dmitry.
Changes since v1:
Use reset parameter, instead of adding reset_mode parameter.
Change reset parameter from bool to unsigned int.
Marcos Paulo de Souza (2):
input/serio/i8042.c: Skipt selftest on some ASUS laptops
kernel
All other places that deals with namespaces have an explanation of why
the restriction is there. The description added in this commit was based
in e66eded8309eb.
Signed-off-by: Marcos Paulo de Souza
---
kernel/fork.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/fork.c b/kernel
Instead of just using plain '1', as it improves readability.
Signed-off-by: Marcos Paulo de Souza
---
include/linux/blk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 1dcf652ba0aa..905c666a0101 10
bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing
the returned data into a new variable.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/md.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index fc488cb30a94
: Cannot open file ./block/blk-tag.c
So remove blk-tag.c traces from kernel-api.rst file to silence these
warnings.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/core-api/kernel-api.rst | 6 --
1 file changed, 6 deletions(-)
diff --git a/Documentation/core-api/kernel-api.rst
b
Patch sent by mistake. The commit message should be:
"Docs/kernel-api.rst: Remove blk-tag.c reference"
Thanks,
On Tue, Jan 01, 2019 at 10:40:14PM -0200, Marcos Paulo de Souza wrote:
> After 7ca01926463a, legacy rq tagging was removed, so block/blk-tag.c
> does not exists anymore.
kas Hruska
Reviewed-by: Marcos Paulo de Souza
> ---
> MAINTAINERS | 1 +
> include/uapi/linux/livepatch.h | 15 +++
> kernel/livepatch/core.c | 5 +++--
> 3 files changed, 19 insertions(+), 2 deletions(-)
> create mode 100644 includ
> + *
> > + */
> > +
> > +#define SHN_LIVEPATCH 0xff20
> > +#define SHF_RELA_LIVEPATCH 0x0010
> > +#define MODULE_NAME_LEN(64 - sizeof(GElf_Addr))
> > +#define WARN(format, ...) \
> > + fprintf(stderr, "klp-convert: " format "\n",
> > ##__VA_ARGS__)
> > +
> > +struct sympos {
> > + char *symbol_name;
> > + char *object_name;
> > + char *loading_obj_name;
> > + int pos;
> > +};
>
> It seems that this structure is not longer used.
>
> > +/*
> > + * klp-convert uses macros and structures defined in the linux
> > sources
> > + * package (see include/uapi/linux/livepatch.h). To prevent the
> > + * dependency when building locally, they are defined below. Also
> > notice
> > + * that these should match the definitions from the targeted
> > kernel.
> > + */
> > +
> > +#define KLP_RELA_PREFIX".klp.rela."
> > +#define KLP_SYM_RELA_PREFIX".klp.sym.rela."
> > +#define KLP_SYM_PREFIX ".klp.sym."
> > +
> > +#ifndef __packed
> > +#define __packed __attribute__((packed))
> > +#endif
> > +
> > +struct klp_module_reloc {
> > + union {
> > + void *sym;
> > + uint64_t sym64; /* Force 64-bit width */
> > + };
> > + uint32_t sympos;
> > +} __packed;
>
> And this one as well.
>
> I do not see any other obvious problem. And it seems to work
> at least for the later added sample module.
I agree with Petr in all his other comments. With the comments
addressed, you can add:
Reviewed-by: Marcos Paulo de Souza
>
> Best Regards,
> Petr
gt; Signed-off-by: Lukas Hruska
Reviewed-by: Marcos Paulo de Souza
(The patch currently conflicts with Linus tree on Makefile and
modpost.c, but nothing to worry, AFAICS)
> ---
> .gitignore | 1 +
> Makefile | 10 ++
> scripts/Makefile.modf
On Mon, 2023-11-06 at 17:25 +0100, Lukas Hruska wrote:
> Add a section to Documentation/livepatch/module-elf-format.rst
> describing how klp-convert works for fixing relocations.
>
> Signed-off-by: Lukas Hruska
Reviewed-by: Marcos Paulo de Souza
> ---
> Documentation/li
On Mon, 6 Nov 2023 17:25:08 +0100 Lukas Hruska wrote:
> Summary
> ---
>
> This is a significantly simplified version of the original klp-convert tool.
> The klp-convert code has never got a proper review and also clean ups
> were not easy. The last version was v7, see
> https://lore.kerne
st
> file to warn readers.
>
> Suggested-by: Josh Poimboeuf
> Signed-off-by: Joe Lawrence
> ---
> samples/livepatch/README.rst | 15 +++
> 1 file changed, 15 insertions(+)
> create mode 100644 samples/livepatch/README.rst
Acked-by: Marcos Paulo de Souza
>
&
to be
> resolved by this tool
> - klp-convert: code simplification
> - selftests: add selftest livepatching function using an external symbol
Thanks for sending this new version Lukas! It currently fails to apply on
current Linux master, but the conflict is very simple to address (attache
to/aesni-intel_glue.c:682:12) [REMOVED] [edges: 4]
> constprop: gcmaes_crypt_by_sg.constprop.13/4182
> (arch/x86/crypto/aesni-intel_glue.c:682:12)
>
> Affected functions: 3
> scatterwalk_unmap.isra.8/4117 (./include/crypto/scatterwalk.h:59:20)
> [REMOVED]
> gcmaes_crypt_by_sg/4019 (arch/x86/crypto/aesni-intel_glue.c:682:12)
> [REMOVED]
> gcmaes_crypt_by_sg.constprop.13/4182
> (arch/x86/crypto/aesni-intel_glue.c:682:12)
>
>
>
> The rest looks great. Thanks a lot, Joe, for putting it together.
I think that we should start provinding a "Livepatch creation how-to", something
similar, but for now I believe that some documentation is better than no
documentation. This document can evolve to reach such point in the future, but
for now, with Miroslav suggestions applied:
Acked-by: Marcos Paulo de Souza
>
> Miroslav
This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v2-v1:
Just fix the typo sbr-2t3e3 for sbe-2t3e3.
Greg, here is the update patch with the comments in the right place.
drivers/staging/sbe-2t3
Describing better what the function does, what the arguments are meant for, and
what SQ stands for.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Change "SQ" to "only one hw_queue (SQ)" in the function signature
documentation (suggested by Chaitan
From: Marcos Paulo de Souza
[BUG]
After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one
block group item"), cache->length is being assigned after calling
btrfs_create_block_group_cache. This causes a problem since
set_free_space_tree_thresholds is calculate t
'i8042_dmi_noselftest_table[0].matches')
>
> Add the missing separator between the two.
Oops, my bad...
Thanks for fixing it Arnd.
Reviewed-by: Marcos Paulo de Souza
>
> Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to
> noselftest list")
> Sig
From: Marcos Paulo de Souza
Signed-off-by: Marcos Paulo de Souza
Cc: Dmitry Torokhov
Cc: Hans de Goede
Cc: Jiri Kosina
Cc: Tom Gundersen
Cc: Peter Hutterer
Cc: linux-in...@vger.kernel.org
Cc: sta...@vger.kernel.org
---
drivers/input/serio/i8042-x86ia64io.h | 9 +
1 file changed, 9
The Notes section of the comment was removed, because now
blk_release_queue can only be executed from blk_cleanup_queue (being
called when the q->kobj reaches zero), and also blk_init_queue was removed
in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Ty
Hi,
Since 5.0.0-rc4 I vefiried that my ASUS laptop cannot turn the screen of
anymore. There were several commits in 5.0 merge window touching this
functionality like:
71b12beaf12f platform/x86: asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan
codes
b3f2f3799a97 platform/x86: asus-nb-wmi: Map
On 2/10/19 9:45 PM, Andy Shevchenko wrote:
> On Sun, Feb 10, 2019 at 9:24 PM Marcos Paulo de Souza
> wrote:
>>
>> Hi,
>>
>> Since 5.0.0-rc4 I vefiried that my ASUS laptop
>
> Can you be more specific, what model, BIOS version, etc (also would be
> ni
Hello João,
On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
> Hello Marcos,
>
> On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza
> wrote:
>>
>>
>>
>> On 2/10/19 9:45 PM, Andy Shevchenko wrote:
>>> On Sun, Feb 10, 2019 at 9:24 PM M
Hi Dmitry,
On 2/18/19 5:15 PM, Dmitry Torokhov wrote:
On Mon, Feb 18, 2019 at 03:21:10PM +0100, Rodrigo Rivas Costa wrote:
On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote:
- if (!wait_for_completion_timeout(&request->done, 30 * HZ)) {
+
Ping :)
On 1/25/19 1:50 AM, Bart Van Assche wrote:
> On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote:
>> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
>> a newly created function called blk_exit_queue, including the call of
>> blkcg_exit_
Ping :)
On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote:
> The Notes section of the comment was removed, because now
> blk_release_queue can only be executed from blk_cleanup_queue (being
> called when the q->kobj reaches zero), and also blk_init_queue was removed
> in a1ce35fa49
blk_init_queue was removed in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
There are more two references in Documentation/block/biodoc.txt, but maybe that
file needs a rewrite in rst anyway?
block/blk-sysfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
HI Jeans,
On 1/15/19 1:54 AM, Jens Axboe wrote:
> On 1/14/19 8:06 PM, Marcos Paulo de Souza wrote:
>> blk_init_queue was removed in a1ce35fa4985.
>
> Honestly, most of that comment is wrong anyway. Since this isn't
> a visible API, I'd just kill the comment complete
Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
a newly created function called blk_exit_queue, including the call of
blkcg_exit_queue. So, adjust the documenation according.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion
These definitions are being moved to raid1-10.c.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid1-10.c | 25 +
drivers/md/raid1.c| 29 ++---
drivers/md/raid10.c | 27 +--
3 files changed, 28 insertions(+), 53
Commit 0c35bd4723e4a39ba2da4c13a22cb97986ee10c8
("md: fix problems with freeing private data after ->run failure")
removed the check for the result of md_integrity_register, so we don't
need to store it anymore, so return it directly.
Signed-off-by: Marcos Paulo de Souza
---
ret variable is only used in a specific situation, so make it local
instead of global.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index e72255464c09..b28dbb797f76
ks
Marcos Paulo de Souza (5):
md cleanup
raid1-10: Unify r{1,10}bio_pool_free
raid0: Remove return statement from void function
md: raid0: Return md_integrity_register result directly
md: raid0: Make ret local in raid0_run
drivers/md/raid0.c| 8 ++--
drivers/md/raid1
Avoiding duplicated code, since they just execute a kfree.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid1-10.c | 5 +
drivers/md/raid1.c| 13 -
drivers/md/raid10.c | 11 +++
3 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/drivers/md
This return statement was introduced in commit
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") and can be
safely removed.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/raid0.c b/drivers/md/rai
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to
return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/md.c | 2 +-
1 fi
This argument was not being considered since blk-mq was set by default,
so removed this documentation to avoid confusion.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/kernel-per-CPU-kthreads.txt | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation
This argument was not being used since the legacy IO path was removed,
when blk-mq was enabled by default. So removed it from the kernel
parameters documentation.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/admin-guide/kernel-parameters.txt | 6 --
1 file changed, 6 deletions
Since the inclusion of blk-mq, elevator argument was not being
considered anymore, and it's utility died long with the legacy IO path,
now removed too.
Signed-off-by: Marcos Paulo de Souza
---
block/elevator.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/block/elevato
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
Signed-off-by: Marcos Paulo de Souza
---
drivers/usb/storage/scsiglue.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers
Currently, all USB devices skip VPD pages, even when the device supports
them (SPC-3 and later), but some of them support VPD, like Cruzer Blade.
Signed-off-by: Marcos Paulo de Souza
---
drivers/scsi/scsi_devinfo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi
://lkml.org/lkml/2019/6/11/1408
Marcos Paulo de Souza (2):
scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade
usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set
drivers/scsi/scsi_devinfo.c| 2 ++
drivers/usb/storage/scsiglue.c | 7 +--
2 files changed, 7 insertions
On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Paulo de Souza wrote:
> > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> > be honored, so only set skip_vpd_pages is try_vpd_p
On Tue, Jun 18, 2019 at 12:52:03PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 07:30:04AM -0300, Marcos Paulo de Souza wrote:
> > On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Pa
On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote:
> On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
>
> > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> > be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
> >
> &g
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
Signed-off-by: Marcos Paulo de Souza
Acked-by: Alan Stern
---
Changes from v1:
changed the check of try_vpd_pages from:
sdev->try_vpd_pages =
On Tue, Jun 18, 2019 at 06:07:24PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 12:17:39PM -0300, Marcos Paulo de Souza wrote:
> > On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote:
> > > On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
> > >
>
ping? Can anybody take a look at this patch?
Thanks,
Marcos
On Tue, Jun 11, 2019 at 11:08:28PM -0300, Marcos Paulo de Souza wrote:
> WWID composed from VPD data from device, specifically page 0x83. So,
> when a device does not have VPD support, for example USB storage devices
> whe
On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote:
>
> Marcos,
>
> > Currently, all USB devices skip VPD pages, even when the device
> > supports them (SPC-3 and later), but some of them support VPD, like
> > Cruzer Blade.
>
> What's your confidence level wrt. all Cruzer Blades
On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote:
> On 6/19/19 5:35 AM, Martin K. Petersen wrote:
> >
> > Marcos,
> >
> >> WWID composed from VPD data from device, specifically page 0x83. So,
> >> when a device does not have VPD support, for example USB storage
> >> devices where V
On Wed, Jun 19, 2019 at 06:45:43AM -0300, Marcos Paulo de Souza wrote:
> On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote:
> >
> > Marcos,
> >
> > > Currently, all USB devices skip VPD pages, even when the device
> > > supports them (SPC
humble ping :)
On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote:
> If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
>
> Signed-off-by: Marcos Paulo de Souza
> Acked
On Thu, Jun 20, 2019 at 04:32:38PM -0400, Martin K. Petersen wrote:
>
> Marcos,
>
> > My first idea was to add a vendor:product mapping at SCSI layer, but
> > so far I haven't found one, so I added the model/vendor found by
> > INQUIRY. Would it be better to check for prod:vendor (as values,
> >
ping?
On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote:
> If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
>
> Signed-off-by: Marcos Paulo de Souza
> Acked
ping?
On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> set_capacity expects the disk size in sectors of 512 bytes, and changing
> the magic number 9 to SECTOR_SHIFT clarifies this intent.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> drivers/block
Hello João,
On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote:
> On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza
> wrote:
>>
>> Hello João,
>>
>> On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
>>> Hello Marcos,
>>>
>>> On Sun,
Hi João,
On 2/13/19 7:46 PM, Marcos Paulo de Souza wrote:
Hello João,
On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote:
On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza
wrote:
Hello João,
On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
Hello Marcos,
On Sun, Feb 10, 2019 at 5:05 PM
ping?
On Sat, Dec 22, 2018 at 08:03:54AM -0200, Marcos Paulo de Souza wrote:
> Instead of just using plain '1', as it improves readability.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> include/linux/blk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 d
1 - 100 of 171 matches
Mail list logo
