Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

2016-09-19 Thread Manuel Schölling
19 at 00:06 +0200, Manuel Schölling wrote: > Add a scrollback buffers for each VGA console. The benefit is that > the scrollback history is not flushed when switching between consoles > but is persistent. > The buffers are allocated on demand when a new console is opened. > > It

[PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

2016-09-06 Thread Manuel Schölling
. Signed-off-by: Manuel Schölling --- Changes in v3: - Add config option for this feature - Fallback to old scrollback buffer if kcalloc() fails - Remove ioctl() call again and add documentation about existing escape sequence to flush the scrollback buffer Changes in v2: - Add ioctl

[PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

2016-09-14 Thread Manuel Schölling
. Signed-off-by: Manuel Schölling --- Changes in v3: - Add config option for this feature - Fallback to old scrollback buffer if kcalloc() fails - Remove ioctl() call again and add documentation about existing escape sequence to flush the scrollback buffer Changes in v2: - Add ioctl

[PATCH] ntfs: Cleanup string initializations (char[] instead of char *)

2014-05-17 Thread Manuel Schölling
Garzik on the KernelJanitor's TODO list). Signed-off-by: Manuel Schölling --- fs/ntfs/inode.c |2 +- fs/ntfs/super.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index f47af5e..3975798 100644 --- a/fs/ntfs/inode.c ++

[PATCH] pinctrl: Cleanup string initializations (char[] instead of char *)

2014-05-17 Thread Manuel Schölling
rnelJanitor's TODO list). Signed-off-by: Manuel Schölling --- drivers/pinctrl/pinctrl-mxs.c|6 +++--- drivers/pinctrl/pinctrl-single.c |4 ++-- drivers/pinctrl/pinctrl-tegra.c |2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctr

[PATCH] fs: Cleanup string initializations (char[] instead of char *)

2014-05-17 Thread Manuel Schölling
rnelJanitor's TODO list). Signed-off-by: Manuel Schölling --- fs/binfmt_misc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index b605003..2a10529 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -419,7 +419,7 @@

[PATCH] fs: FAT: Cleanup string initializations (char[] instead of char *)

2014-05-17 Thread Manuel Schölling
rnelJanitor's TODO list). Signed-off-by: Manuel Schölling --- fs/fat/inode.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index b3361fe..8b7d00e 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -359,7 +359,7 @@ struct inode *

[PATCH] net: 8390: use time_after() for time comparison

2014-05-18 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of raw math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/8390/ax88796.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/8390

[PATCH] net: rds: Use time_after() for time comparison

2014-05-18 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of raw math. Signed-off-by: Manuel Schölling --- net/rds/ib_send.c |4 ++-- net/rds/iw_send.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rds

[PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison

2014-05-19 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_is_before_jiffies() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/neterion/vxge/vxge-main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[no subject]

2014-05-19 Thread Manuel Schölling
Sorry, contrary to the subject of the previous email, this is a single file patch. Patches 2-3 do not exist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

[PATCH] net: vxge: Use time_is_before_jiffies() for time comparison

2014-05-19 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_is_before_jiffies() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/neterion/vxge/vxge-main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3] vxge: Use time_before()

2014-05-19 Thread Manuel Schölling
Thanks for your hints. I tried to incorporate your points into this new version. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ a

[PATCH] vxge: Use time_before()

2014-05-19 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/neterion/vxge/vxge-main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] lpfc: Use time_after()

2014-05-19 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/scsi/lpfc/lpfc_scsi.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH] xilinx: Fix compiler warning

2014-06-22 Thread Manuel Schölling
The time comparsion functions require arguments of type unsigned long instead of (signed) long. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/xilinx/ll_temac_main.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c |2 +- drivers/net/ethernet/xilinx

[PATCH v2] xilinx: Fix compiler warning

2014-06-22 Thread Manuel Schölling
The time comparsion functions require arguments of type unsigned long instead of (signed) long. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/xilinx/ll_temac_main.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c |2 +- drivers/net/ethernet/xilinx

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-23 Thread Manuel Schölling
Hi, I am wondering if we could improve the design of the system call a bit to prevent programming errors. Right now, EINVAL is returned in case of invalid flags (or in the older version of getrandom() also if buflen is too large), EFAULT if buf is an invalid address and EAGAIN if there is not enou

[PATCH] dns_resolver: assure that dns_query() result is null-terminated

2014-06-07 Thread Manuel Schölling
dns_query() credulously assumes that keys are null-terminated and returns a copy of a memory block that is off by one. --- net/dns_resolver/dns_query.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c index e7b6d5

[PATCH v2] dns_resolver: assure that dns_query() result is null-terminated

2014-06-07 Thread Manuel Schölling
dns_query() credulously assumes that keys are null-terminated and returns a copy of a memory block that is off by one. --- net/dns_resolver/dns_query.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c index e7b6d

[PATCH v3] dns_resolver: assure that dns_query() result is null-terminated

2014-06-07 Thread Manuel Schölling
dns_query() credulously assumes that keys are null-terminated and returns a copy of a memory block that is off by one. Signed-off-by: Manuel Schölling --- net/dns_resolver/dns_query.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/dns_resolver/dns_query.c b/net

[PATCH] lustre: Use time_before()

2014-05-21 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/staging/lustre/lustre/include/linux/obd.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] qlogic: Use time_before()

2014-05-21 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] radeon: Use time_before()

2014-05-21 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/gpu/drm/radeon/radeon_pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 2/2] mISDN: use mod_timer()

2014-05-21 Thread Manuel Schölling
The code for resetting the timer can be simplified if mod_timer() is used instead of del_timer() followed by add_timer(). Signed-off-by: Manuel Schölling --- drivers/isdn/mISDN/l1oip_core.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/isdn/mISDN

[PATCH 1/2] mISDN: Use time_before()

2014-05-21 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/isdn/mISDN/l1oip_core.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/isdn

[PATCH v2 2/2] mISDN: Use mod_timer()

2014-05-21 Thread Manuel Schölling
The code for resetting the timer can be simplified if mod_timer() is used instead of del_timer() followed by add_timer(). Signed-off-by: Manuel Schölling --- drivers/isdn/mISDN/l1oip_core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/isdn/mISDN

[PATCH v2 1/2] mISDN: Use time_before()

2014-05-21 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/isdn/mISDN/l1oip_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn

[PATCH] sched: Use time_after()

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- kernel/sched/fair.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel

[PATCH] micrel: Use time_before_eq()

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/micrel/ksz884x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] xilinx: Use time_before_eq()

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/xilinx/ll_temac_main.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c |2

[PATCH] ioat: Use time_before()

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/dma/ioat/dma_v2.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/ioat/dma_v2

[PATCH] e1000: Use time_after() for time comparison

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH] md: Use time_in_range()

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_in_range() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/md/dm-cache-target.c |5 +++-- drivers/md/dm-log-userspace-base.c |4 ++-- drivers/md/dm-thin.c

[PATCH] acpi: Use time_before() for time comparison

2014-05-22 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/acpi/acpi_pad.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/acpi

[PATCH] msi3103: Use time_before_eq()

2014-05-24 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/staging/media/msi3101/sdr-msi3101.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH] msi3103: Use time_before_eq()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/staging/media/msi3101/sdr-msi3101.c | 28 +-- 1 file changed, 14 insertions(+), 14

[PATCH] rtl8188eu: use time_before/time_after and change type of ips_deny_time

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before/_after() instead of plain, error-prone math. To suppress compiler warnings the type of ips_deny_time was changed. Signed-off-by: Manuel Schölling --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c

[PATCH] gdm72xx: use time_before()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/staging/gdm72xx/gdm_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] ipath: use time_before()/_after()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before/_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/infiniband/hw/ipath/ipath_intr.c |4 ++-- drivers/infiniband/hw/ipath/ipath_sdma.c |4 ++-- 2 files

[PATCH] wan: time_before()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/wan/farsync.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan

[PATCH] mwifiex: use time_after()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/wireless/mwifiex/main.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH] dgnc: Use time_after_eq()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_after_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/staging/dgnc/dgnc_neo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] sgi-gru: use time_before()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/misc/sgi-gru/grumain.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/sgi

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2014-05-30 Thread Manuel Schölling
Add a scrollback buffers for each VGA console. The benefit is that the scrollback history is not flushed when switching between consoles but is persistent. The buffers are allocated on demand when a new console is opened. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig |6

[PATCH RESEND] sgi-gru: use time_before()

2014-05-30 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/misc/sgi-gru/grumain.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/sgi

[PATCH v2] console: Add persistent scrollback buffers for all VGA consoles

2014-05-31 Thread Manuel Schölling
Add a scrollback buffers for each VGA console. The benefit is that the scrollback history is not flushed when switching between consoles but is persistent. The buffers are allocated on demand when a new console is opened. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 19

[PATCH] wan: Use usleep_range()

2014-05-31 Thread Manuel Schölling
Instead of using a jiffies hack we can use the standard api for delays. Signed-off-by: Manuel Schölling --- drivers/net/wan/farsync.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index bcfff0d..02f6d1c

[PATCH] dns_resolver: Do not accept domain names longer than 255 chars

2014-05-31 Thread Manuel Schölling
According to RFC1035 "[...] the total length of a domain name (i.e., label octets and label length octets) is restricted to 255 octets or less." Signed-off-by: Manuel Schölling --- net/dns_resolver/dns_query.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v2] dns_resolver: Do not accept domain names longer than 255 chars

2014-05-31 Thread Manuel Schölling
According to RFC1035 "[...] the total length of a domain name (i.e., label octets and label length octets) is restricted to 255 octets or less." Signed-off-by: Manuel Schölling --- net/dns_resolver/dns_query.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH RESEND v2] console: Add persistent scrollback buffers for all VGA consoles

2014-06-14 Thread Manuel Schölling
Add a scrollback buffers for each VGA console. The benefit is that the scrollback history is not flushed when switching between consoles but is persistent. The buffers are allocated on demand when a new console is opened. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 19

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2016-05-02 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 +- drivers/video/console/vgacon.c | 172

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2016-05-09 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 +- drivers/video/console/vgacon.c | 172

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2016-05-23 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 +- drivers/video/console/vgacon.c | 172

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2016-05-16 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 +- drivers/video/console/vgacon.c | 172

[PATCH 0/2] Persistent scrollback buffers for all VGA consoles

2016-04-18 Thread Manuel Schölling
re' of the kernel to clear the buffer when consoles are switched. To offer a way for userland tools to flush the buffer my second patch adds a ioctl call for that. Also this feature is disabled by default and security implications are clearly stated in its documentation. Manuel Schölling (2):

[PATCH 0/2] Persistent scrollback buffers for all VGA consoles

2016-04-18 Thread Manuel Schölling
re' of the kernel to clear the buffer when consoles are switched. To offer a way for userland tools to flush the buffer my second patch adds a ioctl call for that. Also this feature is disabled by default and security implications are clearly stated in its documentation. Manuel Schölling (2):

[PATCH 1/2] console: Add persistent scrollback buffers for all VGA consoles

2016-04-18 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 22 +- drivers/video/console/vgacon.c | 172 +++-- 2 files changed, 133 insertions

[PATCH 2/2] console: Add ioctl for flushing the scrollback buffer

2016-04-18 Thread Manuel Schölling
Tools like clear_console rely on the fact that scrollback history is flushed when switching back and forth between consoles. Persistent scrollback buffers for each console breaks this, so this patch adds a ioctl() callf for flushing the scrollback history. Signed-off-by: Manuel Schölling

[PATCH] console: Add persistent scrollback buffers for all VGA consoles

2016-04-23 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 +- drivers/video/console/vgacon.c | 172

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-06 Thread Manuel Schölling
Hi Greg, On Di, 2016-12-06 at 11:02 +0100, Greg KH wrote: > On Sun, Dec 04, 2016 at 11:53:53AM +0100, Manuel Schölling wrote: > > Reviewed-by: Andrey Utkin > > Tested-by: Andrey Utkin > > Tested-by: Adam Borowski > > > > -- > > Changes in v7: >

[PATCH v6 1/2] console: Move scrollback data into its own struct

2016-11-22 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling --- drivers/video/console/vgacon.c | 91 ++ 1 file changed, 47 insertions(+), 44 deletions(-) diff --git a/drivers/video/console

[PATCH v6 0/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-22 Thread Manuel Schölling
ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (2): console: Move scrollback data into its own struct console: Add persistent scrollback buffers for all VGA consoles drivers/video/console/Kconfig | 25 ++- drivers/video/console

[PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-22 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 25 +++- drivers/video/console/vgacon.c | 134

Re: [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-22 Thread Manuel Schölling
Hi Adam, On Mo, 2016-11-21 at 21:17 +0100, Adam Borowski wrote: > On Sun, Nov 20, 2016 at 10:58:08PM +0100, Manuel Schölling wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between cons

Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-23 Thread Manuel Schölling
On Di, 2016-11-22 at 19:31 +, Andrey Utkin wrote: > I'm not sure my emails with review of previous submission reached you, but in > them I meant to mention that there are some style nits which are easy to > eliminate. I am afraid I did not get it. I will fix these style issues in the next patch

Re: [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-23 Thread Manuel Schölling
On Mo, 2016-11-21 at 21:17 +0100, Adam Borowski wrote: > On Sun, Nov 20, 2016 at 10:58:08PM +0100, Manuel Schölling wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between consoles > > but i

[PATCH v8 3/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-05 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video

[PATCH v8 2/3] console: Add callback to flush scrollback buffer to consw struct

2017-01-05 Thread Manuel Schölling
ell the video console driver which buffer to flush. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/tty/vt/vt.c| 9 + drivers/video/console/vgacon.c | 24 +++- include/linux/consol

[PATCH v8 1/3] console: Move scrollback data into its own struct

2017-01-05 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video/console/vgacon.c | 91 ++ 1 file changed

[PATCH v8 0/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-05 Thread Manuel Schölling
about existing escape sequence to flush the scrollback buffer Changes in v2: - Add ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (3): console: Move scrollback data into its own struct console: Add callback to flush scrollback buffer

Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles

2017-01-19 Thread Manuel Schölling
On Thu, 2017-01-19 at 14:23 +0100, Greg KH wrote: > On Fri, Jan 13, 2017 at 09:07:57PM +0100, Manuel Schölling wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between > > consoles > >

Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

2017-01-13 Thread Manuel Schölling
On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote: > On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > > The impact of the persistent scrollback feature on the code size is > > rather small, so the config option is removed. The feature stays > > disabl

[PATCH v10 2/4] console: Add callback to flush scrollback buffer to consw struct

2017-01-13 Thread Manuel Schölling
ell the video console driver which buffer to flush. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/tty/vt/vt.c| 9 + drivers/video/console/vgacon.c | 24 +++- include/linux/consol

[PATCH v10 1/4] console: Move scrollback data into its own struct

2017-01-13 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video/console/vgacon.c | 91 ++ 1 file changed

[PATCH v10 4/4] console: Make persistent scrollback a boot parameter

2017-01-13 Thread Manuel Schölling
by setting VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. Signed-off-by: Manuel Schölling Suggested-by: Bartlomiej Zolnierkiewicz --- drivers/video/console/Kconfig | 12 +++- drivers/video/console/vgacon.c | 25 - 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/vid

[PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles

2017-01-13 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video

[PATCH v10 0/4] console: Add persistent scrollback buffers for all VGA consoles

2017-01-13 Thread Manuel Schölling
kcalloc() fails - Remove ioctl() call again and add documentation about existing escape sequence to flush the scrollback buffer Changes in v2: - Add ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (4): console: Move scrollback data into

Re: [PATCH v8 3/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-10 Thread Manuel Schölling
ent it (should be any time this week). Thanks again! Manuel > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > > Best regards, > > -- > > Bartlomiej Zolnierkiewicz > > Samsung R&D Institute

[PATCH v4] console: Add persistent scrollback buffers for all VGA console

2016-11-16 Thread Manuel Schölling
--- Changes in v4: - Rename from VGACON_SOFT_SCROLLBACK_FOR_EACH_CONSOLE to VGACON_SOFT_SCROLLBACK_PERSISTENT - Split into two patches - Rework documentation - Remove cosmetic changes in comments (postponed) Changes in v3: - Add config option for this feature - Fallback to old scrol

[PATCH v4 1/2] console: Move scrollback data into its own struct

2016-11-16 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling --- drivers/video/console/vgacon.c | 82 +- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/drivers/video/console

[PATCH v4 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-16 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 ++- drivers/video/console/vgacon.c | 134

Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-16 Thread Manuel Schölling
Hi, I finally found the time to rework the patches, but there are a few things I want to discuss: > > This breaks tools like clear_console that rely on flushing the > > scrollback history by switching back and forth between consoles > > which is why this feature is disabled by default. > > Use th

[PATCH v4.1 0/2] console: Add persistent scrollback buffers for all VGA console

2016-11-16 Thread Manuel Schölling
h the scrollback buffer Changes in v2: - Add ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (2): console: Move scrollback data into its own struct console: Add persistent scrollback buffers for all VGA consoles drivers/video/console/Kc

[PATCH v4.1 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-16 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 23 ++- drivers/video/console/vgacon.c | 134

[PATCH v4.1 1/2] console: Move scrollback data into its own struct

2016-11-16 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling --- drivers/video/console/vgacon.c | 90 +- 1 file changed, 46 insertions(+), 44 deletions(-) diff --git a/drivers/video/console

[PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-27 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling --- drivers/video/console/Kconfig | 25 +++- drivers/video/console/vgacon.c | 142

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-27 Thread Manuel Schölling
not labeled as such, sorry) Manuel Schölling (3): console: Move scrollback data into its own struct console: Add callback to flush scrollback buffer to consw struct console: Add persistent scrollback buffers for all VGA consoles drivers/tty/vt/vt.c| 9 +++ drivers/video/

[PATCH v7 1/3] console: Move scrollback data into its own struct

2016-11-27 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling --- drivers/video/console/vgacon.c | 91 ++ 1 file changed, 47 insertions(+), 44 deletions(-) diff --git a/drivers/video/console

[PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct

2016-11-27 Thread Manuel Schölling
ell the video console driver which buffer to flush. Signed-off-by: Manuel Schölling --- drivers/tty/vt/vt.c| 9 + drivers/video/console/vgacon.c | 24 +++- include/linux/console.h| 4 3 files changed, 36 insertions(+), 1 deletion(-) diff --

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-28 Thread Manuel Schölling
On Mo, 2016-11-28 at 00:53 +0100, Adam Borowski wrote: > \e[3J works well now, thanks! Great to hear that! > Tested-by: Adam Borowski Thanks, Adam, for spending all this time testing the patches!

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-28 Thread Manuel Schölling
Hi Andrey, Adam already discussed some of your notes, but I want to catch up one this one: On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > I see the user experience is subpar to what I'm accustomed to (I use > Konsole and "Clear Scrollback and Reset" action, default shortcut is > Ctrl+Shi

[PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-21 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video

[PATCH RESEND v7 1/3] console: Move scrollback data into its own struct

2016-12-21 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video/console/vgacon.c | 91 ++ 1 file changed

[PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-21 Thread Manuel Schölling
r Changes in v2: - Add ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (3): console: Move scrollback data into its own struct console: Add callback to flush scrollback buffer to consw struct console: Add persistent scrollback buff

[PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct

2016-12-21 Thread Manuel Schölling
ell the video console driver which buffer to flush. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/tty/vt/vt.c| 9 + drivers/video/console/vgacon.c | 24 +++- include/linux/consol

[PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-02 Thread Manuel Schölling
r Changes in v2: - Add ioctl() call to flush scrollback buffer - (Patch v2 was not labeled as such, sorry) Manuel Schölling (3): console: Move scrollback data into its own struct console: Add callback to flush scrollback buffer to consw struct console: Add persistent scrollback buff

[PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-02 Thread Manuel Schölling
history by switching back and forth between consoles which is why this feature is disabled by default. Use the escape sequence \e[3J instead for flushing the buffer. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video

[PATCH RESEND v7 1/3] console: Move scrollback data into its own struct

2017-01-02 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video/console/vgacon.c | 91 ++ 1 file changed

[PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct

2017-01-02 Thread Manuel Schölling
ell the video console driver which buffer to flush. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/tty/vt/vt.c| 9 + drivers/video/console/vgacon.c | 24 +++- include/linux/consol

  1   2   >