[PATCH 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-09-12 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch

Re: [PATCH] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-14 Thread Ludovic Desroches
ubotariu Acked-by: Ludovic Desroches I'll be off for three weeks so if there are minor changes, you can keep my ack. Thanks Ludovic > --- > drivers/i2c/busses/i2c-at91-master.c | 20 > drivers/i2c/busses/i2c-at91.h| 6 +- > 2 files chang

Re: [PATCH v5 0/9] i2c: add support for filters

2019-09-14 Thread Ludovic Desroches
s is the result of the comments on the ML in the direction > requested: to make the bindings globally available for i2c drivers. > > Changes in v5: > - renamed i2c-filter-width-ns to i2c-digital-filter-width-ns as this > is applicable only to digital filter > - created new binding i2c-digit

Re: [PATCH] pinctrl: at91-pio4: implement .get_multiple and .set_multiple

2019-09-14 Thread Ludovic Desroches
; > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Thanks for this improvement. You can keep my ack for v3 as the changes should be the commit message only. I'll be off for three weeks. Regards Ludovic > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 60 ++

Re: [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-08 Thread Ludovic Desroches
On Fri, Sep 20, 2019 at 11:34:50AM +0200, Eugen Hristev - M18282 wrote: > > > On 12.09.2019 23:09, Ludovic Desroches wrote: > > > > > In the SAM9x60 SoC, there are only two clocks instead of three for the > > SDHCI device. The base clk is no longer provided, it is

Re: [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-08 Thread Ludovic Desroches
On Mon, Sep 30, 2019 at 09:56:13AM -0500, Rob Herring wrote: > On Thu, Sep 12, 2019 at 10:09:06PM +0200, Ludovic Desroches wrote: > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > > >

Re: [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()

2019-10-09 Thread Ludovic Desroches
> Signed-off-by: Markus Elfring Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b58ac720d9a1..f71c9f77d405 100644 &

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > External E-Mail > > > Implement i2c bus recovery when slaves devices might hold SDA low. > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > until the slave release SDA. > Hi Kamel, Thanks for adding this n

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 09, 2019 at 04:01:47PM +0200, Alexandre Belloni wrote: > > On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > > External E-Mail > > > > > > > > > Implement i2c

[PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-11 Thread Ludovic Desroches
There is a new compatible string for the SAM9X60 sdhci device. It involves an update of the properties about the clocks stuff. Signed-off-by: Ludovic Desroches --- Changes: - v2: remove the extra example and fix node label This patch conflicts with Nicolas' one: "dt-bindings: sdh

[PATCH v2 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-11 Thread Ludovic Desroches
clock which can take several rates. As we can't trust those values, take them from the clock tree and update the capabilities according to. As we can have the same pitfall, in some cases, with the SAMA5D2 Soc, stop relying on capabilities too. Signed-off-by: Ludovic Desroches --- Changes:

[PATCH v2 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-10-11 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- Changes: -v2: none arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot

Re: [PATCH 2/2] mmc: sdhci-of-at91: add DT property to enable calibration on full reset

2019-10-11 Thread Ludovic Desroches
d reduce > power consumption on some SAMA5D2 SiP revisions. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/mmc/host/s

Re: [PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-18 Thread Ludovic Desroches
On Fri, Oct 18, 2019 at 12:56:14PM +0200, Ulf Hansson wrote: > On Fri, 11 Oct 2019 at 12:33, Ludovic Desroches > wrote: > > > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > &

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-02-19 Thread Ludovic Desroches
Hi, On Fri, Feb 15, 2019 at 10:18:47AM +0100, Wolfram Sang wrote: > On Tue, Jan 15, 2019 at 11:43:51PM +0100, Wolfram Sang wrote: > > > > > All errors (new ones prefixed by >>): > > > > > > >> ERROR: "at91_init_twi_bus_slave" [drivers/i2c/busses/i2c-at91.ko] > > > >> undefined! > > > >> ERROR:

Re: [PATCH] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-22 Thread Ludovic Desroches
gt; > Signed-off-by: Codrin Ciubotariu Acked-by: Ludovic Desroches As Vinod suggested, you may change the commit message to emphasize that the bug comes from the fact that a single variable is used to store different information. The Fixes: tag should be added too. Regards Lud

Re: [PATCH v4] arm/mach-at91/pm : fix possible object reference leak

2019-04-04 Thread Ludovic Desroches
On Tue, Apr 02, 2019 at 10:12:38PM +0800, Peng Hao wrote: > > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device. When returning error we should > call put_device. > > Reviewed-by: Mukesh Ojha > Signed-off-by: Peng Hao Thanks applied to at91-

Re: linux-next: manual merge of the at91 tree with the at91-fixes tree

2019-04-05 Thread Ludovic Desroches
Hi Stephen, On Fri, Apr 05, 2019 at 09:15:19AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the at91 tree got a conflict in: > > arch/arm/mach-at91/pm.c > > between commit: > > ba5e60c9b75d ("arm/mach-at91/pm : fix possible object reference leak") > > from the

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Sat, May 04, 2019 at 05:28:51AM +0530, Raag Jadav wrote: > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > > On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > > > External E-Mail > > > > > > > > > On Mon, Apr 29

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Mon, May 06, 2019 at 10:19:01AM +0200, Eugen Hristev - M18282 wrote: > > > On 04.05.2019 02:58, Raag Jadav wrote: > > > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > >> On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav w

Re: [PATCH] arm/mach-at91/pm : fix possible object reference leak

2019-03-29 Thread Ludovic Desroches
Hi, On Wed, Feb 13, 2019 at 10:55:46PM +0800, Peng Hao wrote: > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device. When returning error we should > call put_device. > > Signed-off-by: Peng Hao > --- > arch/arm/mach-at91/pm.c | 1 + > 1 file c

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-03-29 Thread Ludovic Desroches
On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > SAMA5 devices use the newer DRM driver for LCD. They don't need > the older FB driver: remove the Kconfig option for them. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches CONFIG_FB_ATMEL shoul

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-03-29 Thread Ludovic Desroches
On Fri, Mar 29, 2019 at 02:05:38PM +0100, Ludovic Desroches wrote: > On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > > SAMA5 devices use the newer DRM driver for LCD. They don't need > > the older FB driver: remove the Kconfig option for them. > > > &

Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91

2019-04-19 Thread Ludovic Desroches
On Mon, Apr 15, 2019 at 05:14:50PM +0200, Alexandre Belloni wrote: > External E-Mail > > > On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote: > > is only generated and included > > by arch/arm/mach-at91/, so it does not need to reside in the > > globally visible include/generated/. > > > > I m

Re: linux-next: build failure after merge of the at91 tree

2019-04-23 Thread Ludovic Desroches
On Tue, Apr 23, 2019 at 01:27:52PM +0900, Masahiro Yamada wrote: > External E-Mail > > > On Tue, Apr 23, 2019 at 10:33 AM Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the at91 tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > arch/arm/mach-

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-04-29 Thread Ludovic Desroches
Hello Raag, On Tue, Apr 23, 2019 at 01:06:48PM +0530, Raag Jadav wrote: > External E-Mail > > > Performing i2c write operation while SDA or SCL line is held > or grounded by slave device, we go into infinite at91_twi_write_next_byte > loop with TXRDY interrupt spam. Sorry but I am not sure to h

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-02 Thread Ludovic Desroches
On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > External E-Mail > > > On Mon, Apr 29, 2019 at 11:00:05AM +0200, Ludovic Desroches wrote: > > Hello Raag, > > > > On Tue, Apr 23, 2019 at 01:06:48PM +0530, Raag Jadav wrote: > > > External E-

Re: [PATCH v3 0/9] i2c: add support for filters

2019-07-12 Thread Ludovic Desroches
2c-core-base.c| 2 + > include/linux/i2c.h | 2 + > 9 files changed, 121 insertions(+), 4 deletions(-) Hi, I don't know if it will fit other vendors need concerning the binding but for Microchip it sounds good. Acked-by: Ludovic Desroches for the whole serie. Regards Ludovic

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-12 Thread Ludovic Desroches
On Mon, Aug 12, 2019 at 03:38:34PM +, eugen.hris...@microchip.com wrote: > On 09.08.2019 09:23, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > >> On 8/08/19 3:42 PM, Ludovic Desroches wrote: > >>> On Thu, Aug 08, 2

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > On 8/08/19 3:42 PM, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 10:35:43AM +0200, Eugen Hristev - M18282 wrote: > >> From: Eugen Hristev > >> > >> Add mmc capabilities for SDMMC0 for this

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-09 Thread Ludovic Desroches
On Thu, Aug 08, 2019 at 05:23:00PM +0200, Ulf Hansson wrote: > On Thu, 8 Aug 2019 at 10:35, wrote: > > > > From: Eugen Hristev > > > > HS200 is not implemented in the driver, but the controller claims it > > through caps. > > Remove it via quirk. > > Without this quirk, the mmc core will try to e

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-31 Thread Ludovic Desroches
y: Gustavo A. R. Silva I don't know if there is a policy in the kernel about the expression to use. As this one does the job Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/

Re: [PATCH] crypto: atmel-sha204a: Use device-managed registration API

2019-07-31 Thread Ludovic Desroches
On Tue, Jul 23, 2019 at 03:19:36PM +0800, Chuhong Yuan wrote: > > Use devm_hwrng_register to get rid of manual > unregistration. > > Signed-off-by: Chuhong Yuan Acked-by: Ludovic Desroches Thanks > --- > drivers/crypto/atmel-sha204a.c | 3 +-- > 1 file changed, 1 i

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-08-01 Thread Ludovic Desroches
On Wed, Jul 31, 2019 at 09:06:07AM -0700, Kees Cook wrote: > On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > >host->c

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
Eugen Hristev Acked-by: Ludovic Desroches I am interested to have the some insights about the use of sd-uhs-* properties. Our IP can't deal with 1V8 by itself. It has a 1V8SEL signal which can be used as the logic control input of a mux. So even if the IP claims to support UHS modes, it depends

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-08 Thread Ludovic Desroches
ll fail, > and the eMMC initialization will fail. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c > b/dri

Re: [PATCH] dmaengine: at_xdmac: check for non-empty xfers_list before invoking callback

2019-07-01 Thread Ludovic Desroches
On Sat, Jun 29, 2019 at 01:50:48PM +0530, Raag Jadav wrote: > > tx descriptor retrieved from an empty xfers_list may not have valid > pointers to the callback functions. > Avoid calling dmaengine_desc_get_callback_invoke if xfers_list is empty. > > Signed-off-by: Raag Jadav

[PATCH v5 3/3] i2c: at91: added slave mode support

2019-02-22 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: rework Kconfig and replace IS_ENABLED by defined] Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Kconfig | 13

[PATCH v5 0/3] i2c: at91: slave mode support

2019-02-22 Thread Ludovic Desroches
[Ludovic Desroches: see Changes section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can be

[PATCH v5 2/3] i2c: at91: split driver into core and master file

2019-02-22 Thread Ludovic Desroches
only had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors and use SPDX] Signed-off-by: Ludovic Desroches --- MAINTAINERS | 3 +- drivers/i2c/busses/Mak

[PATCH v5 1/3] i2c: at91: segregate master mode specific code from probe and init func

2019-02-22 Thread Ludovic Desroches
shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 +-- 1 file changed, 55 insertions(+), 35 deletions

Re: [PATCH] iio: adc: at91: disable adc channel interrupt in timeout case

2019-02-22 Thread Ludovic Desroches
are queried we can end up with a > situation where two interrupts are enabled, but only one interrupt is > cleared in the interrupt handler. Resulting in a interrupt loop and a > system hang. > > Signed-off-by: Georg Ottinger Acked-by: Ludovic Desroches Thanks > --- &

Re: [PATCH] iio: adc: at91: disable adc channel interrupt in timeout case

2019-02-22 Thread Ludovic Desroches
ld like to > prepare a pull request concerning the 2nd Issue. For the 3rd and the 4th > Issue I would like to hear your opinion if our modifications are sound before > I will write an pull request. > > Thanks for your time, > Best wishes, > Georg Ottinger > > -

[PATCH] pinctrl: at91: don't use the same irqchip with multiple gpiochips

2018-09-13 Thread Ludovic Desroches
Sharing the same irqchip with multiple gpiochips is not a good practice. For instance, when installing hooks, we change the state of the irqchip. The initial state of the irqchip for the second gpiochip to register is then disrupted. Signed-off-by: Ludovic Desroches --- Hi, This patch fixes the

Re: [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions

2018-09-25 Thread Ludovic Desroches
ime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Hello Jonathan, > > I moved this LCDR read/acknowledge into the IRQ handler after the conversion > value is being read. > Sorry about the noise to stable@vger, removed from message. > > Than

Re: [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode

2018-09-25 Thread Ludovic Desroches
annel. > > Fixes 0e589d5fb "ARM: AT91: IIO: Add AT91 ADC driver." > Cc: Maxime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v2: > - Added 'const' spec to the declaration to avoid build warning > > drivers/

Re: [GIT PULL] ARM: at91: SoC for 4.20

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 25, 2018 at 01:38:12PM -0700, Olof Johansson wrote: > On Tue, Sep 25, 2018 at 12:37:35PM +0200, Alexandre Belloni wrote: > > Arnd, Olof, > > > > Most changes are shuffling around the maintainers entries. There are > > also two PM non urgent fixes. > > > > This one as a trivial conflic

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
Hi Richard, On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 10:47:17AM +0200, Richard Genoud wrote: > > Hi ! > > > > On 07/08/2018 15:00, Ludovic Desroches wrote: > > > From: Nicolas Fer

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
On Wed, Sep 05, 2018 at 03:53:02PM +0200, Richard Genoud wrote: > [added Nicolas back in the thread, he was removed somehow] > > Hi Ludovic ! > > On 05/09/2018 14:43, Ludovic Desroches wrote: > > Hi Richard, > > > > On Thu, Aug 09, 2018 at 01:30:35PM +0200,

[PATCH v4 1/2] tty/serial_core: add ISO7816 infrastructure

2018-09-06 Thread Ludovic Desroches
-off-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi/asm/ioctls.h| 2 ++ arch/parisc/include/uapi/asm/ioctls.h | 2 ++ arch/powerpc/include/uapi/asm/ioctls.h | 2 ++ arch/sh/include/uapi/asm/ioctls.h | 2 ++ arch/sparc/include/uapi/asm

[PATCH v4 0/2] add ISO7816 support

2018-09-06 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v4 - use the IP version number instead of the compatible string to set min and max values

[PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-06 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 190 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 181 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial

[PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl

2018-09-07 Thread Ludovic Desroches
The drive strength has to be set to medium otherwise some data corruption may happen. Signed-off-by: Ludovic Desroches --- Hi, This fix depends on the support of the drive-strength for the atmel pio4 pinctroller. It has been added in v4.19 but I omitted to send it at the same time. Ludovic

Re: [PATCH 1/2] ARM: dts: at91: sama5d4_xplained: fix addresable nand flash size

2018-10-02 Thread Ludovic Desroches
On Tue, Oct 02, 2018 at 02:29:48PM +0300, Tudor Ambarus wrote: > sama5d4_xplained comes with a 4Gb NAND flash. Increase the rootfs > size to match this limit. > > Signed-off-by: Tudor Ambarus Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91-sama5d4_xplain

Re: [PATCH 2/2] ARM: dts: at91: at91sam9x5cm: fix addressable nand flash size

2018-10-02 Thread Ludovic Desroches
On Tue, Oct 02, 2018 at 02:29:49PM +0300, Tudor Ambarus wrote: > at91sam9x5cm comes with a 2Gb NAND flash. Fix the rootfs size to > match this limit. > > Signed-off-by: Tudor Ambarus Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91sam9x5cm.dtsi | 2 +- &g

[GIT PULL] ARM: at91: DT for 4.20 #2

2018-10-03 Thread Ludovic Desroches
Arnd, Olof, Here are the second round of DT changes for 4.20. It consists in NAND description fixes (size and partitions). Regards Ludovic The following changes since commit 97181516b0785dd032700ae4899842389c6bea78: arm: dts: sama5d2: Update coresight bindings for hardware ports (2018-09-19

Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards

2018-09-07 Thread Ludovic Desroches
ing it for all peripherals: trng, aes, tdes and sha are still missing a label. Otherwise Acked-by: Ludovic Desroches Regards Ludovic > > Based on top of at91-next branch of at91.git > > Thanks. > > arch/arm/boot/dts/sama5d4.dtsi | 8 > 1 file changed, 4 insertions(+

Re: [PATCH 1/6] dmaengine: at_hdmac: simplify getting .drvdata

2018-04-22 Thread Ludovic Desroches
On Sun, Apr 22, 2018 at 11:14:09AM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Ludovic Desroches Thanks > --- > > Build tested on

Re: [PATCH 2/6] dmaengine: at_xdmac: simplify getting .drvdata

2018-04-22 Thread Ludovic Desroches
On Sun, Apr 22, 2018 at 11:14:10AM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Ludovic Desroches Thanks > --- > > Build tested on

Re: [PATCH] dmaengine: at_xdmac: fix rare residue corruption

2018-03-19 Thread Ludovic Desroches
On Mon, Mar 19, 2018 at 01:26:09PM +0530, Vinod Koul wrote: > On Thu, Mar 01, 2018 at 09:25:16AM +0100, Ludovic Desroches wrote: > > Hi Maxime, > > > > On Thu, Feb 22, 2018 at 12:39:55PM +0100, Maxime Jayat wrote: > > > Despite the efforts made to correctly r

Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-04-16 Thread Ludovic Desroches
. > > Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870 > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 3 +-- > drivers/usb/gadget/udc/atmel_usba_udc.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include

2018-04-16 Thread Ludovic Desroches
On Mon, Apr 16, 2018 at 11:34:04AM +0200, Romain Izard wrote: > The include defines the private platform_data structure used with AVR > platforms. It has no user since 7c55984e191f. Remove it. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches > --- > driv

Re: [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting

2018-04-16 Thread Ludovic Desroches
On Mon, Apr 16, 2018 at 11:34:05AM +0200, Romain Izard wrote: > Fix the fallout of the conversion to GPIO descriptors in 3df034081021. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +- >

Re: [PATCH linux-next 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

2017-01-22 Thread Ludovic Desroches
Hi Cristian, Minor comments about syntax otherwise Reviewed-by: Ludovic Desroches On Fri, Jan 20, 2017 at 05:40:59PM +0200, cristian.bir...@microchip.com wrote: > From: Cristian Birsan > > Update atmel udc driver with a new enpoint allocation scheme. The data > sheet requi

Re: at_xdmac: txd used outside spinlock after being released?

2016-07-27 Thread Ludovic Desroches
Hi Brent, On Tue, Jul 19, 2016 at 10:58:40PM -0500, Brent Taylor wrote: > Hi Ludovic, >I'm learning about the dmaengine subsystem and I was using the > at_xdmac as a reference.I'm not real familiar with tasklets > because I have used threaded interrupt handlers instead of them. >I noti

Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

2016-10-20 Thread Ludovic Desroches
of:N*T*Catmel,sama5d2-sdhciC* > alias: of:N*T*Catmel,sama5d2-sdhci > > Signed-off-by: Javier Martinez Canillas Acked-by: Ludovic Desroches Thanks > --- > > drivers/mmc/host/sdhci-of-at91.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/m

Re: [PATCH v1] iio: adc: at91: add suspend and resume callback

2016-11-02 Thread Ludovic Desroches
On Wed, Nov 02, 2016 at 10:40:16AM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang > --- > > drivers/iio/adc/at91_adc.c | 35 +++ > 1 file changed, 35 inser

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

2016-12-01 Thread Ludovic Desroches
function. > > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b7d7f2d443a1..8c1abb794340 100644 > --- a/dr

Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select

2016-12-01 Thread Ludovic Desroches
On Thu, Dec 01, 2016 at 01:05:46PM +0900, Masahiro Yamada wrote: > I see no override of read/write callbacks in sdhci-of-at91.c. > > Signed-off-by: Masahiro Yamada Acked-by: Ludovic Desroches Thanks > --- > > BTW, this config may not be so useful in recent multi-platforms

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

2017-03-10 Thread Ludovic Desroches
_power' function for this specific hardware, that configures the voltage in the register in all cases. I don't remember if the set_power ops was available at that time. If yes, I would have thought about it. IMO it's a nice solution. Signed-off-by: Romain Izard Acked-by: Lu

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

2017-03-14 Thread Ludovic Desroches
On Thu, Mar 09, 2017 at 04:18:20PM +0100, Romain Izard wrote: > The SDHCI controller in the SAMA5D2 chip requires a valid voltage set > in the power control register, otherwise commands will fail with a > timeout error. > > When using the regulator framework to specify the regulator used by the >

Re: [PATCH v2] iio: adc: at91: add suspend and resume callback

2016-11-03 Thread Ludovic Desroches
On Wed, Nov 02, 2016 at 05:21:48PM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang Acked-by: Ludovic Desroches Thanks > --- > > Changes in v2: > - Use C

Re: [PATCH] atmel_serial: Use the fractional divider when possible

2017-02-10 Thread Ludovic Desroches
s was tested with a board using an Atmel SAMA5D2 chip and a TI > WL1831 WiFi/Bluetooth combo chip at 3 Mbauds, with hardware flow control > enabled. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Thanks > --- > drivers/tty/serial/atmel_serial.c | 7 --- &g

Re: [PATCH v2] i2c: at91: ensure state is restored after suspending

2017-02-17 Thread Ludovic Desroches
On Thu, Feb 16, 2017 at 06:27:59PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Restore them when resuming. > > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches > --- > Changes in v2

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Ludovic Desroches
Hello Romain, On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > Hello, > > On Atmel SAMA5D2, when trying to configure a serial port for 3 Mbauds > operation, I do not always get the requested baud rate. If the hardware > flow control is disabled by software, the line works correctly

Re: [PATCH] i2c: at91: ensure state is restored after suspending

2017-02-06 Thread Ludovic Desroches
Hi, I add Cyrille for FIFO part. On Mon, Jan 30, 2017 at 06:25:33PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Save them and restore them when resuming. > > Signed-off-by: Alexandre Belloni > --- > drivers/i2c/b

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Ludovic Desroches
On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > Hi Ludovic, > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > Hello Romain, > > > > On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > >> Hello, > >> > >> On

Re: [PATCH] i2c: busses: constify i2c_algorithm structures

2017-02-06 Thread Ludovic Desroches
600 83349 d15 drivers/i2c/busses/i2c-xlp9xx.o >2797 544 83349 d15 drivers/i2c/busses/i2c-xlp9xx.o > >2643 248 8 2899 b53 drivers/i2c/busses/i2c-xlr.o >2707 192 82907 b5b drivers/i2c/busses/i2c-xlr.o > > Signed-off-by: Bhumika Goyal > --- > drivers/i2c/busses/i2c-at91.c| 2 +- Acked-by: Ludovic Desroches Regards Ludovic

Re: Fractional divider on the Atmel USART controller

2017-02-09 Thread Ludovic Desroches
On Mon, Feb 06, 2017 at 04:37:23PM +0100, Ludovic Desroches wrote: > On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > > Hi Ludovic, > > > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > > Hello Romain, > > > > > > On Mon, Feb

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-10 Thread Ludovic Desroches
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- [...] > drivers/i2c/busses/i2c-at91.c | 2 -- Acked-by: Ludovic Desroches [...] > diff --git a/drivers/i2c/busses/i2c-at

[PATCH] i2c: at91: fix support of the "alternative command" feature

2016-08-03 Thread Ludovic Desroches
sfers up to 255 bytes can take advantage of the "alternative command" feature. For greater data transfer sizes, the driver should use the previous implementation, when the "alternative command" support was not implemented yet. Signed-off-by: Cyrille Pitchen Signed-off-by: Lud

Re: [PATCH 9/9] pinctrl: at91-pio4: make it explicitly non-modular

2016-06-07 Thread Ludovic Desroches
VICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Ludovic Desroches > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org > Sign

[PATCH] ARM: at91/dt: sama5d4 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches Fixes: 8d545f32bd77 ("ARM: at91/dt: sama5d4 xplained: add regulators for v(q)mmc1 supplies"

[PATCH] ARM: at91/dt: sama5d3 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches Fixes: 1b53e3416dd0 ("ARM: at91/dt: sama5d3 xplained: add fixed regulator for vmmc0") Cc: sta...@vger.

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-11 Thread Ludovic Desroches
On Thu, Mar 10, 2016 at 11:30:58AM +0100, Ludovic Desroches wrote: > It was impossible to wake-up on card detect event because when sdhci > controller is runtime suspend, it is assumed that all the clocks are > disabled so we can't get irqs. > If the device is removable and th

[PATCH 0/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
Hi, This set of patches does some cleanup in the code and export channels for signed and unsigned conversions. Ludovic Desroches (3): iio:adc:at91-sama5d2: fix typo iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: add support for signed conversion drivers/iio/adc/at91

[PATCH 3/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
The at91-sama5d2 ADC controller can achieve unsigned and signed conversion. For each channel, a signed and an unsigned variant are created. We can't set the sign mode for each channel. For that reason, the controller has to be configured upon conversion requests. Signed-off-by: Ludovic Desr

[PATCH 2/3] iio:adc:at91-sama5d2: fix identation

2016-03-03 Thread Ludovic Desroches
Remove some extra tabs. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 33bacec..5bc038f 100644 --- a

[PATCH 1/3] iio:adc:at91-sama5d2: fix typo

2016-03-03 Thread Ludovic Desroches
Fix typo in the name of a macro. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index dbee13a

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-04 Thread Ludovic Desroches
Hi Ulf, On Fri, Mar 04, 2016 at 10:09:37AM +0100, Ulf Hansson wrote: > On 17 February 2016 at 11:35, Ludovic Desroches [snip] > > I am wondering if I should take account of sdio irq enabled or not here. > > > > I have a sdio device which drives me crazy because of powe

[PATCH v2 0/2] iio: add support for signed conversions

2016-03-07 Thread Ludovic Desroches
Hi Jonathan, I hope these patches are in adequacy with your comments. They are based on the the previous two patches you have taken. I am not sure about the correctness of the documentation. Ludovic Desroches (2): iio: core: introduce IIO_CHAN_INFO_SIGNED iio:adc:at91-sama5d2: add support

[PATCH v2 1/2] iio: core: introduce IIO_CHAN_INFO_SIGNED

2016-03-07 Thread Ludovic Desroches
The same channel can be used to perform a signed or an unsigned conversion. Add a new infomask element to be able to select the type of conversion wanted: a raw one or a signed raw one. Signed-off-by: Ludovic Desroches --- Documentation/ABI/testing/sysfs-bus-iio | 10 ++ drivers/iio

[PATCH v2 2/2] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-07 Thread Ludovic Desroches
. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 125 ++--- 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 5bc038f..0370c4f 100644 --- a/drivers

[PATCH] sdhci: wakeup from runtime PM

2016-03-25 Thread Ludovic Desroches
Hi, When not using the SDHCI controller, it is logical to save power by suspending it. The issue is that SDHCI assumes that the controller is completely disabled. It means the only way to wake up on a card event is to have a gpio for the card detection (so two pins for the same signal). A possible

[PATCH] mmc: sdhci-of-at91: allow the use of controller card detect as wake up

2016-03-25 Thread Ludovic Desroches
esn't disable the interface clock if there is a removable device and no gpio for card detection. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 71 +--- 1 file changed, 45 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/hos

[PATCH] DRAFT: shdci: allows custom wakeup irqs for runtime PM

2016-03-25 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 36 ++-- drivers/mmc/host/sdhci.c | 12 +--- drivers/mmc/host/sdhci.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCH 1/2] iio:adc:at91-sama5d2: cleanup mode register use

2016-03-22 Thread Ludovic Desroches
Do not erase previous configuration of the mode register when setting the sampling frequency. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b

[PATCH 2/2] iio:adc:at91-sama5d2: add support for differential conversions

2016-03-22 Thread Ludovic Desroches
Add signed differential channels and update the voltage scale for differential conversions. Signed-off-by: Ludovic Desroches --- This patch is based on: iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: fix typo drivers/iio/adc/at91-sama5d2_adc.c | 71

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
Hi, On Thu, Mar 24, 2016 at 03:11:25PM +0200, Adrian Hunter wrote: > On 24/03/16 10:42, Krzysztof Kozlowski wrote: > > On 24.03.2016 17:24, Jisheng Zhang wrote: > >> Hi, > >> > >> On Thu, 24 Mar 2016 17:09:27 +0900 Jaehoon Chung wrote: > >> > >>> Hi, > >>> > >>> On 03/24/2016 04:58 PM, Jisheng Zha

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
ate: Thu, 24 Mar 2016 14:29:24 +0200 > > Subject: [PATCH V2] mmc: sdhci: Fix regression setting power on Trats2 board > > > > Several commits relating to setting power have been introducing > > problems by putting driver-specific rules into generic SDHCI code

<    1   2   3   4   5   6   7   >