[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose. Signed-off-

[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose. Signed-off-

[PATCH v2] pinctrl: at91-pio4: add support for drive strength

2018-06-29 Thread Ludovic Desroches
ned-off-by: Ludovic Desroches --- Changes: - v2: use atmel,drive-strength property instead of drive-strengh one since it is not expressend in mA and there is no way to retrieve this value at runtime. - v1: https://www.spinics.net/lists/linux-gpio/msg27789.html .../bindings/pinctrl/atmel,at91-pio4-p

Re: [PATCH v7 3/6] mfd: at91-usart: added mfd driver for usart

2018-06-14 Thread Ludovic Desroches
On Wed, Jun 13, 2018 at 07:36:18PM +0300, Radu Pirea wrote: > This mfd driver is just a wrapper over atmel_serial driver and > spi-at91-usart driver. Selection of one of the drivers is based on a > property from device tree. If the property is not specified, the default > driver is atmel_serial. >

[PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18

2018-08-20 Thread Ludovic Desroches
o it can't replace a memcpy where the destination is the virtual address of an SG buffer. This patch was part of "make more host drivers highmem safe v2". It seems there is the same logical error within the android-goldfish driver but I couldn't check it on real hardware. Ludovic D

[PATCH 1/2] mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
osite way. Signed-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 5b4277814e3f ("mmc: atmel-mci: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/atmel-mci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/dri

[PATCH 2/2] mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
fer but in the opposite way. Signed-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 53d7e098ba08 ("mmc: android-goldfish: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/android-goldfish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/ho

Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet

2018-08-20 Thread Ludovic Desroches
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote: > as you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: Barry Song <21cn...@gmail.com> Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 4 ++-- > 1 fi

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: add QSPI0 + SPI NOR memory nodes

2018-12-11 Thread Ludovic Desroches
On Tue, Dec 11, 2018 at 03:40:33PM +0100, Boris Brezillon wrote: > On Mon, 10 Dec 2018 17:15:29 + > wrote: > > > From: Cyrille Pitchen > > > > This patch configures the QSPI0 controller pin muxing and declares > > a jedec,spi-nor memory. > > > > sama5d2 Xplained RevB and RevC use the Macro

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: add QSPI0 + SPI NOR memory nodes

2018-12-11 Thread Ludovic Desroches
On Tue, Dec 11, 2018 at 03:35:45PM +0100, Alexandre Belloni wrote: > On 11/12/2018 12:32:40+, tudor.amba...@microchip.com wrote: > > Hi, Alexandre, > > > > On 12/10/2018 11:35 PM, Alexandre Belloni wrote: > > > Hi, > > > > > > On 10/12/2018 17:15:29+, tudor.amba...@microchip.com wrote: >

Re: [PATCH v3 0/3] i2c: at91: slave mode support

2018-12-21 Thread Ludovic Desroches
Hi Wolfram, On Tue, Dec 11, 2018 at 08:28:05PM +0100, Wolfram Sang wrote: > Hi Ludovic, > > > > > - fix checkpatch errors > > > > - tests: > > > >- hangs with a SAMA5D4 (master and slave on different busses) after > > > > about > > > >100 transfers. It's the firs time I do this test. >

Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD

2018-12-24 Thread Ludovic Desroches
c: new driver for the Atmel AHB DMA > Controller") > Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control") > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches Thanks > > --- > Successfully 0-day tested on 151 configurations. > > d

[PATCH v4 1/3] i2c: at91: segregate master mode specific code from probe and init func

2018-12-27 Thread Ludovic Desroches
shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 +-- 1 file changed, 55 insertions(+), 35 deletions

[PATCH v4 0/3] i2c: at91: slave mode support

2018-12-27 Thread Ludovic Desroches
[Ludovic Desroches: see Changes section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can be

[PATCH v4 2/3] i2c: at91: split driver into core and master file

2018-12-27 Thread Ludovic Desroches
only had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors] Signed-off-by: Ludovic Desroches --- MAINTAINERS | 3 +- drivers/i2c/busses/Mak

[PATCH v4 3/3] i2c: at91: added slave mode support

2018-12-27 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: rework Kconfig] Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Kconfig | 13 +++ drivers/i2c/busses/Makefile

Re: [RESEND PATCH 1/2] i2c: enable buses to save their clock frequency in adapter

2018-10-29 Thread Ludovic Desroches
their clock frequency in adapter. > > Signed-off-by: Tudor Ambarus Reviwed-by: Ludovic Desroches > --- > include/linux/i2c.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 65b4eaed1d96..f238da204c49 100644 > ---

Re: [PATCH] i2c: at91: switched to resume/suspend callbacks.

2018-11-07 Thread Ludovic Desroches
why we use the _noirq variant. When patches for PM stuff were sent, suspend/resume callbacks were used but in the latest version it moved to the _noirq variant without explanation. Excepting if someone has an argument to keep the _noirq variant, Acked-by: Ludovic Desroches Thanks Regards Ludovic >

Re: sama5d: using the ebi interface from another driver

2018-11-05 Thread Ludovic Desroches
Hi Jean-Michel, On Fri, Nov 02, 2018 at 02:35:26PM +0100, Jean-Michel Hautbois wrote: > Hi all, > > I have a custom board based on a sama5d3 chip. The SoC is connected to > 2 pef24628 SHDSL transceivers, the first one on ebi@4000 and the > second one on ebi@5000. > I tried to write a basi

[PATCH v3 3/3] i2c: at91: added slave mode support

2018-07-16 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Makefile | 3 + drivers/i2c/busses/i2c-at91-core.c | 13 +++- drivers/i2c/busses/i2c-at91-slave.c

[PATCH v3 1/3] i2c: at91: segregate master mode specific code from probe and init func

2018-07-16 Thread Ludovic Desroches
shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 ++- 1 file changed, 55 insertions(+), 35

[PATCH v3 0/3] i2c: at91: slave mode support

2018-07-16 Thread Ludovic Desroches
[Ludovic Desroches: see 'Changes in v3' section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slav

[PATCH v3 2/3] i2c: at91: split driver into core and master file

2018-07-16 Thread Ludovic Desroches
only had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors] Signed-off-by: Ludovic Desroches --- MAINTAINERS| 3 +- drivers/i2c/busses/Mak

Re: [PATCH v5 00/61] dmaengine: Implement generic slave capabilities retrieval

2014-12-08 Thread Ludovic Desroches
On Mon, Dec 08, 2014 at 11:47:46AM +0530, Vinod Koul wrote: > On Mon, Nov 17, 2014 at 02:41:54PM +0100, Maxime Ripard wrote: > > Hi, > > > > As we discussed a couple of weeks ago, this is the third attempt at > > creating a generic behaviour for slave capabilities retrieval so that > > generic lay

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-12 Thread Ludovic Desroches
Hi Wolfram, On Fri, Jan 09, 2015 at 06:21:32PM +0100, Wolfram Sang wrote: > Let the core do the checks if HW quirks prevent a transfer. Saves code > from drivers and adds consistency. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/i2c-core.c | 53 >

Re: [PATCH RFC 1/2] dmaengine: Introduce scheduled DMA framework

2015-03-23 Thread Ludovic Desroches
On Sat, Mar 21, 2015 at 12:42:06PM -0700, Maxime Ripard wrote: [...] > +/* > + * Besoin d'une fonction pour pusher un descriptor vers un pchan > + * > + * Flow normal: > + * - Election d'un pchan (Framework) > + * - Push d'un descripteur vers le pchan (Driver) > + * - idle > + * - int

[PATCH] tty/serial: at91: maxburst was missing for dma transfers

2015-04-16 Thread Ludovic Desroches
Maxburst was not set when doing the dma slave configuration. This value is checked by the recently introduced xdmac. It causes an error when doing the slave configuration and so prevents from using dma. Signed-off-by: Ludovic Desroches Cc: # 3.12 and later --- drivers/tty/serial/atmel_serial.c

[PATCH] ARM: at91/dt: sama5d4: update pinctrl ranges

2015-04-27 Thread Ludovic Desroches
Update the pinctrl ranges property to support pioD controller whose mapping is not contiguous with other pio controllers. Without this update, getting resource will fail, then pinctrl probe will fail too because there is a missing pio controller. Signed-off-by: Ludovic Desroches --- arch/arm

[PATCH 1/4] ARM: at91/dt: sama5d3 xplained: fill in mmc1 and set it to disabled

2015-04-27 Thread Ludovic Desroches
necessary slot configuration if this node were enabled to avoid the following warnings from the driver: atmel_mci f800.mmc: No vmmc regulator found atmel_mci f800.mmc: No vqmmc regulator found Signed-off-by: Ben Dooks Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91

[PATCH 3/4] ARM: at91/dt: sama5d3 xplained: add fixed regulator for vmmc0

2015-04-27 Thread Ludovic Desroches
this is to be used properly. Signed-off-by: Ben Dooks [use a fixed regulator instead of gpio one] Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm

[PATCH 2/4] ARM: at91/dt: sama5d3 xplained: add mmc0 vqmmc entry

2015-04-27 Thread Ludovic Desroches
From: Ben Dooks The SAM5D3 Xplained device tree is missing the vqmmc node which is tied to 3.3V on the board. Add this to avoid the kernel warning that there is no vqmmc node. atmel_mci f000.mmc: No vqmmc regulator found Signed-off-by: Ben Dooks Signed-off-by: Ludovic Desroches --- arch

[PATCH 4/4] ARM: at91/dt: sama5d4 xplained: add regulators for v(q)mmc1 supplies

2015-04-27 Thread Ludovic Desroches
Add vcc_mmc1 fixed regulator to remove the 'no vmmc regulator found' warning when probing the mmc1 device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d4_xplained.dts | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boo

[PATCH 4/4] ARM: at91/dt: sama5d4 xplained: add regulators for v(q)mmc1 supplies

2015-04-27 Thread Ludovic Desroches
Add vcc_mmc1 fixed regulator to remove the 'no vmmc regulator found' warning when probing the mmc1 device. Signed-off-by: Ludovic Desroches --- Remove the additionnal blank line. arch/arm/boot/dts/at91-sama5d4_xplained.dts | 20 1 file changed, 20 insertion

[PATCH] ARM: at91: dt: sama5d4ek: mci0 uses slot 0

2015-05-28 Thread Ludovic Desroches
mci0 uses slot 0 not 1. Signed-off-by: Ludovic Desroches Fixes: 7a4752677c44 ("ARM: at91: dt: add device tree file for SAMA5D4ek board") --- arch/arm/boot/dts/at91-sama5d4ek.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5d4ek.d

Re: [PATCH 1/1] i2c: at91: fix code checker warnings

2015-06-11 Thread Ludovic Desroches
On Thu, Jun 11, 2015 at 11:16:32AM +0200, Cyrille Pitchen wrote: > buf_len is a size_t, so unsigned but was tested with '<= 0'. > > Signed-off-by: Cyrille Pitchen Acked-by: Ludovic Desroches Thanks > --- > drivers/i2c/busses/i2c-at91.c | 6 +++--- > 1 f

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-17 Thread Ludovic Desroches
Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: > On 06/10/2015 09:04 AM, Ludovic Desroches wrote: > >When having a controller which allows per pin muxing, declaring with > >which groups a function can be used is a useless constraint since groups &

Re: [RESEND PATCH 2/2] pinctrl: introduce complex pin description

2015-06-17 Thread Ludovic Desroches
On Mon, Jun 15, 2015 at 10:01:29AM -0600, Stephen Warren wrote: > On 06/10/2015 09:04 AM, Ludovic Desroches wrote: > >Using a string to describe a pin in the device tree can be not enough. > >Some controllers may need extra information to fully describe a pin. It > >concer

[PATCH] dmaengine: at_xdmac: fix bug about channel configuration

2015-06-17 Thread Ludovic Desroches
ff-by: Ludovic Desroches --- drivers/dma/at_xdmac.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index cf1213d..52ca1cc 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -359,18 +359,19 @@ static

[PATCH v2 0/3] Fixes for at_xdmac

2015-06-08 Thread Ludovic Desroches
Hi Vinod, I have updated patch 1 as you requested. About patch 2, I don't really find how to split it. I have applied it on 4.0.4 without any conflicts so backport will not be an issue. Changes from v1: - remove indentation fixes from patch for stable and put it in another one. Lu

[PATCH v2 1/3] dmaengine: at_xdmac: lock fixes

2015-06-08 Thread Ludovic Desroches
the DMA controller with irq disabled. _bh variant is not intended to be used in this case since it can enable irqs. Switch to irqsave/irqrestore variant to avoid this situation. Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org # 4.0 and later --- drivers/dma/at_xdmac.c | 75

[PATCH v2 2/3] dmaengine: at_xdmac: rework slave configuration part

2015-06-08 Thread Ludovic Desroches
Rework slave configuration part in order to more report wrong errors about the configuration. Only maxburst and addr width values are checked when doing the slave configuration. The validity of the channel configuration is done at prepare time. Signed-off-by: Ludovic Desroches Cc: sta

[PATCH v2 3/3] dmaengine: at_xdmac: fix indentation

2015-06-08 Thread Ludovic Desroches
Fix indentation. Signed-off-by: Ludovic Desroches --- drivers/dma/at_xdmac.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index e5dd730..7614c5c 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c

[PATCH] ARM: at91/dt: sama5d4: fix dma conf for aes, sha and tdes nodes

2015-06-08 Thread Ludovic Desroches
The xdmac channel configuration is done in one cell not two. This error prevents from probing devices correctly. Signed-off-by: Ludovic Desroches Fixes: 83906783b766 ("ARM: at91/dt: sama5d4: add aes, sha and tdes nodes") Cc: sta...@vger.kernel.org # 4.1 --- arch/arm/boot/dts/sama5d4

[PATCH] pinctrl: don't try to print function groups if we can't get them

2015-06-08 Thread Ludovic Desroches
There is no reason to try to print groups associated to a function if get_function_groups returns an error. Moreover, it can lead to a NULL pointer dereference error. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinmux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 0/6] i2c: at91: add support to FIFOs and alternative command

2015-06-02 Thread Ludovic Desroches
Hi Cyrille, For the whole serie: Acked-by: Ludovic Desroches If you send a new version, could you add stable in Cc to patch 3/6: Cc: sta...@vger.kernel.org #3.10 and later If not, Wolfram could you do it please? Thanks Ludovic On Tue, Jun 02, 2015 at 03:18:30PM +0200, Cyrille Pitchen wrote

Re: [PATCH v3 0/6] i2c: at91: add support to FIFOs and alternative command

2015-06-02 Thread Ludovic Desroches
On Wed, Jun 03, 2015 at 12:36:28AM +0900, Wolfram Sang wrote: > > > If you send a new version, could you add stable in Cc to patch 3/6: > > No need to send a new version just because of an additional ack. I can > apply that. However... > > > Cc: sta...@vger.kernel.org #3.10 and later > > If not,

Re: [PATCH v2] dmaengine: at_xdmac: rework slave configuration part

2015-06-03 Thread Ludovic Desroches
On Tue, Jun 02, 2015 at 06:52:08PM +0530, Vinod Koul wrote: > On Mon, Jun 01, 2015 at 05:40:48PM +0200, Ludovic Desroches wrote: > > @@ -604,16 +636,18 @@ at_xdmac_prep_slave_sg(struct dma_chan *chan, struct > > scatterlist *sgl, > >

[PATCH 1/2] dmaengine: at_xdmac: lock fixes

2015-06-03 Thread Ludovic Desroches
the DMA controller with irq disabled. _bh variant is not intended to be used in this case since it can enable irqs. Switch to irqsave/irqrestore variant to avoid this situation. Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org # 4.0 and later --- drivers/dma/at_xdmac.c | 85

[PATCH 2/2] dmaengine: at_xdmac: rework slave configuration part

2015-06-03 Thread Ludovic Desroches
Rework slave configuration part in order to more report wrong errors about the configuration. Only maxburst and addr width values are checked when doing the slave configuration. The validity of the channel configuration is done at prepare time. Signed-off-by: Ludovic Desroches Cc: sta

Re: [PATCH v5 0/6] i2c: at91: add support to FIFOs and alternative command

2015-06-03 Thread Ludovic Desroches
For the whole set of patches: Acked-by: Ludovic Desroches Thanks Cyrille On Wed, Jun 03, 2015 at 06:25:16PM +0200, Cyrille Pitchen wrote: > ChangeLog > > v5: > - print I2C controller version in an already existing dev_info() instead of > adding a new one. > > v4: > -

Re: [PATCH 1/2] dmaengine: at_xdmac: lock fixes

2015-06-04 Thread Ludovic Desroches
On Thu, Jun 04, 2015 at 07:49:38PM +0530, Vinod Koul wrote: > On Wed, Jun 03, 2015 at 04:52:26PM +0200, Ludovic Desroches wrote: > > Using _bh variant for spin locks causes this kind of warning: > > Starting logging: [ cut here ] > > WARNING: CPU: 0

Re: [PATCH 1/2] dmaengine: Move icg helpers to global header

2015-06-01 Thread Ludovic Desroches
d-off-by: Maxime Ripard Acked-by: Ludovic Desroches > --- > drivers/dma/at_xdmac.c| 46 -- > include/linux/dmaengine.h | 27 +++ > 2 files changed, 31 insertions(+), 42 deletions(-) > > diff --git a

Re: [PATCH 2/2] dmaengine: hdmac: Implement interleaved transfers

2015-06-01 Thread Ludovic Desroches
will only reject transfers that do not conform to this. > > Signed-off-by: Maxime Ripard One comment below, otherwise Acked-by: Ludovic Desroches > --- > drivers/dma/at_hdmac.c | 106 > > drivers/dma/at_hdmac_regs.h | 5 +++

Re: [PATCH 1/3] i2c: at91: add support for new alternative command mode

2015-06-01 Thread Ludovic Desroches
Hi Cyrille, Some remarks, questions below. On Fri, May 29, 2015 at 03:50:08PM +0200, Cyrille Pitchen wrote: > The alternative command mode was introduced to simplify the transmission of > STOP conditions and to solve timing and latency issues around them. > > This mode relies on a new register,

Re: [PATCH 2/3] i2c: at91: print hardware version

2015-06-01 Thread Ludovic Desroches
On Fri, May 29, 2015 at 03:50:09PM +0200, Cyrille Pitchen wrote: > The probe() function now prints the hardware version of the I2C controller > > Signed-off-by: Cyrille Pitchen Acked-by: Ludovic Desroches > --- > drivers/i2c/busses/i2c-at91.c | 4 > 1 file cha

Re: [PATCH 3/3] i2c: at91: add support to FIFOs

2015-06-01 Thread Ludovic Desroches
Hi Cyrille, Some comments otherwise Acked-by: Ludovic Desroches On Fri, May 29, 2015 at 03:50:10PM +0200, Cyrille Pitchen wrote: > When FIFOs are available and enabled, the driver now configures the Atmel > eXtended DMA Controller to perform word accesses instead of byte accesses

[PATCH v2] dmaengine: at_xdmac: rework slave configuration part

2015-06-01 Thread Ludovic Desroches
Rework slave configuration part in order to no more report wrong errors about the configuration. Only maxburst and addr width values are checked when doing the slave configuration. The validity of the channel configuration is done at prepare time. Signed-off-by: Ludovic Desroches Cc: sta

Re: [PATCH v2 0/5] i2c: at91: add support to FIFOs and alternative command

2015-06-02 Thread Ludovic Desroches
Hi Cyrille, Could you split the patch about the new alternative command mode? Reading some comments in your code, you also fixes bad management of the interrupt flags. It would be great if we can send this as fixes for previous kernels. Thanks Ludovic On Mon, Jun 01, 2015 at 05:49:10PM +0200,

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Ludovic Desroches
On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote: > Hello. > > On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: > > >The probe() function now prints the hardware version of the I2C > >controller. > > >Signed-off-by: Cyrille Pitchen > >--- > > drivers/i2c/busses/i2c-at91.c | 5

Re: [PATCH 0/2] get pinctrl more flexible for per pin muxing controllers

2015-06-10 Thread Ludovic Desroches
On Wed, Jun 10, 2015 at 08:14:50AM -0600, Stephen Warren wrote: > On 06/10/2015 01:33 AM, Linus Walleij wrote: > >On Wed, Jun 3, 2015 at 3:31 PM, Nicolas Ferre > >wrote: > >>Le 04/05/2015 10:56, Ludovic Desroches a écrit : > >>> > >>>Th

[RESEND PATCH 0/2] get pinctrl more flexible for per pin muxing controllers

2015-06-10 Thread Ludovic Desroches
otype of a pin controller and device tree to show the way I want to use these changes. I couldn't test it on boards using generic pinconf so I am not sure that I don't break something... Ludovic Desroches (4): pinctrl: change function behavior for per pin muxing controllers pinctrl: in

[RESEND PROTO] pinctrl: rough draft for a future controller

2015-06-10 Thread Ludovic Desroches
gt;pins = devm_kzalloc(&pdev->dev, sizeof(*group->pins) * group->npins, GFP_KERNEL); + //if (!group->pins) TODO + for (i = 0; i < group->npins; i++) { + ret = of_property_read_u32_index(group_np, "pins", i, &

[RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-10 Thread Ludovic Desroches
When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinmux.c | 58 +++--- include/linux

[RESEND PATCH 2/2] pinctrl: introduce complex pin description

2015-06-10 Thread Ludovic Desroches
me, a 32 bit value is used. The 16 least significant bits are used for the pin number. Other 16 bits can be used to store extra parameters. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinconf-generic.c | 44 ++- include/linux/pinctrl/pinctrl.h

[RESEND PROTO] ARM: at91/dt: proto dt

2015-06-10 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches Conflicts: arch/arm/boot/dts/Makefile --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/at91-sama5d4ek_proto.dts | 243 ++ arch/arm/boot/dts/sama5d4_proto-pinfunc.h | 463 +++ arch/arm/boot/dts

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-18 Thread Ludovic Desroches
On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: > On 06/17/2015 06:38 AM, Ludovic Desroches wrote: > >Hi Stephen, > > > >On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: > >>On 06/10/2015 09:04 AM, Ludovic Desroches wrote: > >>

Re: [PATCH v7 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels

2018-05-22 Thread Ludovic Desroches
f this patch are based on initial original work by > Mohamed Jamsheeth Hajanajubudeen and Bandaru Venkateswara Swamy > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v6: > - fixed a crash when issuing buffer enable from sysfs, if no trigger was > pre

Re: [PATCH v7 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific consumer info

2018-05-22 Thread Ludovic Desroches
On Tue, May 22, 2018 at 10:52:37AM +0300, Eugen Hristev wrote: > Added defines for channel consumer device-tree binding > > Signed-off-by: Eugen Hristev > Reviewed-by: Rob Herring Acked-by: Ludovic Desroches > --- > .../devicetree/bindings/iio/adc/at91-sama5d

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-24 Thread Ludovic Desroches
. > } > ... when != child > // > > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches Thanks > > --- > drivers/pinctrl/pinctrl-at91-pio4.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.

Re: [PATCH] dmaengine: at_xdmac: fix rare residue corruption

2018-03-01 Thread Ludovic Desroches
Hi Maxime, On Thu, Feb 22, 2018 at 12:39:55PM +0100, Maxime Jayat wrote: > Despite the efforts made to correctly read the NDA and CUBC registers, > the order in which the registers are read could sometimes lead to an > inconsistent state. > > Re-using the timeline from the comments, this followin

Re: [PATCH] i2c: at91: Read all available bytes at once

2018-04-25 Thread Ludovic Desroches
Hi David, On Wed, Apr 18, 2018 at 02:40:55PM +0200, David Engraf wrote: > With FIFO enabled it is possible to read multiple bytes > at once in the interrupt handler as long as RXRDY is > set. This may also reduce the number of interrupts. > > Signed-off-by: David Engraf > --- > drivers/i2c/buss

Re: [PATCH] i2c: at91: Read all available bytes at once

2018-04-26 Thread Ludovic Desroches
Hi David, On Wed, Apr 25, 2018 at 05:43:09PM +0200, David Engraf wrote: > Hi Ludovic, > > Am 25.04.2018 um 17:08 schrieb Ludovic Desroches: > > Hi David, > > > > On Wed, Apr 18, 2018 at 02:40:55PM +0200, David Engraf wrote: > > > With FIFO enabled it is poss

Re: [PATCH v2] i2c: at91: Read all available bytes at once

2018-04-26 Thread Ludovic Desroches
bytes at > once. > > Signed-off-by: David Engraf Acked-by: Ludovic Desroches Thanks a lot David. Regards Ludovic > --- > drivers/i2c/busses/i2c-at91.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-at91.c

Re: [PATCH 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-02-05 Thread Ludovic Desroches
d > just finish the tasklet call. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index fe6

Re: [PATCH 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-02-05 Thread Ludovic Desroches
On Tue, Feb 05, 2019 at 12:03:42PM +0100, Nicolas Ferre wrote: > Complement the identification of errors with stoping the channel and > dumping the descriptor that led to the error case. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > drivers/d

Re: [PATCH 3/3] dmaengine: at_xdmac: only monitor overflow errors for peripheral xfer

2019-02-05 Thread Ludovic Desroches
> request signal. > > Remove the use of this interrupt source in such a case. It's based on > the first descriptor which holds the configuration for the whole > linked list transfer. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > drivers/dm

Re: [PATCH v2 1/7] pinctrl: at91: add option to use drive strength bits

2019-02-06 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 05:18:04PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > SAM9X60 uses high and low drive strengths. To implement this, in > at91_pinctrl_mux_ops::set_drivestrength and > at91_pinctrl_mux_ops::get_drivestrength we need bit numbers of > drive strengths (1

Re: [PATCH v2 0/7] add support for SAM9X60 pin controller

2019-02-06 Thread Ludovic Desroches
On Thu, Jan 31, 2019 at 05:18:00PM +0100, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea Minor comment for patch 1. Acked-by: Ludovic Desroches for the whole series. > > This series adds drive strenght and slew rate support for SAMX60's pin > controller. For drive

Re: [PATCH v2 1/7] pinctrl: at91: add option to use drive strength bits

2019-02-06 Thread Ludovic Desroches
On Wed, Feb 06, 2019 at 09:46:28AM +, claudiu.bez...@microchip.com wrote: > > > On 06.02.2019 10:13, Ludovic Desroches wrote: > > On Thu, Jan 31, 2019 at 05:18:04PM +0100, Claudiu Beznea - M18063 wrote: > >> From: Claudiu Beznea > >> > >> SAM

Re: [PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-04-08 Thread Ludovic Desroches
On Thu, Mar 28, 2019 at 04:33:07PM +0100, Nicolas Ferre wrote: > SAMA5 devices use the newer DRM driver for LCD. They don't need > the older FB driver: remove the Kconfig option for them. > > Signed-off-by: Nicolas Ferre Applied to at91-defconfig. Thanks. > --- > arch/arm/mach-at91/Kconfig |

Re: [PATCH v2 1/4] ARM: dts: sama5d{2,4}: use SPDX-License-Identifier

2019-04-08 Thread Ludovic Desroches
@ -1,46 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > /* > * sama5d2.dtsi - Device Tree Include file for SAMA5D2 family SoC > * > * Copyright (C) 2015 Atmel, > *2015 Ludovic Desroches > - * > - * This file is dual-licensed: you can use it eit

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
g pincontrol > configuration. The patch was tested on SAM9x60EK, SAMA5D4-EK and SAMA5D3-EK. > No problem on my side with this set of patches, it's consistent with what we have. Acked-by: Ludovic Desroches I just want to share the full picture leading to this situation. You told me the brea

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
On Wed, Nov 18, 2020 at 04:26:52PM +0100, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello, > > On 18/11/2020 16:03:36+0100, Ludovic Desroches wrote: > > At first glance, there is no trivial

Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank

2020-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2020 at 09:31:36AM +0100, Linus Walleij wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Nov 13, 2020 at 2:25 PM Eugen Hristev > wrote: > > > Some products, like sama7g5, do not have a full last bank of PIO lines.

Re: [PATCH] mmc: Assign boolean values to a bool variable

2021-01-21 Thread Ludovic Desroches
0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 46 > ++-- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --

Re: [PATCH 1/3] dt-bindings: pinctrl: at91-pio4: add slew-rate

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:12PM +0200, Claudiu Beznea wrote: > Document slew-rate DT binding for SAMA7G5. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > --- > .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 8 > +--- &g

Re: [PATCH 2/3] pinctrl: at91-pio4: add support for slew-rate

2021-01-27 Thread Ludovic Desroches
banks; > unsigned last_bank_count; > + unsigned int sr; Hi Claudiu, Nitpicking: I tend to prefer a verbose name as slew_rate or even slew_rate_support. Otherwise, Acked-by: Ludovic Desroches Regards Ludovic > }; > > struct atmel_group { > @@ -117,6 +120,7 @@ s

Re: [PATCH 3/3] pinctrl: at91-pio4: fix "Prefer 'unsigned int' to bare use of 'unsigned'"

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:14PM +0200, Claudiu Beznea wrote: > Fix "Prefer 'unsigned int' to bare use of 'unsigned'" checkpatch.pl > warning. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > ---

Re: [PATCH v2] dt: platform driver: Fill the resources before probe and defer if needed

2014-02-27 Thread Ludovic Desroches
l fail to probe because the ressources don't exist > at this time. > > This patch fills the resource structure only before the device is probed and > will defer the probe if the resource are not available yet. > > Signed-off-by: Jean-Jacques Hiblot > Reviewed-by: Gregory CLE

Re: [PATCH 04/17] i2c: i2c-at91: deprecate class based instantiation

2014-02-11 Thread Ludovic Desroches
On Mon, Feb 10, 2014 at 11:03:58AM +0100, Wolfram Sang wrote: > Warn users that class based instantiation is going away soon in favour > of more robust probing and faster bootup times. > > Signed-off-by: Wolfram Sang > Cc: Ludovic Desroches Acked-by: Ludovic Des

Re: [PATCH] at91: dt: i2c: add a new compatibility string for the at91sam9261

2014-01-15 Thread Ludovic Desroches
On Wed, Jan 15, 2014 at 11:24:27AM +0100, Jean-Jacques Hiblot wrote: > Signed-off-by: Jean-Jacques Hiblot Acked-by: Ludovic Desroches Thanks > --- > drivers/i2c/busses/i2c-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-at91.c b/

possible regression on 3.13 when calling flush_dcache_page

2013-12-12 Thread Ludovic Desroches
Hi, With v3.13-rc3 I have an error when the atmel-mci driver calls flush_dcache_page (log at the end of the message). Since I didn't have it before, I did a git bisect and the commit introducing the error is the following one: 106a74e slab: replace free and inuse in struct slab with newly introd

Re: possible regression on 3.13 when calling flush_dcache_page

2013-12-12 Thread Ludovic Desroches
fix mmc mailing list address error On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > Hi, > > With v3.13-rc3 I have an error when the atmel-mci driver calls > flush_dcache_page (log at the end of the message). > > Since I didn't have it before, I d

Re: possible regression on 3.13 when calling flush_dcache_page

2013-12-16 Thread Ludovic Desroches
On Thu, Dec 12, 2013 at 05:13:22PM +, Russell King - ARM Linux wrote: > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > I'll investigate on atmel-mci driver side but if someone has also this > > issue or see what is wrong in the driver, please

Re: possible regression on 3.13 when calling flush_dcache_page

2013-12-16 Thread Ludovic Desroches
Hello, On Fri, Dec 13, 2013 at 10:59:09AM +0900, Joonsoo Kim wrote: > On Thu, Dec 12, 2013 at 03:36:19PM +0100, Ludovic Desroches wrote: > > fix mmc mailing list address error > > > > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > > Hi, >

Re: [PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-22 Thread Ludovic Desroches
> lables and remove function. > > Cc: Ludovic Desroches > Cc: Chris Ball > Cc: Ulf Hansson > Cc: linux-...@vger.kernel.org > Signed-off-by: Pramod Gurav > --- > drivers/mmc/host/atmel-mci.c | 57 > > 1 fi

Re: [PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-23 Thread Ludovic Desroches
/resorces/resources > lables and remove function. /s/lables/labels Otherwise Acked-by: Ludovic Desroches Thanks > > Cc: Ludovic Desroches > Cc: Chris Ball > Cc: Ulf Hansson > Cc: linux-...@vger.kernel.org > Signed-off-by: Pramod Gurav > > --- > Changes since v1

Re: [PATCH v2 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-23 Thread Ludovic Desroches
On Tue, Sep 23, 2014 at 03:50:06PM +0530, Pramod Gurav wrote: > This change takes care of releasing mmc resources on error cases in > probe function which was missing. Also release timer in remove function. > Acked-by: Ludovic Desroches > Cc: Ludovic Desroches > Cc: Chris

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

2014-09-29 Thread Ludovic Desroches
gt; > Gcc correctly warns about this function getting dropped in the link stage > for the built-in case, which would cause undefined behavior when this error > path is hit. The solution is to simply drop the __exit annotation. > > Signed-off-by: Arnd Bergmann Acked-by: Ludovic

Re: [PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time

2014-07-17 Thread Ludovic Desroches
the removal. Keep > the > DEPRECATED flag, so the core can inform users that the behaviour finally > changed now. After another transition period, this flag can go, too. > > Signed-off-by: Wolfram Sang Acked-by: Ludovic Desroches Thanks > --- > drivers/i2c/busses/i2c-a

<    1   2   3   4   5   6   7   >