Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-27 Thread Loïc Pefferkorn
Hello Greg, After some investigation, I think that removing these wrappers is not going to improve the code readability: On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote: > On Wed, Nov 26, 2014 at 05:15:48PM +0100, Loic Pefferkorn wrote: > > Add __acquires() and __releases() function anno

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-30 Thread Loïc Pefferkorn
On Fri, Nov 28, 2014 at 02:22:07PM -0800, Greg KH wrote: > > That's even worse than I imagined. Putting sparse markings on these > function calls is just papering over nonsense. Please work on unwinding > the mess so that you don't need callbacks for locks, that is an > abstraction that isn't ne

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-26 Thread Loïc Pefferkorn
On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote: > > Ugh, how horrid, please just delete these functions and push down the > spin_lock/unlock calls down into the places these are called. > > Same for these. > > Same thing here. Hello Greg, Thanks for your comments, I will write a v2. -