[PATCH] x86: ioapic needs check attr when programmed more than once

2013-08-22 Thread Liu Ping Fan
When programming ioapic pinX more than once, current code does not check whether the later attr (trigger&polarity) is the same as the former or not. This causes a broken semantic. Fix it by reporting -EBUSY, when attr is different. Signed-off-by: Liu Ping Fan --- arch/x86/kernel/acpi/bo

Re: [PATCH] x86: ioapic needs check attr when programmed more than once

2013-08-23 Thread Liu ping fan
On Fri, Aug 23, 2013 at 3:30 PM, Ingo Molnar wrote: > > * Liu Ping Fan wrote: > >> When programming ioapic pinX more than once, current code >> does not check whether the later attr (trigger&polarity) is the >> same as the former or not. This causes a broken sema

Re: [PATCH] x86: ioapic needs check attr when programmed more than once

2013-08-23 Thread Liu ping fan
On Fri, Aug 23, 2013 at 4:04 PM, Liu ping fan wrote: > On Fri, Aug 23, 2013 at 3:30 PM, Ingo Molnar wrote: >> >> * Liu Ping Fan wrote: >> >>> When programming ioapic pinX more than once, current code >>> does not check whether the later attr (trigger&

[PATCH] x86: ioapic needs check attr when programmed more than once

2013-08-23 Thread Liu Ping Fan
SY to the caller, when attr is different. Signed-off-by: Liu Ping Fan --- arch/x86/kernel/acpi/boot.c| 5 - arch/x86/kernel/apic/io_apic.c | 7 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 230c8ea

pci: question about the life cycle of pci_dev and its parent pci_bus

2012-08-22 Thread Liu ping fan
Hi, I have a question about the life cycle of pci_dev and its parent pci_bus. In pci_destroy_dev(), we remove the pci_dev from the bus_list, so pci_dev is isolated from its parent pci_bus, and their life cycle are independent too. But it seems that in pci_dev, we can still access the pci_bus from

Re: pci: question about the life cycle of pci_dev and its parent pci_bus

2012-08-26 Thread Liu ping fan
arching such codes. Regards, pingfan > Regards! > Gerry > > On 08/23/2012 01:24 PM, Liu ping fan wrote: >> Hi, >> >> I have a question about the life cycle of pci_dev and its parent pci_bus. >> In pci_destroy_dev(), we remove the pci_dev from t

[PATCH] rcu: fix incorrect notes for code

2014-02-23 Thread Liu Ping Fan
-/* Is the specified CPU a no-CPUs CPU? */ +/* Is the specified CPU a no-CBs CPU? */ bool rcu_is_nocb_cpu(int cpu) Signed-off-by: Liu Ping Fan --- kernel/rcu/tree_plugin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h

[tip:x86/apic] x86/ioapic: Check attr against the previous setting when programmed more than once

2013-08-26 Thread tip-bot for Liu Ping Fan
Commit-ID: 25aa2957973d361081ac6c8b6e5a0d9d7a83fef6 Gitweb: http://git.kernel.org/tip/25aa2957973d361081ac6c8b6e5a0d9d7a83fef6 Author: Liu Ping Fan AuthorDate: Fri, 23 Aug 2013 16:58:47 +0800 Committer: Ingo Molnar CommitDate: Mon, 26 Aug 2013 12:58:00 +0200 x86/ioapic: Check attr